a.sidorin updated this revision to Diff 32664.
a.sidorin marked an inline comment as done.
a.sidorin added a comment.
Remove duplicating assertion.
http://reviews.llvm.org/D5102
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h
alexfh added a comment.
Thanks for the explanation.
FTR, this check on line 190 fails with -fdelayed-template-parsing:
// CHECK-FIXES: {{^}}GlobalFunction(1, 2);{{$}}
Users:
chapuni (Author)
http://reviews.llvm.org/rL245435
___
On Thu, Aug 20, 2015 at 1:01 PM, Alexander Kornienko via cfe-commits
cfe-commits@lists.llvm.org wrote:
alexfh added a comment.
Thanks for the explanation.
FTR, this check on line 190 fails with -fdelayed-template-parsing:
// CHECK-FIXES: {{^}}GlobalFunction(1, 2);{{$}}
FWIW, I think
chapuni accepted this revision.
chapuni added a comment.
This revision is now accepted and ready to land.
Ready to commit regardless of one REQUIRES.
Testing Time: 4.73s
Expected Passes: 72
Note, llvm-include-order.cpp will XFAIL for targeting msvc.
Comment at:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
The latest patch works for me when testing on Windows with MSVC. LGTM, and
thank you!
http://reviews.llvm.org/D12180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
angelgarcia created this revision.
angelgarcia added a reviewer: alexfh.
angelgarcia added a subscriber: cfe-commits.
angelgarcia changed the visibility of this Differential Revision from Public
(No Login Required) to All Users.
Remove implicit conversion from nullptr to StringRef.
MaggieYi updated this revision to Diff 32671.
MaggieYi added a comment.
Hi Anna,
Many thanks for your comments. I have modified the patch to address your
comments. Please let me know what you think.
PS: If the updated patch looks good to you, could you please commit it for me
(as I do not
I'll update patch, Michael
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
20.08.2015 18:40, Michael Wong пишет:
fraggamuffin added a comment.
Comment at: lib/Parse/ParseDeclCXX.cpp:3011
@@ -3010,3 +3010,3 @@
if
ABataev updated this revision to Diff 32790.
ABataev added a comment.
Update after review from Kelvin
http://reviews.llvm.org/D12152
Files:
docs/UsersManual.rst
Index: docs/UsersManual.rst
===
--- docs/UsersManual.rst
+++
filcab added a comment.
It seems you missed some `\brief`. Other than that, no complaints on this side.
Comment at: lib/CodeGen/CGExpr.cpp:2303
@@ -2302,4 +2302,3 @@
- if (TrapCond)
-EmitTrapCheck(TrapCond);
+ if (TrapCond) EmitSanitizeTrapCheck(TrapCond);
if
On Thu, Aug 20, 2015 at 2:13 PM, Hans Wennborg h...@chromium.org wrote:
+Saleem and Renato; maybe you can take a look?
Thanks for pointing this out!
The patch is correct and pretty safe to apply for 3.7 I think since its a
simple bug fix, and can result in VFP state corruption (the invalid
bkramer added a comment.
In http://reviews.llvm.org/D12186#228702, @angelgarcia wrote:
It is allowed as long as you specify that the length is 0.
I meant the code before your change, which calls `StringRef(const char *Str)`
and completely disallows nullptr. In other words: this change is
Thanks, Benjamin!
On Thu, Aug 20, 2015 at 11:47 AM, Benjamin Kramer via cfe-commits
cfe-commits@lists.llvm.org wrote:
Author: d0k
Date: Thu Aug 20 04:47:06 2015
New Revision: 245548
URL: http://llvm.org/viewvc/llvm-project?rev=245548view=rev
Log:
[clang-tidy] Fold the meat of the
edward-jones created this revision.
edward-jones added a subscriber: cfe-commits.
AAP is a Harvard architecture, with features representative of a large range of
deeply embedded microprocessors. It aims to aid the development and maintenance
of other out-of-tree deeply embedded systems.
angelgarcia added a comment.
It is allowed as long as you specify that the length is 0.
assert
https://cs.corp.google.com/#piper///depot/google3/third_party/grte/v4_x86/release/usr/grte/v4/include/assert.hl=85ct=xref_jump_to_defcl=GROKgsn=assert((data
bkramer added a subscriber: bkramer.
bkramer added a comment.
Is this tested? I'd expect a crash when constructing a StringRef implicitly
from nullptr.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:341
@@ -340,3 +340,3 @@
SourceMgr.getFileID(Range.getEnd()))
-
Author: abataev
Date: Thu Aug 20 07:15:57 2015
New Revision: 245556
URL: http://llvm.org/viewvc/llvm-project?rev=245556view=rev
Log:
[OPENMP 4.1] Allow to use 'uval' and 'ref' modifiers for reference types only.
Standard allows to use 'uval' and 'ref' modifiers in 'linear' clause for
variables
angelgarcia added a comment.
In http://reviews.llvm.org/D12186#228704, @bkramer wrote:
I meant the code before your change, which calls `StringRef(const char *Str)`
and completely disallows nullptr. In other words: this change is missing a
regression test.
You are right, the current tests
Author: abataev
Date: Thu Aug 20 05:54:39 2015
New Revision: 245550
URL: http://llvm.org/viewvc/llvm-project?rev=245550view=rev
Log:
[OPENMP 4.1] Initial support for modifiers in 'linear' clause.
OpenMP 4.1 adds 3 optional modifiers to 'linear' clause.
Format of 'linear' clause has changed to:
angelgarcia added a comment.
Oooops, copy pasting there was not a good idea. Sorry :(
http://reviews.llvm.org/D12186
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
samsonov added inline comments.
Comment at: lib/ubsan/ubsan_handlers.cc:57-58
@@ -57,2 +56,4 @@
+ if (!Pointer) {
+R.setErrorType(ErrorType::NullPointerUse);
Diag(Loc, DL_Error, %0 null pointer of type %1)
TypeCheckKinds[Data-TypeCheckKind] Data-Type;
Author: xazax
Date: Thu Aug 20 17:59:49 2015
New Revision: 245637
URL: http://llvm.org/viewvc/llvm-project?rev=245637view=rev
Log:
[Static Analyzer] Made it easier to test new checkers using the test suite.
Modified:
cfe/trunk/utils/analyzer/SATestBuild.py
Modified:
jmgao updated this revision to Diff 32769.
jmgao added a comment.
Doc fix, 80 col
http://reviews.llvm.org/D12181
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
george.burgess.iv added inline comments.
Comment at: lib/AST/ExprConstant.cpp:4763
@@ +4762,3 @@
+ /// arithmetic.
+ bool UseStrictCastingRules;
+
rsmith wrote:
This should be handled as an `EvaluationMode`.
Works for me.
Comment at:
jmgao updated this revision to Diff 32788.
jmgao marked 7 inline comments as done.
jmgao added a comment.
clang-format, remove \brief from modified doxygen comments.
http://reviews.llvm.org/D12181
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
filcab added a subscriber: filcab.
filcab added a comment.
Looks good, thanks for working on this.
I added some code style comments.
Comment at: lib/CodeGen/CGExpr.cpp:2399
@@ -2385,1 +2398,3 @@
+
+void CodeGenFunction::EmitTrapCheck(llvm::Value *Checked, const std::string
Author: rsmith
Date: Thu Aug 20 22:04:33 2015
New Revision: 245664
URL: http://llvm.org/viewvc/llvm-project?rev=245664view=rev
Log:
[modules] When we see a definition of a function for which we already have a
non-visible definition, skip the new definition to avoid ending up with a
function with
rsmith added a comment.
In http://reviews.llvm.org/D12181#229358, @rsmith wrote:
Can you please give a brief description of the motivation for this change?
When would it be appropriate to use this rather than `-ftrap-function`?
I'd still like an answer to this. It's not clear to me what the
samsonov added inline comments.
Comment at: lib/ubsan/ubsan_flags.inc:26
@@ +25,2 @@
+UBSAN_FLAG(bool, report_error_type, false,
+Print specific error type instead of 'undefined-behavior' in
summary.)
filcab wrote:
Do we care that much about keeping the
rsmith added inline comments.
Comment at: lib/ubsan/ubsan_handlers.cc:57-58
@@ -57,2 +56,4 @@
+ if (!Pointer) {
+R.setErrorType(ErrorType::NullPointerUse);
Diag(Loc, DL_Error, %0 null pointer of type %1)
TypeCheckKinds[Data-TypeCheckKind] Data-Type;
I feel very silly now.
After testing the testcase again on svn it still works.
It appears the OP was looking for this patch to go onto the 3.6 branch and
was applying my patch to that.
I'll know in future to recheck the testcase afterwards myself in future.
Apologies for the noise guys.
Yaron I
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
lgtm
http://reviews.llvm.org/D12164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
majnemer added a subscriber: majnemer.
majnemer added a comment.
What does it mean to have the attribute applied to non-pointer types like `int
__attribute__((nontemporal)) i;` ? The ACLE doesn't say but making it
erroneous might make sense. Perhaps it would be good to have a semantic test
On Thu, Aug 20, 2015 at 6:39 PM, Michael Zolotukhin via cfe-commits
cfe-commits@lists.llvm.org wrote:
mzolotukhin created this revision.
mzolotukhin added reviewers: hfinkel, doug.gregor, t.p.northover, ab,
mcrosier.
mzolotukhin added a subscriber: cfe-commits.
Herald added a subscriber:
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Core/CheckerManager.cpp:237
@@ +236,3 @@
+return PreObjCMessageCheckers;
+break;
+ case ObjCMessageVisitKind::Post:
nit: remove the break after the return.
Comment at:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245595: [Sparc] Add '-EL' when invoking gcc to link
little-endian binaries. (authored by dougk).
Changed prior to commit:
http://reviews.llvm.org/D12201?vs=32715id=32716#toc
Repository:
rL LLVM
Author: dougk
Date: Thu Aug 20 13:32:26 2015
New Revision: 245595
URL: http://llvm.org/viewvc/llvm-project?rev=245595view=rev
Log:
[Sparc] Add '-EL' when invoking gcc to link little-endian binaries.
Differential Revision: http://reviews.llvm.org/D12201
Modified:
EricWF added inline comments.
Comment at: docs/BuildingLibcxx.rst:56
@@ +55,3 @@
+Mac users, remember to be careful when replacing the system's libc++.
+**Your system will not be able to boot without a functioning libc++.**
+
jroelofs wrote:
Is there a way to
EricWF added a comment.
Gentle ping. There is going to be a couple of days lag time between committing
this and it showing up at libcxx.llvm.org/docs.
Once it is available at `libcxx.llvm.org/docs` we still have time to review it
before we link to it from the homepage.
For this reason, and
zoran.jovanovic created this revision.
zoran.jovanovic added reviewers: hfinkel, atrick, chandlerc.
zoran.jovanovic added subscribers: cfe-commits, yaron.keren, petarj,
Atlantic777, Radovan.Obradovic.
This patch adds command line option for iterative compilation, as well
as the code that invokes
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
Both styles look ok to me, with a slight preference toward matching clang's.
Comment at: docs/BuildingLibcxx.rst:56
@@ +55,3 @@
+Mac users, remember to be careful when
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245583: [clang-tidy] Use a python script instead of a shell
script to run clang-tidy… (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D12180?vs=32705id=32712#toc
Repository:
Author: alexfh
Date: Thu Aug 20 13:11:13 2015
New Revision: 245586
URL: http://llvm.org/viewvc/llvm-project?rev=245586view=rev
Log:
[clang-tidy] Use check_clang_tidy.py instead of check_clang_tidy.sh by default.
Modified:
clang-tools-extra/trunk/clang-tidy/add_new_check.py
Modified:
EricWF updated this revision to Diff 32718.
EricWF marked an inline comment as done.
EricWF updated the summary for this revision.
EricWF added a comment.
Address review comments.
http://reviews.llvm.org/D12129
Files:
CMakeLists.txt
cmake/Modules/HandleOutOfTreeLLVM.cmake
sunfish marked 2 inline comments as done.
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:364
@@ +363,3 @@
+ItaniumCXXABI(CGM, /* UseARMMethodPtrABI = */ true,
+ /* UseARMGuardVarABI = */ true) {}
+
jfb wrote:
It's more common to have no spaces
danalbert accepted this revision.
danalbert added a comment.
I think I prefer the haiku style, but I couldn't give you any concrete reasons
for that.
http://reviews.llvm.org/D12129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
dougk created this revision.
dougk added a reviewer: jyknight.
dougk added a subscriber: cfe-commits.
http://reviews.llvm.org/D12201
Files:
lib/Driver/Tools.cpp
test/Driver/biarch.c
Index: test/Driver/biarch.c
===
---
alexfh added inline comments.
Comment at: test/clang-tidy/google-readability-casting.c:7
@@ -6,3 +6,3 @@
// RUN: clang-tidy --checks=-*,google-readability-casting -header-filter='.*'
%t.main_file.cpp -- -I%S -DTEST_INCLUDE -x c++ | FileCheck %s
-check-prefix=CHECK-MESSAGES
aaron.ballman added a comment.
Yay! I'm really excited for this! Unfortunately, it fails all over the place on
Windows. The errors are all in the form:
58
58 FAIL: Clang Tools ::
clang-tidy/readability-simplify-bool-expr-chained-conditional-return.cpp (7280
of 23187)
58
chapuni added a comment.
Alex, thanks for your working. I tweaked to run on my hosts.
- mingw-w64 with Py3.3
- Linux with Py2.7 and Py3.4
My change is here;
https://github.com/chapuni/llvm-project/commit/0f4a303bdc7b925f42c0cd48817052d2b49b2234
Could you merge it, please?
bkramer accepted this revision.
bkramer added a reviewer: bkramer.
bkramer added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
http://reviews.llvm.org/D12186
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: compnerd
Date: Thu Aug 20 22:21:31 2015
New Revision: 245665
URL: http://llvm.org/viewvc/llvm-project?rev=245665view=rev
Log:
unwind: fix invalid memory access
Fix out-of-bounds array access when setting arm float registers.
Patch by Leandro Graciá Gil!
Modified:
Author: jyknight
Date: Thu Aug 20 23:14:55 2015
New Revision: 245667
URL: http://llvm.org/viewvc/llvm-project?rev=245667view=rev
Log:
Stop treating -static as overriding -fPIC: they are distinct.
For some reason, clang had been treating a command like:
clang -static -fPIC foo.c
as if it should
RKSimon added a comment.
Definitely like this idea - hopefully it'll make it safer to remove unnecessary
builtins.
Comment at: avx2-builtins-codegen.c:182
@@ -151,1 +181,3 @@
+ // FIXME-CHECK-ASM: vpxor %ymm{{.*}}
+ // FIXME-CHECK-ASM: vandps {{.*}}, %ymm{{.*}}
return
ismailp updated this revision to Diff 32745.
ismailp added a comment.
- Renamed `Out` parameter to `Stm`.
- Removed assertion that checks whether an ExplodedNode has an edge to itself.
- Added '-analyzer-viz-egraph-ubigraph' to an analyzer invocation in a test.
http://reviews.llvm.org/D12119
Merged in r245615.
Thanks,
Hans
On Thu, Aug 20, 2015 at 12:13 PM, Richard Smith rich...@metafoo.co.uk wrote:
LGTM for branch.
On Aug 20, 2015 9:47 AM, Hans Wennborg h...@chromium.org wrote:
It was requested that this be merged to 3.7.
Richard: OK for merging?
Thanks,
Hans
On Thu, Aug
On Tue, Aug 18, 2015 at 12:20 PM, Li, Charles via cfe-commits
cfe-commits@lists.llvm.org wrote:
Hi Justin and Richard,
+// RUN: %clang_cc1 -E -C -P -triple x86_64-apple-darwin10 %s %t1.c
+// RUN: %clang_cc1 -fsyntax-only -verify -triple
+x86_64-apple-darwin10 %t1.c
I think you forgot
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM with a couple of tweaks. Thanks!
Comment at: lib/AST/DeclBase.cpp:276
@@ +275,3 @@
+ return false;
+LDC = LDC-getParent();
+ }
rsmith added a comment.
Can you please give a brief description of the motivation for this change? When
would it be appropriate to use this rather than `-ftrap-function`?
Please also include an update for the Clang documentation to describe the new
flag.
http://reviews.llvm.org/D12181
On Wed, Aug 19, 2015 at 11:42 AM, Yaron Keren yaron.ke...@gmail.com wrote:
Yes, it looks like a legacy issue. Documentation says so:
*https://gcc.gnu.org/onlinedocs/gcc-4.8.2/gcc/i386-and-x86-64-Options.html
https://gcc.gnu.org/onlinedocs/gcc-4.8.2/gcc/i386-and-x86-64-Options.html*
+Saleem and Renato; maybe you can take a look?
On Tue, Aug 18, 2015 at 11:24 AM, Leandro Graciá Gil
cfe-commits@lists.llvm.org wrote:
Hi,
Please find attached a patch fixing an out-of-bounds array access present in
the current libunwind top of tree code.
The problem is caused by subtracting
Author: aaronballman
Date: Thu Aug 20 16:27:35 2015
New Revision: 245616
URL: http://llvm.org/viewvc/llvm-project?rev=245616view=rev
Log:
Do not crash when static analysis encounters a FunctionDecl that has a delayed
template parse of its body.
Added:
On Thu, Aug 20, 2015 at 5:18 PM, Richard Smith rich...@metafoo.co.uk wrote:
On Wed, Aug 19, 2015 at 2:52 PM, Aaron Ballman aa...@aaronballman.com
wrote:
On Wed, Aug 19, 2015 at 5:23 PM, Richard Smith rich...@metafoo.co.uk
wrote:
It looks like this would only happen for a late-parsed
EricWF added a comment.
Added more review comments for the boyer_moore searcher.
Comment at: include/experimental/functional:256
@@ +255,3 @@
+
+public: // TODO private:
+_RandomAccessIterator1 __first_;
Is this for testing?
jroelofs added inline comments.
Comment at: docs/BuildingLibcxx.rst:57
@@ +56,3 @@
+ select a safe place to install libc++.
+
+ * ``make install-libcxx install-libcxxabi`` --- Will install the libraries
and the headers
I feel like a warning is not enough...
silvas added inline comments.
Comment at: docs/BuildingLibcxx.rst:57
@@ +56,3 @@
+ select a safe place to install libc++.
+
+ * ``make install-libcxx install-libcxxabi`` --- Will install the libraries
and the headers
jroelofs wrote:
I feel like a warning is
jroelofs added a comment.
I like it!
http://reviews.llvm.org/D12209
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: chapuni
Date: Thu Aug 20 10:04:39 2015
New Revision: 245566
URL: http://llvm.org/viewvc/llvm-project?rev=245566view=rev
Log:
Tweak clang-tools-extra/test/clang-tidy/file-filter.cpp to pass on win32.
FIXME: -I %S/Inputs/file-filter/system/.. must be redundant.
On Win32,
Author: chapuni
Date: Thu Aug 20 10:04:32 2015
New Revision: 245565
URL: http://llvm.org/viewvc/llvm-project?rev=245565view=rev
Log:
clang-tools-extra/test/lit.cfg: Prune an obsolete feature, python27. Now we
requires python=2.7.
clang-tools-extra/test/clang-tidy/clang-tidy-diff.cpp was the
aaron.ballman updated this revision to Diff 32697.
aaron.ballman added a comment.
In http://reviews.llvm.org/D11784#228764, @alexfh wrote:
In http://reviews.llvm.org/D11784#227939, @aaron.ballman wrote:
Addressed review comments. I re-ran the updated patch against LLVM and
Clang, and
fraggamuffin added a comment.
Comment at: lib/Parse/ParseDeclCXX.cpp:3011
@@ -3010,3 +3010,3 @@
if (Tok.is(tok::annot_pragma_openmp)) {
-ParseOpenMPDeclarativeDirective();
continue;
While testing this patch with the latest trunk for my
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
With the triviality implementation, I now get zero false positives (and zero
true positives) in the Clang and LLVM source base.
Awesome! Thanks for working on this!
LGTM
On Thu, Aug 20, 2015 at 06:32:27PM -, Douglas Katzman via cfe-commits wrote:
Modified: cfe/trunk/test/Driver/biarch.c
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/biarch.c?rev=245595r1=245594r2=245595view=diff
Author: aaronballman
Date: Thu Aug 20 14:21:07 2015
New Revision: 245600
URL: http://llvm.org/viewvc/llvm-project?rev=245600view=rev
Log:
Change the test to use the new python script instead of the more verbose RUN
line.
Modified:
LGTM for branch.
On Aug 20, 2015 9:47 AM, Hans Wennborg h...@chromium.org wrote:
It was requested that this be merged to 3.7.
Richard: OK for merging?
Thanks,
Hans
On Thu, Aug 20, 2015 at 6:11 AM, Olivier Goffart via cfe-commits
cfe-commits@lists.llvm.org wrote:
Author: ogoffart
Author: ericwf
Date: Thu Aug 20 14:22:35 2015
New Revision: 245601
URL: http://llvm.org/viewvc/llvm-project?rev=245601view=rev
Log:
Remove completed items from TODO.TXT
Modified:
libcxx/trunk/TODO.TXT
Modified: libcxx/trunk/TODO.TXT
URL:
silvas added inline comments.
Comment at: docs/BuildingLibcxx.rst:57
@@ +56,3 @@
+ select a safe place to install libc++.
+
+ * ``make install-libcxx install-libcxxabi`` --- Will install the libraries
and the headers
silvas wrote:
jroelofs wrote:
I feel
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245605: [Headers][X86] Use __builtin_shufflevector in AVX2
broadcasts. (authored by ab).
Changed prior to commit:
http://reviews.llvm.org/D10556?vs=27973id=32729#toc
Repository:
rL LLVM
EricWF created this revision.
EricWF added reviewers: mclow.lists, beanz, jroelofs.
EricWF added a subscriber: cfe-commits.
On Mac OS X overwriting `/usr/lib/libc++.dylib` can cause your computer to fail
to boot. This patch tries to make it harder to do that accidentally.
If
Author: ab
Date: Thu Aug 20 15:27:21 2015
New Revision: 245605
URL: http://llvm.org/viewvc/llvm-project?rev=245605view=rev
Log:
[Headers][X86] Use __builtin_shufflevector in AVX2 broadcasts.
This lets us optimize them better. We agreed to remove the intrinsics,
instead of combining them later,
samsonov created this revision.
samsonov added reviewers: rsmith, pcc.
samsonov added a subscriber: cfe-commits.
http://reviews.llvm.org/D12215
Files:
lib/ubsan/ubsan_checks.inc
lib/ubsan/ubsan_diag.cc
lib/ubsan/ubsan_diag.h
lib/ubsan/ubsan_flags.inc
lib/ubsan/ubsan_handlers.cc
samsonov added a comment.
See https://llvm.org/bugs/show_bug.cgi?id=24443 (it's worth including this
reference to change description).
http://reviews.llvm.org/D12181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
On Thu, Aug 20, 2015 at 2:45 PM, Adrian Prantl via cfe-commits
cfe-commits@lists.llvm.org wrote:
aprantl added inline comments.
Comment at: include/clang/Frontend/CodeGenOptions.def:164-165
@@ -163,1 +163,4 @@
+CODEGENOPT(DebugTypeExtRefs, 1, 0) /// Whether or not debug
OK, so here's the problem:
The right way to fix this seems to be to delete the assignments to
LongDouble* from the MinGWX86_32TargetInfo constructor; the
X86_32TargetInfo and X86TargetInfo base classes already set them to the
right values. Likewise we can delete the assignments to LongDouble*
Author: yrnkrn
Date: Thu Aug 20 16:51:46 2015
New Revision: 245620
URL: http://llvm.org/viewvc/llvm-project?rev=245620view=rev
Log:
Revert the 64bit part of r245084; long double values were not changed by
it as they are already set correctly by X86_64TargetInfo and X86TargetInfo.
Modified:
Hans, it looked like you might have wanted PR24483 fixed for 3.7. If so,
this patch is safe for branch.
On Thu, Aug 20, 2015 at 1:45 PM, Richard Smith via cfe-commits
cfe-commits@lists.llvm.org wrote:
Author: rsmith
Date: Thu Aug 20 15:45:25 2015
New Revision: 245609
URL:
Author: yrnkrn
Date: Thu Aug 20 16:36:14 2015
New Revision: 245618
URL: http://llvm.org/viewvc/llvm-project?rev=245618view=rev
Log:
Revert the 32bit part of r245084; mingw values were correct before it.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
On Aug 19, 2015, at 2:15 PM, Richard Smith rich...@metafoo.co.uk wrote:
rsmith added a subscriber: rsmith.
Comment at: include/clang/Frontend/CodeGenOptions.def:164-165
@@ -163,1 +163,4 @@
+CODEGENOPT(DebugTypeExtRefs, 1, 0) /// Whether or not debug info should
aprantl added a comment.
Alright, let's hash it, then.
Repository:
rL LLVM
http://reviews.llvm.org/D11958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: eugenis
Date: Thu Aug 20 16:47:16 2015
New Revision: 245619
URL: http://llvm.org/viewvc/llvm-project?rev=245619view=rev
Log:
Revert r245344.
That change is causing strange test failures on Fedora 22 (PR24503),
and it does not have any effect with Gold linker anyway (PR15823,
jmgao marked 8 inline comments as done.
Comment at: tools/clang/lib/CodeGen/CGExpr.cpp:2388
@@ +2387,3 @@
+ }
+ return EmitTrapCheck(Checked);
+}
samsonov wrote:
This is confusing. So, you have the following behavior whenever you need to
emit a check for
Author: ayartsev
Date: Thu Aug 20 16:52:39 2015
New Revision: 245621
URL: http://llvm.org/viewvc/llvm-project?rev=245621view=rev
Log:
[analyzer] Fix for PR24112 (scan-build doesn't work with --use-analyzer=path
to clang++.exe).
Don't derive the path_to_clang++ from the path_to_clang if the
jmgao updated this revision to Diff 32755.
jmgao marked 2 inline comments as done.
jmgao added a comment.
Address comments
http://reviews.llvm.org/D12181
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CGExpr.cpp
Can't we just use the --driver-mode flag instead of trying to mangle the
executable name?
Peter
On Thu, Aug 20, 2015 at 09:52:39PM -, Anton Yartsev via cfe-commits wrote:
Author: ayartsev
Date: Thu Aug 20 16:52:39 2015
New Revision: 245621
URL:
I've reverted r245456 in r245623.
Thanks,
Hans
On Thu, Aug 20, 2015 at 2:56 PM, Richard Smith rich...@metafoo.co.uk wrote:
The cumulative effect of all the patches so far has been to revert this
change from trunk. Hans, can you revert it on the branch too?
Thanks.
On Wed, Aug 19, 2015 at
alexfh updated this revision to Diff 32705.
alexfh marked 4 inline comments as done.
alexfh added a comment.
Addressed review comments.
http://reviews.llvm.org/D12180
Files:
test/clang-tidy/arg-comments.cpp
test/clang-tidy/check_clang_tidy.py
96 matches
Mail list logo
