Re: r248293 - [CUDA] Add implicit __attribute__((used)) to all __global__ functions.

It seems like the real problem here is that we're giving the template instantiation the wrong linkage. It can be used from outside this llvm module, so it should be weak_odr instead of linkonce_odr. On Sep 22, 2015 10:24 AM, "Artem Belevich via cfe-commits" < cfe-commits@lists.llvm.org> wrote: >

[libcxx] r248313 - Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available.

Author: dim Date: Tue Sep 22 13:55:37 2015 New Revision: 248313 URL: http://llvm.org/viewvc/llvm-project?rev=248313=rev Log: Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available. Summary: In rL241532, atomic_support.h was added, which provides handling of atomic

Re: [PATCH] D12362: [clang-format] Add support of consecutive declarations alignment

berenm added a comment. Ping? The unit tests should work fine, now that http://reviews.llvm.org/D12369 has been merged. http://reviews.llvm.org/D12362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13051: Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available.

EricWF added a comment. @jroelofs @dim, could we fallback to the __sync_* builtins on arm? http://reviews.llvm.org/D13051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13051: Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available.

dim added a comment. In http://reviews.llvm.org/D13051#250836, @EricWF wrote: > Does anything actually need this? This interface was never really meant to be > complete, just want was needed. I need it at least for FreeBSD/arm, since it defaults to armv4, and it does not yet have a full set

[libcxx] r248309 - Remove possible trailing padding from aligned_storage. Patch from Yiran Wang

Author: ericwf Date: Tue Sep 22 13:37:03 2015 New Revision: 248309 URL: http://llvm.org/viewvc/llvm-project?rev=248309=rev Log: Remove possible trailing padding from aligned_storage. Patch from Yiran Wang Modified: libcxx/trunk/include/type_traits Modified: libcxx/trunk/include/type_traits

Re: [PATCH] D12482: Analyzer: Teach analyzer how to handle TypeTraitExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL248314: Analyzer: Teach analyzer how to handle TypeTraitExpr (authored by ismailp). Changed prior to commit: http://reviews.llvm.org/D12482?vs=35384=35403#toc Repository: rL LLVM

Re: [PATCH] D12417: Improvements to localizability checks for iOS / OS X

kulpreet added a subscriber: cfe-commits. kulpreet updated this revision to Diff 35404. kulpreet added a comment. Shortened description of PluralMisuseChecker in Checkers.td as per Anna's recommendation. http://reviews.llvm.org/D12417 Files: lib/StaticAnalyzer/Checkers/Checkers.td

Re: [PATCH] __attribute__((enable_if)) and non-overloaded member functions

Hello, > Looks good to me! > > Do you have commit access, or would you like for me to commit it for you? I do not have commit access. It would be great if you can commit for me. Thanks, Ettore Speziale ___ cfe-commits mailing list

Re: [PATCH] D10881: [Sema] Catch a case when 'volatile' qualifier is dropped while binding

rjmccall added a comment. This is outside of my expertise, but I've asked Doug Gregor to take a look. http://reviews.llvm.org/D10881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r244063 - Add missing atomic libcall support.

On 05 Aug 2015, at 18:57, James Y Knight wrote: > Author: jyknight > Date: Wed Aug 5 11:57:36 2015 > New Revision: 244063 > > URL: http://llvm.org/viewvc/llvm-project?rev=244063=rev > Log: > Add missing atomic libcall support. > > Support for emitting libcalls for

Re: [PATCH] D13051: Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available.

jroelofs added a comment. In http://reviews.llvm.org/D13051#250910, @EricWF wrote: > @jroelofs @dim, could we fallback to the __sync_* builtins on arm? @dim would need armv4-flavored implementations of them in compiler-rt (if that's what he's using)... the existing ones use instructions that

[PATCH] D13062: [libcxx] Fix PR24779 -- Prevent evaluation of std::is_default_constructible in clearly ill-formed tuple constructor.

EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. This patch fixes PR24779 (https://llvm.org/bugs/show_bug.cgi?id=24779) http://reviews.llvm.org/D13062 Files: include/tuple

Re: [PATCH] D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors

On Sep 11, 2015 4:23 AM, "Evgeny Astigeevich via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > > eastig added a comment. > > In http://reviews.llvm.org/D12689#243592, @rsmith wrote: > > > Can we instead fix this in Clang by ensuring that libc++ is put at the right position in the static link

Re: [PATCH] D13051: Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Ah sorry I hadn't had coffee yet. Sorry for the breakage. I'll make sure this make sure this patch gets backported appropriately. LGTM thanks for the fix. http://reviews.llvm.org/D13051

Re: [PATCH] D13051: Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available.

On Tue, Sep 22, 2015 at 07:26:46PM +, Jonathan Roelofs via cfe-commits wrote: > jroelofs added a comment. > > In http://reviews.llvm.org/D13051#250910, @EricWF wrote: > > > @jroelofs @dim, could we fallback to the __sync_* builtins on arm? > > > @dim would need armv4-flavored

Re: [PATCH] D5102: [analyzer][Bugfix/improvement] Fix for PR16833

dcoughlin added a comment. I will commit. Thanks! http://reviews.llvm.org/D5102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12453: [CUDA] Allow function overloads based on host/device attributes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL248295: [CUDA] Allow function overloads in CUDA based on host/device attributes. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D12453?vs=34368=35387#toc Repository: rL LLVM

Re: [PATCH] D12893: Augmented CudaHostAction to carry device-side triple.

This revision was automatically updated to reflect the committed changes. Closed by commit rL248298: Augmented CudaHostAction to carry device-side triple. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D12893?vs=34857=35388#toc Repository: rL LLVM

Re: [PATCH] D12892: [CUDA] Minor cuda-related driver fixes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL248297: [CUDA] Fixes minor cuda-related issues in the driver (authored by tra). Changed prior to commit: http://reviews.llvm.org/D12892?vs=34855=35386#toc Repository: rL LLVM

Re: [PATCH] D13051: Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available.

EricWF added a comment. Does anything actually need this? This interface was never really meant to be complete, just want was needed. > It's a shame that libc++ decided to reinvent the wheel here and not use the > C11 atomics support GCC doesn't provide "_Atomic" and `` isn't always fully

Re: [PATCH] D12917: [CUDA] Allow parsing of host and device code simultaneously.

This revision was automatically updated to reflect the committed changes. tra marked an inline comment as done. Closed by commit rL248299: [CUDA] Allow parsing of host and device code simultaneously. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D12917?vs=35031=35389#toc

r248293 - [CUDA] Add implicit __attribute__((used)) to all __global__ functions.

Author: tra Date: Tue Sep 22 12:22:51 2015 New Revision: 248293 URL: http://llvm.org/viewvc/llvm-project?rev=248293=rev Log: [CUDA] Add implicit __attribute__((used)) to all __global__ functions. This makes sure that we emit kernels that were instantiated from the host code and which would never

r248292 - [tooling] Provide the compile commands of the JSON database in the order that they were provided in the JSON file.

Author: akirtzidis Date: Tue Sep 22 12:22:33 2015 New Revision: 248292 URL: http://llvm.org/viewvc/llvm-project?rev=248292=rev Log: [tooling] Provide the compile commands of the JSON database in the order that they were provided in the JSON file. This is useful for debugging of issues and

[libcxx] r248305 - Check in the test for PR#24890 that I forgot in previous commit

Author: marshall Date: Tue Sep 22 12:57:41 2015 New Revision: 248305 URL: http://llvm.org/viewvc/llvm-project?rev=248305=rev Log: Check in the test for PR#24890 that I forgot in previous commit Modified: libcxx/trunk/test/std/utilities/utility/pairs/pairs.pair/swap.pass.cpp Modified:

Re: [PATCH] D11240: Add basic #include sorting functionality to clang-format

djasper updated this revision to Diff 35395. djasper added a comment. Added comments and did some renaming. http://reviews.llvm.org/D11240 Files: include/clang/Format/Format.h include/clang/Tooling/Core/Replacement.h lib/Format/Format.cpp lib/Format/FormatToken.cpp

Re: [PATCH] D5102: [analyzer][Bugfix/improvement] Fix for PR16833

ygribov added a subscriber: ygribov. ygribov added a comment. Folks, could someone commit this for us? http://reviews.llvm.org/D5102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r248307 - The test I cnecked in to check the fix for PR#24890 failed (as expected) w/o the fix, but for the wrong reason. Now it fails for the right reason.

Author: marshall Date: Tue Sep 22 13:09:13 2015 New Revision: 248307 URL: http://llvm.org/viewvc/llvm-project?rev=248307=rev Log: The test I cnecked in to check the fix for PR#24890 failed (as expected) w/o the fix, but for the wrong reason. Now it fails for the right reason. Modified:

Re: [PATCH] D11240: Add basic #include sorting functionality to clang-format

klimek added a comment. Sending another batch of comments. Comment at: lib/Tooling/Core/Replacement.cpp:305-307 @@ +304,5 @@ + Replacements Result; + // Iterate over both sets and always add the next element (smallest total + // Offset) from either 'First' or 'Second'. Merge

r248295 - [CUDA] Allow function overloads in CUDA based on host/device attributes.

Author: tra Date: Tue Sep 22 12:22:59 2015 New Revision: 248295 URL: http://llvm.org/viewvc/llvm-project?rev=248295=rev Log: [CUDA] Allow function overloads in CUDA based on host/device attributes. The patch makes it possible to parse CUDA files that contain host/device functions with identical

r248296 - [CUDA] Add appropriate host/device attribute to builtins.

Author: tra Date: Tue Sep 22 12:23:05 2015 New Revision: 248296 URL: http://llvm.org/viewvc/llvm-project?rev=248296=rev Log: [CUDA] Add appropriate host/device attribute to builtins. The changes are part of attribute-based CUDA function overloading (D12453) and as such are only enabled when it's

r248299 - [CUDA] Allow parsing of host and device code simultaneously.

Author: tra Date: Tue Sep 22 12:23:22 2015 New Revision: 248299 URL: http://llvm.org/viewvc/llvm-project?rev=248299=rev Log: [CUDA] Allow parsing of host and device code simultaneously. * adds -aux-triple option to specify target triple * propagates aux target info to AST context and

r248297 - [CUDA] Fixes minor cuda-related issues in the driver

Author: tra Date: Tue Sep 22 12:23:09 2015 New Revision: 248297 URL: http://llvm.org/viewvc/llvm-project?rev=248297=rev Log: [CUDA] Fixes minor cuda-related issues in the driver * Only the last of the --cuda-host-only/--cuda-device-only options has effect. * CudaHostAction always wraps host-side

Re: PATCH: Provide the compile commands of the JSON database in consistent order

In r248292, the added unit test fails without the changes. > On Sep 18, 2015, at 5:49 PM, Manuel Klimek via cfe-commits > wrote: > > LG in general; I think if we like the order to be deterministic we should try > to come up with a unit test so nobody regresses this

r248298 - Augmented CudaHostAction to carry device-side triple.

Author: tra Date: Tue Sep 22 12:23:13 2015 New Revision: 248298 URL: http://llvm.org/viewvc/llvm-project?rev=248298=rev Log: Augmented CudaHostAction to carry device-side triple. Differential Revision: http://reviews.llvm.org/D12893 Modified: cfe/trunk/include/clang/Driver/Action.h

Re: [PATCH] D11240: Add basic #include sorting functionality to clang-format

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. Ok, I think this is now understandable enough for me to go in. http://reviews.llvm.org/D11240 ___ cfe-commits mailing list

Re: [PATCH] D12793: Three new security overflow builtins with generic argument types

DavidEGrayson added a comment. Thanks for looking at this patch, John! I disagreed with your comment about calculating the encompassing type, but I will incorporate everything else and make a new patch tonight or within a few days. Comment at:

Re: [PATCH] D13052: Add NamingStyle option to modernize-loop-convert.

angelgarcia updated this revision to Diff 35380. angelgarcia marked 10 inline comments as done. angelgarcia added a comment. Use CamelCase on the existing tests and add a test for every other naming convention. http://reviews.llvm.org/D13052 Files: clang-tidy/modernize/LoopConvertCheck.cpp

Re: [PATCH] D12482: Analyzer: Teach analyzer how to handle TypeTraitExpr

ismailp updated this revision to Diff 35384. ismailp added a comment. Addressed comments. http://reviews.llvm.org/D12482 Files: lib/StaticAnalyzer/Core/Environment.cpp lib/StaticAnalyzer/Core/ExprEngine.cpp lib/StaticAnalyzer/Core/SValBuilder.cpp test/Analysis/dtor.cpp Index:

Re: [PATCH] D12482: Analyzer: Teach analyzer how to handle TypeTraitExpr

ismailp marked an inline comment as done. ismailp added a comment. Thanks for reviewing. http://reviews.llvm.org/D12482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13051: Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available.

On Tue, Sep 22, 2015 at 05:44:59PM +, Eric Fiselier via cfe-commits wrote: > EricWF added a comment. > > Does anything actually need this? This interface was never really meant to be > complete, just want was needed. > > > It's a shame that libc++ decided to reinvent the wheel here and not

Re: [PATCH] D12840: [cfe-dev] Enabling ThreadSanitizer on PPC64(BE/LE) plarforms

hfinkel added a subscriber: hfinkel. hfinkel accepted this revision. hfinkel added a reviewer: hfinkel. hfinkel added a comment. This revision is now accepted and ready to land. LGTM, although don't commit until any necessary backend/compiler-rt patches are in. http://reviews.llvm.org/D12840

Re: [PATCH] D13080: [libc++] ~unique_ptr() should not set stored pointer to null

thakis added a subscriber: thakis. thakis added a comment. mclow should review this, not me. http://reviews.llvm.org/D13080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12903: Add -fplugin=name.so option to the driver

rengolin added a comment. In http://reviews.llvm.org/D12903#249406, @thakis wrote: > Also also, this approach fundamentally doesn't work on Windows. I don't think it's supposed to, anyway. :) Repository: rL LLVM http://reviews.llvm.org/D12903

r248318 - [analyzer] Create one state for a range switch case instead of multiple.

Author: dcoughlin Date: Tue Sep 22 15:31:19 2015 New Revision: 248318 URL: http://llvm.org/viewvc/llvm-project?rev=248318=rev Log: [analyzer] Create one state for a range switch case instead of multiple. This fixes PR16833, in which the analyzer was using large amounts of memory for switch

Re: r248293 - [CUDA] Add implicit __attribute__((used)) to all __global__ functions.

On Tue, Sep 22, 2015 at 11:49 AM, Richard Smith wrote: > It seems like the real problem here is that we're giving the template > instantiation the wrong linkage. It can be used from outside this llvm > module, so it should be weak_odr instead of linkonce_odr. > This indeed

[PATCH] D13071: [PATCH] New checker for mismatched operator new/operator delete definitions

aaron.ballman created this revision. aaron.ballman added reviewers: klimek, alexfh. aaron.ballman added a subscriber: cfe-commits. When defining a free store function, it is almost invariably a bug to fail to declare the corresponding free store function. For instance, implementing operator

Re: [PATCH] D13051: Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available.

dim added a comment. In http://reviews.llvm.org/D13051#250921, @jroelofs wrote: > In http://reviews.llvm.org/D13051#250910, @EricWF wrote: > > > @jroelofs @dim, could we fallback to the __sync_* builtins on arm? > The actual implementations of these __sync builtins should still come from

Re: [PATCH] D13013: [ARM] Fix crash "-target arm -mcpu=generic", without "-march="

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. Apart from the style nitpick, LGTM. Thanks! Comment at: lib/Driver/Tools.cpp:6139 @@ +6138,3 @@ + ArchKind = llvm::ARM::parseCPUArch(Triple.getARMCPUForArch(Arch));

[PATCH] D13067: [CUDA] __global__ functions should always be visible externally.

tra created this revision. tra added reviewers: rsmith, echristo. tra added a subscriber: cfe-commits. Adjusted __global__ functions with DiscardableODR linkage to use StrongODR linkage instead so they are visible externally. Replaces D11666 / r248293 http://reviews.llvm.org/D13067 Files:

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

rtrieu added inline comments. Comment at: lib/Basic/SourceManager.cpp:1008 @@ -1008,1 +1007,3 @@ +bool SourceManager::isMacroArgExpansion(SourceLocation Loc, + SourceLocation *NewLoc) const { if (!Loc.isMacroID()) return false;

Re: [PATCH] D9924: Ignore report when the argument to malloc is assigned known value

hiraditya updated this revision to Diff 35461. hiraditya added a comment. Updated commit message and summary. http://reviews.llvm.org/D9924 Files: lib/StaticAnalyzer/Checkers/MallocOverflowSecurityChecker.cpp test/Analysis/malloc-overflow.c test/Analysis/malloc-overflow2.c Index:

Re: [PATCH] D12774: createUniqueFile() is documented to create the file in the temporary directory unless it's supplied an absolute path.Make sure the output filepath supplied to createUniqueFile() in

vsk added a comment. Yes, that looks good. http://reviews.llvm.org/D12774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12996: Driver: support ARM/HF on a single toolchain

compnerd added a comment. Yeah, I realize that we will need that part of the change as well. However, I think that this is a sufficiently standalone piece that we can merge this first. http://reviews.llvm.org/D12996 ___ cfe-commits mailing list

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

This revision was automatically updated to reflect the committed changes. Closed by commit rL248336: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0). (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D9040?vs=34583=35432#toc Repository: rL LLVM

r248336 - [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

Author: dcoughlin Date: Tue Sep 22 17:47:14 2015 New Revision: 248336 URL: http://llvm.org/viewvc/llvm-project?rev=248336=rev Log: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0). Currently realloc(ptr, 0) is treated as free() which seems to be not correct. C standard (N1570)

Re: [PATCH] D9924: Ignore report when the argument to malloc is assigned known value

dcoughlin added a comment. Aditya, can you update the patch title and summary to a commit message so I can commit it? Thanks! http://reviews.llvm.org/D9924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12840: [cfe-dev] Enabling ThreadSanitizer on PPC64(BE/LE) plarforms

samsonov added a subscriber: samsonov. samsonov accepted this revision. samsonov added a reviewer: samsonov. samsonov added a comment. LGTM http://reviews.llvm.org/D12840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12417: Improvements to localizability checks for iOS / OS X

This revision was automatically updated to reflect the committed changes. Closed by commit rL248350: [analyzer] Improve localizability checks for iOS / OS X. (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D12417?vs=35404=35445#toc Repository: rL LLVM

Re: r248234 - ms Intrin.h: Fix __movsw's and __stosw's inline asm.

It says "error: unable to create target: 'No available targets are compatible with this triple, see -version for the available targets.'" I guess you disable a bunch of targets on that bot? On Tue, Sep 22, 2015 at 6:00 PM, Renato Golin via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 21

Re: [PATCH] D12417: Improvements to localizability checks for iOS / OS X

dcoughlin added a comment. This is causing tests to fail on the bots: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/31373 /home/llvmbb/llvm-build-dir/clang-x86_64-debian-fast/llvm.obj/Release+Asserts/bin/clang -cc1 -internal-isystem

r248345 - Module Debugging: Use the clang module signature as the module's dwo_id

Author: adrian Date: Tue Sep 22 18:26:43 2015 New Revision: 248345 URL: http://llvm.org/viewvc/llvm-project?rev=248345=rev Log: Module Debugging: Use the clang module signature as the module's dwo_id when building a module. Clang already records the module signature when building a skeleton CU to

r248350 - [analyzer] Improve localizability checks for iOS / OS X.

Author: dcoughlin Date: Tue Sep 22 18:58:04 2015 New Revision: 248350 URL: http://llvm.org/viewvc/llvm-project?rev=248350=rev Log: [analyzer] Improve localizability checks for iOS / OS X. Various improvements to the localization checker: * Adjusted copy to be consistent with diagnostic text in

Re: [PATCH] D12989: [CUDA] Added CUDA installation detector class.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Thanks! -eric http://reviews.llvm.org/D12989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13067: [CUDA] __global__ functions should always be visible externally.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Seems to be what we were chatting about. Thanks! -eric http://reviews.llvm.org/D13067 ___ cfe-commits mailing list

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

rengolin added a comment. In http://reviews.llvm.org/D12633#250612, @labrinea wrote: > __ARM_FP_FAST is defined to 1 if floating-point optimizations may occur such > that the computed results are different from those prescribed by the order of > operations according to the C standard. Examples

r248344 - Serialization: Let ASTWriter return the signature of the written module.

Author: adrian Date: Tue Sep 22 18:26:31 2015 New Revision: 248344 URL: http://llvm.org/viewvc/llvm-project?rev=248344=rev Log: Serialization: Let ASTWriter return the signature of the written module. NFC Modified: cfe/trunk/include/clang/Serialization/ASTWriter.h

[PATCH] D13080: [libc++] ~unique_ptr() should not set stored pointer to null

dcheng created this revision. dcheng added a reviewer: thakis. dcheng added a subscriber: cfe-commits. This better matches the behavior of MSVC and libstdc++: neither standard library sets the stored pointer to null when destroying the unique_ptr. http://reviews.llvm.org/D13080 Files:

Re: [PATCH] D13080: [libc++] ~unique_ptr() should not set stored pointer to null

dblaikie added a subscriber: dblaikie. dblaikie added a comment. I'd still be curious to see a stronger justification from the standard about this. I know you mentioned/quoted the definition of ~unique_ptr in the standard - but I'm not sure that is meant to imply observable behavior during

r248351 - Revert "[analyzer] Improve localizability checks for iOS / OS X."

Author: dcoughlin Date: Tue Sep 22 19:17:52 2015 New Revision: 248351 URL: http://llvm.org/viewvc/llvm-project?rev=248351=rev Log: Revert "[analyzer] Improve localizability checks for iOS / OS X." This reverts commit r248350. The pluralization checks are failing on some bots. Modified:

Re: [PATCH] D13080: [libc++] ~unique_ptr() should not set stored pointer to null

dcheng added a comment. In http://reviews.llvm.org/D13080#251324, @dblaikie wrote: > I'd still be curious to see a stronger justification from the standard > about this. > > I know you mentioned/quoted the definition of ~unique_ptr in the standard - > but I'm not sure that is meant to imply

Re: r248234 - ms Intrin.h: Fix __movsw's and __stosw's inline asm.

r248355 might help. On Tue, Sep 22, 2015 at 8:23 PM, Nico Weber wrote: > It says "error: unable to create target: 'No available targets are > compatible with this triple, see -version for the available targets.'" I > guess you disable a bunch of targets on that bot? > > On

r248355 - Make ms-intrin.cpp test require the x86 target.

Author: nico Date: Tue Sep 22 19:24:34 2015 New Revision: 248355 URL: http://llvm.org/viewvc/llvm-project?rev=248355=rev Log: Make ms-intrin.cpp test require the x86 target. Modified: cfe/trunk/test/Headers/ms-intrin.cpp Modified: cfe/trunk/test/Headers/ms-intrin.cpp URL:

Re: [PATCH] D13080: [libc++] ~unique_ptr() should not set stored pointer to null

On Tue, Sep 22, 2015 at 5:26 PM, Daniel Cheng via cfe-commits < cfe-commits@lists.llvm.org> wrote: > dcheng added a comment. > > In http://reviews.llvm.org/D13080#251324, @dblaikie wrote: > > > I'd still be curious to see a stronger justification from the standard > > about this. > > > > I know

Re: r248276 - [mips] Added support for using the command line options -Wa, -msoft-float and -Wa, -mhard-float.

On Tue, Sep 22, 2015 at 01:52:33PM -, Daniel Sanders via cfe-commits wrote: > Author: dsanders > Date: Tue Sep 22 08:52:32 2015 > New Revision: 248276 > > URL: http://llvm.org/viewvc/llvm-project?rev=248276=rev > Log: > [mips] Added support for using the command line options -Wa,-msoft-float

Re: [PATCH] D13048: Fix for merging decls in pragma weak

aaron.ballman added a comment. Generally LGTM, but I would wait for Richard to review in this case. ~Aaron Comment at: lib/Sema/SemaDeclAttr.cpp:5201 @@ -5200,5 +5200,3 @@ if (FunctionDecl *FD = dyn_cast(ND)) { -FunctionDecl *NewFD; -// FIXME: Missing call to

[clang-tools-extra] r248252 - misc-unused-parameter: Ignore lambda static invokers.

Author: djasper Date: Tue Sep 22 04:20:20 2015 New Revision: 248252 URL: http://llvm.org/viewvc/llvm-project?rev=248252=rev Log: misc-unused-parameter: Ignore lambda static invokers. Modified: clang-tools-extra/trunk/clang-tidy/misc/UnusedParametersCheck.cpp

Re: [PATCH] D12369: [clang-format] Fix alignConsecutiveAssignments not working properly

djasper closed this revision. djasper added a comment. Submitted as r248254, thank you! http://reviews.llvm.org/D12369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Do you have commit access? Comment at: lib/Format/TokenAnnotator.cpp:377 @@ -376,1 +376,3 @@ +(!Contexts.back().ColonIsDictLiteral || +

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

dkrupp added a comment. Hi, Regarding testing: I think we should create a RecursiveASTvistor based "test checker" that matches every statement and declaration and reports a bug there. Then we could create a test file similar to what we have in

[PATCH] D13048: Fix for merging decls in pragma weak

amusman created this revision. amusman added reviewers: rsmith, aaron.ballman, ABataev. amusman added a subscriber: cfe-commits. In the following example, we have a declaration of weakfoo before #pragma weak. extern void weakfoo(); void localfoo() { }

Re: [PATCH] D12955: Fix assertion in inline assembler IR gen

amusman closed this revision. amusman added a comment. Thanks, I've commited the changes in revision 248158 (but forgot to add link in svn commit message). Alexander http://reviews.llvm.org/D12955 ___ cfe-commits mailing list

r248254 - clang-format: Fix alignConsecutiveAssignments.

Author: djasper Date: Tue Sep 22 04:32:00 2015 New Revision: 248254 URL: http://llvm.org/viewvc/llvm-project?rev=248254=rev Log: clang-format: Fix alignConsecutiveAssignments. It wasn't correctly handling this case: int oneTwoThree = 123; int oneTwo = 12; method(); Review:

r248276 - [mips] Added support for using the command line options -Wa, -msoft-float and -Wa, -mhard-float.

Author: dsanders Date: Tue Sep 22 08:52:32 2015 New Revision: 248276 URL: http://llvm.org/viewvc/llvm-project?rev=248276=rev Log: [mips] Added support for using the command line options -Wa,-msoft-float and -Wa,-mhard-float. Patch by Scott Egerton. Reviewers: vkalintiris, dsanders

Re: [PATCH] D11693: clang-format: Support generalized lambda captures.

djasper added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:1064 @@ +1063,3 @@ +// parseBracedList. For now, parsing matching braces ([], (), {}) is +// good enough. +if (FormatTok->is(tok::l_paren)) { strager wrote: >

Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

RedX2501 added a comment. Ping http://reviews.llvm.org/D10833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12492: [Clang-Format] Add AlwaysBreakBeforeElse and AlwaysBreakBeforeCatch Style to avoid cuddled else/catch

djasper added a comment. If that's ok for you, I'd like to try and restructure the existing options first. I'll try to complete that this week. Will update this review once I am done. http://reviews.llvm.org/D12492 ___ cfe-commits mailing list

Re: [PATCH] D12489: [clang-format] Fixed missing space between Obj-C for/in and a typecast

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Do you have commit access? http://reviews.llvm.org/D12489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r248279 - Remove unused diagnostic. NFC.

Author: d0k Date: Tue Sep 22 09:34:59 2015 New Revision: 248279 URL: http://llvm.org/viewvc/llvm-project?rev=248279=rev Log: Remove unused diagnostic. NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td URL:

Re: [PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

alexfh added inline comments. Comment at: clang-tidy/misc/MoveConstructorInitCheck.cpp:96 @@ +95,3 @@ + +void MoveConstructorInitCheck::handleMoveConstructor( +const MatchFinder::MatchResult ) { Other checks have separate options for the include style (see

Re: [PATCH] D13057: [mips] Relax -mnan=2008 acceptance to permit MIPS32R2 and MIPS64R2.

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] __attribute__((enable_if)) and non-overloaded member functions

Hello, > It looks like the attached patch is the same as the original one? I’ve attache the wrong patch. Here is the right one: enable-if.diff Description: Binary data Thanks, Ettore Speziale___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D13054: [libc++] Un-guarded reference to uncaught_exception() in ostream header

rmaprath created this revision. rmaprath added a subscriber: cfe-commits. The ostream header contains an un-guarded reference to uncaught_exception() which causes it to drag in the exception handling machinery even when not required (i.e. when compiling with -fno-exceptions). There are no tests

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

labrinea added a comment. GCC online docs state: > -ffast-math > Might allow some programs designed to not be too dependent on IEEE behavior > for floating-point to run faster, or die trying. Sets >

Re: [PATCH] D13054: [libc++] Un-guarded reference to uncaught_exception() in ostream header

rmaprath updated this revision to Diff 35367. rmaprath added a comment. Updated patch with bit more context (-U20). http://reviews.llvm.org/D13054 Files: include/ostream Index: include/ostream === --- include/ostream +++

[PATCH] D13057: [mips] Relax -mnan=2008 acceptance to permit MIPS32R2 and MIPS64R2.

dsanders created this revision. dsanders added a reviewer: atanasyan. dsanders added a subscriber: cfe-commits. Strictly speaking, the MIPS*R2 ISA's should not permit -mnan=2008 since this feature was added in MIPS*R3. However, other toolchains permit this and we should do the same.

Re: [PATCH] D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key

ksuther added a comment. I do not. http://reviews.llvm.org/D12501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13048: Fix for merging decls in pragma weak

amusman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5201 @@ -5200,5 +5200,3 @@ if (FunctionDecl *FD = dyn_cast(ND)) { -FunctionDecl *NewFD; -// FIXME: Missing call to CheckFunctionDeclaration(). // FIXME: Mangling? // FIXME: Is the qualifier

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

t.p.northover added a comment. I can't explain the Opts.C99 (fesetround is provided by conforming C++11 implementations too), but I think I was just trying to capture the fact that decent hosted platforms support fesetround but freestanding ones don't (not having any library). Supporting "C89