Re: [PATCH] D11328: [clang-tidy] new "throw-by-value-catch-by-reference" check for clang-tidy

randomcppprogrammer updated this revision to Diff 36700. randomcppprogrammer marked 17 inline comments as done. randomcppprogrammer added a comment. reworked code to include the changes suggested by Aaron Ballman main changes - will not diagnose on throwing catch variables by value/pointer -

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

On Tue, Oct 6, 2015 at 10:19 AM, Manuel Klimek wrote: > On Tue, Oct 6, 2015 at 4:18 PM Aaron Ballman > wrote: >> >> On Tue, Oct 6, 2015 at 10:15 AM, Manuel Klimek wrote: >> > On Tue, Oct 6, 2015 at 4:12 PM Aaron Ballman

r249409 - [VFS] Put the incoming name in the file status to make InMemoryFS behave more like a real FS.

Author: d0k Date: Tue Oct 6 09:45:16 2015 New Revision: 249409 URL: http://llvm.org/viewvc/llvm-project?rev=249409=rev Log: [VFS] Put the incoming name in the file status to make InMemoryFS behave more like a real FS. Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp

r249408 - [Tooling] Remove dead code.

Author: d0k Date: Tue Oct 6 09:45:13 2015 New Revision: 249408 URL: http://llvm.org/viewvc/llvm-project?rev=249408=rev Log: [Tooling] Remove dead code. It took me some time to figure out why this is not working as expected: std:error_code converts to true if there is an error. This means we

Re: r249395 - BasicTests: Suppress InMemoryFileSystemTest.WindowsPath on win32 while investigating.

What was the error? On 6 October 2015 at 08:16, NAKAMURA Takumi via cfe-commits wrote: > Author: chapuni > Date: Tue Oct 6 07:16:27 2015 > New Revision: 249395 > > URL: http://llvm.org/viewvc/llvm-project?rev=249395=rev > Log: > BasicTests: Suppress

r249410 - [Tooling] Reuse FileManager in ASTUnit.

Author: d0k Date: Tue Oct 6 09:45:20 2015 New Revision: 249410 URL: http://llvm.org/viewvc/llvm-project?rev=249410=rev Log: [Tooling] Reuse FileManager in ASTUnit. ASTUnit was creating multiple FileManagers and throwing them away. Reuse the one from Tooling. No functionality change now but

Re: [PATCH] D13444: [clang-tidy] Clocky module and multiple check from my repository

On Tue, Oct 6, 2015 at 8:56 AM, Piotr Zegar wrote: > ClockMan abandoned this revision. > ClockMan added a comment. > > As a 'corporation' in which I work has doubts that checks developed by my > after work, but tested on copyright protected code should be released to >

Re: [PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Do you have commit access, or would you like me to commit on your behalf? http://reviews.llvm.org/D12839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

On Tue, Oct 6, 2015 at 4:12 PM Aaron Ballman wrote: > aaron.ballman added a comment. > > In http://reviews.llvm.org/D13368#260672, @klimek wrote: > > > In http://reviews.llvm.org/D13368#260669, @aaron.ballman wrote: > > > > > This wasn't a comment on the rule so much as

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

On Tue, Oct 6, 2015 at 10:15 AM, Manuel Klimek wrote: > On Tue, Oct 6, 2015 at 4:12 PM Aaron Ballman > wrote: >> >> aaron.ballman added a comment. >> >> In http://reviews.llvm.org/D13368#260672, @klimek wrote: >> >> > In

[PATCH] D13474: [VFS] Port tooling to use the in-memory file system.

bkramer created this revision. bkramer added a reviewer: klimek. bkramer added a subscriber: cfe-commits. Herald added a subscriber: klimek. This means file remappings can now be managed by ClangTool (or a ToolInvocation user) instead of by ToolInvocation itself. The ToolInvocation remapping is

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

On Tue, Oct 6, 2015 at 4:18 PM Aaron Ballman wrote: > On Tue, Oct 6, 2015 at 10:15 AM, Manuel Klimek wrote: > > On Tue, Oct 6, 2015 at 4:12 PM Aaron Ballman > > wrote: > >> > >> aaron.ballman added a comment. > >> > >> In

Re: [PATCH] D13398: [clang-tidy] add check cppcoreguidelines-pro-type-const-cast

alexfh added a comment. It looks like potentially we're going to have tens of checks in this module. I wonder whether we should start organizing the checks somehow right away. For example, create a directory (and a namespace) for each profile. We'd need to adapt the add_new_check.py script to

r249517 - clang-format: Fix false ObjC block detection.

Author: djasper Date: Tue Oct 6 22:43:10 2015 New Revision: 249517 URL: http://llvm.org/viewvc/llvm-project?rev=249517=rev Log: clang-format: Fix false ObjC block detection. Before: inline A operator^(const A , const A ) {} int i; After: inline A operator^(const A , const A ) {} int i;

r249519 - Make clang-format actually respect custom brace wrapping flags.

Author: djasper Date: Tue Oct 6 23:06:10 2015 New Revision: 249519 URL: http://llvm.org/viewvc/llvm-project?rev=249519=rev Log: Make clang-format actually respect custom brace wrapping flags. This fixes llvm.org/PR25073. Modified: cfe/trunk/lib/Format/Format.cpp

r249437 - Make clang_Cursor_getMangling don't mangle if the declaration isn't mangled

Author: ehsan Date: Tue Oct 6 13:24:33 2015 New Revision: 249437 URL: http://llvm.org/viewvc/llvm-project?rev=249437=rev Log: Make clang_Cursor_getMangling don't mangle if the declaration isn't mangled Right now clang_Cursor_getMangling will attempt to mangle any declaration, even if the

Re: [PATCH] D13317: clang_Cursor_getMangling shouldn't mangle if the declaration isn't mangled

ehsan closed this revision. ehsan added a comment. Landed in r249437. http://reviews.llvm.org/D13317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] r249445 - integer: remove explicit casts from _MIN definitions

Author: awatry Date: Tue Oct 6 14:12:12 2015 New Revision: 249445 URL: http://llvm.org/viewvc/llvm-project?rev=249445=rev Log: integer: remove explicit casts from _MIN definitions The spec says (section 6.12.3, CL version 1.2): The macro names given in the following list must use the values

Re: [PATCH] D13317: clang_Cursor_getMangling shouldn't mangle if the declaration isn't mangled

michaelwu updated this revision to Diff 36645. michaelwu added a comment. Turns out clang_isUnexposed is what I wanted, rather than clang_isInvalid. I remember seeing clang_isInvalid work though.. http://reviews.llvm.org/D13317 Files: test/Index/print-mangled-name.cpp

r249440 - Revert r249437

Author: ehsan Date: Tue Oct 6 13:53:12 2015 New Revision: 249440 URL: http://llvm.org/viewvc/llvm-project?rev=249440=rev Log: Revert r249437 Modified: cfe/trunk/test/Index/print-mangled-name.cpp cfe/trunk/tools/c-index-test/c-index-test.c cfe/trunk/tools/libclang/CIndex.cpp

[clang-tools-extra] r249444 - Change the write modes to "binary" so that line endings do not get munged on Windows. Otherwise, when this script is run, all files created on Windows have CRLF instead o

Author: aaronballman Date: Tue Oct 6 14:11:12 2015 New Revision: 249444 URL: http://llvm.org/viewvc/llvm-project?rev=249444=rev Log: Change the write modes to "binary" so that line endings do not get munged on Windows. Otherwise, when this script is run, all files created on Windows have CRLF

Re: [PATCH] D13326: [PGO]: Eliminate __llvm_profile_register calls for Linux (clang changes)

David Li writes: > davidxl updated this revision to Diff 36316. > davidxl added a comment. > > I have modified the implementation to not use linker script, so this > clang patch becomes strictly refactoring with NFC. I think it is still > a good thing to have this in so that

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF added inline comments. Comment at: include/CMakeLists.txt:31 @@ +30,3 @@ +# by prepending __config_site to the current __config header. +# TODO(EricWF) Is it portable to use "cat" and ">>"? +add_custom_command(OUTPUT ${LIBCXX_BINARY_DIR}/__generated_config

Re: r249413 - [Tooling] Don't run a tool invocation without a FileManager.

On Tue, Oct 6, 2015 at 8:04 AM, Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Tue Oct 6 10:04:13 2015 > New Revision: 249413 > > URL: http://llvm.org/viewvc/llvm-project?rev=249413=rev > Log: > [Tooling] Don't run a tool invocation without a

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

eugenis added a comment. Looks great! Comment at: include/CMakeLists.txt:31 @@ +30,3 @@ +# by prepending __config_site to the current __config header. +# TODO(EricWF) Is it portable to use "cat" and ">>"? +add_custom_command(OUTPUT

Re: [PATCH] D13446: [PATCH] Add checker discouraging definition of variadic function definitions in C++

On Mon, Oct 05, 2015 at 07:36:08PM +, Aaron Ballman via cfe-commits wrote: > C-style variadic functions (using an ellipsis) can be dangerous in C++ > due to the inherit lack of type safety with argument passing. Better > alternatives exist, such as function currying (like STL stream objects >

[libcxx] r249461 - Updated issue 2476

Author: marshall Date: Tue Oct 6 15:35:15 2015 New Revision: 249461 URL: http://llvm.org/viewvc/llvm-project?rev=249461=rev Log: Updated issue 2476 Modified: libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/kona.html URL:

Re: [PATCH] D13446: [PATCH] Add checker discouraging definition of variadic function definitions in C++

On Tue, Oct 06, 2015 at 04:20:05PM -0400, Aaron Ballman via cfe-commits wrote: > On Tue, Oct 6, 2015 at 4:12 PM, Joerg Sonnenberger via cfe-commits > wrote: > > On Mon, Oct 05, 2015 at 07:36:08PM +, Aaron Ballman via cfe-commits > > wrote: > >> C-style variadic

Re: [PATCH] D13446: [PATCH] Add checker discouraging definition of variadic function definitions in C++

On Tue, Oct 6, 2015 at 4:49 PM, Joerg Sonnenberger via cfe-commits wrote: > On Tue, Oct 06, 2015 at 04:20:05PM -0400, Aaron Ballman via cfe-commits wrote: >> On Tue, Oct 6, 2015 at 4:12 PM, Joerg Sonnenberger via cfe-commits >> wrote: >> >

Re: [libclc] r249445 - integer: remove explicit casts from _MIN definitions

On Tue, Oct 06, 2015 at 07:12:12PM -, Aaron Watry via cfe-commits wrote: > Author: awatry > Date: Tue Oct 6 14:12:12 2015 > New Revision: 249445 > > URL: http://llvm.org/viewvc/llvm-project?rev=249445=rev > Log: > integer: remove explicit casts from _MIN definitions Why do this definitions

Re: [PATCH] D13446: [PATCH] Add checker discouraging definition of variadic function definitions in C++

On Tue, Oct 6, 2015 at 4:12 PM, Joerg Sonnenberger via cfe-commits wrote: > On Mon, Oct 05, 2015 at 07:36:08PM +, Aaron Ballman via cfe-commits wrote: >> C-style variadic functions (using an ellipsis) can be dangerous in C++ >> due to the inherit lack of type

[libcxx] r249458 - Our test allocators support move/copy construction; they should support move/copy assignment as well

Author: marshall Date: Tue Oct 6 15:30:56 2015 New Revision: 249458 URL: http://llvm.org/viewvc/llvm-project?rev=249458=rev Log: Our test allocators support move/copy construction; they should support move/copy assignment as well Modified: libcxx/trunk/test/support/allocators.h Modified:

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF added inline comments. Comment at: include/CMakeLists.txt:31 @@ +30,3 @@ +# by prepending __config_site to the current __config header. +# TODO(EricWF) Is it portable to use "cat" and ">>"? +add_custom_command(OUTPUT ${LIBCXX_BINARY_DIR}/__generated_config

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

rnk added a subscriber: rnk. Comment at: include/CMakeLists.txt:31 @@ +30,3 @@ +# by prepending __config_site to the current __config header. +# TODO(EricWF) Is it portable to use "cat" and ">>"? +add_custom_command(OUTPUT ${LIBCXX_BINARY_DIR}/__generated_config

Re: [PATCH] D13311: [clang-tidy] Add check cppcoreguidelines-pro-bounds-pointer-arithmetic

mgehre marked 2 inline comments as done. Comment at: test/clang-tidy/cppcoreguidelines-pro-bounds-pointer-arithmetic.cpp:37 @@ +36,3 @@ + q -= i; + // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: do not use pointer arithmetic + q -= ENUM_LITERAL; aaron.ballman

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

mgehre marked an inline comment as done. mgehre added a comment. I cannot think of any way to improve the usefulness of the diagnostic in the non-polymorphic case. For now, this patch has a link to the CppCoreGuidelines document in the docs/**/*.rst file. Also, this check is not enabled by

[libcxx] r249475 - Remove unnecessary inline functions capturing the contents of C library macros.

Author: rsmith Date: Tue Oct 6 17:03:22 2015 New Revision: 249475 URL: http://llvm.org/viewvc/llvm-project?rev=249475=rev Log: Remove unnecessary inline functions capturing the contents of C library macros. The C standard requires that these be provided as functions even if they're also

Re: [PATCH] D12747: Implement [depr.c.headers]

Split header out of On Tue, Oct 6, 2015 at 3:07 PM, Richard Smith wrote: > Next: factoring the definition of std::nullptr_t out into a separate file, > so that and can both use it, without > including and without providing a ::nullptr_t like > does. > > On Tue,

Re: [libcxx] r249475 - Remove unnecessary inline functions capturing the contents of C library macros.

On 10/6/15 4:03 PM, Richard Smith via cfe-commits wrote: Author: rsmith Date: Tue Oct 6 17:03:22 2015 New Revision: 249475 URL: http://llvm.org/viewvc/llvm-project?rev=249475=rev Log: Remove unnecessary inline functions capturing the contents of C library macros. The C standard requires

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

mgehre updated this revision to Diff 36664. mgehre added a comment. Remove trailing [cppcoreguidelines-pro-type-static-cast-downcast] on tests http://reviews.llvm.org/D13368 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp

Re: [PATCH] D13398: [clang-tidy] add check cppcoreguidelines-pro-type-const-cast

mgehre updated this revision to Diff 36668. mgehre added a comment. Rebased http://reviews.llvm.org/D13398 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp clang-tidy/cppcoreguidelines/ProTypeConstCastCheck.cpp

Re: [PATCH] D13325: Fix crash in codegen on casting to `bool &`.

rjmccall added a comment. LGTM. http://reviews.llvm.org/D13325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12747: Implement [depr.c.headers]

Likewise for , , On Tue, Oct 6, 2015 at 3:20 PM, Richard Smith wrote: > Split header out of > > On Tue, Oct 6, 2015 at 3:07 PM, Richard Smith > wrote: > >> Next: factoring the definition of std::nullptr_t out into a separate >> file, so that

Re: [PATCH] D12747: Implement [depr.c.headers]

On Mon, Oct 5, 2015 at 7:10 PM, Eric Fiselier wrote: > EricWF added a comment. > > I think thing change will help us close a number out outstanding bugs. I > don't have any fundamental objections to this approach. However the size > of this patch scares me. I understand the

Re: [PATCH] D12747: Implement [depr.c.headers]

LGTM. On Tue, Oct 6, 2015 at 3:58 PM, Richard Smith wrote: > On Mon, Oct 5, 2015 at 7:10 PM, Eric Fiselier wrote: >> >> EricWF added a comment. >> >> I think thing change will help us close a number out outstanding bugs. I >> don't have any fundamental

Re: [PATCH] D12747: Implement [depr.c.headers]

Next: factoring the definition of std::nullptr_t out into a separate file, so that and can both use it, without including and without providing a ::nullptr_t like does. On Tue, Oct 6, 2015 at 3:02 PM, Eric Fiselier wrote: > LGTM. > > On Tue, Oct 6, 2015 at 3:58 PM, Richard

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

xazax.hun marked 2 inline comments as done. xazax.hun added a comment. In http://reviews.llvm.org/D10305#258671, @zaks.anna wrote: > > Generating mangled names requires ASTContext which is not available during > > the error reporting. BugReporter does have the ASTContext, so it would not > > >

Re: [PATCH] D13100: [mips] Separated mips specific -Wa options, so that they are not checked on other platforms.

dsanders accepted this revision. dsanders added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13326: [PGO]: Eliminate __llvm_profile_register calls for Linux (clang changes)

Clang FE refactoring change is not needed anymore. In commit 0d32e7d952bc80830183e0c2c6ec5027ca6b1450, Vasileios Kalintiris did the same thing for multi-lib support. David On Tue, Oct 6, 2015 at 12:13 AM, Justin Bogner wrote: > David Li writes: >>

Re: [PATCH] D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key

ksuther added a comment. Do I need to do anything else about this and http://reviews.llvm.org/D12489, or do they eventually get committed by someone else? Thanks! http://reviews.llvm.org/D12501 ___ cfe-commits mailing list

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF added a comment. Cool. I've reached out to some platform maintainers to make sure they don't see any problems. I'll commit this once I hear back. http://reviews.llvm.org/D13407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12747: Implement [depr.c.headers]

On Tue, Oct 6, 2015 at 4:16 PM, Sean Silva wrote: > On Tue, Oct 6, 2015 at 4:13 PM, Richard Smith > wrote: > >> On Tue, Oct 6, 2015 at 4:11 PM, Sean Silva wrote: >> >>> +extern "C++" { >>> +#include <__nullptr> >>> +using

Re: [PATCH] D9898: MismatchingNewDeleteDetector uses incorrect field, and finds no initializer

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D9898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [clang-tools-extra] r249235 - Replace double negation of !FileID.isInvalid() with FileID.isValid().

I'd say that the SourceLocation::isInvalid is more confusing than useful. Not sure why it was added in the first place. On Sat, Oct 3, 2015 at 12:46 PM, Yaron Keren via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: yrnkrn > Date: Sat Oct 3 05:46:20 2015 > New Revision: 249235 > >

Re: [PATCH] D12644: Using -isysroot on Apple platform

EricWF added a comment. You need to use the CMake option `CMAKE_OSX_SYSROOT` to manage the system root because `lib/CMakeLists.txt` uses "CMAKE_OSX_SYSROOT" to find the correct libc++abi.dylib. Have you tried that? It is unfortunate that Linux and OS X use different options for the same thing

r249497 - [SEH] Fix x64 __exception_code in __except blocks

Author: rnk Date: Tue Oct 6 20:07:13 2015 New Revision: 249497 URL: http://llvm.org/viewvc/llvm-project?rev=249497=rev Log: [SEH] Fix x64 __exception_code in __except blocks Use llvm.eh.exceptioncode to get the code out of EAX for x64. For 32-bit, the filter is responsible for storing it to

Re: [PATCH] D13488: [analyzer] Assume escape is possible through system functions taking void*

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Has a typo but otherwise LGTM. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:258 @@ +257,3 @@ + /// the condition. + bool

r249499 - clang/test/CodeGen/exceptions-seh-leave-new.c: Use "opt -instnamer" for branch-sensitive checks.

Author: chapuni Date: Tue Oct 6 20:29:26 2015 New Revision: 249499 URL: http://llvm.org/viewvc/llvm-project?rev=249499=rev Log: clang/test/CodeGen/exceptions-seh-leave-new.c: Use "opt -instnamer" for branch-sensitive checks. Modified: cfe/trunk/test/CodeGen/exceptions-seh-leave-new.c

r249501 - clang-format: Fix false positive in pointer/reference detection.

Author: djasper Date: Tue Oct 6 20:41:14 2015 New Revision: 249501 URL: http://llvm.org/viewvc/llvm-project?rev=249501=rev Log: clang-format: Fix false positive in pointer/reference detection. Before: return options != nullptr &==(*options); After: return options != nullptr &&

r249502 - clang-format: Understand array reference types.

Author: djasper Date: Tue Oct 6 20:41:22 2015 New Revision: 249502 URL: http://llvm.org/viewvc/llvm-project?rev=249502=rev Log: clang-format: Understand array reference types. Before: void f(Type()[10]) {} void f(Type (*parameter)[10]) {} After: void f(Type ()[10]) {} void f(Type

Re: [PATCH] D13099: [Analyzer] Don’t invalidate CXXThis when conservatively evaluating const methods (PR 21606)

xazax.hun added inline comments. Comment at: test/Analysis/const-method-call.cpp:26 @@ +25,3 @@ + +struct Derived : Base { + mutable int mut; Please add a test case, where only base have a mutable field. http://reviews.llvm.org/D13099

Re: [PATCH] D13099: [Analyzer] Don’t invalidate CXXThis when conservatively evaluating const methods (PR 21606)

seaneveson marked 6 inline comments as done. seaneveson added a comment. There is an issue where pointers to the object (this) should cause it to be invalidated, but don't since TK_PreserveContents has been set. For example: class B; class A { B b; const foo(); }; class B {

Re: [PATCH] D13099: [Analyzer] Don’t invalidate CXXThis when conservatively evaluating const methods (PR 21606)

seaneveson updated this revision to Diff 36604. seaneveson added a comment. Removed mutable field from derived class in inheritance test case. http://reviews.llvm.org/D13099 Files: include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h lib/StaticAnalyzer/Core/CallEvent.cpp

Re: [PATCH] D13099: [Analyzer] Don’t invalidate CXXThis when conservatively evaluating const methods (PR 21606)

seaneveson marked an inline comment as done. seaneveson added a comment. http://reviews.llvm.org/D13099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12747: Implement [depr.c.headers]

On Tue, Oct 6, 2015 at 3:07 PM, Richard Smith wrote: > Next: factoring the definition of std::nullptr_t out into a separate file, > so that and can both use it, without > including and without providing a ::nullptr_t like > does. > Sorry, missed a couple of the

Re: r249395 - BasicTests: Suppress InMemoryFileSystemTest.WindowsPath on win32 while investigating.

On Wed, Oct 7, 2015 at 12:29 AM Rafael Espíndola wrote: > What was the error? > http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/5683 http://bb.pgr.jp/builders/ninja-clang-i686-msc18-R/builds/3409

Re: [PATCH] D12747: Implement [depr.c.headers]

. This one is tricky: 1) There's an (undocumented) interface between the C standard library and this header, where the macros __need_ptrdiff_t, __need_size_t, __need_wchar_t, __need_NULL, __need_wint_t request just a piece of this header rather than the whole thing. If we see any of those, just

Re: [PATCH] D12747: Implement [depr.c.headers]

On Tue, Oct 6, 2015 at 4:13 PM, Richard Smith wrote: > On Tue, Oct 6, 2015 at 4:11 PM, Sean Silva wrote: > >> +extern "C++" { >> +#include <__nullptr> >> +using std::nullptr_t; >> +} >> >> Does this even compile with modules? >> > > Yes. You're

r249484 - Fix Clang-tidy modernize-use-nullptr warnings in source directories; other minor cleanups

Author: hans Date: Tue Oct 6 18:40:43 2015 New Revision: 249484 URL: http://llvm.org/viewvc/llvm-project?rev=249484=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in source directories; other minor cleanups Patch by Eugene Zelenko! Differential Revision: http://reviews.llvm.org/D13406

Re: [PATCH] D13406: [Clang] Fix Clang-tidy modernize-use-nullptr warnings in source directories; other minor cleanups.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/Sema/SemaDeclObjC.cpp:510 @@ -509,3 +509,3 @@ -if (PrevDecl && SuperClassDecl == 0) { +if (PrevDecl && (!SuperClassDecl)) { // The previous

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF updated this revision to Diff 36682. EricWF added a comment. Use `type` instead of `cat` on windows as suggested by @rnk. @eugenis does this address your concern? http://reviews.llvm.org/D13407 Files: CMakeLists.txt cmake/Modules/HandleLibcxxFlags.cmake

[PATCH] D13488: [analyzer] Assume escape is possible through system functions taking void*

zaks.anna created this revision. zaks.anna added a reviewer: dcoughlin. zaks.anna added subscribers: xazax.hun, cfe-commits. Herald added a subscriber: aemerson. The analyzer assumes that system functions will not free memory or modify the arguments in other ways, so we assume that arguments do

r249388 - [VFS] Port applyAllReplacements to InMemoryFileSystem.

Author: d0k Date: Tue Oct 6 05:23:17 2015 New Revision: 249388 URL: http://llvm.org/viewvc/llvm-project?rev=249388=rev Log: [VFS] Port applyAllReplacements to InMemoryFileSystem. Modified: cfe/trunk/lib/Tooling/Core/Replacement.cpp Modified: cfe/trunk/lib/Tooling/Core/Replacement.cpp URL:

r249389 - [VFS] Port SimpleFormatContext to InMemoryFileSystem.

Author: d0k Date: Tue Oct 6 05:23:34 2015 New Revision: 249389 URL: http://llvm.org/viewvc/llvm-project?rev=249389=rev Log: [VFS] Port SimpleFormatContext to InMemoryFileSystem. Modified: cfe/trunk/lib/Index/SimpleFormatContext.h Modified: cfe/trunk/lib/Index/SimpleFormatContext.h URL:

r249391 - Adds a way for tools to deduce the target config from a compiler name.

Author: klimek Date: Tue Oct 6 05:45:03 2015 New Revision: 249391 URL: http://llvm.org/viewvc/llvm-project?rev=249391=rev Log: Adds a way for tools to deduce the target config from a compiler name. Adds `addTargetAndModeForProgramName`, a utility function that will add appropriate `-target foo`

Re: [PATCH] D13318: Add a utility function to add target information to a command line

klimek closed this revision. klimek added a comment. Submitted as r249391. http://reviews.llvm.org/D13318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r249392 - clang-format: Make IncludeCategories configurable in .clang-format file.

Author: djasper Date: Tue Oct 6 06:54:18 2015 New Revision: 249392 URL: http://llvm.org/viewvc/llvm-project?rev=249392=rev Log: clang-format: Make IncludeCategories configurable in .clang-format file. This was made much easier by introducing an IncludeCategory struct to replace the previously

Re: [PATCH] D13469: Create interfaces and tests for the overlapping replacements fix in clang-tidy.

angelgarcia updated this revision to Diff 36620. angelgarcia added a comment. Explain why we have defined these mocks. http://reviews.llvm.org/D13469 Files: unittests/clang-tidy/CMakeLists.txt unittests/clang-tidy/ClangTidyTest.h unittests/clang-tidy/OverlappingReplacementsTest.cpp

Re: [PATCH] D13311: [clang-tidy] Add check cppcoreguidelines-pro-bounds-pointer-arithmetic

aaron.ballman added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-pro-bounds-pointer-arithmetic.cpp:37 @@ +36,3 @@ + q -= i; + // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: do not use pointer arithmetic + q -= ENUM_LITERAL; I don't think this

Re: [PATCH] D13383: [clang] Add flag to DeclContext to distinguish between qualified and unqualified name lookups

aaron.ballman added a comment. I'm uncertain whether this change is good or not (Richard is more likely to have thoughts on that), but the patch is missing tests. Comment at: clang/lib/Sema/SemaLookup.cpp:208 @@ +207,3 @@ + + class Deinitializer { +std::function

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

aaron.ballman added a comment. In http://reviews.llvm.org/D13368#260672, @klimek wrote: > In http://reviews.llvm.org/D13368#260669, @aaron.ballman wrote: > > > This wasn't a comment on the rule so much as a comment on the diagnostic > > not being very helpful.In this case, you're telling the

Re: [PATCH] D13313: [clang-tidy] new check cppcoreguidelines-pro-type-reinterpret-cast

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've committed it in r249399. ~Aaron http://reviews.llvm.org/D13313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r249395 - BasicTests: Suppress InMemoryFileSystemTest.WindowsPath on win32 while investigating.

Author: chapuni Date: Tue Oct 6 07:16:27 2015 New Revision: 249395 URL: http://llvm.org/viewvc/llvm-project?rev=249395=rev Log: BasicTests: Suppress InMemoryFileSystemTest.WindowsPath on win32 while investigating. Modified: cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp Modified:

Re: [PATCH] D13383: [clang] Add flag to DeclContext to distinguish between qualified and unqualified name lookups

evgeny777 added a comment. Hello Jim and Sean, Greg suggested adding you for this review. Can you please take a look? http://reviews.llvm.org/D13383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13386: PR24115: Don't instantiate constexpr function templates in decltype

sberg abandoned this revision. sberg added a comment. Ah, I see. I'll wait for that approach to be implemented then. http://reviews.llvm.org/D13386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r249403 - ToolingTests: Tweak getAnyTarget() to match "x86_64".

Author: chapuni Date: Tue Oct 6 08:58:13 2015 New Revision: 249403 URL: http://llvm.org/viewvc/llvm-project?rev=249403=rev Log: ToolingTests: Tweak getAnyTarget() to match "x86_64". Both "x86" and "x86-64" are incompatible to triple's arch. Modified:

[clang-tools-extra] r249399 - Add a new module for the C++ Core Guidelines, and the first checker for those guidelines: cppcoreguidelines-pro-type-reinterpret-cast.

Author: aaronballman Date: Tue Oct 6 08:31:00 2015 New Revision: 249399 URL: http://llvm.org/viewvc/llvm-project?rev=249399=rev Log: Add a new module for the C++ Core Guidelines, and the first checker for those guidelines: cppcoreguidelines-pro-type-reinterpret-cast. Patch by Matthias Gehre!

[clang-tools-extra] r249402 - Create interfaces and tests for the overlapping replacements fix in clang-tidy.

Author: angelgarcia Date: Tue Oct 6 08:52:51 2015 New Revision: 249402 URL: http://llvm.org/viewvc/llvm-project?rev=249402=rev Log: Create interfaces and tests for the overlapping replacements fix in clang-tidy. Summary: No changes in clang-tidy yet. Reviewers: klimek Subscribers: alexfh,

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

klimek added a subscriber: klimek. klimek added a comment. In http://reviews.llvm.org/D13368#260669, @aaron.ballman wrote: > This wasn't a comment on the rule so much as a comment on the diagnostic not > being very helpful.In this case, you're telling the user to not do something, > but it is

r249394 - clang-format: Add empty line before code-blocks in Docs.

Author: djasper Date: Tue Oct 6 07:11:51 2015 New Revision: 249394 URL: http://llvm.org/viewvc/llvm-project?rev=249394=rev Log: clang-format: Add empty line before code-blocks in Docs. Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst cfe/trunk/docs/tools/dump_format_style.py

Re: [PATCH] D13469: Create interfaces and tests for the overlapping replacements fix in clang-tidy.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG Comment at: unittests/clang-tidy/OverlappingReplacementsTest.cpp:21 @@ +20,3 @@ +const char BoundIf[] = "if"; + +class UseCharCheck : public ClangTidyCheck {

[PATCH] D13469: Create interfaces and tests for the overlapping replacements fix in clang-tidy.

angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: cfe-commits, alexfh. No changes in clang-tidy yet. http://reviews.llvm.org/D13469 Files: unittests/clang-tidy/CMakeLists.txt unittests/clang-tidy/ClangTidyTest.h

Re: [PATCH] D13474: [VFS] Port tooling to use the in-memory file system.

bkramer updated this revision to Diff 36632. bkramer added a comment. - Don't rebuild VFS for every compile command - Still have to guard against multiple runs of one Tool, ClangToolTest.ArgumentAdjusters does that. http://reviews.llvm.org/D13474 Files: include/clang/Tooling/Tooling.h

Re: [PATCH] D13465: Add SafeStack support for test-suite.

jroelofs added a subscriber: jroelofs. jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13465 ___ cfe-commits mailing list

Re: [PATCH] D13465: Add SafeStack support for test-suite.

jroelofs added a comment. In http://reviews.llvm.org/D13465#260628, @tharvik wrote: > When running the test suite, it gives a bunch of `undefined reference to > '__safestack_unsafe_stack_ptr'`. > See regression results . Sounds like it's missing the safestack

Re: [PATCH] D13383: [clang] Add flag to DeclContext to distinguish between qualified and unqualified name lookups

evgeny777 added a comment. In case of qualified lookup it raises flag in DeclContext, which is not used anywhere else in clang, only in lldb (clang expression parser is linked to lldb). http://reviews.llvm.org/D13383 ___ cfe-commits mailing list

Re: [PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

flx added a comment. I don't have access, so that'd be great if you or Alex could submit the patch, thanks! Comment at: clang-tidy/misc/MoveConstructorInitCheck.cpp:11 @@ -10,2 +10,3 @@ #include "MoveConstructorInitCheck.h" +#include "../utils/Matchers.h" #include

Re: [PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've commit in r249429. http://reviews.llvm.org/D12839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13383: [clang] Add flag to DeclContext to distinguish between qualified and unqualified name lookups

aaron.ballman added a comment. In http://reviews.llvm.org/D13383#260815, @evgeny777 wrote: > What kind of tests do you propose for this? It doesn't introduce any new > features to clang, only to lldb where the separate review exists It modifies the behavior of all qualified lookups in Clang,

Re: [PATCH] D13383: [clang] Add flag to DeclContext to distinguish between qualified and unqualified name lookups

evgeny777 added a comment. What kind of tests do you propose for this? It doesn't introduce any new features to clang, only to lldb where the separate review exists http://reviews.llvm.org/D13383 ___ cfe-commits mailing list

  1   2   >