r249598 - ASTMatchers: Keep AllCallbacks in a set instead of a vector

Author: djasper Date: Wed Oct 7 14:56:12 2015 New Revision: 249598 URL: http://llvm.org/viewvc/llvm-project?rev=249598=rev Log: ASTMatchers: Keep AllCallbacks in a set instead of a vector AllCallbacks is currently only used to call onStartOfTranslationUnit and onEndOfTranslationUnit on them. In

Re: [PATCH] D13510: [PATCH] Support C++ Core Guidelines copy assignment restrictions

mgehre added a comment. The user will see [cppcoreguidelines-c-copy-assignment-signature] in warnings, but there is no docs/clang-tidy/checks/cppcoreguidelines-c-copy-assignment-signature.rst. The user won't know that he needs to look for misc-assign-operator-signature. Maybe create a link to

Re: [PATCH] D11328: [clang-tidy] new "throw-by-value-catch-by-reference" check for clang-tidy

randomcppprogrammer updated this revision to Diff 36795. randomcppprogrammer marked 11 inline comments as done. randomcppprogrammer added a comment. Incorporated feedback from Aaron Ballmann main changes: - replaced isa followed by cast with dyn_cast - reworked comments - fixed typo in

Re: [PATCH] D12747: Implement [depr.c.headers]

Marshall: ping, does the below satisfy your concerns about the direction here? On Wed, Sep 16, 2015 at 2:04 PM, Richard Smith wrote: > On Mon, Sep 14, 2015 at 7:07 AM, Marshall Clow > wrote: > >> mclow.lists added a comment. >> >> I have two

Re: [PATCH] D13453: Always generate cmake config files

jordan_rose resigned from this revision. jordan_rose edited reviewers, added: beanz; removed: jordan_rose. jordan_rose added a comment. I just get things to build with CMake, and I'm not involved with Clang so much these days. This is more about controlling what gets installed, which should be

Re: [PATCH] D13304: Avoid inlining in throw statement

On Wed, Oct 7, 2015 at 3:10 PM, Jun Bum Lim via cfe-commits < cfe-commits@lists.llvm.org> wrote: > junbuml added a comment. > > Thanks Richard for the comment. > > Initially, I intended to implement this in inliner by checking if a > callsite is in exception handling regions. However, I decided

Re: r249556 - [VFS] Port driver tool chains to VFS.

This change breaks cmake build: undefined reference to `clang::DiagnosticIDs::DiagnosticIDs()' /home/jvesely/llvm/tools/clang/unittests/Driver/ToolChainTest.cpp:33: undefined reference to `clang::DiagnosticsEngine::DiagnosticsEngine(llvm::IntrusiveRefCntPtr const&, clang::DiagnosticOptions*,

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

kromanova added a comment. Hi Pierre, I noticed the same issue. When I downloaded a patch from http://reviews.llvm.org/D11279, I had to manually add .keep files to make tests to pass. It's a Phabricator problem. The diff file that I uploaded to Phabricator contains .keep files, however the

r249616 - [WinEH] Don't use lifetime markers for MS catch parameters

Author: rnk Date: Wed Oct 7 16:03:41 2015 New Revision: 249616 URL: http://llvm.org/viewvc/llvm-project?rev=249616=rev Log: [WinEH] Don't use lifetime markers for MS catch parameters We don't have a good place to put them. Our previous spot was causing us to optimize loads from the exception

Re: [PATCH] D13523: ASTMatchers: Keep AllCallbacks in a set instead of a vector

djasper closed this revision. djasper added a comment. Submitted as r249598. http://reviews.llvm.org/D13523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r249556 - [VFS] Port driver tool chains to VFS.

On Wed, Oct 7, 2015 at 10:09 PM, Jan Vesely wrote: > > This change breaks cmake build: > undefined reference to `clang::DiagnosticIDs::DiagnosticIDs()' > /home/jvesely/llvm/tools/clang/unittests/Driver/ToolChainTest.cpp:33: > undefined reference to >

Re: [PATCH] D13440: [clang-tidy] Python script for easy check rename

ClockMan marked 5 inline comments as done. Comment at: clang-tidy/rename_check.py:53 @@ +52,3 @@ + return newFileName + +def getListOfFiles(clang_tidy_path): Not sure what you mean... Repository: rL LLVM http://reviews.llvm.org/D13440

Re: [PATCH] D13440: [clang-tidy] Python script for easy check rename

ClockMan updated this revision to Diff 36801. ClockMan added a comment. Corrected review issues. Repository: rL LLVM http://reviews.llvm.org/D13440 Files: clang-tidy/rename_check.py Index: clang-tidy/rename_check.py === ---

Re: [PATCH] D13357: [Concepts] Add diagnostic; specializations of variable and function concepts

On Wed, Oct 7, 2015 at 2:59 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > rsmith added inline comments. > > > Comment at: lib/Sema/SemaDecl.cpp:5902-5915 > @@ -5901,1 +5901,16 @@ > + > + // C++ Concepts TS [dcl.spec.concept]p7: A program shall not

Re: [PATCH] D13344: Keep the IfStmt node even if the condition is invalid

rsmith added inline comments. Comment at: lib/Sema/SemaStmt.cpp:508-509 @@ -513,6 +507,4 @@ - DiagnoseUnusedExprResult(elseStmt); - return new (Context) IfStmt(Context, IfLoc, ConditionVar, ConditionExpr, thenStmt, ElseLoc, elseStmt); }

Re: [PATCH] D13453: Always generate cmake config files

chapuni added a reviewer: jordan_rose. chapuni added a comment. LGTM, but I haven't tested. I'll wait for 3rd opinion for several hours. :) I thought it may be moved to an arbitrary subdirectory. http://reviews.llvm.org/D13453 ___ cfe-commits

Re: [PATCH] D13510: [PATCH] Support C++ Core Guidelines copy assignment restrictions

sbenza added a comment. In http://reviews.llvm.org/D13510#261925, @aaron.ballman wrote: > In http://reviews.llvm.org/D13510#261825, @Eugene.Zelenko wrote: > > > I think it'll be fine to rename check without leaving traces of misc. Same > > thing happened with modernize-shrink-to-fit. > > > I

Re: [PATCH] D13304: Avoid inlining in throw statement

rsmith added a subscriber: rsmith. rsmith added a comment. This seems like something that's much better handled by the inliner. We should presumably treat all the code that leads up to the throw as being cold, not just the invocation of the throw-expression itself, and it seems like it should

Fwd: [PATCH] D11328: [clang-tidy] new "throw-by-value-catch-by-reference" check for clang-tidy

Hi,I incorporated most of your changes. There are 2 open issues- on one location I could not follow your advice, the compiler refused to compile the code. I chose a different approach and hope you like it.- the second thing is this MaterializeTemporary advice that you gave. I don’t fully

Re: [PATCH] D13099: [Analyzer] Don’t invalidate CXXThis when conservatively evaluating const methods (PR 21606)

zaks.anna added a comment. > Again I'm not sure this is worth checking for, based on the assumption that a > reasonable const method won't modify the relevant object. What do people > think? These are heuristics. I think dealing with this case should not be a pre-requisite for the patch. We

Re: [PATCH] D13525: [CodeGen] Attach function attributes to functions created in CGBlocks.cpp.

On Wed, Oct 7, 2015 at 1:48 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > > > On 2015-Oct-07, at 11:35, Akira Hatanaka wrote: > > > > ahatanak created this revision. > > ahatanak added reviewers: dexonsmith, echristo. > > ahatanak added a subscriber:

Re: [PATCH] D13357: [Concepts] Add diagnostic; specializations of variable and function concepts

rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5902-5915 @@ -5901,1 +5901,16 @@ + + // C++ Concepts TS [dcl.spec.concept]p7: A program shall not declare [...] + // an explicit specialization, or a partial specialization of a concept + //

Re: [PATCH] D13304: Avoid inlining in throw statement

junbuml added a comment. Thanks Richard for the comment. Initially, I intended to implement this in inliner by checking if a callsite is in exception handling regions. However, I decided not to implement this in inliner because this kind of check should be performed for all callsites if we

Re: [PATCH] D13497: Silence warning from lit about missing clang-interpreter

richard.barton.arm abandoned this revision. richard.barton.arm added a comment. Adandoning and starting again with cfe-commits as subscriber. http://reviews.llvm.org/D13497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D13500: Improve helpfulness of assert message when number of diagnostics overflows number of available enum values.

richard.barton.arm created this revision. richard.barton.arm added a reviewer: rafael. richard.barton.arm added a subscriber: cfe-commits. There are two asserts that can trigger if the number of diagnostic messages in a kind overflows the number of available enums values. The one that fires if

Re: [PATCH] D13495: Improve the helpfulness of an assert message

richard.barton.arm abandoned this revision. richard.barton.arm added a comment. Abandoning as cfe-commits was not on subscribers http://reviews.llvm.org/D13495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D13498: Silence spurious warning from lit about missing clang-interpreter

richard.barton.arm created this revision. richard.barton.arm added reviewers: ddunbar, rafael. richard.barton.arm added a subscriber: cfe-commits. Clang's lit.cfg checks for the presence of a few test binaries, including the clang-interpreter. This binary is only built if building the clang

[clang-tools-extra] r249526 - [VFS] Switch clang-tidy tests to use an in-memory fs.

Author: d0k Date: Wed Oct 7 03:35:23 2015 New Revision: 249526 URL: http://llvm.org/viewvc/llvm-project?rev=249526=rev Log: [VFS] Switch clang-tidy tests to use an in-memory fs. Again, this is both cleaner and completely removes any depedency on the host file system. Modified:

Re: [PATCH] D9888: [OPENMP] Driver support for OpenMP offloading

Hahnfeld added a comment. Currently trying to test, but 1. Offloading to the same target isn't supported (`x86_64-unknown-linux-gnu` as host and device) - this was working with `clang-omp` The produced IR isn't showing any calls to the target library and on linkage it complains: undefined

r249525 - [VFS] Also drop '.' when adding files to an in-memory FS.

Author: d0k Date: Wed Oct 7 03:32:50 2015 New Revision: 249525 URL: http://llvm.org/viewvc/llvm-project?rev=249525=rev Log: [VFS] Also drop '.' when adding files to an in-memory FS. Otherwise we won't be able to find them later. Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp

[PATCH] D13499: Convert test to take input from stdin rather than reading a file

richard.barton.arm created this revision. richard.barton.arm added a reviewer: ABataev. richard.barton.arm added a subscriber: cfe-commits. Herald added a subscriber: aemerson. This test takes input from a file rather than from stdin and then goes on to check for a label "bar". This could match

Re: [PATCH] D13496: Convert test to take input from stdin rather than reading a file

richard.barton.arm abandoned this revision. richard.barton.arm added a comment. Abandoning as I forgot to add cfe-commits. http://reviews.llvm.org/D13496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12614: [OpenMP] Offloading descriptor registration and device codegen.

sfantao updated this revision to Diff 36812. sfantao added a comment. Rebase and fix typo in regression test directive. http://reviews.llvm.org/D12614 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Basic/LangOptions.def include/clang/Basic/LangOptions.h

r249658 - Use itostr(), not std::to_string() because of Android.

Author: dougk Date: Thu Oct 8 00:25:03 2015 New Revision: 249658 URL: http://llvm.org/viewvc/llvm-project?rev=249658=rev Log: Use itostr(), not std::to_string() because of Android. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL:

Re: r249639 - Make clang_Cursor_getMangling not mangle if the declaration isn't mangled

FYI, this caused a -Wdeclaration-after-statement warning that I fixed in r249652. On Wed, Oct 7, 2015 at 5:01 PM, Ehsan Akhgari via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ehsan > Date: Wed Oct 7 19:01:20 2015 > New Revision: 249639 > > URL:

r249647 - [WinEH] Remove NewMSEH and enable its behavior by default

Author: rnk Date: Wed Oct 7 20:13:52 2015 New Revision: 249647 URL: http://llvm.org/viewvc/llvm-project?rev=249647=rev Log: [WinEH] Remove NewMSEH and enable its behavior by default Testing has shown that it is at least as reliable as the old landingpad pattern matching code. Removed:

r249640 - Don't emit exceptional stackrestore cleanups around inalloca functions

Author: rnk Date: Wed Oct 7 19:17:45 2015 New Revision: 249640 URL: http://llvm.org/viewvc/llvm-project?rev=249640=rev Log: Don't emit exceptional stackrestore cleanups around inalloca functions The backend restores the stack pointer after recovering from an exception. This is similar to

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

rsmith added inline comments. Comment at: include/clang/Basic/Attr.td:2098-2102 @@ +2097,7 @@ + let Documentation = [OMPDeclareSimdDocs]; + let AdditionalMembers = [{ + void printPrettyPragma(raw_ostream , const PrintingPolicy ) const { +OS << "\n"; + } + }]; +}

Re: [PATCH] D9888: [OPENMP] Driver support for OpenMP offloading

tra added a comment. In http://reviews.llvm.org/D9888#257904, @sfantao wrote: > This diff refactors the original patch and is rebased on top of the latests > offloading changes inserted for CUDA. > > Here I don't touch the CUDA support. I tried, however, to have the > implementation modular

Re: [PATCH] D9888: [OPENMP] Driver support for OpenMP offloading

sfantao added a comment. Art, Jonas, Thanks for the comments! In http://reviews.llvm.org/D9888#261434, @Hahnfeld wrote: > Currently trying to test, but > > 1. Offloading to the same target isn't supported (`x86_64-unknown-linux-gnu` > as host and device) - this was working with `clang-omp`

Re: [PATCH] D13440: [clang-tidy] Python script for easy check rename

alexfh added inline comments. Comment at: clang-tidy/rename_check.py:53 @@ +52,3 @@ + return newFileName + +def getListOfFiles(clang_tidy_path): ClockMan wrote: > Not sure what you mean... I meant that after that patch the module file name can be more complex.

Re: [PATCH] D9888: [OPENMP] Driver support for OpenMP offloading

sfantao updated this revision to Diff 36816. sfantao added a comment. Make the offloading ELF sections consistent with what is in http://reviews.llvm.org/D12614. Fix bug in AtTopLevel flag, so that the bundling job is considered always top level job. Fix several typos.

Re: [PATCH] D13399: [CMake] Bug 14109 - CMake build for compiler-rt should use just-built clang

samsonov added inline comments. Comment at: runtime/CMakeLists.txt:41 @@ +40,3 @@ + + add_custom_target(compiler-rt-clear +DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/compiler-rt-cleared So, that's the target that you can invoke manually to clean compiler-rt build?

Re: [PATCH] D13440: [clang-tidy] Python script for easy check rename

mgehre added a subscriber: mgehre. Comment at: clang-tidy/rename_check.py:39 @@ +38,3 @@ + if len(sys.argv) != 4: +print('Usage: rename_check.py , e.g.\n') +print('rename_check.py misc awesome-functions new-awesome-function\n') Should be ``` Usage:

Re: [PATCH] D13440: [clang-tidy] Python script for easy check rename

alexfh added inline comments. Comment at: clang-tidy/rename_check.py:3 @@ +2,3 @@ +# +#===- add_new_check.py - clang-tidy check generator --*- python -*--===# +# Please update the script name and description in the comment. Comment at:

Re: [PATCH] D13523: ASTMatchers: Keep AllCallbacks in a set instead of a vector

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. That makes a lot of sense. LG http://reviews.llvm.org/D13523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r249593 - While researching LWG#2244, I noticed we weren't testing that eofbit was being cleared. Now we are

Author: marshall Date: Wed Oct 7 14:41:24 2015 New Revision: 249593 URL: http://llvm.org/viewvc/llvm-project?rev=249593=rev Log: While researching LWG#2244, I noticed we weren't testing that eofbit was being cleared. Now we are Modified:

[libcxx] r249595 - Mark 2244 as 'Patch Ready', 2477 and 2487 as 'Complete'

Author: marshall Date: Wed Oct 7 14:45:14 2015 New Revision: 249595 URL: http://llvm.org/viewvc/llvm-project?rev=249595=rev Log: Mark 2244 as 'Patch Ready', 2477 and 2487 as 'Complete' Modified: libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/kona.html URL:

r249535 - Make the test take input from stdin to prevent matching characters in a file path

Author: rbarton Date: Wed Oct 7 05:33:36 2015 New Revision: 249535 URL: http://llvm.org/viewvc/llvm-project?rev=249535=rev Log: Make the test take input from stdin to prevent matching characters in a file path Modified: cfe/trunk/test/OpenMP/for_simd_codegen.cpp Modified:

r249538 - Silence warning about not being able to find clang-interpreter

Author: rbarton Date: Wed Oct 7 06:14:25 2015 New Revision: 249538 URL: http://llvm.org/viewvc/llvm-project?rev=249538=rev Log: Silence warning about not being able to find clang-interpreter This binary is only built with the examples project, so only require it then. Modified:

r249532 - [VFS] Refactor VFSFromYAML a bit.

Author: d0k Date: Wed Oct 7 05:05:44 2015 New Revision: 249532 URL: http://llvm.org/viewvc/llvm-project?rev=249532=rev Log: [VFS] Refactor VFSFromYAML a bit. - Rename it to RedirectingFileSystem. This is what it does, YAML is just a serialization format for it. - Consistently use unique_ptr

r249534 - Fix crash in codegen on casting to `bool &`.

Author: abataev Date: Wed Oct 7 05:22:08 2015 New Revision: 249534 URL: http://llvm.org/viewvc/llvm-project?rev=249534=rev Log: Fix crash in codegen on casting to `bool &`. Currently codegen crashes trying to emit casting to bool &. It happens because bool type is converted to i1 and later then

Re: [PATCH] D13325: Fix crash in codegen on casting to `bool &`.

This revision was automatically updated to reflect the committed changes. Closed by commit rL249534: Fix crash in codegen on casting to `bool &`. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D13325?vs=36179=36725#toc Repository: rL LLVM

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

I think, it would be more consistent to have clang-tidy insert a link to the check documentation (on llvm.org) into each warning. The documentation pages already contain links to the relevant rules. We could even version documentation pages, if we think it's important (but afaiu,

Re: [PATCH] D13498: Silence spurious warning from lit about missing clang-interpreter

rengolin added a subscriber: rengolin. rengolin accepted this revision. rengolin added a reviewer: rengolin. rengolin added a comment. This revision is now accepted and ready to land. Makes sense. LGTM. Thanks! http://reviews.llvm.org/D13498 ___

Re: [PATCH] D13504: Prevent modernize-use-auto from emitting a warning when 'auto' was already being used.

alexfh added inline comments. Comment at: test/clang-tidy/modernize-use-auto-new.cpp:100 @@ -98,1 +99,3 @@ + // Don't warn when 'auto' is already being used. + auto aut = new MyType(); } Please add tests for `auto *` and `const auto *`.

[PATCH] D13504: Prevent modernize-use-auto from emitting a warning when 'auto' was already being used.

angelgarcia created this revision. angelgarcia added reviewers: klimek, bkramer. angelgarcia added subscribers: alexfh, cfe-commits. This fixes https://llvm.org/bugs/show_bug.cgi?id=25082 . http://reviews.llvm.org/D13504 Files: clang-tidy/modernize/UseAutoCheck.cpp

Re: [PATCH] D13504: Prevent modernize-use-auto from emitting a warning when 'auto' was already being used.

angelgarcia updated this revision to Diff 36724. angelgarcia added a comment. Good point. Solved. http://reviews.llvm.org/D13504 Files: clang-tidy/modernize/UseAutoCheck.cpp test/clang-tidy/modernize-use-auto-new.cpp Index: test/clang-tidy/modernize-use-auto-new.cpp

[clang-tools-extra] r249540 - Add checker for the C++ Core Guidelines: cppcoreguidelines-pro-type-const-cast.

Author: aaronballman Date: Wed Oct 7 07:24:57 2015 New Revision: 249540 URL: http://llvm.org/viewvc/llvm-project?rev=249540=rev Log: Add checker for the C++ Core Guidelines: cppcoreguidelines-pro-type-const-cast. Patch by Matthias Gehre! Added:

Re: [PATCH] D13398: [clang-tidy] add check cppcoreguidelines-pro-type-const-cast

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the patch! I've commit in r249540. Given the number of checkers that you're working on, I would recommend getting commit privileges if you'd like them. http://reviews.llvm.org/D13398

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. On Tue, Oct 6, 2015 at 5:46 PM, Matthias Gehre wrote: > mgehre marked an inline comment as done. > mgehre added a comment. > > I cannot think of any way to

Re: [PATCH] D13304: Avoid inlining in throw statement

junbuml added a comment. Is there any comment on this change? Note that with change, I observed about 6% performance improvement in spec2006/xalancbmk. I will address any comment to get this in. http://reviews.llvm.org/D13304 ___ cfe-commits

Re: [PATCH] D13398: [clang-tidy] add check cppcoreguidelines-pro-type-const-cast

On Tue, Oct 6, 2015 at 11:07 PM, Alexander Kornienko wrote: > alexfh added a comment. > > It looks like potentially we're going to have tens of checks in this module. > I wonder whether we should start organizing the checks somehow right away. > For example, create a

Re: r249392 - clang-format: Make IncludeCategories configurable in .clang-format file.

On Wed, Oct 7, 2015 at 9:07 AM, Daniel Jasper wrote: > Should be fixed now. Sorry about that. No worries, thank you for the quick fix! ~Aaron > > On Wed, Oct 7, 2015 at 3:00 PM, Aaron Ballman > wrote: >> >> I am now getting sphinx warnings from this

Re: r249392 - clang-format: Make IncludeCategories configurable in .clang-format file.

Should be fixed now. Sorry about that. On Wed, Oct 7, 2015 at 3:00 PM, Aaron Ballman wrote: > I am now getting sphinx warnings from this commit: > > > /opt/llvm/build-llvm/src/llvm/tools/clang/docs/ClangFormatStyleOptions.rst:159: > ERROR: Error in "code-block"

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

pgousseau added a comment. For some reasons the patch file I get from the "download raw diff link" does not contain the diff for the added .keep files? But the .keep files show up in phabricator, so I guess it is a phabricator issue? Repository: rL LLVM http://reviews.llvm.org/D13482

[PATCH] D13510: [PATCH] Support C++ Core Guidelines copy assignment restrictions

aaron.ballman created this revision. aaron.ballman added reviewers: Eugene.Zelenko, alexfh, mgehre, sbenza. aaron.ballman added a subscriber: cfe-commits. Eugene pointed out to me that our existing misc-assign-operator-signature check was almost perfectly implementing the C++ Core Guideline

r249542 - clang-format: Hopefully fix code blocks in docs.

Author: djasper Date: Wed Oct 7 08:02:45 2015 New Revision: 249542 URL: http://llvm.org/viewvc/llvm-project?rev=249542=rev Log: clang-format: Hopefully fix code blocks in docs. Otherwise I will have to install sphinx ;).. Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst

Re: [PATCH] D13311: [clang-tidy] Add check cppcoreguidelines-pro-bounds-pointer-arithmetic

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. On Tue, Oct 6, 2015 at 5:31 PM, Matthias Gehre wrote: > mgehre marked 2 inline comments as done. > > > Comment at: >

Re: r249392 - clang-format: Make IncludeCategories configurable in .clang-format file.

I am now getting sphinx warnings from this commit: /opt/llvm/build-llvm/src/llvm/tools/clang/docs/ClangFormatStyleOptions.rst:159: ERROR: Error in "code-block" directive: maximum 1 argument(s) allowed, 3 supplied. .. code-block:: c++ someLongFunction(argument1, argument2);

r249552 - [clang-format] Stop alignment sequences on open braces and parens when

Author: djasper Date: Wed Oct 7 10:03:26 2015 New Revision: 249552 URL: http://llvm.org/viewvc/llvm-project?rev=249552=rev Log: [clang-format] Stop alignment sequences on open braces and parens when aligning assignments. This was done correctly when aligning the declarations, but not when

Re: [PATCH] D13513: [clang-format] Stop alignment sequences on open braces and parens when aligning assignments.

berenm added inline comments. Comment at: unittests/Format/FormatTest.cpp:8657 @@ +8656,3 @@ + "};\n" + "int i = 0;\n" + "auto v = type{\n" djasper wrote: > So, it is kind of interesting that we (would) align with a

[clang-tools-extra] r249555 - Loosening the restriction on variadic function definitions so that extern "C" function definitions are permissible.

Author: aaronballman Date: Wed Oct 7 10:14:10 2015 New Revision: 249555 URL: http://llvm.org/viewvc/llvm-project?rev=249555=rev Log: Loosening the restriction on variadic function definitions so that extern "C" function definitions are permissible. Modified:

Re: [PATCH] D12358: [Analyzer] Handling constant bound loops

seaneveson marked 4 inline comments as done. seaneveson added a comment. There are some issues which haven't been resolved yet: - There is a loss of precision for loops that need to be executed exactly maxBlockVisitOnPath times, as the loop body is executed with the widened state **instead**

Re: [PATCH] D13513: [clang-format] Stop alignment sequences on open braces and parens when aligning assignments.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good, thank you. Comment at: unittests/Format/FormatTest.cpp:8657 @@ +8656,3 @@ + "};\n" + "int i = 0;\n" + "auto v =

Re: [PATCH] D13513: [clang-format] Stop alignment sequences on open braces and parens when aligning assignments.

djasper closed this revision. djasper added a comment. Submitted as r249552. http://reviews.llvm.org/D13513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13221: Make CompilerInvocation's use of the debug options more understandable.

dougk marked an inline comment as done. dougk added a comment. James, you're right, 'gdwarf-2' followed by 'line-tables-only' works, but the opposite order doesn't. So it halfway works, which is better than not working at all. Comment at: lib/Driver/Tools.cpp:2353 @@ +2352,3

Re: [PATCH] D12358: [Analyzer] Handling constant bound loops

seaneveson updated this revision to Diff 36739. seaneveson added a comment. Updated to latest revision. Change patch to widen all loops which do not exit. Changed to widen on block entrance so the guard condition is accounted for (thanks for the suggestion). Updated tests to reflect changes.

[PATCH] D13513: [clang-format] Stop alignment sequences on open braces and parens when aligning assignments.

berenm created this revision. berenm added a reviewer: djasper. berenm added a subscriber: cfe-commits. Herald added a subscriber: klimek. This was done correctly when aligning the declarations, but not when aligning assignments. FIXME: The code between assignments and declarations alignment is

Re: [PATCH] D13351: [Power PC] add soft float support for ppc32

spetrovic updated this revision to Diff 36763. http://reviews.llvm.org/D13351 Files: include/clang/Basic/TargetInfo.h lib/Basic/Targets.cpp lib/CodeGen/TargetInfo.cpp lib/Driver/Tools.cpp lib/Driver/Tools.h test/CodeGen/ppc-sfvarargs.c test/Driver/ppc-features.cpp Index:

Re: [clang-tools-extra] r249399 - Add a new module for the C++ Core Guidelines, and the first checker for those guidelines: cppcoreguidelines-pro-type-reinterpret-cast.

On Wed, Oct 7, 2015 at 12:05 PM, Joerg Sonnenberger via cfe-commits wrote: > On Tue, Oct 06, 2015 at 01:31:01PM -, Aaron Ballman via cfe-commits wrote: >> Log: >> Add a new module for the C++ Core Guidelines, and the first checker >> for those guidelines:

Re: [PATCH] D12793: Three new overflow builtins with generic argument types

DavidEGrayson marked an inline comment as done. DavidEGrayson added a comment. Well, it has been another week. John, I don't have commit access, so can you commit this? Thanks! Let me know if the patch doesn't apply cleanly or any tests fail. http://reviews.llvm.org/D12793

Re: [PATCH] D13510: [PATCH] Support C++ Core Guidelines copy assignment restrictions

aaron.ballman added a comment. In http://reviews.llvm.org/D13510#261825, @Eugene.Zelenko wrote: > I think it'll be fine to rename check without leaving traces of misc. Same > thing happened with modernize-shrink-to-fit. I think the difference here is that many C++ Core Guideline checks are...

r249556 - [VFS] Port driver tool chains to VFS.

Author: d0k Date: Wed Oct 7 10:48:01 2015 New Revision: 249556 URL: http://llvm.org/viewvc/llvm-project?rev=249556=rev Log: [VFS] Port driver tool chains to VFS. There are still some loose ends here but it's sufficient so we can detect GCC headers that are inside of a VFS. Added:

Re: [clang-tools-extra] r249399 - Add a new module for the C++ Core Guidelines, and the first checker for those guidelines: cppcoreguidelines-pro-type-reinterpret-cast.

On Tue, Oct 06, 2015 at 01:31:01PM -, Aaron Ballman via cfe-commits wrote: > Log: > Add a new module for the C++ Core Guidelines, and the first checker > for those guidelines: cppcoreguidelines-pro-type-reinterpret-cast. I wonder about the generality of this. Does it really make sense to flag

Re: [PATCH] D13221: Make CompilerInvocation's use of the debug options more understandable.

dblaikie added a subscriber: dblaikie. dblaikie accepted this revision. dblaikie added a reviewer: dblaikie. This revision is now accepted and ready to land. Comment at: test/Driver/clang-g-opts.c:33 @@ -22,5 +32,3 @@ -// CHECK-WITHOUT-G-NOT: "-g" -// CHECK-WITH-G: "-g" -//

Re: r248949 - Don't inherit availability information when implementing a protocol requirement.

Hi Doug, On Wed, Sep 30, 2015 at 2:27 PM, Douglas Gregor via cfe-commits wrote: > Author: dgregor > Date: Wed Sep 30 16:27:42 2015 > New Revision: 248949 > > URL: http://llvm.org/viewvc/llvm-project?rev=248949=rev > Log: > Don't inherit availability information when

Re: [PATCH] D11328: [clang-tidy] new "throw-by-value-catch-by-reference" check for clang-tidy

aaron.ballman added a comment. This patch is looking much closer! Thank you for continuing to work on it. I found several mechanical changes that need to be made, like style, comments, formatting, isa<> followed by cast<>, etc. There is one logic issue regarding materialized temporaries that I

[PATCH] D13525: [CodeGen] Attach function attributes to functions created in CGBlocks.cpp.

ahatanak created this revision. ahatanak added reviewers: dexonsmith, echristo. ahatanak added a subscriber: cfe-commits. This patch makes changes to attach function attributes to the following functions created in CGBlocks.cpp: __copy_helper_block_ __destroy_helper_block_

Re: [PATCH] D13221: Make CompilerInvocation's use of the debug options more understandable.

dougk marked an inline comment as done. dougk added a comment. http://reviews.llvm.org/D13221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D13523: ASTMatchers: Keep AllCallbacks in a set instead of a vector

djasper created this revision. djasper added a reviewer: klimek. djasper added a subscriber: cfe-commits. Herald added a subscriber: klimek. AllCallbacks is currently only used to call onStartOfTranslationUnit and onEndOfTranslationUnit on them. In this (and any other scenario I can come up

Re: [PATCH] D13510: [PATCH] Support C++ Core Guidelines copy assignment restrictions

Eugene.Zelenko added a comment. I think it'll be fine to rename check without leaving traces of misc. Same thing happened with modernize-shrink-to-fit. http://reviews.llvm.org/D13510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

sbenza added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-pro-type-static-cast-downcast.cpp:28 @@ +27,3 @@ + + auto P0 = static_cast(new Base()); + // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: do not use static_cast to downcast from a base to a

[PATCH] D13516: Fix overlapping replacements in clang-tidy.

angelgarcia created this revision. angelgarcia added reviewers: klimek, bkramer. angelgarcia added subscribers: alexfh, cfe-commits. Prevent clang-tidy from applying fixes to errors that overlap with other errors' fixes, with one exception: if one fix is completely contained inside another one,