Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

rengolin added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:458 @@ +457,3 @@ +StringRef Value = A->getValue(); +bool Valid = llvm::StringSwitch(Value) + .Case("default", true) tinti wrote: > tinti wrote: > > compnerd wrote: > > >

[PATCH] D14285: [x86] Additional small fix for MCU psABI support

andreybokhanko created this revision. andreybokhanko added reviewers: rnk, DavidKreitzer, mkuper. andreybokhanko added a subscriber: cfe-commits. This patch fixes one more thing in MCU psABI support: LongDoubleWidth should be set to 64. http://reviews.llvm.org/D14285 Files:

r251949 - Simplify Sema::ProcessPropertyDecl. NFC

Author: dgregor Date: Tue Nov 3 11:02:34 2015 New Revision: 251949 URL: http://llvm.org/viewvc/llvm-project?rev=251949=rev Log: Simplify Sema::ProcessPropertyDecl. NFC Now that the properties created within Objective-C class extensions go into the extension themselves, we don't need any of the

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

martell added a comment. > This is what I'm worried about. :) Can you elaborate on what would break? Essentially mingw-w64 has a few header defines for working around builtings such as __rtdsc and the interlocked functions and some other builtins As soon as one of these headers are included it

r251953 - Revert "Support watchOS and tvOS in compiler-rt builds"

Author: tnorthover Date: Tue Nov 3 12:14:42 2015 New Revision: 251953 URL: http://llvm.org/viewvc/llvm-project?rev=251953=rev Log: Revert "Support watchOS and tvOS in compiler-rt builds" The required compiler-rt changes aren't present yet so attempting to build with compiler-rt breaks. And

Re: [PATCH] D13446: [PATCH] Add checker discouraging definition of variadic function definitions in C++

Apologies, I will try to take a look today On Tue, Nov 3, 2015, 10:05 AM Aaron Ballman wrote: > On Tue, Nov 3, 2015 at 7:19 AM, Alexander Kornienko > wrote: > > On Fri, Oct 9, 2015 at 12:13 PM, Aaron Ballman > > wrote: > >>

Re: [PATCH] D13304: Avoid inlining in throw statement

junbuml added a comment. The basic idea of this change is to avoid inlining callsites invoked in exception handling regions (EHR) so that we can reduce code size blow-up in very cold regions and indirectly increase inline opportunities for functions containing exception handling code. I think

[PATCH] D14292: [libcxx] Make it possible to build a no-exceptions variant of libcxx.

rmaprath created this revision. rmaprath added reviewers: rengolin, mclow.lists. rmaprath added a subscriber: cfe-commits. Fixes a small omission in libcxx that prevents libcxx being built when -DLIBCXX_ENABLE_EXCEPTIONS=0 is used. I will do a follow-up patch to introduce the new libc++ build

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

rnk added a comment. In http://reviews.llvm.org/D14180#279962, @martell wrote: > In http://reviews.llvm.org/D14180#279651, @rnk wrote: > > > Will Clang be able to compile the last few stable mingw-w64 releases with > > this change? I'd like that to keep working. > > > Clang has not been able to

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

martell added a comment. In http://reviews.llvm.org/D14180#280184, @rnk wrote: > You're mostly interested in the non-builtin parts of -fms-extensions, like > declspec and UUID, right? Yes that would be one of the main reasons, gcc is very lacking in this department :) > You can then change

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

rmaprath added a comment. PS: I've run a couple of hand-crafted builders on a locally hacked up buildbot and made sure the above changes are fine. http://reviews.llvm.org/D14293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14285: [x86] Additional small fix for MCU psABI support

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D14285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12031: Const std::move() argument ClangTidy check

dvadym added a comment. Thanks alexfh and sbenza for comments! I've addressed most of them. Could you please advice how to find that some expression has type which is template dependent? Regards, Vadym Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:20 @@ +19,3 @@ +

r251966 - [analyzer] Move the ObjCGenericsChecker out of the alpha package.

Author: dcoughlin Date: Tue Nov 3 13:38:03 2015 New Revision: 251966 URL: http://llvm.org/viewvc/llvm-project?rev=251966=rev Log: [analyzer] Move the ObjCGenericsChecker out of the alpha package. It is now in the osx.cocoa package and so will be on by default for Apple toolchains. Modified:

Re: [PATCH] D12031: Const std::move() argument ClangTidy check

dvadym updated the summary for this revision. dvadym updated this revision to Diff 39077. dvadym marked 6 inline comments as done. dvadym added a comment. 1.Most comments addressed 2.Taking into consideration applying move to trivially copyable objects 3.Different message if move argument

Re: [PATCH] D13446: [PATCH] Add checker discouraging definition of variadic function definitions in C++

On Tue, Nov 3, 2015 at 7:19 AM, Alexander Kornienko wrote: > On Fri, Oct 9, 2015 at 12:13 PM, Aaron Ballman > wrote: >> >> On Fri, Oct 9, 2015 at 3:09 PM, Daniel Berlin wrote: >> > dberlin added a subscriber: dberlin. >> > >> >

[PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

rmaprath created this revision. rmaprath added reviewers: rengolin, gribozavr, gkistanova, EricWF. rmaprath added a subscriber: cfe-commits. This patch adds the necessary builders to zorg to get the -fno-exceptions libcxx library variant building. I've only used those build-slaves which I have

Re: [PATCH] D14291: Improve modernize-make-unique matcher.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D14291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D14291: Improve modernize-make-unique matcher.

angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: cfe-commits, alexfh. "std::unique_ptr" is not the same type as "std::unique_ptr", unless we insert a "hasCanonicalType" in the middle. Probably it also happens in

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

rnk added a comment. I'd like clang to work out of the box with mingw-w64 releases from at least the past year. You're mostly interested in the non-builtin parts of -fms-extensions, like declspec and UUID, right? One way we could do this is to enable -fms-extensions in mingw but then suppress

Re: [PATCH] D12031: Const std::move() argument ClangTidy check

dvadym updated this revision to Diff 39080. dvadym marked an inline comment as done. dvadym added a comment. Small clean-up http://reviews.llvm.org/D12031 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/MoveConstantArgumentCheck.cpp

Re: [PATCH] D14172: [libcxx] Make it possible to build a no-exceptions variant of libcxx.

rmaprath abandoned this revision. rmaprath added a comment. Abandoning revision as it seems I cannot add subscribers/reviewers to existing phab reviews. http://reviews.llvm.org/D14172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14266: CodeGen: Update for debug info API change.Depends on D14265.

This LGTM (although obviously gated on LLVM changes). > On 2015-Nov-02, at 16:28, Peter Collingbourne wrote: > > pcc created this revision. > pcc added a reviewer: dexonsmith. > pcc added a subscriber: cfe-commits. > > http://reviews.llvm.org/D14266 > > Files: >

Re: [PATCH] D12031: Const std::move() argument ClangTidy check

aaron.ballman added a subscriber: aaron.ballman. Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:1 @@ +1,2 @@ +#include "MoveConstantArgumentCheck.h" + Missing new file legal text. Comment at:

r251955 - Introduce module file extensions to piggy-back data onto module files.

Author: dgregor Date: Tue Nov 3 12:33:07 2015 New Revision: 251955 URL: http://llvm.org/viewvc/llvm-project?rev=251955=rev Log: Introduce module file extensions to piggy-back data onto module files. Introduce the notion of a module file extension, which introduces additional information into a

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

gribozavr added a comment. The Debian configuration LGTM. http://reviews.llvm.org/D14293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13304: Avoid inlining in throw statement

rsmith added a comment. I am not convinced that it's reasonable to put inlining heuristics into clang's IR generation. This will cause maintenance problems for the inliner in the future (anyone tuning the inlining heuristics and thresholds will need to be aware of this, and clang will behave

Re: [PATCH] D14164: Driver: fallback to parent directory of clang if no sysroot for mingw-w64 target

yaron.keren added a subscriber: cfe-commits. yaron.keren added a comment. We did not have cfe-commits as subscriber so I'm adding it now (this is a clang commit), see if someone would like to further comment. http://reviews.llvm.org/D14164 ___

[PATCH] D14303: [analyzer] Add 'optin' checker package and move localizability checkers into it.

dcoughlin created this revision. dcoughlin added reviewers: zaks.anna, krememek. dcoughlin added a subscriber: cfe-commits. This patch creates a new 'optin' top-level checker package and moves several of the localizability checkers into it. This package is for checkers that are not alpha and

Re: [PATCH] D14179: Remove some legacy mingw-w64 gcc struct info

chapuni added a comment. Sorry, I supposed someone removed it. It was really buggy in past. Repository: rL LLVM http://reviews.llvm.org/D14179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D14307: AMDGPU: Add support for 's' and 'v' asm constraints

tstellarAMD created this revision. tstellarAMD added reviewers: echristo, arsenm. tstellarAMD added a subscriber: cfe-commits. 's' is used to specify sgprs and 'v' is used to specify vgprs. http://reviews.llvm.org/D14307 Files: lib/Basic/Targets.cpp test/Sema/inline-asm-validate-amdgpu.cl

Re: [PATCH] D13099: [Analyzer] Don’t invalidate CXXThis when conservatively evaluating const methods (PR 21606)

dcoughlin added a comment. This patch seems to have caused a regression. https://llvm.org/bugs/show_bug.cgi?id=25392 Repository: rL LLVM http://reviews.llvm.org/D13099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

tinti set the repository for this revision to rL LLVM. tinti updated this revision to Diff 39108. tinti added a comment. - Clang format code. - Update eabi names to match new LLVM patch. Repository: rL LLVM http://reviews.llvm.org/D14184 Files: include/clang/Driver/Options.td

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

jroelofs added a subscriber: jroelofs. Comment at: buildbot/osuosl/master/config/builders.py:771 @@ +770,3 @@ + # the -fno-exceptions library build. + additional_features={'no-libcxx-tests'}), + 'category': 'libcxx'}, How bad is

Re: [PATCH] D13304: Avoid inlining in throw statement

mcrosier added a comment. @chandlerc: Adding Chandler in case he has an opinion on how to move forward or how we could go about tuning the cold threshold. http://reviews.llvm.org/D13304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

rmaprath added inline comments. Comment at: buildbot/osuosl/master/config/builders.py:771 @@ +770,3 @@ + # the -fno-exceptions library build. + additional_features={'no-libcxx-tests'}), + 'category': 'libcxx'}, jroelofs wrote: >

Re: [PATCH] D14277: [Analyzer] Make referenced SymbolMetadata live even if its region is dead

jordan_rose added a comment. The intent here was that a metadata symbol represents //metadata about a region.// That means if the region is dead, and the symbol isn't directly referenceable, we won't be able to recreate it. The advantage of `&&` was that checkers didn't have to track when

Re: [PATCH] D13304: Avoid inlining in throw statement

junbuml added a comment. Thanks Richard for your comment ! If the frond-end is not a good to place for this, I think there are two places we can consider : inliner or prune-eh. 1. In inliner, we can directly check if a CallSite branches an exception region, and then make getInlineThreshold()

Re: [PATCH] D14179: Remove some legacy mingw-w64 gcc struct info

martell added a comment. From what I can gather it made sense at the time of gcc 4.6 so I don't think anyone is at fault :) Repository: rL LLVM http://reviews.llvm.org/D14179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

On Tue, Nov 3, 2015 at 7:23 PM, Richard Smith wrote: > rsmith added inline comments. > > > Comment at: include/clang/Basic/AttrDocs.td:1628 > @@ +1627,3 @@ > +The ``internal_linkage`` attribute changes the linkage type of the > declaration to internal. >

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

eugenis added inline comments. Comment at: lib/AST/Decl.cpp:635-641 @@ -634,2 +634,9 @@ assert(!isa(D) && "Didn't expect a FieldDecl!"); + for (const DeclContext *DC = D->getDeclContext(); + !isa(DC); DC = DC->getParent()) { +const NamespaceDecl *ND =

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

rsmith added inline comments. Comment at: include/clang/Basic/AttrDocs.td:1628 @@ +1627,3 @@ +The ``internal_linkage`` attribute changes the linkage type of the declaration to internal. +This is similar to C-style ``static``, but can be used on classes and class methods +This

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

On Tue, Nov 3, 2015 at 7:44 PM, Richard Smith wrote: > On Tue, Nov 3, 2015 at 4:37 PM, Aaron Ballman via cfe-commits > wrote: >> >> On Tue, Nov 3, 2015 at 7:23 PM, Richard Smith >> wrote: >> > rsmith added inline

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

eugenis updated this revision to Diff 39135. eugenis marked 2 inline comments as done. Repository: rL LLVM http://reviews.llvm.org/D13925 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Sema/Sema.h lib/AST/Decl.cpp lib/Sema/SemaDecl.cpp

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

eugenis updated this revision to Diff 39124. eugenis marked 5 inline comments as done. eugenis added a comment. Disabled the new attribute on namespaces. Repository: rL LLVM http://reviews.llvm.org/D13925 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

Re: [PATCH] D13304: Avoid inlining in throw statement

manmanren added a subscriber: manmanren. manmanren added a comment. Inliner currently does not include analysis passes such as BPI and BFI. With the new pass manager, we should be able to hook up inliner with BFI (and we can handle throw in BFI). Before that, maybe we can add this as part of

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

On Tue, Nov 3, 2015 at 4:37 PM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Tue, Nov 3, 2015 at 7:23 PM, Richard Smith > wrote: > > rsmith added inline comments. > > > > > > Comment at: include/clang/Basic/AttrDocs.td:1628 > >

[PATCH] D14311: [Clang] Fix some Clang-tidy modernize warnings, other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: hans. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Herald added subscribers: dschuff, jfb. Fixed warnings are: modernize-use-override, modernize-use-nullptr

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

eugenis updated this revision to Diff 39128. eugenis added a comment. One more test for forward declarations. Repository: rL LLVM http://reviews.llvm.org/D13925 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Sema/Sema.h lib/AST/Decl.cpp

Re: [PATCH] D12473: [clang-tidy] Add old style function check

alexfh added a comment. Apparently, I forgot to submit the comments a looong time ago. Sorry for the delay. In http://reviews.llvm.org/D12473#236401, @alexfh wrote: > A high-level comment: > > It seems that the scope of the check is artificially made too narrow. The > check could actually

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

majnemer updated this revision to Diff 39153. majnemer added a comment. - Address Richard's latest comments http://reviews.llvm.org/D13786 Files: include/clang/AST/ASTContext.h include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/DeclTemplate.h

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Please add a test for serialization/deserialization of this declaration. Otherwise, this looks fine. Comment at: include/clang/Serialization/ASTBitCodes.h:994 @@ -990,3

Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

RedX2501 updated this revision to Diff 39158. RedX2501 added a comment. Added module tests to libclang and python. http://reviews.llvm.org/D10833 Files: bindings/python/clang/cindex.py bindings/python/tests/cindex/test_cursor.py include/clang-c/Index.h

Re: [PATCH] D10834: Added functions to retrieve information about whether a vardecl is local in libclang and its python bindings.

RedX2501 retitled this revision from "Added functions to retrieve information about variable storage in libclang and its python bindings." to "Added functions to retrieve information about whether a vardecl is local in libclang and its python bindings.". RedX2501 updated this revision to Diff

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

majnemer updated this revision to Diff 39145. majnemer added a comment. - Add an llvm_unreachable to ASTDeclReader::VisitBuiltinTemplateDecl - Address Richard's review comments. - Add logic to check [intseq.intseq]p1. - Remove TemplateName::BuiltinTemplate - Rename BuiltinTemplateNameKind to

[PATCH] D14316: [Concepts] Add diagnostics which fall under [dcl.spec.concept]p1

nwilson created this revision. nwilson added reviewers: rsmith, hubert.reinterpretcast, aaron.ballman, faisalv. nwilson added a subscriber: cfe-commits. Diagnose when the 'concept' specifier is used on a typedef or function parameter. http://reviews.llvm.org/D14316 Files:

Re: [PATCH] D14316: [Concepts] Add diagnostics which fall under [dcl.spec.concept]p1

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D14316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

This revision was automatically updated to reflect the committed changes. Closed by commit rL252036: [Sema] Implement __make_integer_seq (authored by majnemer). Changed prior to commit: http://reviews.llvm.org/D13786?vs=39153=39154#toc Repository: rL LLVM http://reviews.llvm.org/D13786

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

rmaprath added inline comments. Comment at: buildbot/osuosl/master/config/builders.py:874 @@ -842,1 +873,3 @@ 'CMAKE_CXX_FLAGS': '-mcpu=cortex-a15'})}, + +# Cortex-A15 -fno-exceptions libcxx build (skips libcxx tests)

Re: [PATCH] D12031: Const std::move() argument ClangTidy check

alexfh added inline comments. Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:22 @@ +21,3 @@ + bool IsTypeDependOnTemplateParameter = + false; // my first guess was type->getTypeClass () == 30 but it doesn't + // work in some cases. Could you please

Re: [PATCH] D13388: Add support for querying the visibility of a cursor

skalinichev added a comment. Well, I think it's ok then. Still there is no test for visibility set from command line case. Also adding comment to clang_getCursorVisibility explaining that it also works with visibility set from command line would be very useful. Comment at:

Re: [PATCH] D13844: [libclang] Visit TypeAliasTemplateDecl

skalinichev added a comment. Yes, I have commit acces now (didn't test it yet though). I'll try to submit this patch soon. Thanks! http://reviews.llvm.org/D13844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r251930 - Remove some legacy mingw-w64 gcc struct info

Author: martell Date: Tue Nov 3 09:57:45 2015 New Revision: 251930 URL: http://llvm.org/viewvc/llvm-project?rev=251930=rev Log: Remove some legacy mingw-w64 gcc struct info As of gcc 4.7 mingw-w64 no longer emits 128-bit structs as i128 Differential Revision: http://reviews.llvm.org/D14179

[PATCH] D14289: Handle correctly containers that are data members in modernize-loop-convert.

angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: alexfh, cfe-commits. I recently found that the variable naming wasn't working as expected with containers that are data members. The new index always received the name "Elem" (or equivalent)

Re: [PATCH] D14282: Improve more the const-detection in modernize-loop-convert.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D14282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14179: Remove some legacy mingw-w64 gcc struct info

This revision was automatically updated to reflect the committed changes. Closed by commit rL251930: Remove some legacy mingw-w64 gcc struct info (authored by martell). Changed prior to commit: http://reviews.llvm.org/D14179?vs=38744=39067#toc Repository: rL LLVM

[PATCH] D14286: ASTImporter: expressions, pt.1

a.sidorin created this revision. a.sidorin added a reviewer: sepavloff. a.sidorin added a subscriber: cfe-commits. a.sidorin set the repository for this revision to rL LLVM. This patch implements some expression-related AST node import. This is the first patch in a series. Supported nodes:

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

martell added a comment. In http://reviews.llvm.org/D14180#279651, @rnk wrote: > Will Clang be able to compile the last few stable mingw-w64 releases with > this change? I'd like that to keep working. Clang has not been able to compile mingw-w64 crt for the last few releases. I have only

[PATCH] D14282: Improve more the const-detection in modernize-loop-convert.

angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: cfe-commits, alexfh. The previous change was focused in detecting when a non-const object was used in a constant way. Looks like I forgot the most important and trivial case: when the object

Re: [PATCH] D14014: Checker of proper vfork usage

ygribov updated this revision to Diff 39040. ygribov added a comment. Updated warning messages. http://reviews.llvm.org/D14014 Files: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerHelpers.h lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/Checkers.td

Re: [PATCH] D14014: Checker of proper vfork usage

ygribov marked 2 inline comments as done. ygribov added a comment. http://reviews.llvm.org/D14014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r251940 - Improve more the const-detection in modernize-loop-convert.

Author: angelgarcia Date: Tue Nov 3 10:31:36 2015 New Revision: 251940 URL: http://llvm.org/viewvc/llvm-project?rev=251940=rev Log: Improve more the const-detection in modernize-loop-convert. Summary: The previous change was focused in detecting when a non-const object was used in a constant

Re: [PATCH] D14282: Improve more the const-detection in modernize-loop-convert.

This revision was automatically updated to reflect the committed changes. Closed by commit rL251940: Improve more the const-detection in modernize-loop-convert. (authored by angelgarcia). Changed prior to commit: http://reviews.llvm.org/D14282?vs=39052=39074#toc Repository: rL LLVM

Re: [PATCH] D14289: Handle correctly containers that are data members in modernize-loop-convert.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D14289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14289: Handle correctly containers that are data members in modernize-loop-convert.

angelgarcia updated this revision to Diff 39075. angelgarcia added a comment. Merge with the latest revision. http://reviews.llvm.org/D14289 Files: clang-tidy/modernize/LoopConvertCheck.cpp clang-tidy/modernize/LoopConvertCheck.h clang-tidy/modernize/LoopConvertUtils.h

[clang-tools-extra] r251943 - Handle correctly containers that are data members in modernize-loop-convert.

Author: angelgarcia Date: Tue Nov 3 10:38:31 2015 New Revision: 251943 URL: http://llvm.org/viewvc/llvm-project?rev=251943=rev Log: Handle correctly containers that are data members in modernize-loop-convert. Summary: I recently found that the variable naming wasn't working as expected with