r253466 - [libclang] Add entry points that take a full command line including argv[0].

Author: d0k Date: Wed Nov 18 10:14:27 2015 New Revision: 253466 URL: http://llvm.org/viewvc/llvm-project?rev=253466=rev Log: [libclang] Add entry points that take a full command line including argv[0]. This provides both a more uniform interface and makes libclang behave like clang tooling wrt

r253467 - [Myriad]: insert -L paths into linker cmd only when they exist.

Author: dougk Date: Wed Nov 18 10:24:46 2015 New Revision: 253467 URL: http://llvm.org/viewvc/llvm-project?rev=253467=rev Log: [Myriad]: insert -L paths into linker cmd only when they exist. Differential Revision: http://reviews.llvm.org/D14754 Added:

[PATCH] D14779: Adding checker to detect excess padding in records

bcraig created this revision. bcraig added reviewers: zaks.anna, jordan_rose, xazax.hun. bcraig added a subscriber: cfe-commits. The intent of this checker is to generate a report for any class / structure that could reduce its padding by reordering the fields. This results in a very noisy

Re: r252853 - libclang: add clang_Cursor_getCXXManglings

On Tue, Nov 17, 2015 at 5:07 PM, Reid Kleckner wrote: > This introduced a memory leak, which I'm testing a patch for. > Oops, thanks. > Aside from that, did you get Doug to review this? We probably want to be > really careful about changing libclang's C API, so you should be

r253473 - Adding AST matchers for VarDecl storage durations. Can now determine whether a VarDecl has automatic, static, or thread storage duration. This also updates the documentation for matchers, w

Author: aaronballman Date: Wed Nov 18 11:05:39 2015 New Revision: 253473 URL: http://llvm.org/viewvc/llvm-project?rev=253473=rev Log: Adding AST matchers for VarDecl storage durations. Can now determine whether a VarDecl has automatic, static, or thread storage duration. This also updates the

Re: r253473 - Adding AST matchers for VarDecl storage durations. Can now determine whether a VarDecl has automatic, static, or thread storage duration. This also updates the documentation for matchers

On Wed, Nov 18, 2015 at 12:44 PM, Bruno Cardoso Lopes wrote: > Hi Aaron, > > This commit is failing tests due to assertions in the tests: > http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/13216 This was reverted in r253475 while I investigate. ~Aaron

Re: [PATCH] D14744: PR10235: support for vector mode attributes + warning

DmitryPolukhin updated this revision to Diff 40506. DmitryPolukhin marked 3 inline comments as done. http://reviews.llvm.org/D14744 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDeclAttr.cpp test/Sema/attr-mode-vector-types.c

Re: [PATCH] D14744: PR10235: support for vector mode attributes + warning

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks, this LGTM! ~Aaron http://reviews.llvm.org/D14744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12359: New warning -Wnonconst-parameter when a pointer parameter can be const

danielmarjamaki marked an inline comment as done. danielmarjamaki added a comment. Does anybody else think that this should be moved to clang-tidy? I believe that the noise level is very low when I scan various open source projects. My script tries to run clang on all projects in the debian

r253471 - [ARM] Support +feature targeting in -mcpu/-march

Author: brasmi01 Date: Wed Nov 18 10:33:48 2015 New Revision: 253471 URL: http://llvm.org/viewvc/llvm-project?rev=253471=rev Log: [ARM] Support +feature targeting in -mcpu/-march Added: cfe/trunk/test/Driver/arm-features.c (with props) Modified: cfe/trunk/lib/Driver/Tools.cpp

Re: [PATCH] D14773: [ARM] Support +feature targeting in -mcpu/-march

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. This looks good to me. Thanks! Repository: rL LLVM http://reviews.llvm.org/D14773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14744: PR10235: support for vector mode attributes + warning

DmitryPolukhin added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:3315 @@ +3314,3 @@ + llvm::APInt VectorSize(64, 0); + if (Str.size() >= 4 && Str[0] == 'V') { +// Minimal length of vector mode is 4: 'V' + NUMBER(>=1) + TYPE(>=2). aaron.ballman

Re: [PATCH] D14773: [ARM] Support +feature targeting in -mcpu/-march

bsmith closed this revision. bsmith added a comment. Thanks, committed as r253471. Repository: rL LLVM http://reviews.llvm.org/D14773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

danielmarjamaki updated this revision to Diff 40505. danielmarjamaki added a comment. I have problems with the "default" handling of expressions. I want to warn about loss of precision for such code: unsigned int x = 256; unsigned char c; c = x; The analyser tells me that the RHS value

Re: [PATCH] D12359: New warning -Wnonconst-parameter when a pointer parameter can be const

On Wed, Nov 18, 2015 at 7:41 AM, Daniel Marjamäki < cfe-commits@lists.llvm.org> wrote: > danielmarjamaki marked an inline comment as done. > danielmarjamaki added a comment. > > Does anybody else think that this should be moved to clang-tidy? > Yep > > I believe that the noise level is very

[PATCH] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

Hi Richard, This is an updated patch for allowing -fmodule-map-file to shadow implicitly found modules. I’ve tried to simplify things by just using the explicitness of the module rather than the original more-general approach. I’ll make a separate patch for -fmodule-file, which is turning

Re: [PATCH] D14695: [libclang] Add entry points that take a full command line including argv[0].

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D14695 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [cfe-commits] r119285 - in /cfe/trunk: lib/Frontend/ASTUnit.cpp tools/c-index-test/c-index-test.c

(now with the right list) On Tue, Nov 16, 2010 at 12:03 AM Douglas Gregor wrote: > Author: dgregor > Date: Mon Nov 15 17:00:34 2010 > New Revision: 119285 > > URL: http://llvm.org/viewvc/llvm-project?rev=119285=rev > Log: > Tweak libclang's heuristics for building precompiled

Re: [PATCH] D14773: [ARM] Support +feature targeting in -mcpu/-march

bsmith updated this revision to Diff 40515. bsmith added a comment. Add +crypto to testing. Repository: rL LLVM http://reviews.llvm.org/D14773 Files: lib/Driver/Tools.cpp test/Driver/arm-features.c Index: test/Driver/arm-features.c

Re: [PATCH] D14754: [Myriad]: insert -L paths into linker cmd only when they exist.

This revision was automatically updated to reflect the committed changes. Closed by commit rL253467: [Myriad]: insert -L paths into linker cmd only when they exist. (authored by dougk). Changed prior to commit: http://reviews.llvm.org/D14754?vs=40442=40516#toc Repository: rL LLVM

Re: [PATCH] D14130: Delete dead code in the LibcxxAndAbiBuilder

jroelofs closed this revision. jroelofs added a comment. r253480 http://reviews.llvm.org/D14130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Some buildbot statistics for the last week

Hello everyone, Here are some buildbot statistics you may found interesting. I will be adding more statistics. My goal is to publish metrics to help with keeping the buildbot infrastructure healthy and improving it. All the numbers are for the week of 11/8/2015 - 11/14/2015. Thanks Galina

r253486 - Removing the AST matcher test for thread_local storage duration. Not all platforms support TLS, and on platforms that do not support it, use of thread_local causes an error. Since there's no

Author: aaronballman Date: Wed Nov 18 12:37:29 2015 New Revision: 253486 URL: http://llvm.org/viewvc/llvm-project?rev=253486=rev Log: Removing the AST matcher test for thread_local storage duration. Not all platforms support TLS, and on platforms that do not support it, use of thread_local

Re: Some buildbot statistics for the last week

On Wed, Nov 18, 2015 at 1:40 PM, Galina Kistanova via cfe-commits wrote: > Hello everyone, > > Here are some buildbot statistics you may found interesting. I will be > adding more statistics. > My goal is to publish metrics to help with keeping the buildbot >

r253481 - Re-committing r253473 after hopefully fixing the bot breakage. There was a copy-pasta issue that my local testing did not catch.

Author: aaronballman Date: Wed Nov 18 11:56:55 2015 New Revision: 253481 URL: http://llvm.org/viewvc/llvm-project?rev=253481=rev Log: Re-committing r253473 after hopefully fixing the bot breakage. There was a copy-pasta issue that my local testing did not catch. Modified:

Re: [PATCH] D14325: [clang-format] Do not align assignments that aren't after the same number of commas. (Closes: 25329)

berenm marked an inline comment as done. berenm added a comment. Ping? http://reviews.llvm.org/D14325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [cfe-commits] r119285 - in /cfe/trunk: lib/Frontend/ASTUnit.cpp tools/c-index-test/c-index-test.c

> On Nov 18, 2015, at 9:36 AM, Manuel Klimek wrote: > > > > On Wed, Nov 18, 2015 at 6:19 PM Douglas Gregor > wrote: > > > Sent from my iPhone > > On Nov 18, 2015, at 8:19 AM, Manuel Klimek

Re: [PATCH] D14616: [libcxx] Replace TEST_HAS_NO_EXCEPTIONS with _LIBCPP_NO_EXCEPTIONS [NFC]

jroelofs requested changes to this revision. jroelofs added a comment. This revision now requires changes to proceed. This change is not the right thing to do. The reason this is a separate macro is that we don't want the tests in `test/std` to depend on implementation details of libcxx itself.

Re: [PATCH] D14779: Adding checker to detect excess padding in records

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. I may be mistaken, but this check looks more appropriate for Clang-tidy. http://reviews.llvm.org/D14779 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r253486 - Removing the AST matcher test for thread_local storage duration. Not all platforms support TLS, and on platforms that do not support it, use of thread_local causes an error. Since there'

On 11/18/15 11:37 AM, Aaron Ballman via cfe-commits wrote: Author: aaronballman Date: Wed Nov 18 12:37:29 2015 New Revision: 253486 URL: http://llvm.org/viewvc/llvm-project?rev=253486=rev Log: Removing the AST matcher test for thread_local storage duration. Not all platforms support TLS, and

Re: r253481 - Re-committing r253473 after hopefully fixing the bot breakage. There was a copy-pasta issue that my local testing did not catch.

Hi Aaron, There's one test failing now: https://smooshbase.apple.com/ci/job/apple-clang-stage1-configure-R_master_check/7042/ FAIL: Clang-Unit :: ASTMatchers/Release+Asserts/ASTMatchersTests/Matcher.VarDecl_StorageDuration (8227 of 24324) TEST 'Clang-Unit ::

Re: [PATCH] D14134: [OpenMP] Parsing and sema support for map clause

kkwli0 marked 6 inline comments as done. kkwli0 added a comment. Address the comments and will post an updated patch. http://reviews.llvm.org/D14134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r253481 - Re-committing r253473 after hopefully fixing the bot breakage. There was a copy-pasta issue that my local testing did not catch.

On Wed, Nov 18, 2015 at 2:07 PM, Bruno Cardoso Lopes wrote: > Hi Aaron, > > There's one test failing now: > https://smooshbase.apple.com/ci/job/apple-clang-stage1-configure-R_master_check/7042/ I have temporarily addressed this in r253486. The issue is that thread_local

Re: Some buildbot statistics for the last week

Permanently failing bots are way better that 50/50 flaky bots, but still not good. As for the sanitizer-x86_64-linux-bootstrap, it shows some legitimate failures in different parts of llvm that no one bothered to fix. That's kinda understandable because MSan failures are hard to reproduce locally

r253495 - [Sema] Don't work around a malformed AST

Author: majnemer Date: Wed Nov 18 13:49:19 2015 New Revision: 253495 URL: http://llvm.org/viewvc/llvm-project?rev=253495=rev Log: [Sema] Don't work around a malformed AST We created a malformed TemplateSpecializationType: it was dependent but had a RecordType as it's canonical type. This would

Re: r253481 - Re-committing r253473 after hopefully fixing the bot breakage. There was a copy-pasta issue that my local testing did not catch.

Ops, missed you follow up r253486 again. Thanks, On Wed, Nov 18, 2015 at 11:07 AM, Bruno Cardoso Lopes wrote: > Hi Aaron, > > There's one test failing now: > https://smooshbase.apple.com/ci/job/apple-clang-stage1-configure-R_master_check/7042/ > > FAIL: Clang-Unit :: >

Re: r253486 - Removing the AST matcher test for thread_local storage duration. Not all platforms support TLS, and on platforms that do not support it, use of thread_local causes an error. Since there'

On Wed, Nov 18, 2015 at 2:08 PM, Jonathan Roelofs wrote: > > > On 11/18/15 11:37 AM, Aaron Ballman via cfe-commits wrote: >> >> Author: aaronballman >> Date: Wed Nov 18 12:37:29 2015 >> New Revision: 253486 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=253486=rev

Re: [PATCH] D14616: [libcxx] Replace TEST_HAS_NO_EXCEPTIONS with _LIBCPP_NO_EXCEPTIONS [NFC]

EricWF added a comment. @jroelofs +1. We are trying to make our test suite generic enough that other STL maintainers may use it and contribute to it. http://reviews.llvm.org/D14616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14134: [OpenMP] Parsing and sema support for map clause

kkwli0 updated this revision to Diff 40537. kkwli0 added a comment. Updated patch with the 2nd review comments addressed. http://reviews.llvm.org/D14134 Files: include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/OpenMPClause.h include/clang/AST/RecursiveASTVisitor.h

Re: [PATCH] D9600: Add scan-build python implementation

jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. This revision is now accepted and ready to land. Sounds reasonable and I can help with setting up the CMake & LIT goop once you've got it committed. FWIW, I was able to get a simple example

Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

Dushistov added a comment. apply all suggestions http://reviews.llvm.org/D14170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

Dushistov marked an inline comment as done. Dushistov added a comment. http://reviews.llvm.org/D14170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

Dushistov updated this revision to Diff 40485. Dushistov added a comment. Replace 'endswith' with 'operator==', also update test to check that all four ways to call postEvent not produce warning http://reviews.llvm.org/D14170 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp

Re: [PATCH] D13383: [clang] Add flag to DeclContext to distinguish between qualified and unqualified name lookups

evgeny777 closed this revision. evgeny777 added a comment. Deinitializer class was renamed and moved under LookupQualifiedName() function scope http://reviews.llvm.org/D13383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14760: Resolve build problem on NetBSD

krytarowski added a comment. In http://reviews.llvm.org/D14760#291616, @joerg wrote: > Are you sure your sources are up-to-date? That file is newly generated in > LLVM and no changes outside should be necessary. Are you using cmake or gmake? Yes. This is also the reason to kill randomly

[PATCH] D14773: [ARM] Support +feature targeting in -mcpu/-march

bsmith created this revision. bsmith added a reviewer: rengolin. bsmith added a subscriber: cfe-commits. bsmith set the repository for this revision to rL LLVM. Herald added subscribers: rengolin, aemerson. For AArch64 it is possible to specify various optional extensions by using options such

r253458 - Fix tests in order for them to not fail after r252604.

Author: igor.laevsky Date: Wed Nov 18 08:40:41 2015 New Revision: 253458 URL: http://llvm.org/viewvc/llvm-project?rev=253458=rev Log: Fix tests in order for them to not fail after r252604. Some expected attributes appear to be incorrect after optimizations are run and llvm will strip them. Use

Re: [PATCH] D14744: PR10235: support for vector mode attributes + warning

aaron.ballman added a comment. In http://reviews.llvm.org/D14744#291663, @DmitryPolukhin wrote: > Added new warning group as suggested. > > I see thousands of vector types in headers on GitHub >

Re: [PATCH] D14796: Preserve exceptions information during calls code generation.

rjmccall added a comment. What I was thinking was something more along the lines of a little struct that stored either a Decl * or a FunctionType *, and you could change the TargetDecl argument to functions like EmitCall and ConstructAttributeList to that. Maybe call it something like

Re: [PATCH] D14796: Preserve exceptions information during calls code generation.

sfantao added a comment. In http://reviews.llvm.org/D14796#292336, @rjmccall wrote: > What I was thinking was something more along the lines of a little struct > that stored either a Decl * or a FunctionType *, and you could change the > TargetDecl argument to functions like EmitCall and

Re: [PATCH] D13263: Addition of __attribute__((pass_object_size)) to Clang

rsmith added inline comments. Comment at: include/clang/AST/Expr.h:631-634 @@ -630,1 +630,6 @@ + /// \brief If the current Expr is either a pointer, this will try to + /// statically determine the number of bytes available where the pointer is + /// pointing. Returns true

r253534 - Don't actually add the __unsafe_unretained qualifier in MRC;

Author: rjmccall Date: Wed Nov 18 20:28:03 2015 New Revision: 253534 URL: http://llvm.org/viewvc/llvm-project?rev=253534=rev Log: Don't actually add the __unsafe_unretained qualifier in MRC; driving a canonical difference between that and an unqualified type is a really bad idea when both are

r253533 - Fix the emission of ARC-style ivar layouts in the fragile runtime

Author: rjmccall Date: Wed Nov 18 20:27:55 2015 New Revision: 253533 URL: http://llvm.org/viewvc/llvm-project?rev=253533=rev Log: Fix the emission of ARC-style ivar layouts in the fragile runtime to start at the offset of the first ivar instead of the rounded-up end of the superclass. The latter

r253535 - [coroutines] Tweak diagnostics to always use fully-qualified name for std::coroutine_traits.

Author: rsmith Date: Wed Nov 18 20:36:35 2015 New Revision: 253535 URL: http://llvm.org/viewvc/llvm-project?rev=253535=rev Log: [coroutines] Tweak diagnostics to always use fully-qualified name for std::coroutine_traits. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D12614: [OpenMP] Offloading descriptor registration and device codegen.

sfantao added a comment. Ping! http://reviews.llvm.org/D12614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D7606: Fix adress cast for C++ in SEMA

sfantao added a comment. Ping! http://reviews.llvm.org/D7606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14804: [clang] Disable Unicode in asm files

tinti removed rL LLVM as the repository for this revision. tinti updated this revision to Diff 40595. http://reviews.llvm.org/D14804 Files: lib/Lex/Lexer.cpp test/CodeGen/asm-unicode.S test/CodeGen/c-unicode.c Index: test/CodeGen/c-unicode.c

Re: [PATCH] D14804: [clang] Disable Unicode in asm files

joker.eph added a comment. Isn't the patch reversed or do I miss something? Repository: rL LLVM http://reviews.llvm.org/D14804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

zaks.anna added inline comments. Comment at: test/Analysis/qt_malloc.cpp:11 @@ +10,3 @@ + QCoreApplication::postEvent(obj, event); + QApplication::postEvent(obj, event); +} Should the leak be reported when the object is passed to QApplication::postEvent? In

[PATCH] D14796: Preserve exceptions information during calls code generation.

sfantao created this revision. sfantao added reviewers: rjmccall, rnk, ABataev, hfinkel. sfantao added a subscriber: cfe-commits. This patch changes the generation of `CGFunctionInfo` to contain the `FunctionProtoType` if it is available. This enables the code generation for call instructions

r253532 - [analyzer] Improve modeling of static initializers.

Author: zaks Date: Wed Nov 18 19:25:28 2015 New Revision: 253532 URL: http://llvm.org/viewvc/llvm-project?rev=253532=rev Log: [analyzer] Improve modeling of static initializers. Conversions between unrelated pointer types (e.g. char * and void *) involve bitcasts which were not properly modeled

Re: [PATCH] D14796: Preserve exceptions information during calls code generation.

sfantao updated this revision to Diff 40587. sfantao added a comment. Create `CGCalleeInfo` to forward the declaration and function type information during the emission of calls. http://reviews.llvm.org/D14796 Files: include/clang/CodeGen/CGFunctionInfo.h lib/CodeGen/CGCall.cpp

Re: [PATCH] D14652: [analyzer] Improve modeling of static initializers.

zaks.anna added a comment. Fixed and committed. Comment at: test/Analysis/inline.cpp:308 @@ +307,3 @@ +clang_analyzer_eval(0 != void_string); // expected-warning{{TRUE}} +clang_analyzer_eval(0 != ((char *)void_string)[1]); // expected-warning{{TRUE}} + }

Re: [PATCH] D14652: [analyzer] Improve modeling of static initializers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL253532: [analyzer] Improve modeling of static initializers. (authored by zaks). Changed prior to commit: http://reviews.llvm.org/D14652?vs=40144=40582#toc Repository: rL LLVM

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:7659 @@ +7658,3 @@ +Diag(D.getDeclSpec().getConceptSpecLoc(), + diag::err_concept_specified_specialization) << 1; + } hubert.reinterpretcast wrote: > nwilson wrote: > >

Re: [PATCH] D13388: Add support for querying the visibility of a cursor

michaelwu added a comment. Anyone mind landing this for me? I don't have commit access. http://reviews.llvm.org/D13388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] Change memcpy/memmove/memset to have dest and source alignment

Pushed this in LLVM r253511 and clang 253512. Thanks again for the review Hal. BTW, I realized the docs need to be updated. I’ll let the bots run on this for a while and if it all goes well I’ll commit the docs update. Cheers, Pete > On Nov 11, 2015, at 11:25 AM, Pete Cooper via cfe-commits

Re: [PATCH] D14737: Convert some ObjC msgSends to runtime calls

> On Nov 18, 2015, at 4:21 PM, John McCall wrote: > > rjmccall added inline comments. > > > Comment at: include/clang/Basic/ObjCRuntime.h:182 > @@ +181,3 @@ > +switch (getKind()) { > +case FragileMacOSX: return false; > +case MacOSX: return

Re: [PATCH] D14737: Convert some ObjC msgSends to runtime calls

rjmccall added inline comments. Comment at: include/clang/Basic/ObjCRuntime.h:182 @@ +181,3 @@ +switch (getKind()) { +case FragileMacOSX: return false; +case MacOSX: return getVersion() >= VersionTuple(10, 10); I went ahead and asked Greg, and he

r253506 - [MSVC Compat] Make -Wmicrosoft-cast not an error by default

Author: majnemer Date: Wed Nov 18 15:42:38 2015 New Revision: 253506 URL: http://llvm.org/viewvc/llvm-project?rev=253506=rev Log: [MSVC Compat] Make -Wmicrosoft-cast not an error by default Too much code is sloppy about this to error by default. Modified:

r253519 - Fix debian build after r253512.

Author: pete Date: Wed Nov 18 16:53:40 2015 New Revision: 253519 URL: http://llvm.org/viewvc/llvm-project?rev=253519=rev Log: Fix debian build after r253512. The conversion from QuantityType to the (temporary) IntegerAlignment class was ambiguous. For now add in explicit conversion to unsigned

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

hubert.reinterpretcast added inline comments. Comment at: lib/Sema/SemaDecl.cpp:7659 @@ +7658,3 @@ +Diag(D.getDeclSpec().getConceptSpecLoc(), + diag::err_concept_specified_specialization) << 1; + } nwilson wrote: > hubert.reinterpretcast

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

nwilson added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2003 @@ +2002,3 @@ +def err_concept_specified_specialization : Error< + "%'concept' cannot be applied on an " + "%select{explicit instantiation|explicit specialization|partial

Re: [PATCH] D13746: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

chapuni added inline comments. Comment at: clang-tools-extra/trunk/test/clang-tidy/cppcoreguidelines-pro-bounds-constant-array-index.cpp:2 @@ +1,3 @@ +// RUN: %check_clang_tidy %s cppcoreguidelines-pro-bounds-constant-array-index %t -- -config='{CheckOptions: [{key:

Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Thanks! LGTM. I'll commit. http://reviews.llvm.org/D14170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14779: Adding checker to detect excess padding in records

zaks.anna added a comment. This is a partial review. I did not look at the padding calculations closely. Have you run this over codebases other than clang? Are there any false positives? > Even with the default of 8, this checker is too noisy to justify turning on > by default. Clang+LLVM has

Re: [PATCH] D13746: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

mgehre added inline comments. Comment at: clang-tools-extra/trunk/test/clang-tidy/cppcoreguidelines-pro-bounds-constant-array-index.cpp:2 @@ +1,3 @@ +// RUN: %check_clang_tidy %s cppcoreguidelines-pro-bounds-constant-array-index %t -- -config='{CheckOptions: [{key:

r253523 - [MS ABI] Let arbitrary entities participate in vftable ordering

Author: majnemer Date: Wed Nov 18 18:03:54 2015 New Revision: 253523 URL: http://llvm.org/viewvc/llvm-project?rev=253523=rev Log: [MS ABI] Let arbitrary entities participate in vftable ordering In the Microsoft ABI, the vftable is laid out in the order in the declaration order of the entities

r253541 - Revert "Fix debian build after r253512."

Author: pete Date: Wed Nov 18 23:55:44 2015 New Revision: 253541 URL: http://llvm.org/viewvc/llvm-project?rev=253541=rev Log: Revert "Fix debian build after r253512." This reverts commit r253519. This likely broke the bots in http://lab.llvm.org:8011/builders/clang-ppc64-elf-linux2/builds/20202

Re: [PATCH] D14652: [analyzer] Improve modeling of static initializers.

ygribov added inline comments. Comment at: test/Analysis/inline.cpp:308 @@ +307,3 @@ +clang_analyzer_eval(0 != void_string); // expected-warning{{TRUE}} +clang_analyzer_eval(0 != ((char *)void_string)[1]); // expected-warning{{TRUE}} + } zaks.anna

r253516 - [analyzer] Skip checking blocks in dependent contexts.

Author: dcoughlin Date: Wed Nov 18 16:46:52 2015 New Revision: 253516 URL: http://llvm.org/viewvc/llvm-project?rev=253516=rev Log: [analyzer] Skip checking blocks in dependent contexts. Since we don't check functions in dependent contexts, we should skip blocks in those contexts as well. This

Re: [PATCH] D14779: Adding checker to detect excess padding in records

zaks.anna added a comment. > I may be mistaken, but this check looks more appropriate for Clang-tidy. This is a syntactic check. Both clang-tidy as well as the clang static analyzer contain this type of checks. If we move all syntactic checks to clang-tidy, the users that use the analyzer but