dvadym updated this revision to Diff 40751.
dvadym marked 3 inline comments as done.
dvadym added a comment.
New in this upload:
1.Adding checking that language is C++
2.Not consider calls of std::move in template instantation
3.Creating CharSourceRange for removal
4.Using
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: aaron.ballman.
DmitryPolukhin added a subscriber: cfe-commits.
This CL is for discussion how to better fix bit-filed layout compatibility
issue with GCC (see PR25575 for test case and more details). Current clang
behavior is
a.sidorin removed rL LLVM as the repository for this revision.
a.sidorin updated this revision to Diff 40769.
a.sidorin added a comment.
Herald added a subscriber: klimek.
Seems like I have found a way to test ASTImporter. What about some unit-tests?
A sample test using AST matcher is attached.
Author: djasper
Date: Fri Nov 20 08:32:54 2015
New Revision: 253667
URL: http://llvm.org/viewvc/llvm-project?rev=253667=rev
Log:
clang-format: [Proto] Support extending message.
Before:
extend.foo.Bar {
}
After:
extend .foo.Bar {
}
Modified:
cfe/trunk/lib/Format/FormatToken.h
a.sidorin updated this revision to Diff 40775.
a.sidorin added a comment.
Add language-related arguments for compilation.
http://reviews.llvm.org/D14286
Files:
include/clang/ASTMatchers/ASTMatchers.h
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
unittests/AST/CMakeLists.txt
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D14134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rmaprath updated this revision to Diff 40767.
rmaprath added a comment.
Addressing review comments:
- Fixed a couple of typos.
- Made the use of the thread-local storage specifier a bit more flexible to
allow testing on few other configurations.
http://reviews.llvm.org/D14653
Files:
dvadym added a comment.
Thanks for comments! PTAL
Since it's added checking of trivially copyable arguments of move, it's needed
to rename this check, what do you think about MoveNoEffectCheck?
Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:11
@@ +10,3 @@
+#include
ABataev created this revision.
ABataev added reviewers: rjmccall, DavidKreitzer, mkuper.
ABataev added a subscriber: cfe-commits.
For MCU only C calling convention is allowed, all other calling conventions are
not supported.
http://reviews.llvm.org/D14864
Files:
lib/Basic/Targets.cpp
jroelofs added inline comments.
Comment at: tools/scan-build-py/libear/__init__.py:1
@@ +1,2 @@
+# -*- coding: utf-8 -*-
+# The LLVM Compiler Infrastructure
rizsotto.mailinglist wrote:
> dcoughlin wrote:
> > How does this file fit into the
rizsotto.mailinglist marked 13 inline comments as done.
rizsotto.mailinglist added a comment.
thanks Devin for your comments. made some changes already (will upload it
tonight after some tests).
Comment at: tools/scan-build-py/CHANGES.txt:1
@@ +1,1 @@
+v, -- Initial release.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253677: Handle ARMv6-J as an alias, instead of fake
architecture (authored by askrobov).
Changed prior to commit:
http://reviews.llvm.org/D14756?vs=40431=40789#toc
Repository:
rL LLVM
sdardis updated this revision to Diff 40782.
sdardis marked 4 inline comments as done.
sdardis added a comment.
Updated comments, used cast as suggested, added mutual exclusion check for
mips16+interrupt combination.
Extended mips16/nomips16 attribute handlers for mutual exclusion, add to
Author: djasper
Date: Fri Nov 20 10:18:42 2015
New Revision: 253672
URL: http://llvm.org/viewvc/llvm-project?rev=253672=rev
Log:
clang-format: [JS] Properly add a space after "in" in for loops.
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/trunk/unittests/Format/FormatTestJS.cpp
Author: askrobov
Date: Fri Nov 20 10:47:05 2015
New Revision: 253677
URL: http://llvm.org/viewvc/llvm-project?rev=253677=rev
Log:
Handle ARMv6-J as an alias, instead of fake architecture
Summary: Clang-side update, corresponding to D14755
Reviewers: rengolin, bogden, compnerd
Subscribers:
Author: djasper
Date: Fri Nov 20 09:26:50 2015
New Revision: 253669
URL: http://llvm.org/viewvc/llvm-project?rev=253669=rev
Log:
clang-format: Don't use incorrect space in macro calls with operators.
Before:
MACRO(> );
After:
MACRO(>);
Not overly important, but easy and good for symmetry
Author: djasper
Date: Fri Nov 20 10:44:28 2015
New Revision: 253674
URL: http://llvm.org/viewvc/llvm-project?rev=253674=rev
Log:
clang-format: [JS] Make AllowShortFunctionsOnASingle line value "Empty"
work properly.
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
Author: rnk
Date: Fri Nov 20 11:41:12 2015
New Revision: 253680
URL: http://llvm.org/viewvc/llvm-project?rev=253680=rev
Log:
[DebugInfo] Look through type sugar on union types when casting
Fixes PR25584.
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
sisnkemp updated this revision to Diff 40794.
http://reviews.llvm.org/D14215
Files:
lib/Driver/Tools.cpp
lib/Frontend/CompilerInvocation.cpp
test/CodeGen/x86_64-profiling-keep-fp.c
Index: test/CodeGen/x86_64-profiling-keep-fp.c
jroelofs added a comment.
Are you aware of http://reviews.llvm.org/D9600 ?
http://reviews.llvm.org/D14629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pete updated this revision to Diff 40790.
pete added a comment.
Added a couple of tests for retain returning types other than id. Returning a
pointer should still be converted to a call, while returning a non-pointer such
as float will get a message instead.
I walked through the code in the
aaron.ballman added a comment.
Btw, here are some statistics as to the rate at which this diagnostic is
triggered:
LLVM: 21255 warnings (about 18000 warnings were due to two AST matcher
constructors; adding noexcept to those brings the count to 2895 warnings, most
of which are cl::opt-related
danielcdh marked an inline comment as done.
danielcdh added a comment.
http://reviews.llvm.org/D14848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sisnkemp updated this revision to Diff 40793.
sisnkemp added a comment.
Added a test with -momit-leaf-frame-pointer as requested by davidxl.
http://reviews.llvm.org/D14215
Files:
lib/Driver/Tools.cpp
lib/Frontend/CompilerInvocation.cpp
test/CodeGen/x86_64-profiling-keep-fp-1.c
Author: rnk
Date: Fri Nov 20 13:08:30 2015
New Revision: 253694
URL: http://llvm.org/viewvc/llvm-project?rev=253694=rev
Log:
Thread Safety Analysis: Fix DenseMap iterator invalidation UAF
Rather than storing BeforeInfo in the DenseMap by value, this stores a
unique_ptr to it, so that we can keep
eugenis added a comment.
I vaguely recall that android runtime loader had some symbol lookup
differencies with glibc and that prevented interceptors (when statically linked
into the main executable) from working. Maybe it is not the case now.
http://reviews.llvm.org/D14858
Author: seurer
Date: Fri Nov 20 14:47:34 2015
New Revision: 253706
URL: http://llvm.org/viewvc/llvm-project?rev=253706=rev
Log:
Fix test case function name checks
This is similar to the earlier fix I did, r253702, expect that here it
is function names that are being searched for. If the
dvyukov added a comment.
> Yes, we should use shared runtime library on Android.
Note that tsan is different from all of asan/msan/ubsan in that it does
zillions of calls into runtime, so the indirection will have non-zero runtime
cost.
Is it possible to statically link it into something that
bcraig updated the summary for this revision.
bcraig updated this revision to Diff 40818.
bcraig added a comment.
Adding a test to validate non-trivial message components.
Adding recommendations to the diagnostic on how to fix and / or suppress the
generated report.
Changing default padding
george.burgess.iv created this revision.
george.burgess.iv added a reviewer: rsmith.
george.burgess.iv added a subscriber: cfe-commits.
When evaluating constexpr vector splats, we weren't doing appropriate type
conversions on the literal we were splatting, causing assertion failures in
cases
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:256
@@ +255,3 @@
+def warn_mips_interrupt_attribute : Warning<
+ "function %0 must %select{take no arguments|have the \'void\' return type}1"
+ " for the 'interrupt' attribute for
dimitry added a subscriber: dimitry.
dimitry added a comment.
In http://reviews.llvm.org/D14858#294082, @eugenis wrote:
> I vaguely recall that android runtime loader had some symbol lookup
> differencies with glibc and that prevented interceptors (when statically
> linked into the main
eugenis added a comment.
In http://reviews.llvm.org/D14858#293651, @danalbert wrote:
> I assume we're going to actually want to go the other direction on this and
> build a shared library for Android's TSAN (see eugenis' comment on
>
kcc added a comment.
performance is a very strong reason to have tsan linked statically.
every memory access in the app is instrumented with a function call,
if we make this call go through PLT we'll get significant drop in performance.
This is not a blocker, but I want to explicitly mention
eugenis added a comment.
OK, it sounds like static runtime would work fine.
We would still need a way to switch to the shared runtime for the apps (the
workflow when we LD_PRELOAD the runtime into the Zygote to run instrumented
apps on a non-instrumented device). Something like -shared-libasan
Author: pcc
Date: Fri Nov 20 14:49:39 2015
New Revision: 253707
URL: http://llvm.org/viewvc/llvm-project?rev=253707=rev
Log:
Driver: Defer computation of linker path until it is needed.
This allows us to construct Linux toolchains without a valid linker. This
is needed for example to build a
probinson added a subscriber: probinson.
probinson added a comment.
Not sure what the exact problem is, but we still have one bot using
configure/make, and it dies with this on the install step unless we use -j1. I
know the hand-written Makefiles are deprecated and we've worked around it, but
sgundapa created this revision.
sgundapa added reviewers: echristo, craig.topper.
sgundapa added a subscriber: cfe-commits.
This unit test need not be true on all the targets.
http://reviews.llvm.org/D14887
Files:
test/CodeGen/tbm-builtins.c
Index: test/CodeGen/tbm-builtins.c
rjmccall added a comment.
In http://reviews.llvm.org/D14737#293967, @pete wrote:
> Added a couple of tests for retain returning types other than id. Returning
> a pointer should still be converted to a call, while returning a non-pointer
> such as float will get a message instead.
>
> I
Author: cbieneman
Date: Fri Nov 20 16:09:03 2015
New Revision: 253720
URL: http://llvm.org/viewvc/llvm-project?rev=253720=rev
Log:
[CMake] Fix handling of passing through semi-colon separated lists.
When passing around CMake arguments as lists of arguments any arguments
containing lists need to
Author: cbieneman
Date: Fri Nov 20 16:09:06 2015
New Revision: 253721
URL: http://llvm.org/viewvc/llvm-project?rev=253721=rev
Log:
[CMake] Add support for specifying arguments to the bootstrap build.
This adds support for three types of argument specifications for bootstrap
builds:
(1)
Author: tinti
Date: Fri Nov 20 17:42:39 2015
New Revision: 253738
URL: http://llvm.org/viewvc/llvm-project?rev=253738=rev
Log:
[clang] Disable Unicode in asm files
Clang should not convert tokens to Unicode when preprocessing assembly
files.
Fixes PR25558.
Added:
scanon created this revision.
scanon added reviewers: hfinkel, resistor, lhames.
scanon added a subscriber: cfe-commits.
r253269 exposed a pre-existing issue in tryEmitFMulAdd, where we would assert
if a fusable operation had operands with multiple uses (we didn't see it
previously because
zaks.anna added a comment.
> And I really like how the clang-tidy guys were doing it.
It would be great if the clang static analyzer config file would be similar to
the clang-tidy one. We would avoid user confusion if they are consistent. Is
some reuse possible? Currently, when clang-tidy
Author: rsmith
Date: Fri Nov 20 16:47:10 2015
New Revision: 253726
URL: http://llvm.org/viewvc/llvm-project?rev=253726=rev
Log:
[coroutines] Support braced-init-list as operand of co_yield expression.
Modified:
cfe/trunk/lib/Parse/ParseExprCXX.cpp
cfe/trunk/test/SemaCXX/coroutines.cpp
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
This is fine. One inline comment.
-eric
Comment at: test/CodeGen/tbm-builtins.c:2-3
@@ -1,3 +1,4 @@
// RUN: %clang_cc1 %s -O3 -triple=x86_64-unknown-unknown
gribozavr added inline comments.
Comment at:
test/std/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.pass.cpp:35
@@ -30,1 +34,3 @@
}
+
+template
gribozavr wrote:
> mclow.lists wrote:
> > This is not how I would rewrite this test.
> > I
Author: rsmith
Date: Fri Nov 20 16:40:06 2015
New Revision: 253725
URL: http://llvm.org/viewvc/llvm-project?rev=253725=rev
Log:
[coroutines] Synthesize yield_value call for co_yield.
Modified:
cfe/trunk/lib/Sema/SemaCoroutine.cpp
cfe/trunk/test/SemaCXX/coroutines.cpp
Modified:
tinti closed this revision.
tinti added a comment.
r253738
Repository:
rL LLVM
http://reviews.llvm.org/D14804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko added a comment.
I think will be good idea to ask specialist in configure build to look on make
file. I used other Clang or LLVM make file as example. Frankly, I don't see
anything bad with it.
However this fix was backported to 3.7.x and configure build is still supported
Author: matze
Date: Fri Nov 20 18:56:41 2015
New Revision: 253741
URL: http://llvm.org/viewvc/llvm-project?rev=253741=rev
Log:
Fix testcase when building on darwin
Explicitely specify a target to avoid "_" prefixes on the names.
Modified:
cfe/trunk/test/CodeGen/c-unicode.c
Modified:
Author: tstellar
Date: Fri Nov 20 19:32:08 2015
New Revision: 253748
URL: http://llvm.org/viewvc/llvm-project?rev=253748=rev
Log:
Creating release candidate rc2 from release_371 branch
Added:
libcxxabi/tags/RELEASE_371/rc2/ (props changed)
- copied from r253747,
Author: tstellar
Date: Fri Nov 20 19:32:06 2015
New Revision: 253747
URL: http://llvm.org/viewvc/llvm-project?rev=253747=rev
Log:
Creating release candidate rc2 from release_371 branch
Added:
libcxx/tags/RELEASE_371/rc2/ (props changed)
- copied from r253746,
Author: tstellar
Date: Fri Nov 20 19:32:21 2015
New Revision: 253754
URL: http://llvm.org/viewvc/llvm-project?rev=253754=rev
Log:
Creating release candidate rc2 from release_371 branch
Added:
libunwind/tags/RELEASE_371/rc2/ (props changed)
- copied from r253753,
Author: d0k
Date: Fri Nov 20 01:57:46 2015
New Revision: 253654
URL: http://llvm.org/viewvc/llvm-project?rev=253654=rev
Log:
Regenerate ASTMatchersReference without CRLF.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
Modified: cfe/trunk/docs/LibASTMatchersReference.html
URL:
Author: matze
Date: Fri Nov 20 20:13:29 2015
New Revision: 253758
URL: http://llvm.org/viewvc/llvm-project?rev=253758=rev
Log:
Fix c-unicode.c testcase again.
Specifying a fixed triple is not possible because that target may not
even be compiler. Go for a simpler fix by using a _? regex for the
On Fri, Nov 20, 2015 at 2:09 PM, Chris Bieneman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: cbieneman
> Date: Fri Nov 20 16:09:06 2015
> New Revision: 253721
>
> URL: http://llvm.org/viewvc/llvm-project?rev=253721=rev
> Log:
> [CMake] Add support for specifying arguments to the
Author: matze
Date: Fri Nov 20 20:28:42 2015
New Revision: 253760
URL: http://llvm.org/viewvc/llvm-project?rev=253760=rev
Log:
Let's try to fix this test again with a fixed target triple
Modified:
cfe/trunk/test/CodeGen/c-unicode.c
Modified: cfe/trunk/test/CodeGen/c-unicode.c
URL:
RedX2501 added a comment.
Ping
http://reviews.llvm.org/D10833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
59 matches
Mail list logo
