Re: [PATCH] D14872: PR25575: Make GCC 4.4+ comatible layout for packed bit-fileds of char type

hfinkel added a subscriber: hfinkel. hfinkel added a comment. Please upload this patch with full context, see: http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface > Should we add warning about changes in layout for packed bit-fileds of char > type? GCC has it "note:

Re: r253958 - Reduce the stack usage per recursive step when RecursiveASTVisitor cannot perform data recursion.

On Tue, Nov 24, 2015 at 1:16 PM, Alexey Samsonov wrote: > Looks like Clang::Index/index-many-call-ops.cpp still uses too much stack > in ASan mode: > > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/10177/steps/check-clang%20asan/logs/stdio > > ASan

[libcxx] r254030 - Remove undefined behavior from tests; specifically, ensure that the value type of the allocators match the value type of the containers

Author: marshall Date: Tue Nov 24 16:10:51 2015 New Revision: 254030 URL: http://llvm.org/viewvc/llvm-project?rev=254030=rev Log: Remove undefined behavior from tests; specifically, ensure that the value type of the allocators match the value type of the containers Modified:

Re: r253958 - Reduce the stack usage per recursive step when RecursiveASTVisitor cannot perform data recursion.

Unfortunately, that change breaks the Clang compilation, see r254041 review thread. On Tue, Nov 24, 2015 at 3:54 PM, Richard Smith wrote: > On Tue, Nov 24, 2015 at 1:16 PM, Alexey Samsonov > wrote: > >> Looks like Clang::Index/index-many-call-ops.cpp

Re: [libcxx] r254050 - Silence a -Wmissing-braces warning in the tests; mbstate_t is defined differently on different C libraries.

Could this initialization just be written as "mbstate_t mb = {}" & avoid the warning entirely (I'm not entirely sure what the warning was, but I imagine that'd avoid it) On Tue, Nov 24, 2015 at 5:06 PM, Marshall Clow via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: marshall > Date:

r254053 - Fix typo that was being SFINAE'd away (and apparently GCC 4.7.2 rejects-valid on this).

Author: rsmith Date: Tue Nov 24 20:41:42 2015 New Revision: 254053 URL: http://llvm.org/viewvc/llvm-project?rev=254053=rev Log: Fix typo that was being SFINAE'd away (and apparently GCC 4.7.2 rejects-valid on this). Modified: cfe/trunk/include/clang/AST/RecursiveASTVisitor.h Modified:

Re: r254041 - Teach RAV to pass its DataRecursionQueue to derived classes if they ask for it,

Hah, looks like a rejects-valid, but it found a real bug, so *shrug*. =) Hopefully fixed in r254053. On Tue, Nov 24, 2015 at 5:14 PM, Alexey Samsonov wrote: > Hm, looks like we can't compile Clang itself after this change (with GCC): > > >

Re: r254053 - Fix typo that was being SFINAE'd away (and apparently GCC 4.7.2 rejects-valid on this).

Possible to test (unit test?) the bug that GCC accidentally found here? On Tue, Nov 24, 2015 at 6:41 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Tue Nov 24 20:41:42 2015 > New Revision: 254053 > > URL:

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

rjmccall added a comment. This looks fantastic, thanks for doing all that. Approved with the one minor change. Comment at: lib/Sema/SemaPseudoObject.cpp:175 @@ -145,1 +174,3 @@ +PSE->getType(), PSE->getValueKind(), PSE->getObjectKind(), +

Re: [PATCH] D14864: [X86] Support for C calling convention only for MCU target.

rjmccall added a comment. LGTM. http://reviews.llvm.org/D14864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

kfunk accepted this revision. kfunk added a comment. Looks good to me now. I'd also appreciate another +1 from somone else, though. http://reviews.llvm.org/D10833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D10802: [mips] Interrupt attribute support.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, once one minor nit is fixed. Thank you for working on this! Comment at: include/clang/Basic/DiagnosticSemaKinds.td:257 @@ +256,3 @@ + "MIPS 'interrupt'

Re: r253958 - Reduce the stack usage per recursive step when RecursiveASTVisitor cannot perform data recursion.

Looks like Clang::Index/index-many-call-ops.cpp still uses too much stack in ASan mode: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/10177/steps/check-clang%20asan/logs/stdio ASan increases the stack usage, so do you think there's more to fix here, or we should just

Re: [PATCH] D14506: Porting shouldVisitImplicitCode to DataRecursiveASTVisitor.

bcraig abandoned this revision. bcraig added a comment. Largely supplanted by r253958 http://reviews.llvm.org/D14506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D14964: [clang-tidy] Fix problem with parallel configure build

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, probinson. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. This fix should solve problem with parallel configure build introduced in D12700 as suggested

Re: r254041 - Teach RAV to pass its DataRecursionQueue to derived classes if they ask for it,

Unfortunately, the bot still seems to be unhappy: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/12246/steps/build%20fresh%20clang/logs/stdio On Tue, Nov 24, 2015 at 6:45 PM, Richard Smith wrote: > Hah, looks like a rejects-valid, but it found a

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

probinson added a comment. The problem is that making the install-local target will try to create the PROJ_sharedir directory in parallel with trying to copy DESTFILES to that directory. You need to set up the dependencies such that the directory is guaranteed to be created first. If you

Lit Test C++11 compatibility patch #5

Hi Everyone, I am continuing with updating Lit tests to be C++11 compatible. Here is the fifth patch. This patch contains 20 tests. These are mostly diagnostics changes due to new C++11 features and changes in the standard. Here are the explanations for each test in the order that they

Re: [PATCH] D12031: Const std::move() argument ClangTidy check

dvadym added a comment. Thanks alexfh! I've addressed your comments and uploaded new patch. PTAL Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:56 @@ +55,3 @@ +<< IsConstArg << IsVariable << IsTriviallyCopyable +<<

Re: [PATCH] D12031: Const std::move() argument ClangTidy check

dvadym updated this revision to Diff 41061. dvadym marked 8 inline comments as done. dvadym added a comment. In this patch alexfh comments addressed http://reviews.llvm.org/D12031 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

Re: [PATCH] D14935: Fix rewrite of reserved library name in case of -nodefaultlibs

This revision was automatically updated to reflect the committed changes. Closed by commit rL253990: Fix rewrite of reserved library name in case of -nodefaultlibs (authored by niravd). Changed prior to commit: http://reviews.llvm.org/D14935?vs=41040=41052#toc Repository: rL LLVM

r253990 - Fix rewrite of reserved library name in case of -nodefaultlibs

Author: niravd Date: Tue Nov 24 10:07:21 2015 New Revision: 253990 URL: http://llvm.org/viewvc/llvm-project?rev=253990=rev Log: Fix rewrite of reserved library name in case of -nodefaultlibs The Driver only checked if nostdlib was set when deciding to add reserved_lib_stdcxx, but as nostdlib is

r254007 - [analyzer] Pass value expression for inlined defensive checks when binding null to nonnull.

Author: dcoughlin Date: Tue Nov 24 13:15:11 2015 New Revision: 254007 URL: http://llvm.org/viewvc/llvm-project?rev=254007=rev Log: [analyzer] Pass value expression for inlined defensive checks when binding null to nonnull. The nullability checker was not suppressing false positives resulting

r254041 - Teach RAV to pass its DataRecursionQueue to derived classes if they ask for it,

Author: rsmith Date: Tue Nov 24 17:50:47 2015 New Revision: 254041 URL: http://llvm.org/viewvc/llvm-project?rev=254041=rev Log: Teach RAV to pass its DataRecursionQueue to derived classes if they ask for it, to allow them to explicitly opt into data recursion despite having overridden

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

ABataev updated this revision to Diff 41018. ABataev added a comment. Update after review http://reviews.llvm.org/D13336 Files: include/clang/AST/ExprCXX.h include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/StmtNodes.td include/clang/Serialization/ASTBitCodes.h

Re: r253898 - Driver: fallback to the location of clang if no sysroot,

> > This breaks mingw support on openSUSE : My first question is why on SUSE is clang installed in /opt while mingw-w64 in /usr? x86_64-w64-mingw32-gcc is in $PATH, and this used to work fine before > this commit. It doesn't look for gcc on linux that is a windows host only thing. It didn't do

Re: r253898 - Driver: fallback to the location of clang if no sysroot,

On Tue, Nov 24, 2015 at 12:43 PM, Martell Malone wrote: >> This breaks mingw support on openSUSE : > > My first question is why on SUSE is clang installed in /opt while mingw-w64 > in /usr? Well this is a custom clang it can be anywhere. Official one is in /usr. >>

Re: r253859 - Fix calculation of shifted cursor/code positions. Specifically support

On 23 November 2015 at 22:31, Daniel Jasper wrote: > Fixed in r253929. Thanks! ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r253972 - Use libcxx's default rune table with the Musl C library.

Author: vkalintiris Date: Tue Nov 24 04:24:54 2015 New Revision: 253972 URL: http://llvm.org/viewvc/llvm-project?rev=253972=rev Log: Use libcxx's default rune table with the Musl C library. Summary: Also, there are no exported character type tables from Musl so we have to Fallback to the

Re: [PATCH] D14926: Use libcxx's default rune table with the Musl C library.

This revision was automatically updated to reflect the committed changes. Closed by commit rL253972: Use libcxx's default rune table with the Musl C library. (authored by vkalintiris). Changed prior to commit: http://reviews.llvm.org/D14926?vs=40926=41016#toc Repository: rL LLVM

Re: r253898 - Driver: fallback to the location of clang if no sysroot,

> > Why not hardcode /usr for Linux hosts? Portable toolchain packages exist but can't on linux if you do this. but in general I'm sure most would agree that detection is much better then hard coding. This is why Yaron approved the patch Well this is a custom clang it can be anywhere. Official

Re: [PATCH] D14935: Fix nodefaultlibs/nostdlib check

niravd updated this revision to Diff 41040. niravd added a comment. Fix review issues http://reviews.llvm.org/D14935 Files: lib/Driver/Driver.cpp test/Driver/nodefaultlib.c Index: test/Driver/nodefaultlib.c === ---

Re: [PATCH] D10802: [mips] Interrupt attribute support.

sdardis updated this revision to Diff 41041. sdardis added a comment. Updated text of return type/parameters warning to Aaron's suggestion. Dropped '\' escape characters from warning/error text. Removed mips16/nomips16 check. Tweak of comment in handleMipsInterruptAttr.

Re: r253898 - Driver: fallback to the location of clang if no sysroot,

Searching for gcc on Linux is not a good idea, you'll find the system one not the mingw one. Searching for i686-w64-mingw32-gcc or x86_64-w64-mingw32-gcc should work better, that is searching for: getTriple().getArchName()) + "-w64-mingw32-gcc" Moreover, this should work on Windows as well,

Re: r253898 - Driver: fallback to the location of clang if no sysroot,

> > Searching for gcc on Linux is not a good idea, you'll find the system one > not the mingw one. Searching for i686-w64-mingw32-gcc or > x86_64-w64-mingw32-gcc should work better, that is searching for: > getTriple().getArchName()) + "-w64-mingw32-gcc" Moreover, this should work on Windows as

Re: [PATCH] D14919: Fix IssueHash generation

xazax.hun added inline comments. Comment at: include/clang/StaticAnalyzer/Core/IssueHash.h:42 @@ -41,1 +41,3 @@ + llvm::StringRef BugType, const Decl *D, + const LangOptions& LangOpts); Please

Re: [PATCH] D14203: [analyzer] Improve pointer arithmetic checker.

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/PointerArithChecker.cpp:150 @@ +149,3 @@ +return getArrayRegion(Region, Polymorphic, AKind, C); + default: +break; xazax.hun wrote: > dcoughlin wrote: > > In general, I think it is

Re: [PATCH] D14203: [analyzer] Improve pointer arithmetic checker.

xazax.hun updated this revision to Diff 41022. xazax.hun marked 11 inline comments as done. xazax.hun added a comment. - Fixed some of the review comments. - Updated to latest trunk. http://reviews.llvm.org/D14203 Files: lib/StaticAnalyzer/Checkers/PointerArithChecker.cpp

r253977 - [OPENMP] Fix crash on codegen for 'task' directive with no shared variables.

Author: abataev Date: Tue Nov 24 07:01:44 2015 New Revision: 253977 URL: http://llvm.org/viewvc/llvm-project?rev=253977=rev Log: [OPENMP] Fix crash on codegen for 'task' directive with no shared variables. If 'task' region does not have shared variables codegen could crash on calculation of size

Re: [PATCH] D14919: Fix IssueHash generation

o.gyorgy updated this revision to Diff 41024. o.gyorgy added a comment. Some small format changes. Based on the review. http://reviews.llvm.org/D14919 Files: include/clang/StaticAnalyzer/Core/IssueHash.h lib/Basic/SourceManager.cpp lib/StaticAnalyzer/Checkers/DebugCheckers.cpp

Re: [PATCH] D14864: [X86] Support for C calling convention only for MCU target.

DavidKreitzer added a comment. Looks good, Alexey! I have no further comments. - Dave http://reviews.llvm.org/D14864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D14935: Fix nodefaultlibs/nostdlib check

niravd created this revision. niravd added reviewers: dougk, jyknight. niravd added subscribers: cfe-commits, rsmith. Checks for nostdlib should also always check nodefaultlibs or nostartfiles as appropriate. Clang Driver misses a case http://reviews.llvm.org/D14935 Files:

[PATCH] D14954: [x86] Exclusion of incorrect include headers paths for MCU target

andreybokhanko created this revision. andreybokhanko added reviewers: ddunbar, rnk, mkuper. andreybokhanko added a subscriber: cfe-commits. This patch excludes incorrect include headers paths for MCU target. http://reviews.llvm.org/D14954 Files: lib/Frontend/InitHeaderSearch.cpp

Re: r253886 - Disable frame pointer elimination when using -pg

Hi, David Blaikie via cfe-commits wrote: > On Mon, Nov 23, 2015 at 9:30 AM, Xinliang David Li via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > Author: davidxl > > Date: Mon Nov 23 11:30:31 2015 > > New Revision: 253886 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=253886=rev >