Re: [PATCH] D10137: On {mips, mipsel, mips64, mips64el}-freebsd, we need to pass any -G option to the assembler.

2015-12-27 Thread Dimitry Andric via cfe-commits
dim updated this revision to Diff 43655. dim added a comment. Add a test for passing -G0 to the assembler. http://reviews.llvm.org/D10137 Files: lib/Driver/Tools.cpp test/Driver/freebsd-mips-as.c Index: test/Driver/freebsd-mips-as.c

r256468 - On {mips, mipsel, mips64, mips64el}-freebsd, we need to pass any -G option to the assembler.

2015-12-27 Thread Dimitry Andric via cfe-commits
Author: dim Date: Sun Dec 27 04:36:44 2015 New Revision: 256468 URL: http://llvm.org/viewvc/llvm-project?rev=256468=rev Log: On {mips,mipsel,mips64,mips64el}-freebsd, we need to pass any -G option to the assembler. Summary: See also:

Re: r256468 - On {mips, mipsel, mips64, mips64el}-freebsd, we need to pass any -G option to the assembler.

2015-12-27 Thread Joerg Sonnenberger via cfe-commits
On Sun, Dec 27, 2015 at 10:36:44AM -, Dimitry Andric via cfe-commits wrote: > Author: dim > Date: Sun Dec 27 04:36:44 2015 > New Revision: 256468 > > URL: http://llvm.org/viewvc/llvm-project?rev=256468=rev > Log: > On {mips,mipsel,mips64,mips64el}-freebsd, we need to pass any -G option to >

Re: [PATCH] D10137: On {mips, mipsel, mips64, mips64el}-freebsd, we need to pass any -G option to the assembler.

2015-12-27 Thread Dimitry Andric via cfe-commits
dim commandeered this revision. dim added a reviewer: brooks. dim added a comment. Picking this up, since it needs a minor change to apply. http://reviews.llvm.org/D10137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15166: Fix C++ support on recent DragonFly BSD releases

2015-12-27 Thread Dimitry Andric via cfe-commits
dim added a comment. Tried this with trunk r256465, but I get the following test failure: FAIL: Clang :: Driver/dragonfly.c (3997 of 30174) TEST 'Clang :: Driver/dragonfly.c' FAILED Script: --

r256467 - Fix C++ support on recent DragonFly BSD releases

2015-12-27 Thread Dimitry Andric via cfe-commits
Author: dim Date: Sun Dec 27 04:01:44 2015 New Revision: 256467 URL: http://llvm.org/viewvc/llvm-project?rev=256467=rev Log: Fix C++ support on recent DragonFly BSD releases Summary: [ Copied from https://llvm.org/bugs/show_bug.cgi?id=25597 ] Clang support for DragonFly BSD is lagging a bit,

Re: [PATCH] D15166: Fix C++ support on recent DragonFly BSD releases

2015-12-27 Thread Dimitry Andric via cfe-commits
dim updated this revision to Diff 43654. dim added a comment. Fix the test to check for --enable-new-dtags. http://reviews.llvm.org/D15166 Files: lib/Driver/ToolChains.cpp lib/Driver/Tools.cpp lib/Frontend/InitHeaderSearch.cpp test/Driver/dragonfly.c Index: test/Driver/dragonfly.c

r256472 - Constify NestedNameSpecifier::dump and add a no-argument dump function suitable for calling from a debugger.

2015-12-27 Thread Yaron Keren via cfe-commits
Author: yrnkrn Date: Sun Dec 27 08:34:22 2015 New Revision: 256472 URL: http://llvm.org/viewvc/llvm-project?rev=256472=rev Log: Constify NestedNameSpecifier::dump and add a no-argument dump function suitable for calling from a debugger. Modified:

Re: [PATCH] D15704: Add some overlooked optnone tests, and tighten up an existing test

2015-12-27 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thank you for these; I think the optnon-class-members.cpp and optnon-templates.cpp have value, so I would say to keep them. http://reviews.llvm.org/D15704

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

2015-12-27 Thread Aaron Ballman via cfe-commits
aaron.ballman added a subscriber: aaron.ballman. Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:22 @@ +21,3 @@ + +bool inHeaderFile(const SourceManager* SM, SourceLocation Location) { + StringRef Filename = SM->getFilename(SM->getExpansionLoc(Location));

Re: [PATCH] D15791: Disable generating movt on FreeBSD

2015-12-27 Thread Ed Maste via cfe-commits
emaste added a comment. > @davide, any idea whether lld will be able to handle movt correctly? If so, > we might want to make this dependent on -fuse-ld=bfd or -fuse-ld=lld ? I'm sure lld will handle everything we need eventually (if it does not already), but I'm not sure it's reasonable to

Re: [PATCH] D15709: [X86] Support 'interrupt' attribute for x86

2015-12-27 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/Basic/AttrDocs.td:1867 @@ +1866,3 @@ +Clang supports the GNU style ``__attribute__((interrupt))`` attribute on +x86 targets. This attribute may be attached to a function definition and +instructs the backend to

[clang-tools-extra] r256474 - Renaming CERT documentation files to use the CERT rule identifiers. This is for consistency with other checkers, where the documentation file name matches the checker nam

2015-12-27 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sun Dec 27 13:14:55 2015 New Revision: 256474 URL: http://llvm.org/viewvc/llvm-project?rev=256474=rev Log: Renaming CERT documentation files to use the CERT rule identifiers. This is for consistency with other checkers, where the documentation file name matches the

Re: [PATCH] D15791: Disable generating movt on FreeBSD

2015-12-27 Thread Dimitry Andric via cfe-commits
dim added a comment. In http://reviews.llvm.org/D15791#317175, @emaste wrote: > > @davide, any idea whether lld will be able to handle movt correctly? If so, > > we might want to make this dependent on -fuse-ld=bfd or -fuse-ld=lld ? > > > I'm sure lld will handle everything we need eventually

r256478 - [Sema] ArrayRef-ize ActOnBaseSpecifiers. NFC

2015-12-27 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sun Dec 27 15:55:19 2015 New Revision: 256478 URL: http://llvm.org/viewvc/llvm-project?rev=256478=rev Log: [Sema] ArrayRef-ize ActOnBaseSpecifiers. NFC Modified: cfe/trunk/include/clang/Sema/Sema.h cfe/trunk/lib/Parse/ParseDeclCXX.cpp

Re: [PATCH] D15055: [X86] Better support for the MCU psABI

2015-12-27 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/CodeGen/TargetInfo.cpp:838 @@ +837,3 @@ + bool shouldAggregateUseDirect(QualType Ty, CCState , bool , +bool ) const; + bool

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

2015-12-27 Thread Nathan Wilson via cfe-commits
nwilson added inline comments. Comment at: include/clang/AST/DeclTemplate.h:836 @@ -835,2 +835,3 @@ + bool IsConcept : 1; protected: rsmith wrote: > This might make more sense on `TemplateDecl`, since we also want this flag > for `VarTemplateDecl`s. In any

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

2015-12-27 Thread Nathan Wilson via cfe-commits
nwilson updated this revision to Diff 43670. nwilson added a comment. - Store the IsConcept boolean flag in TemplateDecl by making TemplatedDecl an IntPointerPair, and move the associated member functions into TemplateDecl. - Remove unnecessary quoted comment. - Remove an extra space where the

Re: [PATCH] D15709: [X86] Support 'interrupt' attribute for x86

2015-12-27 Thread John McCall via cfe-commits
rjmccall added inline comments. Comment at: include/clang/Basic/Attr.td:255 @@ -254,2 +254,3 @@ def TargetX86 : TargetArch<["x86"]>; +def TargetIA : TargetArch<["x86", "x86_64"]>; def TargetWindows : TargetArch<["x86", "x86_64", "arm", "thumb"]> { As far as I'm

Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

2015-12-27 Thread guibufolo+l...@gmail.com via cfe-commits
RedX2501 added a comment. Ping http://reviews.llvm.org/D10833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r256485 - [OPENMP 4.5] Do not allow 'linear' clause along with 'ordered(expr)' clause.

2015-12-27 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Mon Dec 28 00:23:08 2015 New Revision: 256485 URL: http://llvm.org/viewvc/llvm-project?rev=256485=rev Log: [OPENMP 4.5] Do not allow 'linear' clause along with 'ordered(expr)' clause. According to OpenMP 4.5 "A linear clause or an ordered clause with a parameter can be

Re: [PATCH] D15647: [X86] Fix stack alignment for MCU target (Clang part)

2015-12-27 Thread John McCall via cfe-commits
rjmccall added inline comments. Comment at: tools/clang/lib/AST/ASTContext.cpp:1902 @@ +1901,3 @@ + if (Target->getTriple().getArch() == llvm::Triple::xcore || + Target->getTriple().isOSIAMCU()) +return ABIAlign; // Never overalign on XCore and IAMCU.

r256488 - clang-format: Fix incorrect function type detection.

2015-12-27 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Mon Dec 28 01:44:25 2015 New Revision: 256488 URL: http://llvm.org/viewvc/llvm-project?rev=256488=rev Log: clang-format: Fix incorrect function type detection. Before: int x = f ()(); After: int x = f()(); Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp

r256487 - [OPENMP 4.5] Sema/parsing support for extended format of 'schedule' clause.

2015-12-27 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Mon Dec 28 01:25:51 2015 New Revision: 256487 URL: http://llvm.org/viewvc/llvm-project?rev=256487=rev Log: [OPENMP 4.5] Sema/parsing support for extended format of 'schedule' clause. OpenMP 4.0-3.1 supports the next format of ‘schedule’ clause: schedule(kind[, chunk_size])