[PATCH] D16465: [MS ABI] Prevent some expressions from evaluating to a constant

ehsan created this revision. ehsan added a reviewer: rnk. ehsan added a subscriber: cfe-commits. In the Microsoft ABI, some expressions containing references to variables cannot be evaluated as a constant. These are expressions containing a conditional, logical and/or, or comma operator with an

Re: [PATCH] D16344: [libcxx] Fix PR26103 - Error calling is_convertible with incomplete type

mdaniels updated this revision to Diff 45685. http://reviews.llvm.org/D16344 Files: include/type_traits test/std/utilities/meta/meta.rel/is_convertible.pass.cpp Index: test/std/utilities/meta/meta.rel/is_convertible.pass.cpp

Re: [PATCH] D16465: [MS ABI] Prevent some expressions from evaluating to a constant

ehsan added inline comments. Comment at: lib/AST/ExprConstant.cpp:4113 @@ +4112,3 @@ + if (!CheckPotentialExpressionContainingDeclRefExpr(E->getTrueExpr(), + E->getFalseExpr())) +return false;

r258503 - Let RecursiveASTVisitor visit array index VarDecls

Author: nico Date: Fri Jan 22 09:11:54 2016 New Revision: 258503 URL: http://llvm.org/viewvc/llvm-project?rev=258503=rev Log: Let RecursiveASTVisitor visit array index VarDecls An implicit copy ctor creates loop VarDecls that hang off CXXCtorInitializer. RecursiveASTVisitor used to not visit

r258504 - Change of UserLabelPrefix default value from "_" to ""

Author: asbokhan Date: Fri Jan 22 09:24:34 2016 New Revision: 258504 URL: http://llvm.org/viewvc/llvm-project?rev=258504=rev Log: Change of UserLabelPrefix default value from "_" to "" Differential Revision: http://reviews.llvm.org/D16295 Modified: cfe/trunk/lib/Basic/TargetInfo.cpp

Re: [PATCH] D16295: Change of UserLabelPrefix default value from "_" to ""

This revision was automatically updated to reflect the committed changes. Closed by commit rL258504: Change of UserLabelPrefix default value from "_" to "" (authored by asbokhan). Changed prior to commit: http://reviews.llvm.org/D16295?vs=45177=45687#toc Repository: rL LLVM

Re: r258110 - Fix PR26134: When substituting into default template arguments, keep CurContext unchanged.

It seems Richard is out of office, but perhaps he can verify this later. Dimitry: go ahead and merge it (or let me know if you'd like me to). On Fri, Jan 22, 2016 at 12:38 PM, Dimitry Andric wrote: > Hans, > > This change looks pretty trivial, and is required to not crash

[PATCH] D16484: [CUDA] Disallow variadic functions other than printf in device code.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: jhen, echristo, cfe-commits. http://reviews.llvm.org/D16484 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/SemaCUDA/va-arg.cu test/SemaCUDA/vararg.cu Index:

Re: [PATCH] D15624: Add iOS/watchOS/tvOS support for ASan (clang part)

samsonov accepted this revision. samsonov added a reviewer: samsonov. samsonov added a comment. LGTM Comment at: lib/Driver/ToolChains.cpp:339 @@ +338,3 @@ + } +} + You might need `llvm_unreachable` at the very end to suppress GCC warnings

r258564 - AMDGPU: Add barrier builtin

Author: arsenm Date: Fri Jan 22 15:56:30 2016 New Revision: 258564 URL: http://llvm.org/viewvc/llvm-project?rev=258564=rev Log: AMDGPU: Add barrier builtin Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn.cl Modified:

Re: r258110 - Fix PR26134: When substituting into default template arguments, keep CurContext unchanged.

Hans, This change looks pretty trivial, and is required to not crash for the test cases in PR26134. Can we merge it to release_38, please? -Dimitry > On 19 Jan 2016, at 19:28, Dimitry Andric via cfe-commits > wrote: > > Hi Richard, > > I am unsure if you are

Re: [PATCH] D16484: [CUDA] Disallow variadic functions other than printf in device code.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Small nit. LGTM otherwise. Comment at: lib/Sema/SemaDecl.cpp:8291-8293 @@ +8290,5 @@ +// in device-side CUDA code. +if (NewFD->isVariadic() && (NewFD->hasAttr() || +

r258555 - Module debugging: Create a parent DIModule with the PCH name for types

Author: adrian Date: Fri Jan 22 15:14:41 2016 New Revision: 258555 URL: http://llvm.org/viewvc/llvm-project?rev=258555=rev Log: Module debugging: Create a parent DIModule with the PCH name for types emitted into a precompiled header to mirror the debug info emitted for object files importing the

Re: r258110 - Fix PR26134: When substituting into default template arguments, keep CurContext unchanged.

Thanks, I merged it in r258549. -Dimitry > On 22 Jan 2016, at 21:43, Hans Wennborg wrote: > > It seems Richard is out of office, but perhaps he can verify this later. > > Dimitry: go ahead and merge it (or let me know if you'd like me to). > > On Fri, Jan 22, 2016 at 12:38

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

silvas added inline comments. Comment at: lib/Driver/Tools.cpp:3279 @@ -3278,1 +3278,3 @@ + + Args.AddAllArgs(CmdArgs, options::OPT_fprofile_ir_instr); } xur wrote: > mcrosier wrote: > > I don't think AddAllArgs is what you really want. What if the user > >

Re: [PATCH] D15599: [CodeGen] Fix a crash that occurs when attribute "naked" is attached to a c++ member function

ahatanak added inline comments. Comment at: lib/CodeGen/CodeGenFunction.cpp:1962 @@ +1961,3 @@ +for (auto *U : I->users()) + InstrsToRemove.push_back(cast(U)); + manmanren wrote: > Do we need to check if the user has been erased? I am not sure if the

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

xur added inline comments. Comment at: lib/Driver/Tools.cpp:3279 @@ -3278,1 +3278,3 @@ + + Args.AddAllArgs(CmdArgs, options::OPT_fprofile_ir_instr); } mcrosier wrote: > I don't think AddAllArgs is what you really want. What if the user specifies > the option

[PATCH] D16480: [libcxx] NFC: suppress warning on systems where sizeof(int) == sizeof(long)

bcraig created this revision. bcraig added a reviewer: mclow.lists. bcraig added a subscriber: cfe-commits. The old code produced a couple of these warnings... src/string.cpp:95:11: warning: comparison of constant -2147483648 with expression of type 'long' (range [-2147483648, 2147483647]) is

Re: [PATCH] D16376: clang-tidy check: User-defined copy without assignment

jbcoe added inline comments. Comment at: clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.cpp:52 @@ +51,3 @@ + hasDescendant( + cxxMethodDecl(isMoveAssignmentOperator(), unless(isImplicit())) + .bind("move-assignment")),

r258550 - [OpenMP] Remove '#if 1' hanging in target_map_messages.cpp.

Author: sfantao Date: Fri Jan 22 14:52:54 2016 New Revision: 258550 URL: http://llvm.org/viewvc/llvm-project?rev=258550=rev Log: [OpenMP] Remove '#if 1' hanging in target_map_messages.cpp. Modified: cfe/trunk/test/OpenMP/target_map_messages.cpp Modified:

Re: [PATCH] D16444: AMDGPU: Rename builtins to use amdgcn prefix

arsenm closed this revision. arsenm added a comment. r258560 http://reviews.llvm.org/D16444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r258560 - AMDGPU: Rename builtins to use amdgcn prefix

Author: arsenm Date: Fri Jan 22 15:30:53 2016 New Revision: 258560 URL: http://llvm.org/viewvc/llvm-project?rev=258560=rev Log: AMDGPU: Rename builtins to use amdgcn prefix Keep the ones still used by libclc around for now. Emit the new amdgcn intrinsic name if not targeting r600, in which case

Re: [PATCH] D16484: [CUDA] Disallow variadic functions other than printf in device code.

jlebar updated this revision to Diff 45736. jlebar marked an inline comment as done. jlebar added a comment. Add check for extern "C" printf -- we don't want to take just any printf! http://reviews.llvm.org/D16484 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

silvas added a comment. In http://reviews.llvm.org/D15829#333902, @davidxl wrote: > For the longer term, one possible solution is to make FE based > instrumentation only used for coverage testing which can be turned on > with -fcoverage-mapping option (currently, -fcoverage-mapping can not >

Re: [PATCH] D16179: [clang-tidy] Handle decayed types and other improvements in VirtualNearMiss check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL258562: [clang-tidy] Handle decayed types and other improvements in VirtualNearMiss… (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D16179?vs=45482=45739#toc Repository: rL

[clang-tools-extra] r258562 - [clang-tidy] Handle decayed types and other improvements in VirtualNearMiss check.

Author: xazax Date: Fri Jan 22 15:45:51 2016 New Revision: 258562 URL: http://llvm.org/viewvc/llvm-project?rev=258562=rev Log: [clang-tidy] Handle decayed types and other improvements in VirtualNearMiss check. Handle decayed types, ignore qualifiers and accessibility when considering a method

[PATCH] D16482: Add builtins for bitreverse intrinsic

arsenm created this revision. arsenm added a reviewer: jmolloy. arsenm added a subscriber: cfe-commits. Follow the naming convention that bswap uses since it's a similar sort of operation. http://reviews.llvm.org/D16482 Files: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp

r258543 - [OpenMP] Update map clause SEMA to support OpenMP 4.5 possible list items.

Author: sfantao Date: Fri Jan 22 14:21:36 2016 New Revision: 258543 URL: http://llvm.org/viewvc/llvm-project?rev=258543=rev Log: [OpenMP] Update map clause SEMA to support OpenMP 4.5 possible list items. Summary: Extend support in the map clause SEMA for the expressions supported in the OpenMP

Re: [PATCH] D16376: clang-tidy check: User-defined copy without assignment

jbcoe updated this revision to Diff 45729. jbcoe added a comment. Added handling for move-constructor/move-assignment pairs. http://reviews.llvm.org/D16376 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.cpp

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

davidxl added a comment. For the longer term, one possible solution is to make FE based instrumentation only used for coverage testing which can be turned on with -fcoverage-mapping option (currently, -fcoverage-mapping can not be used alone and must be used together with

Re: [PATCH] D16286: [clang-tidy] Readability check for redundant parenthesis in return expression.

LegalizeAdulthood added a comment. As a general comment, I am continually fascinated by the **huge** variety of opinion as to matters of readability within the C++ community. I don't know why we have so many differing opinions compared to the communities built around other programming

Re: [PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

Thank you for fixing this! On Fri, Jan 22, 2016 at 12:30 PM, Nico Weber wrote: > I implemented Reid's suggestion in 258545. I tested that the test runs and > passes when the DIA SDK is around (this is usually the case), and doesn't > run when it isn't. > > On Thu, Jan 21,

[PATCH] D16469: Pass --wrap=pthread_create to linker for -fsplit-stack

hjl.tools created this revision. hjl.tools added a reviewer: rsmith. hjl.tools added a subscriber: cfe-commits. From https://gcc.gnu.org/ml/gcc-patches/2010-09/msg01807.html -fsplit-stack should pass --wrap=pthread_create to linker for -fsplit-stack It is needed to initialize the stack guard.

r258519 - Fix a typo in r258507 and change the PCH dwoid constant to ~1UL.

Author: adrian Date: Fri Jan 22 12:46:45 2016 New Revision: 258519 URL: http://llvm.org/viewvc/llvm-project?rev=258519=rev Log: Fix a typo in r258507 and change the PCH dwoid constant to ~1UL. rdar://problem/24290667 Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

r258518 - Fix 80-column violations.

Author: adrian Date: Fri Jan 22 12:46:40 2016 New Revision: 258518 URL: http://llvm.org/viewvc/llvm-project?rev=258518=rev Log: Fix 80-column violations. Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp URL:

[libcxx] r258511 - unordered: Rename __construct_node_hash() to allow forwarding, NFC

Author: dexonsmith Date: Fri Jan 22 12:27:26 2016 New Revision: 258511 URL: http://llvm.org/viewvc/llvm-project?rev=258511=rev Log: unordered: Rename __construct_node_hash() to allow forwarding, NFC Rename the version of __construct_node() that takes a hash as an argument to

[PATCH] D16475: Remove autoconf support

beanz created this revision. beanz added reviewers: echristo, chandlerc, grosbach, bob.wilson. beanz added a subscriber: cfe-commits. Herald added a subscriber: klimek. This patch is provided in preparation for removing autoconf on 1/26. The proposal to remove autoconf on 1/26 was discussed on

[PATCH] D16478: Always build a new TypeSourceInfo for function templates with parameters

thakis created this revision. thakis added reviewers: rsmith, rnk. thakis added a subscriber: cfe-commits. Herald added subscribers: aemerson, klimek. RecursiveASTVisitor::TraverseFunctionHelper() traverses a function's ParmVarDecls by going to the function's getTypeSourceInfo if it exists, and

r258526 - Rephrase this test to help debug a buildbot issue

Author: adrian Date: Fri Jan 22 13:14:24 2016 New Revision: 258526 URL: http://llvm.org/viewvc/llvm-project?rev=258526=rev Log: Rephrase this test to help debug a buildbot issue Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp URL:

Re: [PATCH] D15670: Accept elided commas in macro function arguments for MS compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rL258530: [MSVC Compat] Accept elided commas in macro function arguments (authored by ehsan). Changed prior to commit: http://reviews.llvm.org/D15670?vs=43310=45718#toc Repository: rL LLVM

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

> On 2016-Jan-21, at 23:14, Eric Fiselier wrote: > > EricWF added a comment. > >> - Did I successfully match the coding style? (I'm kind of lost without >> clang-format TBH.) > > > The style looks pretty good. I'll comment on any nits I have. > >> - Should I separate the

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

xur updated this revision to Diff 45708. xur added a comment. This new patches integrates Sean review comments: (1) make -fprofile-ir-instr a cc1 option instead of driver option. (2) add one cc1 option test, and test the pass is indeed invoked. (3) remove the driver test (runtime library). (4)

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

mcrosier added a subscriber: mcrosier. mcrosier added a comment. Would it make sense to include an additional test (in test/Driver) that shows the -fprofile-ir-instr option being passed from the driver to the frontend? Such a test case would land in clang_f_opt.c, which has many examples.

Re: [PATCH] D15670: Accept elided commas in macro function arguments for MS compatibility

ehsan added a comment. Sure. I'd be happy to address any comments post-landing. Thanks! http://reviews.llvm.org/D15670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r258531 - Fix the build by using the correct suffix for 64 bit literals

Author: adrian Date: Fri Jan 22 13:29:41 2016 New Revision: 258531 URL: http://llvm.org/viewvc/llvm-project?rev=258531=rev Log: Fix the build by using the correct suffix for 64 bit literals Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

r258517 - [analyzer] SATestBuild.py: Handle spaces in path passed to --use-analyzer.

Author: dcoughlin Date: Fri Jan 22 12:45:22 2016 New Revision: 258517 URL: http://llvm.org/viewvc/llvm-project?rev=258517=rev Log: [analyzer] SATestBuild.py: Handle spaces in path passed to --use-analyzer. I missed this one in r258493. Modified: cfe/trunk/utils/analyzer/SATestBuild.py

Re: [PATCH] D16376: clang-tidy check: User-defined copy without assignment

jbcoe planned changes to this revision. jbcoe added a comment. i need the matcher from http://reviews.llvm.org/D16470 to add a corresponding pair of checks and fixes for move-constructors and move-assignment. http://reviews.llvm.org/D16376 ___

Re: r258530 - [MSVC Compat] Accept elided commas in macro function arguments

Do you mean only a warning for the case this patch is handling, or also for cases such as the second test case in https://llvm.org/bugs/show_bug.cgi?id=25875#c1 too? (I think it would probably be a good idea to warn in both cases.) On Fri, Jan 22, 2016 at 2:39 PM, Nico Weber

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

On Thu, Jan 21, 2016 at 7:32 PM, Sean Silva wrote: > silvas added a comment. > > @slingn and I had a discussion offline about the potential names and came up > with some ideas, but none is a clear winner. > > Overall, my feeling is that from a user's perspective, the

Re: [PATCH] D15624: Add iOS/watchOS/tvOS support for ASan (clang part)

zaks.anna updated this revision to Diff 45720. zaks.anna added a comment. Thanks for spotting the bug! The bug is fixed and the tests are added in this revision. http://reviews.llvm.org/D15624 Files: lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h test/Driver/darwin-sanitizer-ld.c

Re: [PATCH] D16438: Fix printing of types in initializers with suppressed tags.

nick.sumner retitled this revision from "Fix printing of nested variable declarations with suppressed tags" to "Fix printing of types in initializers with suppressed tags.". nick.sumner updated the summary for this revision. nick.sumner updated this revision to Diff 45658. nick.sumner added a

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

silvas added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:440 @@ +439,3 @@ + if (CodeGenOpts.ProfileIRInstr) { +// Should not have ProfileInstrGenerate set -- it is for clang +// instrumentation only. Then change the existing references in

Re: [PATCH] D16377: Ensure virtual-near-miss does not crash on functions without names

alexfh added a subscriber: alexfh. alexfh added a comment. Should be fixed in http://reviews.llvm.org/D16179. http://reviews.llvm.org/D16377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

I'll upload a new patch in a moment. Replies inline below. > On 2016-Jan-21, at 23:12, Eric Fiselier wrote: > > EricWF added a comment. > > Overall the patch looks good but I have a few concerns. > >> - If argument.first can be trivially converted to key_type, don't alloc. > >

Re: [PATCH] D15699: [cfi] Cross-DSO CFI diagnostic mode (clang part)

eugenis added a comment. ping Repository: rL LLVM http://reviews.llvm.org/D15699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16152: [clang-tidy] Add check performance-faster-string-find

alexfh added inline comments. Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:30 @@ +29,3 @@ +Class = Class.trim(); +if (!Class.empty()) + Result.push_back(Class); aaron.ballman wrote: > > Also changed the separator to be ';' instead of

Re: [PATCH] D5023: [analyzer] Fix ObjC Dealloc Checker to operate only on classes with retained properties

dcoughlin updated this revision to Diff 45756. dcoughlin marked 6 inline comments as done. dcoughlin added a comment. I've updated ddkilzer's patch to address Jordan's last round of comments. Specifically, I have: - Changed the patch to use isObjCRetainableType() to additional warn about

Re: [PATCH] D15921: [analyzer] Utility to match function calls.

This revision was automatically updated to reflect the committed changes. Closed by commit rL258572: [analyzer] Utility to match function calls. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D15921?vs=44721=45748#toc Repository: rL LLVM

Re: [PATCH] D16377: Ensure virtual-near-miss does not crash on functions without names

Should be fixed in http://reviews.llvm.org/D16179. On Jan 20, 2016 23:55, "Aaron Ballman" wrote: > aaron.ballman updated this revision to Diff 45451. > aaron.ballman added a comment. > > Now checking that both the base *and* the derived functions have names. > > >

r258572 - [analyzer] Utility to match function calls.

Author: xazax Date: Fri Jan 22 16:32:46 2016 New Revision: 258572 URL: http://llvm.org/viewvc/llvm-project?rev=258572=rev Log: [analyzer] Utility to match function calls. This patch adds a small utility to match function calls. This utility abstracts away the mutable keywords and the lazy

[libcxx] r258575 - unordered_map: Reuse insert logic in emplace when possible, NFC

Author: dexonsmith Date: Fri Jan 22 16:48:02 2016 New Revision: 258575 URL: http://llvm.org/viewvc/llvm-project?rev=258575=rev Log: unordered_map: Reuse insert logic in emplace when possible, NFC An upcoming commit will add an optimization to insert() that avoids unnecessary mallocs when we can

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

dexonsmith updated this revision to Diff 45758. dexonsmith added a comment. Committed r258511 and r258575 as preps. Updated patch addresses review comments (and skips the trivially constructible parts). http://reviews.llvm.org/D16360 Files: include/__hash_table include/unordered_map

r258495 - [OPENMP] Generalize codegen for 'sections'-based directive.

Author: abataev Date: Fri Jan 22 02:56:50 2016 New Revision: 258495 URL: http://llvm.org/viewvc/llvm-project?rev=258495=rev Log: [OPENMP] Generalize codegen for 'sections'-based directive. If 'sections' directive has only one sub-section, the code for 'single'-based directive was emitted.

Re: [PATCH] D16401: [OpenMP] Sema for depend clause on target exit data directive.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D16401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16413: Let RecursiveASTVisitor visit array index VarDecls

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG. I'd probably add a test to unittests/Tooling/RecursiveASTVisitorTest.cpp. http://reviews.llvm.org/D16413 ___ cfe-commits mailing list

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

danielmarjamaki added a comment. In http://reviews.llvm.org/D16310#331538, @LegalizeAdulthood wrote: > If you state what the check does, then > > In http://reviews.llvm.org/D16310#331054, @danielmarjamaki wrote: > > > In http://reviews.llvm.org/D16310#330367, @LegalizeAdulthood wrote: > > > > >

Re: [PATCH] D15921: [analyzer] Utility to match function calls.

krasin added a subscriber: krasin. krasin added a comment. FYI: this revision has likely broken the build: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/9561 FAIL: Clang :: Analysis/simple-stream-checks.c (367 of 8927) - TEST 'Clang :: Analysis/simple-stream-checks.c'

[PATCH] D16467: [libcxx] re.results.form: Format out-of-range subexpression references as null

dexonsmith created this revision. dexonsmith added reviewers: EricWF, mclow.lists. dexonsmith added a subscriber: cfe-commits. Rather than crashing in match_results::format() when a reference to a marked subexpression is out of range, format the subexpression as empty (i.e., replace it with an

Re: [PATCH] D8940: Clang changes for indirect call target profiling

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. LGTM. I think we also need a user level option to turn value profiling on/off (in followups). http://reviews.llvm.org/D8940 ___ cfe-commits

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

LegalizeAdulthood added a comment. I find this an interesting discussion. I do not mean to imply that my remarks constitute any sort of demand that this check produce my suggestion for a fixit. In http://reviews.llvm.org/D16310#333416, @danielmarjamaki wrote: > I expect that this warning will

r258500 - Replace some tabs with spaces.

Author: nico Date: Fri Jan 22 08:12:44 2016 New Revision: 258500 URL: http://llvm.org/viewvc/llvm-project?rev=258500=rev Log: Replace some tabs with spaces. Modified: cfe/trunk/unittests/Tooling/RecursiveASTVisitorTest.cpp Modified: cfe/trunk/unittests/Tooling/RecursiveASTVisitorTest.cpp

Re: [PATCH] D16376: clang-tidy check: User-defined copy without assignment

jbcoe added inline comments. Comment at: clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.h:25 @@ +24,3 @@ +/// assignment operator to be `= delete`. +/// +/// For the user-facing documentation see: jbcoe wrote: > The standard says that compiler generation

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

pxli168 updated this revision to Diff 45681. pxli168 marked 4 inline comments as done. pxli168 added a comment. Rewrite some comments and add missing invalid test case. http://reviews.llvm.org/D16040 Files: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td

r258506 - [MSVC Compat] Don't provide /volatile:ms semantics to types > pointer

Author: majnemer Date: Fri Jan 22 10:36:44 2016 New Revision: 258506 URL: http://llvm.org/viewvc/llvm-project?rev=258506=rev Log: [MSVC Compat] Don't provide /volatile:ms semantics to types > pointer Volatile loads of type wider than a pointer get split by MSVC because the base x86 ISA doesn't

Re: [PATCH] D16465: [MS ABI] Prevent some expressions from evaluating to a constant

majnemer added a subscriber: majnemer. majnemer added a comment. Adding @rsmith as a reviewer. http://reviews.llvm.org/D16465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16401: [OpenMP] Sema for depend clause on target exit data directive.

This revision was automatically updated to reflect the committed changes. Closed by commit rL258502: [OpenMP] Sema for depend clause on target exit data directive. (authored by arpith). Changed prior to commit: http://reviews.llvm.org/D16401?vs=45532=45684#toc Repository: rL LLVM

r258502 - [OpenMP] Sema for depend clause on target exit data directive.

Author: arpith Date: Fri Jan 22 08:58:21 2016 New Revision: 258502 URL: http://llvm.org/viewvc/llvm-project?rev=258502=rev Log: [OpenMP] Sema for depend clause on target exit data directive. Summary: Accept depend clause on target exit data directive in sema and add test cases. Reviewers:

Re: [PATCH] D16444: AMDGPU: Rename builtins to use amdgcn prefix

tstellarAMD accepted this revision. tstellarAMD added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D16444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16295: Change of UserLabelPrefix default value from "_" to ""

andreybokhanko added a comment. Rafael, thanks for the review! In http://reviews.llvm.org/D16295#329929, @rafael wrote: > I am pretty sure the cases in init.c are wrong as the assembly itself > doesn't use a '_'. > > Having said that, it is probably a good thing to do this in two steps. > So

r258505 - Try to pacify MSVC.

Author: nico Date: Fri Jan 22 09:49:53 2016 New Revision: 258505 URL: http://llvm.org/viewvc/llvm-project?rev=258505=rev Log: Try to pacify MSVC. I'm not sure why it needs these braces, but they help locally. Modified: cfe/trunk/include/clang/AST/RecursiveASTVisitor.h Modified:

Re: r258505 - Try to pacify MSVC.

Fun fact: cl.exe refuses to compile this program: #include void f(std::vector v) { for (int i : v) do {} while(false); } ¯\_(ツ)_/¯ On Fri, Jan 22, 2016 at 10:49 AM, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: nico > Date: Fri Jan 22 09:49:53 2016 > New

Re: [PATCH] D12354: [libcxx] Add global assertion handler for debug mode.

> On 2016-Jan-21, at 22:22, Eric Fiselier wrote: > > > > On Thu, Jan 21, 2016 at 10:35 PM, Duncan P. N. Exon Smith > wrote: > > > On 2016-Jan-21, at 17:59, Eric Fiselier wrote: > > > > EricWF added a comment. > > > > In

r258507 - Module Debugging: Use a nonzero DWO id for precompiled headers.

Author: adrian Date: Fri Jan 22 11:43:43 2016 New Revision: 258507 URL: http://llvm.org/viewvc/llvm-project?rev=258507=rev Log: Module Debugging: Use a nonzero DWO id for precompiled headers. PCH files don't have a module signature and LLVM uses a nonzero DWO id as an indicator for skeleton /

Re: r258507 - Module Debugging: Use a nonzero DWO id for precompiled headers.

On Fri, Jan 22, 2016 at 9:43 AM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Fri Jan 22 11:43:43 2016 > New Revision: 258507 > > URL: http://llvm.org/viewvc/llvm-project?rev=258507=rev > Log: > Module Debugging: Use a nonzero DWO id for precompiled

Re: [PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

hokein marked an inline comment as done. Comment at: clang-tidy/utils/HeaderFileExtensionsUtils.cpp:49 @@ +48,3 @@ + AllHeaderFileExtensions.split(Suffixes, ','); + HeaderFileExtensions.clear(); + for (llvm::StringRef Suffix : Suffixes) { I'm +1 on keeping the

Re: [PATCH] D16152: [clang-tidy] Add check performance-faster-string-find

hokein added a subscriber: hokein. Comment at: clang-tidy/performance/FasterStringFindCheck.h:25 @@ +24,3 @@ +/// The character literal overload is more efficient. +/// +/// For the user-facing documentation see: I think you need to add document about

[PATCH] D16503: [MSVC Compat] Warn when suppressing a trailing comma in macro args

ehsan created this revision. ehsan added a reviewer: thakis. ehsan added a subscriber: cfe-commits. MSVC suppresses a trailing comma if no arguments are passed in place of a variadic argument[1]. This patch adds a -Wmicrosoft warning when accepting such code. [1]

Re: r258530 - [MSVC Compat] Accept elided commas in macro function arguments

On Fri, Jan 22, 2016 at 3:22 PM, Nico Weber wrote: > Every time we accept something in MS mode that isn't standards compliant, > we should accept it with a warning (for stuff that's harmless, an Extension > warning, for stuff that can lead to bugs a Warning warning), unless

[PATCH] D16502: [CUDA] Reject the alias attribute in CUDA device code.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: echristo, jhen, cfe-commits. CUDA (well, strictly speaking, NVPTX) doesn't support aliases. http://reviews.llvm.org/D16502 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDeclAttr.cpp

Re: [PATCH] D12354: [libcxx] Add global assertion handler for debug mode.

On Fri, Jan 22, 2016 at 10:44 AM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > > > On 2016-Jan-21, at 22:22, Eric Fiselier wrote: > > > > > > > > On Thu, Jan 21, 2016 at 10:35 PM, Duncan P. N. Exon Smith < > dexonsm...@apple.com> wrote: > > > > > On 2016-Jan-21, at

Re: [PATCH] D15705: Adding a scripted test for PR25717

ygao updated this revision to Diff 45784. http://reviews.llvm.org/D15705 Files: test/Preprocessor/bigoutput.c test/lit.cfg Index: test/lit.cfg === --- test/lit.cfg +++ test/lit.cfg @@ -491,4 +491,9 @@ if use_gmalloc:

Re: [PATCH] D16480: [libcxx] NFC: suppress warning on systems where sizeof(int) == sizeof(long)

EricWF added a subscriber: EricWF. EricWF added a comment. How are you getting this warning? I can't generate it with Clang 3.8 on 64bit linux with -m32. In that configuration int and long have the same size. http://reviews.llvm.org/D16480 ___

r258594 - [analyzer] SATestBuild.py: Remove html and log when producing reference results.

Author: dcoughlin Date: Fri Jan 22 19:09:07 2016 New Revision: 258594 URL: http://llvm.org/viewvc/llvm-project?rev=258594=rev Log: [analyzer] SATestBuild.py: Remove html and log when producing reference results. The html reports are huge -- every issue in a given file results in a separate copy

[PATCH] D16498: AMDGPU: Add amdgcn cube builtins

arsenm created this revision. arsenm added a reviewer: tstellarAMD. arsenm added a subscriber: cfe-commits. http://reviews.llvm.org/D16498 Files: include/clang/Basic/BuiltinsAMDGPU.def test/CodeGenOpenCL/builtins-amdgcn.cl Index: test/CodeGenOpenCL/builtins-amdgcn.cl

r258596 - [cfi] Do not emit bit set entry for available_externally vtables.

Author: eugenis Date: Fri Jan 22 19:20:18 2016 New Revision: 258596 URL: http://llvm.org/viewvc/llvm-project?rev=258596=rev Log: [cfi] Do not emit bit set entry for available_externally vtables. In the Itanium ABI, vtable may be emitted speculatively as an available_externally global. Such

[PATCH] D16499: [CUDA] Disable ctor/dtor aliases in device code.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: echristo, jhen, cfe-commits. NVPTX doesn't support aliases, so don't generate them. http://reviews.llvm.org/D16499 Files: lib/Driver/Tools.cpp test/Driver/cuda-constructor-alias.cu Index:

[PATCH] D16501: [CUDA] Don't generate aliases for static extern "C" functions.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: echristo, jhen, cfe-commits. These aliases are done to support inline asm, but there's nothing we can do: NVPTX doesn't support aliases. http://reviews.llvm.org/D16501 Files: lib/CodeGen/CodeGenModule.cpp

r258591 - [analyzer] Fixup r258572 Utility to match function calls.

Author: zaks Date: Fri Jan 22 18:45:37 2016 New Revision: 258591 URL: http://llvm.org/viewvc/llvm-project?rev=258591=rev Log: [analyzer] Fixup r258572 Utility to match function calls. Initialize the IdentifierInfo pointer. Hope this fixes the buildbot breakage. Modified:

[libcxx] r258593 - Fix test to pass in C++03

Author: marshall Date: Fri Jan 22 19:02:29 2016 New Revision: 258593 URL: http://llvm.org/viewvc/llvm-project?rev=258593=rev Log: Fix test to pass in C++03 Modified: libcxx/trunk/test/libcxx/utilities/meta/is_referenceable.pass.cpp Modified:

r258598 - SemaOpenMP.cpp: Fix a warning in r258543. [-Wunused-variable]

Author: chapuni Date: Fri Jan 22 19:38:20 2016 New Revision: 258598 URL: http://llvm.org/viewvc/llvm-project?rev=258598=rev Log: SemaOpenMP.cpp: Fix a warning in r258543. [-Wunused-variable] Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp URL:

  1   2   >