Re: [PATCH] D16613: Introduce a cmake module to figure out whether we need to link with libatomic.

dsanders added a comment. FWIW, the changes in the last revision look minor to me. I doubt it affects the LGTM > Do we have any test cases for arbitrary sized trivally copyable structures? > That might also be needed. The failures in 3.8.0rc1 (and presumably still occur in the 3.8.0rc2 that

r259637 - Reduce initial Sema memory consumption by 400KB. By Elisavet Sakellari.

Author: axel Date: Wed Feb 3 04:45:22 2016 New Revision: 259637 URL: http://llvm.org/viewvc/llvm-project?rev=259637=rev Log: Reduce initial Sema memory consumption by 400KB. By Elisavet Sakellari. Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp URL:

RE: [cfe-commits] r170428 [1/3] - in /cfe/trunk: include/clang/AST/ include/clang/Basic/ include/clang/Sema/ include/clang/Serialization/ lib/AST/ lib/CodeGen/ lib/Parse/ lib/Sema/ lib/Serialization/

Hi Richard, Since these are OpenCL specific types, I think you are right, these types shouldn't be part of the C++ ABI library. Thanks Guy -Original Message- From: meta...@gmail.com [mailto:meta...@gmail.com] On Behalf Of Richard Smith Sent: Wednesday, February 03, 2016 02:46 To:

Re: [PATCH] D14471: [AArch64] Fix a crash in driver

rengolin added subscribers: labrinea, bsmith. rengolin added a comment. Hi, I think it's clear now to me that this strategy isn't going to work. What you need is to add support for AArch64 in the TargetParser and simplify the name matching in the same way we did for ARM. There really is no

Re: [PATCH] D16801: [OpenMP] Change in initial size of DSAStackTy::StackTy

karies added a subscriber: karies. karies closed this revision. karies added a comment. Committed as r259637 http://reviews.llvm.org/D16801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r259639 - -inline-asm][X86] Add ability to use AVX512 in MS inline asm

Author: myatsina Date: Wed Feb 3 05:32:08 2016 New Revision: 259639 URL: http://llvm.org/viewvc/llvm-project?rev=259639=rev Log: -inline-asm][X86] Add ability to use AVX512 in MS inline asm Defined the new AVX512 registers in clang inline asm. Fixed a bug in the MC subtarget info creation

[clang-tools-extra] r259640 - clang-tidy: [misc-unused-parameters] Ignore template instantiations.

Author: djasper Date: Wed Feb 3 05:33:18 2016 New Revision: 259640 URL: http://llvm.org/viewvc/llvm-project?rev=259640=rev Log: clang-tidy: [misc-unused-parameters] Ignore template instantiations. No functional changes intended as we should already do the corresponding fixes when visiting the

Re: [PATCH] D16376: clang-tidy check: rule-of-five

jbcoe marked an inline comment as done. jbcoe added a comment. I think I'll move this check to `cppcoreguidelines` and call it `rule-of-five`. https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#c21-if-you-define-or-delete-any-default-operation-define-or-delete-them-all

Re: [PATCH] D16376: clang-tidy check: rule-of-five

jbcoe retitled this revision from "clang-tidy check: Assignment and Construction" to "clang-tidy check: rule-of-five". jbcoe removed rL LLVM as the repository for this revision. jbcoe updated this revision to Diff 46775. jbcoe added a comment. I've responded to review comments (thanks for those)

Re: [PATCH] D16539: [FIX] 26194 - LLVM crash in CXXNameMangler::mangleType

ichesnokov added a comment. I noticed that MicrosoftMangler already has many extension functions. I.e. this MicrosoftMangler.cpp change is Ok. Please review and accept/commit. http://reviews.llvm.org/D16539 ___ cfe-commits mailing list

[PATCH] D16851: Update of "GCC extensions not implemented yet" in Clang User's Manual

andreybokhanko created this revision. andreybokhanko added a reviewer: rsmith. andreybokhanko added a subscriber: cfe-commits. #pragma weak, global register variables and static initialization of flexible array members are supported, so I removed them from "GCC extensions not implemented yet"

[clang-tools-extra] r259643 - [clang-tidy] bug fix: Don't warn on partial template specialization in `misc-definitions-in-headers` check.

Author: hokein Date: Wed Feb 3 06:10:27 2016 New Revision: 259643 URL: http://llvm.org/viewvc/llvm-project?rev=259643=rev Log: [clang-tidy] bug fix: Don't warn on partial template specialization in `misc-definitions-in-headers` check. Reviewers: alexfh Subscribers: cfe-commits Differential

r259647 - Forgot to remove file in previous commit.

Author: ygribov Date: Wed Feb 3 07:36:31 2016 New Revision: 259647 URL: http://llvm.org/viewvc/llvm-project?rev=259647=rev Log: Forgot to remove file in previous commit. Removed: cfe/trunk/test/Analysis/analyze_display_progress.c Removed: cfe/trunk/test/Analysis/analyze_display_progress.c

Re: [PATCH] D16539: [FIX] 26194 - LLVM crash in CXXNameMangler::mangleType

ichesnokov updated the summary for this revision. ichesnokov updated this revision to Diff 46772. ichesnokov added a comment. This diff adds mangling check test cases for Itanium and Microsoft manglers http://reviews.llvm.org/D16539 Files: lib/AST/ItaniumMangle.cpp

r259646 - [analyzer] AnalysisConsumer: print fully-qualified function name while displaying progress

Author: ygribov Date: Wed Feb 3 07:35:33 2016 New Revision: 259646 URL: http://llvm.org/viewvc/llvm-project?rev=259646=rev Log: [analyzer] AnalysisConsumer: print fully-qualified function name while displaying progress -analyzer-display progress option prints only function names which may be

Re: [PATCH] D16804: [analyzer] AnalysisConsumer: print fully-qualified function name while displaying progress

This revision was automatically updated to reflect the committed changes. Closed by commit rL259646: [analyzer] AnalysisConsumer: print fully-qualified function name while… (authored by ygribov). Changed prior to commit: http://reviews.llvm.org/D16804?vs=46640=46777#toc Repository: rL LLVM

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste added a comment. Hi Anna, thanks for having a look once more! Comment at: tools/clang/lib/StaticAnalyzer/Checkers/Checkers.td:75 @@ -74,1 +74,3 @@ +def MPI : Package<"mpi">; + zaks.anna wrote: > This should probably go under the 'option'

Re: [PATCH] D16808: [MCU] PR26438: Fix assertion failure on function returning an empty struct or union

hjl.tools added a comment. I am planning to update i386, x86-64 and IA MCU psABIs to address how to pass and return C++ empty class after resolving: https://llvm.org/bugs/show_bug.cgi?id=26337 by updating C++ ABI to explicitly pass and return C++ empty class like C empty structure.

Re: [PATCH] D16638: [CUDA] Added device-side system call decls and related wrappers.

tra closed this revision. tra added a comment. Committed in r259690 http://reviews.llvm.org/D16638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13893: Roll-back r250822.

ariccio added a comment. See original diff here: http://reviews.llvm.org/D13890 Repository: rL LLVM http://reviews.llvm.org/D13893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13893: Roll-back r250822.

ariccio added a subscriber: ariccio. ariccio added a comment. Whatever happened to this? What in `ASTMatchers` did it break? It seems like a good change, and nobody followed up to fix it? Repository: rL LLVM http://reviews.llvm.org/D13893 ___

Re: r258782 - Recommit: R258773 [OpenCL] Pipe builtin functions

On Wed, Feb 3, 2016 at 1:00 PM, Richard Smith wrote: > On Wed, Feb 3, 2016 at 11:08 AM, Anastasia Stulova > wrote: >> >> I think the main reason is that we have committed pipe type before the >> release branch was taken. It appears to have no use

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

yaxunl updated this revision to Diff 46838. yaxunl marked 3 inline comments as done. yaxunl added a comment. Revised as Anastasia suggested. http://reviews.llvm.org/D16686 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticParseKinds.td

r259690 - [CUDA] added declarations for device-side system calls

Author: tra Date: Wed Feb 3 14:53:58 2016 New Revision: 259690 URL: http://llvm.org/viewvc/llvm-project?rev=259690=rev Log: [CUDA] added declarations for device-side system calls ...and std:: wrappers for free/malloc. Modified: cfe/trunk/lib/Headers/__clang_cuda_runtime_wrapper.h

Re: [PATCH] D16259: Add clang-tidy readability-redundant-control-flow check

On Mon, Feb 1, 2016 at 4:32 PM, Aaron Ballman wrote: > > > Comment at: clang-tidy/readability/RedundantControlFlowCheck.cpp:60 > @@ +59,3 @@ > + if (const auto *Return = dyn_cast(*last)) > +issueDiagnostic(Result, Block, Return->getSourceRange(), > +

Re: [PATCH] D16376: clang-tidy check: rule-of-five

On Wed, Feb 3, 2016 at 1:03 PM, Jonathan Coe wrote: > > > On 3 February 2016 at 18:44, David Blaikie wrote: > >> >> >> On Wed, Feb 3, 2016 at 10:23 AM, Jonathan Coe wrote: >> >>> All the C++ compilers I have tried using (GCC,Clang,MSVC) will

Re: [PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

sfantao updated this revision to Diff 46825. sfantao marked 4 inline comments as done. sfantao added a comment. Clean up changes that are not required now. Use CGOpenMPRuntime to contain everything that requires sharing. Create diagnostic to notify user about unsupported OpenMP targets.

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

bcraig added a comment. @mclow.lists ping http://reviews.llvm.org/D15539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16376: clang-tidy check: rule-of-five

On Wed, Feb 3, 2016 at 4:13 PM, David Blaikie wrote: > > > On Wed, Feb 3, 2016 at 1:03 PM, Jonathan Coe wrote: >> >> >> >> On 3 February 2016 at 18:44, David Blaikie wrote: >>> >>> >>> >>> On Wed, Feb 3, 2016 at 10:23 AM, Jonathan Coe

Re: [PATCH] D16259: Add clang-tidy readability-redundant-control-flow check

On Wed, Feb 3, 2016 at 3:57 PM, Kim Gräsman wrote: > On Mon, Feb 1, 2016 at 4:32 PM, Aaron Ballman wrote: >> >> >> Comment at: clang-tidy/readability/RedundantControlFlowCheck.cpp:60 >> @@ +59,3 @@ >> + if (const auto *Return =

r259715 - Revert r259624 - Make CF constant string decl visible to name lookup to fix module errors.

Author: qcolombet Date: Wed Feb 3 16:14:53 2016 New Revision: 259715 URL: http://llvm.org/viewvc/llvm-project?rev=259715=rev Log: Revert r259624 - Make CF constant string decl visible to name lookup to fix module errors. This breaks some internal bots in stage2: clang seg fault. Looking with

Re: [PATCH] D16823: [cfi] Safe handling of unaddressable vtable pointers (clang).

eugenis closed this revision. eugenis added a comment. http://llvm.org/viewvc/llvm-project?rev=259716=rev Repository: rL LLVM http://reviews.llvm.org/D16823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16044: getVariableName() for MemRegion

Alexander_Droste added a comment. Comment at: tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:662 @@ +661,3 @@ +else if (auto SV = +ER->getIndex().getAs()) { +llvm::SmallString<8> buf; Alexander_Droste wrote: > xazax.hun wrote: > > These

Re: [PATCH] D16376: clang-tidy check: rule-of-five

On 3 February 2016 at 18:44, David Blaikie wrote: > > > On Wed, Feb 3, 2016 at 10:23 AM, Jonathan Coe wrote: > >> All the C++ compilers I have tried using (GCC,Clang,MSVC) will generate >> assignment operators even if the user defines a copy-constructor. This

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

On Wed, Feb 3, 2016 at 12:40 PM, Bob Wilson wrote: > > On Feb 3, 2016, at 12:23 PM, Xinliang David Li wrote: > > On Tue, Feb 2, 2016 at 1:31 PM, Bob Wilson wrote: > > > On Jan 22, 2016, at 1:43 PM, Sean Silva via cfe-commits >

r259716 - [cfi] Safe handling of unaddressable vtable pointers (clang).

Author: eugenis Date: Wed Feb 3 16:18:55 2016 New Revision: 259716 URL: http://llvm.org/viewvc/llvm-project?rev=259716=rev Log: [cfi] Safe handling of unaddressable vtable pointers (clang). Avoid crashing when printing diagnostics for vtable-related CFI errors. In diagnostic mode, the frontend

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

On Tue, Feb 2, 2016 at 1:31 PM, Bob Wilson wrote: > >> On Jan 22, 2016, at 1:43 PM, Sean Silva via cfe-commits >> wrote: >> >> silvas added a comment. >> >> In http://reviews.llvm.org/D15829#333902, @davidxl wrote: >> >>> For the longer term,

Re: [PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

sfantao added a comment. Hi Alexey, Thanks again for the review! Comment at: lib/CodeGen/CGOpenMPRuntimeCommon.h:1 @@ +1,2 @@ +//=== CGOpenMPRuntimeCommon.h - Helpers for OpenMP Runtimes Codegen ==// +// ABataev wrote: > I don't think we need this new

r259687 - Refactor conversion of deduced template arguments to reduce repetition.

Author: rsmith Date: Wed Feb 3 14:15:01 2016 New Revision: 259687 URL: http://llvm.org/viewvc/llvm-project?rev=259687=rev Log: Refactor conversion of deduced template arguments to reduce repetition. Modified: cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp Modified:

Re: [PATCH] D16638: [CUDA] Added device-side system call decls and related wrappers.

tra updated this revision to Diff 46818. tra added a comment. Updated comment. http://reviews.llvm.org/D16638 Files: lib/Headers/__clang_cuda_runtime_wrapper.h Index: lib/Headers/__clang_cuda_runtime_wrapper.h === ---

Re: [PATCH] D13893: Roll-back r250822.

angelgarcia added a subscriber: angelgarcia. angelgarcia added a comment. The compiler complained about creating constant instances of classes without a user provided constructor (which is the case for the ASTMatchers). I gave up this change because it broke the build for a huge amount of people

Re: [PATCH] D16376: clang-tidy check: rule-of-five

On Wed, Feb 3, 2016 at 1:40 PM, Aaron Ballman wrote: > On Wed, Feb 3, 2016 at 4:13 PM, David Blaikie wrote: > > > > > > On Wed, Feb 3, 2016 at 1:03 PM, Jonathan Coe wrote: > >> > >> > >> > >> On 3 February 2016 at 18:44, David

Re: [PATCH] D16638: [CUDA] Added device-side system call decls and related wrappers.

jlebar added a comment. lgtm. Thank you. http://reviews.llvm.org/D16638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13893: Roll-back r250822.

The compiler complained about creating constant instances of classes without a user provided constructor (which is the case for the ASTMatchers). I gave up this change because it broke the build for a huge amount of people and I didn't want that to happen again.

Re: [PATCH] D15636: Reduce false positives in printf/scanf format checker

AndyG added a comment. Thoughts? Am I good to go? Cheers, Andy http://reviews.llvm.org/D15636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16692: [OpenCL] Eliminate warning when declaring OpenCL builtin functions

yaxunl closed this revision. yaxunl added a comment. committed http://reviews.llvm.org/D16692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

> On Feb 3, 2016, at 12:23 PM, Xinliang David Li wrote: > > On Tue, Feb 2, 2016 at 1:31 PM, Bob Wilson > wrote: >> >>> On Jan 22, 2016, at 1:43 PM, Sean Silva via cfe-commits >>> wrote: >>>

r259688 - Ensure that we substitute into the declaration of a template parameter pack

Author: rsmith Date: Wed Feb 3 14:40:30 2016 New Revision: 259688 URL: http://llvm.org/viewvc/llvm-project?rev=259688=rev Log: Ensure that we substitute into the declaration of a template parameter pack (that is not a pack expansion) during template argument deduction, even if we deduced that

Re: r258782 - Recommit: R258773 [OpenCL] Pipe builtin functions

On Wed, Feb 3, 2016 at 11:08 AM, Anastasia Stulova < anastasia.stul...@arm.com> wrote: > I think the main reason is that we have committed pipe type before the > release branch was taken. It appears to have no use without the pipe > builtin functions. > > Are there any risks of adding this now? >

Re: [PATCH] D16545: [libcxxabi] Enable testing for static libc++abi

bcraig added a comment. ping http://reviews.llvm.org/D16545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16544: [libcxx] Framework to allow testing of static libc++abi

bcraig added a comment. ping http://reviews.llvm.org/D16544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16044: getVariableName() for MemRegion

xazax.hun added inline comments. Comment at: tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:662 @@ +661,3 @@ +else if (auto SV = +ER->getIndex().getAs()) { +llvm::SmallString<8> buf; Alexander_Droste wrote: > Alexander_Droste wrote: > >

Re: [PATCH] D16376: clang-tidy check: rule-of-five

jbcoe planned changes to this revision. jbcoe added a comment. If the destructor is user-declared then I need to `=delete` the compiler-generated copy constructor and copy assignment operator (if they are not defined, if either is defined then they are already handled by this check). The move

Re: [PATCH] D16770: [MS] PR26234: Allow typedef redefinition of equally qualified, sized and aligned types in C

d.zobnin.bugzilla updated this revision to Diff 46781. d.zobnin.bugzilla added a comment. Thanks for the review! Updated the patch according to the comments: allowed only integer, enum and pointer types which have the same qualifiers, signedness, width and alignment. Changed the diagnostic

Re: [PATCH] D16770: [MS] PR26234: Allow typedef redefinition of equally qualified, sized and aligned types in C

d.zobnin.bugzilla marked 5 inline comments as done. Comment at: include/clang/AST/ASTContext.h:1772-1783 @@ -1771,1 +1771,14 @@ + /// Return true is the given typedef types are compatible in C from MSVC's + /// point of view. + // + // Conditions: + // 1. Both typedef

Re: [PATCH] D16759: [OpenMP] Parsing + sema for target parallel for directive.

arpith-jacob marked an inline comment as done. arpith-jacob added a comment. Alexey, I've made the change in the comments. Thanks very much for your time! http://reviews.llvm.org/D16759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12834: add gcc abi_tag support

DmitryPolukhin added a comment. I think Sema part should be exacted to separate patch and committed first after fixing Aaron's comments. Mangling part requires more work and much more tests. I'm still looking what actually GCC does and how it can be re-implemented in Clang without calling

Re: [PATCH] D16482: Add builtins for bitreverse intrinsic

hfinkel added a subscriber: hfinkel. hfinkel accepted this revision. hfinkel added a reviewer: hfinkel. hfinkel added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D16482 ___ cfe-commits mailing list

Re: [PATCH] D16748: Cleanup MemRegion.cpp/MemRegion.h

aaron.ballman closed this revision. aaron.ballman added a comment. LGTM, but the patch does not apply cleanly because it was created using absolute paths. In the future, please generate the patch with relative paths. ;-) Commit in r259652 http://reviews.llvm.org/D16748

r259652 - Minor cleanup to remove casts and improve some const correctness. NFC.

Author: aaronballman Date: Wed Feb 3 09:20:51 2016 New Revision: 259652 URL: http://llvm.org/viewvc/llvm-project?rev=259652=rev Log: Minor cleanup to remove casts and improve some const correctness. NFC. Patch by Alexander Riccio. Modified:

Re: [PATCH] D16376: clang-tidy check: rule-of-five

alexfh added a comment. In http://reviews.llvm.org/D16376#342901, @jbcoe wrote: > I think I'll move this check to `cppcoreguidelines` and call it > `rule-of-five`. Yes, please move it to cppcoreguidelines. >

r259651 - [OpenCL] Adding reserved operator logical xor for OpenCL

Author: stulova Date: Wed Feb 3 09:17:14 2016 New Revision: 259651 URL: http://llvm.org/viewvc/llvm-project?rev=259651=rev Log: [OpenCL] Adding reserved operator logical xor for OpenCL This patch adds the reserved operator ^^ when compiling for OpenCL (spec v1.1 s6.3.g), which results in a

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

danielmarjamaki added a comment. In http://reviews.llvm.org/D13126#335929, @danielmarjamaki wrote: > For information, I am testing this patch right now.. it will take a while 1-2 > days. I have run my latest patch.. In 2215 projects it found 875 warnings. For comparison the -Wconversion

r259648 - Provide match function to look over an entire TU again.

Author: djasper Date: Wed Feb 3 08:29:55 2016 New Revision: 259648 URL: http://llvm.org/viewvc/llvm-project?rev=259648=rev Log: Provide match function to look over an entire TU again. Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchFinder.h

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

yaxunl updated this revision to Diff 46783. yaxunl marked an inline comment as done. yaxunl added a comment. Revised as Xiuli suggested. With the change, there will be quotation marks around the attribute name, so other diagnostics are also changed to be consistent.

[PATCH] D16870: [CUDA] Tweak attribute-based overload resolution to match nvcc behavior.

tra created this revision. tra added reviewers: jlebar, jingyue, jpienaar, eliben. tra added a subscriber: cfe-commits. This is an artefact of split-mode CUDA compilation that we need to mimic. HD functions are sometimes allowed to call H or D functions. Due to split compilation mode device-side

Re: [PATCH] D16700: [Clang-tidy] Make null pointer literals for fixes configurable for two checks

LegalizeAdulthood added inline comments. Comment at: clang-tidy/readability/ImplicitBoolCastCheck.h:32 @@ -30,1 +31,3 @@ +Options.get("NullPointerLiteral", +Context->getLangOpts().CPlusPlus11 ? "nullptr" : "0")) {} void

Re: [PATCH] D16794: [Clang-tidy] Make readability-simplify-boolean-expr working with included files

Eugene.Zelenko added a comment. In http://reviews.llvm.org/D16794#343652, @LegalizeAdulthood wrote: > Again, isn't this already assigned to me in the bug tracker? > > In general, my assumption in bug trackers is that if someone has assigned the > bug to themselves, then they are working on it.

r259728 - Bump DiagnosticSemaKinds count; we're close to hitting it.

Author: mren Date: Wed Feb 3 17:35:29 2016 New Revision: 259728 URL: http://llvm.org/viewvc/llvm-project?rev=259728=rev Log: Bump DiagnosticSemaKinds count; we're close to hitting it. $ grep '= DIAG_START_SEMA' include/clang/Basic/DiagnosticIDs.h DIAG_START_ANALYSIS =

Re: [PATCH] D16794: [Clang-tidy] Make readability-simplify-boolean-expr working with included files

LegalizeAdulthood added a comment. In http://reviews.llvm.org/D16794#341552, @aaron.ballman wrote: > Missing a test case for this functionality. The isExpansionInMainFile() was > used to silence the diagnostic in macros, but it was pointed out during > review that this should be fixed and it

Re: [PATCH] D16794: [Clang-tidy] Make readability-simplify-boolean-expr working with included files

LegalizeAdulthood added a comment. Again, isn't this already assigned to me in the bug tracker? In general, my assumption in bug trackers is that if someone has assigned the bug to themselves, then they are working on it. Repository: rL LLVM http://reviews.llvm.org/D16794

Re: [PATCH] D16748: Cleanup MemRegion.cpp/MemRegion.h

ariccio marked an inline comment as done. ariccio added a comment. Grr! missed a single note. http://reviews.llvm.org/D16748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13893: Roll-back r250822.

ariccio added a comment. In http://reviews.llvm.org/D13893#343436, @angelgarcia wrote: > The compiler complained about creating constant instances of classes > without a user provided constructor (which is the case for the ASTMatchers). > > I gave up this change because it broke the build for a

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

LegalizeAdulthood added a comment. I am already working on fixing this bug (isn't PR25894 already assigned to me?), but what's missing from this patch is an automated test that proves it works. In order to write such an automated test, I believe

r259721 - Reapply r259624, it is likely not the commit causing the bot failures.

Author: qcolombet Date: Wed Feb 3 16:41:00 2016 New Revision: 259721 URL: http://llvm.org/viewvc/llvm-project?rev=259721=rev Log: Reapply r259624, it is likely not the commit causing the bot failures. Original message: Make CF constant string decl visible to name lookup to fix module errors The

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

zaks.anna added inline comments. Comment at: tools/clang/lib/StaticAnalyzer/Checkers/Checkers.td:75 @@ -74,1 +74,3 @@ +def MPI : Package<"mpi">; + Alexander_Droste wrote: > zaks.anna wrote: > > This should probably go under the 'option' package. What do you

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

rsmith added inline comments. Comment at: include/clang/Driver/Options.td:1463 @@ +1462,3 @@ +Group; +def mnofloat128 : Flag<["-"], "mno-float128">, +Group; Per the mangling rules at the top of this file, this should be named `mno_float128`.

Re: [PATCH] D15636: Reduce false positives in printf/scanf format checker

rtrieu added a comment. Oops, forget to hit send on my last comment. My concern is something like: printf(condition ? "first message: %d" : "second message: %d", 5, 10); There's nothing in the code implying that either message is the one that should be using two arguments, so which one will

Re: [PATCH] D16700: [Clang-tidy] Make null pointer literals for fixes configurable for two checks

Eugene.Zelenko added inline comments. Comment at: clang-tidy/readability/ImplicitBoolCastCheck.h:32 @@ -30,1 +31,3 @@ +Options.get("NullPointerLiteral", +Context->getLangOpts().CPlusPlus11 ? "nullptr" : "0")) {} void

Re: [PATCH] D16259: Add clang-tidy readability-redundant-control-flow check

In article

Re: [libcxx] r259682 - re.results.form: Format out-of-range subexpression references as null

Hans, do you mind merging this to the 3.8 branch? Marshall, do you agree this is okay to take? > On 2016-Feb-03, at 11:30, Duncan P. N. Exon Smith via cfe-commits > wrote: > > Author: dexonsmith > Date: Wed Feb 3 13:30:20 2016 > New Revision: 259682 > > URL:

Re: [PATCH] D16738: Fix invalid casts in .

eugenis updated this revision to Diff 46857. eugenis added a comment. How about this? Repository: rL LLVM http://reviews.llvm.org/D16738 Files: include/__config include/functional Index: include/functional === ---

[PATCH] D16873: Refactor MemRegionManager::getVarRegion to call two new functions, improving readability

ariccio created this revision. ariccio added reviewers: aaron.ballman, dcoughlin. ariccio added a subscriber: cfe-commits. Instead of one long function, `MemRegionManager::getVarRegion` now calls `getMemRegionGloballyStored` for global, non-static variables, and `getMemRegionStaticLocal` for

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

hubert.reinterpretcast added a comment. Minor comments; otherwise, LGTM. Comment at: lib/Sema/SemaDecl.cpp:6007 @@ +6006,3 @@ + // applied only to the definition of a [...] variable template, declared + // in namespace scope. [...] A concept definition refers to [...]

r259734 - Fix predefine for __NSConstantString struct type

Author: benlangmuir Date: Wed Feb 3 18:55:24 2016 New Revision: 259734 URL: http://llvm.org/viewvc/llvm-project?rev=259734=rev Log: Fix predefine for __NSConstantString struct type Per review feedback the name was wrong and it can be used outside Objective-C. Unfortunately, making the internal

Re: [PATCH] D16692: [OpenCL] Eliminate warning when declaring OpenCL builtin functions

pxli168 added a comment. I see you have committed this patch, you can try to follow the guide here: http://llvm.org/docs/Phabricator.html#committing-a-change To add something in your commit and then the system will automatic close the diff and have link to the commmit. This will help others to

Re: [PATCH] D16870: [CUDA] Tweak attribute-based overload resolution to match nvcc behavior.

jingyue added inline comments. Comment at: include/clang/Sema/Sema.h:8801 @@ -8798,3 +8800,3 @@ // LangOpts.CUDADisableTargetCallChecks is true. -CFP_Fallback, // Low priority caller/callee combination -CFP_Best, // Preferred caller/callee

Re: [PATCH] D16870: [CUDA] Tweak attribute-based overload resolution to match nvcc behavior.

tra added a comment. When overload set contains h and HD functions that are otherwise equal for overload resolution, you want to be able to tell which one is better. http://reviews.llvm.org/D16870 ___ cfe-commits mailing list

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

pxli168 added inline comments. Comment at: lib/CodeGen/CGLoopInfo.cpp:131 @@ +130,3 @@ +// equivalent LoopHintAttr enums. +// See OpenCL v2.0 s6.11.5 for details. +// 0 corresponds to opencl_unroll_hint attribute without Can you also change this

Re: r259624 - Make CF constant string decl visible to name lookup to fix module errors

Hey Doug, I fixed this in r259734; could you take a glance at that patch too? As I mentioned in person it required more changes than just moving this definition outside the if/fixing the name. Thanks, Ben > On Feb 3, 2016, at 11:50 AM, Ben Langmuir via cfe-commits >

Re: [libcxx] r259682 - re.results.form: Format out-of-range subexpression references as null

I'm OK if Marshall is. Thanks, Hans On Wed, Feb 3, 2016 at 4:59 PM, Duncan P. N. Exon Smith via cfe-commits wrote: > Hans, do you mind merging this to the 3.8 branch? > > Marshall, do you agree this is okay to take? > >> On 2016-Feb-03, at 11:30, Duncan P. N. Exon

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

nwilson updated this revision to Diff 46854. nwilson added a comment. - This update removes the parameter in `TemplateDecl::setConcept` since there isn't a need to mark a concept false. http://reviews.llvm.org/D13357 Files: include/clang/AST/DeclTemplate.h

Re: [PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

alexfh added a comment. Sorry for the delay. A few more comments. Comment at: clang-tidy/google/GlobalNamesInHeadersCheck.cpp:30 @@ +29,3 @@ + RawStringHeaderFileExtensions, HeaderFileExtensions)) { +llvm::errs() << "Invalid header file extension: " +

Re: [PATCH] D16152: [clang-tidy] Add check performance-faster-string-find

sbenza updated this revision to Diff 46798. sbenza added a comment. Make the delimiter a constant and fix mismatch between parse/serialize of the option. http://reviews.llvm.org/D16152 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/FasterStringFindCheck.cpp

Re: [PATCH] D16819: Remove llvm::(cast|isa) from lib/CodeGen/Address.h to fix build with gcc-4.8.1

sugak added a comment. @rsmith: yes, I need someone to commit this. http://reviews.llvm.org/D16819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

hubert.reinterpretcast added inline comments. Comment at: lib/Sema/SemaExpr.cpp:1156-1159 @@ +1155,6 @@ + + QualType LHSElemType = dyn_cast(LHSType) ? +cast(LHSType)->getElementType() : LHSType; + QualType RHSElemType = dyn_cast(RHSType) ? +

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

On Wed, Feb 3, 2016 at 3:52 PM, Hubert Tong < hubert.reinterpretc...@gmail.com> wrote: > hubert.reinterpretcast added inline comments. > > > Comment at: lib/Sema/SemaExpr.cpp:1156-1159 > @@ +1155,6 @@ > + > + QualType LHSElemType = dyn_cast(LHSType) ? > +

Re: [PATCH] D16351: [FIX] Bug 25404 - Crash on typedef in OpenCL 2.0

ichesnokov marked 3 inline comments as done. ichesnokov added a comment. Notice that redefinition of typedef defined at system header will show the same message. http://reviews.llvm.org/D16351 ___ cfe-commits mailing list

Re: [PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

sfantao added a comment. Hi Alexey, Thanks for the feedback! Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:340-341 @@ +339,4 @@ + case llvm::Triple::nvptx64: +assert(CGM.getLangOpts().OpenMPIsDevice && + "OpenMP NVPTX is only prepared to deal with device code.");

Re: [PATCH] D16351: [FIX] Bug 25404 - Crash on typedef in OpenCL 2.0

ichesnokov updated this revision to Diff 46876. ichesnokov marked 2 inline comments as done. ichesnokov added a comment. Test case enriched to check typedef redefinition without warnings. Minor fix of comment. http://reviews.llvm.org/D16351 Files: lib/Sema/SemaDecl.cpp

  1   2   >