Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

This looks like a change to clang - could you test it in clang (& review it on cfe-commits instead of llvm-commits)? On Sat, Feb 6, 2016 at 11:57 AM, David Li via cfe-commits < cfe-commits@lists.llvm.org> wrote: > davidxl created this revision. > davidxl added a reviewer: vsk. > davidxl added

Re: Linux-abi group

* H.J. Lu [2016-02-08 11:24:53 -0800]: > I created a mailing list to discuss Linux specific,.processor independent > modification and extension of generic System V Application Binary Interface: > > https://groups.google.com/d/forum/linux-abi > > I will start to document

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On 8 February 2016 at 19:23, Richard Smith wrote: > "POD for the purpose of layout" is defined in the Itanium C++ ABI here: > > http://mentorembedded.github.io/cxx-abi/abi.html#definitions Thanks. So there's no problem using "POD for the purposes of layout", and the change to "POD for the

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Mon, Feb 8, 2016 at 11:33 AM, Jonathan Wakely wrote: > On 8 February 2016 at 19:23, Richard Smith wrote: >> "POD for the purpose of layout" is defined in the Itanium C++ ABI here: >> >> http://mentorembedded.github.io/cxx-abi/abi.html#definitions > > Thanks. So there's

Re: [PATCH] D16930: Improve literal operator parameter diagnostics.

erik.pilkington updated this revision to Diff 47240. erik.pilkington added a comment. Thanks! This update fixes everything you brought up. http://reviews.llvm.org/D16930 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDeclCXX.cpp test/CXX/over/over.oper/over.literal/p5.cpp

Re: [PATCH] D16962: clang-tidy: avoid std::bind

jbcoe planned changes to this revision. jbcoe added a comment. Placeholder handling needs correcting. Repository: rL LLVM http://reviews.llvm.org/D16962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D16999: [CMake] Improve the clang order-file generation workflow

beanz created this revision. beanz added a reviewer: bogner. beanz added a subscriber: cfe-commits. This commit re-lands r259862. The underlying cause of the build breakage was an incorrectly written capabilities test. In tools/Driver/CMakeLists.txt I was attempting to check if a linker flag

Re: [PATCH] D16873: Refactor MemRegionManager::getVarRegion to call two new functions, improving readability

ariccio added a comment. One of two comments addressed, one question asked. Comment at: llvm/tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:792 @@ +791,3 @@ + +const MemRegion* MemRegionManager::getMemSpaceForLocalVariable(const VarDecl *D, llvm::PointerUnion ) { + const

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Mon, Feb 8, 2016 at 12:05 PM, H.J. Lu wrote: > On Mon, Feb 8, 2016 at 11:33 AM, Jonathan Wakely > wrote: > > On 8 February 2016 at 19:23, Richard Smith wrote: > >> "POD for the purpose of layout" is defined in the Itanium C++ ABI here: > >> > >>

Re: [PATCH] D16930: Improve literal operator parameter diagnostics.

rsmith added a comment. Thanks, this looks good. I think we can make the control flow a little more obvious by moving the `return true;`s right after we emit each diagnostic, and that also lets us remove the `goto`. Comment at: lib/Sema/SemaDeclCXX.cpp:11769 @@ +11768,3 @@

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Mon, Feb 8, 2016 at 12:38 PM, Richard Smith wrote: > On Mon, Feb 8, 2016 at 12:05 PM, H.J. Lu wrote: >> >> On Mon, Feb 8, 2016 at 11:33 AM, Jonathan Wakely >> wrote: >> > On 8 February 2016 at 19:23, Richard Smith wrote: >>

Re: r260126 - Simplify test cases

On Mon, Feb 8, 2016 at 11:14 AM, Xinliang David Li via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: davidxl > Date: Mon Feb 8 13:14:14 2016 > New Revision: 260126 > > URL: http://llvm.org/viewvc/llvm-project?rev=260126=rev > Log: > Simplify test cases > It's handy to mention that

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Mon, Feb 8, 2016 at 10:46 AM, Jonathan Wakely via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 8 February 2016 at 18:31, H.J. Lu wrote: > > On Mon, Feb 8, 2016 at 10:30 AM, Jonathan Wakely > wrote: > >> On 8 February 2016 at 18:26,

Re: [PATCH] D16552: Let clang not error out on `const std::vector empty_vec; ` with libstdc++5.3.

thakis added a comment. ping :-) http://reviews.llvm.org/D16552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

On Mon, Feb 8, 2016 at 9:25 AM, David Li via llvm-commits < llvm-comm...@lists.llvm.org> wrote: > davidxl updated this revision to Diff 47217. > davidxl added a comment. > > Simplified test case suggested by Vedant. > > > http://reviews.llvm.org/D16947 > > Files: > lib/CodeGen/CGClass.cpp >

Re: r260124 - Remove dead code.

On 08/02/16 20:38, Richard Smith wrote: On Mon, Feb 8, 2016 at 11:25 AM, Vassil Vassilev > wrote: On 08/02/16 20:10, Richard Smith via cfe-commits wrote: Author: rsmith Date: Mon Feb 8 13:10:14 2016 New

Re: [PATCH] D16552: Let clang not error out on `const std::vector empty_vec; ` with libstdc++5.3.

rsmith added a comment. Can we implement all of DR253 instead? (That is, don't restrict this change to libstdc++'s types.) We don't have precise wording for DR253 yet, but do have the guidance that "if the implicit default constructor initializes all subobjects, no initializer should be

Re: Linux-abi group

* H. J. Lu: > On Mon, Feb 8, 2016 at 11:32 AM, Florian Weimer wrote: >> * H. J. Lu: >> >>> I created a mailing list to discuss Linux specific,.processor independent >>> modification and extension of generic System V Application Binary Interface: >>> >>>

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

On Mon, Feb 8, 2016 at 11:39 AM, David Blaikie wrote: > > > On Mon, Feb 8, 2016 at 9:25 AM, David Li via llvm-commits > wrote: >> >> davidxl updated this revision to Diff 47217. >> davidxl added a comment. >> >> Simplified test case suggested by

r260126 - Simplify test cases

Author: davidxl Date: Mon Feb 8 13:14:14 2016 New Revision: 260126 URL: http://llvm.org/viewvc/llvm-project?rev=260126=rev Log: Simplify test cases Modified: cfe/trunk/test/Profile/def-ctors.cpp cfe/trunk/test/Profile/def-dtors.cpp Modified: cfe/trunk/test/Profile/def-ctors.cpp URL:

r260124 - Remove dead code.

Author: rsmith Date: Mon Feb 8 13:10:14 2016 New Revision: 260124 URL: http://llvm.org/viewvc/llvm-project?rev=260124=rev Log: Remove dead code. Modified: cfe/trunk/lib/Sema/SemaLookup.cpp Modified: cfe/trunk/lib/Sema/SemaLookup.cpp URL:

Re: r260124 - Remove dead code.

On 08/02/16 20:10, Richard Smith via cfe-commits wrote: Author: rsmith Date: Mon Feb 8 13:10:14 2016 New Revision: 260124 URL: http://llvm.org/viewvc/llvm-project?rev=260124=rev Log: Remove dead code. Modified: cfe/trunk/lib/Sema/SemaLookup.cpp Modified:

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

Both cfe-commits and llvm-commits are cc'ed. David On Mon, Feb 8, 2016 at 11:29 AM, David Blaikie wrote: > This looks like a change to clang - could you test it in clang (& review it > on cfe-commits instead of llvm-commits)? > > On Sat, Feb 6, 2016 at 11:57 AM, David Li via

Re: [PATCH] D16934: [Coverage] Fix crash in VisitIfStmt

vsk updated this revision to Diff 47230. vsk added a comment. - Check that we don't crash on a nested 'STMT' test case. http://reviews.llvm.org/D16934 Files: lib/CodeGen/CoverageMappingGen.cpp test/CoverageMapping/macro-expressions.cpp Index: test/CoverageMapping/macro-expressions.cpp

r260129 - [Coverage] Fix crash when handling certain macro expansions

Author: vedantk Date: Mon Feb 8 13:25:45 2016 New Revision: 260129 URL: http://llvm.org/viewvc/llvm-project?rev=260129=rev Log: [Coverage] Fix crash when handling certain macro expansions When handling 'if' statements, we crash if the condition and the consequent branch are spanned by a single

Re: [PATCH] D16934: [Coverage] Fix crash in VisitIfStmt

This revision was automatically updated to reflect the committed changes. Closed by commit rL260129: [Coverage] Fix crash when handling certain macro expansions (authored by vedantk). Changed prior to commit: http://reviews.llvm.org/D16934?vs=47230=47232#toc Repository: rL LLVM

Re: r260124 - Remove dead code.

On Mon, Feb 8, 2016 at 11:25 AM, Vassil Vassilev wrote: > On 08/02/16 20:10, Richard Smith via cfe-commits wrote: > >> Author: rsmith >> Date: Mon Feb 8 13:10:14 2016 >> New Revision: 260124 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=260124=rev >> Log: >> Remove

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

ah, right, sorry about that - gmail didn't render cfe-commits on the to line in the first email... weird. Anyway, no need to include llvm-commits on clang-only changes. On Mon, Feb 8, 2016 at 11:30 AM, Xinliang David Li wrote: > Both cfe-commits and llvm-commits are cc'ed.

Re: [PATCH] D16552: Let clang not error out on `const std::vector empty_vec; ` with libstdc++5.3.

rsmith added a comment. In http://reviews.llvm.org/D16552#346678, @thakis wrote: > Will do, thanks! In "If the implicit default constructor initializes all > subobjects, no initializer should be required", is "initializes all > subobjects meant recursively? I think so, or more specifically,

Re: [PATCH] D16934: [Coverage] Fix crash in VisitIfStmt

vsk updated this revision to Diff 47229. vsk added a comment. - Made the check a bit more general by moving it to `propagateCounts`. - Added 3 more tests. http://reviews.llvm.org/D16934 Files: lib/CodeGen/CoverageMappingGen.cpp test/CoverageMapping/macro-expressions.cpp Index:

Re: Linux-abi group

On Mon, Feb 8, 2016 at 11:32 AM, Florian Weimer wrote: > * H. J. Lu: > >> I created a mailing list to discuss Linux specific,.processor independent >> modification and extension of generic System V Application Binary Interface: >> >> https://groups.google.com/d/forum/linux-abi

Linux-abi group

Hi, I created a mailing list to discuss Linux specific,.processor independent modification and extension of generic System V Application Binary Interface: https://groups.google.com/d/forum/linux-abi I will start to document existing Linux extensions, like STT_GNU_IFUNC. I will propose some new

Re: Linux-abi group

On Mon, Feb 8, 2016 at 11:33 AM, Szabolcs Nagy wrote: > * H.J. Lu [2016-02-08 11:24:53 -0800]: >> I created a mailing list to discuss Linux specific,.processor independent >> modification and extension of generic System V Application Binary Interface: >> >>

Re: [PATCH] D16552: Let clang not error out on `const std::vector empty_vec; ` with libstdc++5.3.

thakis added a comment. Will do, thanks! In "If the implicit default constructor initializes all subobjects, no initializer should be required", is "initializes all subobjects meant recursively? I.e. is this ok according to that language? ` struct Inner { Inner() = default; int i;

Re: Linux-abi group

On Mon, Feb 8, 2016 at 11:44 AM, Florian Weimer wrote: > * H. J. Lu: > >> On Mon, Feb 8, 2016 at 11:32 AM, Florian Weimer wrote: >>> * H. J. Lu: >>> I created a mailing list to discuss Linux specific,.processor independent modification and

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

davidxl updated this revision to Diff 47239. davidxl added a comment. Further simplify tests according to David B's comment. http://reviews.llvm.org/D16947 Files: lib/CodeGen/CGClass.cpp test/Profile/def-assignop.cpp Index: test/Profile/def-assignop.cpp

r260155 - [Concepts] Remove the IsConcept bit and associated member functions from VarDecl

Author: nwilson Date: Mon Feb 8 16:02:50 2016 New Revision: 260155 URL: http://llvm.org/viewvc/llvm-project?rev=260155=rev Log: [Concepts] Remove the IsConcept bit and associated member functions from VarDecl because the information is now stored in TemplateDecl. Modified:

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

xur updated this revision to Diff 47251. xur marked an inline comment as done. xur added a comment. fixed the typo in comments http://reviews.llvm.org/D15829 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/BackendUtil.cpp

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Mon, Feb 8, 2016 at 2:42 PM, Richard Smith wrote: > Do we really need an 'empty type' special case? > > The x86_64 psABI already seems clear that empty types with size <= 16 > are not passed at all. Following the algorithm in section 3.2.3, each > eightbyte is classified

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Mon, Feb 8, 2016 at 2:46 PM, H.J. Lu wrote: > On Mon, Feb 8, 2016 at 2:35 PM, Richard Smith wrote: >> On Mon, Feb 8, 2016 at 1:40 PM, H.J. Lu wrote: >>> >>> On Mon, Feb 8, 2016 at 12:38 PM, Richard Smith

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Mon, Feb 8, 2016 at 2:49 PM, H.J. Lu wrote: > On Mon, Feb 8, 2016 at 2:42 PM, Richard Smith wrote: >> Do we really need an 'empty type' special case? >> >> The x86_64 psABI already seems clear that empty types with size <= 16 >> are not passed at

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Mon, Feb 8, 2016 at 2:51 PM, Richard Smith wrote: > On Mon, Feb 8, 2016 at 2:46 PM, H.J. Lu wrote: >> On Mon, Feb 8, 2016 at 2:35 PM, Richard Smith wrote: >>> On Mon, Feb 8, 2016 at 1:40 PM, H.J. Lu

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Mon, Feb 8, 2016 at 2:54 PM, H.J. Lu wrote: > On Mon, Feb 8, 2016 at 2:51 PM, Richard Smith wrote: >> On Mon, Feb 8, 2016 at 2:46 PM, H.J. Lu wrote: >>> On Mon, Feb 8, 2016 at 2:35 PM, Richard Smith

Re: [PATCH] D16913: Adding doxygen comments to the LLVM intrinsics (part 4, pmmintrin.h)

This revision was automatically updated to reflect the committed changes. Closed by commit rL260160: This patch adds doxygen comments for all the intrinsincs in the header file… (authored by kromanova). Changed prior to commit: http://reviews.llvm.org/D16913?vs=46988=47250#toc Repository:

r260160 - This patch adds doxygen comments for all the intrinsincs in the header file pmmintrin.h. The doxygen comments are automatically generated based on Sony's intrinsics document.

Author: kromanova Date: Mon Feb 8 16:35:09 2016 New Revision: 260160 URL: http://llvm.org/viewvc/llvm-project?rev=260160=rev Log: This patch adds doxygen comments for all the intrinsincs in the header file pmmintrin.h. The doxygen comments are automatically generated based on Sony's intrinsics

Re: [PATCH] D16962: clang-tidy: avoid std::bind

jbcoe removed rL LLVM as the repository for this revision. jbcoe updated this revision to Diff 47247. jbcoe added a comment. Require C++14 for improved fixits. Do not attempt to generate fixits for more complicated uses of bind. http://reviews.llvm.org/D16962 Files:

r260161 - [PGO] Cover more cases of implicitly generated C++ methods

Author: davidxl Date: Mon Feb 8 16:41:37 2016 New Revision: 260161 URL: http://llvm.org/viewvc/llvm-project?rev=260161=rev Log: [PGO] Cover more cases of implicitly generated C++ methods Modified: cfe/trunk/test/Profile/cxx-implicit.cpp Modified: cfe/trunk/test/Profile/cxx-implicit.cpp

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Mon, Feb 8, 2016 at 2:35 PM, Richard Smith wrote: > On Mon, Feb 8, 2016 at 1:40 PM, H.J. Lu wrote: >> >> On Mon, Feb 8, 2016 at 12:38 PM, Richard Smith wrote: >> > On Mon, Feb 8, 2016 at 12:05 PM, H.J. Lu

Re: [PATCH] D16962: clang-tidy: avoid std::bind

jbcoe updated this revision to Diff 47259. jbcoe added a comment. Moved check to readability module. Aside: would it be worthwhile creating a python script to move checks from one module to another? http://reviews.llvm.org/D16962 Files: clang-tidy/readability/AvoidStdBindCheck.cpp

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Mon, Feb 8, 2016 at 2:58 PM, Richard Smith wrote: > On Mon, Feb 8, 2016 at 2:54 PM, H.J. Lu wrote: >> On Mon, Feb 8, 2016 at 2:51 PM, Richard Smith wrote: >>> On Mon, Feb 8, 2016 at 2:46 PM, H.J. Lu

r260159 - Make ParentMap work with explicit specializations of function templates.

Author: nico Date: Mon Feb 8 16:23:09 2016 New Revision: 260159 URL: http://llvm.org/viewvc/llvm-project?rev=260159=rev Log: Make ParentMap work with explicit specializations of function templates. For an explicit specialization, we first build a FunctionDecl, and then we call SubstDecl() on it

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Mon, Feb 8, 2016 at 1:40 PM, H.J. Lu wrote: > > On Mon, Feb 8, 2016 at 12:38 PM, Richard Smith wrote: > > On Mon, Feb 8, 2016 at 12:05 PM, H.J. Lu wrote: > >> > >> On Mon, Feb 8, 2016 at 11:33 AM, Jonathan Wakely

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

Do we really need an 'empty type' special case? The x86_64 psABI already seems clear that empty types with size <= 16 are not passed at all. Following the algorithm in section 3.2.3, each eightbyte is classified as NO_CLASS, and thus is not passed. So the proposed change would only affect the

Re: [PATCH] D16930: Improve literal operator parameter diagnostics.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks great, thanks, do you need someone to commit this for you? http://reviews.llvm.org/D16930 ___ cfe-commits mailing list

Re: r260056 - Disable failing nozlibcompress.c

Thanks! On Sun, Feb 7, 2016 at 1:00 PM, Nico Weber via cfe-commits wrote: > Author: nico > Date: Sun Feb 7 15:00:17 2016 > New Revision: 260056 > > URL: http://llvm.org/viewvc/llvm-project?rev=260056=rev > Log: > Disable failing nozlibcompress.c > > This test hasn't

Re: [PATCH] D16962: clang-tidy: avoid std::bind

alexfh added a comment. In http://reviews.llvm.org/D16962#346822, @jbcoe wrote: > Moved check to readability module. > > Aside: would it be worthwhile creating a python script to move checks from > one module to another? It's reasonable to teach the `rename_check.py` script move across

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

On Mon, Feb 8, 2016 at 4:05 PM, David Blaikie wrote: > > > On Mon, Feb 8, 2016 at 3:58 PM, Xinliang David Li > wrote: >> >> To be clear, you are suggesting breaking the test into two (one for >> copy, and one for move) ? I am totally fine with that. > > >

Re: [PATCH] D16738: Fix invalid casts in .

eugenis added a comment. In http://reviews.llvm.org/D16738#345696, @EricWF wrote: > I prefer using the `(void*)` casts when possible. In particular when doing > the pointer comparisons. Could you change those back to `void*` casts then > use the `__as_base` function for the rest? done

Re: [PATCH] D16738: Fix invalid casts in .

eugenis updated this revision to Diff 47271. Repository: rL LLVM http://reviews.llvm.org/D16738 Files: include/__config include/functional Index: include/functional === --- include/functional +++ include/functional @@

Re: [PATCH] D16930: Improve literal operator parameter diagnostics.

erik.pilkington added a comment. Yes I do, if you don't mind. Thanks for your help! http://reviews.llvm.org/D16930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

On Mon, Feb 8, 2016 at 12:07 PM, Xinliang David Li wrote: > On Mon, Feb 8, 2016 at 11:39 AM, David Blaikie wrote: > > > > > > On Mon, Feb 8, 2016 at 9:25 AM, David Li via llvm-commits > > wrote: > >> > >> davidxl updated this

Re: [PATCH] D16761: clang-cl: Support loading plugins on Windows

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D16761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: Linux-abi group

On Mon, 8 Feb 2016, H.J. Lu wrote: > >> I was referring to program properties: > >> > >> https://groups.google.com/forum/#!topic/generic-abi/fyIXttIsYc8 > > > > This looks more like an ELF topic to me, not really ABI. > > > > Please discuss this on a GNU project list because it affects the > >

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

On Mon, Feb 8, 2016 at 3:17 PM, David Blaikie wrote: > > > On Mon, Feb 8, 2016 at 12:07 PM, Xinliang David Li > wrote: >> >> On Mon, Feb 8, 2016 at 11:39 AM, David Blaikie wrote: >> > >> > >> > On Mon, Feb 8, 2016 at 9:25 AM, David Li

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

On Mon, Feb 8, 2016 at 3:21 PM, Xinliang David Li wrote: > On Mon, Feb 8, 2016 at 3:17 PM, David Blaikie wrote: > > > > > > On Mon, Feb 8, 2016 at 12:07 PM, Xinliang David Li > > wrote: > >> > >> On Mon, Feb 8, 2016 at 11:39 AM, David

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

saugustine updated this revision to Diff 47267. saugustine added a comment. - Privatize all functions but getFullyQualifiedName. http://reviews.llvm.org/D15861 Files: include/clang/Tooling/Core/QualTypeNames.h lib/Tooling/Core/CMakeLists.txt lib/Tooling/Core/QualTypeNames.cpp

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

On Mon, Feb 8, 2016 at 3:35 PM, David Blaikie wrote: > > > On Mon, Feb 8, 2016 at 3:21 PM, Xinliang David Li > wrote: >> >> On Mon, Feb 8, 2016 at 3:17 PM, David Blaikie wrote: >> > >> > >> > On Mon, Feb 8, 2016 at 12:07 PM, Xinliang

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

On Mon, Feb 8, 2016 at 3:46 PM, Xinliang David Li wrote: > On Mon, Feb 8, 2016 at 3:35 PM, David Blaikie wrote: > > > > > > On Mon, Feb 8, 2016 at 3:21 PM, Xinliang David Li > > wrote: > >> > >> On Mon, Feb 8, 2016 at 3:17 PM, David

Re: [libcxx] r260012 - Cleanup node-type handling in the unordered containers

Hey Tim, Sorry about the breakage. I've reverted the commit in r260172. I'll make sure that gnu_cxx::hash_map continues to work before recommitting. /Eric On Mon, Feb 8, 2016 at 2:23 PM, Tim Northover wrote: > Hi Eric, > > On 6 February 2016 at 16:36, Eric Fiselier

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Mon, Feb 8, 2016 at 2:55 PM, Richard Smith wrote: > On Mon, Feb 8, 2016 at 2:49 PM, H.J. Lu wrote: >> On Mon, Feb 8, 2016 at 2:42 PM, Richard Smith wrote: >>> Do we really need an 'empty type' special case? >>> >>> The x86_64

Re: r260058 - Make nozlibcompress.c pass and reenable it.

Thanks for fixing this! On Sun, Feb 7, 2016 at 1:32 PM, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: nico > Date: Sun Feb 7 15:32:17 2016 > New Revision: 260058 > > URL: http://llvm.org/viewvc/llvm-project?rev=260058=rev > Log: > Make nozlibcompress.c pass and

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Mon, Feb 8, 2016 at 3:01 PM, H.J. Lu wrote: > On Mon, Feb 8, 2016 at 2:58 PM, Richard Smith wrote: >> On Mon, Feb 8, 2016 at 2:54 PM, H.J. Lu wrote: >>> On Mon, Feb 8, 2016 at 2:51 PM, Richard Smith

[libcxx] r260172 - Revert r260012 due to __gnu_cxx::hash_map breakage

Author: ericwf Date: Mon Feb 8 17:47:13 2016 New Revision: 260172 URL: http://llvm.org/viewvc/llvm-project?rev=260172=rev Log: Revert r260012 due to __gnu_cxx::hash_map breakage Removed: libcxx/trunk/test/libcxx/containers/unord/key_value_traits.pass.cpp

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. OK, let's go ahead with this approach for now; we can investigate replacing the implementation with a `PrintingPolicy` flag later. Comment at:

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

To be clear, you are suggesting breaking the test into two (one for copy, and one for move) ? I am totally fine with that. I thought you suggested removing the testing of move/op case because they might share the same code path (clang's implementation) as the copy/op. thanks, David On Mon, Feb

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

On Mon, Feb 8, 2016 at 3:58 PM, Xinliang David Li wrote: > To be clear, you are suggesting breaking the test into two (one for > copy, and one for move) ? I am totally fine with that. Nah, no need to split the test case - we try to keep the number of test files down (&

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

On Mon, Feb 8, 2016 at 4:31 PM, Xinliang David Li wrote: > On Mon, Feb 8, 2016 at 4:05 PM, David Blaikie wrote: > > > > > > On Mon, Feb 8, 2016 at 3:58 PM, Xinliang David Li > > wrote: > >> > >> To be clear, you are suggesting

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

ha! somehow I kept thinking you are referring to implicit declared ctors. From your test case, it is seems that the implicit copy/move op is also broken and is fixed by this patch too. That means a missing test case to me. Will update the case when verified. thanks, David On Mon, Feb 8,

r260181 - Fix undefined behavior when compiling in C++14 due to sized operator delete

Author: rsmith Date: Mon Feb 8 19:05:04 2016 New Revision: 260181 URL: http://llvm.org/viewvc/llvm-project?rev=260181=rev Log: Fix undefined behavior when compiling in C++14 due to sized operator delete being called with the wrong size: convert CGFunctionInfo to use TrailingObjects and ask

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

On Mon, Feb 8, 2016 at 5:05 PM, Xinliang David Li wrote: > ha! somehow I kept thinking you are referring to implicit declared ctors. > Ah, glad we figured out the disconnect - thanks for bearing with me! > > From your test case, it is seems that the implicit copy/move op

<    1   2