r262341 - [cmake] Add a few more compiler-rt check-* targets for EXTERNAL_COMPILER_RT

2016-03-01 Thread Filipe Cabecinhas via cfe-commits
Author: filcab Date: Tue Mar 1 09:33:52 2016 New Revision: 262341 URL: http://llvm.org/viewvc/llvm-project?rev=262341=rev Log: [cmake] Add a few more compiler-rt check-* targets for EXTERNAL_COMPILER_RT Modified: cfe/trunk/runtime/CMakeLists.txt Modified: cfe/trunk/runtime/CMakeLists.txt

Re: [PATCH] D17761: Added applyAllReplacementsAndFormat that works for multiple files.

2016-03-01 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 49493. ioeric added a comment. - Added getOrCreateFileID interface in SourceManager. http://reviews.llvm.org/D17761 Files: include/clang/Basic/SourceManager.h include/clang/Format/Format.h include/clang/Tooling/Core/Replacement.h

r262340 - [cmake] Try to appease the buildbots.

2016-03-01 Thread Filipe Cabecinhas via cfe-commits
Author: filcab Date: Tue Mar 1 09:07:19 2016 New Revision: 262340 URL: http://llvm.org/viewvc/llvm-project?rev=262340=rev Log: [cmake] Try to appease the buildbots. Modified: cfe/trunk/runtime/CMakeLists.txt Modified: cfe/trunk/runtime/CMakeLists.txt URL:

Re: [PATCH] D17722: Make sure SLocEntry is an expansion before using getExpansion() method in SourceManager.

2016-03-01 Thread Benjamin Kramer via cfe-commits
bkramer added a comment. This doesn't have a test case. Also I don't understand why this is the correct fix. If someone is calling one of those method with a file SourceLocation (as opposed to a macro SourceLocation) they should stop doing that. Repository: rL LLVM

Re: SourceTypeInfo for long long

2016-03-01 Thread Alexander Kornienko via cfe-commits
Answered on the review thread. The problem is with BuiltinTypeLoc not storing the location for the end token of builtin type names consisting of multiple tokens. This can be worked around by re-lexing a fragment of the code for now. Richard, does it make sense to store the end location in

Re: SourceTypeInfo for long long

2016-03-01 Thread Piotr Padlewski via cfe-commits
my pass works for things like (note that for test purposes I use lexical_cast that doesn't do anything, so the second one compiles) int a = boost::lexical_cast("42"); long long* b = boost::lexical_cast("42"); => auto a = boost::lexical_cast("42"); auto b = boost::lexical_cast("42"); but it

[PATCH] D17764: Add attributes for AMD GPU Tools

2016-03-01 Thread Konstantin Zhuravlyov via cfe-commits
kzhuravl-AMD created this revision. kzhuravl-AMD added reviewers: arsenm, tstellarAMD. kzhuravl-AMD added a subscriber: cfe-commits. Add following kernel function attributes for AMD GPU Tools (debugger, profiler): - amdgpu_tools_insert_nops - insert two nop instructions for each high level

Re: SourceTypeInfo for long long

2016-03-01 Thread Piotr Padlewski via cfe-commits
review: http://reviews.llvm.org/D17765 2016-03-01 15:12 GMT+01:00 Piotr Padlewski : > my pass works for things like > (note that for test purposes I use lexical_cast that doesn't do anything, > so the second one compiles) > > int a = boost::lexical_cast("42"); > long

r262336 - [cmake] Pass through the cmake_3_2_USES_TERMINAL variable so we get progress bars on an external compiler-rt build

2016-03-01 Thread Filipe Cabecinhas via cfe-commits
Author: filcab Date: Tue Mar 1 08:10:38 2016 New Revision: 262336 URL: http://llvm.org/viewvc/llvm-project?rev=262336=rev Log: [cmake] Pass through the cmake_3_2_USES_TERMINAL variable so we get progress bars on an external compiler-rt build Modified: cfe/trunk/runtime/CMakeLists.txt

r262335 - [cmake] Use CMake's USES_TERMINAL for the test targets.

2016-03-01 Thread Filipe Cabecinhas via cfe-commits
Author: filcab Date: Tue Mar 1 08:08:18 2016 New Revision: 262335 URL: http://llvm.org/viewvc/llvm-project?rev=262335=rev Log: [cmake] Use CMake's USES_TERMINAL for the test targets. Modified: cfe/trunk/runtime/CMakeLists.txt Modified: cfe/trunk/runtime/CMakeLists.txt URL:

r262334 - [cmake] Fallback to LLVM_EXTERNAL_COMPILER_RT_SOURCE_DIR if COMPILER_RT_SRC_ROOT doesn't exist.

2016-03-01 Thread Filipe Cabecinhas via cfe-commits
Author: filcab Date: Tue Mar 1 08:08:13 2016 New Revision: 262334 URL: http://llvm.org/viewvc/llvm-project?rev=262334=rev Log: [cmake] Fallback to LLVM_EXTERNAL_COMPILER_RT_SOURCE_DIR if COMPILER_RT_SRC_ROOT doesn't exist. Modified: cfe/trunk/runtime/CMakeLists.txt Modified:

Re: SourceTypeInfo for long long

2016-03-01 Thread Alexander Kornienko via cfe-commits
+cfe-commits for wider audience. Hi Piotr, On Tue, Mar 1, 2016 at 2:36 PM, Piotr Padlewski wrote: > Hi Alexey, > I am currently writing new check > https://llvm.org/bugs/show_bug.cgi?id=26763 > Awesome! Sorry I didn't have time yet to comment on the issues you

[PATCH] D17761: Added applyAllReplacementsAndFormat that works for multiple files.

2016-03-01 Thread Eric Liu via cfe-commits
ioeric created this revision. ioeric added a reviewer: klimek. ioeric added subscribers: klimek, cfe-commits. Added applyAllReplacementsAndFormat that works for multiple files. http://reviews.llvm.org/D17761 Files: include/clang/Format/Format.h include/clang/Tooling/Core/Replacement.h

Re: [PATCH] D17688: Fix missed leak from MSVC specific allocation functions

2016-03-01 Thread Aaron Ballman via cfe-commits
On Tue, Mar 1, 2016 at 2:16 AM, Alexander Riccio wrote: > ariccio updated this revision to Diff 49456. > ariccio added a comment. > > Nit addressed. > > > http://reviews.llvm.org/D17688 > > Files: > llvm/tools/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp > > Index:

r262329 - FormatTests: Update libdeps corresponding to r262323.

2016-03-01 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Tue Mar 1 07:11:36 2016 New Revision: 262329 URL: http://llvm.org/viewvc/llvm-project?rev=262329=rev Log: FormatTests: Update libdeps corresponding to r262323. Modified: cfe/trunk/unittests/Format/CMakeLists.txt Modified: cfe/trunk/unittests/Format/CMakeLists.txt URL:

r262325 - Fix test breakage on windows where the default std is c++11 by forcing c++03 in the test.

2016-03-01 Thread Manuel Klimek via cfe-commits
Author: klimek Date: Tue Mar 1 06:53:18 2016 New Revision: 262325 URL: http://llvm.org/viewvc/llvm-project?rev=262325=rev Log: Fix test breakage on windows where the default std is c++11 by forcing c++03 in the test. Modified: cfe/trunk/test/Index/keep-going.cpp Modified:

r262326 - [CLANG][AVX512][BUILTIN] Adding PSRLV builtin

2016-03-01 Thread Michael Zuckerman via cfe-commits
Author: mzuckerm Date: Tue Mar 1 07:03:45 2016 New Revision: 262326 URL: http://llvm.org/viewvc/llvm-project?rev=262326=rev Log: [CLANG][AVX512][BUILTIN] Adding PSRLV builtin Differential Revision: http://reviews.llvm.org/D17718 Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def

r262324 - Fix DLL build by adding required dependency.

2016-03-01 Thread Manuel Klimek via cfe-commits
Author: klimek Date: Tue Mar 1 06:47:30 2016 New Revision: 262324 URL: http://llvm.org/viewvc/llvm-project?rev=262324=rev Log: Fix DLL build by adding required dependency. Modified: cfe/trunk/unittests/Format/CMakeLists.txt Modified: cfe/trunk/unittests/Format/CMakeLists.txt URL:

r262323 - Add functions to apply replacements and reformat them.

2016-03-01 Thread Manuel Klimek via cfe-commits
Author: klimek Date: Tue Mar 1 06:37:30 2016 New Revision: 262323 URL: http://llvm.org/viewvc/llvm-project?rev=262323=rev Log: Add functions to apply replacements and reformat them. This is a commonly useful feature to have, and we have implemented it multiple times with different kinds of

Re: [PATCH] D17727: Moved applyAllReplacementsAndFormat to clangFormat to avoid cyclic dependency.

2016-03-01 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D17727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r262321 - [CLANG] [AVX512] [BUILTIN] Adding PSRA{Q|D|QI|DI}{128|256|512} builtin

2016-03-01 Thread Michael Zuckerman via cfe-commits
Author: mzuckerm Date: Tue Mar 1 05:38:16 2016 New Revision: 262321 URL: http://llvm.org/viewvc/llvm-project?rev=262321=rev Log: [CLANG] [AVX512] [BUILTIN] Adding PSRA{Q|D|QI|DI}{128|256|512} builtin Differential Revision: http://reviews.llvm.org/D17693 Modified:

Re: [PATCH] D17727: Moved applyAllReplacementsAndFormat to clangFormat to avoid cyclic dependency.

2016-03-01 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 49470. ioeric marked 5 inline comments as done. ioeric added a comment. - Fixed commenting. http://reviews.llvm.org/D17727 Files: include/clang/Format/Format.h include/clang/Tooling/Core/Replacement.h lib/Format/Format.cpp

r262318 - Optionally demote fatal errors to non-fatal errors.

2016-03-01 Thread Manuel Klimek via cfe-commits
Author: klimek Date: Tue Mar 1 04:56:19 2016 New Revision: 262318 URL: http://llvm.org/viewvc/llvm-project?rev=262318=rev Log: Optionally demote fatal errors to non-fatal errors. This behavior is enabled when the new CXTranslationUnit_KeepGoing option is passed to

Re: [PATCH] D15283: [ARMv8-M] Add Clang targeting for ARMv8-M Baseline/Mainline

2016-03-01 Thread Bradley Smith via cfe-commits
bsmith added a comment. Ping. This change has been waiting for review for over a month now, it would be great to get this committed. Thanks. Repository: rL LLVM http://reviews.llvm.org/D15283 ___ cfe-commits mailing list

Re: [PATCH] D17756: [clang-tidy] Make 'modernize-pass-by-value' fix work on header files.

2016-03-01 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks! Comment at: test/clang-tidy/modernize-pass-by-value-header.cpp:1 @@ +1,2 @@ +// RUN: cp %S/Inputs/modernize-pass-by-value/header.h %T/pass-by-value-header.h +//

Re: [PATCH] D17727: Moved applyAllReplacementsAndFormat to clangFormat to avoid cyclic dependency.

2016-03-01 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: include/clang/Format/Format.h:734-736 @@ -733,1 +733,5 @@ +/// \brief Return replacements that are merged from orginal replacements +/// and the replacements for formatting the code after applying the orginal +/// replacements.

Re: [PATCH] D17550: Adding doxygen comments to the LLVM intrinsics (part 6, popcntintrin.h)

2016-03-01 Thread Dmitri Gribenko via cfe-commits
On Mon, Feb 29, 2016 at 10:59 AM, Romanova, Katya wrote: > Hi Dmitri, > > Could you please let us know your opinion about C++ vs C-style doxygen > comments. Read this thread for ‘pro’ and ‘con’ arguments about using C++ > headers. Will LLVM online

<    1   2