Re: [PATCH] D17950: Implement is_always_lock_free

bcraig added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:305 @@ +304,3 @@ +if (TypeWidth == TypeAlign && (TypeWidth & (TypeWidth - 1)) == 0 && +TypeWidth <= InlineWidth) + return Always; jyknight wrote: > jfb wrote: > > bcraig

Re: [PATCH] D17865: Add an optional string argument to DeprecatedAttr for Fix-It.

This revision was automatically updated to reflect the committed changes. Closed by commit rL263652: Add an optional string argument to DeprecatedAttr for Fix-It. (authored by mren). Changed prior to commit: http://reviews.llvm.org/D17865?vs=50682=50844#toc Repository: rL LLVM

r263636 - Revert r263617, "Reapply: [VFS] Add support for handling path traversals"

Author: chapuni Date: Wed Mar 16 07:15:29 2016 New Revision: 263636 URL: http://llvm.org/viewvc/llvm-project?rev=263636=rev Log: Revert r263617, "Reapply: [VFS] Add support for handling path traversals" It broke standalone clang build. Removed:

[PATCH] D18293: [clang-tidy] Fix redundant-string-init check with msvc 14 headers.

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. The string constructors are not defined using optional parameters and are not recognized by the redundant-string-init checker. The following patch fixes the redundant-string-init checker

Re: [PATCH] D16529: [clang-tidy] Add modernize-raw-string-literal check

LegalizeAdulthood updated this revision to Diff 51105. LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added a comment. Update from comments. Update documentation to reflect changes in the implementation. I do not have commit access. Patch by Richard Thomson

Re: [PATCH] D17482: [clang-tidy] Allow tests to verify changes made to header files

LegalizeAdulthood added a comment. In http://reviews.llvm.org/D17482#372677, @alexfh wrote: > Sorry for leaving this without attention for a while. > > I'm somewhat concerned about this change. It's adding a certain level of > complexity, but doesn't cover some less trivial cases like handling

Re: [PATCH] D18205: [libcxxabi] Disable cxa_thread_atexit_test if unavailable

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after the inline question is addressed. Comment at: test/libcxxabi/test/config.py:38 @@ +37,3 @@ +super(Configuration, self).configure_features() +if

Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

No, that case worked already. The case you fixed is the one where Base is 'foo' and Property is 'prop'…and actually, thinking more about it, this should not be considered "exact". *sigh* The point of "exact" is "if you see this Base and Property again, are you sure it's really the same Base?".

Re: [PATCH] D18199: CodeGen: Implement IR generation for the relative vtable ABI (PR26723).

pcc updated this revision to Diff 50998. pcc added a comment. - Update test to match committed debug info change http://reviews.llvm.org/D18199 Files: docs/UsersManual.rst lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGVTables.cpp lib/CodeGen/CGVTables.h lib/CodeGen/CodeGenFunction.h

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8380 @@ +8379,3 @@ +def warn_unused_abi_stability_attr : Warning< + "unused C++ ABI stability attribute on non-dynamic class">, + InGroup>;

Re: [PATCH] D17950: Implement is_always_lock_free

jfb added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:305 @@ +304,3 @@ +if (TypeWidth == TypeAlign && (TypeWidth & (TypeWidth - 1)) == 0 && +TypeWidth <= InlineWidth) + return Always; bcraig wrote: > jyknight wrote: > > jfb

r263687 - Add an optional named argument (replacement = "xxx") to AvailabilityAttr.

Author: mren Date: Wed Mar 16 22:09:55 2016 New Revision: 263687 URL: http://llvm.org/viewvc/llvm-project?rev=263687=rev Log: Add an optional named argument (replacement = "xxx") to AvailabilityAttr. This commit adds a named argument to AvailabilityAttr, while r263652 adds an optional string

r263752 - Revert r263687 for ubsan bot failure.

Author: mren Date: Thu Mar 17 17:13:50 2016 New Revision: 263752 URL: http://llvm.org/viewvc/llvm-project?rev=263752=rev Log: Revert r263687 for ubsan bot failure. Modified: cfe/trunk/include/clang/Basic/Attr.td cfe/trunk/include/clang/Basic/AttrDocs.td

Re: [PATCH] D18280: [tsan] Allow -fsanitize=thread for iOS-style simulator targets

dcoughlin updated this revision to Diff 51076. dcoughlin added a comment. Added tests for iOS and iOS simulators. http://reviews.llvm.org/D18280 Files: lib/Driver/ToolChains.cpp test/Driver/fsanitize.c Index: test/Driver/fsanitize.c

[PATCH] D18240: Asm preprocessor fix for unknown hash-lines

andrew.zhogin created this revision. andrew.zhogin added reviewers: jordan_rose, bkramer. andrew.zhogin added a subscriber: cfe-commits. When preprocessing assembly file (with "clang -cc1 -E -x assembler-with-cpp") after every unknown-pragma line, additional empty line is added. # some comment 1

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

dexonsmith updated this revision to Diff 50869. dexonsmith added a comment. Eric and I had a quick chat on IRC. - The asymmetric usage of __extract_key and __can_extract_key was awkward, as Eric pointed out already. - However, a symmetric __extract_key would have caused Clang (and other

Re: r263785 - Make LookupResult movable again.

Also might be marginally tidier if Paths was a unique_ptr, then you wouldn't have to explicitly null it out. I think this is still a pretty subtle thing to allow move or copy support for & perhaps best avoided, or split into the query parameters and the result if we're going to support it. For

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

On Wed, Mar 16, 2016 at 10:19 AM, don hinton wrote: > The current behavior, albeit deprecated, is to implicitly define these. > Therefore, it would be incorrect not to delete them if the implicit > versions don't do the right thing. > > I'd be happy to add a FIXME, but I

Re: [PATCH] D18191: [clang-tidy] Add check for function parameters that are const& to builtin types

LegalizeAdulthood added inline comments. Comment at: test/clang-tidy/misc-const-ref-builtin.cpp:32-34 @@ +31,4 @@ + +void f(const int& i, const int& j); +// CHECK-MESSAGES: :[[@LINE-1]]:19: warning: const reference to 'int' at parameter 'i' in function 'f'

Re: [PATCH] D17950: Implement is_always_lock_free

jfb updated this revision to Diff 51048. jfb added a comment. - Use __atomic_always_lock_free instead http://reviews.llvm.org/D17950 Files: lib/Frontend/InitPreprocessor.cpp test/Lexer/cxx-features.cpp Index: test/Lexer/cxx-features.cpp

Re: [PATCH] D17951: Implement is_always_lock_free

jfb added inline comments. Comment at: include/atomic:859 @@ +858,3 @@ +template <> _LIBCPP_CONSTEXPR bool __libcpp_always_lock_free = 2 == ATOMIC_CHAR32_T_LOCK_FREE; +template <> _LIBCPP_CONSTEXPR bool __libcpp_always_lock_free = 2 == ATOMIC_WCHAR_T_LOCK_FREE; +template <>

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

chapuni added a subscriber: chapuni. chapuni added a comment. Excuse me, I have reverted it in r263636. Comment at: lib/Frontend/ModuleDependencyCollector.cpp:65 @@ +64,3 @@ +static bool real_path(StringRef SrcPath, SmallVectorImpl ) { +#ifdef HAVE_REALPATH + char

Re: [PATCH] D18163: Add visualizers for more clang types. Create more C++-like visualizations for existing Clang types

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D18163#376358, @mspertus wrote: > Added reference types and a more accurate AttributedType enum. I am working > on additional items for the future

Re: [PATCH] D18274: [clang-tidy] Add boost module

Prazek updated this revision to Diff 51086. http://reviews.llvm.org/D18274 Files: clang-tidy/CMakeLists.txt clang-tidy/boost/BoostTidyModule.cpp clang-tidy/boost/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/tool/CMakeLists.txt clang-tidy/tool/ClangTidyMain.cpp

Re: r263687 - Add an optional named argument (replacement = "xxx") to AvailabilityAttr.

This change is causing ubsan bot to complain . Please fix or revert. Most likely the guilty part is this: +*getReplacementSlot() = replacementExpr;

r263686 - Reapply [2]: [VFS] Add support for handling path traversals

Author: bruno Date: Wed Mar 16 21:20:43 2016 New Revision: 263686 URL: http://llvm.org/viewvc/llvm-project?rev=263686=rev Log: Reapply [2]: [VFS] Add support for handling path traversals This was applied twice r261551 and 263617 and later reverted because: (1) Windows bot failing on unittests.

Re: [PATCH] D18203: [OPENMP] Implementation of codegen for firstprivate clause of target directive

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM http://reviews.llvm.org/D18203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13704: [Fix] Allow implicit conversions of the address of overloadable functions in C + docs update

rsmith added inline comments. Comment at: lib/Sema/SemaOverload.cpp:10419 @@ -10418,3 +10429,1 @@ - ResultTy) || - (!S.getLangOpts().CPlusPlus && TargetType->isVoidPointerType())) { Matches.push_back(std::make_pair(

[PATCH] D18262: [clang-tidy] Skip reporting of not applicable fixes.

etienneb created this revision. etienneb added reviewers: rnk, emso, alexfh, bkramer. etienneb added a subscriber: cfe-commits. Invalid source location are causing clang-tidy to crash when manipulating an invalid file. Macro definitions on the command line have locations in a virtual buffer and

[PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: alexfh, hokein. baloghadamsoftware added subscribers: cfe-commits, xazax.hun. Finds return statements in assign operator bodies where the return value is different from '*this'. Only assignment operators with correct

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r263709 - clang-format: Slightly weaken AlignAfterOpenBracket=AlwaysBreak.

Author: djasper Date: Thu Mar 17 07:00:22 2016 New Revision: 263709 URL: http://llvm.org/viewvc/llvm-project?rev=263709=rev Log: clang-format: Slightly weaken AlignAfterOpenBracket=AlwaysBreak. If a call takes a single argument, using AlwaysBreak can lead to lots of wasted lines and additional

Re: [PATCH] D17840: [OPENMP] Private, firstprivate, and lastprivate clauses for distribute, host code generation

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM http://reviews.llvm.org/D17840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r263732 - Remove defaulted move ops, the type is zero-cost copyable anyway, so there's no need for specific move ops

btw, in each case, the derived class's move ctor was called. On Thu, Mar 17, 2016 at 5:36 PM, don hinton wrote: > I just did some tests, and when a derived class is explicitly moved, e.g., > with std::move(), the current behavior is (clang++/g++/vc++): > > 1) if base has

Re: [PATCH] D17451: PR26448: [Sema] Fix determined type of ternary operator acting on two xvalue class types

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: lib/Sema/SemaExprCXX.cpp:4698 @@ +4697,3 @@ + // constraint that in the conversion the reference must bind directly to + // E1. + //

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

steven_wu added a comment. Hi Richard Thanks for looking at the patch! Replies are inlined with the feedback. Steven Comment at: include/clang/Frontend/CodeGenOptions.def:57 @@ -56,1 +56,3 @@ +CODEGENOPT(EmbedBitcode , 1, 0) ///< Embed LLVM IR bitcode as data.

Re: [PATCH] D17552: Pass -backend-option to LLVM when there is no target machine

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D17552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

On Wed, Mar 16, 2016 at 10:52 AM, don hinton wrote: > -Werror clean is great. > > If you could add -Wdeprecated, then we wouldn't need to delete them -- the > warning is only issued with -Wdeprecated is passed. > Right, that's what I'm saying - add a fixme so that once we

Re: [PATCH] D18196: [CodeGen] Emit lifetime.end intrinsic after destructor call in landing pad

rnk added a comment. In http://reviews.llvm.org/D18196#375997, @rjmccall wrote: > You should talk to Reid or someone else involved in MSVC-style EH support to > ensure that they generate a reasonable code pattern for this. I patched this in and verified it works. Clang makes a separate

r263652 - Add an optional string argument to DeprecatedAttr for Fix-It.

Author: mren Date: Wed Mar 16 13:50:49 2016 New Revision: 263652 URL: http://llvm.org/viewvc/llvm-project?rev=263652=rev Log: Add an optional string argument to DeprecatedAttr for Fix-It. We only add this to __attribute__((deprecated)). Differential Revision: http://reviews.llvm.org/D17865

Re: [PATCH] D18196: [CodeGen] Emit lifetime.end intrinsic after destructor call in landing pad

rnk added a comment. In http://reviews.llvm.org/D18196#376837, @ahatanak wrote: > I can add another RUN line to test/CodeGenCXX/microsoft-abi-eh-cleanups.cpp > that is identical to the existing RUN line except that it has "-O3 > -disable-llvm-optzns". I confirmed that the test still passes

[PATCH] D18238: [clang-tidy] Fix clang-tidy crashes when using -fdelayed-template-parsing.

etienneb created this revision. etienneb added reviewers: rnk, alexfh, emso, bkramer. etienneb added a subscriber: cfe-commits. Herald added a subscriber: aemerson. Fix crashes caused by deferencing null pointer when declarations parsing may be delayed. The body of the declarations may be null.

Re: [PATCH] D17950: Implement is_always_lock_free

jyknight added a subscriber: jyknight. jyknight added a comment. This conflicts with http://reviews.llvm.org/D17933. Most of this change also seems unnecessary. - I think the `is_always_lock_free` function should be defined based on the existing `__atomic_always_lock_free` builtin, not on

Re: r263785 - Make LookupResult movable again.

On Fri, Mar 18, 2016 at 5:10 PM, David Blaikie wrote: > > > On Fri, Mar 18, 2016 at 6:31 AM, Benjamin Kramer via cfe-commits > wrote: >> >> Author: d0k >> Date: Fri Mar 18 08:31:00 2016 >> New Revision: 263785 >> >> URL:

RE: r259776 - [OPENMP 4.0] Fixed support of array sections/array subscripts.

Hi Alexey, I think this now also affects the released version of Clang 3.8.0. Can this be merged for 3.8.1 if such a version will exist somewhen? Thanks, Jonas > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of Alexey Bataev via

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

rsmith added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:272-299 @@ -265,1 +271,30 @@ + // abi_tag is a gcc attribute, taking one or more strings called "tags". + // + // The goal is to annotate against which version of a library an object was + // build and to

Re: [PATCH] D17950: Implement is_always_lock_free

I know that MIPS does that, and an out-of-tree implementation of hexagon implements 1-byte cmpxchg in terms of the 4-byte version. The emulation code isn't particularly small, and it seems reasonable to make it a libcall. The emulation code seems sketchy from a correctness perspective, as you

Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rL263818: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo. (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D18268?vs=51025=51056#toc Repository: rL LLVM

Re: [PATCH] D16579: Warn if friend function depends on template parameters.

I'm not qualified to comment on the implementation, but I'm a bit skeptical that this warning is appropriate in the first place. I've often declared friend non-template functions, e.g. swap(). I've never intended to declare a friend *template specialization*. Is declaring friend template

Re: [PATCH] D18149: Add check for unneeded copies of locals

fowles updated this revision to Diff 50927. http://reviews.llvm.org/D18149 Files: clang-tidy/performance/UnnecessaryCopyInitialization.cpp clang-tidy/performance/UnnecessaryCopyInitialization.h docs/clang-tidy/checks/performance-unnecessary-copy-initialization.rst

Re: [PATCH] D16965: Fix for Bug 14644 - clang confuses scope operator for global namespace giving extra qualification on member

dblaikie added a comment. Not sure I fully understand the issue with the existing diagnostic/change in wording. '::' is a nested name specifier, even if it's a degenerate case, I think - so the old wording doesn't seem wrong, as such (& the new text seems correct in the other cases too -

Re: [PATCH] D17951: Implement is_always_lock_free

jfb added inline comments. Comment at: include/atomic:859 @@ +858,3 @@ +template <> _LIBCPP_CONSTEXPR bool __libcpp_always_lock_free = 2 == ATOMIC_CHAR32_T_LOCK_FREE; +template <> _LIBCPP_CONSTEXPR bool __libcpp_always_lock_free = 2 == ATOMIC_WCHAR_T_LOCK_FREE; +template <>

Re: [PATCH] D18136: boost-use-to-string check

LegalizeAdulthood added inline comments. Comment at: clang-tidy/boost/UseToStringCheck.cpp:56 @@ +55,3 @@ + const auto *MatchedToString = Result.Nodes.getNodeAs("to_string"); + auto Q = Result.Nodes.getNodeAs("char_type")->getAsType(); + Q seems pretty obtuse

Re: [PATCH] D18136: boost-use-to-string check

Prazek marked 12 inline comments as done. Prazek added a comment. http://reviews.llvm.org/D18136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18205: [libcxxabi] Disable cxa_thread_atexit_test if unavailable

Hahnfeld added inline comments. Comment at: test/libcxxabi/test/config.py:38 @@ +37,3 @@ +super(Configuration, self).configure_features() +if self.get_lit_bool('thread_atexit', False): +self.config.available_features.add('thread_atexit')

Re: [PATCH] D18261: Show members of DeclContexts (i.e., class members) in Visual Studio native visualizers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang.natvis:77 @@ +76,3 @@ + + + mspertus wrote: > aaron.ballman wrote: > > The only hard-wiring I see uses 3 bits, so

Re: [PATCH] D18136: boost-use-to-string check

Prazek added inline comments. Comment at: test/clang-tidy/boost-use-to-string.cpp:5-11 @@ +4,9 @@ +namespace std { + +template class basic_string {}; + +using string = basic_string; +using wstring = basic_string; +} + +namespace boost { I don't see any test

Re: [PATCH] D17865: Add an optional string argument to DeprecatedAttr for Fix-It.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. One small documentation nit, but I'm fine with you fixing it then committing (no need for another round of review). Thanks! Comment at:

Re: [PATCH] D11797: [LIbClang] Report the named type for ElaboratedType

skalinichev updated this revision to Diff 51109. skalinichev added a comment. Looking a bit more at the recent commits in libclang, it seems like all recently added functions follow this naming convention: clang_Cursor_* clang_Type_* e.t.c. So I'm renaming the function to follow that style

r263647 - Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

Author: swiftix Date: Wed Mar 16 13:00:46 2016 New Revision: 263647 URL: http://llvm.org/viewvc/llvm-project?rev=263647=rev Log: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end Till now, preserve_mostcc/preserve_allcc calling convention attributes

Re: [PATCH] D13704: [Fix] Allow implicit conversions of the address of overloadable functions in C + docs update

george.burgess.iv added inline comments. Comment at: lib/Sema/SemaOverload.cpp:10419 @@ -10418,3 +10429,1 @@ - ResultTy) || - (!S.getLangOpts().CPlusPlus && TargetType->isVoidPointerType())) { Matches.push_back(std::make_pair(

Re: [PATCH] D14905: [constexpr-lambda] Support parsing of constexpr specifier (and its inference) on lambda expressions

rsmith added inline comments. Comment at: lib/AST/ExprConstant.cpp:2050 @@ +2049,3 @@ +if (!Result && isLambdaCallOperator(Frame->Callee) && +VD->getDeclContext() != Frame->Callee) { + // Assume variables referenced within a lambda's call operator that were

Re: [PATCH] D18253: Switch AMDGPU Linker to amdphdrs + update test

tstellarAMD accepted this revision. tstellarAMD added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D18253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17407: [Sema] PR25755 Fix crash when initializing out-of-order struct references

rsmith added inline comments. Comment at: lib/Sema/SemaInit.cpp:1815-1816 @@ -1814,1 +1814,4 @@ // worthwhile to skip over the rest of the initializer, though. + unsigned FieldIdx = 0; + unsigned MaxFieldIdx = 0; + llvm::BitVector SeenFields; You don't need

Re: [PATCH] D17764: Add attributes for AMD GPU Tools

kzhuravl-AMD abandoned this revision. kzhuravl-AMD added a comment. After recent discussions we decided to use target specific options instead http://reviews.llvm.org/D17764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17986: [ASTMatchers] New matcher hasReturnValue added

sbenza added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:4848 @@ +4847,3 @@ +/// \code +/// return a+b; +/// \endcode `a + b` (with spaces) A few in this comment, and one in the test. Comment at:

Re: [PATCH] D17950: Implement is_always_lock_free

jfb added a comment. In http://reviews.llvm.org/D17950#377386, @cfe-commits wrote: > I know that MIPS does that, and an out-of-tree implementation of hexagon > implements 1-byte cmpxchg in terms of the 4-byte version. The emulation > code isn't particularly small, and it seems reasonable to

Re: [PATCH] D17951: Implement is_always_lock_free

jfb added inline comments. Comment at: include/atomic:900 @@ +899,3 @@ +# if defined(_LIBCPP_LOCK_FREE_IS_SIZE_BASED) + static _LIBCPP_CONSTEXPR bool is_always_lock_free = __libcpp_always_lock_free; +# else Actually, this should be based on

[libcxx] r263688 - Make std::addressof constexpr in C++17 (Clang only).

Author: ericwf Date: Wed Mar 16 22:30:56 2016 New Revision: 263688 URL: http://llvm.org/viewvc/llvm-project?rev=263688=rev Log: Make std::addressof constexpr in C++17 (Clang only). Added:

Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

Thanks Jordan. I’ve committed the patch in r263818. I didn’t understand your comment on WeakObjectProfileTy’s table (I’m assuming you are talking about the table in ScopeInfo.h:183). It looks like the entry MyClass.prop in the table already covers the case this patch fixed (in the test case I

Re: [PATCH] D15469: Expose cxx constructor and method properties through libclang and python bindings.

skalinichev added a comment. I see. There were some changes recently in the indexing functionality. I'm not sure whether this change is intended or not, but since it's not your fault and we already have a lot of tests confirming that clang_CXXMethod_isDeleted is working as expected (e.g.

r263732 - Remove defaulted move ops, the type is zero-cost copyable anyway, so there's no need for specific move ops

Author: dblaikie Date: Thu Mar 17 13:28:16 2016 New Revision: 263732 URL: http://llvm.org/viewvc/llvm-project?rev=263732=rev Log: Remove defaulted move ops, the type is zero-cost copyable anyway, so there's no need for specific move ops (addresses MSVC build error, since MSVC 2013 can't

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

hintonda updated this revision to Diff 50843. hintonda added a comment. Added FIXME comment, and reformated with clang-format. http://reviews.llvm.org/D18123 Files: include/clang/AST/UnresolvedSet.h include/clang/Sema/Lookup.h Index: include/clang/Sema/Lookup.h

[PATCH] D18294: clang-format: [JS] no space in union and intersection types.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. | and & in types, as opposed to the bitwise operators, should not have whitespace around them (e.g. `Foo`). http://reviews.llvm.org/D18294

Re: [PATCH] D17951: Implement is_always_lock_free

jfb added a comment. In http://reviews.llvm.org/D17951#376546, @bcraig wrote: > Visual Studio has a flag, /Zc:wchar_t-, that turns wchar_t into a short. > This flag is for people that need to maintain ABI compatibility with ancient > Visual Studios (MSVC6? MSVC5?). It is definitely

r263738 - For MS ABI, emit dllexport friend functions defined inline in class

Author: rnk Date: Thu Mar 17 14:52:20 2016 New Revision: 263738 URL: http://llvm.org/viewvc/llvm-project?rev=263738=rev Log: For MS ABI, emit dllexport friend functions defined inline in class Summary: ...as that is apparently what MSVC does Reviewers: rnk Patch by Stephan Bergmann

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

On Wed, Mar 16, 2016 at 1:31 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > > > On 2016-Mar-16, at 12:20, Eric Fiselier wrote: > > > > EricWF added a comment. > > > > Adding inline comments for the implementation. Comments on the tests to > follow shortly. > > > > > >

r263794 - Show members of DeclContexts (i.e., class members) in Visual Studio native visualizers

Author: mps Date: Fri Mar 18 11:38:34 2016 New Revision: 263794 URL: http://llvm.org/viewvc/llvm-project?rev=263794=rev Log: Show members of DeclContexts (i.e., class members) in Visual Studio native visualizers This change shows members of DeclContext objects in the Visual Studio debugger. It

r263748 - Reapply [VFS] Add 'overlay-relative' field to YAML files

Author: bruno Date: Thu Mar 17 16:11:23 2016 New Revision: 263748 URL: http://llvm.org/viewvc/llvm-project?rev=263748=rev Log: Reapply [VFS] Add 'overlay-relative' field to YAML files This reapplies r261552. The VFS overlay mapping between virtual paths and real paths is done through the

Re: [PATCH] D18191: [clang-tidy] Add check for function parameters that are const& to builtin types

sdowney updated this revision to Diff 51000. sdowney added a comment. Add tests for FixIts http://reviews.llvm.org/D18191 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/ConstRefBuiltinCheck.cpp clang-tidy/misc/ConstRefBuiltinCheck.h clang-tidy/misc/MiscTidyModule.cpp

Re: [PATCH] D16579: Warn if friend function depends on template parameters.

Ping. Thanks, --Serge 2016-02-26 12:20 GMT+06:00 Serge Pavlov : > Could someone provide a feedback? > > Thanks, > --Serge > > 2016-01-26 20:55 GMT+06:00 Serge Pavlov : > >> sepavloff created this revision. >> sepavloff added a subscriber: cfe-commits.

Re: [PATCH] D17950: Implement is_always_lock_free

bcraig added a subscriber: bcraig. Comment at: lib/Frontend/InitPreprocessor.cpp:305 @@ +304,3 @@ +if (TypeWidth == TypeAlign && (TypeWidth & (TypeWidth - 1)) == 0 && +TypeWidth <= InlineWidth) + return Always; On some targets (like Hexagon),

Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

On Fri, Mar 18, 2016 at 11:08 AM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > rnk added a comment. > > I'm not sure your example is in scope for -Wshadow, though. Any function > call that takes a non-const reference to the parameter could modify it. Sure - my argument

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

Great! I think we should proceed with your is_trivially_copyable idea and I'll see if I can come up with a pathological test case that breaks it. Hopefully we can find something that works. On Mar 17, 2016 2:54 PM, "Duncan P. N. Exon Smith via cfe-commits" < cfe-commits@lists.llvm.org> wrote: >

[libcxx] r263659 - Add __unconstref for future use

Author: ericwf Date: Wed Mar 16 15:32:07 2016 New Revision: 263659 URL: http://llvm.org/viewvc/llvm-project?rev=263659=rev Log: Add __unconstref for future use Modified: libcxx/trunk/include/type_traits Modified: libcxx/trunk/include/type_traits URL:

r263740 - Revert "For MS ABI, emit dllexport friend functions defined inline in class"

Author: rnk Date: Thu Mar 17 15:06:58 2016 New Revision: 263740 URL: http://llvm.org/viewvc/llvm-project?rev=263740=rev Log: Revert "For MS ABI, emit dllexport friend functions defined inline in class" This reverts commit r263738. This appears to cause a failure in

Re: [PATCH] D16965: Fix for Bug 14644 - clang confuses scope operator for global namespace giving extra qualification on member

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: rsmith. Comment at: lib/Sema/SemaDecl.cpp:3803 @@ +3802,3 @@ + +// Per C++ standard [n3485] 3.4.4 Elaborated type specifiers, section 3: +// "Cannot introduce an qualified".

Re: [PATCH] D17180: Fix failing python bindings test

skalinichev added a comment. It reminded me http://reviews.llvm.org/D17278 So it seems like it should be already fixed, no? Repository: rL LLVM http://reviews.llvm.org/D17180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18149: Add check for unneeded copies of locals

fowles updated this revision to Diff 50878. http://reviews.llvm.org/D18149 Files: clang-tidy/performance/UnnecessaryCopyInitialization.cpp clang-tidy/performance/UnnecessaryCopyInitialization.h docs/clang-tidy/checks/performance-unnecessary-copy-initialization.rst

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

rjmccall added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:4935-4943 @@ +4934,11 @@ + + bool HasStableAttr = Record->hasAttr(); + bool HasUnstableAttr = Record->hasAttr(); + if (HasStableAttr && HasUnstableAttr) { +Diag(Record->getLocation(),

Re: [PATCH] D18199: CodeGen: Implement IR generation for the relative vtable ABI (PR26723).

rnk added inline comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:1627 @@ +1626,3 @@ + +llvm::Value *CodeGenFunction::GetVirtualFunctionFromVTable(const CXXRecordDecl *RD, + llvm::Value *VTable, Maybe

Re: [PATCH] D15591: [Bugfix] Make type deduction work more nicely with unaddressable functions

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D15591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18238: [clang-tidy] Fix clang-tidy crashes when using -fdelayed-template-parsing.

LegalizeAdulthood added a subscriber: LegalizeAdulthood. LegalizeAdulthood added a comment. LGTM http://reviews.llvm.org/D18238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18262: [clang-tidy] Skip reporting of not applicable fixes.

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a comment. Thank you for working on this! A question below, but also, the patch is missing test cases for the change. Comment at: ClangTidy.cpp:144 @@ -138,1 +143,3 @@ + +Diag <<

Re: [PATCH] D18238: [clang-tidy] Fix clang-tidy crashes when using -fdelayed-template-parsing.

rnk accepted this revision. rnk added a comment. lgtm, thanks! http://reviews.llvm.org/D18238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18025: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

This revision was automatically updated to reflect the committed changes. Closed by commit rL263647: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the… (authored by swiftix). Changed prior to commit: http://reviews.llvm.org/D18025?vs=50508=50838#toc Repository: rL

Re: [PATCH] D18139: [Cxx1z] Implement Lambda Capture of *this by Value as [=, *this] (P0018R3)

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: include/clang/AST/LambdaCapture.h:48 @@ +47,3 @@ + // by value or reference. + // - or, points to the VLASentinel if this represents a by VLA

r263634 - [modules] Fix adding a templated friend functions to a namespace from another module.

Author: vvassilev Date: Wed Mar 16 06:17:04 2016 New Revision: 263634 URL: http://llvm.org/viewvc/llvm-project?rev=263634=rev Log: [modules] Fix adding a templated friend functions to a namespace from another module. When clang adds argument dependent lookup candidates, it can perform template

Re: [PATCH] D17986: [ASTMatchers] New matcher hasReturnValue added

baloghadamsoftware retitled this revision from "[ASTMatchers] Existing matcher hasAnyArgument fixed and new matcher hasReturnValue added" to "[ASTMatchers] New matcher hasReturnValue added". baloghadamsoftware updated the summary for this revision. baloghadamsoftware updated this revision to

Re: [PATCH] D18199: CodeGen: Implement IR generation for the relative vtable ABI (PR26723).

pcc added a comment. There's a correctness issue with this change that I'll need to resolve before this goes in; see http://lists.llvm.org/pipermail/cfe-dev/2016-March/048025.html http://reviews.llvm.org/D18199 ___ cfe-commits mailing list

  1   2   3   >