Re: [PATCH] D19648: [include-fixer] Add Yaml database integration.

This revision was automatically updated to reflect the committed changes. Closed by commit rL268017: [include-fixer] Add Yaml database integration. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D19648?vs=55412=3#toc Repository: rL LLVM

[clang-tools-extra] r268017 - [include-fixer] Add Yaml database integration.

Author: hokein Date: Fri Apr 29 04:23:38 2016 New Revision: 268017 URL: http://llvm.org/viewvc/llvm-project?rev=268017=rev Log: [include-fixer] Add Yaml database integration. Reviewers: bkramer Subscribers: cfe-commits, klimek, djasper Differential Revision: http://reviews.llvm.org/D19648

[libcxx] r268009 - Fix PR21428 for long. Buffer was one byte too small in octal formatting case. Rename previously added test

Author: ericwf Date: Fri Apr 29 02:23:20 2016 New Revision: 268009 URL: http://llvm.org/viewvc/llvm-project?rev=268009=rev Log: Fix PR21428 for long. Buffer was one byte too small in octal formatting case. Rename previously added test Added:

r268013 - [Clang][AVX512][Builtin] Adding intrinsics for compress instruction set

Author: mzuckerm Date: Fri Apr 29 03:52:02 2016 New Revision: 268013 URL: http://llvm.org/viewvc/llvm-project?rev=268013=rev Log: [Clang][AVX512][Builtin] Adding intrinsics for compress instruction set Differential Revision: http://reviews.llvm.org/D19599 Modified:

r268018 - Implementation of VlA of GNU C++ extension, by Vladimir Yakovlev.

Author: abataev Date: Fri Apr 29 04:39:50 2016 New Revision: 268018 URL: http://llvm.org/viewvc/llvm-project?rev=268018=rev Log: Implementation of VlA of GNU C++ extension, by Vladimir Yakovlev. This enables GNU C++ extension "Variable length array" by default. Differential Revision:

Re: [PATCH] D19665: [ARM] Guard the declarations of f16 to f32 vcvt intrinsics in arm_neon.h by testing __ARM_FP

sbaranga added inline comments. Comment at: include/clang/Basic/arm_neon.td:710-711 @@ -709,2 +709,4 @@ + def VCVT_F32_F16 : SInst<"vcvt_f32_f16", "wd", "h">; +} def VCVT_S32 : SInst<"vcvt_s32", "xd", "fQf">; Thanks for catching this!

Re: [PATCH] D15654: A Python code model for C++ used to drive code generators

jbcoe abandoned this revision. jbcoe added a comment. I'm abandoning this revision for lack of interest. http://reviews.llvm.org/D15654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19665: [ARM] Guard the declarations of f16 to f32 vcvt intrinsics in arm_neon.h by testing __ARM_FP

sbaranga updated this revision to Diff 5. sbaranga added a comment. Don't change the AArch64 intrinsics and move the test to Sema. http://reviews.llvm.org/D19665 Files: include/clang/Basic/arm_neon.td test/Sema/arm-no-fp16.c Index: include/clang/Basic/arm_neon.td

r268020 - [OPENMP] Fix detection of explicit data-sharing attributes in templates.

Author: abataev Date: Fri Apr 29 04:56:11 2016 New Revision: 268020 URL: http://llvm.org/viewvc/llvm-project?rev=268020=rev Log: [OPENMP] Fix detection of explicit data-sharing attributes in templates. Fixes a bug with analysis of data-sharing attributes in templates. Modified:

[clang-tools-extra] r268021 - [find-all-symbols] Fix racy yaml file writing.

Author: d0k Date: Fri Apr 29 05:16:28 2016 New Revision: 268021 URL: http://llvm.org/viewvc/llvm-project?rev=268021=rev Log: [find-all-symbols] Fix racy yaml file writing. If multiple find-all-symbols processes access the temporary directory simultaneously with two files with the same name they

Re: [PATCH] D19415: [libcxx][rfc] Externalized threading support

rmaprath updated this revision to Diff 55570. rmaprath added a comment. Re-sync with http://reviews.llvm.org/D19412. http://reviews.llvm.org/D19415 Files: include/__threading_support Index: include/__threading_support === ---

Re: [PATCH] D19412: [libcxx] Refactor pthread usage - II

rmaprath updated this revision to Diff 55569. rmaprath added a comment. Minor tweak: Got rid of the unnecessary template parameters on `__libcpp_thread_create` and `__libcpp_tl_create`. http://reviews.llvm.org/D19412 Files: include/__config include/__mutex_base

Re: [PATCH] D19415: [libcxx][rfc] Externalized threading support

rmaprath updated this revision to Diff 55573. rmaprath added a comment. Minor re-spin on http://reviews.llvm.org/D19412. http://reviews.llvm.org/D19415 Files: include/__threading_support Index: include/__threading_support ===

Re: [PATCH] D19647: [find-all-symbols] Save absolute file path instead of relative file path in SymbolInfo.

This revision was automatically updated to reflect the committed changes. Closed by commit rL268019: [find-all-symbols] Save absolute file path instead of relative file path in… (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D19647?vs=55398=6#toc Repository: rL

Re: [PATCH] D19412: [libcxx] Refactor pthread usage - II

rmaprath updated this revision to Diff 7. rmaprath added a comment. In http://reviews.llvm.org/D19412#416183, @EricWF wrote: > OK. I *think* this is my last round of review comments except for one > specific issue. I'm still looking into the changes to the static mutex's and >

Re: [PATCH] D19361: [MS] Improved implementation of MS stack pragmas (vtordisp, *_seg)

This revision was automatically updated to reflect the committed changes. Closed by commit rL268029: Recommit "[MS] Improved implementation of stack pragmas (vtordisp, *_seg)" (authored by dzobnin). Changed prior to commit: http://reviews.llvm.org/D19361?vs=54484=55568#toc Repository: rL

[clang-tools-extra] r268019 - [find-all-symbols] Save absolute file path instead of relative file path in SymbolInfo.

Author: hokein Date: Fri Apr 29 04:45:09 2016 New Revision: 268019 URL: http://llvm.org/viewvc/llvm-project?rev=268019=rev Log: [find-all-symbols] Save absolute file path instead of relative file path in SymbolInfo. Reviewers: bkramer Subscribers: cfe-commits Differential Revision:

Re: [PATCH] D18274: [clang-tidy] Add boost module

Prazek abandoned this revision. Prazek added a comment. Merged with boost-use-to-string http://reviews.llvm.org/D18274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r268022 - Make run-find-all-symbols executable.

Author: d0k Date: Fri Apr 29 05:33:11 2016 New Revision: 268022 URL: http://llvm.org/viewvc/llvm-project?rev=268022=rev Log: Make run-find-all-symbols executable. Modified: clang-tools-extra/trunk/include-fixer/find-all-symbols/tool/run-find-all-symbols.py (contents, props changed)

[PATCH] D19720: [find-all-symbols] Parallelize the merge step.

bkramer created this revision. bkramer added reviewers: hokein, djasper. bkramer added a subscriber: cfe-commits. There is still more parallelism to get here because we synchonize on the actual uniquing but just doing YAML parsing in parallel already gives a significant speedup. Merging all

r268029 - Recommit "[MS] Improved implementation of stack pragmas (vtordisp, *_seg)"

Author: dzobnin Date: Fri Apr 29 06:27:00 2016 New Revision: 268029 URL: http://llvm.org/viewvc/llvm-project?rev=268029=rev Log: Recommit "[MS] Improved implementation of stack pragmas (vtordisp, *_seg)" Slightly updated version, double-checked build and tests. Improve implementation of MS

Re: [PATCH] D19156: [ms][dll] #27212: Generating of implicit special members should take into account MSVC compatibility version

avt77 updated this revision to Diff 55567. avt77 added a comment. Now it's really a micro-patch: please review. http://reviews.llvm.org/D19156 Files: lib/Sema/SemaDeclCXX.cpp test/CodeGenCXX/dllexport.cpp Index: lib/Sema/SemaDeclCXX.cpp

Re: [PATCH] D19720: [find-all-symbols] Parallelize the merge step.

bkramer updated this revision to Diff 55577. bkramer added a comment. Drain the pool, fix typo. http://reviews.llvm.org/D19720 Files: include-fixer/find-all-symbols/tool/FindAllSymbolsMain.cpp Index: include-fixer/find-all-symbols/tool/FindAllSymbolsMain.cpp

Re: [PATCH] D18136: boost-use-to-string check

Prazek updated this revision to Diff 8. Prazek marked an inline comment as done. Prazek added a comment. merged with boost module http://reviews.llvm.org/D18136 Files: clang-tidy/CMakeLists.txt clang-tidy/boost/BoostTidyModule.cpp clang-tidy/boost/CMakeLists.txt

Re: [PATCH] D19622: [libc++] Implement the member functions of a local struct.

On 28.04.2016 04:25, Eric Fiselier via cfe-commits wrote: EricWF closed this revision. EricWF added a comment. r267843. This warning seems a bit silly though. And here I thought this warning was gone after VS 2008, given that its dedicated warning page was removed. But it's apparently

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

This revision was automatically updated to reflect the committed changes. Closed by commit rL268018: Implementation of VlA of GNU C++ extension, by Vladimir Yakovlev. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D18823?vs=53658=4#toc Repository: rL LLVM

Re: [PATCH] D18136: boost-use-to-string check

Prazek marked 2 inline comments as done. Comment at: clang-tidy/boost/UseToStringCheck.cpp:38 @@ +37,3 @@ + argumentCountIs(1), unless(isInTemplateInstantiation())) + .bind("to_string"), + this); alexfh wrote: > clang-format? nope,

[PATCH] D19717: [find-all-symbols] Fix racy yaml file writing.

bkramer created this revision. bkramer added a reviewer: hokein. bkramer added a subscriber: cfe-commits. If multiple find-all-symbols processes access the temporary directory simultaneously with two files with the same name they would collide and create a broken yaml file. Fix this by using the

Re: [PATCH] D19717: [find-all-symbols] Fix racy yaml file writing.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! LGTM with one nit. Comment at: include-fixer/find-all-symbols/SymbolInfo.h:92 @@ +91,3 @@ +/// \brief Write SymbolInfos to a stream (YAML format). +bool

Re: [PATCH] D19717: [find-all-symbols] Fix racy yaml file writing.

This revision was automatically updated to reflect the committed changes. Closed by commit rL268021: [find-all-symbols] Fix racy yaml file writing. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D19717?vs=9=55562#toc Repository: rL LLVM

r268028 - [clang][BuiltIn][AVX512]Adding intrinsics for cmp{ss|sd} instruction set.

Author: mzuckerm Date: Fri Apr 29 06:01:16 2016 New Revision: 268028 URL: http://llvm.org/viewvc/llvm-project?rev=268028=rev Log: [clang][BuiltIn][AVX512]Adding intrinsics for cmp{ss|sd} instruction set. Differential Revision: http://reviews.llvm.org/D19601 Modified:

Re: [PATCH] D19412: [libcxx] Refactor pthread usage - II

rmaprath updated this revision to Diff 55571. rmaprath added a comment. Missed one: s/_LIBCPP_COND_INITIALIZER/_LIBCPP_CONDVAR_INITIALIZER http://reviews.llvm.org/D19412 Files: include/__config include/__mutex_base include/__threading_support include/mutex include/thread

Re: [PATCH] D18700: [Inline asm][GCC compatibility] Handle %v-prefixed code in inline assembly

d.zobnin.bugzilla updated this revision to Diff 55581. d.zobnin.bugzilla added a comment. Herald added a subscriber: joker.eph. Updated the patch after r266292 commit: [ASTImporter] Implement some expression-related AST node import. http://reviews.llvm.org/D18700 Files:

Re: [PATCH] D19654: PR27132: Proper mangling for __unaligned qualifier (now with PR27367 fixed)

andreybokhanko updated this revision to Diff 55588. andreybokhanko added a comment. Fixed a bug uncovered by David Majnemer's review; added tests he asked for. http://reviews.llvm.org/D19654 Files: include/clang/AST/Type.h include/clang/Basic/AddressSpaces.h include/clang/Basic/Attr.td

[PATCH] D19721: Fix crash in BuildCXXDefaultInitExpr.

teemperor created this revision. teemperor added reviewers: cfe-commits, rnk. Fix crash in BuildCXXDefaultInitExpr when member of template class has same name as the class itself. http://reviews.llvm.org/D19721 Files: lib/Sema/SemaDeclCXX.cpp

Re: [PATCH] D19658: [X86] Add -m[no-]x87 and -m[no-]80387 options to control FeatureX87

aturetsk added a comment. Hi, Thanks for the review. All m_x86_Features_Group options are handled in function handleTargetFeaturesGroup from lib/Driver/Tools.cpp, so there is no additional code needed. There was no test for this, so I added a new one trying to cover all options from

Re: [PATCH] D19361: [MS] Improved implementation of MS stack pragmas (vtordisp, *_seg)

d.zobnin.bugzilla added a comment. Reid, thanks for review! I've changed the patch according to your comments and also moved implementation of RAII object to SemaAttr.cpp file (implementation in header broke many buildbots). Nico, I will look at serialization and try to implement the desired

Re: [PATCH] D19720: [find-all-symbols] Parallelize the merge step.

This revision was automatically updated to reflect the committed changes. Closed by commit rL268037: [find-all-symbols] Parallelize the merge step. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D19720?vs=55577=55589#toc Repository: rL LLVM

[clang-tools-extra] r268037 - [find-all-symbols] Parallelize the merge step.

Author: d0k Date: Fri Apr 29 07:46:27 2016 New Revision: 268037 URL: http://llvm.org/viewvc/llvm-project?rev=268037=rev Log: [find-all-symbols] Parallelize the merge step. There is still more parallelism to get here because we synchonize on the actual uniquing but just doing YAML parsing in

Re: [PATCH] D19720: [find-all-symbols] Parallelize the merge step.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Just see you updated code. LGTM. http://reviews.llvm.org/D19720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19720: [find-all-symbols] Parallelize the merge step.

hokein added inline comments. Comment at: include-fixer/find-all-symbols/tool/FindAllSymbolsMain.cpp:107 @@ -94,3 +106,3 @@ } llvm::raw_fd_ostream OS(OutputFile, EC, llvm::sys::fs::F_None); Don't we need to all 'Pool.wait()' to wait for all working

Re: [PATCH] D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC

hubert.reinterpretcast added inline comments. Comment at: include/clang/AST/DeclTemplate.h:175 @@ -152,2 +174,3 @@ + Expr *RequiresClause; public: faisalv wrote: > Yuk - this entire guy (FizedSizeTemplateParameterListStorage) seems quite > fragile (dependent

Re: [PATCH] D19658: [X86] Add -m[no-]x87 and -m[no-]80387 options to control FeatureX87

aturetsk updated this revision to Diff 55579. aturetsk added a comment. Add a missing option and a test. http://reviews.llvm.org/D19658 Files: include/clang/Driver/Options.td test/Driver/x86-target-features.c Index: test/Driver/x86-target-features.c

Re: [PATCH] D19689: Add Subjects to NoDebugAttr [NFC]

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This turns out to be a bit of a mess: Alias and NoDebug use the same diagnostic kind text, neither of which match the actual subject list. Alias doesn't appertain to an obj-c

Re: [PATCH] D19412: [libcxx] Refactor pthread usage - II

rmaprath updated this revision to Diff 55593. rmaprath added a comment. Added missing `__confg` header include. http://reviews.llvm.org/D19412 Files: include/__config include/__mutex_base include/__threading_support include/mutex include/thread src/algorithm.cpp

Re: [PATCH] D19665: [ARM] Guard the declarations of f16 to f32 vcvt intrinsics in arm_neon.h by testing __ARM_FP

sbaranga added a comment. Thanks, r268047! Cheers, Silviu http://reviews.llvm.org/D19665 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19183: [clang-tidy] Add modernize-make-shared check

Prazek added a subscriber: alexfh. Prazek added a comment. ping. @alexfh are you planning to take a look? http://reviews.llvm.org/D19183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r268047 - [ARM] Guard the declarations of f16 to f32 vcvt intrinsics in arm_neon.h by testing __ARM_FP

Author: sbaranga Date: Fri Apr 29 10:03:32 2016 New Revision: 268047 URL: http://llvm.org/viewvc/llvm-project?rev=268047=rev Log: [ARM] Guard the declarations of f16 to f32 vcvt intrinsics in arm_neon.h by testing __ARM_FP Summary: Conversions between float and half are only available when the

Re: [PATCH] D19484: [OpenCL] Add supported OpenCL extensions to target info.

yaxunl updated this revision to Diff 55600. yaxunl added a comment. Add defining macro cl_khr_ for supported extensions or optional core features. Enable supported extensions or optional core features only if it is available in the OpenCL version the program is compiled with. Add spir triple

r268055 - Recommitted r264281 "Supporting all entities declared in lexical scope in LLVM debug info."

Author: aaboud Date: Fri Apr 29 11:08:08 2016 New Revision: 268055 URL: http://llvm.org/viewvc/llvm-project?rev=268055=rev Log: Recommitted r264281 "Supporting all entities declared in lexical scope in LLVM debug info." After fixing PR26942 in r267004. Added:

Re: [PATCH] D19547: [clang-tidy] Add FixIt for swapping arguments in string-constructor-checker.

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/misc/StringConstructorCheck.cpp:110 @@ -106,2 +109,3 @@ if (Result.Nodes.getNodeAs("swapped-parameter")) { -diag(Loc, "constructor parameters are probably

Re: [PATCH] D19689: Add Subjects to NoDebugAttr [NFC]

On Fri, Apr 29, 2016 at 12:24 PM, Paul Robinson wrote: > probinson added a comment. > > I'll proceed from here without doing anything about the inconsistencies, > because this particular one should go away and you're already doing something > about the rest of it. I

Re: [PATCH] D19721: Fix crash in BuildCXXDefaultInitExpr.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: test/SemaCXX/pr27047-default-init-expr-name-conflict.cpp:6 @@ +5,3 @@ +template +struct B { + More reduced: template struct A { int A = 0; };

Re: [PATCH] D19590: Check for CERT ERR34-C. Detect errors when converting a string to a number

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with a few nits. Comment at: clang-tidy/cert/StrToNumCheck.cpp:182 @@ +181,3 @@ +void StrToNumCheck::check(const MatchFinder::MatchResult ) { + const auto *CE =

Re: [PATCH] D19665: [ARM] Guard the declarations of f16 to f32 vcvt intrinsics in arm_neon.h by testing __ARM_FP

t.p.northover accepted this revision. t.p.northover added a reviewer: t.p.northover. t.p.northover added a comment. This revision is now accepted and ready to land. Looks good. Thanks for updating the patch. Tim. http://reviews.llvm.org/D19665 ___

Re: [PATCH] D19708: [CGDebugInfo] Generate debug info for member calls in the context of the callee expression

hfinkel updated this revision to Diff 55610. hfinkel added a comment. Use David's suggested approach: Modify the preferred expression location for member calls. If the callee has a valid location (not all do), then use that. Otherwise, fall back to the starting location. This seems to cleanly

Re: [PATCH] D19689: Add Subjects to NoDebugAttr [NFC]

probinson added a comment. I'll proceed from here without doing anything about the inconsistencies, because this particular one should go away and you're already doing something about the rest of it. Comment at: include/clang/Basic/Attr.td:977 @@ -976,1 +976,3 @@ + let

Re: [PATCH] D19708: [CGDebugInfo] Generate debug info for member calls in the context of the callee expression

Seems a much more principled solution yes. On Fri, Apr 29, 2016, 9:19 AM Hal Finkel wrote: > hfinkel updated this revision to Diff 55610. > hfinkel added a comment. > > Use David's suggested approach: Modify the preferred expression location > for member calls. If the callee

Re: [PATCH] D19708: [CGDebugInfo] Generate debug info for member calls in the context of the callee expression

echristo added a subscriber: echristo. echristo added a comment. Seems a much more principled solution yes. http://reviews.llvm.org/D19708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19679: Method pool in modules: sync up out of date selectors before writing the module

manmanren added a comment. Adrian, Thanks for reviewing the patch! Manman Comment at: include/clang/Serialization/ASTReader.h:657 @@ +656,3 @@ + /// Whether a selector is out of date. We mark a selector as out of date + // if we load another module after the method pool

Re: [PATCH] D19689: Add Subjects to NoDebugAttr [NFC]

On Thu, Apr 28, 2016 at 4:46 PM, Robinson, Paul wrote: > Generally tests test something other than "this program doesn't crash" - > should it test that we apply the attribute correctly? (either via ast dump, > or checking the resulting DWARF doesn't have debug info on the

Re: [PATCH] D19708: [CGDebugInfo] Generate debug info for member calls in the context of the callee expression

As mentioned in the bug, I /think/ the right thing to do here is to change the preferred location of the CXXMemberCallExpr so that we improve diagnostics as well. Any place where the preferred location of an expression and the debug location of an expression are differing I'd really like a pretty

[PATCH] D19727: [MS] Improved implementation #pragma pack (MS pragmas, part 2)

d.zobnin.bugzilla created this revision. d.zobnin.bugzilla added a reviewer: rnk. d.zobnin.bugzilla added subscribers: thakis, cfe-commits. An attempt to make implementation of #pragma pack consistent with other "stack" pragmas. Also modifies #pragma options align, since it shares the stack with

Re: r267904 - Debug info: Apply an artificial debug location to __cyg_profile_func.* calls.

On Thu, Apr 28, 2016 at 4:42 PM, Adrian Prantl wrote: > > On Apr 28, 2016, at 4:31 PM, David Blaikie wrote: > > > > On Thu, Apr 28, 2016 at 1:11 PM, Adrian Prantl wrote: > >> >> On Apr 28, 2016, at 12:53 PM, David Blaikie

Re: [PATCH] D19666: [ubsan] Add -fubsan-strip-path-components=N

filcab updated this revision to Diff 55605. filcab marked 2 inline comments as done. filcab added a comment. Addressed Richard's comments. Waiting on http://reviews.llvm.org/D19724 (operator- on Path's reverse_iterator) before landing this. http://reviews.llvm.org/D19666 Files:

[PATCH] D19725: [Coverage] Fix an issue where a coverage region might not be created for a macro containing for or while statements.

ikudrin created this revision. ikudrin added reviewers: bogner, davidxl, vsk. ikudrin added a subscriber: cfe-commits. The situation happened when a macro contained a full loop statement, which body ended at the end of the macro. http://reviews.llvm.org/D19725 Files:

Re: [PATCH] D19727: [MS] Improved implementation #pragma pack (MS pragmas, part 2)

d.zobnin.bugzilla added inline comments. Comment at: lib/Sema/SemaAttr.cpp:277-278 @@ -276,4 @@ - // empty. - Diag(PragmaLoc, diag::warn_pragma_pop_failed) - << "pack" << (Name ? "no record matching name" : "stack empty"); - Here I removed the

Re: [PATCH] D19679: Method pool in modules: sync up out of date selectors before writing the module

aprantl added inline comments. Comment at: test/Modules/method_pool_write.m:3 @@ +2,3 @@ +// RUN: %clang_cc1 -fmodules-cache-path=%t -fmodules -fimplicit-module-maps -I %S/Inputs %s -verify +// expected-no-diagnostics + manmanren wrote: > aprantl wrote: > > Is

Re: [PATCH] D19346: [CUDA] Copy host builtin types to NVPTXTargetInfo.

This revision was automatically updated to reflect the committed changes. jlebar marked 2 inline comments as done. Closed by commit rL268131: [CUDA] Copy host builtin types to NVPTXTargetInfo. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D19346?vs=55648=55682#toc

[clang-tools-extra] r268140 - [Release Notes] Mention Clang-tidy cert-err34-c check.

Author: eugenezelenko Date: Fri Apr 29 19:11:10 2016 New Revision: 268140 URL: http://llvm.org/viewvc/llvm-project?rev=268140=rev Log: [Release Notes] Mention Clang-tidy cert-err34-c check. Fix order and style of Boost related notes. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst

[PATCH] D19756: Expand aggregate arguments more often on 32-bit Windows

rnk created this revision. rnk added reviewers: majnemer, hans. rnk added a subscriber: cfe-commits. Before this change, we would pass all non-HFA record arguments on Windows with byval. Byval often blocks optimizations and results in bad code generation. Windows now uses the existing workaround

[PATCH] D19755: [include-fixer] Fix Clang-tidy modernize-use-override and some Include What You Use warnings

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: bkramer, hokein, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository:

r268151 - Reverting 268055 as it caused PR27579.

Author: aaboud Date: Fri Apr 29 20:44:38 2016 New Revision: 268151 URL: http://llvm.org/viewvc/llvm-project?rev=268151=rev Log: Reverting 268055 as it caused PR27579. Removed: cfe/trunk/test/CodeGenCXX/debug-info-lb.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D19759: [libcxx] [test] Replace one more occurrence of non-Standard std::launch::any with AnyPolicy.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Replace one more occurrence of non-Standard std::launch::any with AnyPolicy. Also, fix MSVC "warning C4101: 'ex': unreferenced local variable".

Re: [PATCH] D19756: Expand aggregate arguments more often on 32-bit Windows

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. This is awesome! lgtm I only have nits and questions. Want to reference PR27522 in the patch description? Also in the description: > I also expanded the workaround handle C++ records with

Re: r268113 - [Sema] Specify the underlying type for an enum. NFC.

On Fri, Apr 29, 2016 at 6:02 PM, George Burgess IV wrote: > Right under the enum is an 11x11 static array of PromotedType. This change > makes that array size go from 484 bytes to 121. Ah, good to know. That sort of information would be useful in the commit message

[PATCH] D19758: [libcxx] [test] Replace non-Standard "atomic_flag f(false); " with Standard "atomic_flag f = ATOMIC_FLAG_INIT; ".

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Replace non-Standard "atomic_flag f(false);" with Standard "atomic_flag f = ATOMIC_FLAG_INIT;". The test init03.pass.cpp is explicitly testing this

Re: [PATCH] D19759: [libcxx] [test] Replace one more occurrence of non-Standard std::launch::any with AnyPolicy.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Woops, guess I was a bit careless there. http://reviews.llvm.org/D19759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19412: [libcxx] Refactor pthread usage - II

EricWF added a comment. In http://reviews.llvm.org/D19412#416596, @rmaprath wrote: > In http://reviews.llvm.org/D19412#416183, @EricWF wrote: > > > OK. I *think* this is my last round of review comments except for one > > specific issue. I'm still looking into the changes to the static mutex's

Re: [PATCH] D16965: Fix for Bug 14644 - clang confuses scope operator for global namespace giving extra qualification on member

ryee88 updated this revision to Diff 55707. ryee88 added a comment. Removed unnecessary code changes. This patch contains a unit test to detect a regression of this global name specifier issue. http://reviews.llvm.org/D16965 Files: test/Parser/cxx-class.cpp Index: test/Parser/cxx-class.cpp

Re: [PATCH] D19625: [libc++] Void-cast runtime-unused variables.

STL_MSFT updated the summary for this revision. STL_MSFT updated this revision to Diff 55683. STL_MSFT added a comment. This moves "str" as requested. It also adds void casts to another file, and removes an unused argc/argv pair. http://reviews.llvm.org/D19625 Files:

Re: r268129 - [NFC] Initialize a variable to make buildbot green.

On Fri, Apr 29, 2016 at 3:50 PM, Denis Zobnin via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dzobnin > Date: Fri Apr 29 17:50:16 2016 > New Revision: 268129 > > URL: http://llvm.org/viewvc/llvm-project?rev=268129=rev > Log: > [NFC] Initialize a variable to make buildbot green. > >

RE: [PATCH] D19625: [libc++] Void-cast runtime-unused variables.

[David Blaikie] > Unused-variable seems pretty low value. Yeah, but it still has the potential to detect mistakes (e.g. typos, or code you intended to write but forgot about). I figured I'd submit a patch, since there weren't actually that many occurrences, and they were all easy to silence in

[PATCH] D19754: Allow 'nodebug' on local variables

probinson created this revision. probinson added reviewers: aaron.ballman, dblaikie, aprantl. probinson added a subscriber: cfe-commits. Expand the purview of the 'nodebug' attribute from functions/methods and static-storage variables to include local variables. Parameters and members of

Re: [PATCH] D19483: docs: Update SafeStack docs with separate-stack-seg feature and single-thread storage

mlemay-intel updated this revision to Diff 55706. mlemay-intel added a comment. Add documentation for -safe-stack-usp-storage=tcb, -safe-stack-usp-tcb-offset=, and -safe-stack-usp-init. http://reviews.llvm.org/D19483 Files: docs/SafeStack.rst Index: docs/SafeStack.rst

Re: [PATCH] D19625: [libc++] Void-cast runtime-unused variables.

I'm not sure why we'd want to compile the test suite with -Wunused-variable (& even if we did, I imagine Clang's doesn't fire here because the variables are used, just in non-evaluated contexts?)? Is there a benefit to it being clean of unused-variable warnings? (in Clang's test case we just

r268131 - [CUDA] Copy host builtin types to NVPTXTargetInfo.

Author: jlebar Date: Fri Apr 29 18:05:19 2016 New Revision: 268131 URL: http://llvm.org/viewvc/llvm-project?rev=268131=rev Log: [CUDA] Copy host builtin types to NVPTXTargetInfo. Summary: Host and device types must match, otherwise when we pass values back and forth between the host and device,

Re: [PATCH] D19749: Delete store to Target option PositionIndependentExecutable

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D19749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19536: [CodeGenObjCXX] Fix handling of blocks in lambda

rjmccall added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:806 @@ -792,1 +805,3 @@ + } + src = Builder.CreateStructGEP(Addr, Idx, Offset, FD->getName()); } else { Hmm. It's become increasingly clear that my original decision to expand

Re: [PATCH] D19625: [libc++] Void-cast runtime-unused variables.

STL_MSFT marked 2 inline comments as done. STL_MSFT added a comment. What I'm doing is running libcxx's tests against MSVC's compiler and libraries. I could aggressively suppress warnings (and indeed I'm doing that for the noisiest, lowest-value warnings), but instead I'm building the tests

Re: [PATCH] D19759: [libcxx] [test] Replace one more occurrence of non-Standard std::launch::any with AnyPolicy.

EricWF closed this revision. EricWF added a comment. r268153. http://reviews.llvm.org/D19759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r268153 - Replace one more occurrence of non-standard std:launch::any. Patch from s...@microsoft.com

Author: ericwf Date: Fri Apr 29 21:30:18 2016 New Revision: 268153 URL: http://llvm.org/viewvc/llvm-project?rev=268153=rev Log: Replace one more occurrence of non-standard std:launch::any. Patch from s...@microsoft.com Modified:

Re: [PATCH] D19625: [libc++] Void-cast runtime-unused variables.

On Fri, Apr 29, 2016 at 4:34 PM, Stephan T. Lavavej via cfe-commits < cfe-commits@lists.llvm.org> wrote: > STL_MSFT marked 2 inline comments as done. > STL_MSFT added a comment. > > What I'm doing is running libcxx's tests against MSVC's compiler and > libraries. I could aggressively suppress

r268137 - Delete store to Target option PositionIndependentExecutable as PIE is now set in module flags.

Author: tmsriram Date: Fri Apr 29 18:38:53 2016 New Revision: 268137 URL: http://llvm.org/viewvc/llvm-project?rev=268137=rev Log: Delete store to Target option PositionIndependentExecutable as PIE is now set in module flags. Differential Revision: http://reviews.llvm.org/D19749 Modified:

Re: [PATCH] D19749: Delete store to Target option PositionIndependentExecutable

This revision was automatically updated to reflect the committed changes. Closed by commit rL268137: Delete store to Target option PositionIndependentExecutable as PIE is now set… (authored by tmsriram). Changed prior to commit: http://reviews.llvm.org/D19749?vs=55676=55687#toc Repository:

Re: [PATCH] D19625: [libc++] Void-cast runtime-unused variables.

On Fri, Apr 29, 2016 at 4:59 PM, Stephan T. Lavavej < s...@exchange.microsoft.com> wrote: > [David Blaikie] > > Unused-variable seems pretty low value. > > Yeah, but it still has the potential to detect mistakes (e.g. typos, or > code you intended to write but forgot about). > > I figured I'd

Re: r268113 - [Sema] Specify the underlying type for an enum. NFC.

Yeah, I was thinking the diff would show the array decl so that the motivation would be less ambiguous, but it looks like it was clipped out entirely. I'll try to be a bit more descriptive in the future, though; thanks for asking to clarify. :) On Fri, Apr 29, 2016 at 4:59 PM, Aaron Ballman

Re: r268127 - Add a new warning to notify users of mismatched SDK and deployment target

This breaks the PS4 bots at least. They've been red for hours now. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast?numbuilds=100 On Fri, Apr 29, 2016 at 3:28 PM, Chris Bieneman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: cbieneman > Date: Fri Apr

RE: [PATCH] D19625: [libc++] Void-cast runtime-unused variables.

[STL] > When my work is finished (currently 3132 tests are passing out of 4541), I > expect that > we'll start running libcxx's tests in our automation, which will detect > regressions rapidly and reliably. [David Blaikie] > It'd be great to have this sort of stuff upstream (in a public facing

Re: [PATCH] D19625: [libc++] Void-cast runtime-unused variables.

EricWF added a comment. Our test harness has a switch to enable warnings. I would be happy to set up a bot in that configuration. It would probably be easier than setting up one that uses MSVC. Currently that mode disables the unused variable warnings but if/when STL cleans all of those we can

  1   2   >