Re: [PATCH] D19770: Add FixedSizeStorage to TrailingObjects; NFC

hubert.reinterpretcast updated this revision to Diff 55728. hubert.reinterpretcast added a comment. Use AlignOf instead of AlignmentCalcHelper Since BaseTy should be aligned properly for its trailing objects, the use of AlignmentCalcHelper is unnecessary. http://reviews.llvm.org/D19770 Files:

Re: [PATCH] D19658: [X86] Add -m[no-]x87 and -m[no-]80387 options to control FeatureX87

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Nice. If you wouldn't mind splitting out into 3 patches (all ok): a) The initial testcase, b) the mno-cx16 patch and associated test c) The x87 part and associated test. You'll also want

Re: [PATCH] D19483: docs: Update SafeStack docs with separate-stack-seg feature and various USP storage modes

pcc added a comment. > It appears that Clang already supports an -mthread_model=single option, so do > you recommend that I remove the -mllvm -safe-stack-usp-storage=single-thread > option and rely on -mthread_model instead? Makes sense to me. We're free to break `-mllvm` flags, they are for

Re: [PATCH] D19483: docs: Update SafeStack docs with separate-stack-seg feature and various USP storage modes

mlemay-intel added a comment. In http://reviews.llvm.org/D19483#417865, @pcc wrote: > > This makes sense for the example I gave. However, there are also more > > complicated situations. Sometimes it is necessary to specify different > > options for different files that are compiled for the

Re: [PATCH] D19770: Add FixedSizeStorage to TrailingObjects; NFC

hubert.reinterpretcast added a comment. An example of using `FixedSizeStorage` can be found in http://reviews.llvm.org/D19771. Comment at: include/llvm/Support/TrailingObjects.h:352 @@ +351,3 @@ +template +using _ = +

[PATCH] D19771: Rework FixedSizeTemplateParameterListStorage

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: rsmith, faisalv, aaron.ballman. hubert.reinterpretcast added subscribers: nwilson, cfe-commits. This change replaces the custom FixedSizeTemplateParameterListStorage implementation with one that follows the

[PATCH] D19770: Add FixedSizeStorage to TrailingObjects; NFC

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: rsmith, faisalv, aaron.ballman. hubert.reinterpretcast added subscribers: nwilson, cfe-commits, llvm-commits. This change introduces two types, `FixedSizeStorage` and `FixedSizeStorageOwner`, which can be used

Re: [PATCH] D19483: docs: Update SafeStack docs with separate-stack-seg feature and various USP storage modes

pcc added a comment. > This makes sense for the example I gave. However, there are also more > complicated situations. Sometimes it is necessary to specify different > options for different files that are compiled for the same OS. For example, > early during the initialization of a dynamic

Re: [PATCH] D19483: docs: Update SafeStack docs with separate-stack-seg feature and various USP storage modes

mlemay-intel added a comment. In http://reviews.llvm.org/D19483#417857, @pcc wrote: > You should be using `-target x86-unknown-contiki` or similar. That should > tune the behaviour to what is required for that OS. See what we have in > `TargetLoweringBase::getSafeStackPointerLocation` to

Re: [PATCH] D19483: docs: Update SafeStack docs with separate-stack-seg feature and various USP storage modes

pcc added a comment. You should be using `-target x86-unknown-contiki` or similar. That should tune the behaviour to what is required for that OS. See what we have in `TargetLoweringBase::getSafeStackPointerLocation` to provide Android-specific behaviour for example. The existence of flags is

Re: [PATCH] D17841: [libclang/python] Add bindings for children of diagnostics

compnerd closed this revision. compnerd added a comment. Committed as SVN r268167. Thanks for the patch! http://reviews.llvm.org/D17841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r268167 - python: add bindings for children of diagnostics

Author: compnerd Date: Sat Apr 30 16:14:01 2016 New Revision: 268167 URL: http://llvm.org/viewvc/llvm-project?rev=268167=rev Log: python: add bindings for children of diagnostics This exposes the Clang API bindings clang_getChildDiagnostics (which returns a CXDiagnosticSet) and

Re: [PATCH] D19483: docs: Update SafeStack docs with separate-stack-seg feature and various USP storage modes

mlemay-intel added a comment. In http://reviews.llvm.org/D19483#417844, @pcc wrote: > We shouldn't be adding (much less documenting) `-mllvm` flags. Is there any > reason why this behavior can't be gated on the OS? We actually already have added at least one `-mllvm` flag: `-mllvm

Re: [PATCH] D19483: docs: Update SafeStack docs with separate-stack-seg feature and various USP storage modes

pcc added a comment. We shouldn't be adding (much less documenting) `-mllvm` flags. Is there any reason why this behavior can't be gated on the OS? http://reviews.llvm.org/D19483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] RHEL: Look in more places to find g++ headers and runtime

LGTM. Do you have commit access? Cheers, Rafael On 11 April 2016 at 14:49, Michael Lampe wrote: > New patch attached. > > -Michael > > > Rafael Espíndola wrote: >> >> LGTM with a comment saying why it is needed. >> >> Cheers, >> Rafael >> >> >> On 22 March 2016 at

Re: [PATCH] D19769: [clang-tidy] Add explicitly given array size heuristic to misc-suspicious-missing-comma check.

etienneb added a comment. If you are interested to a quick chat on this Checker, ping me. I know other cases that should be filtered and I'm lacking time to implement them. Here is a common one I would lie to see happening (base on comments): const char* A[] = { // This is a entry

[PATCH] D19769: [clang-tidy] Add explicitly given array size heuristic to misc-suspicious-missing-comma check.

szdominik created this revision. szdominik added reviewers: alexfh, etienneb. szdominik added subscribers: cfe-commits, xazax.hun. Additional heuristic to misc-suspicious-missing-comma checker, based on the (in)equality of the explicitly given array size and the real array size. Note: in these

Re: [PATCH] D18073: Add memory allocating functions

zaks.anna added a comment. You conditionally defined when you build ON Windows machine, not when you build FOR Windows. You should be able to query the compiler to check which targets it's building for. http://reviews.llvm.org/D18073 ___

Re: [PATCH] D19312: Warn about UB at member function calls from base class ctor initializers.

teemperor updated this revision to Diff 55716. teemperor added a comment. Merged all tests into one file. http://reviews.llvm.org/D19312 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDeclCXX.cpp

Re: [PATCH] D19327: Keep invalid function body as part of the AST

ogoffart added a comment. An alternative patch is uploaded there: http://reviews.llvm.org/D19764 http://reviews.llvm.org/D19327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D19764: Keep invalid functions as part of the AST

ogoffart created this revision. ogoffart added reviewers: cfe-commits, rsmith. This is an alternative to http://reviews.llvm.org/D19327 We want to keep all the invalid function declarations as part of the AST. This patch depends also on http://reviews.llvm.org/D19763 otherwise the tests in

[PATCH] D19763: Functions declared in a scope should not hide previous declaration in earlier scopes

ogoffart created this revision. ogoffart added reviewers: cfe-commits, rsmith. This code should be an error: void foo(int); void f3() { int foo(float); { float foo(int); // expected-error {{functions that differ only in their return type cannot be overloaded}} } } the

Re: [PATCH] D19654: PR27132: Proper mangling for __unaligned qualifier (now with PR27367 fixed)

majnemer added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1583-1584 @@ -1579,2 +1582,4 @@ case QMM_Result: +// Presence of __unaligned qualifier shouldn't affect mangling here. +Quals.removeUnaligned(); if ((!IsPointer && Quals) || isa(T)) {

Re: [PATCH] D19412: [libcxx] Refactor pthread usage - II

rmaprath added a comment. In http://reviews.llvm.org/D19412#417682, @EricWF wrote: > In http://reviews.llvm.org/D19412#416596, @rmaprath wrote: > > > In http://reviews.llvm.org/D19412#416183, @EricWF wrote: > > > > > OK. I *think* this is my last round of review comments except for one > > >