Re: [PATCH] D20349: Fix a clang bug in lambda capture of 'this'

The patch'll need a test case (in clang/tests) - I've not looked at the change/have much opinion there, just suggesting adding a test at minimum so when someone does come to review it it's more complete/closer to/ready to commit. On Tue, May 17, 2016 at 9:23 PM, Taewook Oh via cfe-commits <

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler updated this revision to Diff 57657. eric_niebler added a comment. Factor out TrySimplifyPath from Preprocessor::HandleIncludeDirective. Other review feedback. http://reviews.llvm.org/D19843 Files: include/clang/Basic/DiagnosticGroups.td

Re: [PATCH] D19783: Fix cv-qualification of '*this' captures (and nasty bug PR27507 introduced by commit 263921 "Implement Lambda Capture of *this by Value as [=, *this]")

twoh added a comment. My patch passes check-clang and the test cases in this patch as well. BTW, newly added test cases in the patch seem to be passed even without the patch. Isn't the bug appears when template instantiation generates nested lambdas (because template instantiation updates the

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

curdeius added a comment. Nice job! Thanks for taking my remarks into account. Comment at: include/clang/Basic/VirtualFileSystem.h:14 Oops, my fault. http://reviews.llvm.org/D19843 ___ cfe-commits mailing list

[libcxx] r269973 - Mark LWG2583 as complete. I did this a while ago, and forgot to update the table.

Author: marshall Date: Wed May 18 14:31:01 2016 New Revision: 269973 URL: http://llvm.org/viewvc/llvm-project?rev=269973=rev Log: Mark LWG2583 as complete. I did this a while ago, and forgot to update the table. Modified: libcxx/trunk/www/cxx1z_status.html Modified:

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler added inline comments. Comment at: include/clang/Basic/VirtualFileSystem.h:97 @@ +96,3 @@ + return Status->getName(); +else + return Status.getError(); curdeius wrote: > No else needed after return. But then `Status` is not in scope.

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler marked 2 inline comments as done. eric_niebler added a comment. Thanks for the feedback, @curdeius. What happens now? Do I just wait until somebody accepts the llvm diff and this one? How do I increase the likelihood that that happens? http://reviews.llvm.org/D19843

Re: [PATCH] D20382: Add postorder support to RecursiveASTVisitor

teemperor added a comment. The motivation for this patch is a hashing algorithm for all AST nodes which reuses child hash values to be O(n) and therefore needs postorder support (think Java's Object.hashCode() but on AST nodes as an example). The full code that currently uses this feature can be

Re: [PATCH] D19783: Fix cv-qualification of '*this' captures (and nasty bug PR27507 introduced by commit 263921 "Implement Lambda Capture of *this by Value as [=,*this]")

OK - thanks - will take a closer look at this hopefuly this evening or tomorrow - and respond to Richard's other comments too. Faisal Vali On Wed, May 18, 2016 at 1:46 PM, Taewook Oh wrote: > twoh added a comment. > > My patch passes check-clang and the test cases in this patch

[PATCH] D20383: PCH + Module: make sure we write out macros associated with builtin identifiers

manmanren created this revision. manmanren added reviewers: benlangmuir, rsmith. manmanren added a subscriber: cfe-commits. When we import a module that defines a builtin identifier from prefix header and precompile the prefix header, the macro information related to the identifier is lost. If

Re: [PATCH] D20243: [PCH] Disable inclusion of timestamps when generating pch files on windows.

probinson added a comment. This is fine as far as I'm concerned, but I think somebody more familiar with the area ought to chime in. http://reviews.llvm.org/D20243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20243: [PCH] Disable inclusion of timestamps when generating pch files on windows.

thakis added a subscriber: thakis. thakis added a comment. Did you see http://reviews.llvm.org/D19815 ? Does that help? Warren might have opinions on this. http://reviews.llvm.org/D20243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r269989 - Update for llvm change.

Author: rafael Date: Wed May 18 17:04:57 2016 New Revision: 269989 URL: http://llvm.org/viewvc/llvm-project?rev=269989=rev Log: Update for llvm change. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp URL:

[libcxx] r269991 - Optimize declval for compile times. Patch from Eric Niebler.

Author: ericwf Date: Wed May 18 17:23:46 2016 New Revision: 269991 URL: http://llvm.org/viewvc/llvm-project?rev=269991=rev Log: Optimize declval for compile times. Patch from Eric Niebler. This patch implements the C++11 version of declval without requiring a template instantiation. See PR27798

[PATCH] D20382: Add postorder support to RecursiveASTVisitor

teemperor created this revision. teemperor added reviewers: zaks.anna, v.g.vassilev, doug.gregor, chandlerc. teemperor added a subscriber: cfe-commits. This patch adds postorder traversal support to the RecursiveASTVisitor. This feature needs to be explicitly enabled by overriding

Re: [PATCH] D20243: [PCH] Disable inclusion of timestamps when generating pch files on windows.

cameron314 added a subscriber: cameron314. cameron314 added a comment. I've seen rare cases where parses using the PCH files were yielding completely invalid data, almost as if they were corrupted. I wonder now if this could be the cause. (We're on Windows too.) http://reviews.llvm.org/D20243

Re: [PATCH] D20243: [PCH] Disable inclusion of timestamps when generating pch files on windows.

wristow added a comment. In http://reviews.llvm.org/D20243#433615, @thakis wrote: > Did you see http://reviews.llvm.org/D19815 ? Does that help? Warren might > have opinions on this. Yes, these are definitely related. Fixing that other problem does //not //also fix the issue here, however

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

hintonda updated this revision to Diff 57686. hintonda added a comment. Improved matcher logic and add better range handling to try to deal with multiple asserts concerning bad ranges when running checker again real code, e.g., libcxx. Even so, still seeing some asserts in

Re: [PATCH] D20325: Add ARM cdp intrinsics

rs added a comment. Hi Renato, I've created 2 new reviews for this work http://reviews.llvm.org/D20394 which adds a test for the intrinsic in llvm and http://reviews.llvm.org/D20394 which fixes the builtin signature for the cdp intrinsic. Thanks, Ranjeet Repository: rL LLVM

[PATCH] D20404: [Driver] Fix driver support for color diagnostics

bruno created this revision. bruno added a reviewer: rsmith. bruno added subscribers: cfe-commits, dexonsmith. Diagnostics that happen during driver time do not have color output support unless -fcolor-diagonostic is explicitly passed into the driver. OTOH, it works great for cc1 mode since

Re: [PATCH] D20394: Fix cdp intrinsic

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. LGTM. Thanks! http://reviews.llvm.org/D20394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r270006 - Fix a funny Dvorak typo.

Author: rafael Date: Wed May 18 19:16:09 2016 New Revision: 270006 URL: http://llvm.org/viewvc/llvm-project?rev=270006=rev Log: Fix a funny Dvorak typo. Modified: cfe/trunk/lib/Parse/ParseStmtAsm.cpp Modified: cfe/trunk/lib/Parse/ParseStmtAsm.cpp URL:

Re: r269910 - Update for llvm change.

yes, thanks. Cheers, Rafael On 18 May 2016 at 19:10, Sean Silva wrote: > > > On Wed, May 18, 2016 at 4:58 AM, Rafael Espindola via cfe-commits > wrote: >> >> Author: rafael >> Date: Wed May 18 06:58:56 2016 >> New Revision: 269910 >> >> URL:

[PATCH] D20394: Fix cdp intrinsic

rs created this revision. rs added a reviewer: rengolin. rs added a subscriber: cfe-commits. Fixed cdp intrinsic to only accept compile time constant values, previously you could pass in a variable to the builtin which would result in illegal llvm assembly output.

[libcxx] r269998 - Cleanup superfluous std:: qualifiers in

Author: ericwf Date: Wed May 18 18:09:24 2016 New Revision: 269998 URL: http://llvm.org/viewvc/llvm-project?rev=269998=rev Log: Cleanup superfluous std:: qualifiers in Modified: libcxx/trunk/include/type_traits Modified: libcxx/trunk/include/type_traits URL:

[PATCH] D20405: [CUDA] allow sm_50,52,53 GPUs

tra created this revision. tra added a reviewer: jlebar. tra added a subscriber: cfe-commits. LLVM accepts them since r233575. http://reviews.llvm.org/D20405 Files: lib/Basic/Targets.cpp lib/Driver/ToolChains.cpp test/CodeGen/nvptx-cpus.c Index: test/CodeGen/nvptx-cpus.c

Re: [PATCH] D20401: [Lexer] Don't merge macro args from different macro files

vsk updated this revision to Diff 57711. vsk added a comment. - Add some comments to the unit test. http://reviews.llvm.org/D20401 Files: lib/Lex/TokenLexer.cpp test/CoverageMapping/Inputs/macros.h test/CoverageMapping/include-macros.c unittests/Lex/LexerTest.cpp Index:

Re: [PATCH] D20325: Add ARM cdp intrinsics

rs added a comment. > http://reviews.llvm.org/D20394 which adds a test for the intrinsic in llvm Wrong link, should be http://reviews.llvm.org/D20393 Repository: rL LLVM http://reviews.llvm.org/D20325 ___ cfe-commits mailing list

Re: r269910 - Update for llvm change.

On Wed, May 18, 2016 at 4:58 AM, Rafael Espindola via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rafael > Date: Wed May 18 06:58:56 2016 > New Revision: 269910 > > URL: http://llvm.org/viewvc/llvm-project?rev=269910=rev > Log: > Update for llvm change. > > Modified: >

Re: [PATCH] D20383: PCH + Module: make sure we write out macros associated with builtin identifiers

bruno added a subscriber: bruno. bruno added a comment. Hi Manman, Comment at: lib/Serialization/ASTWriter.cpp:2191 @@ -2191,1 +2190,3 @@ +// We write out exported module macros for PCH as well. +if (true) { auto Leafs = PP.getLeafModuleMacros(Name);

Re: r270009 - Make Sema::getPrintingPolicy less ridiculously expensive. This used to perform

On Wed, May 18, 2016 at 6:49 PM, Sean Silva via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Wed, May 18, 2016 at 6:39 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rsmith >> Date: Wed May 18 20:39:10 2016 >> New Revision: 270009 >> >> URL:

Re: r270009 - Make Sema::getPrintingPolicy less ridiculously expensive. This used to perform

Ah, just saw 270010 On Wed, May 18, 2016 at 6:49 PM, Sean Silva wrote: > > > On Wed, May 18, 2016 at 6:39 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rsmith >> Date: Wed May 18 20:39:10 2016 >> New Revision: 270009 >> >> URL:

Re: r270009 - Make Sema::getPrintingPolicy less ridiculously expensive. This used to perform

On Wed, May 18, 2016 at 6:39 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Wed May 18 20:39:10 2016 > New Revision: 270009 > > URL: http://llvm.org/viewvc/llvm-project?rev=270009=rev > Log: > Make Sema::getPrintingPolicy less ridiculously

r270016 - Fix PR27601 by reverting [r267453] - Refactor traversal of bases in deduction of template parameters from base

Author: faisalv Date: Wed May 18 21:28:21 2016 New Revision: 270016 URL: http://llvm.org/viewvc/llvm-project?rev=270016=rev Log: Fix PR27601 by reverting [r267453] - Refactor traversal of bases in deduction of template parameters from base This reversal is being done with r267453's author's

Re: [PATCH] D20407: [CodeGen][ObjC] zero-ext an i1 value to i8

rjmccall added a comment. _Atomic is functionally a type qualifier and should be removed in Sema when computing the result type of the getter and the parameter type of the setter. That is, if the user declares a property of type _Atomic(_Bool), we should pretend that the property has type

r270021 - Reapply^3 "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC"

Author: vedantk Date: Wed May 18 22:54:54 2016 New Revision: 270021 URL: http://llvm.org/viewvc/llvm-project?rev=270021=rev Log: Reapply^3 "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC" Sync up with "(llvm) Use Error in InstrProf and Coverage". Modified:

[PATCH] D20407: [CodeGen][ObjC] zero-ext an i1 value to i8

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a subscriber: cfe-commits. This patch fixes an assert that fires when there is a property that has attribute nonatomic and type _Atomic(_Bool). The assert fires when an i1 value is bitcast to i8 (which is the

Re: [PATCH] D7982: Add readability-duplicate-include check to clang-tidy

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Include What You Use detect duplicated include directives. I think will be good idea to use it instead of Clang-tidy for much deeper analysis. http://reviews.llvm.org/D7982

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

I don't think we even need a helper. Clang::ConstructJob takes a `Compilation`, which has a `Driver`, which has a `DiagnosticsEngine`, which has a `DiagnosticsOptions`. In other words, I think you can delete the code in Clang::ConstructJob (change it to a lookup) now that you've changed

Re: [PATCH] D20407: [CodeGen][ObjC] zero-ext an i1 value to i8

ahatanak added a comment. Also, it seems that there are bugs in the way clang handles functions whose return types are atomic. Clang asserts when compiling the following test case: $ cat t1.c _Atomic _Bool b1; _Atomic _Bool foo1() { return b1; } $ clang -std=c11 -o - -S t1.c

r270010 - Revert accidentally-committed test for PR27558 (which currently fails...)

Author: rsmith Date: Wed May 18 20:41:52 2016 New Revision: 270010 URL: http://llvm.org/viewvc/llvm-project?rev=270010=rev Log: Revert accidentally-committed test for PR27558 (which currently fails...) Modified: cfe/trunk/test/SemaCXX/member-pointer.cpp Modified:

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

silvas added a subscriber: silvas. silvas added a comment. I don't see an issue with putthing this as a helper in libBasic. We may need to add a libOption dependency to it but that sounds fine. http://reviews.llvm.org/D20404 ___ cfe-commits

Re: [PATCH] D20341: [CUDA] Enable fusing FP ops for CUDA by default.

hfinkel added a comment. In http://reviews.llvm.org/D20341#432586, @jlebar wrote: > > But people also don't expect IEEE compliance on GPUs > > > Is that true? Yes. > You have a lot more experience with this than I do, but my observation of > nvidia's hardware is that it's moved to add *more*

Re: r266719 - Warn if function or variable cannot be implicitly instantiated

On Thu, Apr 21, 2016 at 12:44 AM, Serge Pavlov wrote: > Let me demonstrate the problem using excerpt from v8 sources: > > -- lithium.h > template > struct LSubKindOperand { > static int* Create(int index) { return

Re: [PATCH] D15089: Patch to google checks in clang-tidy

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please update you patch to current code. Looks like addresses were fixed in files where they existed, but still need to be added to files without them. Repository: rL LLVM http://reviews.llvm.org/D15089

r270009 - Make Sema::getPrintingPolicy less ridiculously expensive. This used to perform

Author: rsmith Date: Wed May 18 20:39:10 2016 New Revision: 270009 URL: http://llvm.org/viewvc/llvm-project?rev=270009=rev Log: Make Sema::getPrintingPolicy less ridiculously expensive. This used to perform an identifier table lookup, *and* copy the LangOptions (including various std::vectors).

Re: [PATCH] D19783: Fix cv-qualification of '*this' captures (and nasty bug PR27507 introduced by commit 263921 "Implement Lambda Capture of *this by Value as [=, *this]")

There are tests from the test file in my patch that don't pass(*) if you just apply Oh's fix . That's not surprising since Oh's patch only meant to fix the crash, but not the 'cv' qualification issue of '*this' that we didn't have to deal with prior to by-value captures of '*this' and my initial

Re: [PATCH] D19783: Fix cv-qualification of '*this' captures (and nasty bug PR27507 introduced by commit 263921 "Implement Lambda Capture of *this by Value as [=, *this]")

faisalv updated this revision to Diff 57733. faisalv marked an inline comment as done. faisalv added a comment. This patch addresses all of Richard's comments - except one (on which I'm awaiting some additional clarity on, before I make any changes). http://reviews.llvm.org/D19783 Files:

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

pcc planned changes to this revision. pcc added a comment. One thing that I forgot to do here was to add a test covering my changes to `CGDebugInfo::EmitGlobalVariable`. I'll do that momentarily. http://reviews.llvm.org/D20415 ___ cfe-commits

Re: [PATCH] D19783: Fix cv-qualification of '*this' captures (and nasty bug PR27507 introduced by commit 263921 "Implement Lambda Capture of *this by Value as [=, *this]")

faisalv marked 5 inline comments as done. faisalv added a comment. OK - agree (and addressed in a forthcoming patch) all your comments - except for the one I could use some clarity on - please see below Comment at: lib/Sema/SemaExprCXX.cpp:910 @@ +909,3 @@ +

[PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

pcc created this revision. pcc added reviewers: dexonsmith, dblaikie, aprantl. pcc added a subscriber: cfe-commits. http://reviews.llvm.org/D20415 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.cpp

Re: [PATCH] D20329: [clang-include-fixer] Added Vim integration for clang-include-fixer.

bkramer added a comment. I expect the insertion code in the python part to cause trouble in the future again but I guess this is fine for now. Can you add a section to include-fixer.rst on how to set this up? http://reviews.llvm.org/D20329 ___

Re: [PATCH] D20325: Add ARM cdp intrinsics

rs marked an inline comment as done. rs added a comment. > It's been our stance for a long time to require docs to approve changes, > however small. I don't want to relax that which I think is a good constraint, > not for such a seemly irrelevant issue. > I also doubt this will be the only

[clang-tools-extra] r269896 - [clang-tidy] Fix a functional change from r269656.

Author: d0k Date: Wed May 18 04:48:46 2016 New Revision: 269896 URL: http://llvm.org/viewvc/llvm-project?rev=269896=rev Log: [clang-tidy] Fix a functional change from r269656. Instead of forming char ranges that patch made us form token ranges, which behave subtly different. Sadly I'm only

Re: [PATCH] D20111: [OpenMP] Adjust map type bits according to latest spec and use zero size array sections for pointers.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4873-4877 @@ -4880,1 +4872,7 @@ +OMP_MAP_IS_PTR = 0x10, +/// \brief This flags signals that an argument is the first one relating to +/// a map/private clause expression. For some cases a

Re: [PATCH] D20362: [clang-format] Make formatReplacements() also sort #includes.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. I am not even certain whether we want to keep a separate sortIncludes in the interface at all, but as this doesn't change the public API, it doesn't hurt.

Re: [PATCH] D20360: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269916: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20360?vs=57600=57605#toc Repository: rL LLVM

[clang-tools-extra] r269918 - [clang-tidy] Fix misc-unused-using-decls test failure in windows

Author: hokein Date: Wed May 18 08:07:13 2016 New Revision: 269918 URL: http://llvm.org/viewvc/llvm-project?rev=269918=rev Log: [clang-tidy] Fix misc-unused-using-decls test failure in windows buildbot. Modified: clang-tools-extra/trunk/test/clang-tidy/misc-unused-using-decls.cpp Modified:

Re: [PATCH] D20198: clang-format: [JS] sort ES6 imports.

klimek added inline comments. Comment at: lib/Format/SortJavaScriptImports.cpp:46-47 @@ +45,4 @@ +// An ES6 module reference. +// +// ES6 implements a module system, where individual modules (~= source files) +// can reference other modules, either importing symbols from them, or

Re: Patch submission for bug 27400

Thank you for the patch! Note, however, that most clang-tidy reviews are done using Phabricator (see llvm.org/docs/Phabricator.html). It's not required, but it makes the reviews much easier (and much easier to keep track of). On Tue, May 17, 2016 at 10:47 PM, Mads Ravn via cfe-commits <

Re: [PATCH] D20360: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr.

hokein updated this revision to Diff 57597. hokein added a comment. Remove modification of dump_ast_matchers.py http://reviews.llvm.org/D20360 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp

Re: [PATCH] D20112: [OpenMP] Add support for the 'private pointer' flag to signal variables captured in target regions and used in first-private clauses.

ABataev added a comment. Please, update to latest revision. I made some changes in firstprivates that may affect your patch. Will review it after it. http://reviews.llvm.org/D20112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r269914 - [Mips] Finetuning MIPS32 Android default variants

Author: petarj Date: Wed May 18 07:46:06 2016 New Revision: 269914 URL: http://llvm.org/viewvc/llvm-project?rev=269914=rev Log: [Mips] Finetuning MIPS32 Android default variants MIPS32 Android defaults to FPXX ("-fpxx"). MIPS32R6 Android defaults to FP64A ("-mfp64 -mno-odd-spreg"). Differential

Re: [PATCH] D20360: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr.

aaron.ballman added a comment. In http://reviews.llvm.org/D20360#432878, @alexfh wrote: > In http://reviews.llvm.org/D20360#432874, @aaron.ballman wrote: > > > The changes to docs/tools/dump_ast_matchers.py look to be spurious, can > > they be reverted? > > > The script should be executable, so

r269910 - Update for llvm change.

Author: rafael Date: Wed May 18 06:58:56 2016 New Revision: 269910 URL: http://llvm.org/viewvc/llvm-project?rev=269910=rev Log: Update for llvm change. Modified: cfe/trunk/lib/Parse/ParseStmtAsm.cpp cfe/trunk/tools/driver/cc1as_main.cpp Modified: cfe/trunk/lib/Parse/ParseStmtAsm.cpp

Re: [PATCH] D20345: [Mips] Finetuning MIPS32 Android default variants

This revision was automatically updated to reflect the committed changes. Closed by commit rL269914: [Mips] Finetuning MIPS32 Android default variants (authored by petarj). Changed prior to commit: http://reviews.llvm.org/D20345?vs=57543=57603#toc Repository: rL LLVM

[clang-tools-extra] r269923 - [include-fixer] Don't insert #includes if a fatal error occurred.

Author: d0k Date: Wed May 18 08:32:38 2016 New Revision: 269923 URL: http://llvm.org/viewvc/llvm-project?rev=269923=rev Log: [include-fixer] Don't insert #includes if a fatal error occurred. This typically happens when the user didn't setup include paths correctly and the fixer starts adding

r269907 - Add new intrinsic support for MONITORX and MWAITX instructions

Author: ashutosh Date: Wed May 18 06:56:23 2016 New Revision: 269907 URL: http://llvm.org/viewvc/llvm-project?rev=269907=rev Log: Add new intrinsic support for MONITORX and MWAITX instructions Summary: MONITORX/MWAITX instructions provide similar capability to the MONITOR/MWAIT pair while adding

Re: [PATCH] D19796: Add new intrinsic support for MONITORX and MWAITX instructions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269907: Add new intrinsic support for MONITORX and MWAITX instructions (authored by Ashutosh). Changed prior to commit: http://reviews.llvm.org/D19796?vs=55788=57593#toc Repository: rL LLVM

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724 @@ +3723,3 @@ + bool Matched = false; + for (const auto *Overridden : Node.overridden_methods()) { +BoundNodesTreeBuilder OverriddenBuilder(*Builder); courbet

Re: [PATCH] D20360: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr.

hokein updated this revision to Diff 57596. hokein marked an inline comment as done. hokein added a comment. Address review comments. http://reviews.llvm.org/D20360 Files: docs/LibASTMatchersReference.html docs/tools/dump_ast_matchers.py include/clang/ASTMatchers/ASTMatchers.h

Re: [PATCH] D20325: Add ARM cdp intrinsics

Hi, To add my oar in, I agree with Tim here. It is regrettable but true that documentation, be that the ARMARM or ACLE tends to lag behind our development. If LLVM wants to be at the leading edge of architecture support (I hope it does!) then patches will just have to be accepted without pointers

r269916 - [ASTMatcher] Add a node matcher for UnresolvedLookupExpr.

Author: hokein Date: Wed May 18 07:53:59 2016 New Revision: 269916 URL: http://llvm.org/viewvc/llvm-project?rev=269916=rev Log: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr. Reviewers: alexfh, aaron.ballman Subscribers: aaron.ballman, klimek, cfe-commits Differential Revision:

r269921 - [X86][SSE3] Sync with llvm/test/CodeGen/X86/sse3-intrinsics-fast-isel.ll

Author: rksimon Date: Wed May 18 08:17:39 2016 New Revision: 269921 URL: http://llvm.org/viewvc/llvm-project?rev=269921=rev Log: [X86][SSE3] Sync with llvm/test/CodeGen/X86/sse3-intrinsics-fast-isel.ll Modified: cfe/trunk/test/CodeGen/sse3-builtins.c Modified:

Re: [PATCH] D20360: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr.

alexfh added a comment. In http://reviews.llvm.org/D20360#432874, @aaron.ballman wrote: > The changes to docs/tools/dump_ast_matchers.py look to be spurious, can they > be reverted? The script should be executable, so the change looks fine to me. http://reviews.llvm.org/D20360

Re: [PATCH] D20360: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr.

hokein updated this revision to Diff 57600. hokein added a comment. Rebase to master. http://reviews.llvm.org/D20360 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTMatchersNodeTest.cpp

Re: [PATCH] D20321: [Clang][AVX512][intrinsics] Fix vperm intrinsics.

m_zuckerman accepted this revision. m_zuckerman added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM http://reviews.llvm.org/D20321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D20362: [clang-format] Make formatReplacements() also sort #includes.

ioeric created this revision. ioeric added reviewers: bkramer, djasper. ioeric added a subscriber: cfe-commits. Herald added a subscriber: klimek. [clang-format] Make formatReplacements() also sort #includes. http://reviews.llvm.org/D20362 Files: lib/Format/Format.cpp

[PATCH] D20365: [PATCH] clang-tidy: Bug 27731 - modernize-pass-by-value suggest using std::move for types that perform copies on move

madsravn created this revision. madsravn added reviewers: alexfh, vsk, djasper, klimek. madsravn added a subscriber: cfe-commits. This is a patch for bug: https://llvm.org/bugs/show_bug.cgi?id=27731 I have excluded types which are trivially copyable from being called with std::move in the

Re: [PATCH] D20326: [clang-tidy] Fix a template function false positive in misc-unused-using-decls check.

hokein updated this revision to Diff 57576. hokein added a comment. Create a node matcher for UnresolvedLookupExpr. http://reviews.llvm.org/D20326 Files: clang-tidy/misc/UnusedUsingDeclsCheck.cpp test/clang-tidy/misc-unused-using-decls.cpp Index:

Re: [clang-tools-extra] r269896 - [clang-tidy] Fix a functional change from r269656.

Thank you for fixing this! On Wed, May 18, 2016 at 11:48 AM, Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Wed May 18 04:48:46 2016 > New Revision: 269896 > > URL: http://llvm.org/viewvc/llvm-project?rev=269896=rev > Log: > [clang-tidy] Fix a

Re: [PATCH] D20326: [clang-tidy] Fix a template function false positive in misc-unused-using-decls check.

hokein marked an inline comment as done. hokein added a comment. http://reviews.llvm.org/D20326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20326: [clang-tidy] Fix a template function false positive in misc-unused-using-decls check.

hokein updated this revision to Diff 57586. hokein marked an inline comment as done. hokein added a comment. Use for-range loop. http://reviews.llvm.org/D20326 Files: clang-tidy/misc/UnusedUsingDeclsCheck.cpp test/clang-tidy/misc-unused-using-decls.cpp Index:

[PATCH] D20360: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr.

hokein created this revision. hokein added a reviewer: alexfh. hokein added a subscriber: cfe-commits. Herald added a subscriber: klimek. http://reviews.llvm.org/D20360 Files: docs/LibASTMatchersReference.html docs/tools/dump_ast_matchers.py include/clang/ASTMatchers/ASTMatchers.h

[clang-tools-extra] r269906 - [clang-tidy] Fix a template function false positive in misc-unused-using-decls check.

Author: hokein Date: Wed May 18 06:49:34 2016 New Revision: 269906 URL: http://llvm.org/viewvc/llvm-project?rev=269906=rev Log: [clang-tidy] Fix a template function false positive in misc-unused-using-decls check. Summary: Ignore warning uninstantiated template function usages. Reviewers:

Re: [PATCH] D20326: [clang-tidy] Fix a template function false positive in misc-unused-using-decls check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269906: [clang-tidy] Fix a template function false positive in misc-unused-using… (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20326?vs=57586=57591#toc Repository: rL LLVM

Re: [PATCH] D20349: Fix a clang bug in lambda capture of 'this'

Thanks for the work here - but this bug is a duplicate of this: https://llvm.org/bugs/show_bug.cgi?id=27507, which unearthed some other subtle bugs with the cv capture of *this by copy. I've submitted a patch for review here: http://reviews.llvm.org/D19783 that addresses both issues - about 2-3

[PATCH] D20359: Convert AVX non-temporal store builtins to LLVM-native IR. This was previously done for SSE builtins.

m_zuckerman created this revision. m_zuckerman added a reviewer: craig.topper. m_zuckerman added subscribers: delena, cfe-commits, AsafBadouh, igorb. http://reviews.llvm.org/D20359 Files: include/llvm/IR/IntrinsicsX86.td lib/Target/X86/X86IntrinsicsInfo.h

[PATCH] D20358: Convert AVX non-temporal store builtins to LLVM-native IR.

m_zuckerman created this revision. m_zuckerman added a reviewer: craig.topper. m_zuckerman added subscribers: delena, cfe-commits. http://reviews.llvm.org/D20358 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/avx512f-builtins.c Index: lib/CodeGen/CGBuiltin.cpp

Re: [PATCH] D20360: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr.

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. The changes to docs/tools/dump_ast_matchers.py look to be spurious, can they be reverted? Comment at: include/clang/ASTMatchers/ASTMatchers.h:1089 @@

Re: [PATCH] D20326: [clang-tidy] Fix a template function false positive in misc-unused-using-decls check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:95 @@ +94,3 @@ + if (auto *ULE = Result.Nodes.getNodeAs("used")) { +for (auto I = ULE->decls_begin(), E =

Re: [PATCH] D20326: [clang-tidy] Fix a template function false positive in misc-unused-using-decls check.

hokein marked an inline comment as done. Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:24 @@ +23,3 @@ +// FIXME: Add a node matcher for UnresolvedLookupExpr in ASTMatcher. +AST_MATCHER(CallExpr, hasUnresolvedLookupExpr) { + return isa(Node.getCallee());

Re: [PATCH] D19804: Make clang-format cleaner remove redundant commas in list and redundant colon in constructor initializer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269888: Make clang-format cleaner remove redundant commas in list and redundant colon… (authored by ioeric). Changed prior to commit: http://reviews.llvm.org/D19804?vs=57146=57570#toc Repository: rL

r269888 - Make clang-format cleaner remove redundant commas in list and redundant colon in constructor initializer.

Author: ioeric Date: Wed May 18 03:02:56 2016 New Revision: 269888 URL: http://llvm.org/viewvc/llvm-project?rev=269888=rev Log: Make clang-format cleaner remove redundant commas in list and redundant colon in constructor initializer. Summary: Make clang-format cleaner remove redundant

Re: [PATCH] D20171: Support for MSVS default calling convention options (/Gd, /Gz, /Gv, /Gr)

This revision was automatically updated to reflect the committed changes. Closed by commit rL269891: Support for MSVS default calling convention options (/Gd, /Gz, /Gv, (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D20171?vs=57344=57579#toc Repository: rL LLVM

Re: [PATCH] D20326: [clang-tidy] Fix a template function false positive in misc-unused-using-decls check.

hokein updated this revision to Diff 57569. hokein marked an inline comment as done. hokein added a comment. Make a node matcher for unresolvedLookupExpr type. http://reviews.llvm.org/D20326 Files: clang-tidy/misc/UnusedUsingDeclsCheck.cpp test/clang-tidy/misc-unused-using-decls.cpp

Re: [PATCH] D20326: [clang-tidy] Fix a template function false positive in misc-unused-using-decls check.

hokein marked an inline comment as done. Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:24 @@ +23,3 @@ +// FIXME: Move this node matcher to ASTMatcher. +AST_MATCHER(Stmt, unresolvedLookupExpr) { + return isa(Node); alexfh wrote: > That's because we need a

Re: [PATCH] D20354: [include-fixer] Ignore non-scoped enum declaration during search.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Comment at: include-fixer/SymbolIndexManager.cpp:45 @@ +44,3 @@ + while (IdentiferContext != Names.rend() && + SymbolContext !=

Re: [PATCH] D20325: Add ARM cdp intrinsics

On 18 May 2016 at 03:45, Tim Northover via cfe-commits wrote: > Well yes, it's probably got orders of magnitude less bugs than the > backend for a start. :D > Generally we're far more relaxed as long as a specification is on the > way. We're up to to v8.2 in LLVM

Re: [PATCH] D20325: Add ARM cdp intrinsics

rengolin added a comment. Thanks Ranjeet, The tests don't really need the new builtin to exist at all and can be added now. When you submit the __arm_cdp patch, you just need to make sure Clang generates a call to @llvm.arm.cdp and everything else will be covered. cheers, --renato

  1   2   >