[PATCH] D20871: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and _mm512_setzero_epi32

m_zuckerman created this revision. m_zuckerman added reviewers: AsafBadouh, igorb, delena. m_zuckerman added a subscriber: cfe-commits. http://reviews.llvm.org/D20871 Files: lib/Headers/avx512fintrin.h Index: lib/Headers/avx512fintrin.h

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 marked 5 inline comments as done. rogfer01 added a comment. http://reviews.llvm.org/D20561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16545: [libcxxabi] Enable testing for static libc++abi

rmaprath added a comment. Works great. Thanks! http://reviews.llvm.org/D16545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20447: [OpenCL] Fixup extension list

Anastasia added inline comments. Comment at: test/SemaOpenCL/extension-version.cl:73 @@ +72,3 @@ + +#endif + jvesely wrote: > Anastasia wrote: > > Could you put a comment to make it more readable, something like > > > > #endif // (__OPENCL_C_VERSION__ < 110) >

r271409 - ObjC lifetime: pull sugar off when the qualifiers conflict.

Author: mren Date: Wed Jun 1 12:14:19 2016 New Revision: 271409 URL: http://llvm.org/viewvc/llvm-project?rev=271409=rev Log: ObjC lifetime: pull sugar off when the qualifiers conflict. It's possible to have multiple local ObjCLifetime qualifiers. When there is a conflict, we can't stop after we

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Eugene.Zelenko added a comment. There is a way to tell IWYU about compound headers with pragmas . I also suggested to make this possible via file with compound headers list. But person who knows

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

bruno added inline comments. Comment at: test/PCH/include-timestamp.cpp:5 @@ +4,3 @@ +// Check timestamp is included by default. +// RUN: %clang_cc1 -x c++-header -emit-pch -o %t %S/Inputs/include-timestamp-pch.h +// RUN: touch %S/Inputs/include-timestamp.h Can

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 marked 2 inline comments as done. rogfer01 added a comment. Well, the assignment-vs-comparison warning does emit a fix-it in `Sema::DiagnoseAssignmentAsCondition(Expr *E)` Diag(Loc, diag::note_condition_assign_silence) << FixItHint::CreateInsertion(Open, "(") <<

[PATCH] D20870: [Clang][AVX512][INTRINSICS] adding round cvt and fix regular cvtps_ph

m_zuckerman created this revision. m_zuckerman added reviewers: AsafBadouh, igorb, delena. m_zuckerman added a subscriber: cfe-commits. http://reviews.llvm.org/D20870 Files: lib/Headers/avx512vlintrin.h test/CodeGen/avx512vl-builtins.c Index: test/CodeGen/avx512vl-builtins.c

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

Anastasia added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:1782 @@ -1773,2 +1781,3 @@ Opts.RTTIData = Opts.RTTI && !Args.hasArg(OPT_fno_rtti_data); - Opts.Blocks = Args.hasArg(OPT_fblocks); + Opts.Blocks = Args.hasArg(OPT_fblocks) || (Opts.OpenCL +

Re: [PATCH] D20447: [OpenCL] Fixup extension list

jvesely marked 2 inline comments as done. Comment at: test/SemaOpenCL/extension-version.cl:73 @@ +72,3 @@ + +#endif + Anastasia wrote: > Could you put a comment to make it more readable, something like > > #endif // (__OPENCL_C_VERSION__ < 110) These large

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 added a comment. I think I wasn't clear with the purpose of the fix-it: there are a few cases where getting the address of an unaligned pointer is safe (i.e. false positives). For instance, when I checked Firefox and Chromium there are cases where getting the address of an unaligned

Re: [PATCH] D20447: [OpenCL] Fixup extension list

jvesely updated this revision to Diff 59240. jvesely added a comment. Fix typo: COre -> Core Repository: rL LLVM http://reviews.llvm.org/D20447 Files: include/clang/Basic/OpenCLExtensions.def test/SemaOpenCL/extension-version.cl Index: test/SemaOpenCL/extension-version.cl

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 updated this revision to Diff 59241. rogfer01 added a comment. This change adds a fix-it suggesting parentheses to silence the warning. http://reviews.llvm.org/D20561 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp test/Sema/address-packed.c

Re: [PATCH] D20447: [OpenCL] Fixup extension list

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rL LLVM http://reviews.llvm.org/D20447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [Diffusion] rL249410: [Tooling] Reuse FileManager in ASTUnit.

cameron314 added a subscriber: cfe-commits. http://reviews.llvm.org/rL249410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20886: [libcxxabi] Allow target flags to affect configuration tests.

EricWF created this revision. EricWF added reviewers: danalbert, jroelofs, bcraig, compnerd. EricWF added a subscriber: cfe-commits. This patch changes the libc++abi CMake so that it adds certain target flags like '-m32' or '--gcc-toolchain' before including `config-ix.cmake`. Since these flags

Re: [PATCH] D20844: FixIt: use getLocForEndOfToken to insert fix-it after a type name.

rjmccall added a comment. LGTM. http://reviews.llvm.org/D20844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20889: [libunwind] Allow target flags to affect CMake configuration tests

EricWF created this revision. EricWF added reviewers: jroelofs, danalbert, compnerd, bcraig, rmaprath. EricWF added a subscriber: cfe-commits. This patch changes the libunwind CMake so that it adds certain target flags like '-m32' or '--gcc-toolchain' before including config-ix.cmake. Since

Re: [PATCH] D20844: FixIt: use getLocForEndOfToken to insert fix-it after a type name.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271448: FixIt: use getLocForEndOfToken to insert fix-it after a type name. (authored by mren). Changed prior to commit: http://reviews.llvm.org/D20844?vs=59296=59315#toc Repository: rL LLVM

[libcxx] r271449 - Implement P0033R1 - Re-enabling shared_from_this

Author: ericwf Date: Wed Jun 1 19:15:35 2016 New Revision: 271449 URL: http://llvm.org/viewvc/llvm-project?rev=271449=rev Log: Implement P0033R1 - Re-enabling shared_from_this Summary: See http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0033r1.html Reviewers: mclow.lists

Re: [PATCH] D19254: Implement P0033R1 - Re-enabling shared_from_this

This revision was automatically updated to reflect the committed changes. Closed by commit rL271449: Implement P0033R1 - Re-enabling shared_from_this (authored by EricWF). Changed prior to commit: http://reviews.llvm.org/D19254?vs=54150=59316#toc Repository: rL LLVM

r271451 - [asan] Added -fsanitize-address-use-after-scope flag

Author: vitalybuka Date: Wed Jun 1 19:24:20 2016 New Revision: 271451 URL: http://llvm.org/viewvc/llvm-project?rev=271451=rev Log: [asan] Added -fsanitize-address-use-after-scope flag Summary: Also emit lifetime markers for -fsanitize-address-use-after-scope. Asan uses life-time markers for

Re: [PATCH] D20887: [libcxx] Allow target flags to affect CMake configuration tests

compnerd requested changes to this revision. This revision now requires changes to proceed. Comment at: CMakeLists.txt:259 @@ +258,3 @@ +add_target_flags_if(LIBCXX_TARGET_TRIPLE "-target ${LIBCXX_TARGET_TRIPLE}") +add_target_flags_if(LIBCXX_SYSROOT "--sysroot ${LIBCXX_SYSROOT}")

Re: [PATCH] D20715: [docs] Document the source-based code coverage feature

> On Jun 1, 2016, at 11:30 AM, Justin Bogner wrote: > > Vedant Kumar writes: >> vsk created this revision. >> vsk added a reviewer: bogner. >> vsk added subscribers: kcc, cfe-commits, silvas. >> >> It would be helpful to have a user-friendly guide for

r271454 - [docs] Document the source-based code coverage feature

Author: vedantk Date: Wed Jun 1 19:51:50 2016 New Revision: 271454 URL: http://llvm.org/viewvc/llvm-project?rev=271454=rev Log: [docs] Document the source-based code coverage feature Differential Revision: http://reviews.llvm.org/D20715 Added: cfe/trunk/docs/SourceBasedCodeCoverage.rst

Re: [PATCH] D20715: [docs] Document the source-based code coverage feature

This revision was automatically updated to reflect the committed changes. Closed by commit rL271454: [docs] Document the source-based code coverage feature (authored by vedantk). Changed prior to commit: http://reviews.llvm.org/D20715?vs=59078=59322#toc Repository: rL LLVM

Re: [PATCH] D20799: Add C++17 std::not_fn negator.

EricWF updated this revision to Diff 59324. EricWF added a comment. - Make not_fn call operator conditionally noexcept. - Make 'std::invoke' conditionally noexcept as well. http://reviews.llvm.org/D20799 Files: include/functional

Re: [PATCH] D20887: [libcxx] Allow target flags to affect CMake configuration tests

EricWF updated this revision to Diff 59325. EricWF added a comment. Address review comments. Add "=" sign in sysroot. http://reviews.llvm.org/D20887 Files: CMakeLists.txt cmake/Modules/HandleLibcxxFlags.cmake Index: cmake/Modules/HandleLibcxxFlags.cmake

[libunwind] r271458 - [libunwind] Allow target flags to affect CMake configuration tests

Author: ericwf Date: Wed Jun 1 20:02:10 2016 New Revision: 271458 URL: http://llvm.org/viewvc/llvm-project?rev=271458=rev Log: [libunwind] Allow target flags to affect CMake configuration tests Summary: This patch changes the libunwind CMake so that it adds certain target flags like '-m32' or

r271457 - [docs] Add missing newline to console section

Author: vedantk Date: Wed Jun 1 20:01:48 2016 New Revision: 271457 URL: http://llvm.org/viewvc/llvm-project?rev=271457=rev Log: [docs] Add missing newline to console section Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst URL:

[libcxx] r271459 - Remove enable_shared_from_this test since it leaks the control block and fails with ASAN

Author: ericwf Date: Wed Jun 1 20:09:12 2016 New Revision: 271459 URL: http://llvm.org/viewvc/llvm-project?rev=271459=rev Log: Remove enable_shared_from_this test since it leaks the control block and fails with ASAN Modified:

[libcxx] r271460 - [libcxx] Allow target flags to affect CMake configuration tests

Author: ericwf Date: Wed Jun 1 20:10:08 2016 New Revision: 271460 URL: http://llvm.org/viewvc/llvm-project?rev=271460=rev Log: [libcxx] Allow target flags to affect CMake configuration tests Summary: This patch changes the libc++ CMake so that it adds certain target flags like '-m32' or

Re: [PATCH] D20886: [libcxxabi] Allow target flags to affect configuration tests.

EricWF added inline comments. Comment at: CMakeLists.txt:201 @@ +200,3 @@ + message(FATAL_ERROR "LIBCXXABI_BUILD_32_BITS=ON is not supported on this platform.") +endif() + compnerd wrote: > Why not handle this like libunwind? Alternative, we could duplicate

r271461 - [docs] Use cpp code-blocks where appropriate

Author: vedantk Date: Wed Jun 1 20:15:59 2016 New Revision: 271461 URL: http://llvm.org/viewvc/llvm-project?rev=271461=rev Log: [docs] Use cpp code-blocks where appropriate Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst URL:

[libunwind] r271462 - Add status/warning message for 32 bit builds

Author: ericwf Date: Wed Jun 1 20:19:52 2016 New Revision: 271462 URL: http://llvm.org/viewvc/llvm-project?rev=271462=rev Log: Add status/warning message for 32 bit builds Modified: libunwind/trunk/CMakeLists.txt Modified: libunwind/trunk/CMakeLists.txt URL:

Re: [PATCH] D20886: [libcxxabi] Allow target flags to affect configuration tests.

EricWF added inline comments. Comment at: CMakeLists.txt:201 @@ +200,3 @@ + message(FATAL_ERROR "LIBCXXABI_BUILD_32_BITS=ON is not supported on this platform.") +endif() + Done in r271462. http://reviews.llvm.org/D20886

Re: [clang-tools-extra] r261991 - [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

On Wed, Jun 01, 2016 at 11:19:44PM +0200, Edoardo P. wrote: > Ping. > > Deadline to merge the changes to the 3.8 branch is today. > I will make sure to merge this before -rc1. Thanks for reminding me. -Tom > Cheers, > Edward-san > > 2016-05-24 20:25 GMT+02:00 Edoardo P.

[libcxx] r271464 - Add C++17 std::not_fn negator.

Author: ericwf Date: Wed Jun 1 20:25:41 2016 New Revision: 271464 URL: http://llvm.org/viewvc/llvm-project?rev=271464=rev Log: Add C++17 std::not_fn negator. Summary: Exactly what it sounds like. I plan to commit this in a couple of days assuming no objections. Reviewers: mclow.lists, EricWF

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Eugene.Zelenko added a comment. See https://github.com/include-what-you-use/include-what-you-use/issues/292 and https://github.com/include-what-you-use/include-what-you-use/issues/301. Repository: rL LLVM http://reviews.llvm.org/D20714 ___

Re: [PATCH] D19254: Implement P0033R1 - Re-enabling shared_from_this

mclow.lists added a comment. Other than the versioning, this looks fine to me. Comment at: include/memory:5439 @@ -5438,1 +5438,3 @@ +_LIBCPP_INLINE_VISIBILITY +weak_ptr<_Tp> weak_from_this() _NOEXCEPT Shouldn't these be wrapped in `#ifdef _LIBCPP_VER

Re: [PATCH] D20715: [docs] Document the source-based code coverage feature

Vedant Kumar writes: > vsk created this revision. > vsk added a reviewer: bogner. > vsk added subscribers: kcc, cfe-commits, silvas. > > It would be helpful to have a user-friendly guide for code > coverage. There is some overlap with [1], but this document visits > issues which

Re: [PATCH] D20561: Warn when taking address of packed member

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. In http://reviews.llvm.org/D20561#445824, @rogfer01 wrote: > I think I wasn't clear with the purpose of the fix-it: there are a few cases > where getting the address

r271414 - Disable warning about core features by default

Author: jvesely Date: Wed Jun 1 13:04:53 2016 New Revision: 271414 URL: http://llvm.org/viewvc/llvm-project?rev=271414=rev Log: Disable warning about core features by default Reviewers: Anastasia, yaxunl Differential Revision: http://reviews.llvm.org/D20744 Modified:

r271413 - Fixup list of available extensions

Author: jvesely Date: Wed Jun 1 13:04:50 2016 New Revision: 271413 URL: http://llvm.org/viewvc/llvm-project?rev=271413=rev Log: Fixup list of available extensions Reviewers: Anastasia Differential Revision: http://reviews.llvm.org/D20447 Added:

Re: [PATCH] D20447: [OpenCL] Fixup extension list

This revision was automatically updated to reflect the committed changes. jvesely marked 5 inline comments as done. Closed by commit rL271413: Fixup list of available extensions (authored by jvesely). Changed prior to commit: http://reviews.llvm.org/D20447?vs=59240=59254#toc Repository: rL

Re: [PATCH] D20744: [OpenCL] Disable warning about core features by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL271414: Disable warning about core features by default (authored by jvesely). Changed prior to commit: http://reviews.llvm.org/D20744?vs=59079=59255#toc Repository: rL LLVM

Re: r271336 - [CUDA] Conservatively mark inline asm as convergent.

On Tue, May 31, 2016 at 09:27:13PM -, Justin Lebar via cfe-commits wrote: > Author: jlebar > Date: Tue May 31 16:27:13 2016 > New Revision: 271336 > > URL: http://llvm.org/viewvc/llvm-project?rev=271336=rev > Log: > [CUDA] Conservatively mark inline asm as convergent. > > Summary: > This is

[PATCH] D20874: [libcxx] Two more threading dependencies

rmaprath created this revision. rmaprath added reviewers: EricWF, bcraig, mclow.lists. rmaprath added a subscriber: cfe-commits. Bumped into these while working on the externally threaded variant. I think it makes most sense to group these two under the main threading API. This greatly

[libcxxabi] r271423 - [libcxxabi][test] Add missing return statement.

Author: asiri Date: Wed Jun 1 14:13:53 2016 New Revision: 271423 URL: http://llvm.org/viewvc/llvm-project?rev=271423=rev Log: [libcxxabi][test] Add missing return statement. This causes a test failure when running with -Werror=return-type. NFC. Modified:

Re: r271336 - [CUDA] Conservatively mark inline asm as convergent.

Thank you, Tom. I will have a look. On Wed, Jun 1, 2016 at 11:22 AM, Tom Stellard wrote: > On Tue, May 31, 2016 at 09:27:13PM -, Justin Lebar via cfe-commits wrote: >> Author: jlebar >> Date: Tue May 31 16:27:13 2016 >> New Revision: 271336 >> >> URL:

Re: [PATCH] D20874: [libcxx] Two more threading dependencies

bcraig added inline comments. Comment at: include/__threading_support:187 @@ +186,3 @@ +{ +std::terminate(); +} Why does this need to go in threading_support? Seems like this is mostly orthogonal to threading. libcxxabi seems like the better place to hold

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

etienneb added a comment. In http://reviews.llvm.org/D20714#445911, @Eugene.Zelenko wrote: > There is a way to tell IWYU about compound headers with pragmas > . > I also suggested to make this

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

pcc updated this revision to Diff 59260. pcc marked 2 inline comments as done. pcc added a comment. - Address review comments http://reviews.llvm.org/D20415 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.cpp

Re: [PATCH] D20844: FixIt: correctly set DeclSpec's range end for a type name annotation.

manmanren added a comment. In http://reviews.llvm.org/D20844#445762, @rjmccall wrote: > Hmm. No, I think the original code is correct here — RangeEnd is a token > range, and those are generally inclusive rather than exclusive. The fix-it > needs to be inserting at the end of the token. We

Re: [PATCH] D20844: FixIt: correctly set DeclSpec's range end for a type name annotation.

On Wed, Jun 1, 2016 at 12:42 PM, Manman Ren via cfe-commits < cfe-commits@lists.llvm.org> wrote: > manmanren added a comment. > > In http://reviews.llvm.org/D20844#445762, @rjmccall wrote: > > > Hmm. No, I think the original code is correct here — RangeEnd is a > token range, and those are

Re: [PATCH] D16948: [libcxx] Filesystem TS -- Complete

EricWF marked an inline comment as done. Comment at: src/experimental/operations.cpp:128-129 @@ +127,4 @@ +bool stat_equivalent(struct ::stat& st1, struct ::stat& st2) { +return (st1.st_dev == st2.st_dev && st1.st_ino == st2.st_ino); +} + majnemer wrote: > It

[clang-tools-extra] r271426 - Fix uninitialized memory access when the token 'const' is not present in

Author: sbenza Date: Wed Jun 1 15:37:23 2016 New Revision: 271426 URL: http://llvm.org/viewvc/llvm-project?rev=271426=rev Log: Fix uninitialized memory access when the token 'const' is not present in the program. If the token is not there, we still warn but we don't try to give a fixit hint.

Re: [PATCH] D20871: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and _mm512_setzero_epi32

delena added a comment. Why do you need them. Is it a part of API? http://reviews.llvm.org/D20871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

sepavloff added inline comments. Comment at: lib/AST/ASTImporter.cpp:2373 @@ +2372,3 @@ + Error = true; +ToInfo = TemplateArgumentLocInfo(TSI); + } else { Maybe `else` before this statement so that in the case of error `ToInfo` remained default

Re: r271387 - Adding front-end support to several intrinsics (bit scanning, conversion and state reading intrinsics)

Please implement _bit_scan_forward and _bit_scan_reverse in terms of __builtin_ctz and __builtin_clz. On Wed, Jun 1, 2016 at 5:21 AM, Michael Zuckerman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: mzuckerm > Date: Wed Jun 1 07:21:00 2016 > New Revision: 271387 > > URL:

Re: [PATCH] D20857: [clang-tidy] Add modernize-explicit-operator-bool check.

etienneb added a comment. I wonder if these two checks should not be merge in one checker. modernize-explicit-conversion-operator Comment at: clang-tidy/modernize/ExplicitOperatorBoolCheck.cpp:21 @@ +20,3 @@ +void ExplicitOperatorBoolCheck::registerMatchers(MatchFinder

Re: [PATCH] D17462: Fix a codegen bug for variadic functions with pass_object_size params

george.burgess.iv added a comment. Ping :) http://reviews.llvm.org/D17462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r271427 - [driver][arm] add armv7 and thumb include and lib paths

Author: chh Date: Wed Jun 1 15:48:46 2016 New Revision: 271427 URL: http://llvm.org/viewvc/llvm-project?rev=271427=rev Log: [driver][arm] add armv7 and thumb include and lib paths Add a new test android-ndk-standalone.cpp with new Android NDK release tree structure. Detect armv7 sub

Re: [PATCH] D20843: ObjC lifetime: pull sugar off when the qualifiers conflict.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271409: ObjC lifetime: pull sugar off when the qualifiers conflict. (authored by mren). Changed prior to commit: http://reviews.llvm.org/D20843?vs=59149=59249#toc Repository: rL LLVM

Re: [PATCH] D20358: [Clang][AVX512][Intrinsics]Convert AVX non-temporal store builtins to LLVM-native IR.

ab added a comment. In http://reviews.llvm.org/D20358#446218, @ab wrote: > In http://reviews.llvm.org/D20358#446210, @RKSimon wrote: > > > Is there any reason why we can't just get rid of all the SSE movnt builtins > > and use __builtin_nontemporal_store instead > >

[PATCH] D20881: [libunwind] Add LIBUNWIND_BUILD_32_BITS CMake option.

EricWF created this revision. EricWF added reviewers: rmaprath, compnerd, jroelofs. EricWF added a subscriber: cfe-commits. This option defaults to LLVM_BUILD_32_BITS but it allows it to be modified separate from the rest of LLVM. This is intended to help fix PR27959.

Re: [PATCH] D20358: [Clang][AVX512][Intrinsics]Convert AVX non-temporal store builtins to LLVM-native IR.

RKSimon added a comment. In http://reviews.llvm.org/D20358#446220, @ab wrote: > In http://reviews.llvm.org/D20358#446218, @ab wrote: > > > In http://reviews.llvm.org/D20358#446210, @RKSimon wrote: > > > > > Is there any reason why we can't just get rid of all the SSE movnt > > > builtins and

[PATCH] D20883: [cmake] Fix builds with LLVM_ENABLE_PIC=0

labath created this revision. labath added a reviewer: beanz. labath added a subscriber: cfe-commits. When this flag is specified, the target llvm-lto is not built, but is still used as a dependency of the test targets. cmake 2.8 silently ignored this situation, but with

Re: [PATCH] D20709: Support ARM subtarget feature +long64

pirama updated this revision to Diff 59294. pirama removed a reviewer: rsmith. pirama added a comment. Herald added subscribers: danalbert, tberghammer. Add a RenderScript langopt and updated to change long's size and alignment in TargetInfo::adjust(). http://reviews.llvm.org/D20709 Files:

Re: [PATCH] D20844: FixIt: use getLocForEndOfToken to insert fix-it after a type name.

manmanren retitled this revision from "FixIt: correctly set DeclSpec's range end for a type name annotation." to "FixIt: use getLocForEndOfToken to insert fix-it after a type name.". manmanren updated the summary for this revision. manmanren updated this revision to Diff 59296. manmanren added a

Re: [PATCH] D20358: [Clang][AVX512][Intrinsics]Convert AVX non-temporal store builtins to LLVM-native IR.

RKSimon added a subscriber: RKSimon. RKSimon added a comment. Is there any reason why we can't just get rid of all the SSE movnt builtins and use __builtin_nontemporal_store instead (http://reviews.llvm.org/D12313)? http://reviews.llvm.org/D20358

Re: [PATCH] D20358: [Clang][AVX512][Intrinsics]Convert AVX non-temporal store builtins to LLVM-native IR.

ab added a subscriber: ab. ab added a comment. In http://reviews.llvm.org/D20358#446210, @RKSimon wrote: > Is there any reason why we can't just get rid of all the SSE movnt builtins > and use __builtin_nontemporal_store instead (http://reviews.llvm.org/D12313)? I wanted to suggest that too,

Re: [PATCH] D20709: Support ARM subtarget feature +long64

pirama added a reviewer: rsmith. pirama added a comment. Adding Richard to reviewers as the planned direction of this patch directly relates to the Frontend. http://reviews.llvm.org/D20709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20844: FixIt: correctly set DeclSpec's range end for a type name annotation.

> On Jun 1, 2016, at 1:18 PM, Richard Smith via cfe-commits > wrote: > > On Wed, Jun 1, 2016 at 12:42 PM, Manman Ren via cfe-commits > > wrote: > manmanren added a comment. > > In

Re: [PATCH] D20709: Support ARM subtarget feature +long64

rsmith added a subscriber: rsmith. rsmith added a comment. The summary and content of this patch are very different. If you have an ABI variant that any language should be able to target, that should be controlled by the triple and related flags, not by a RenderScript language option. If you

r271438 - [driver][arm] change regular expression to work on Windows

Author: chh Date: Wed Jun 1 17:53:59 2016 New Revision: 271438 URL: http://llvm.org/viewvc/llvm-project?rev=271438=rev Log: [driver][arm] change regular expression to work on Windows Differential Revision: http://reviews.llvm.org/D20600 Modified:

Re: [libcxx] r271459 - Remove enable_shared_from_this test since it leaks the control block and fails with ASAN

No the leak was my fault. The sneaky line was "std::shared_ptr s(ptr, );", which caused the allocation of a shared control block. Since the deleter is a NOP it gets leaked and ASAN reports it. I'm going to follow up with a better test that ASAN doesn't complain about. On Wed, Jun 1, 2016 at 7:49

[libcxx] r271469 - Update libcxx.llvm.org documentation by linking to new docs.

Author: ericwf Date: Wed Jun 1 21:16:28 2016 New Revision: 271469 URL: http://llvm.org/viewvc/llvm-project?rev=271469=rev Log: Update libcxx.llvm.org documentation by linking to new docs. Summary: Currently much of the libcxx website is duplicated between the old www/ documentation and newer

r271471 - [docs] Minor formatting changes and typo fixes

Author: vedantk Date: Wed Jun 1 21:25:13 2016 New Revision: 271471 URL: http://llvm.org/viewvc/llvm-project?rev=271471=rev Log: [docs] Minor formatting changes and typo fixes Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst URL:

[libcxx] r271473 - Mark LWG issue 2450 as complete.

Author: ericwf Date: Wed Jun 1 22:12:44 2016 New Revision: 271473 URL: http://llvm.org/viewvc/llvm-project?rev=271473=rev Log: Mark LWG issue 2450 as complete. Added: libcxx/trunk/test/std/utilities/function.objects/comparisons/pointer_comparison_test_helper.hpp Modified:

[libunwind] r271466 - Attempt to fix libunwind build

Author: ericwf Date: Wed Jun 1 20:50:10 2016 New Revision: 271466 URL: http://llvm.org/viewvc/llvm-project?rev=271466=rev Log: Attempt to fix libunwind build Modified: libunwind/trunk/src/CMakeLists.txt Modified: libunwind/trunk/src/CMakeLists.txt URL:

Re: [libcxx] r271459 - Remove enable_shared_from_this test since it leaks the control block and fails with ASAN

I don't get it. If this code doesn't pass ASAN, or if it leaks anything, doesn't that indicate a bug in the library implementation of C++1z shared_ptr? I can't find where this code does anything sneaky that a sanitizer ought to care about... On Jun 1, 2016 6:15 PM, "Eric Fiselier via cfe-commits"

Re: [PATCH] D20389: NVPTX: Add supported CL features

jvesely added inline comments. Comment at: test/Misc/nvptx.languageOptsOpenCL.cl:1 @@ +1,2 @@ +// REQUIRES: nvptx-registered-target +// RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple nvptx-unknown-unknown Anastasia wrote: > Should we check for errors on

Re: [PATCH] D20660: Remove `auto_ptr` in C++17.

EricWF added a comment. REQUIRES-ANY landed in r271468. http://reviews.llvm.org/D20660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19250: Update libcxx.llvm.org documentation by linking to new docs.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D19250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxxabi] r271470 - [libcxxabi] Allow target flags to affect configuration tests.

Author: ericwf Date: Wed Jun 1 21:18:31 2016 New Revision: 271470 URL: http://llvm.org/viewvc/llvm-project?rev=271470=rev Log: [libcxxabi] Allow target flags to affect configuration tests. Summary: This patch changes the libc++abi CMake so that it adds certain target flags like '-m32' or

r271472 - [docs] Fix misplaced comma

Author: vedantk Date: Wed Jun 1 21:45:59 2016 New Revision: 271472 URL: http://llvm.org/viewvc/llvm-project?rev=271472=rev Log: [docs] Fix misplaced comma Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst URL:

[PATCH] D20878: [Coverage] Do not push a new region after a CXXTryStmt

vsk created this revision. vsk added reviewers: bogner, MaggieYi, phillip.power. vsk added a subscriber: cfe-commits. There are three possible scenarios when entering a CXXTryStmt: 1. No exceptions thrown. 2. An exception is thrown but caught by one of the handlers. 3. An exception is

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

sbarzowski updated this revision to Diff 59277. sbarzowski added a comment. Thanks for review, guys. I fixed as many easy problems as I had time for today, will continue later. Repository: rL LLVM http://reviews.llvm.org/D19201 Files: clang-tidy/misc/CMakeLists.txt

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

sbarzowski marked 11 inline comments as done. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:33 @@ +32,3 @@ +// token including trailing whitespace. +static SourceRange findToken(const SourceManager , LangOptions LangOpts, + SourceLocation

Re: [PATCH] D20859: [X86][SSE] Replace (V)CVTTPS2DQ and VCVTTPD2DQ truncating (round to zero) f32/f64 to i32 with generic IR (clang)

This revision was automatically updated to reflect the committed changes. Closed by commit rL271436: [X86][SSE] Replace (V)CVTTPS2DQ and VCVTTPD2DQ truncating (round to zero)… (authored by RKSimon). Changed prior to commit: http://reviews.llvm.org/D20859?vs=59204=59284#toc Repository: rL

Re: [PATCH] D20871: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and _mm512_setzero_epi32

RKSimon added a subscriber: RKSimon. RKSimon added a comment. Tests? http://reviews.llvm.org/D20871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r271430 - Cleanup non-standard tests as reported by s...@microsoft.com. NFC.

Author: ericwf Date: Wed Jun 1 16:05:53 2016 New Revision: 271430 URL: http://llvm.org/viewvc/llvm-project?rev=271430=rev Log: Cleanup non-standard tests as reported by s...@microsoft.com. NFC. This patch addresses the following issues in the test suite: 1. Move "std::bad_array_length" test

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Prazek added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:25 @@ +24,3 @@ + Finder->addMatcher( + cxxThrowExpr(stmt(hasAncestor(functionDecl(isNoThrow()).bind("func" + .bind("throw"), aaron.ballman wrote: > Prazek

r271436 - [X86][SSE] Replace (V)CVTTPS2DQ and VCVTTPD2DQ truncating (round to zero) f32/f64 to i32 with generic IR (clang)

Author: rksimon Date: Wed Jun 1 16:46:51 2016 New Revision: 271436 URL: http://llvm.org/viewvc/llvm-project?rev=271436=rev Log: [X86][SSE] Replace (V)CVTTPS2DQ and VCVTTPD2DQ truncating (round to zero) f32/f64 to i32 with generic IR (clang) The 'cvtt' truncation (round to zero) conversions can

[PATCH] D20880: [Coverage] Push a region and propagate counts through try blocks

vsk created this revision. vsk added reviewers: ikudrin, bogner, MaggieYi, phillip.power. vsk added a subscriber: cfe-commits. This lets us handle expansions in the try block properly. Here's how the final report changes: ``` Before: | 16|// CHECK: Z3fn3v: 1| 17|void fn3() TRY

Re: [clang-tools-extra] r261991 - [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

Ping. Deadline to merge the changes to the 3.8 branch is today. Cheers, Edward-san 2016-05-24 20:25 GMT+02:00 Edoardo P. : > Ping, > > who's going to merge? I have no commit access. > > Cheers, > Edward-san > > > 2016-05-20 18:34 GMT+02:00 Tom Stellard

r271431 - [Sema] Fix incorrect enum token namespace

Author: etienneb Date: Wed Jun 1 16:17:32 2016 New Revision: 271431 URL: http://llvm.org/viewvc/llvm-project?rev=271431=rev Log: [Sema] Fix incorrect enum token namespace Summary: This patch fix the scoping of enum literal. They were not resolving to the right type. It was not causing any

[PATCH] D20887: [libcxx] Allow target flags to affect CMake configuration tests

EricWF created this revision. EricWF added reviewers: danalbert, jroelofs, bcraig, compnerd. EricWF added a subscriber: cfe-commits. This patch changes the libc++ CMake so that it adds certain target flags like '-m32' or '--gcc-toolchain' before including config-ix.cmake. Since these flags can

  1   2   >