Re: [PATCH] D20467: [include-fixer] Mention more details in the document.

hokein updated this revision to Diff 59838. hokein added a comment. Fix typo. http://reviews.llvm.org/D20467 Files: docs/ReleaseNotes.rst docs/include-fixer.rst Index: docs/include-fixer.rst === --- docs/include-fixer.rst +++

[PATCH] D21058: [Clang][AVX512][BUILTIN]Adding missing intrinsics srl and sll

m_zuckerman created this revision. m_zuckerman added reviewers: AsafBadouh, igorb, delena. m_zuckerman added a subscriber: cfe-commits. http://reviews.llvm.org/D21058 Files: include/clang/Basic/BuiltinsX86.def lib/Headers/avx512bwintrin.h test/CodeGen/avx512bw-builtins.c Index:

[clang-tools-extra] r271989 - [include-fixer] Mention more details in the document.

Author: hokein Date: Tue Jun 7 02:50:48 2016 New Revision: 271989 URL: http://llvm.org/viewvc/llvm-project?rev=271989=rev Log: [include-fixer] Mention more details in the document. Reviewers: bkramer Subscribers: Eugene.Zelenko, cfe-commits, ioeric Differential Revision:

Re: [PATCH] D20467: [include-fixer] Mention more details in the document.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271989: [include-fixer] Mention more details in the document. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20467?vs=59838=59839#toc Repository: rL LLVM

Re: [PATCH] D20856: [clang-tidy] readability-identifier-naming - Support for Type Aliases

This revision was automatically updated to reflect the committed changes. Closed by commit rL271992: [clang-tidy] readability-identifier-naming - Support for Type Aliases (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D20856?vs=59189=59847#toc Repository: rL LLVM

Re: [PATCH] D20966: [include-fixer] Add the missing header to the file where the unidentified symbol comes from.

hokein added inline comments. Comment at: include-fixer/IncludeFixer.cpp:104 @@ -103,3 @@ -// class Bar; -// Foo foo; -// bkramer wrote: > Does this patch do the right thing for the test case in the comment? > Otherwise we'll try add includes to

Re: [PATCH] D21059: [clang-tidy] Ignore the deleted function in misc-definitions-in-headers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271991: [clang-tidy] Ignore the deleted function in misc-definitions-in-headers. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D21059?vs=59843=59845#toc Repository: rL LLVM

[clang-tools-extra] r271991 - [clang-tidy] Ignore the deleted function in misc-definitions-in-headers.

Author: hokein Date: Tue Jun 7 03:55:38 2016 New Revision: 271991 URL: http://llvm.org/viewvc/llvm-project?rev=271991=rev Log: [clang-tidy] Ignore the deleted function in misc-definitions-in-headers. Reviewers: alexfh Subscribers: cfe-commits Differential Revision:

Re: [PATCH] D20382: Add postorder support to RecursiveASTVisitor

bkramer added a comment. IMO a 20% release binary size increase is not acceptable. Is there a way to compile in support only if it's actually used? Maybe some constexpr or template magic? http://reviews.llvm.org/D20382 ___ cfe-commits mailing

Re: [PATCH] D21059: [clang-tidy] Ignore the deleted function in misc-definitions-in-headers.

hokein updated this revision to Diff 59843. hokein marked an inline comment as done. hokein added a comment. Use the existing test file. http://reviews.llvm.org/D21059 Files: clang-tidy/misc/DefinitionsInHeadersCheck.cpp test/clang-tidy/misc-definitions-in-headers.hpp Index:

[PATCH] D21059: [clang-tidy] Ignore the deleted function in misc-definitions-in-headers.

hokein created this revision. hokein added a reviewer: alexfh. hokein added a subscriber: cfe-commits. http://reviews.llvm.org/D21059 Files: clang-tidy/misc/DefinitionsInHeadersCheck.cpp test/clang-tidy/misc-definitions-in-headers-cxx11.hpp Index:

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

hokein added inline comments. Comment at: test/clang-tidy/misc-misplaced-const.c:17 @@ +16,3 @@ + const ip i3 = 0; + // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: 'i3' declared with a const-qualified typedef type; results in the type being 'int *const' instead of 'const int *'

Re: [PATCH] D21019: [include-fixer] try to make vim header selection more friendly.

bkramer added a comment. Nice! Can we somehow make the user not press enter after putting in the number? getchar() maybe? http://reviews.llvm.org/D21019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21021: [Clang][AVX512][BuiltIn]Adding intrinsics move_{sd|ss} to clang

delena added inline comments. Comment at: lib/Headers/avx512fintrin.h:9124 @@ +9123,3 @@ +{ + return (__m128) __builtin_ia32_movss_mask ((__v4sf) __A, (__v4sf) __B, + (__v4sf) __W, please try the following: if (__U) return __builtin_shuffle(A, B,

Re: [PATCH] D21058: [Clang][AVX512][BUILTIN]Adding missing intrinsics srl and sll

igorb accepted this revision. igorb added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D21058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21059: [clang-tidy] Ignore the deleted function in misc-definitions-in-headers.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with one comment. Comment at: test/clang-tidy/misc-definitions-in-headers-cxx11.hpp:6 @@ +5,3 @@ + +int f() = delete; +// CHECK-NOT: [misc-definitions-in-headers]

r271995 - Reapply [Coverage] Fix an assertion failure if the definition of an unused function spans multiple files.

Author: ikudrin Date: Tue Jun 7 05:07:51 2016 New Revision: 271995 URL: http://llvm.org/viewvc/llvm-project?rev=271995=rev Log: Reapply [Coverage] Fix an assertion failure if the definition of an unused function spans multiple files. We have an assertion failure if, for example, the definition

Re: [PATCH] D21050: [clang-tidy] correct clang-tidy-diff.py help message

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Thank you for fixing the copy-paste failures! Do you need me to commit the patch for you? Comment at: clang-tidy/tool/clang-tidy-diff.py:42 @@ -41,3 +41,3 @@

[PATCH] D21060: [AVX512] Emit select instruction instead of using x86 specific instrinsics.

igorb created this revision. igorb added reviewers: craig.topper, delena. igorb added a subscriber: cfe-commits. igorb set the repository for this revision to rL LLVM. [AVX512] Emit select instruction instead of using x86 specific instrinsics. This will allow us to remove the x86 instrinics

Re: [PATCH] D21019: [include-fixer] try to make vim header selection more friendly.

ioeric updated this revision to Diff 59858. ioeric added a comment. - fixed a bug with index. http://reviews.llvm.org/D21019 Files: include-fixer/tool/clang-include-fixer.py Index: include-fixer/tool/clang-include-fixer.py ===

Re: [PATCH] D21019: [include-fixer] try to make vim header selection more friendly.

ioeric added a comment. As per our offline discussion, `getchar()` does not work with options with more than 2 digits (e.g. index number > 9). I'll keep it as it is now until we come up with a better solution. http://reviews.llvm.org/D21019 ___

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

JamesReynolds updated this revision to Diff 59857. JamesReynolds added a comment. Thanks Eugene, I've added a comment into docs/ReleaseNotes.rst to say this is in. I'll create a BugZilla account to update PR. I've also added a new test and code to create FixIts for uses of the Macros as well

[clang-tools-extra] r272038 - [Clang-tidy] Documentation style consistency.

Author: eugenezelenko Date: Tue Jun 7 13:29:15 2016 New Revision: 272038 URL: http://llvm.org/viewvc/llvm-project?rev=272038=rev Log: [Clang-tidy] Documentation style consistency. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:262 @@ -261,1 +261,3 @@ +- Updated `readability-identifier-naming-check + `_ Please put this not in

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

kubabrecka added a subscriber: kubabrecka. kubabrecka added a comment. This doesn’t make sense to me, Clang is able to produce ASanified code even when the compiler itself isn’t ASanified (that’s what LLVM_USE_SANITIZER does). Where exactly is this test failing? Repository: rL LLVM

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

hokein added a comment. @aaron.ballman, you forgot to add the check in docs/ReleaseNotes.rst. http://reviews.llvm.org/D21036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20922: [libcxx] [test] Rename global "x" to "testcases" in complex.number/cases.h and make it const for safety.

STL_MSFT closed this revision. STL_MSFT added a comment. Marshall checked this in, so I'm closing this. http://reviews.llvm.org/D20922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20921: [libcxx] [test] Slightly rearrange scopes in order to avoid shadowing M typedefs.

STL_MSFT closed this revision. STL_MSFT added a comment. Marshall checked this one in too, closing. http://reviews.llvm.org/D20921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r272050 - Added notes for a bunch of the issues

Author: marshall Date: Tue Jun 7 15:05:57 2016 New Revision: 272050 URL: http://llvm.org/viewvc/llvm-project?rev=272050=rev Log: Added notes for a bunch of the issues Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL:

Re: 3.8 Merge Request: r259776

Hi Tom, I'm on a vacation right now without an access to the computer. Could you do it yourself? Best regards, Alexey Bataev Отправлено с iPhone > 7 июня 2016 г., в 22:49, Tom Stellard написал(а): > > Hi Alexy, > > Can you merge this? > > Thanks, > Tom > >> On Tue, Jun

Re: [PATCH] D21107: Generate codeview for array types

majnemer added a subscriber: majnemer. Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:785 @@ +784,3 @@ + TypeIndex IndexType = Asm->MAI->getPointerSize() == 8 ? + TypeIndex(SimpleTypeKind::UInt64) : + TypeIndex(SimpleTypeKind::UInt32); They don't

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler updated the summary for this revision. eric_niebler updated this revision to Diff 59974. eric_niebler added a comment. Rework the patch to only warn by default for include files //not// found in system include directories, unless they are known "standard" headers that should be

Re: [PATCH] D20709: For RenderScript, set alignment and width of long to 64-bits

rsmith added a comment. In http://reviews.llvm.org/D20709#446595, @srhines wrote: > There is a coming patch that adds a single attribute (for "kernel"), that has > error checking to ensure that it is only used by our RenderScript targets. I > assume that the cleanest way to retain that

r272080 - [Sema] Teach CheckPlaceholderExpr about unaddressable functions.

Author: gbiv Date: Tue Jun 7 19:34:22 2016 New Revision: 272080 URL: http://llvm.org/viewvc/llvm-project?rev=272080=rev Log: [Sema] Teach CheckPlaceholderExpr about unaddressable functions. Given the following C++: ``` void foo(); void foo() __attribute__((enable_if(false, ""))); bool bar() {

r272079 - [ItaniumMangle] Mangle dependent __underlying_type correctly

Author: majnemer Date: Tue Jun 7 19:34:15 2016 New Revision: 272079 URL: http://llvm.org/viewvc/llvm-project?rev=272079=rev Log: [ItaniumMangle] Mangle dependent __underlying_type correctly We attempted to use the UnaryTransformType's UnderlyingType instead of it's BaseType. This is not

[PATCH] D21111: Avoid accessing an invalid PresumedLoc

jordan_rose created this revision. jordan_rose added a reviewer: rsmith. jordan_rose added a subscriber: cfe-commits. jordan_rose set the repository for this revision to rL LLVM. DiagnosticNoteRenderer asserts trying to emit its "while building module Foo imported from bar.h:5" note when the

[PATCH] D21113: Add support for case-insensitive header lookup

hans created this revision. hans added reviewers: rsmith, rnk, thakis. hans added subscribers: compnerd, majnemer, benlangmuir, cfe-commits. This is useful when dealing with headers that are normally used on case-insensitive filesystems, such as the Windows SDK, when cross-compiling from a

[PATCH] D21107: Generate codeview for array types

amccarth created this revision. amccarth added a reviewer: rnk. amccarth added a subscriber: cfe-commits. Creates codeview type records for arrays and adds a simple test for one. http://reviews.llvm.org/D21107 Files: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp

Re: [PATCH] D21113: Add support for case-insensitive header lookup

hans updated this revision to Diff 59982. hans added a comment. Add --show-includes test. http://reviews.llvm.org/D21113 Files: include/clang/Basic/VirtualFileSystem.h include/clang/Driver/Options.td include/clang/Lex/HeaderSearchOptions.h lib/Basic/VirtualFileSystem.cpp

Re: [PATCH] D21107: Generate codeview for array types

amccarth added inline comments. Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:785 @@ +784,3 @@ + TypeIndex IndexType = Asm->MAI->getPointerSize() == 8 ? + TypeIndex(SimpleTypeKind::UInt64) : + TypeIndex(SimpleTypeKind::UInt32); majnemer wrote: >

[PATCH] D21093: [libcxx] [test] In unord.hash/floating.pass.cpp, add a static_cast to fix a truncation warning.

STL_MSFT created this revision. STL_MSFT added reviewers: mclow.lists, EricWF. STL_MSFT added a subscriber: cfe-commits. In unord.hash/floating.pass.cpp, add a static_cast to fix a truncation warning. Fixes MSVC warning C4305 "'argument': truncation from 'double' to 'const std::hash::_Kty'".

[PATCH] D21094: [libcxx] [test] In test/support/test_allocator.h, fix construct() to avoid moving immovable types.

STL_MSFT created this revision. STL_MSFT added reviewers: mclow.lists, EricWF. STL_MSFT added a subscriber: cfe-commits. In test/support/test_allocator.h, fix construct() to avoid moving immovable types. This improves the allocator's conformance, and fixes compiler errors with MSVC's STL. The

[PATCH] D21095: [libcxx] [test] Fix another MSVC warning C4101 "unreferenced local variable".

STL_MSFT created this revision. STL_MSFT added reviewers: mclow.lists, EricWF. STL_MSFT added a subscriber: cfe-commits. Fix another MSVC warning C4101 "unreferenced local variable". http://reviews.llvm.org/D21095 Files:

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

bcraig added a comment. tldr; I'm going to recommend we stick with the current algorithm, but I only have partial data to back that up. For the pile of LLVM projects that I am currently building (llvm, clang, libcxx, libcxxabi), 18.9% of all analyzed functions hit the maximum step count. For

[PATCH] D21092: [libcxx] [test] Fix vector tests that were using ints copy-pasted from vector tests.

STL_MSFT created this revision. STL_MSFT added reviewers: mclow.lists, EricWF. STL_MSFT added a subscriber: cfe-commits. Fix vector tests that were using ints copy-pasted from vector tests. I copied the bool a[] 0/1 pattern from another vector test. Fixes MSVC warning C4305 "'argument':

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

bcraig updated this revision to Diff 59950. bcraig added a comment. Uploading more context. http://reviews.llvm.org/D20933 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h lib/StaticAnalyzer/Core/CoreEngine.cpp Index: lib/StaticAnalyzer/Core/CoreEngine.cpp

[PATCH] D21096: [libcxx] [test] Fix MSVC warning C4125 "decimal digit terminates octal escape sequence".

STL_MSFT created this revision. STL_MSFT added reviewers: mclow.lists, EricWF. STL_MSFT added a subscriber: cfe-commits. Fix MSVC warning C4125 "decimal digit terminates octal escape sequence". MSVC somewhat justifiably warns when it sees an octal escape immediately followed by a decimal digit,

Re: 3.8 Merge Request: r259776

Hi Alexy, Can you merge this? Thanks, Tom On Tue, Jun 07, 2016 at 09:40:44AM -0700, Richard Smith wrote: > It's larger than I'd like for a merge onto the branch, but yes, it looks OK. > > On 7 Jun 2016 9:20 a.m., "Tom Stellard via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > > > Hi

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

On Tue, Jun 7, 2016 at 3:06 PM, Haojian Wu wrote: > hokein added a comment. > > @aaron.ballman, you forgot to add the check in docs/ReleaseNotes.rst. Added in a separate commit (r272026). ~Aaron > > > http://reviews.llvm.org/D21036 > > >

RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

Hi Jeroen, Thanks for your consideration. I am OK with removing those extensions which do not affect language or builtin functions. After removing them, they will be unknown to Clang. If a user tries to enable them, a warning will be emitted saying the extension is unknown. Anastasia, are

Re: [PATCH] D21113: Add support for case-insensitive header lookup

compnerd added a comment. This looks good to me. Thanks for picking this up! And thanks for the perf numbers! Comment at: lib/Basic/VirtualFileSystem.cpp:401 @@ +400,3 @@ +IntrusiveRefCntPtr Base) +: Base(Base) {} + Probably can inline this in the

[libcxxabi] r272102 - Creating release directory for release_381.

Author: tstellar Date: Tue Jun 7 22:27:22 2016 New Revision: 272102 URL: http://llvm.org/viewvc/llvm-project?rev=272102=rev Log: Creating release directory for release_381. Added: libcxxabi/tags/RELEASE_381/ ___ cfe-commits mailing list

[libunwind] r272115 - Creating release candidate rc1 from release_381 branch

Author: tstellar Date: Tue Jun 7 22:27:35 2016 New Revision: 272115 URL: http://llvm.org/viewvc/llvm-project?rev=272115=rev Log: Creating release candidate rc1 from release_381 branch Added: libunwind/tags/RELEASE_381/rc1/ - copied from r272114, libunwind/branches/release_38/

[libcxx] r272100 - Creating release directory for release_381.

Author: tstellar Date: Tue Jun 7 22:27:19 2016 New Revision: 272100 URL: http://llvm.org/viewvc/llvm-project?rev=272100=rev Log: Creating release directory for release_381. Added: libcxx/tags/RELEASE_381/ ___ cfe-commits mailing list

[libunwind] r272114 - Creating release directory for release_381.

Author: tstellar Date: Tue Jun 7 22:27:34 2016 New Revision: 272114 URL: http://llvm.org/viewvc/llvm-project?rev=272114=rev Log: Creating release directory for release_381. Added: libunwind/tags/RELEASE_381/ ___ cfe-commits mailing list

[libcxx] r272101 - Creating release candidate rc1 from release_381 branch

Author: tstellar Date: Tue Jun 7 22:27:21 2016 New Revision: 272101 URL: http://llvm.org/viewvc/llvm-project?rev=272101=rev Log: Creating release candidate rc1 from release_381 branch Added: libcxx/tags/RELEASE_381/rc1/ (props changed) - copied from r272100,

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Actually there are other tests with -fsanitize=address I see only difference in %clang vs %clang_cc1? Could you try this? Repository: rL LLVM http://reviews.llvm.org/D21082

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

vitalybuka added a comment. I guess you can remove // UNSUPPORTED: mingw32 added by cfe/trunk@271509 Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

vitalybuka added a comment. http://reviews.llvm.org/D21117 Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. It was accepted accidentally. Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

vitalybuka added a comment. Oh, I see, most asan tests in clang use cross-compiler, e.g.: -target x86_64-linux-gnu Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D21117: Specify target in lifetime-asan test.

vitalybuka created this revision. vitalybuka added reviewers: pcc, eugenis. vitalybuka added subscribers: kubabrecka, chapuni, christof, cfe-commits. Some target platforms -fsanitize=address. http://reviews.llvm.org/D21117 Files: test/CodeGen/lifetime-asan.c Index:

r272091 - AMDGPU: Verify subtarget specific builtins

Author: arsenm Date: Tue Jun 7 20:56:42 2016 New Revision: 272091 URL: http://llvm.org/viewvc/llvm-project?rev=272091=rev Log: AMDGPU: Verify subtarget specific builtins Cleanup setup of subtarget features. Added: cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn-error.cl

Re: [PATCH] D17516: AMDGPU: Verify subtarget specific builtins

arsenm closed this revision. arsenm added a comment. r272091 http://reviews.llvm.org/D17516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] r272103 - Creating release candidate rc1 from release_381 branch

Author: tstellar Date: Tue Jun 7 22:27:23 2016 New Revision: 272103 URL: http://llvm.org/viewvc/llvm-project?rev=272103=rev Log: Creating release candidate rc1 from release_381 branch Added: libcxxabi/tags/RELEASE_381/rc1/ (props changed) - copied from r272102,

r272067 - [docs] Coverage: Explain how to avoid static initializers

Author: vedantk Date: Tue Jun 7 17:25:29 2016 New Revision: 272067 URL: http://llvm.org/viewvc/llvm-project?rev=272067=rev Log: [docs] Coverage: Explain how to avoid static initializers Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst Modified:

Re: [PATCH] D17516: AMDGPU: Verify subtarget specific builtins

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Seems pretty reasonable. If I missed anything we can pick it up later. -eric Comment at: lib/Basic/Targets.cpp:2010 @@ +2009,3 @@ + + // XXX - What does the member GPU

[PATCH] D21104: [CodeGen][ObjC] Block captures should inherit the type of the captured field in the enclosing lambda or block

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a subscriber: cfe-commits. This patch fixes a bug in code-gen where it uses the type of the declared variable rather than the type of the capture of the enclosing lambda or block for the block capture. For

Re: [PATCH] D18761: [mips] Enable IAS by default for 32-bit MIPS targets (O32).

dsanders closed this revision. dsanders added a comment. This has already been committed. I'm not sure why it didn't auto-close. http://reviews.llvm.org/D18761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. In http://reviews.llvm.org/D21036#450106, @sbenza wrote: > I think this would be more interesting with macros. > Eg triggering in code like this: > > #define FOO(type, op) const type& X = op() > FOO(int*, bar);

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

DmitryPolukhin added a comment. In http://reviews.llvm.org/D18035#450258, @rsmith wrote: > Yes, I definitely want us to implement this for GCC compatibility. And now > that we have a specification for this feature, we can evaluate whether this > is doing the right thing. On that basis: > > I

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

hokein added inline comments. Comment at: clang-tidy/llvm/HeaderGuardCheck.h:19 @@ -18,3 +18,3 @@ /// Finds and fixes header guards that do not adhere to LLVM style. class LLVMHeaderGuardCheck : public utils::HeaderGuardCheck { hokein wrote: > madsravn wrote:

[PATCH] D21072: [mips] Account for -mabi when determining whether IAS is the default or not.

dsanders created this revision. dsanders added subscribers: jfb, dschuff, cfe-commits. dsanders added a dependency: D21070: Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'. Herald added subscribers: sdardis, srhines, danalbert, tberghammer.

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

aaron.ballman marked an inline comment as done. Comment at: test/clang-tidy/misc-misplaced-const.c:17 @@ +16,3 @@ + const ip i3 = 0; + // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: 'i3' declared with a const-qualified typedef type; results in the type being 'int *const' instead

[PATCH] D21070: Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'

dsanders created this revision. dsanders added a subscriber: cfe-commits. dsanders added a dependency: D21069: [mips] Require that ABI's are passed in the triple within LLVM.. Herald added subscribers: srhines, danalbert, tberghammer. 'clang -cc1' and 'clang -cc1as' will mutate the triple to

Re: [PATCH] D21071: [mips] Account for -mabi when determining whether IAS is the default or not.

dsanders abandoned this revision. dsanders added a comment. Part of this patch is missing. I'll repost it soon. http://reviews.llvm.org/D21071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D21066: Pass MCSubtargetInfo instead of CPU and Triple to createMCAsmBackend

aturetsk created this revision. aturetsk added reviewers: bruno, echristo, ahatanak, RKSimon. aturetsk added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. Pass MCSubtargetInfo instead of CPU and Triple to AsmBackend in order to be able to reach feature bits there (e.g. for

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

aaron.ballman updated this revision to Diff 59868. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Updated based on review feedback: - Added another two test cases (one for templates and one for const binding to the right of the typedef type). - Updated test cases

Re: [PATCH] D21022: [ARM] Fix linker emulation for arm 32 big endian

spetrovic updated this revision to Diff 59870. spetrovic marked an inline comment as done. spetrovic added a comment. Comment addressed. http://reviews.llvm.org/D21022 Files: lib/Driver/Tools.cpp test/Driver/linux-ld.c Index: test/Driver/linux-ld.c

[clang-tools-extra] r272004 - [include-fixer] try to make vim header selection more friendly.

Author: ioeric Date: Tue Jun 7 07:21:43 2016 New Revision: 272004 URL: http://llvm.org/viewvc/llvm-project?rev=272004=rev Log: [include-fixer] try to make vim header selection more friendly. Summary: use 'input()' to get user's input so that we can support more options. Reviewers: hokein,

Re: [PATCH] D21019: [include-fixer] try to make vim header selection more friendly.

This revision was automatically updated to reflect the committed changes. Closed by commit rL272004: [include-fixer] try to make vim header selection more friendly. (authored by ioeric). Changed prior to commit: http://reviews.llvm.org/D21019?vs=59858=59871#toc Repository: rL LLVM

[PATCH] D21071: [mips] Account for -mabi when determining whether IAS is the default or not.

dsanders created this revision. dsanders added a subscriber: cfe-commits. dsanders added a dependency: D21070: Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'. Herald added subscribers: dschuff, jfb. This stops cases such as '-target

Re: [PATCH] D21074: Correct invalid end location in diagnostics for some identifiers.

erikjv abandoned this revision. erikjv added a comment. Wrong patch http://reviews.llvm.org/D21074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r272012 - [clang][AVX512][Intrinsics] Adding intrinsics reduce_[round]_{ss|sd} to clang

Author: mzuckerm Date: Tue Jun 7 09:00:20 2016 New Revision: 272012 URL: http://llvm.org/viewvc/llvm-project?rev=272012=rev Log: [clang][AVX512][Intrinsics] Adding intrinsics reduce_[round]_{ss|sd} to clang Differential Revision: http://reviews.llvm.org/D21014 Modified:

[PATCH] D21074: Correct invalid end location in diagnostics for some identifiers.

erikjv created this revision. erikjv added reviewers: bkramer, klimek. erikjv added a subscriber: cfe-commits. Declaration names in DeclSpec had only their start set to a valid location, so when the type specifier was missing, only the carret would be shown at the first character of the name of a

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

pgousseau updated this revision to Diff 59887. pgousseau added a comment. Following Bruno's comment: - Remove call to sleep using touch -m -a -t http://reviews.llvm.org/D20867 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/FrontendOptions.h

Re: [PATCH] D21023: [mips] Defer validity check for CPU/ABI pairs and improve error message for invalid cases.

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D21023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

pgousseau added a comment. > > On Linux, if the timestamp of a header file, included in the pch, is > > modified, then including the pch without regenerating it causes a fatal > > error, which is reasonable. > > > On Windows the check is ifdefed out, allowing the compilation to continue >

Re: [PATCH] D21014: [Clang][AVX512][Intrinsics] Adding intrinsics reduce_[round]_{ss|sd} to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL272012: [clang][AVX512][Intrinsics] Adding intrinsics reduce_[round]_{ss|sd} to clang (authored by mzuckerm). Changed prior to commit: http://reviews.llvm.org/D21014?vs=59697=59882#toc Repository:

Re: [PATCH] D15994: Allow for unfinished #if blocks in preambles.

erikjv abandoned this revision. erikjv added a comment. This will give errors about unbalanced #if/#endif for header guards. http://reviews.llvm.org/D15994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20687: [ASTMatchers] Make isNoThrow and hasDynamicExceptionSpec polymorphic for use with both functionDecl and functionProtoType

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for working on this! http://reviews.llvm.org/D20687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20687: [ASTMatchers] Make isNoThrow and hasDynamicExceptionSpec polymorphic for use with both functionDecl and functionProtoType

hintonda added a comment. Thanks Aaron. If you could commit for me, I'd appreciate it. Thanks again... http://reviews.llvm.org/D20687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D21075: Correct invalid end location in diagnostics for some identifiers.

erikjv created this revision. erikjv added reviewers: bkramer, klimek. erikjv added a subscriber: cfe-commits. Declaration names in DeclSpec had only their start set to a valid location, so when the type specifier was missing, only the carret would be shown at the first character of the name of a

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

It seems Phabricator did not picked up Richard's message so I have manually copied and replied to it via Phabricator's web interface. Cheers, Pierre On 6 June 2016 at 21:53, Richard Smith wrote: > On Wed, Jun 1, 2016 at 8:33 AM, pierre gousseau via cfe-commits < >

[libcxx] r272018 - Avoid Shadowing warnings in the associative containers tests. Thanks to STL for the patch.

Author: marshall Date: Tue Jun 7 10:49:39 2016 New Revision: 272018 URL: http://llvm.org/viewvc/llvm-project?rev=272018=rev Log: Avoid Shadowing warnings in the associative containers tests. Thanks to STL for the patch. Modified:

[PATCH] D21081: MPI-Checker patch for Clang Static Analyzer

dcoughlin created this revision. dcoughlin added reviewers: zaks.anna, dcoughlin, Alexander_Droste. dcoughlin added a subscriber: cfe-commits. (Cloning the revision for the ASan issue since the old one is closed and can't be re-opened) This patch adds a static analysis checker to verify the

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

rmaprath added a comment. In http://reviews.llvm.org/D20328#451197, @rmaprath wrote: > In http://reviews.llvm.org/D20328#451178, @mclow.lists wrote: > > > Also, I don't see how this can be retargeted "at runtime"; are you implying > > that someone can choose at program launch time what

Re: [PATCH] D20921: [libcxx] [test] Slightly rearrange scopes in order to avoid shadowing M typedefs.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Landed as revision 272018 http://reviews.llvm.org/D20921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

mclow.lists added a comment. Some nits while reading this. More to come. Also, I don't see how this can be retargeted "at runtime"; are you implying that someone can choose at program launch time what threading system to use? How could that work given (say) a constexpr constructor for a mutex

Re: [PATCH] D21081: MPI-Checker patch for Clang Static Analyzer

dcoughlin added a comment. Alexander, When I committed your patch, the AddressSanitizer bots found a memory corruption issue so I reverted it. This will need to be fixed before we can commit the patch. Since Phabricator automatically closed http://reviews.llvm.org/D12761, I've created a new

  1   2   >