Re: [PATCH] D21343: Implement `lcm` and `gcd` from library fundamentals V2

mclow.lists updated this revision to Diff 60856. mclow.lists added a comment. Updated based on comments here and elsewhere. - Do the abs once, rather than at every level of recursion - Add tests for `bool`. - Constexpr Also, add an assertion to detect overflow in `lcm`. I have not yet

Re: [PATCH] D21343: Implement `lcm` and `gcd` from library fundamentals V2

mclow.lists marked 8 inline comments as done. mclow.lists added a comment. http://reviews.llvm.org/D21343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r272798 - [Sparc] setjmp and longjmp intrinsic support update to add unit tests and remove accidentally checked-in code.

Author: lerochris Date: Wed Jun 15 11:08:13 2016 New Revision: 272798 URL: http://llvm.org/viewvc/llvm-project?rev=272798=rev Log: [Sparc] setjmp and longjmp intrinsic support update to add unit tests and remove accidentally checked-in code. Related to revision r272782 Modified:

[PATCH] D21367: AMDGPU: Set amdgpu_kernel calling convention for OpenCL kernels.

nhaustov created this revision. nhaustov added reviewers: tstellarAMD, rsmith. nhaustov added a subscriber: cfe-commits. Herald added a subscriber: kzhuravl. Extend CC field of FunctionType to 5 bits and ExtInfo to 10 bits to make space for new calling convention. Add new Clang calling convention

Re: [PATCH] D21179: Add mrrc/mrrc2 intrinsics and update existing mcrr/mcrr2 intrinsics to accept a single uint64 type instead of 2 uint32 types

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. Thanks Ranjeet, looks much better now! LGTM, Thanks! http://reviews.llvm.org/D21179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21134: clang-tidy: new check readability-misplaced-array-index

danielmarjamaki removed rL LLVM as the repository for this revision. danielmarjamaki updated this revision to Diff 60803. danielmarjamaki added a comment. updated releasedocs deeper lookup if macro is used only warn when the replacement can be done safely. the expressions "x[y+z]" and y+z[x]"

Re: r272702 - s/Intrin.h/intrin.h/, trying to fix the build after r272701

Thank you! On Tue, Jun 14, 2016 at 10:14 PM, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hans > Date: Tue Jun 14 15:14:24 2016 > New Revision: 272702 > > URL: http://llvm.org/viewvc/llvm-project?rev=272702=rev > Log: > s/Intrin.h/intrin.h/, trying to fix the

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

pgousseau added a comment. Ping! http://reviews.llvm.org/D20867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21134: clang-tidy: new check readability-misplaced-array-index

danielmarjamaki updated this revision to Diff 60804. danielmarjamaki added a comment. fixed typo in releasenotes http://reviews.llvm.org/D21134 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/MisplacedArrayIndexCheck.cpp

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

vmiklos updated this revision to Diff 60800. http://reviews.llvm.org/D21364 Files: clang-rename/USRLocFinder.cpp test/clang-rename/DtorDefTest.cpp Index: test/clang-rename/DtorDefTest.cpp === --- /dev/null +++

Re: [gentoo-musl] Re: Add support for musl-libc on Linux

2016-06-14 20:55 GMT+08:00 Rafael Espíndola : > On 13 June 2016 at 21:07, Lei Zhang wrote: >> 2016-06-14 5:00 GMT+08:00 Rafael Espíndola : >>> Do you need someone to commit it for you? >> >> Yes, please :) > >

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

vmiklos updated the summary for this revision. vmiklos updated this revision to Diff 60799. http://reviews.llvm.org/D21364 Files: clang-rename/USRLocFinder.cpp test/clang-rename/DtorDefTest.cpp Index: test/clang-rename/DtorDefTest.cpp

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

vmiklos added a comment. Thanks, sounds like exactly what I need. http://reviews.llvm.org/D21364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

berenm added a comment. It looks like it doesn't like the `operator[]` either: struct test { long long int foo(); int operator[](int a); double bar(); long long int foo(); int operator()(int a); double bar(); }; becomes: struct test { long long int foo();

[PATCH] D21364: clang-rename: implement renaming of classes with a dtor

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. Work in progress, not complete yet. Current result: clang-rename -offset 135 -new-name=Bar DtorDefTest.cpp -- - handles "Foo" from "Foo::~Foo" correctly - handles "~Foo" from

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

klimek added a comment. For 2), SourceLocation has getLocWithOffset? http://reviews.llvm.org/D21364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

bmharper added a comment. Interesting. Working on it! http://reviews.llvm.org/D21279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

vmiklos updated this revision to Diff 60801. vmiklos added a comment. Now the correct patch. :-) http://reviews.llvm.org/D21364 Files: clang-rename/USRLocFinder.cpp test/clang-rename/DtorDefTest.cpp Index: test/clang-rename/DtorDefTest.cpp

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Comment at: clang-rename/USRLocFinder.cpp:94 @@ +93,3 @@ + // that is not to be touched by the rename. +

[PATCH] D21366: [clang-tidy] misc-move-const-arg: Fix typos

mboehme created this revision. mboehme added a reviewer: alexfh. mboehme added a subscriber: cfe-commits. http://reviews.llvm.org/D21366 Files: clang-tidy/misc/MoveConstantArgumentCheck.cpp clang-tidy/misc/MoveConstantArgumentCheck.h Index: clang-tidy/misc/MoveConstantArgumentCheck.h

Re: [PATCH] D21371: [include-fixer] Correct two wrong header mappings.

This revision was automatically updated to reflect the committed changes. Closed by commit rL272773: [include-fixer] Correct two wrong header mappings. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D21371?vs=60812=60814#toc Repository: rL LLVM

r272775 - [OPENMP] Fix crash for 'schedule|dist_schedule' clauses during

Author: abataev Date: Wed Jun 15 06:20:48 2016 New Revision: 272775 URL: http://llvm.org/viewvc/llvm-project?rev=272775=rev Log: [OPENMP] Fix crash for 'schedule|dist_schedule' clauses during instantiation. Added checks for non-dependent context when trygin to capture non-constant schedule chunk

r272777 - [ARM] Add mrrc/mrrc2 intrinsics and update existing mcrr/mcrr2 intrinsics.

Author: rsingh Date: Wed Jun 15 06:32:18 2016 New Revision: 272777 URL: http://llvm.org/viewvc/llvm-project?rev=272777=rev Log: [ARM] Add mrrc/mrrc2 intrinsics and update existing mcrr/mcrr2 intrinsics. Patch adds intrinsics for mrrc/mrrc2. The intrinsics for mrrc/mrrc2 return a single uint64_t

r272782 - [Sparc] Change to let clang know that setjmp and longjmp intrinsics are implemented in the back-end.

Author: lerochris Date: Wed Jun 15 07:44:47 2016 New Revision: 272782 URL: http://llvm.org/viewvc/llvm-project?rev=272782=rev Log: [Sparc] Change to let clang know that setjmp and longjmp intrinsics are implemented in the back-end. Differential Revision: http://reviews.llvm.org/D19798

r272776 - Revert accidential "[MSVC] Late parsing of in-class defined member functions in template"

Author: abataev Date: Wed Jun 15 06:24:54 2016 New Revision: 272776 URL: http://llvm.org/viewvc/llvm-project?rev=272776=rev Log: Revert accidential "[MSVC] Late parsing of in-class defined member functions in template" This reverts commit 0253605771b8bd9d414aba74fe2742c730d6fd1a. Modified:

r272774 - [MSVC] Late parsing of in-class defined member functions in template

Author: abataev Date: Wed Jun 15 06:19:39 2016 New Revision: 272774 URL: http://llvm.org/viewvc/llvm-project?rev=272774=rev Log: [MSVC] Late parsing of in-class defined member functions in template classes. MSVC actively uses unqualified lookup in dependent bases, lookup at the instantiation

Re: [PATCH] D21179: Add mrrc/mrrc2 intrinsics and update existing mcrr/mcrr2 intrinsics to accept a single uint64 type instead of 2 uint32 types

This revision was automatically updated to reflect the committed changes. Closed by commit rL272777: [ARM] Add mrrc/mrrc2 intrinsics and update existing mcrr/mcrr2 intrinsics. (authored by rsingh). Changed prior to commit: http://reviews.llvm.org/D21179?vs=60504=60815#toc Repository: rL

[PATCH] D21373: [Clang][bmi][intrinsics] Adding _mm_tzcnt_64 _mm_tzcnt_32 intrinsics to clang.

m_zuckerman created this revision. m_zuckerman added reviewers: AsafBadouh, igorb, delena. m_zuckerman added a subscriber: cfe-commits. http://reviews.llvm.org/D21373 Files: lib/Headers/bmiintrin.h test/CodeGen/bmi-builtins.c Index: test/CodeGen/bmi-builtins.c

[PATCH] D21375: Remove a redundant set of applyAllReplacements declarations.

ioeric created this revision. ioeric added reviewers: djasper, klimek. ioeric added a subscriber: cfe-commits. Herald added a subscriber: klimek. Not sure if this is intended, but there are two identical sets of declarations of applyAllReplacements. http://reviews.llvm.org/D21375 Files:

[PATCH] D21371: [include-fixer] Correct two wrong header mappings.

hokein created this revision. hokein added a reviewer: bkramer. hokein added subscribers: cfe-commits, ioeric. http://reviews.llvm.org/D21371 Files: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp Index: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp

[clang-tools-extra] r272773 - [include-fixer] Correct two wrong header mappings.

Author: hokein Date: Wed Jun 15 06:15:12 2016 New Revision: 272773 URL: http://llvm.org/viewvc/llvm-project?rev=272773=rev Log: [include-fixer] Correct two wrong header mappings. Reviewers: bkramer Subscribers: ioeric, cfe-commits Differential Revision: http://reviews.llvm.org/D21371

Re: [PATCH] D21241: Add an ASTMatcher for ignoring ExprWithCleanups.

etienneb added a subscriber: etienneb. etienneb added a comment. I was wondering why we didn't created that Matcher: IgnoreImplicit I believe it's more commonly used than 'ignoringExprWithCleanups'. It can be implemented by calling 'Stmt.IgnoreImplicit'. /// Skip past any implicit AST nodes

[clang-tools-extra] r272795 - Apply performance-unnecessary-value-param to clang-tidy.

Author: d0k Date: Wed Jun 15 10:46:10 2016 New Revision: 272795 URL: http://llvm.org/viewvc/llvm-project?rev=272795=rev Log: Apply performance-unnecessary-value-param to clang-tidy. With minor manual tweaks. No functionality change intended. Modified:

[PATCH] D21385: Adjust Registry interface to not require plugins to export a registry

john.brawn created this revision. john.brawn added reviewers: ehsan, reames, chapuni. john.brawn added subscribers: llvm-commits, cfe-commits. john.brawn set the repository for this revision to rL LLVM. Herald added a subscriber: klimek. Currently the Registry class contains the vestiges of a

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

aturetsk added inline comments. Comment at: lib/Driver/Tools.cpp:3657 @@ +3656,3 @@ + if (IsIAMCU && types::isCXX(Input.getType())) +D.Diag(diag::err_drv_cxx_not_supported) << getToolChain().getTriple().str(); + aturetsk wrote: > bruno wrote: > > aturetsk

Re: [PATCH] D21373: [Clang][bmi][intrinsics] Adding _mm_tzcnt_64 _mm_tzcnt_32 intrinsics to clang.

RKSimon added a subscriber: RKSimon. RKSimon added a reviewer: RKSimon. Comment at: lib/Headers/bmiintrin.h:296 @@ -290,1 +295,3 @@ +} + #ifdef __x86_64__ Why not just #define to __tzcnt_u32 like the (many) other duplicate tzcnt intrinsics we have: ``` #define

r272787 - [AVX512] Use native IR for mask pcmpeq/pcmpgt intrinsics.

Author: ctopper Date: Wed Jun 15 09:06:34 2016 New Revision: 272787 URL: http://llvm.org/viewvc/llvm-project?rev=272787=rev Log: [AVX512] Use native IR for mask pcmpeq/pcmpgt intrinsics. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/test/CodeGen/avx512bw-builtins.c

r272788 - Don't use static variables in LambdaCapture

Author: john.brawn Date: Wed Jun 15 09:14:51 2016 New Revision: 272788 URL: http://llvm.org/viewvc/llvm-project?rev=272788=rev Log: Don't use static variables in LambdaCapture When static variables are used in inline functions in header files anything that uses that function ends up with a

Re: [PATCH] D20732: Don't use static variables in LambdaCapture

This revision was automatically updated to reflect the committed changes. Closed by commit rL272788: Don't use static variables in LambdaCapture (authored by john.brawn). Changed prior to commit: http://reviews.llvm.org/D20732?vs=58787=60831#toc Repository: rL LLVM

Re: [PATCH] D21187: Allow use of lambda expressions in array bounds

ahatanak added a comment. Sorry for my late reply. Comment at: lib/Sema/SemaExpr.cpp:12825 @@ -12824,1 +12824,3 @@ + // BlockContext. + } else if (!Rec.IsArrayBound) { // C++1y [expr.const]p2: rsmith wrote: > This isn't correct; you still

Re: [PATCH] D21306: [x86] AVX FP compare builtins should require AVX target feature (PR28112)

RKSimon added a comment. It seems like part of the need for this is because the _mm_cmp_ps style intrinsics are defined as macros (to get around the problem of trying to use an immediate as an argument): #define _mm_cmp_ps(a, b, c) __extension__ ({ \

[clang-tools-extra] r272803 - [clang-tidy] Remove dead code. NFC.

Author: d0k Date: Wed Jun 15 11:51:04 2016 New Revision: 272803 URL: http://llvm.org/viewvc/llvm-project?rev=272803=rev Log: [clang-tidy] Remove dead code. NFC. Modified: clang-tools-extra/trunk/clang-tidy/modernize/LoopConvertUtils.cpp

Re: [PATCH] D21375: Remove a redundant set of applyAllReplacements declarations.

ioeric abandoned this revision. ioeric added a comment. Abandon this patch in favor of http://reviews.llvm.org/D21382 http://reviews.llvm.org/D21375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r272804 - Fix const default initialization of lock_guard<>

Author: ericwf Date: Wed Jun 15 12:04:40 2016 New Revision: 272804 URL: http://llvm.org/viewvc/llvm-project?rev=272804=rev Log: Fix const default initialization of lock_guard<> Modified: libcxx/trunk/include/mutex Modified: libcxx/trunk/include/mutex URL:

r272807 - [x86] generate IR for SSE integer min/max builtins

Author: spatel Date: Wed Jun 15 12:18:50 2016 New Revision: 272807 URL: http://llvm.org/viewvc/llvm-project?rev=272807=rev Log: [x86] generate IR for SSE integer min/max builtins Sibling patch to r272806: http://reviews.llvm.org/rL272806 Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp

[libcxx] r272809 - Add -Wno-unused-command-line-argument when running the test suite to prevent errors

Author: ericwf Date: Wed Jun 15 12:25:05 2016 New Revision: 272809 URL: http://llvm.org/viewvc/llvm-project?rev=272809=rev Log: Add -Wno-unused-command-line-argument when running the test suite to prevent errors Modified: libcxx/trunk/test/libcxx/test/config.py Modified:

Re: [PATCH] D21277: Resubmit r270688: Using new TargetParser in Clang.

rengolin added inline comments. Comment at: lib/Basic/Targets.cpp:5709 @@ -5716,3 +5708,3 @@ void getTargetDefines(const LangOptions , MacroBuilder ) const override { We'll have to re-work these parts anyway. When I was looking to do

Re: r272782 - [Sparc] Change to let clang know that setjmp and longjmp intrinsics are implemented in the back-end.

On Wed, Jun 15, 2016 at 12:44:48PM -, Chris Dewhurst via cfe-commits wrote: > Modified: cfe/trunk/lib/Basic/Targets.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=272782=272781=272782=diff >

Re: [PATCH] D20732: Don't use static variables in LambdaCapture

jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. Fine with me. Repository: rL LLVM http://reviews.llvm.org/D20732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

bmharper set the repository for this revision to rL LLVM. bmharper updated this revision to Diff 60830. bmharper added a comment. Fix the recent two issues mentioned by Beren, ie the single-statement scopes (for loop without braces), and operator[] alignment. Repository: rL LLVM

r272789 - Apply some suggestions from clang-tidy's performance-unnecessary-value-param.

Author: d0k Date: Wed Jun 15 09:20:56 2016 New Revision: 272789 URL: http://llvm.org/viewvc/llvm-project?rev=272789=rev Log: Apply some suggestions from clang-tidy's performance-unnecessary-value-param. No functionality change intended. Modified: cfe/trunk/lib/AST/ASTDiagnostic.cpp

r272790 - Reverting r272777 because one of the tests

Author: rsingh Date: Wed Jun 15 09:21:28 2016 New Revision: 272790 URL: http://llvm.org/viewvc/llvm-project?rev=272790=rev Log: Reverting r272777 because one of the tests added in the llvm patch is causing an assertion to fail. Modified: cfe/trunk/include/clang/Basic/BuiltinsARM.def

Re: Buildbot numbers for the last week of 6/05/2016 - 6/11/2016

Maybe a comma-separated attachments? The tables relay positioning and font. Thanks Galina On Tue, Jun 14, 2016 at 6:59 PM, Sean Silva wrote: > Some of these tables are getting quite mangled somewhere along the line > (email client? mailing list handling? idk). Could

[clang-tools-extra] r272816 - clang-rename: implement renaming of classes with a dtor

Author: vmiklos Date: Wed Jun 15 13:35:41 2016 New Revision: 272816 URL: http://llvm.org/viewvc/llvm-project?rev=272816=rev Log: clang-rename: implement renaming of classes with a dtor The declaration wasn't renamed. Also neither part of the declaration wasn't renamed. Reviewers: klimek

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

This revision was automatically updated to reflect the committed changes. Closed by commit rL272816: clang-rename: implement renaming of classes with a dtor (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D21364?vs=60801=60869#toc Repository: rL LLVM

Re: [libcxx] r272634 - Implement variadic lock_guard.

Maybe we should add a new warning in Clang for this. -Wshadow diagnosis's this but -Wshadow isn't a part of -Wall or -Wextra so it's of limited utility. A separate warning for shadowing 'x' caused by "T(x)" might be useful. Do people actually use "T(x)" in the wild to default construct 'x'?

Re: [libcxx] r272634 - Implement variadic lock_guard.

I've had a change of heart. I think that lock_guard<> has some utility in generic code, and I'm not sure removing it is a good idea. For example a function like: template void ExecuteUnderLocks(Func&& fn, Locks&... locks) { lock_guard g(locks...); fn(); } I checked the proposal and it's

Re: [libcxx] r272634 - Implement variadic lock_guard.

Does this change (and the paper) permit declarations like the following? lock_guard<> guard(); If that syntax is allowed, then this is also likely allowed... lock_guard<>(guard); I would really like the prior two examples to not compile. Here is a common bug that I see in the

Re: r272253 - clang/test/CodeGenCXX/debug-info-method.cpp: Tweak for thiscall, for targeting Win32 x86.

On Thu, Jun 9, 2016 at 8:59 AM, David Blaikie wrote: > Reid - is this intended fallout? (seems plausible, but just checking) > > Is MinGW a good analogy for any of this work? (does it produce DWARF? Does > it use the Windows ABI? Does it emit Calling Convention attributes?) >

Re: r272253 - clang/test/CodeGenCXX/debug-info-method.cpp: Tweak for thiscall, for targeting Win32 x86.

On Wed, Jun 15, 2016 at 10:59 AM, Reid Kleckner wrote: > On Thu, Jun 9, 2016 at 8:59 AM, David Blaikie wrote: > >> Reid - is this intended fallout? (seems plausible, but just checking) >> >> Is MinGW a good analogy for any of this work? (does it produce

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Sure! LGTM http://reviews.llvm.org/D19274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r272253 - clang/test/CodeGenCXX/debug-info-method.cpp: Tweak for thiscall, for targeting Win32 x86.

On Wed, Jun 15, 2016 at 11:05 AM, David Blaikie wrote: > Perhaps we shouldn't emit it if it's the logical platform default as it > (to my naive understanding) appears to be here? > It is only the default for member functions, and member functions can be cdecl (the free

Re: [PATCH] D20347: Add support to clang-cl driver for /GS switch

rnk accepted this revision. rnk added a reviewer: rnk. rnk added a comment. lgtm Surely this is going to break something, but let's throw the switch and find out. http://reviews.llvm.org/D20347 ___ cfe-commits mailing list

Re: [PATCH] D21396: [libcxxabi] Reorder base class initializers in libc++abi tests to prevent -Wreorder

This revision was automatically updated to reflect the committed changes. Closed by commit rL272821: [libcxxabi] Reorder base class initializers in libc++abi tests to prevent… (authored by EricWF). Changed prior to commit: http://reviews.llvm.org/D21396?vs=60876=60881#toc Repository: rL

[libcxx] r272822 - Fix warning in tuple tests. The test suite should now run clean with most warnings enabled

Author: ericwf Date: Wed Jun 15 14:41:52 2016 New Revision: 272822 URL: http://llvm.org/viewvc/llvm-project?rev=272822=rev Log: Fix warning in tuple tests. The test suite should now run clean with most warnings enabled Modified:

r272825 - Add a few Musl related tests that already pass.

Author: rafael Date: Wed Jun 15 15:02:22 2016 New Revision: 272825 URL: http://llvm.org/viewvc/llvm-project?rev=272825=rev Log: Add a few Musl related tests that already pass. Patch by Lei Zhang. Modified: cfe/trunk/test/Driver/linux-ld.c Modified: cfe/trunk/test/Driver/linux-ld.c URL:

Re: [libcxx] r272634 - Implement variadic lock_guard.

On Wed, Jun 15, 2016 at 11:45 AM, Craig, Ben via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Does this change (and the paper) permit declarations like the following? > > lock_guard<> guard(); > > If that syntax is allowed, then this is also likely allowed... > >

Re: [PATCH] D21396: [libcxxabi] Reorder base class initializers in libc++abi tests to prevent -Wreorder

howard.hinnant added a comment. Look good to me. http://reviews.llvm.org/D21396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21396: [libcxxabi] Reorder base class initializers in libc++abi tests to prevent -Wreorder

EricWF created this revision. EricWF added reviewers: mclow.lists, howard.hinnant. EricWF added a subscriber: cfe-commits. This patch fixes -Wreorder warnings on test classes with virtual bases. Since the compiler is performing the reordering anyway this change *should* have NFC. However the

Re: [gentoo-musl] Re: Add support for musl-libc on Linux

r272825, Thanks, Rafael On 15 June 2016 at 04:28, Lei Zhang wrote: > 2016-06-14 20:55 GMT+08:00 Rafael Espíndola : >> On 13 June 2016 at 21:07, Lei Zhang wrote: >>> 2016-06-14 5:00 GMT+08:00 Rafael Espíndola

[PATCH] D21402: Add an Android version check for GNU strerror_r.

danalbert created this revision. danalbert added reviewers: mclow.lists, EricWF. danalbert added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer. Android didn't gain GNU's strerror_r until Marshmallow. If we're building libc++ against something older (we build

Re: [PATCH] D21338: cc1_main: Do not print statistics in -disable_free mode.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Assuming that it's guaranteed that the other path would always print out the statistics, LGTM Repository: rL LLVM http://reviews.llvm.org/D21338

Re: [libcxx] r272634 - Implement variadic lock_guard.

It would be awesome if this kind of shadowing warning could be put into -Wall. My recollection on the last set of -Wshadow reviews is that most shadowing warnings are from ctor arguments being used to initialize members. Here's the last discussion / review regarding shadowing

Re: [PATCH] D21338: cc1_main: Do not print statistics in -disable_free mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rL272820: cc1_main: Do not print statistics twice in -disable_free mode. (authored by matze). Changed prior to commit: http://reviews.llvm.org/D21338?vs=60732=60877#toc Repository: rL LLVM

[libcxxabi] r272823 - Fix warning about uninitialized const member. NFC

Author: ericwf Date: Wed Jun 15 14:48:26 2016 New Revision: 272823 URL: http://llvm.org/viewvc/llvm-project?rev=272823=rev Log: Fix warning about uninitialized const member. NFC Modified: libcxxabi/trunk/test/catch_member_data_pointer_01.pass.cpp Modified:

[libcxxabi] r272819 - Suppress warnings about the operations currently under test.

Author: ericwf Date: Wed Jun 15 14:07:19 2016 New Revision: 272819 URL: http://llvm.org/viewvc/llvm-project?rev=272819=rev Log: Suppress warnings about the operations currently under test. Modified: libcxxabi/trunk/test/catch_class_03.pass.cpp libcxxabi/trunk/test/catch_class_04.pass.cpp

[libcxxabi] r272821 - [libcxxabi] Reorder base class initializers in libc++abi tests to prevent -Wreorder

Author: ericwf Date: Wed Jun 15 14:33:01 2016 New Revision: 272821 URL: http://llvm.org/viewvc/llvm-project?rev=272821=rev Log: [libcxxabi] Reorder base class initializers in libc++abi tests to prevent -Wreorder Summary: This patch fixes -Wreorder warnings on test classes with virtual bases.

[libcxxabi] r272824 - Fix [libcxxabi] Fix warning about uninitialized const member.

Author: ericwf Date: Wed Jun 15 14:59:16 2016 New Revision: 272824 URL: http://llvm.org/viewvc/llvm-project?rev=272824=rev Log: Fix [libcxxabi] Fix warning about uninitialized const member. Modified: libcxxabi/trunk/test/catch_member_data_pointer_01.pass.cpp Modified:

Re: [libcxx] r272634 - Implement variadic lock_guard.

On 6/15/2016 1:15 PM, Eric Fiselier wrote: On Wed, Jun 15, 2016 at 11:45 AM, Craig, Ben via cfe-commits > wrote: Does this change (and the paper) permit declarations like the following? lock_guard<> guard();

Re: [libcxx] r272634 - Implement variadic lock_guard.

Makes sense. Here's hoping parameter deduction for constructors makes it in! (better link) http://open-std.org/JTC1/SC22/WG21/docs/papers/2016/p0091r2.html On 6/15/2016 1:54 PM, Eric Fiselier wrote: I've had a change of heart. I think that lock_guard<> has some utility in generic code,

Re: [PATCH] D21268: [x86] translate SSE packed FP comparison builtins to IR

This revision was automatically updated to reflect the committed changes. Closed by commit rL272840: [x86] translate SSE packed FP comparison builtins to IR (authored by spatel). Changed prior to commit: http://reviews.llvm.org/D21268?vs=60473=60905#toc Repository: rL LLVM

r272840 - [x86] translate SSE packed FP comparison builtins to IR

Author: spatel Date: Wed Jun 15 16:20:04 2016 New Revision: 272840 URL: http://llvm.org/viewvc/llvm-project?rev=272840=rev Log: [x86] translate SSE packed FP comparison builtins to IR As noted in the code comment, a potential follow-on would be to remove the builtins themselves. Other than

Re: [PATCH] D19754: Allow 'nodebug' on local variables

This revision was automatically updated to reflect the committed changes. Closed by commit rL272859: Allow 'nodebug' on local variables. (authored by probinson). Changed prior to commit: http://reviews.llvm.org/D19754?vs=60930=60940#toc Repository: rL LLVM http://reviews.llvm.org/D19754

r272862 - [DebugInfo] Enable generation of unique identifiers for externally visible MS ABI types

Author: rnk Date: Wed Jun 15 20:21:28 2016 New Revision: 272862 URL: http://llvm.org/viewvc/llvm-project?rev=272862=rev Log: [DebugInfo] Enable generation of unique identifiers for externally visible MS ABI types We implemented the mangling for this a long time ago. Added:

Re: [PATCH] D21402: Add an Android version check for GNU strerror_r.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. I would have preferred to always use the POSIX version, but it's impossible to turn of GNU extensions without breaking the linux build. http://reviews.llvm.org/D21402

r272867 - [Lex] Try to fix a 'comparison is always false' warning. NFC.

Author: gbiv Date: Wed Jun 15 21:30:33 2016 New Revision: 272867 URL: http://llvm.org/viewvc/llvm-project?rev=272867=rev Log: [Lex] Try to fix a 'comparison is always false' warning. NFC. Modified: cfe/trunk/lib/Lex/PPDirectives.cpp Modified: cfe/trunk/lib/Lex/PPDirectives.cpp URL:

[libcxx] r272827 - Add an Android version check for GNU strerror_r.

Author: danalbert Date: Wed Jun 15 15:20:32 2016 New Revision: 272827 URL: http://llvm.org/viewvc/llvm-project?rev=272827=rev Log: Add an Android version check for GNU strerror_r. Summary: Android didn't gain GNU's strerror_r until Marshmallow. If we're building libc++ against something older

Re: [PATCH] D21402: Add an Android version check for GNU strerror_r.

This revision was automatically updated to reflect the committed changes. Closed by commit rL272827: Add an Android version check for GNU strerror_r. (authored by danalbert). Changed prior to commit: http://reviews.llvm.org/D21402?vs=60887=60893#toc Repository: rL LLVM

r272832 - Add support to clang-cl driver for /GS switch

Author: etienneb Date: Wed Jun 15 15:34:33 2016 New Revision: 272832 URL: http://llvm.org/viewvc/llvm-project?rev=272832=rev Log: Add support to clang-cl driver for /GS switch Summary: This patch is adding command-line support for the MSVC buffer security check. The buffer security check is

Re: [clang-tools-extra] r272816 - clang-rename: implement renaming of classes with a dtor

Miklos, TokenName produces unused variable warning in builds with asserts disabled. Could you add LLVM_ATTRIBUTE_UNUSED to it? Thanks, --Artem On Wed, Jun 15, 2016 at 11:35 AM, Miklos Vajna via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: vmiklos > Date: Wed Jun 15 13:35:41 2016

[PATCH] D21407: Enable building and using atomic shared_ptr for GCC.

EricWF created this revision. EricWF added reviewers: mclow.lists, rmaprath. EricWF added a subscriber: cfe-commits. Currently the implementation of [util.smartptr.shared.atomic] is provided only when using Clang, and not with GCC. This is a relic of not having a GCC implementation of , even

Re: [PATCH] D21030: [Sema] Fix rejects-valid where parameter pack was not expanded in type alias

erik.pilkington updated this revision to Diff 60908. erik.pilkington added a comment. This new patch replaces the call to `RebuildPackExpansion` with a direct call to `getPackExpansionType`. Also use `None` instead of `NumExpansions` as argument. As far as the `assert(*NumExpansions == 1)`, I

Re: [PATCH] D20748: Handle recursion in LLVMIRGeneration Timer

davide added a comment. ping? http://reviews.llvm.org/D20748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r272853 - Fix linking of DFSan + coverage.

Author: eugenis Date: Wed Jun 15 18:05:21 2016 New Revision: 272853 URL: http://llvm.org/viewvc/llvm-project?rev=272853=rev Log: Fix linking of DFSan + coverage. Broken in r272717 because of no test coverage. Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp

Re: [clang-tools-extra] r272816 - clang-rename: implement renaming of classes with a dtor

Should be fixed in r272852 --Artem On Wed, Jun 15, 2016 at 3:16 PM, Artem Belevich wrote: > Miklos, > > TokenName produces unused variable warning in builds with asserts disabled. > Could you add LLVM_ATTRIBUTE_UNUSED to it? > > Thanks, > --Artem > > > On Wed, Jun 15, 2016 at

Re: [PATCH] D17462: Fix a codegen bug for variadic functions with pass_object_size params

george.burgess.iv added a comment. (: ƃuıd http://reviews.llvm.org/D17462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21419: [CUDA] Don't pass top-level -march down to device cc1 or ptxas.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: echristo, cfe-commits. Previously if you did e.g. $ clang -march=haswell -x cuda foo.cu we would pass "-march=haswell -march=sm_20" down to the ptxas tool. This causes it to assert, and rightly so!

Re: [PATCH] D21390: redefinition of '__true_type' struct __true_type {}; - Bug 27991

rsmith accepted this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision is now accepted and ready to land. Makes sense to me. Repository: rL LLVM http://reviews.llvm.org/D21390 ___ cfe-commits mailing list

Re: [PATCH] D21419: [CUDA] Don't pass top-level -march down to device cc1 or ptxas.

jlebar updated this revision to Diff 60931. jlebar added a comment. Remove redundant test. http://reviews.llvm.org/D21419 Files: lib/Driver/ToolChains.cpp test/Driver/cuda-march.cu Index: test/Driver/cuda-march.cu === ---

Re: [PATCH] D21419: [CUDA] Don't pass top-level -march down to device cc1 or ptxas.

jlebar added inline comments. Comment at: test/Driver/cuda-march.cu:15-16 @@ +14,4 @@ + +// RUN: %clang -### -target x86_64-linux-gnu -c -march=skylake --cuda-gpu-arch=sm_30 %s 2>&1 | \ +// RUN: FileCheck -check-prefix SKYLAKE -check-prefix SM30 %s + tra wrote:

  1   2   >