Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Looks almost good now, a few comments. You'd better await for comments from @alexfh or @sbenza before committing. Comment at:

Re: [PATCH] D20979: [OpenCL] Use function metadata to represent kernel attributes

yaxunl added inline comments. Comment at: test/CodeGenOpenCL/kernel-attributes.cl:9 @@ -8,3 +10,1 @@ -// CHECK: opencl.kernels = !{[[MDNODE0:![0-9]+]], [[MDNODE3:![0-9]+]]} - bader wrote: > AFAIK, this named metadata node were also useful for kernel functions

Re: [PATCH] D21517: clang-rename: add a -old-name option

klimek added inline comments. Comment at: clang-rename/USRFinder.h:28-33 @@ -27,6 +27,8 @@ -// Given an AST context and a point, returns a NamedDecl identifying the symbol -// at the point. Returns null if nothing is found at the point. +// Given an AST context and a point (or

Re: [PATCH] D21517: clang-rename: add a -old-name option

vmiklos updated this revision to Diff 61255. vmiklos added a comment. Added a getNamedDeclFor() for the fully qualified name-based search. http://reviews.llvm.org/D21517 Files: clang-rename/USRFinder.cpp clang-rename/USRFinder.h clang-rename/USRFindingAction.cpp

r273159 - [modules] Allow emission of update records for predefined __va_list_tag.

Author: vvassilev Date: Mon Jun 20 10:10:40 2016 New Revision: 273159 URL: http://llvm.org/viewvc/llvm-project?rev=273159=rev Log: [modules] Allow emission of update records for predefined __va_list_tag. Handles the cases where old __va_list_tag is coming from a module and the new is not,

Re: [PATCH] D21507: Changes after running check modernize-use-emplace (D20964)

jlebar added a subscriber: jlebar. jlebar added a comment. There seem to be many nontrivial whitespace errors introduced by this patch. For example, -Attrs.push_back(HTMLStartTagComment::Attribute(Ident.getLocation(), -

Re: [libcxx] r249738 - Split out of .

On 17/10/15 01:27, Richard Smith via cfe-commits wrote: On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl > wrote: On Oct 14, 2015, at 5:07 PM, Richard Smith > wrote: Ack, there are

Re: [PATCH] D20979: [OpenCL] Use function metadata to represent kernel attributes

bader accepted this revision. bader added a comment. LGTM. Comment at: test/CodeGenOpenCL/kernel-attributes.cl:9 @@ -8,3 +10,1 @@ -// CHECK: opencl.kernels = !{[[MDNODE0:![0-9]+]], [[MDNODE3:![0-9]+]]} - AFAIK, this named metadata node were also useful for

Re: [PATCH] D20979: [OpenCL] Use function metadata to represent kernel attributes

yaxunl added a comment. Ping! Alexey/Xiuli, are you OK with this change? Thanks. http://reviews.llvm.org/D20979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21453: Add support for attribute "overallocated"

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:2279 @@ +2278,3 @@ + let Spellings = [GNU<"overallocated">, CXX11<"clang", "overallocated">]; + let Subjects = SubjectList<[Record], ErrorDiag, "ExpectedStructOrUnion">; + let Documentation =

Re: [PATCH] D21505: [Clang][AVX512][Intrinsics]Adding intrinsics for mov{ss|sd} instruction set

m_zuckerman updated this revision to Diff 61250. http://reviews.llvm.org/D21505 Files: lib/Headers/avx512fintrin.h test/CodeGen/avx512f-builtins.c Index: test/CodeGen/avx512f-builtins.c === --- test/CodeGen/avx512f-builtins.c

r273158 - Make test less sensitive to the resource directory.

Author: probinson Date: Mon Jun 20 09:33:49 2016 New Revision: 273158 URL: http://llvm.org/viewvc/llvm-project?rev=273158=rev Log: Make test less sensitive to the resource directory. Same tactic as linux-header-search.cpp and android-ndk-standalone.cpp. Modified:

Re: [PATCH] D21506: [analyzer] Block in critical section

NoQ added a comment. Useful stuff! When I see your approach with `mutexCount`, the following test case comes to mind: std::mutex m; void foo() { // Suppose this function is always called // with the mutex 'm' locked. m.unlock(); // Here probably some useful work is done.

Re: [PATCH] D21367: AMDGPU: Set amdgpu_kernel calling convention for OpenCL kernels.

nhaustov added a comment. In http://reviews.llvm.org/D21367#461480, @tstellarAMD wrote: > Does this new patch fix the OpenCL regression? Yes, it fixes the problem with calling kernel from kernel. I'll add a test too. http://reviews.llvm.org/D21367

Re: [PATCH] D21367: AMDGPU: Set amdgpu_kernel calling convention for OpenCL kernels.

nhaustov updated this revision to Diff 61247. nhaustov added a comment. Add test for calling OpenCL kernel from kernel. http://reviews.llvm.org/D21367 Files: include/clang/AST/Type.h include/clang/Basic/Specifiers.h lib/AST/ItaniumMangle.cpp lib/AST/Type.cpp lib/AST/TypePrinter.cpp

Re: [gentoo-musl] Re: Add support for musl-libc on Linux

From what I can see, the EABI type is used to decide if certain __aeabi_ prefixed functions such as __aeabi_idiv are available. If Musl differs in function availability from the GNU library here I think you'll need a Musl EABI type. However if there is no difference you should be able to use the

Re: [gentoo-musl] Re: Add support for musl-libc on Linux

2016-06-18 8:52 GMT+08:00 Rafael Espíndola : > There are probably a few more places that need to be patched. > > In particular, take a look at lib/Target/ARM. There are things like > computeTargetABI and isTargetHardFloat that probably need to be > updated (and tested).

Re: [PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

berenm added a comment. Thanks! The operators are now correctly handled. Another thing I've found is that constructors aren't aligned either with other declarations or either together. Do you think it would be possible to treat them as functions as well? Friend functions also aren't aligned

r273150 - Add -fsyntax-only to Driver/opencl.cl test.

Author: congliu Date: Mon Jun 20 06:25:26 2016 New Revision: 273150 URL: http://llvm.org/viewvc/llvm-project?rev=273150=rev Log: Add -fsyntax-only to Driver/opencl.cl test. Modified: cfe/trunk/test/Driver/opencl.cl Modified: cfe/trunk/test/Driver/opencl.cl URL:

Re: [musl] Re: [gentoo-musl] Re: Add support for musl-libc on Linux

* Lei Zhang [2016-06-20 18:59:20 +0800]: > 2016-06-20 17:37 GMT+08:00 Peter Smith : > > - isTargetEHABICompatible() > > I'm making the assumption that musl supports the ARM exceptions EHABI, > > if so you'll want to add MUSL and MUSLHF here. > >

r273147 - [X86] Add -mno-iamcu option.

Author: aturetsk Date: Mon Jun 20 05:31:39 2016 New Revision: 273147 URL: http://llvm.org/viewvc/llvm-project?rev=273147=rev Log: [X86] Add -mno-iamcu option. Add -mno-iamcu option to: 1) Countervail -miamcu option easily 2) Be compatible with GCC which supports this option Differential

Re: [PATCH] D21469: Add -mno-iamcu option

This revision was automatically updated to reflect the committed changes. Closed by commit rL273147: [X86] Add -mno-iamcu option. (authored by aturetsk). Changed prior to commit: http://reviews.llvm.org/D21469?vs=61088=61245#toc Repository: rL LLVM http://reviews.llvm.org/D21469 Files:

Re: [gentoo-musl] Re: Add support for musl-libc on Linux

2016-06-20 19:44 GMT+08:00 Peter Smith : > From what I can see, the EABI type is used to decide if certain > __aeabi_ prefixed functions such as __aeabi_idiv are available. If > Musl differs in function availability from the GNU library here I > think you'll need a Musl

Re: [gentoo-musl] Re: Add support for musl-libc on Linux

2016-06-20 17:37 GMT+08:00 Peter Smith : > Hello Lei, Hi, thanks for your reply! > I agree with Rafael that this is currently missing a few critical > things right now, especially in the llvm patch. > > My (limited) understanding of musl is that it intends to support the

Re: [PATCH] D21224: [Driver] Add method to redirect output of Compilation.

nhaustov added a comment. Ping. http://reviews.llvm.org/D21224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r273147 - [X86] Add -mno-iamcu option.

Hi Andrey, On Mon, Jun 20, 2016 at 3:31 AM, Andrey Turetskiy via cfe-commits wrote: > Author: aturetsk > Date: Mon Jun 20 05:31:39 2016 > New Revision: 273147 > > URL: http://llvm.org/viewvc/llvm-project?rev=273147=rev > Log: > [X86] Add -mno-iamcu option. > > Add

Re: [PATCH] D19184: Remove MaxFunctionCount module flag annotation

eraman added a comment. This patch and the one in http://reviews.llvm.org/D19185 are now ready to land as the inliner now uses ProfileSummaryInfo. I will check them in. http://reviews.llvm.org/D19184 ___ cfe-commits mailing list

Re: [PATCH] D20923: [Sema] Fix a crash on invalid where invalid defaulted function is called

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman http://reviews.llvm.org/D20923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20939: Update for DiagnosticInfoStackSize changes

arsenm accepted this revision. arsenm added a reviewer: arsenm. arsenm added a comment. This revision is now accepted and ready to land. r273178 http://reviews.llvm.org/D20939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r273193 - [Sema] Only define function as move assignment when needed

Author: epilk Date: Mon Jun 20 15:04:15 2016 New Revision: 273193 URL: http://llvm.org/viewvc/llvm-project?rev=273193=rev Log: [Sema] Only define function as move assignment when needed Fixes PR27941, a crash on invalid. Differential revision: http://reviews.llvm.org/D20923 Modified:

Re: [libcxx] r273034 - Add Filesystem TS -- Complete

Eric, Some tests appear to fail if the path to the tests' current directory has some symlinks in it. In my case source and build tree are in directory 'work' that's symlinked to from my home directory: /usr/local/home/tra/work -> /work/tra This causes multiple failures in libcxx tests. One

r273198 - Remove MaxFunctionCount module flag annotation.

Author: eraman Date: Mon Jun 20 15:48:32 2016 New Revision: 273198 URL: http://llvm.org/viewvc/llvm-project?rev=273198=rev Log: Remove MaxFunctionCount module flag annotation. Differential revision: http://reviews.llvm.org/D19184 Removed: cfe/trunk/test/Profile/max-function-count.c

Re: [PATCH] D21507: Changes after running check modernize-use-emplace (D20964)

Prazek added a comment. In http://reviews.llvm.org/D21507#462210, @jlebar wrote: > There seem to be many nontrivial whitespace errors introduced by this patch. > For example, > > -Attrs.push_back(HTMLStartTagComment::Attribute(Ident.getLocation(), > -

r273196 - clang-format: [Proto] Fix "import public" after r273179.

Author: djasper Date: Mon Jun 20 15:39:53 2016 New Revision: 273196 URL: http://llvm.org/viewvc/llvm-project?rev=273196=rev Log: clang-format: [Proto] Fix "import public" after r273179. Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp cfe/trunk/unittests/Format/FormatTestProto.cpp

Re: [PATCH] D20923: [Sema] Fix a crash on invalid where invalid defaulted function is called

This revision was automatically updated to reflect the committed changes. Closed by commit rL273193: [Sema] Only define function as move assignment when needed (authored by epilk). Changed prior to commit: http://reviews.llvm.org/D20923?vs=59409=61296#toc Repository: rL LLVM

Re: [PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

bmharper added a comment. I've taken some time to investigate those two issues, and these are my thoughts: 1. Constructor alignment: I think this is a good thing to do, but if `isFunctionDeclarationName`, and it's caller `TokenAnnotator::calculateFormattingInformation` are anything to go by,

Re: [libcxx] r273034 - Add Filesystem TS -- Complete

Oh shoot, I definitely didn't take that into account. I'll put together a fix. /Eric On Mon, Jun 20, 2016 at 2:27 PM, Artem Belevich wrote: > Eric, > > Some tests appear to fail if the path to the tests' current directory has > some symlinks in it. > In my case source and

Re: [PATCH] D19184: Remove MaxFunctionCount module flag annotation

This revision was automatically updated to reflect the committed changes. Closed by commit rL273198: Remove MaxFunctionCount module flag annotation. (authored by eraman). Changed prior to commit: http://reviews.llvm.org/D19184?vs=53969=61302#toc Repository: rL LLVM

[PATCH] D21545: CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.

pcc created this revision. pcc added reviewers: tejohnson, mehdi_amini. pcc added a subscriber: cfe-commits. pcc added dependencies: D21542: CodeGen: Replace test/CodeGen/thinlto_backend.c with a functional test., D20268: [wip] Resolution-based LTO API., D21537: Frontend: Simplify ownership

[PATCH] D21547: Added calculateRangesAfterReplaments() to calculate affacted ranges in the new code.

ioeric created this revision. ioeric added reviewers: djasper, klimek. ioeric added a subscriber: cfe-commits. Herald added a subscriber: klimek. Added calculateRangesAfterReplaments() to calculate original ranges as well as newly affacted ranges in the new code. http://reviews.llvm.org/D21547

Re: [gentoo-musl] Re: Add support for musl-libc on Linux

Hello Lei, I agree with Rafael that this is currently missing a few critical things right now, especially in the llvm patch. My (limited) understanding of musl is that it intends to support the same interface as GNUEABI and GNUEABIHF, but it is obviously a different implementation. This is what

Re: [Patch] Add a ENABLE_X86_RELAX_RELOCATIONS cmake option

Patch LGTM. -Chris > On Jun 17, 2016, at 12:36 PM, Rafael Espíndola > wrote: > > This corresponds to binutils' --enable-x86-relax-relocations. > > Cheers, > Rafael > <0001-Add-a-ENABLE_X86_RELAX_RELOCATIONS-cmake-option.patch>

Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

ashi1 updated this revision to Diff 61275. ashi1 marked 2 inline comments as done. ashi1 added a comment. Revised with Anastasia's comments. Please take a look at the diagnostic to see if it is what we want. http://reviews.llvm.org/D21031 Files:

r273190 - [OpenMP] Add the nowait clause to target update construct.

Author: kli Date: Mon Jun 20 14:16:34 2016 New Revision: 273190 URL: http://llvm.org/viewvc/llvm-project?rev=273190=rev Log: [OpenMP] Add the nowait clause to target update construct. Differential Revision: http://reviews.llvm.org/D21477 Added:

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

This revision was automatically updated to reflect the committed changes. Closed by commit rL273191: [OpenCL] Include opencl-c.h by default as a clang module (authored by yaxunl). Changed prior to commit: http://reviews.llvm.org/D20444?vs=60568=61290#toc Repository: rL LLVM

r273191 - [OpenCL] Include opencl-c.h by default as a clang module

Author: yaxunl Date: Mon Jun 20 14:26:00 2016 New Revision: 273191 URL: http://llvm.org/viewvc/llvm-project?rev=273191=rev Log: [OpenCL] Include opencl-c.h by default as a clang module Include opencl-c.h by default as a module to utilize the automatic AST caching mechanism of clang modules.

r273179 - clang-format: [Proto] Don't do bad things if imports are missing ; .

Author: djasper Date: Mon Jun 20 13:20:38 2016 New Revision: 273179 URL: http://llvm.org/viewvc/llvm-project?rev=273179=rev Log: clang-format: [Proto] Don't do bad things if imports are missing ;. Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp

Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

ashi1 marked 6 inline comments as done. ashi1 added a comment. F2085685: D21031.patch Comment at: include/clang/Driver/CC1Options.td:670 @@ -669,21 +669,3 @@ -def cl_opt_disable : Flag<["-"], "cl-opt-disable">, - HelpText<"OpenCL only. This

Re: [PATCH] D21506: [analyzer] Block in critical section

zaks.anna added a comment. Thanks for the patch! Have you run this on a large codebase? Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:406 @@ +405,3 @@ +def BlockInCriticalSectionChecker : Checker<"BlockInCriticalSection">, + HelpText<"Check for blocks in

r273230 - clang/test/Headers/opencl-c-header.cl: Add explicit -triple x86_64-unknown to appease *-win32 targets.

Author: chapuni Date: Mon Jun 20 20:54:54 2016 New Revision: 273230 URL: http://llvm.org/viewvc/llvm-project?rev=273230=rev Log: clang/test/Headers/opencl-c-header.cl: Add explicit -triple x86_64-unknown to appease *-win32 targets. :9:25: note: possible intended match here %call = tail

r273232 - [Docs] More warning fixes to unbreak the docs buildbot.

Author: gbiv Date: Mon Jun 20 21:19:43 2016 New Revision: 273232 URL: http://llvm.org/viewvc/llvm-project?rev=273232=rev Log: [Docs] More warning fixes to unbreak the docs buildbot. A number of warnings still remain, but these were the last of the "unlexable code"-related ones (AFAICT). I

r273237 - [CodeGen] Do not run initializers for imported variables

Author: majnemer Date: Mon Jun 20 22:40:16 2016 New Revision: 273237 URL: http://llvm.org/viewvc/llvm-project?rev=273237=rev Log: [CodeGen] Do not run initializers for imported variables The export side is responsible for running any initializers, they are run when the module is first loaded.

r273239 - r273237 fixed PR28220, not PR28216

Author: majnemer Date: Mon Jun 20 22:43:11 2016 New Revision: 273239 URL: http://llvm.org/viewvc/llvm-project?rev=273239=rev Log: r273237 fixed PR28220, not PR28216 Added: cfe/trunk/test/CodeGenCXX/PR28220.cpp - copied, changed from r273237, cfe/trunk/test/CodeGenCXX/PR28216.cpp

Re: [libcxx] r273034 - Add Filesystem TS -- Complete

Hi Artem, Sorry for the delay, I've been busy with school all day. I'll check in a fix tomorrow morning. Sorry again, /Eric On Mon, Jun 20, 2016 at 2:31 PM, Eric Fiselier wrote: > Oh shoot, I definitely didn't take that into account. I'll put together a > fix. > > /Eric > > > >

[PATCH] D21542: CodeGen: Replace test/CodeGen/thinlto_backend.c with a functional test.

pcc created this revision. pcc added a reviewer: tejohnson. pcc added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. This new test tests that functions are capable of being imported, rather than that the import pass is run. This new test is compatible with the approach being

r273227 - [Docs] Try to fix the docs buildbot.

Author: gbiv Date: Mon Jun 20 19:16:23 2016 New Revision: 273227 URL: http://llvm.org/viewvc/llvm-project?rev=273227=rev Log: [Docs] Try to fix the docs buildbot. It's complaining that it couldn't lex a compiler warning as C++. I don't blame it. Modified:

Re: [PATCH] D21544: [MS] Don't expect vftables to be provided for extern template instantiations

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D21544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21542: CodeGen: Replace test/CodeGen/thinlto_backend.c with a functional test.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM but with one question: Any issue with IR tests in clang tests? I noticed that there are very few (although there is already one existing .ll in test/CodeGen).

[PATCH] D21544: [MS] Don't expect vftables to be provided for extern template instantiations

rnk created this revision. rnk added a reviewer: majnemer. rnk added a subscriber: cfe-commits. MSVC doesn't provide them. PR28223 I left behind the machinery in case we want to resurrect available_externally vftable emission to support devirtualization. http://reviews.llvm.org/D21544 Files:

Re: [PATCH] D21228: Deprecated (legacy) string literal conversion to 'char *' causes strange overloading resolution

a.makarov added a comment. Ping. http://reviews.llvm.org/D21228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21497: Fix test to specify C++03 (fails with C++11).

probinson abandoned this revision. probinson added a comment. A proper fix is obviously better than patching the test! http://reviews.llvm.org/D21497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D21517: clang-rename: add a -old-name option

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. This is similar to -offset with the following differences: 1) -offset can refer to local variables as well. 2) -old-name makes it easier to refer to e.g. ClassName::MemberName by

[PATCH] D21537: Frontend: Simplify ownership model for clang's output streams.

pcc created this revision. pcc added a reviewer: rsmith. pcc added a subscriber: cfe-commits. This changes the CompilerInstance::createOutputFile function to return a std::unique_ptr, rather than an llvm::raw_ostream implicitly owned by the CompilerInstance. This in most cases required that I

Re: [PATCH] D21537: Frontend: Simplify ownership model for clang's output streams.

pcc updated this revision to Diff 61317. pcc added a comment. - Move EmitAssemblyHelper's pass managers into CreatePasses http://reviews.llvm.org/D21537 Files: include/clang/CodeGen/BackendUtil.h include/clang/CodeGen/ObjectFilePCHContainerOperations.h

Re: [PATCH] D20647: Add flag to add InlineHint attribute on implicitly inline functions

Ilod updated this revision to Diff 61318. Ilod added a comment. New patch, which instead add NoInline to function not marked (implicitly or explicitly) inline, when we use the -finline-hint-functions flag (effectily inlining only implicitly and explicitly inline functions). Also adds support

r273224 - Add a ENABLE_X86_RELAX_RELOCATIONS cmake option.

Author: rafael Date: Mon Jun 20 18:54:44 2016 New Revision: 273224 URL: http://llvm.org/viewvc/llvm-project?rev=273224=rev Log: Add a ENABLE_X86_RELAX_RELOCATIONS cmake option. This corresponds to binutils' --enable-x86-relax-relocations. Modified: cfe/trunk/CMakeLists.txt