r273994 - Revert r273950, (empty). Please recommit it with readable commit message.

Author: chapuni Date: Tue Jun 28 01:10:54 2016 New Revision: 273994 URL: http://llvm.org/viewvc/llvm-project?rev=273994=rev Log: Revert r273950, (empty). Please recommit it with readable commit message. Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trunk/lib/Basic/Targets.cpp URL:

[clang-tools-extra] r273993 - clang-rename: Update libdeps corresponding to r273910.

Author: chapuni Date: Tue Jun 28 01:08:10 2016 New Revision: 273993 URL: http://llvm.org/viewvc/llvm-project?rev=273993=rev Log: clang-rename: Update libdeps corresponding to r273910. Modified: clang-tools-extra/trunk/clang-rename/tool/CMakeLists.txt Modified:

Re: r273950 -

Reverted it in r273994. I expect you may recommit it. ;) On Tue, Jun 28, 2016 at 9:12 AM Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Did you land this intentionally? What was the commit message supposed to > be? > > On Mon, Jun 27, 2016 at 6:11 PM, Chris Dewhurst via

Re: r273911 - [ExprConstant] Fix PR28314 - crash while evluating objectsize.

+Richard, Hans This patch fixes a crash that's also present in Clang 3.8. So, I think it should find its way into 3.8.2, if possible. Thank you! :) -- Forwarded message -- From: George Burgess IV via cfe-commits Date: Mon, Jun 27, 2016 at 12:40 PM

Re: [PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

bmharper added a comment. Friendly PING. Please let me know if there's anything else that I need to do here, otherwise I'll keep quiet and expect a merge at some point? Repository: rL LLVM http://reviews.llvm.org/D21279 ___ cfe-commits mailing

Re: [PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

djasper added a comment. Sorry.. Really busy at the moment, but will try to get this reviewed and submitted this week. If not, please ping again! Repository: rL LLVM http://reviews.llvm.org/D21279 ___ cfe-commits mailing list

Re: [PATCH] D21224: [Driver] Add method to redirect output of Compilation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL273997: [Driver] Add method to redirect output of Compilation. (authored by nhaustov). Changed prior to commit: http://reviews.llvm.org/D21224?vs=60333=62066#toc Repository: rL LLVM

Re: [PATCH] D21603: [include-fixer] Fix namespace after inserting a missing header.

djasper added a comment. Sorry, I completely forgot about this. Will try to review today. Is this part about the patch description accurate? "This version only fixes the first discovered unidentified symbol. In the long run, include-fixer should fix all unidentified symbols with a same name at

Re: [PATCH] D21502: Fix heuristics skipping invalid ctor-initializers with C++11

ogoffart added a comment. Ping. The problem i'm fixing here is how we recover invalid code in the ctor-init part as we skip the function body. In particular, we want to know if the '{' is the begining of the body or not. In C++03, we always consider it as the beginng of the body. The problem

Re: [PATCH] D21642: [clang-tidy] boost-use-to-string arg expr location bugfix

alexfh added inline comments. Comment at: test/clang-tidy/boost-use-to-string.cpp:154 @@ +153,3 @@ + float floating; + Fields* wierd; + const int () const {return integer;} alexfh wrote: > "wierd" is weird ;) I should have been more clear in the first place:

Re: [PATCH] D21642: [clang-tidy] boost-use-to-string arg expr location bugfix

This revision was automatically updated to reflect the committed changes. Closed by commit rL274001: [clang-tidy] boost-use-to-string arg expr location bugfix (authored by Prazek). Changed prior to commit: http://reviews.llvm.org/D21642?vs=61665=62069#toc Repository: rL LLVM

[clang-tools-extra] r274001 - [clang-tidy] boost-use-to-string arg expr location bugfix

Author: prazek Date: Tue Jun 28 03:16:20 2016 New Revision: 274001 URL: http://llvm.org/viewvc/llvm-project?rev=274001=rev Log: [clang-tidy] boost-use-to-string arg expr location bugfix Summary: getExprLoc returns location after dot for member call. Reviewers: alexfh, sbenza, hokein

Re: [PATCH] D21783: [CodeView] Implement support for bitfields in Clang

aaboud added a comment. Looks good, one minor comments below. Comment at: lib/CodeGen/CGDebugInfo.h:243 @@ +242,3 @@ + llvm::DIScope *RecordTy, + const RecordDecl *RD, SourceLocation Loc); +

Re: [PATCH] D21601: Make tooling::applyAllReplacements return llvm::Expected instead of empty string to indicate potential error.

ioeric marked 3 inline comments as done. ioeric added a comment. Friendly ping http://reviews.llvm.org/D21601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21507: Changes after running check modernize-use-emplace (D20964)

Prazek added a comment. In http://reviews.llvm.org/D21507#465733, @sanjoy wrote: > One other thing to point out -- have you verified that the changes in > `unittests/` are benign (i.e. you're not semantically changing the tests)? Yes I do. Repository: rL LLVM

[libcxx] r274018 - Use WG21.link reflector to get to issues, rather than linking directly

Author: marshall Date: Tue Jun 28 09:13:28 2016 New Revision: 274018 URL: http://llvm.org/viewvc/llvm-project?rev=274018=rev Log: Use WG21.link reflector to get to issues, rather than linking directly Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html

[PATCH] D21792: [Clang][Feature] Adding CLFLUSHOPT feature and intrinsic to clang

m_zuckerman created this revision. m_zuckerman added reviewers: AsafBadouh, igorb, delena. m_zuckerman added a subscriber: cfe-commits. http://reviews.llvm.org/D21792 Files: include/clang/Basic/BuiltinsX86.def lib/Headers/CMakeLists.txt lib/Headers/clflushoptintrin.h

Re: [PATCH] D21075: Correct invalid end location in diagnostics for some identifiers.

klimek added inline comments. Comment at: lib/Sema/SemaType.cpp:1339 @@ +1338,3 @@ +auto R = DS.getSourceRange(); +if (R.getEnd().isInvalid()) + R.setEnd(R.getBegin()); Do you know in which cases we get source ranges that are half valid?

Re: [PATCH] D21737: [PATCH] [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else.

mehdi_amini requested changes to this revision. mehdi_amini added a comment. This revision now requires changes to proceed. Missing test. Repository: rL LLVM http://reviews.llvm.org/D21737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r274015 - [ASTMatchers] Add isLambda() matcher.

Author: sbenza Date: Tue Jun 28 09:08:56 2016 New Revision: 274015 URL: http://llvm.org/viewvc/llvm-project?rev=274015=rev Log: [ASTMatchers] Add isLambda() matcher. Modified: cfe/trunk/docs/LibASTMatchersReference.html cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D21795: [OpenCL] Add attribute 'pure' to read_image built-in functions to enable optimizations.

bader created this revision. bader added reviewers: Anastasia, yaxunl. bader added subscribers: cfe-commits, pxli168, pekka.jaaskelainen. http://reviews.llvm.org/D21795 Files: lib/Headers/opencl-c.h Index: lib/Headers/opencl-c.h

Re: [PATCH] D21145: [Sema] Fix crash on valid where instantiation of lambda cannot access type of 'this'

erik.pilkington added a comment. Okay, thanks! I'll add the assert in. @rsmith: Any thoughts on this? http://reviews.llvm.org/D21145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21744: [OpenCL] Fix code generation of kernel pipe parameters.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lib/CodeGen/CodeGenFunction.cpp:535 @@ -531,3 +534,3 @@ if (isPipe) -baseTypeName = -

Re: [PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

cameron314 added a comment. Anyone have a few minutes to look at this? http://reviews.llvm.org/D20338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21744: [OpenCL] Fix code generation of kernel pipe parameters.

bader updated this revision to Diff 62100. bader added a comment. Re-format the patch. No functional changes. http://reviews.llvm.org/D21744 Files: lib/CodeGen/CodeGenFunction.cpp test/CodeGenOpenCL/pipe_types.cl Index: test/CodeGenOpenCL/pipe_types.cl

Re: [PATCH] D21277: Resubmit r270688: Using new TargetParser in Clang.

mehdi_amini added a comment. Why was it closed? Was it committed? It'd be nice to have a comment with the closing action. Repository: rL LLVM http://reviews.llvm.org/D21277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r273911 - [ExprConstant] Fix PR28314 - crash while evluating objectsize.

+Tom who does the "dot" releases. I don't know if he's planning for a 3.8.2, but just in case, I suppose it's on the radar now :-) Thanks, Hans On Mon, Jun 27, 2016 at 11:21 PM, George Burgess IV wrote: > +Richard, Hans > > This patch fixes a crash that's also

Re: [PATCH] D21783: [CodeView] Implement support for bitfields in Clang

majnemer updated this revision to Diff 62095. majnemer added a comment. - Address review comments http://reviews.llvm.org/D21783 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGen/debug-info-packed-struct.c test/CodeGenCXX/debug-info-ms-bitfields.cpp Index:

[libcxx] r274016 - Updated C++1Z status page with new work from Oulu WG21 meeting

Author: marshall Date: Tue Jun 28 09:11:54 2016 New Revision: 274016 URL: http://llvm.org/viewvc/llvm-project?rev=274016=rev Log: Updated C++1Z status page with new work from Oulu WG21 meeting Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL:

[clang-tools-extra] r274019 - [clang-tidy] Do not match on lambdas.

Author: sbenza Date: Tue Jun 28 09:19:41 2016 New Revision: 274019 URL: http://llvm.org/viewvc/llvm-project?rev=274019=rev Log: [clang-tidy] Do not match on lambdas. We match on the generated FunctionDecl of the lambda and try to fix it. This causes a crash. The right behavior is to ignore

Re: [PATCH] D21737: [PATCH] [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else.

mehdi_amini added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:459 @@ -456,2 +458,3 @@ legacy::FunctionPassManager *FPM = getPerFunctionPasses(); + FPM->add(new TargetLibraryInfoWrapperPass(*TLII)); if (CodeGenOpts.VerifyModule) It is not super

[PATCH] D21799: [ASTMatchers] Add missing forEachArgumentWithParam() to code sample

mboehme created this revision. mboehme added a reviewer: klimek. mboehme added a subscriber: cfe-commits. Herald added a subscriber: klimek. http://reviews.llvm.org/D21799 Files: include/clang/ASTMatchers/ASTMatchers.h Index: include/clang/ASTMatchers/ASTMatchers.h

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra added a comment. Ping. http://reviews.llvm.org/D21666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21367: AMDGPU: Set amdgpu_kernel calling convention for OpenCL kernels.

Anastasia added inline comments. Comment at: lib/Basic/Targets.cpp:2122 @@ +2121,3 @@ + + + CallingConvCheckResult checkCallingConvention(CallingConv CC) const override { One extra line? http://reviews.llvm.org/D21367

r274035 - [CMake] Pass LLVM_LIT_ARGS into compiler-rt build.

Author: cbieneman Date: Tue Jun 28 12:00:49 2016 New Revision: 274035 URL: http://llvm.org/viewvc/llvm-project?rev=274035=rev Log: [CMake] Pass LLVM_LIT_ARGS into compiler-rt build. If top-level lit args are specified, you probably want that in the sub-project too. Modified:

Re: [PATCH] D21700: [SemaExpr] Support lax conversions in assignments with vector and scalars with same size

bruno added a comment. Ping! http://reviews.llvm.org/D21700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21795: [OpenCL] Add attribute 'pure' to read_image built-in functions to enable optimizations.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! http://reviews.llvm.org/D21795 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21641: Use ArgList::hasFlag to check if -miamcu/-mno-iamcu is passed. NFC.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Cool, thanks! LGTM http://reviews.llvm.org/D21641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r274045 - [CMake] Connect check-compiler-rt to check-all

Author: cbieneman Date: Tue Jun 28 13:32:22 2016 New Revision: 274045 URL: http://llvm.org/viewvc/llvm-project?rev=274045=rev Log: [CMake] Connect check-compiler-rt to check-all When using the LLVM_BUILD_EXTERNAL_COMPILER_RT option with LLVM_ENABLE_TESTS we should also bind check-compiler-rt to

Re: [PATCH] D21810: Don't instantiate a full host toolchain in ASTMatchersTest.

klimek added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersTest.h:77 @@ +76,3 @@ + // Some tests need rtti/exceptions on. Use an unknown-unknown triple so we + // don't instantiate the full system toolchain. On Linux, instantiting the + // toolchain involves

r274060 - cxx_status: make c++17 footnote list formatting consistent with other footnote lists.

Author: rsmith Date: Tue Jun 28 15:37:43 2016 New Revision: 274060 URL: http://llvm.org/viewvc/llvm-project?rev=274060=rev Log: cxx_status: make c++17 footnote list formatting consistent with other footnote lists. Modified: cfe/trunk/www/cxx_status.html Modified:

r274059 - cxx_status: fix footnote for p0136.

Author: rsmith Date: Tue Jun 28 15:37:00 2016 New Revision: 274059 URL: http://llvm.org/viewvc/llvm-project?rev=274059=rev Log: cxx_status: fix footnote for p0136. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL:

Re: [PATCH] D21783: [CodeView] Implement support for bitfields in Clang

aaboud accepted this revision. aaboud added a comment. This revision is now accepted and ready to land. LGTM. Please update PR28162. http://reviews.llvm.org/D21783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21810: Don't instantiate a full host toolchain in ASTMatchersTest.

chandlerc added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersTest.h:81-83 @@ +80,5 @@ + // + // FIXME: This is a hack to work around the fact that there's no way to do the + // equivalent of runToolOnCodeWithArgs without instantiating a full Driver. + // We

r274058 - Update cxx_dr_status from test/CXX/drs.

Author: rsmith Date: Tue Jun 28 15:35:53 2016 New Revision: 274058 URL: http://llvm.org/viewvc/llvm-project?rev=274058=rev Log: Update cxx_dr_status from test/CXX/drs. Modified: cfe/trunk/www/cxx_dr_status.html Modified: cfe/trunk/www/cxx_dr_status.html URL:

r274050 - Fix unreasonably-precise CHECK.

Author: rsmith Date: Tue Jun 28 14:09:30 2016 New Revision: 274050 URL: http://llvm.org/viewvc/llvm-project?rev=274050=rev Log: Fix unreasonably-precise CHECK. Modified: cfe/trunk/test/CodeGenCXX/inheriting-constructor.cpp Modified: cfe/trunk/test/CodeGenCXX/inheriting-constructor.cpp URL:

Re: [PATCH] D21367: AMDGPU: Set amdgpu_kernel calling convention for OpenCL kernels.

yaxunl added a comment. > Maybe we can use the fact that calling conventions are separate in AST and in > LLVM IR. So in AST maybe we can have opencl_kernel and in LLVM it can map to > spir_kernel for SPIR and amdgpu_kernel for AMDGPU. This approach looks good to me. Thanks.

Re: [PATCH] D21810: Don't instantiate a full host toolchain in ASTMatchersTest.

jlebar added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersTest.h:81-83 @@ +80,5 @@ + // + // FIXME: This is a hack to work around the fact that there's no way to do the + // equivalent of runToolOnCodeWithArgs without instantiating a full Driver. + // We

[PATCH] D21810: Don't instantiate a full host toolchain in ASTMatchersTest.

jlebar created this revision. jlebar added a reviewer: chandlerc. jlebar added a subscriber: cfe-commits. Herald added a subscriber: klimek. This test was stat()'ing large swaths of /usr/lib hundreds of times, as every invocation of matchesConditionally*() created a new Linux toolchain. In

Buildbot numbers for the last week of 6/19/2016 - 6/25/2016

Hello everyone, Below are some buildbot numbers for the last week of 6/19/2016 - 6/25/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Re: [PATCH] D21810: Don't instantiate a full host toolchain in ASTMatchersTest.

jlebar updated this revision to Diff 62132. jlebar marked 3 inline comments as done. jlebar added a comment. Fix typo in comment. http://reviews.llvm.org/D21810 Files: unittests/ASTMatchers/ASTMatchersTest.h Index: unittests/ASTMatchers/ASTMatchersTest.h

[PATCH] D21790: [Clang][Feature] Adding CLFLUSHOPT feature to clang

m_zuckerman created this revision. m_zuckerman added reviewers: AsafBadouh, igorb, delena. m_zuckerman added a subscriber: cfe-commits. http://reviews.llvm.org/D21790 Files: include/clang/Basic/BuiltinsX86.def lib/Headers/CMakeLists.txt lib/Headers/immintrin.h Index:

[PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

jakev created this revision. jakev added reviewers: silvas, davidxl, friss, vsk, bob.wilson, xur. jakev added a subscriber: cfe-commits. jakev set the repository for this revision to rL LLVM. The flags: For frontend instrumentation: `-fpgo-train=source-cfg` For IR-level instrumentation:

r274084 - Revert "[PS4] Tighten up a test (noticed in passing)"

Author: silvas Date: Tue Jun 28 19:29:23 2016 New Revision: 274084 URL: http://llvm.org/viewvc/llvm-project?rev=274084=rev Log: Revert "[PS4] Tighten up a test (noticed in passing)" This reverts commit r269709. r262285 changed this deliberately so that the test would not be sensitive to which

Re: [PATCH] D20334: [libcxx] Fix a bug in strstreambuf::overflow

dexonsmith added a comment. I agree with Ben that this looks good. Marshall and Eric, do you want Akira to hold off, or are you happy deferring to Ben and me? http://reviews.llvm.org/D20334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20334: [libcxx] Fix a bug in strstreambuf::overflow

(Ignore me, I was looking at an old version.) > On 2016-Jun-28, at 17:56, Duncan P. N. Exon Smith via cfe-commits > wrote: > > The fix looks fairly obvious, but you haven't added a testcase. Would you > please do so? > >> On 2016-May-17, at 12:20, Akira Hatanaka

Re: [PATCH] D20334: [libcxx] Fix a bug in strstreambuf::overflow

I agree with Ben that this looks good. Marshall and Eric, do you want Akira to hold off, or are you happy deferring to Ben and me? > On 2016-May-26, at 18:31, Akira Hatanaka via cfe-commits > wrote: > > ahatanak updated this revision to Diff 58740. > ahatanak

r274088 - Mark inheriting constructors as deleted if the corresponding defaulted default

Author: rsmith Date: Tue Jun 28 20:10:27 2016 New Revision: 274088 URL: http://llvm.org/viewvc/llvm-project?rev=274088=rev Log: Mark inheriting constructors as deleted if the corresponding defaulted default constructor would be; this is effectively required by P0136R1. This has the effect of

r274101 - [Diag] Add getter shouldAlwaysPrint. NFC

Author: anemet Date: Tue Jun 28 23:55:31 2016 New Revision: 274101 URL: http://llvm.org/viewvc/llvm-project?rev=274101=rev Log: [Diag] Add getter shouldAlwaysPrint. NFC For the new hotness attribute, the API will take the pass rather than the pass name so we can no longer play the trick of

r274104 - Revert "[Coverage] Adopt llvm::coverage::encodeFilenamesAndRawMappings (NFC)"

Author: vedantk Date: Wed Jun 29 00:33:09 2016 New Revision: 274104 URL: http://llvm.org/viewvc/llvm-project?rev=274104=rev Log: Revert "[Coverage] Adopt llvm::coverage::encodeFilenamesAndRawMappings (NFC)" This reverts commit 161ff9db3a3d0d62880d1cb18d58182cd3034912 (r273056). This is breaking

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

silvas added a comment. Some basic comments. Comment at: include/clang/Driver/Options.td:483 @@ +482,3 @@ +Group, Flags<[DriverOption]>, MetaVarName<"">, +HelpText<"Generate instrumented code to collect execution counts into (overridden by LLVM_PROFILE_FILE env

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

vsk added a comment. This lgtm with one nit, and pending approval from others. Comment at: include/clang/Driver/Options.td:482 @@ +481,3 @@ +def fpgo_train_EQ : Joined<["-"], "fpgo-train=">, +Group, Flags<[DriverOption]>, MetaVarName<"">, +HelpText<"Generate

r274064 - AvailabilityAttr: we accept "macos" as the platform name.

Author: mren Date: Tue Jun 28 15:55:30 2016 New Revision: 274064 URL: http://llvm.org/viewvc/llvm-project?rev=274064=rev Log: AvailabilityAttr: we accept "macos" as the platform name. We continue accepting "macosx" but canonicalize it to "macos", When emitting diagnostics, we use "macOS" instead

Re: [PATCH] D21653: [Sema] Disallow ambiguous base-to-derived conversion in template argument deduction

On Thu, Jun 23, 2016 at 10:37 AM, Erik Pilkington via cfe-commits < cfe-commits@lists.llvm.org> wrote: > erik.pilkington created this revision. > erik.pilkington added reviewers: rsmith, faisalv. > erik.pilkington added a subscriber: cfe-commits. > > Previously, Clang would incorrectly accept the

Re: [PATCH] D21277: Resubmit r270688: Using new TargetParser in Clang.

rengolin added a comment. Sorry, this was committed and reverted (bugs, being fixed by http://reviews.llvm.org/D21785). We should start a new one when that's in. Ignore this one. :) Repository: rL LLVM http://reviews.llvm.org/D21277 ___

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

rsmith added a comment. Thank you! I'm happy with this implementation (other than some data structure improvements), and cxx-abi-dev discussion seems to be settling on this approach (mangling the return type / variable type to extract attributes) being the right one. (Minor nit: please make

r274044 - Update the expected masked load/store intrinsics names in tests

Author: apilipenko Date: Tue Jun 28 13:28:45 2016 New Revision: 274044 URL: http://llvm.org/viewvc/llvm-project?rev=274044=rev Log: Update the expected masked load/store intrinsics names in tests The mangling of their names was changed in order to support arbitrary addrspace pointers as

r274012 - [SPARC] Allows inlining of atomics for Sparc32 with appropriate store barrier.

Author: lerochris Date: Tue Jun 28 07:55:55 2016 New Revision: 274012 URL: http://llvm.org/viewvc/llvm-project?rev=274012=rev Log: [SPARC] Allows inlining of atomics for Sparc32 with appropriate store barrier. The final change is required to extend the back-end's AtomicExpandPass that was

[PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

tavianator created this revision. tavianator added reviewers: danalbert, jroelofs. tavianator added a subscriber: cfe-commits. Herald added subscribers: danalbert, tberghammer. __cxa_thread_atexit_impl() isn't present on all platforms, for example Android pre-6.0. This patch uses a weak symbol

RE: r273950 -

Sorry. I did enter a commit message. I’ve no idea why it’s not there. I’ll re-commit later today. From: tha...@google.com [mailto:tha...@google.com] On Behalf Of Nico Weber Sent: 28 June 2016 01:12 To: Chris.Dewhurst Cc: cfe-commits Subject:

r273997 - [Driver] Add method to redirect output of Compilation.

Author: nhaustov Date: Tue Jun 28 03:00:42 2016 New Revision: 273997 URL: http://llvm.org/viewvc/llvm-project?rev=273997=rev Log: [Driver] Add method to redirect output of Compilation. Summary: Currently output of child process, however in my use case, it needs to be captured and presented to

Re: [PATCH] D21619: [Sema] Implement C++14's DR1579: Prefer moving id-expression out of functions

rsmith added a comment. Thank you for working on this! Please also add a test to test/CXX/drs/dr15xx.cpp with a "// dr1579: 3.9" comment (we have a script that turns those comments into www/cxx_dr_status.html). Comment at: include/clang/Sema/Sema.h:3473 @@ -3472,3 +3472,3 @@

Re: [PATCH] D21277: Resubmit r270688: Using new TargetParser in Clang.

rengolin reopened this revision. rengolin added a comment. This revision is now accepted and ready to land. Reopening, as this is the right patch. This patch is approved, waiting on http://reviews.llvm.org/D21785, which fixes the issue that made us revert http://reviews.llvm.org/D20088 in the

[PATCH] D21820: [libcxx] [test] Make swap_noexcept.pass.cpp tests more portable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make swap_noexcept.pass.cpp tests more portable. These tests define types like some_alloc, which dramatically fail to meet the allocator requirements. They don't even have

r274077 - [Sema] Disallow ambigious base classes in template argument deduction

Author: epilk Date: Tue Jun 28 18:05:09 2016 New Revision: 274077 URL: http://llvm.org/viewvc/llvm-project?rev=274077=rev Log: [Sema] Disallow ambigious base classes in template argument deduction Fixes PR28195. Differential revision: http://reviews.llvm.org/D21653 Modified:

Re: [PATCH] D21501: [Driver] Add support for Broadcom Vulcan core

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. This seems fine to me. http://reviews.llvm.org/D21501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21653: [Sema] Disallow ambiguous base-to-derived conversion in template argument deduction

erik.pilkington added a comment. Do you mean Faisal's example? He committed that in r270016. Thanks for taking a look! http://reviews.llvm.org/D21653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21392: [clang-tidy] Enhance redundant-expression check

etienneb added inline comments. Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:27 @@ -25,1 +26,3 @@ +static bool incrementWithoutOverflow(const llvm::APSInt , + llvm::APSInt ) { aaron.ballman wrote: > I think this

Re: [PATCH] D21653: [Sema] Disallow ambiguous base-to-derived conversion in template argument deduction

rsmith added a comment. Well OK then, commit away! :) http://reviews.llvm.org/D21653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r274076 - ObjC Class Property: diagnostics when accessing a class property using instance.

Author: mren Date: Tue Jun 28 18:01:49 2016 New Revision: 274076 URL: http://llvm.org/viewvc/llvm-project?rev=274076=rev Log: ObjC Class Property: diagnostics when accessing a class property using instance. When a class property is accessed with an object instance, before this commit, we try to

r274041 - NFC. Test commit, remove a redundant empty line in Tooling.cpp

Author: apilipenko Date: Tue Jun 28 12:56:29 2016 New Revision: 274041 URL: http://llvm.org/viewvc/llvm-project?rev=274041=rev Log: NFC. Test commit, remove a redundant empty line in Tooling.cpp Modified: cfe/trunk/lib/Tooling/Tooling.cpp Modified: cfe/trunk/lib/Tooling/Tooling.cpp URL:

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

majnemer added a subscriber: majnemer. Comment at: src/cxa_thread_atexit.cpp:36-47 @@ +35,14 @@ + public: +DtorListHolder() { + pthread_key_create(_, run_dtors); +} + +~DtorListHolder() { + run_dtors(get()); + pthread_key_delete(key_); +} + +

r274080 - Function declarations are, in fact, permitted in the init-statement of a for

Author: rsmith Date: Tue Jun 28 18:26:18 2016 New Revision: 274080 URL: http://llvm.org/viewvc/llvm-project?rev=274080=rev Log: Function declarations are, in fact, permitted in the init-statement of a for loop. Don't confuse Sema by saying they're not. Modified:

Re: [PATCH] D21773: [clang] Update an optimization remark test for change D18777

sanjoy added a subscriber: anemet. sanjoy added a comment. Sound plausible, but I don't know this area (optimization remarks) well enough to sign off on this. @anemet can you please take a look? http://reviews.llvm.org/D21773 ___ cfe-commits

Re: [PATCH] D21773: [clang] Update an optimization remark test for change D18777

anemet added a comment. > This test checks the loop-vectorization remarks when pointer checking > threshold is exceeded. The change in http://reviews.llvm.org/D18777 would > introduce zexts that cannot be removed so that the "loop not vectorized" > reason is changed, hence breaking this test.

[PATCH] D21825: Driver: Forbid -fthinlto-index with output formats other than object files.

pcc created this revision. pcc added a reviewer: tejohnson. pcc added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. The other output formats aren't really useful to end users. The equivalent functionality can still be accessed by developers with tools such as llvm-lto.

Re: [PATCH] D21545: CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.

pcc updated this revision to Diff 62160. pcc marked 2 inline comments as done. pcc added a comment. - Use ComputeCrossModuleImportForModule http://reviews.llvm.org/D21545 Files: lib/CodeGen/BackendUtil.cpp lib/CodeGen/CMakeLists.txt Index: lib/CodeGen/CMakeLists.txt

Re: [PATCH] D21277: Resubmit r270688: Using new TargetParser in Clang.

jojo added a comment. I'm sorry that I should have submitted this and its fix in one review. Now the old fix http://reviews.llvm.org/D21276 is abandoned,as a latest fix is included in http://reviews.llvm.org/D21785. I will commit http://reviews.llvm.org/D21277 and

Re: [PATCH] D21773: [clang] Update an optimization remark test for change D18777

anemet added a comment. In http://reviews.llvm.org/D21773#469596, @lihuang wrote: > IV is promoted to 64-bit but the trunc/zext cannot be eliminated (at least > cannot be eliminated with the -O1 pass pipeline). Then optimzation remark > becomes: > > optimization-remark-options.c:17:3:

Re: [PATCH] D20334: [libcxx] Fix a bug in strstreambuf::overflow

The fix looks fairly obvious, but you haven't added a testcase. Would you please do so? > On 2016-May-17, at 12:20, Akira Hatanaka via cfe-commits > wrote: > > ahatanak created this revision. > ahatanak added reviewers: mclow.lists, EricWF, howard.hinnant. >

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

tavianator added inline comments. Comment at: src/cxa_thread_atexit.cpp:36-47 @@ +35,14 @@ + public: +DtorListHolder() { + pthread_key_create(_, run_dtors); +} + +~DtorListHolder() { + run_dtors(get()); + pthread_key_delete(key_); +} + +

Re: [PATCH] D21603: [include-fixer] Fix namespace after inserting a missing header.

hokein added a comment. In http://reviews.llvm.org/D21603#468717, @djasper wrote: > Sorry, I completely forgot about this. Will try to review today. Is this part > about the patch description accurate? Yes, the description is accurate. > Specifically, what needs to be implemented in vim to