Re: r274246 - [codeview] Emit qualified display names if -gline-tables-only is on

On Fri, Jul 8, 2016 at 1:04 PM, Nico Weber wrote: > On Fri, Jul 8, 2016 at 3:57 PM, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> >> On Thu, Jul 7, 2016 at 4:10 PM, Reid Kleckner wrote: >> >>> On Thu, Jul 7, 2016 at 3:45 PM,

Re: [PATCH] D22170: [OpenCL] Fixes opencl.cl testcase issues and cl-strict-aliasing only allowed with cl-std=CL

yaxunl added inline comments. Comment at: test/Frontend/opencl-blocks.cl:9 @@ -8,1 +8,3 @@ // RUN: %clang_cc1 %s -triple amdgcn--amdhsa -x c -std=c99 -verify -fsyntax-only +// RUN: %clang_cc1 -cl-std=CL1.1 -cl-strict-aliasing %s 2>&1 | FileCheck

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama added a comment. Ping... http://reviews.llvm.org/D20602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

Prazek added a subscriber: Prazek. Prazek added a comment. Very usefull check! I don't have enough time right now to check everything, so better wait for review of Alexfh or someone else. I just wanted to leave some thoughts. Comment at:

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

yaxunl updated this revision to Diff 63571. yaxunl added a comment. Added test for invalid sampler values. http://reviews.llvm.org/D21567 Files: include/clang/AST/OperationKinds.def include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td

r275095 - [NFC] Reorder fields of VersionTuple to reduce size

Author: epilk Date: Mon Jul 11 15:00:48 2016 New Revision: 275095 URL: http://llvm.org/viewvc/llvm-project?rev=275095=rev Log: [NFC] Reorder fields of VersionTuple to reduce size Differential revision: http://reviews.llvm.org/D19934 Modified: cfe/trunk/include/clang/Basic/VersionTuple.h

[libcxx] r275094 - Allow is_swappable to SFINAE on deleted/ambiguous swap functions

Author: ericwf Date: Mon Jul 11 14:57:13 2016 New Revision: 275094 URL: http://llvm.org/viewvc/llvm-project?rev=275094=rev Log: Allow is_swappable to SFINAE on deleted/ambiguous swap functions Modified: libcxx/trunk/include/type_traits

Re: r274246 - [codeview] Emit qualified display names if -gline-tables-only is on

On Mon, Jul 11, 2016 at 10:35 AM, David Blaikie wrote: > > I believe so, but don't have specific numbers. Alexey made this choice > when it was originally implemented & I believe had the data back then. > I don't think we made an explicit choice to use short names. gdb and

Re: [PATCH] D20786: Fix undefined behavior in __tree

EricWF added a reviewer: howard.hinnant. EricWF added a subscriber: howard.hinnant. EricWF added a comment. Adding Howard to the reviewers. @howard.hinnant Feel free to take a look if your interested. @mclow.lists Any comments? http://reviews.llvm.org/D20786

[libcxx] r275089 - Hide some internal symbols for memory resource.

Author: ericwf Date: Mon Jul 11 14:22:09 2016 New Revision: 275089 URL: http://llvm.org/viewvc/llvm-project?rev=275089=rev Log: Hide some internal symbols for memory resource. Modified: libcxx/trunk/src/experimental/memory_resource.cpp Modified:

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). http://reviews.llvm.org/D0 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22190: cppcoreguidelines-pro-bounds-constant-array-index: crash for value dependent index in c++03 mode

aaron.ballman added a comment. In http://reviews.llvm.org/D22190#479921, @mgehre wrote: > Even if we change isIntegerConstantExpr() to return true instead of > asserting, we still need this fix to the check. Because > we call isIntegerConstantExpr() to find out if we can possibly calculate the

Re: r274991 - [clang-cl] Add support for /Zd

On Mon, Jul 11, 2016 at 12:18 PM, Nico Weber wrote: > On Mon, Jul 11, 2016 at 12:19 PM, David Majnemer > wrote: > >> >> >> On Mon, Jul 11, 2016 at 9:03 AM, Nico Weber wrote: >> >>> On Mon, Jul 11, 2016 at 11:51 AM, David

[PATCH] D22227: [ubsan] Disable bounds-check for flexible array ivars

vsk created this revision. vsk added reviewers: rsmith, samsonov. vsk added a subscriber: cfe-commits. Ubsan does not emit bounds checks for flexible array members, e.g:

Re: [PATCH] D19679: Method pool in modules: sync up out of date selectors before writing the module

manmanren closed this revision. manmanren marked an inline comment as done. manmanren added a comment. In r268091. http://reviews.llvm.org/D19679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r274991 - [clang-cl] Add support for /Zd

On Mon, Jul 11, 2016 at 12:19 PM, David Majnemer wrote: > > > On Mon, Jul 11, 2016 at 9:03 AM, Nico Weber wrote: > >> On Mon, Jul 11, 2016 at 11:51 AM, David Majnemer < >> david.majne...@gmail.com> wrote: >> >>> >>> >>> On Mon, Jul 11, 2016 at 8:42

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

mgehre added a subscriber: mgehre. mgehre added a comment. Nice check. This should be mentioned in docs/ReleaseNotes.rst http://reviews.llvm.org/D0 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21453: Add support for attribute "overallocated"

aaron.ballman added inline comments. Comment at: include/clang/AST/Decl.h:3249 @@ -3248,1 +3248,3 @@ + /// This is true if this struct ends with an array marked 'flexible_array'. + bool HasFlexibleArrayAttr : 1; ahatanak wrote: > Probably it can be looked up

Re: [PATCH] D22208: clang-tidy] Fixes to modernize-use-emplace

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:21 @@ +20,3 @@ +llvm::Optional +getHasAnyName(const std::vector ) { + llvm::Optional hasMatcher; Should be

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

yaxunl updated this revision to Diff 63556. yaxunl marked 3 inline comments as done. yaxunl added a comment. Revised by Anastia's comments. Disabled warning for sampler enum value by default. http://reviews.llvm.org/D21567 Files: include/clang/AST/OperationKinds.def

Re: [PATCH] D22170: [OpenCL] Fixes opencl.cl testcase issues and cl-strict-aliasing only allowed with cl-std=CL

ashi1 updated this revision to Diff 63539. ashi1 marked 2 inline comments as done. ashi1 added a comment. Moved cl-strict-aliasing testing to a new file cl-strict-aliasing.cl Repository: rL LLVM http://reviews.llvm.org/D22170 Files: lib/Frontend/CompilerInvocation.cpp

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

yaxunl marked 20 inline comments as done. Comment at: lib/CodeGen/CGExprConstant.cpp:694 @@ +693,3 @@ +case CK_IntToOCLSampler: + llvm_unreachable("global sampler variables are not generated"); + Anastasia wrote: > Does this only apply to global variable

Re: [PATCH] D22171: [ObjC Availability] Implement parser support for Objective-C's @available

manmanren added a comment. Thanks for working on this, Erik. Manman Comment at: include/clang/AST/Availability.h:32 @@ +31,3 @@ +class AvailabilitySpec { + VersionTuple Version; + StringRef Platform; Can you put a description for "Version"? i.e if it

Re: [PATCH] D19934: [NFC] Reorder fields of VersionTuple to reduce size

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman http://reviews.llvm.org/D19934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r275105 - Always use the allocator to construct/destruct elements of a deque/vector. Fixes PR#28412. Thanks to Jonathan Wakely for the report.

Author: marshall Date: Mon Jul 11 16:38:08 2016 New Revision: 275105 URL: http://llvm.org/viewvc/llvm-project?rev=275105=rev Log: Always use the allocator to construct/destruct elements of a deque/vector. Fixes PR#28412. Thanks to Jonathan Wakely for the report. Modified:

Re: [PATCH] D22208: clang-tidy] Fixes to modernize-use-emplace

Prazek added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:21 @@ +20,3 @@ +llvm::Optional +getHasAnyName(const std::vector ) { + llvm::Optional hasMatcher; aaron.ballman

Re: [PATCH] D21453: Add support for attribute "overallocated"

ahatanak updated this revision to Diff 63596. ahatanak added a comment. Change diagnostic messages. http://reviews.llvm.org/D21453 Files: include/clang/AST/Decl.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D21453: Add support for attribute "overallocated"

ahatanak added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2170 @@ +2169,3 @@ + "'flexible_array' attribute only applies to %select{" + "the last member of a struct|members of structs or classes|" + "fixed sized array members|array members that have

r275121 - [Coverage] Do not map regions from system headers

Author: vedantk Date: Mon Jul 11 17:57:46 2016 New Revision: 275121 URL: http://llvm.org/viewvc/llvm-project?rev=275121=rev Log: [Coverage] Do not map regions from system headers Do not assign source regions located within system headers file ID's, and do not construct counter mapping regions

[libcxx] r275114 - Don't compute modulus of hash if it is smaller than the bucket count.

Author: ericwf Date: Mon Jul 11 17:02:02 2016 New Revision: 275114 URL: http://llvm.org/viewvc/llvm-project?rev=275114=rev Log: Don't compute modulus of hash if it is smaller than the bucket count. This cleans up a previous optimization attempt in hash, and results in additional performance

[PATCH] D22242: [analyzer] De-duplicate some code for discovering the origin of the symbol.

NoQ created this revision. NoQ added a reviewer: dcoughlin. NoQ added a subscriber: cfe-commits. Or, more importantly, tell the users that there's a way to discover the region, value of which - at some moment of time - the symbol was introduced to represent. Idea proposed by Devin Coughlin.

Buildbot numbers for the week of 6/26/2016 - 7/02/2016

Hello everyone, Below are some buildbot numbers for the week of 6/26/2016 - 7/02/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 7/03/2016 - 7/09/2016

Hello everyone, Below are some buildbot numbers for the last week of 7/03/2016 - 7/09/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

[PATCH] D22248: [Sema] Create a separate group for incompatible function pointer warning

bruno created this revision. bruno added reviewers: bob.wilson, doug.gregor, krememek. bruno added subscribers: cfe-commits, dexonsmith. Give incompatible pointer warning for function pointers its own diagnostic group while leaving it as a subgroup of incompatible-pointer-types. This is in

r275127 - Fix test submitted with r275115 (failed on ppc64 buildbots).

Author: wolfgangp Date: Mon Jul 11 18:20:28 2016 New Revision: 275127 URL: http://llvm.org/viewvc/llvm-project?rev=275127=rev Log: Fix test submitted with r275115 (failed on ppc64 buildbots). Modified: cfe/trunk/test/CodeGen/forwarding-blocks-if.c Modified:

r275128 - Correcting the previous fix for test submitted with r275115.

Author: wolfgangp Date: Mon Jul 11 18:27:19 2016 New Revision: 275128 URL: http://llvm.org/viewvc/llvm-project?rev=275128=rev Log: Correcting the previous fix for test submitted with r275115. Modified: cfe/trunk/test/CodeGen/forwarding-blocks-if.c Modified:

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

jakev updated the summary for this revision. jakev updated this revision to Diff 63634. jakev added a comment. Change patch to use `-fprofile-generate` to enable IRPGO. Repository: rL LLVM http://reviews.llvm.org/D21823 Files: include/clang/Driver/Options.td lib/Driver/Tools.cpp

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

ABataev added a comment. I don't see successful test for the clause, which prints AST and checks serialization/deserialization. Also it should include a template test to check that dependent objects are handled correctly Comment at: include/clang/AST/OpenMPClause.h:4236 @@

Re: r274991 - [clang-cl] Add support for /Zd

On Mon, Jul 11, 2016 at 12:29 PM, David Majnemer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Mon, Jul 11, 2016 at 12:18 PM, Nico Weber wrote: > >> On Mon, Jul 11, 2016 at 12:19 PM, David Majnemer < >> david.majne...@gmail.com> wrote: >> >>> >>> >>> On Mon,

Re: [PATCH] D21706: [libcxx] refactor for throw

weimingz added a comment. Hi Marshall, do you have any comments? http://reviews.llvm.org/D21706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22189: llvm.noalias - Clang CodeGen - check restrict variable map only for restrict-qualified lvalues

majnemer added a subscriber: majnemer. majnemer accepted this revision. majnemer added a reviewer: majnemer. majnemer added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/CodeGen/CodeGenFunction.h:2725 @@ -2724,3 +2724,3 @@ void

[PATCH] D22255: [libcxx] Create __is_alloc_constructible<Alloc, Type, Args...> trait which checks the validity of allocator_traits construction.

EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. Example Usage: To check the `EmplaceConstructible` Container requirement you would ask: `__is_alloc_constructible::value`

Re: [PATCH] D22255: [libcxx] Create __is_alloc_constructible<Alloc, Type, Args...> trait which checks the validity of allocator_traits construction.

EricWF updated this revision to Diff 63635. EricWF added a comment. - Don't use `is_constructible` in the `__is_alloc_constructible` implementation. `is_constructible` requires `is_destructible`, but that isn't required within allocators. Instead this trait checks the validity of the

Re: [PATCH] D22255: [libcxx] Create __is_alloc_constructible<Alloc, Type, Args...> trait which checks the validity of allocator_traits construction.

EricWF updated this revision to Diff 63636. EricWF added a comment. Add correct tests. http://reviews.llvm.org/D22255 Files: include/memory include/type_traits include/vector test/libcxx/utilities/memory/allocator.traits/__is_alloc_constructible.pass.cpp

Re: [PATCH] D22073: libc++: test lock-free atomic alignment

EricWF added a comment. - The test should be moved to `test/libcxx/atomics/atomics.align` since it's libc++ specific. - Please give the anonymous struct declarations unique names. `T1`, `T2`, ..., `TN` is fine. Currently they all mangle to `main::type` in diagnostic output. - The test fails to

Re: [PATCH] D22242: [analyzer] De-duplicate some code for discovering the origin of the symbol.

zaks.anna added a subscriber: zaks.anna. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/SymExpr.h:81 @@ -78,2 +80,3 @@ unsigned computeComplexity() const; + const MemRegion *getOriginRegion() const; }; Please, add a doxygen style comment.

r275154 - [MS ABI] Support throwing/catching __unaligned types

Author: majnemer Date: Mon Jul 11 23:42:50 2016 New Revision: 275154 URL: http://llvm.org/viewvc/llvm-project?rev=275154=rev Log: [MS ABI] Support throwing/catching __unaligned types We need to mark the appropriate bits in ThrowInfo and HandlerType so that the personality routine can correctly

Re: [PATCH] D21834: Implementing 'If statement with Initializer'

AntonBikineev updated the summary for this revision. AntonBikineev updated this revision to Diff 63471. AntonBikineev added a comment. @rsmith, Richard, again, thank you for guiding. I've addressed your comments. http://reviews.llvm.org/D21834 Files: include/clang/AST/Stmt.h

r275047 - [Sema] Disallow __make_integer_seq from showing up in __make_integer_seq

Author: majnemer Date: Mon Jul 11 00:59:24 2016 New Revision: 275047 URL: http://llvm.org/viewvc/llvm-project?rev=275047=rev Log: [Sema] Disallow __make_integer_seq from showing up in __make_integer_seq We hit over stringent asserts when trying to diagnose. Loosen them as appropriate. This

r275049 - [AVX512] Replace masked AND/OR/XOR intrinsics with native code and remove the builtins.

Author: ctopper Date: Mon Jul 11 01:14:18 2016 New Revision: 275049 URL: http://llvm.org/viewvc/llvm-project?rev=275049=rev Log: [AVX512] Replace masked AND/OR/XOR intrinsics with native code and remove the builtins. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def

Re: [PATCH] D21992: [clang-tidy] new cppcoreguidelines-slicing

hokein added inline comments. Comment at: clang-tidy/cppcoreguidelines/SlicingCheck.cpp:48 @@ +47,3 @@ + + // Assignement slicing: "a = b;" and "a = std::move(b);" variants. + const auto SlicesObjectInAssignment = Looks like you are missing some cases here,

[clang-tools-extra] r275051 - [clang-tidy] Pass absolute path to OptionsProvider::getOptions/getRawOptions.

Author: hokein Date: Mon Jul 11 02:47:04 2016 New Revision: 275051 URL: http://llvm.org/viewvc/llvm-project?rev=275051=rev Log: [clang-tidy] Pass absolute path to OptionsProvider::getOptions/getRawOptions. Summary: Although there is no guarantee of getOptions/getRawOptions receiving an absolute

Re: [PATCH] D22102: [clang-rename] extend testset

omtcyf0 updated this revision to Diff 63470. omtcyf0 added a comment. add XFAIL test with virtual function renaming http://reviews.llvm.org/D22102 Files: test/clang-rename/FunctionMacro.cpp test/clang-rename/Namespace.cpp test/clang-rename/TemplateTypename.cpp

Re: [PATCH] D21851: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format.

Hahnfeld added a comment. In http://reviews.llvm.org/D21851#479042, @sfantao wrote: > That was probably not the reason why you were getting the failure, but the > bundler was not prepared to bundle files if the host was not the first input. > I fixed that. This was indeed the problem, this

Re: [PATCH] D20795: Added basic capabilities to detect source code clones.

zaks.anna added a comment. Hi, Thank you for working on this! Here are several comments from a **partial** review. Can you talk a bit about how do you envision to generalize this to copy and paste detection, where the pasted code is only partially modified? Do you think this could be

Re: [PATCH] D21472: [clang-tidy] readability-identifier-naming - support for other case types

JamesReynolds updated the summary for this revision. JamesReynolds updated this revision to Diff 63462. JamesReynolds added a comment. > You mean Upper_Separated and upper_Separated_Back? ;) Actually, these names > are not particularly clear. I've managed to find "Camel_Snake_Case" > used for

Re: [PATCH] D22154: [clang-tidy] Pass absolute path to OptionsProvider::getOptions/getRawOptions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL275051: [clang-tidy] Pass absolute path to OptionsProvider::getOptions/getRawOptions. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D22154?vs=63282=63469#toc Repository: rL

Re: [PATCH] D22091: [clang-rename] exit code-related bugfix and code cleanup

omtcyf0 updated this revision to Diff 63463. omtcyf0 added a comment. Add new test, which ensures clang-rename failure if new name is not passed. http://reviews.llvm.org/D22091 Files: clang-rename/RenamingAction.cpp clang-rename/USRLocFinder.cpp clang-rename/USRLocFinder.h

Re: [PATCH] D21834: Implementing 'If statement with Initializer'

AntonBikineev updated this revision to Diff 63472. http://reviews.llvm.org/D21834 Files: include/clang/AST/Stmt.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/AST/ASTImporter.cpp lib/AST/ExprConstant.cpp lib/AST/Stmt.cpp lib/Analysis/BodyFarm.cpp

Re: [PATCH] D21834: Implementing 'If statement with Initializer'

AntonBikineev updated this revision to Diff 63474. http://reviews.llvm.org/D21834 Files: include/clang/AST/Stmt.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/AST/ASTImporter.cpp lib/AST/ExprConstant.cpp lib/AST/Stmt.cpp lib/Analysis/BodyFarm.cpp

Re: [PATCH] D22176: [OpenMP] add more tests for 'distribute simd' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D22176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22075: [OpenMP] Fix incorrect diagnostics in map clause

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:10667-10668 @@ +10666,4 @@ + if (Type.isNull() || Type->isAnyPointerType() || + CheckArrayExpressionDoesNotReferToWholeSize(SemaRef, + SI->getAssociatedExpression(),Type)) +

Re: [PATCH] D22102: [clang-rename] extend testset

klimek added a comment. Add // FIXME: to tests that do not work yet. I'd personally not check in the XFAIL tests for now, and just add them when you implement the missing functionality; the problem with XFAIL here is that (due to the offsets involved) they can easily switch into a mode where

[PATCH] D22212: [X86][AVX512] Constants for integer comparison predicates

AsafBadouh created this revision. AsafBadouh added reviewers: guyblank, m_zuckerman, delena. AsafBadouh added a subscriber: cfe-commits. AsafBadouh set the repository for this revision to rL LLVM. Repository: rL LLVM http://reviews.llvm.org/D22212 Files:

Re: [PATCH] D21834: Implementing 'If statement with Initializer'

AntonBikineev updated this revision to Diff 63475. AntonBikineev added a comment. Moved stars to the right side of declarations http://reviews.llvm.org/D21834 Files: include/clang/AST/Stmt.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/AST/ASTImporter.cpp

Re: [PATCH] D22190: cppcoreguidelines-pro-bounds-constant-array-index: crash for value dependent index in c++03 mode

mgehre added a comment. Even if we change isIntegerConstantExpr() to return true instead of asserting, we still need this fix to the check. Because we call isIntegerConstantExpr() to find out if we can possibly calculate the (constant) value of the index expression. If it is value dependent, we

Re: [PATCH] D21744: [OpenCL] Fix code generation of kernel pipe parameters.

pxli168 accepted this revision. pxli168 added a comment. Sorry for the late reply, I was busy with some backend problem. LGTM, thanks for the fix! http://reviews.llvm.org/D21744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D22096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21834: Implementing 'If statement with Initializer'

AntonBikineev updated this revision to Diff 63473. AntonBikineev added a comment. removed a leftover from parser/cxx1z-init-stmt.cpp test http://reviews.llvm.org/D21834 Files: include/clang/AST/Stmt.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h

Re: [PATCH] D21992: [clang-tidy] new cppcoreguidelines-slicing

courbet added a comment. Thanks for the comments. Comment at: clang-tidy/cppcoreguidelines/SlicingCheck.cpp:48 @@ +47,3 @@ + + // Assignement slicing: "a = b;" and "a = std::move(b);" variants. + const auto SlicesObjectInAssignment = hokein wrote: > Looks

Re: [PATCH] D21992: [clang-tidy] new cppcoreguidelines-slicing

courbet updated this revision to Diff 63477. courbet marked 4 inline comments as done. courbet added a comment. - Add a test case following comments. - Add more comments in tests. - Add examples in doc. - Simplify code a bit. http://reviews.llvm.org/D21992 Files:

Re: [PATCH] D21992: [clang-tidy] new cppcoreguidelines-slicing

courbet added a comment. I've ran this check on llvm. There are 0 instances of virtual function slicing (which is not surprising since these usually result in actual bugs) and 71 instances of member varaible slicing: - 'FullSourceLoc' to 'SourceLocation': 57 - 'APSInt' to 'APInt': 5 -

Re: [PATCH] D22169: [OpenMP] add more tests for 'distribute parallel for simd' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D22169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

ABataev added a comment. No positive tests for the construct Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8333 @@ -8332,1 +8332,3 @@ "expected at least one 'to' clause or 'from' clause specified to '#pragma omp target update'">; +def

[clang-tools-extra] r275063 - Changes related to tooling::applyAllReplacements interface change in D21601.

Author: ioeric Date: Mon Jul 11 08:53:21 2016 New Revision: 275063 URL: http://llvm.org/viewvc/llvm-project?rev=275063=rev Log: Changes related to tooling::applyAllReplacements interface change in D21601. Summary: this patch contains changes related to the interface change from

Re: [PATCH] D21601: Make tooling::applyAllReplacements return llvm::Expected instead of empty string to indicate potential error.

This revision was automatically updated to reflect the committed changes. Closed by commit rL275062: Make tooling::applyAllReplacements return llvm::Expected instead of… (authored by ioeric). Changed prior to commit: http://reviews.llvm.org/D21601?vs=61823=63505#toc Repository: rL LLVM

Re: r274991 - [clang-cl] Add support for /Zd

This breaks existing users of -gline-tables-only. What's the motivation for this change? On Sat, Jul 9, 2016 at 5:49 PM, David Majnemer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: majnemer > Date: Sat Jul 9 16:49:16 2016 > New Revision: 274991 > > URL:

r275061 - [OpenCL] Improved diagnostics of OpenCL types.

Author: stulova Date: Mon Jul 11 08:46:02 2016 New Revision: 275061 URL: http://llvm.org/viewvc/llvm-project?rev=275061=rev Log: [OpenCL] Improved diagnostics of OpenCL types. - Changes diagnostics for Blocks to be implicitly const qualified OpenCL v2.0 s6.12.5. - Added and unified

Re: [PATCH] D21602: Changes related to tooling::applyAllReplacements interface change in D21601.

This revision was automatically updated to reflect the committed changes. Closed by commit rL275063: Changes related to tooling::applyAllReplacements interface change in D21601. (authored by ioeric). Changed prior to commit: http://reviews.llvm.org/D21602?vs=63504=63506#toc Repository: rL

Re: [PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

bmharper added a comment. kaPING! Repository: rL LLVM http://reviews.llvm.org/D21279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r274991 - [clang-cl] Add support for /Zd

VS2013's cl.exe doesn't understand /Zd, 2015's doesn't either. This means people who want to ask clang-cl for line tables only will have to add this flag in some if(is_clang) block in their build file anyways. What's the advantage of giving this flag a spelling that's different from both cl and

Re: [PATCH] D22170: [OpenCL] Fixes opencl.cl testcase issues and cl-strict-aliasing only allowed with cl-std=CL

yaxunl added inline comments. Comment at: test/Frontend/opencl-blocks.cl:9 @@ -8,1 +8,3 @@ // RUN: %clang_cc1 %s -triple amdgcn--amdhsa -x c -std=c99 -verify -fsyntax-only +// RUN: %clang_cc1 -cl-std=CL1.1 -cl-strict-aliasing %s 2>&1 | FileCheck

[PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

mboehme created this revision. mboehme added a reviewer: sbenza. mboehme added a subscriber: cfe-commits. The check emits a warning if std::move() is applied to a forwarding reference, i.e. an rvalue reference of a function template argument type. If a developer is unaware of the special rules

Re: [PATCH] D22129: [clang-rename] add documentation

bkramer added inline comments. Comment at: docs/clang-rename.rst:17 @@ +16,3 @@ + +The tool development is in very early stage, so you might encounter bugs and +crashes. Submitting reports with information about how to reproduce the issue maybe 'is in a very

Re: r274991 - [clang-cl] Add support for /Zd

On Mon, Jul 11, 2016 at 7:18 AM, Nico Weber wrote: > VS2013's cl.exe doesn't understand /Zd, 2015's doesn't either. This means > people who want to ask clang-cl for line tables only will have to add this > flag in some if(is_clang) block in their build file anyways. What's

Re: [PATCH] D22170: [OpenCL] Fixes opencl.cl testcase issues and cl-strict-aliasing only allowed with cl-std=CL

yaxunl added inline comments. Comment at: test/Frontend/opencl-blocks.cl:9 @@ -8,1 +8,3 @@ // RUN: %clang_cc1 %s -triple amdgcn--amdhsa -x c -std=c99 -verify -fsyntax-only +// RUN: %clang_cc1 -cl-std=CL1.1 -cl-strict-aliasing %s 2>&1 | FileCheck

Re: [PATCH] D21385: Adjust Registry interface to not require plugins to export a registry

john.brawn added a comment. > Plugins tests are still disabled by lit.cfg I think, as it only checks for > enable_shared, which is disabled. I suppose we could wait for both this and > the SampleAnalyzerPlugin to be patched before enabling plugins tests if we > have

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

On Sat, Jul 9, 2016 at 7:39 PM Sean Silva wrote: > silvas added a comment. > > In http://reviews.llvm.org/D21823#479418, @davidxl wrote: > > > I should have brought it up earlier, but I forgot.I think a better > (and simpler) proposal is to make -fprofile-generate and

Re: r274991 - [clang-cl] Add support for /Zd

On Mon, Jul 11, 2016 at 9:03 AM, Nico Weber wrote: > On Mon, Jul 11, 2016 at 11:51 AM, David Majnemer > wrote: > >> >> >> On Mon, Jul 11, 2016 at 8:42 AM, Nico Weber wrote: >> >>> On Mon, Jul 11, 2016 at 11:36 AM, David

Re: r274991 - [clang-cl] Add support for /Zd

On Mon, Jul 11, 2016 at 8:42 AM, Nico Weber wrote: > On Mon, Jul 11, 2016 at 11:36 AM, David Majnemer > wrote: > >> >> >> On Mon, Jul 11, 2016 at 7:18 AM, Nico Weber wrote: >> >>> VS2013's cl.exe doesn't understand /Zd,

r275078 - [Sema] Don't artificially forbid BuiltinTemplateDecls in CheckTemplateArgument

Author: majnemer Date: Mon Jul 11 12:09:56 2016 New Revision: 275078 URL: http://llvm.org/viewvc/llvm-project?rev=275078=rev Log: [Sema] Don't artificially forbid BuiltinTemplateDecls in CheckTemplateArgument After thinking about it, we don't really need to forbid BuiltinTemplateDecls

RE: r275040 - [CodeGen] Treat imported static local variables as declarations

This changes the IR but not the debug-info metadata? --paulr > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > David Majnemer via cfe-commits > Sent: Sunday, July 10, 2016 9:28 PM > To: cfe-commits@lists.llvm.org > Subject: r275040 -

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

carlo.bertolli updated this revision to Diff 63527. carlo.bertolli added a comment. [OpenMP] Apply comments: remove creation of private variable and update regression tests to include references to pointers. Repository: rL LLVM http://reviews.llvm.org/D21904 Files:

Re: [PATCH] D22222: [ASTMatchers] isSignedInteger() and isUnsignedInteger()

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Please regenerate the public docs (using dump_ast_matchers.py). Otherwise, LGTM! http://reviews.llvm.org/D2 ___ cfe-commits

Re: [PATCH] D22170: [OpenCL] Fixes opencl.cl testcase issues and cl-strict-aliasing only allowed with cl-std=CL

ashi1 marked 4 inline comments as done. Comment at: lib/Frontend/CompilerInvocation.cpp:1681 @@ -1692,1 +1680,3 @@ + // -cl-strict-aliasing needs to emit diagnostic in the case where CL > 1.0. + // This option should be deprecated for CL > 1.0 because

Re: [PATCH] D20795: Added basic capabilities to detect source code clones.

NoQ added a comment. Your code is well-written and easy to understand, and makes me want to use it on my code! Added some minor comments, and there seems to be a small logic error in the compound statement hasher. Not sure if that was already explained in detail, but i seem to agree that the

Re: r274991 - [clang-cl] Add support for /Zd

On Mon, Jul 11, 2016 at 11:36 AM, David Majnemer wrote: > > > On Mon, Jul 11, 2016 at 7:18 AM, Nico Weber wrote: > >> VS2013's cl.exe doesn't understand /Zd, 2015's doesn't either. This means >> people who want to ask clang-cl for line tables only

Re: r274991 - [clang-cl] Add support for /Zd

On Mon, Jul 11, 2016 at 11:51 AM, David Majnemer wrote: > > > On Mon, Jul 11, 2016 at 8:42 AM, Nico Weber wrote: > >> On Mon, Jul 11, 2016 at 11:36 AM, David Majnemer < >> david.majne...@gmail.com> wrote: >> >>> >>> >>> On Mon, Jul 11, 2016 at 7:18

[PATCH] D22222: [ASTMatchers] isSignedInteger() and isUnsignedInteger()

courbet created this revision. courbet added a reviewer: aaron.ballman. courbet added a subscriber: cfe-commits. Herald added a subscriber: klimek. I could not find a way to match signedness of integers in the AST, so I'm adding these two matchers. http://reviews.llvm.org/D2 Files:

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7868 @@ +7867,3 @@ +def warn_sampler_initializer_invalid_bits : Warning< + "Sampler initializer has invalid %0 bits">, InGroup; +def err_sampler_initializer_not_constant : Error<

  1   2   >