LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22476: [AST] Make MemberExpr non-dependent according to core issue 224

mgehre created this revision. mgehre added reviewers: klimek, aaron.ballman, rsmith. mgehre added a subscriber: cfe-commits. A MemberExpr is non-dependent if 1) it is a member of the current instantiation 2) the member is non-dependent We check 1) by asserting that the base of the MemberExpr is

r275913 - [Coverage] Normalize '..' out of filename strings

Author: vedantk Date: Mon Jul 18 16:01:27 2016 New Revision: 275913 URL: http://llvm.org/viewvc/llvm-project?rev=275913=rev Log: [Coverage] Normalize '..' out of filename strings This fixes the issue of having duplicate entries for the same file in a coverage report s.t none of the entries

Re: [PATCH] D22248: [Sema] Create a separate group for incompatible function pointer warning

bruno closed this revision. bruno added a comment. Thanks, r275907. https://reviews.llvm.org/D22248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22476: [AST] Make MemberExpr non-dependent according to core issue 224

rsmith added inline comments. Comment at: lib/AST/Expr.cpp:1425 @@ +1424,3 @@ + + if (E->isTypeDependent() && isa(base)) { +bool MemberOfCurrentInstantiation = true; The language rule for this says nothing about the base being a `this` expression; there are

Re: r263019 - [OpenMP] Add support for multidimensional array sections in map clause SEMA.

On Wed, Mar 9, 2016 at 7:46 AM, Samuel Antao via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: sfantao > Date: Wed Mar 9 09:46:05 2016 > New Revision: 263019 > > URL: http://llvm.org/viewvc/llvm-project?rev=263019=rev > Log: > [OpenMP] Add support for multidimensional array sections

Re: [PATCH] D20748: Handle recursion in LLVMIRGeneration Timer

davide added a comment. Richard, can you please take a look at this? The more I look at it the more it seems weird that we can recurse in this case, but I may miss something https://reviews.llvm.org/D20748 ___ cfe-commits mailing list

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

rengolin added inline comments. Comment at: docs/Proposals/GitHub.rst:208 @@ +207,3 @@ +3. Make sure we have an llvm-project (with submodules) setup in the official + account, with all necessary hooks (history, update, merges). +4. Make sure bisecting with llvm-project works.

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

mehdi_amini added inline comments. Comment at: docs/Proposals/GitHub.rst:209 @@ +208,3 @@ + well as a webhook to update the umbrella project (see below). +3. Make sure we have an llvm-project (with submodules) setup in the official + account, with all necessary hooks

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

majnemer added a comment. Could you please attach a diff with additional context? Comment at: lib/Driver/ToolChains.cpp:3717-3735 @@ -3678,1 +3716,21 @@ + // We need a detected GCC installation on Linux to provide libstdc++'s + // headers. We handled the libc++ case above.

Re: [PATCH] D21228: Deprecated (legacy) string literal conversion to 'char *' causes strange overloading resolution

a.makarov added a comment. Friendly ping! https://reviews.llvm.org/D21228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20786: Fix undefined behavior in __tree

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. I'm not really happy with this situation, but I don't see how to improve this patch. https://reviews.llvm.org/D20786 ___ cfe-commits

[libcxx] r275787 - Change a couple ifdefs from '#if __cplusplus >= 2011xxx' to '#ifndef _LIBCPP_CXX03_LANG'. No functionality change.

Author: marshall Date: Mon Jul 18 08:19:00 2016 New Revision: 275787 URL: http://llvm.org/viewvc/llvm-project?rev=275787=rev Log: Change a couple ifdefs from '#if __cplusplus >= 2011xxx' to '#ifndef _LIBCPP_CXX03_LANG'. No functionality change. Modified: libcxx/trunk/include/iterator

Re: [PATCH] D21637: [libcxx] Don't use pthread initializers in constexpr constructors

elram added a comment. I don't have commit access. Can someone do it for me please? https://reviews.llvm.org/D21637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15075: No error for conflict between inputs\outputs and clobber list

zizhar added a comment. Hello Hans, Regarding the changes in intrin.h, You're the last to change/add these lines, I found out that there is a conflict between the clobber list and input or output lists. Can you review this change? Thanks, Ziv Izhar https://reviews.llvm.org/D15075

Re: [PATCH] D21678: Fix For pr28288 - Error message in shift of vector values

vbyakovl added a comment. Ping! https://reviews.llvm.org/D21678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22431: clang-format: [JS] nested and tagged template strings.

djasper added inline comments. Comment at: lib/Format/FormatTokenLexer.cpp:231 @@ -230,3 +230,3 @@ void FormatTokenLexer::tryParseTemplateString() { FormatToken *BacktickToken = Tokens.back(); I think, this could now use an elaborate comment on what it is

Re: [PATCH] D15075: No error for conflict between inputs\outputs and clobber list

majnemer added a subscriber: majnemer. Comment at: lib/Headers/Intrin.h:841-874 @@ -840,44 +840,36 @@ #if defined(__i386__) || defined(__x86_64__) static __inline__ void __DEFAULT_FN_ATTRS __movsb(unsigned char *__dst, unsigned char const *__src, size_t __n) { - __asm__("rep

Re: [PATCH] D22417: [OpenMP] update test cases for -std=c++11 compile

This revision was automatically updated to reflect the committed changes. Closed by commit rL275805: [OpenMP] update test cases for -std=c++11 compile (authored by kli). Changed prior to commit: https://reviews.llvm.org/D22417?vs=64270=64336#toc Repository: rL LLVM

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

olista01 updated this revision to Diff 64318. https://reviews.llvm.org/D22292 Files: src/UnwindRegistersRestore.S src/UnwindRegistersSave.S Index: src/UnwindRegistersSave.S === --- src/UnwindRegistersSave.S +++

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

compnerd added inline comments. Comment at: docs/Proposals/GitHub.rst:127 @@ +126,3 @@ +* The projects' repositories will remain identical, with a new address (GitHub). +* They'll continue to have SVN RW access, but will also gain Git RW access. +* The linear history can still

[PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

rengolin created this revision. rengolin added reviewers: lattner, chandlerc, jyknight, mehdi_amini, MatzeB, probinson, t.p.northover, chapuni, delcypher, dberlin, rsmith, beanz, cmatthews, asl, aaron.ballman, bcraig, Bigcheese, jroelofs, theraven, greened, hong.gyu.kim, rafael, AlexDenisov,

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 added a comment. > Please wait until someone has had the chance to review before committing (the > fix does not appear trivial and the original code broke code). I'm on > vacation today (in theory), but perhaps @rsmith will have a chance to review. Sure. Thanks.

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

rengolin removed rL LLVM as the repository for this revision. rengolin updated this revision to Diff 64334. rengolin added a comment. First round of changes reflecting reviews. https://reviews.llvm.org/D22463 Files: docs/Proposals/GitHub.rst Index: docs/Proposals/GitHub.rst

Re: [PATCH] D22208: clang-tidy] Fixes to modernize-use-emplace

Prazek added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D22208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

jroelofs added inline comments. Comment at: docs/Proposals/GitHub.rst:127 @@ +126,3 @@ +* The projects' repositories will remain identical, with a new address (GitHub). +* They'll continue to have SVN RW access, but will also gain Git RW access. +* The linear history can still

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

rengolin added inline comments. Comment at: docs/Proposals/GitHub.rst:127 @@ +126,3 @@ +* The projects' repositories will remain identical, with a new address (GitHub). +* They'll continue to have SVN RW access, but will also gain Git RW access. +* The linear history can still

Re: [PATCH] D15075: No error for conflict between inputs\outputs and clobber list

zizhar added a comment. Akira, You've mentioned a good point, this X86 logic should indeed be moved to X86TargetInfo. The current convertConstraint() implementation is not doing what I need – it doesn’t handle all the input/output constraints I need, and it returns the constraint in a

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

jroelofs added a subscriber: jroelofs. Comment at: docs/Proposals/GitHub.rst:127 @@ +126,3 @@ +* The projects' repositories will remain identical, with a new address (GitHub). +* They'll continue to have SVN RW access, but will also gain Git RW access. +* The linear history can

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

compnerd added inline comments. Comment at: docs/Proposals/GitHub.rst:167 @@ +166,3 @@ +with the limited number of developers whose job will be to mainly merge +thousands of patches a day. + rengolin wrote: > compnerd wrote: > > I don't fully understand how this

r275805 - [OpenMP] update test cases for -std=c++11 compile

Author: kli Date: Mon Jul 18 11:09:53 2016 New Revision: 275805 URL: http://llvm.org/viewvc/llvm-project?rev=275805=rev Log: [OpenMP] update test cases for -std=c++11 compile target_parallel_for_simd_collapse_messages.cpp and target_parallel_for_simd_ordered_messages.cpp give different

[libclc] r275813 - Replace llvm.AMDGPU.ldexp with llvm.amdgcn.ldexp

Author: arsenm Date: Mon Jul 18 11:42:50 2016 New Revision: 275813 URL: http://llvm.org/viewvc/llvm-project?rev=275813=rev Log: Replace llvm.AMDGPU.ldexp with llvm.amdgcn.ldexp It didn't really work on r600 to begin with, which should get its own intrinsic. Added:

Re: [PATCH] D21637: [libcxx] Don't use pthread initializers in constexpr constructors

mclow.lists closed this revision. mclow.lists added a comment. Committed as revision 275819. https://reviews.llvm.org/D21637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxx] r275114 - Don't compute modulus of hash if it is smaller than the bucket count.

> On 2016-Jul-17, at 13:11, Eric Fiselier wrote: > > Hi Duncan, > > It's possibly expected. It depends on what operation it's performing. I > expected a bit of a performance drop in some cases but I have a plan to fix > those. > Do you have a link to LNT? LNT is documented

Re: [PATCH] D22374: [analyzer] Copy and move constructors - ExprEngine extended for "almost trivial" copy and move constructors

a.sidorin added a comment. Adam, It is not a debug checker. It is UndefinedAssignment checker which correctly tells us that `Inner.y` is assigned with an uninitialized value while copying. So I wonder if we are allowed to skip such warnings because these warnings don't look like false

[clang-tools-extra] r275846 - Trunk release notes are now for 4.0.0

Author: hans Date: Mon Jul 18 13:08:59 2016 New Revision: 275846 URL: http://llvm.org/viewvc/llvm-project?rev=275846=rev Log: Trunk release notes are now for 4.0.0 The 3.9 release are on the 3.9 branch. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified:

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

majnemer added a subscriber: majnemer. Comment at: lib/Basic/Targets.cpp:718 @@ +717,3 @@ +Builder.defineMacro("_LONG_LONG"); +Builder.defineMacro("_ALL_SOURCE"); +Builder.defineMacro("_REENTRANT"); Are we really supposed to define this macro? Does

Re: r275820 - [analyzer] Add checker modeling potential C++ self-assignment

It seems to have broken this buildbot: http://bb.pgr.jp/builders/cmake-llvm-x86_64-linux/builds/40225/ I'm just about to create the 3.9 release branch, so it would be great if this could fixed/figured out soon. Thanks, Hans On Mon, Jul 18, 2016 at 10:23 AM, Devin Coughlin via cfe-commits

[libunwind] r275841 - Creating release_39 branch off revision 275826

Author: hans Date: Mon Jul 18 12:53:22 2016 New Revision: 275841 URL: http://llvm.org/viewvc/llvm-project?rev=275841=rev Log: Creating release_39 branch off revision 275826 Added: libunwind/branches/release_39/ - copied from r275826, libunwind/trunk/

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

emaste added a subscriber: emaste. Comment at: docs/Proposals/GitHub.rst:8-9 @@ +7,4 @@ + +This is a proposal to move our current revision control system from Subversion +to GitHub. Below are the financial and technical arguments as to why we need +such a move and how will people

Re: [PATCH] D21970: Add attribute abi_tag to the release notes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, and feel free to move to before the "no longer passes --build-id" item above. https://reviews.llvm.org/D21970 ___ cfe-commits mailing list

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

filcab added a subscriber: filcab. filcab added a comment. What about branches? I'm guessing we should expect the usual release branches. But will any person be able to create a branch? Will there be a policy, if this is the case? Is the policy enforceable? Comment at:

r275826 - [clang-cl] Reinstate -gline-tables-only as a CoreOption while we sort out the fate of /Zd

Author: rnk Date: Mon Jul 18 12:49:40 2016 New Revision: 275826 URL: http://llvm.org/viewvc/llvm-project?rev=275826=rev Log: [clang-cl] Reinstate -gline-tables-only as a CoreOption while we sort out the fate of /Zd Modified: cfe/trunk/include/clang/Driver/Options.td Modified:

Re: [libcxx] r275114 - Don't compute modulus of hash if it is smaller than the bucket count.

It looks like Shootout-C++ improved after that commit, if I'm reading these results correctly: http://llvm.org/perf/db_default/v4/nts/87812 > On 2016-Jul-17, at 15:16, Eric Fiselier wrote: > > FYI, > > I recommitted the previously removed optimization in r275734. I believe it

Re: [PATCH] D22426: Fix automatic detection of ARM MSVC toolset in clang.exe

rnk added a comment. In https://reviews.llvm.org/D22426#486129, @DaveBartolomeo wrote: > One reasonable solution would be to choose the toolset that is hosted on the > same architecture as the host of clang.exe (e.g. x64-hosted Clang looks for > x64-hosted MSVC). If this sounds good, I can

r275817 - Release note for 'nodebug' on variables

Author: probinson Date: Mon Jul 18 12:19:12 2016 New Revision: 275817 URL: http://llvm.org/viewvc/llvm-project?rev=275817=rev Log: Release note for 'nodebug' on variables Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL:

Re: [PATCH] D22200: [libc++] Fix macOS Sierra build issues by declaring basic_string(const allocator_type& __a) noexcept.

bruno added a subscriber: bruno. bruno added a comment. Hi, Can you provide more details on what the build issues are? It seems that the line you introduce is covered in the ifdef below, wonder why it's not triggering in your build? Repository: rL LLVM https://reviews.llvm.org/D22200

[libcxx] r275819 - Don't use pthread initializers in constexpr constructors. Patch by elram. Reviewed at https://reviews.llvm.org/D21637.

Author: marshall Date: Mon Jul 18 12:23:06 2016 New Revision: 275819 URL: http://llvm.org/viewvc/llvm-project?rev=275819=rev Log: Don't use pthread initializers in constexpr constructors. Patch by elram. Reviewed at https://reviews.llvm.org/D21637. Modified:

Re: [libcxx] r275114 - Don't compute modulus of hash if it is smaller than the bucket count.

> On 2016-Jul-18, at 10:43, Duncan P. N. Exon Smith > wrote: > > >> On 2016-Jul-17, at 13:11, Eric Fiselier wrote: >> >> Hi Duncan, >> >> It's possibly expected. It depends on what operation it's performing. I >> expected a bit of a performance drop in

[libcxx] r275832 - Creating release_39 branch off revision 275826

Author: hans Date: Mon Jul 18 12:52:56 2016 New Revision: 275832 URL: http://llvm.org/viewvc/llvm-project?rev=275832=rev Log: Creating release_39 branch off revision 275826 Added: libcxx/branches/release_39/ (props changed) - copied from r275826, libcxx/trunk/ Propchange:

[libcxxabi] r275833 - Creating release_39 branch off revision 275826

Author: hans Date: Mon Jul 18 12:52:59 2016 New Revision: 275833 URL: http://llvm.org/viewvc/llvm-project?rev=275833=rev Log: Creating release_39 branch off revision 275826 Added: libcxxabi/branches/release_39/ - copied from r275826, libcxxabi/trunk/

Re: [PATCH] D22057: Prevent devirtualization of calls to un-instantiated functions.

Sunil_Srivastava added a comment. Ping. https://reviews.llvm.org/D22057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19311: [analyzer] Self Assignment Checker

This revision was automatically updated to reflect the committed changes. Closed by commit rL275820: [analyzer] Add checker modeling potential C++ self-assignment (authored by dcoughlin). Changed prior to commit: https://reviews.llvm.org/D19311?vs=64135=64346#toc Repository: rL LLVM

r275820 - [analyzer] Add checker modeling potential C++ self-assignment

Author: dcoughlin Date: Mon Jul 18 12:23:30 2016 New Revision: 275820 URL: http://llvm.org/viewvc/llvm-project?rev=275820=rev Log: [analyzer] Add checker modeling potential C++ self-assignment This checker checks copy and move assignment operators whether they are protected against

Re: r275820 - [analyzer] Add checker modeling potential C++ self-assignment

Hans, I’m happy to revert — but I think r275820 is very unlikely to have been the root cause of the issue at http://bb.pgr.jp/builders/cmake-llvm-x86_64-linux/builds/40225/ . (The commit is a change to the clang static analyzer

r275844 - Trunk release notes are now for 4.0.0

Author: hans Date: Mon Jul 18 13:05:19 2016 New Revision: 275844 URL: http://llvm.org/viewvc/llvm-project?rev=275844=rev Log: Trunk release notes are now for 4.0.0 The 3.9 release are on the 3.9 branch. Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

probinson added a subscriber: probinson. Comment at: docs/Proposals/GitHub.rst:141 @@ +140,3 @@ +has commit access to our current repository. In the future, you only need to +provide the GitHub user to be granted access. + This reads a little bit like "we will

Re: [PATCH] D22010: Add more gcc compatibility names to clang's cpuid.h

bruno added a subscriber: bruno. Comment at: lib/Headers/cpuid.h:114 @@ -109,2 +113,3 @@ #define bit_AVX 0x1000 +#define bit_F16C0x2000 #define bit_RDRND 0x4000 Isn't this one also meant for gcc compat?

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

weimingz added inline comments. Comment at: src/UnwindRegistersRestore.S:325 @@ -324,4 +324,3 @@ DEFINE_LIBUNWIND_PRIVATE_FUNCTION(_ZN9libunwind13Registers_arm20restoreCoreAndJumpToEv) -#if !defined(__ARM_ARCH_ISA_ARM) - ldr r2, [r0, #52] - ldr r3, [r0, #60] +#if

Re: r275820 - [analyzer] Add checker modeling potential C++ self-assignment

Reverted in r275880. Sorry about that. I’ll have to investigate why I didn’t get an email from the bot about the failure. Thanks Devin > On Jul 18, 2016, at 11:59 AM, Hans Wennborg wrote: > > Oops, as you suspected I failed at copy/paste. This is the bot that's > broken:

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

weimingz added inline comments. Comment at: src/UnwindRegistersRestore.S:326 @@ +325,3 @@ +#if !defined(__ARM_ARCH_ISA_ARM) && __ARM_ARCH_ISA_THUMB == 1 + @ r8-r12: ldr into r1-r5, then mov to r8-r12 + ldr r1, [r0, #0x20] weimingz wrote: > originally, r0-r7 get

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

bcraig added a subscriber: bcraig. Comment at: src/UnwindRegistersRestore.S:325 @@ -324,4 +324,3 @@ DEFINE_LIBUNWIND_PRIVATE_FUNCTION(_ZN9libunwind13Registers_arm20restoreCoreAndJumpToEv) -#if !defined(__ARM_ARCH_ISA_ARM) - ldr r2, [r0, #52] - ldr r3, [r0, #60] +#if

Re: [PATCH] D21228: Deprecated (legacy) string literal conversion to 'char *' causes strange overloading resolution

rsmith accepted this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D21228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22285: Support -masm= flag for x86 assembly targets

bruno added a subscriber: bruno. bruno accepted this revision. bruno added a reviewer: bruno. bruno added a comment. This revision is now accepted and ready to land. LGTM with one small fix, see below. Comment at: lib/Driver/Tools.cpp:6379 @@ +6378,3 @@ +void

[libclc] r275874 - R600: Use new barrier intrinsic

Author: arsenm Date: Mon Jul 18 13:42:17 2016 New Revision: 275874 URL: http://llvm.org/viewvc/llvm-project?rev=275874=rev Log: R600: Use new barrier intrinsic Modified: libclc/trunk/r600/lib/synchronization/barrier_impl.ll Modified: libclc/trunk/r600/lib/synchronization/barrier_impl.ll

r275880 - Revert "[analyzer] Add checker modeling potential C++ self-assignment"

Author: dcoughlin Date: Mon Jul 18 13:57:50 2016 New Revision: 275880 URL: http://llvm.org/viewvc/llvm-project?rev=275880=rev Log: Revert "[analyzer] Add checker modeling potential C++ self-assignment" This reverts commit r275820. It is failing on the bots. Removed:

Re: [PATCH] D19311: [analyzer] Self Assignment Checker

dcoughlin reopened this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Re-opening. Reverted in r275880. It was causing a failure on the bots: http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/51780 Repository: rL LLVM

Re: [PATCH] D22075: [OpenMP] Fix incorrect diagnostics in map clause

davidsh updated this revision to Diff 64353. davidsh added a comment. Fix a typo in code and address test case issues. https://reviews.llvm.org/D22075 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/target_map_messages.cpp test/OpenMP/target_parallel_for_map_messages.cpp

Re: r251898 - [modules] Rationalize the behavior of Decl::declarationReplaces, and in

On 3 November 2015 at 04:13, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Mon Nov 2 21:13:11 2015 > New Revision: 251898 > > URL: http://llvm.org/viewvc/llvm-project?rev=251898=rev > Log: > [modules] Rationalize the behavior of

r275848 - docs/conf.py: update version to 4.0

Author: hans Date: Mon Jul 18 13:13:08 2016 New Revision: 275848 URL: http://llvm.org/viewvc/llvm-project?rev=275848=rev Log: docs/conf.py: update version to 4.0 Modified: cfe/trunk/docs/analyzer/conf.py cfe/trunk/docs/conf.py Modified: cfe/trunk/docs/analyzer/conf.py URL:

[clang-tools-extra] r275849 - docs/conf.py: update version to 4.0

Author: hans Date: Mon Jul 18 13:13:46 2016 New Revision: 275849 URL: http://llvm.org/viewvc/llvm-project?rev=275849=rev Log: docs/conf.py: update version to 4.0 Modified: clang-tools-extra/trunk/docs/conf.py Modified: clang-tools-extra/trunk/docs/conf.py URL:

[PATCH] D22470: [libcxx] Improve shared_ptr dtor performance

bcraig created this revision. bcraig added reviewers: jfb, mclow.lists, EricWF. bcraig added a subscriber: cfe-commits. If the last destruction is uncontended, skip the atomic store on __shared_weak_owners_. For x86_64, this results in an 8% improvement in shared_ptr ctor+dtor performance. Old

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

apaprocki added inline comments. Comment at: lib/Basic/Targets.cpp:718 @@ +717,3 @@ +Builder.defineMacro("_LONG_LONG"); +Builder.defineMacro("_ALL_SOURCE"); +Builder.defineMacro("_REENTRANT"); majnemer wrote: > Are we really supposed to define this

Re: r275820 - [analyzer] Add checker modeling potential C++ self-assignment

Oops, as you suspected I failed at copy/paste. This is the bot that's broken: http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/51780 On Mon, Jul 18, 2016 at 10:57 AM, Devin Coughlin wrote: > Hans, > > I’m happy to revert — but I think r275820 is very unlikely to

Re: [clang-tools-extra] r275886 - Unbreak extra tools build post r275882.

Thanks, I just checked out clang-tool-extras and was in the process of doing that :) — Mehdi > On Jul 18, 2016, at 12:21 PM, Benjamin Kramer via cfe-commits > wrote: > > Author: d0k > Date: Mon Jul 18 14:21:22 2016 > New Revision: 275886 > > URL:

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

majnemer added inline comments. Comment at: lib/Basic/Targets.cpp:718 @@ +717,3 @@ +Builder.defineMacro("_LONG_LONG"); +Builder.defineMacro("_ALL_SOURCE"); +Builder.defineMacro("_REENTRANT"); apaprocki wrote: > majnemer wrote: > > Are we really

[clang-tools-extra] r275886 - Unbreak extra tools build post r275882.

Author: d0k Date: Mon Jul 18 14:21:22 2016 New Revision: 275886 URL: http://llvm.org/viewvc/llvm-project?rev=275886=rev Log: Unbreak extra tools build post r275882. Modified: clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp clang-tools-extra/trunk/include-fixer/tool/ClangIncludeFixer.cpp

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

winksaville added a subscriber: winksaville. Comment at: docs/Proposals/GitHub.rst:132 @@ +131,3 @@ + +There is no need to additional tags, flags and properties, nor of external +services controlling the history, since both SVN and *git rev-list* can already This

Re: r275377 - Use hasFlag instead of hasArg

What build problem did this cause? Did this just not compile (it looks as if ArgList has hasArg and hasFlag, so I'm not sure what the specific problem might've been) On Wed, Jul 13, 2016 at 11:45 PM Dean Michael Berris via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dberris >

r275877 - Support -masm= flag for x86 assembly targets.

Author: ygao Date: Mon Jul 18 13:44:51 2016 New Revision: 275877 URL: http://llvm.org/viewvc/llvm-project?rev=275877=rev Log: Support -masm= flag for x86 assembly targets. For assembly files without .intel_syntax or .att_syntax directives, allow the -masm= flag to supply a default assembly

Re: [PATCH] D22285: Support -masm= flag for x86 assembly targets

ygao marked an inline comment as done. Comment at: lib/Driver/Tools.cpp:6379 @@ +6378,3 @@ +void ClangAs::AddX86TargetArgs(const ArgList , +ArgStringList ) const { + if (Arg *A = Args.getLastArg(options::OPT_masm_EQ)) { bruno

Re: [PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

This revision was automatically updated to reflect the committed changes. Closed by commit rL275895: [Driver] Compute effective target triples once per job (NFCI) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D22290?vs=64023=64367#toc Repository: rL LLVM

Re: [PATCH] D22289: [PATCH 1/2] [Driver] Make Driver::DefaultTargetTriple private (NFCI)

This revision was automatically updated to reflect the committed changes. Closed by commit rL275894: [Driver] Make Driver::DefaultTargetTriple private (NFCI) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D22289?vs=63756=64366#toc Repository: rL LLVM

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

rengolin updated this revision to Diff 64371. rengolin added a comment. Second round of suggestions applied. https://reviews.llvm.org/D22463 Files: docs/Proposals/GitHub.rst Index: docs/Proposals/GitHub.rst === --- /dev/null

Re: r275820 - [analyzer] Add checker modeling potential C++ self-assignment

Thanks, I've merged the revert in r275902. Cheers, Hans On Mon, Jul 18, 2016 at 12:06 PM, Devin Coughlin wrote: > Reverted in r275880. Sorry about that. I’ll have to investigate why I didn’t > get an email from the bot about the failure. > > Thanks > Devin > > On Jul 18,

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

rengolin added inline comments. Comment at: docs/Proposals/GitHub.rst:198 @@ +197,3 @@ +3. Make sure we have an llvm-project (with submodules) setup in the official + account. +4. Make sure bisecting with llvm-project works. mehdi_amini wrote: > Uh, this point

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

rengolin updated this revision to Diff 64373. rengolin added a comment. Removing "broken" to describe the history, just explaining it'll be local. Expanding to mention that hooks will need to be implemented in step 3. https://reviews.llvm.org/D22463 Files: docs/Proposals/GitHub.rst Index:

Re: [PATCH] D22465: [clang-rename] introduce better symbol finding and add few more tests

omtcyfz updated this revision to Diff 64374. https://reviews.llvm.org/D22465 Files: clang-rename/RenamingAction.cpp clang-rename/USRFinder.cpp clang-rename/USRLocFinder.cpp test/clang-rename/ClassNameInFunctionDefenition.cpp test/clang-rename/ComplicatedClassType.cpp

Re: [PATCH] D22069: clang-tidy modernize-loop-convert: preserve type of alias declaration (bug 28341)

mgehre added a comment. Friendly ping https://reviews.llvm.org/D22069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r275904 - Bump version # to 4.0.0

Author: marshall Date: Mon Jul 18 15:27:19 2016 New Revision: 275904 URL: http://llvm.org/viewvc/llvm-project?rev=275904=rev Log: Bump version # to 4.0.0 Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__config URL:

r275906 - Add missing header in ClangFuzzer (after r275882 cleanup)

Author: mehdi_amini Date: Mon Jul 18 15:33:09 2016 New Revision: 275906 URL: http://llvm.org/viewvc/llvm-project?rev=275906=rev Log: Add missing header in ClangFuzzer (after r275882 cleanup) Modified: cfe/trunk/tools/clang-fuzzer/ClangFuzzer.cpp Modified:

r275907 - [Sema] Create a separate group for incompatible function pointer warning

Author: bruno Date: Mon Jul 18 15:37:06 2016 New Revision: 275907 URL: http://llvm.org/viewvc/llvm-project?rev=275907=rev Log: [Sema] Create a separate group for incompatible function pointer warning Give incompatible function pointer warning its own diagnostic group but still leave it as a

Re: [PATCH] D22227: [ubsan] Disable bounds-check for flexible array ivars

vsk added a comment. Ping. https://reviews.llvm.org/D7 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22419: [CFG] Fix crash in thread sanitizer.

nandor updated this revision to Diff 64368. nandor added a comment. Fixed typo https://reviews.llvm.org/D22419 Files: lib/Analysis/CFG.cpp test/SemaCXX/warn-thread-safety-analysis.cpp Index: test/SemaCXX/warn-thread-safety-analysis.cpp

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

mehdi_amini added inline comments. Comment at: docs/Proposals/GitHub.rst:199 @@ +198,3 @@ + +Here's a proposed plan: + Annoyingly my comment does no longer show-up next to the point it was referring to, it was about your third point: > Make sure we have an

Re: [PATCH] D22465: [clang-rename] introduce better symbol finding and add few more tests

omtcyfz added a comment. Removed two `FIXME`s. Seems like types are now handled correctly. +1 test passing. https://reviews.llvm.org/D22465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r275905 - Allow iOS and tvOS version numbers with 2-digit major version numbers.

Author: bwilson Date: Mon Jul 18 15:29:14 2016 New Revision: 275905 URL: http://llvm.org/viewvc/llvm-project?rev=275905=rev Log: Allow iOS and tvOS version numbers with 2-digit major version numbers. rdar://problem/26921601 Modified: cfe/trunk/lib/Basic/Targets.cpp

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

apaprocki added inline comments. Comment at: lib/Basic/Targets.cpp:718 @@ +717,3 @@ +Builder.defineMacro("_LONG_LONG"); +Builder.defineMacro("_ALL_SOURCE"); +Builder.defineMacro("_REENTRANT"); majnemer wrote: > apaprocki wrote: > > majnemer wrote: > >

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

apaprocki updated this revision to Diff 64376. https://reviews.llvm.org/D18360 Files: lib/Basic/Targets.cpp lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp lib/Driver/Tools.h tools/libclang/CIndexer.cpp Index:

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

rengolin added inline comments. Comment at: docs/Proposals/GitHub.rst:200 @@ +199,3 @@ + +Here's a proposed plan: + You can click on the "<<" button and it will show where it was first inserted. That's how I found out. :) The hooks, AFAICS, will be added to the

  1   2   >