courbet updated this revision to Diff 65028.
courbet marked an inline comment as done.
https://reviews.llvm.org/D21992
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppcoreguidelines/SlicingCheck.cpp
clang-tidy/c
vmiklos added inline comments.
Comment at: clang-rename/RenamingAction.cpp:48
@@ +47,3 @@
+for (unsigned I = 0; I < NewNameList.size(); ++I) {
+ HandleOneRename(Context, NewNameList[I], PrevNameList[I], USRList[I]);
+}
klimek wrote:
> Question is whet
klimek added a comment.
Kirill, unless you have *specific* issues with this patch, I think it's good to
land.
Comment at: clang-rename/RenamingAction.cpp:48
@@ +47,3 @@
+for (unsigned I = 0; I < NewNameList.size(); ++I) {
+ HandleOneRename(Context, NewNameList[I], Prev
vmiklos updated this revision to Diff 65031.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
clang-rename/tool/clang-rename.py
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clan
vmiklos marked an inline comment as done.
vmiklos added a comment.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz updated this revision to Diff 65033.
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
Address comments.
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRLocFinder.cpp
te
omtcyfz added inline comments.
Comment at: clang-rename/USRFinder.cpp:94
@@ -91,4 +93,3 @@
const auto *Decl = NameLoc.getNestedNameSpecifier()->getAsNamespace();
- if (Decl && !setResult(Decl, NameLoc.getLocalBeginLoc(),
- Decl->getNameAsStr
NoQ added a comment.
Regarding the cache stack - it feels easier for me to allocate a separate stack
for each statement, and put the stack on stack (!) rather than having it
global. This way it'd be automatically cleaned for you when VisitStmt() exits,
and you'd be able to address child cache b
honggyu.kim created this revision.
honggyu.kim added reviewers: rjmccall, hans.
honggyu.kim added a subscriber: cfe-commits.
Since some profiling tools, such as gprof, ftrace, and uftrace, use
-pg option to generate a mcount function call at the entry of each
function. Function invocation can be d
honggyu.kim added a comment.
Hi John and Hans,
I don't know if I found right reviewers for this patch, but could you please
have a look at it?
I found this problem while I was trying to profile a binary that is compiled
with -pg and -O2 as I reported in bugzilla.
https://llvm.org/bugs/show_bug.
omtcyfz added inline comments.
Comment at: clang-rename/tool/ClangRename.cpp:19
@@ +18,3 @@
+#include "clang/Basic/Diagnostic.h"
+#include "clang/Basic/DiagnosticIDs.h"
+#include "clang/Basic/DiagnosticOptions.h"
Do we use anything from `DiagnosticIDs.h` here?
R
omtcyfz added a comment.
I'd be actually happy if instead of having `-rename-at` option we'd have this
behavior by default unless `-rename-all` is used.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
NoQ added a comment.
The natural way to avoid both heavy artillery with `StmtNodes.inc` and
low-performance if-chains is to use a //Visitor//.
(`Const`)`StmtVisitor` is implemented as a huge switch, contents of which are
auto-generated from `StmtNodes.inc`. In fact, your approach with
`StmtNod
hokein accepted this revision.
hokein added a comment.
Looks good now. Do you need I submit for you?
https://reviews.llvm.org/D21992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
olista01 updated this revision to Diff 65037.
olista01 added a comment.
Herald added a subscriber: samparker.
- Don't save/restore r12
- Use LDM when restoring r8-r11
https://reviews.llvm.org/D22292
Files:
src/UnwindRegistersRestore.S
src/UnwindRegistersSave.S
Index: src/UnwindRegistersSav
olista01 added inline comments.
Comment at: src/UnwindRegistersRestore.S:325-336
@@ -324,5 +324,14 @@
DEFINE_LIBUNWIND_PRIVATE_FUNCTION(_ZN9libunwind13Registers_arm20restoreCoreAndJumpToEv)
-#if !defined(__ARM_ARCH_ISA_ARM)
- ldr r2, [r0, #52]
- ldr r3, [r0, #60]
+#if !defined
vmiklos added a comment.
In https://reviews.llvm.org/D21814#492540, @omtcyfz wrote:
> I'd be actually happy if instead of having `-rename-at` option we'd have this
> behavior by default unless `-rename-all` is used.
Not sure I understand this request. rename-at and rename-all all subcommands,
courbet added a comment.
I can submit, thanks.
https://reviews.llvm.org/D21992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz added a comment.
> I can make the rename-at subcommand optional, and when not specifying a
> subcommand, assume rename-at was specified (unless -help or -version is
> used). Is this what you want?
Yep, exactly.
Sorry, I might have not expressed my idea good enough.
https://reviews.l
Author: d0k
Date: Fri Jul 22 04:07:16 2016
New Revision: 276400
URL: http://llvm.org/viewvc/llvm-project?rev=276400&view=rev
Log:
[include-fixer] Fix faulty sort predicate.
Note the == on the last line, this isn't a strict-weak ordering.
Modified:
clang-tools-extra/trunk/include-fixer/Includ
olista01 updated this revision to Diff 65039.
olista01 added a comment.
- ADD must be ADDS for Thumb1 (previous patch was an old version uploaded by
mistake)
https://reviews.llvm.org/D22292
Files:
src/UnwindRegistersRestore.S
src/UnwindRegistersSave.S
Index: src/UnwindRegistersSave.S
hokein added a comment.
Seems that you only uploaded the diff part, I only see the updated part of your
patch now, and can't see the whole patch now (The review page says "Context
not available"), could you upload the whole patch again?
Comment at: docs/clang-tidy/checks/misc
murrayc added inline comments.
Comment at: clang-tidy/modernize/ExplicitOperatorBoolCheck.cpp:38
@@ +37,3 @@
+ Finder->addMatcher(
+ cxxConversionDecl(returns(booleanType()), unless(isExplicit()))
+ .bind("operator-bool"),
alexfh wrote:
> Please mer
hubert.reinterpretcast created this revision.
hubert.reinterpretcast added reviewers: aaron.ballman, faisalv, rsmith.
hubert.reinterpretcast added a subscriber: cfe-commits.
This change fixes issues with `LLVM_CONSTEXPR` functions and
`TrailingObjects::FixedSizeStorage`. In particular, some of th
vmiklos added a comment.
Done, that also allows not modifying most existing tests.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vmiklos updated this revision to Diff 65042.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
clang-rename/tool/clang-rename.py
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clan
Alexander_Droste created this revision.
Alexander_Droste added reviewers: zaks.anna, dcoughlin.
Alexander_Droste added a subscriber: cfe-commits.
This patch corrects two comments which do not match the current behavior of the
checker.
https://reviews.llvm.org/D22670
Files:
lib/StaticAnalyzer/
Alexander_Droste created this revision.
Alexander_Droste added reviewers: zaks.anna, dcoughlin.
Alexander_Droste added a subscriber: cfe-commits.
This patch moves the MPIFunctionClassifier header to
`clang/include/clang/StaticAnalyzer/Checkers`,
in order to make it accessible in other parts of th
Alexander_Droste marked 7 inline comments as done.
Alexander_Droste added a comment.
https://reviews.llvm.org/D21962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Alexander_Droste updated this revision to Diff 65052.
Alexander_Droste added a comment.
- use new `MPIFunctionClassifier.h` path
- change `getAsCXXRecordDecl()->getNameAsString()` ->
`getAsCXXRecordDecl()->getName()`
- add comment to `addPair` lambda
- rename `ArgumentExpression` to `BufferExprs`
omtcyfz updated this revision to Diff 65053.
omtcyfz added a comment.
- reduce rate of hardcoding
- simplify symbol location finding
- introduce tests with templates, some of them are `PASS`ing
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
omtcyfz updated this revision to Diff 65054.
omtcyfz added a comment.
split declarations
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRFindingAction.cpp
clang-rename/USRLocFinder.cpp
test/cl
omtcyfz updated this revision to Diff 65056.
omtcyfz added a comment.
oops... actually split declarations
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRFindingAction.cpp
clang-rename/USRLocFin
omtcyfz updated this revision to Diff 65060.
omtcyfz added a comment.
remove redundant `#include` and `using` directives
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRFindingAction.cpp
clang-r
Author: courbet
Date: Fri Jul 22 07:42:19 2016
New Revision: 276408
URL: http://llvm.org/viewvc/llvm-project?rev=276408&view=rev
Log:
[clang-tidy] new cppcoreguidelines-slicing
Flags slicing of member variables or vtable. See:
https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidel
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks!
Comment at: clang-rename/USRFinder.h:49
@@ +48,3 @@
+// FIXME: This wouldn't be needed if
+// RecursiveASTVisitor::VisitNestedNameSpecifier would have been
implem
alexfh added a comment.
In https://reviews.llvm.org/D21962#492657, @Alexander_Droste wrote:
> Still, the type mismatch is somehow not found/listed by clang-tidy.
> When invoking `$LLVM_TRUNK/build/.../clang-tidy -checks='*' -list-checks |
> ag mpi`
> it does not show up. Something seems to be
alexfh added a subscriber: alexfh.
alexfh added a comment.
Specifically, this header is going to be used in the corresponding clang-tidy
check (see the dependent revision).
https://reviews.llvm.org/D22671
___
cfe-commits mailing list
cfe-commits@li
alexfh added a comment.
A few more nits. Please ensure the tests pass once you get the mpi module
linking to the clang-tidy binary.
Comment at: docs/clang-tidy/checks/mpi-type-mismatch.rst:4
@@ +3,3 @@
+mpi-type-mismatch
+==
+
Remove extra `
On Thu, Jul 21, 2016 at 6:34 PM, Robinson, Paul via cfe-commits
wrote:
>
>
>> -Original Message-
>> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
>> Simon Pilgrim via cfe-commits
>> Sent: Wednesday, July 20, 2016 3:18 AM
>> To: cfe-commits@lists.llvm.org
>> Sub
omtcyfz updated this revision to Diff 65066.
omtcyfz added a comment.
@alexfh, or wait... It's fine, I just forgot to add few tests, sorry.
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRFindingA
omtcyfz updated this revision to Diff 65065.
omtcyfz added a comment.
@alexfh, awww, sorry, I've uploaded wrong diff last time for whatever reason...
Can you review the changes please?
Now it contains many new tests and I managed to cut off unnecessary blocks of
code.
https://reviews.llvm.org
omtcyfz added inline comments.
Comment at: test/clang-rename/ComplicatedClassType.cpp:1-6
@@ -1,6 +1,7 @@
-// Unsupported test.
// RUN: cat %s > %t.cpp
-// FIXME: This test contains very simple constructions likely to be seen in any
-// project and therefore passing this test is
Author: courbet
Date: Fri Jul 22 08:33:51 2016
New Revision: 276413
URL: http://llvm.org/viewvc/llvm-project?rev=276413&view=rev
Log:
Revert "[clang-tidy] new cppcoreguidelines-slicing"
Tests fail on clang-x64-ninja-win7 due to too narrow expectation.
Removed:
clang-tools-extra/trunk/clang-t
Author: omtcyfz
Date: Fri Jul 22 08:41:09 2016
New Revision: 276414
URL: http://llvm.org/viewvc/llvm-project?rev=276414&view=rev
Log:
[clang-rename] introduce better symbol finding
This patch introduces:
* TypeLoc visiting, which helps a lot in renaming types
* NestedNameSpecifierLoc visiting (t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276414: [clang-rename] introduce better symbol finding
(authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D22465?vs=65066&id=65067#toc
Repository:
rL LLVM
https://reviews.llvm.
Does this apply to 3.9?
On Wed, Jul 20, 2016 at 11:28 PM, George Burgess IV via cfe-commits
wrote:
> Author: gbiv
> Date: Wed Jul 20 22:28:13 2016
> New Revision: 276232
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276232&view=rev
> Log:
> [Sema] Fix PR28623.
>
> In atomic builtins, we assume
Author: courbet
Date: Fri Jul 22 08:45:00 2016
New Revision: 276415
URL: http://llvm.org/viewvc/llvm-project?rev=276415&view=rev
Log:
Revert "Revert "[clang-tidy] new cppcoreguidelines-slicing""
Second try for r276408
Added:
clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/SlicingCheck.c
pipping added a subscriber: pipping.
pipping added a comment.
Any updates on this?
https://reviews.llvm.org/D5409
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Richard: should we merge this to 3.9?
On Thu, Jul 21, 2016 at 6:31 PM, Erik Pilkington via cfe-commits
wrote:
> Author: epilk
> Date: Thu Jul 21 17:31:40 2016
> New Revision: 276350
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276350&view=rev
> Log:
> [CodeGen] Fix a crash when constant foldi
Richard: should we merge this to 3.9?
On Thu, Jul 21, 2016 at 7:03 PM, David Majnemer via cfe-commits
wrote:
> Author: majnemer
> Date: Thu Jul 21 18:03:43 2016
> New Revision: 276352
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276352&view=rev
> Log:
> [Sema] Handle errors during rewriteBuil
Should we merge this to 3.9?
On Thu, Jul 21, 2016 at 3:38 AM, Craig Topper via cfe-commits
wrote:
> Author: ctopper
> Date: Thu Jul 21 02:38:43 2016
> New Revision: 276250
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276250&view=rev
> Log:
> [Sema,X86] Add explicit check to ensure that builti
Alexander_Droste marked 5 inline comments as done.
Alexander_Droste added a comment.
> You need to add this to ClangTidyMain.cpp:
Thanks for pointing this out and reviewing the code once more!
https://reviews.llvm.org/D21962
___
cfe-commits mailin
Alexander_Droste updated this revision to Diff 65072.
Alexander_Droste added a comment.
This update addresses all requested changes. All integration tests are still
passing.
https://reviews.llvm.org/D21962
Files:
clang-tidy/CMakeLists.txt
clang-tidy/mpi/CMakeLists.txt
clang-tidy/mpi/MPIT
Author: rksimon
Date: Fri Jul 22 08:58:56 2016
New Revision: 276417
URL: http://llvm.org/viewvc/llvm-project?rev=276417&view=rev
Log:
[X86][AVX] Added support for lowering to VBROADCASTF128/VBROADCASTI128 with
generic IR
As discussed on D22460, I've updated the vbroadcastf128 pd256/ps256 builtin
dsanders created this revision.
dsanders added a reviewer: sdardis.
dsanders added a subscriber: cfe-commits.
Unfortunately we can't enable it for all N64 because it is not yet possible to
distinguish N32 from N64 from the triple on other environments.
Alexander_Droste updated this revision to Diff 65074.
Alexander_Droste added a comment.
- fix typo
https://reviews.llvm.org/D21962
Files:
clang-tidy/CMakeLists.txt
clang-tidy/mpi/CMakeLists.txt
clang-tidy/mpi/MPITidyModule.cpp
clang-tidy/mpi/TypeMismatchCheck.cpp
clang-tidy/mpi/TypeMi
sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D22679
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
sdardis added a comment.
Yes, I think you should also reflect mpf's comment here too.
https://reviews.llvm.org/D22679
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdardis added a comment.
Actually, seeing your reply on the related patch, keep the comment as it
reflects trunk.
https://reviews.llvm.org/D22679
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
In many cases a transitively included header can be considered a part of a
public interface of an already included header, e.g. it's reasonable to assume
that DiagnosticIDs.h is a pa
Author: jvesely
Date: Fri Jul 22 10:00:08 2016
New Revision: 276423
URL: http://llvm.org/viewvc/llvm-project?rev=276423&view=rev
Log:
ptx: Fix builtin names after clang r274770
Signed-off-by: Jan Vesely
Acked-By: Aaron Watry
Modified:
libclc/trunk/ptx-nvidiacl/lib/synchronization/barrier.c
Author: emaste
Date: Fri Jul 22 10:00:42 2016
New Revision: 276424
URL: http://llvm.org/viewvc/llvm-project?rev=276424&view=rev
Log:
Merge r276128: libunwind: limit stack usage in unwind cursor
Modified:
libunwind/branches/release_39/ (props changed)
libunwind/branches/release_39/includ
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D22671
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
teemperor updated this revision to Diff 65086.
teemperor added a comment.
- StmtDataCollector is now using ConstStmtVisitor
- Added tests for StmtDataCollector
https://reviews.llvm.org/D22514
Files:
lib/Analysis/CloneDetection.cpp
test/Analysis/copypaste/test-asm.cpp
test/Analysis/copypas
zaks.anna added a comment.
Great!
How does this work when a path spans multiple files, specifically, when the
definitions from a header file are inlined? We could add file names but only in
cases the file name does not match the main file.
> and hard to navigate (especially when using a specia
Author: annat
Date: Fri Jul 22 10:37:56 2016
New Revision: 276425
URL: http://llvm.org/viewvc/llvm-project?rev=276425&view=rev
Log:
test commit. update comment grammatically. NFC
Modified:
cfe/trunk/lib/CodeGen/CGDeclCXX.cpp
Modified: cfe/trunk/lib/CodeGen/CGDeclCXX.cpp
URL:
http://llvm.org
jbcoe removed rL LLVM as the repository for this revision.
jbcoe updated this revision to Diff 65092.
jbcoe marked 2 inline comments as done.
jbcoe added a comment.
Addressed review comments, thanks for those, check is nicer now.
https://reviews.llvm.org/D22513
Files:
clang-tidy/cppcoreguidel
Error message says r272936 had the error, so it looks like it would, yeah.
:)
Would you like me to merge it to the 3.9 branch?
On Fri, Jul 22, 2016 at 6:51 AM, Hans Wennborg wrote:
> Does this apply to 3.9?
>
> On Wed, Jul 20, 2016 at 11:28 PM, George Burgess IV via cfe-commits
> wrote:
> > Au
john.brawn added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D1
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
john.brawn added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D21385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko added a comment.
It's used for DiagnosticIDs.. However, in https://reviews.llvm.org/D22656
Alexander told that DiagnosticIDs.h should be treated as part of Diagnostic.h.
Repository:
rL LLVM
https://reviews.llvm.org/D22654
___
cfe-
jbcoe updated this revision to Diff 65096.
jbcoe marked 6 inline comments as done.
jbcoe added a comment.
Address comments from review, thanks for those.
https://reviews.llvm.org/D22513
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModu
hfinkel added a subscriber: hfinkel.
hfinkel added a comment.
What's the actual desired behavior here? Should the inliner strip out calls to
mcount() as it inlines?
https://reviews.llvm.org/D22666
___
cfe-commits mailing list
cfe-commits@lists.llvm
rs added a subscriber: rs.
rs added a comment.
Hi Amjad,
are you still planning on getting this patch and
https://reviews.llvm.org/D16077 committed ? It looks like these two patches are
final pieces in the puzzle to get macro information in the DWARF debug output.
I've downloaded the diffs and
Eugene.Zelenko updated this revision to Diff 65099.
Eugene.Zelenko added a comment.
Don't include DiagnosticIDs.h.
Repository:
rL LLVM
https://reviews.llvm.org/D22656
Files:
clang-apply-replacements/tool/ClangApplyReplacementsMain.cpp
Index: clang-apply-replacements/tool/ClangApplyReplace
Author: jvesely
Date: Fri Jul 22 12:24:20 2016
New Revision: 276442
URL: http://llvm.org/viewvc/llvm-project?rev=276442&view=rev
Log:
AMDGPU: Use clang intrinsics for workitem builtins
v2: split into 2 patches
use clang builtins for other intrinsics as well
v3: Fix warnings
Switch r600 t
Author: jvesely
Date: Fri Jul 22 12:24:24 2016
New Revision: 276443
URL: http://llvm.org/viewvc/llvm-project?rev=276443&view=rev
Log:
AMDGPU: Implement get_global_offset builtin
Also fix get_global_id to consider offset
No idea how to add this for ptx, so they are stuck with the old get_global_id
Thanks Ranjeet,
Indeed I was planning to update the patches to top of trunk and reload them, so
if you can save me this trouble I would appreciate that.
Once we upload the updated patches I would like to ping the community and ask
for feedback.
Thanks,
Amjad
> -Original Message-
> From:
zaks.anna added inline comments.
Comment at: test/Analysis/PR12421.c:11
@@ +10,2 @@
+
+// CHECK: warning: Path diagnostic report is not generated. HTMLDiagnostics
does not support diagnostics that cross file boundaries.
We should use the name of the diagnostic co
Author: chapuni
Date: Fri Jul 22 12:33:04 2016
New Revision: 276445
URL: http://llvm.org/viewvc/llvm-project?rev=276445&view=rev
Log:
ClangRenameTests: Update libdeps.
Modified:
clang-tools-extra/trunk/unittests/clang-rename/CMakeLists.txt
Modified: clang-tools-extra/trunk/unittests/clang-re
weimingz added a comment.
LGTM.
Maybe @renato can review it too.
Thanks Oliver and Saleem.
https://reviews.llvm.org/D22292
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benlangmuir added a comment.
> Can you point me to the source codes where we use rename to replace the file?
> I am curious on how this all works out.
This is the same as clang's handling of other output files. See
{{CompilerInstance::createOutputFile}} and {{clearOutputFiles}}. When we are
Author: annat
Date: Fri Jul 22 12:50:08 2016
New Revision: 276448
URL: http://llvm.org/viewvc/llvm-project?rev=276448&view=rev
Log:
Clang changes for overloading invariant.start and end intrinsics
This change depends on the corresponding LLVM change at:
https://reviews.llvm.org/D22519
The llvm.i
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, kkwli0.
sfantao added subscribers: cfe-commits, caomhin.
This patch fixes a bug in the map of array sections whose base is a reference
to a pointer. The existing mapping support was not prepared to deal with
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: cfe-commits, caomhin.
This patch adds support for the use_device_ptr clause. It includes changes in
SEMA that could not be tested without codegen, namely, the
rjmccall added a comment.
In https://reviews.llvm.org/D22666#493026, @hfinkel wrote:
> What's the actual desired behavior here? Should the inliner strip out calls
> to mcount() as it inlines?
I think they basically just want a late pass (as in immediately prior to
codegen) to insert the mcoun
manmanren added a comment.
In https://reviews.llvm.org/D22636#493072, @benlangmuir wrote:
> > Can you point me to the source codes where we use rename to replace the
> > file? I am curious on how this all works out.
>
>
> This is the same as clang's handling of other output files. See
> {{Comp
ashi1 updated this revision to Diff 65118.
ashi1 marked an inline comment as done.
ashi1 added a comment.
Revised based on Sam's comments. Added to tests
Misc\amdgcn.languageOptsOpenCL.cl and SemaOpenCL\extension-version.cl
Repository:
rL LLVM
https://reviews.llvm.org/D22637
Files:
includ
Author: pirama
Date: Fri Jul 22 13:49:43 2016
New Revision: 276455
URL: http://llvm.org/viewvc/llvm-project?rev=276455&view=rev
Log:
Add .rgba syntax extension to ext_vector_type types
Summary:
This patch enables .rgba accessors to ext_vector_type types and adds
tests for syntax validation and co
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276455: Add .rgba syntax extension to ext_vector_type types
(authored by pirama).
Changed prior to commit:
https://reviews.llvm.org/D20602?vs=62305&id=65119#toc
Repository:
rL LLVM
https://reviews.l
yaxunl added inline comments.
Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:190
@@ +189,3 @@
+// expected-warning@-1{{unsupported OpenCL extension 'cl_khr_mipmap_image' -
ignoring}}
+#endif
+
we also need to check the else case for `__OPENCL_C_VERSION__ < 20
mgehre added a comment.
Friendly ping
https://reviews.llvm.org/D15031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
This revision is now accepted and ready to land.
LGTM, given the comments are addressed.
Comment at: include/clang/Analysis/CloneDetection.h:37
@@ +36,3 @@
+ /// Stmt, then S is a pointer to this Stmt.
+ Stmt c
Most of these have been broken like this for a long time so I'm not sure.
This patch as is depends on r276249 too since we were missing qualifiers in
the intrinsics file.
~Craig
On Fri, Jul 22, 2016 at 6:55 AM, Hans Wennborg wrote:
> Should we merge this to 3.9?
>
> On Thu, Jul 21, 2016 at 3:38
sfantao updated this revision to Diff 65123.
sfantao added a comment.
- Use the correct enumerator for return pointer, as specified in the design
document.
https://reviews.llvm.org/D22691
Files:
include/clang/AST/OpenMPClause.h
lib/AST/OpenMPClause.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
l
ashi1 updated this revision to Diff 65126.
ashi1 marked an inline comment as done.
ashi1 added a comment.
Revised based on Sam's comments.
Repository:
rL LLVM
https://reviews.llvm.org/D22637
Files:
include/clang/Basic/OpenCLExtensions.def
lib/Basic/Targets.cpp
test/Misc/amdgcn.language
v.g.vassilev added a comment.
Could we stress test the implementation by running on files from llvm's/clang's
test suite. For example, for a test TST we could do something like: cat TST >>
tmp_TST; cat TST >> tmp_TST and run our our copy-paste checker on tmp_TST.
This way we know how many clon
Author: ericwf
Date: Fri Jul 22 15:04:56 2016
New Revision: 276462
URL: http://llvm.org/viewvc/llvm-project?rev=276462&view=rev
Log:
Merging r276215:
r276215 | ericwf | 2016-07-20 17:56:42 -0600 (Wed, 20 Jul 2016) | 9 lines
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D22637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
1 - 100 of 144 matches
Mail list logo
