[PATCH] D22788: [OpenMP] Code generation for the is_device_ptr clause

sfantao created this revision. sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0. sfantao added subscribers: cfe-commits, caomhin. This patch adds support for the is_device_ptr clause. It expands SEMA to use the mappable expression logic that can only be tested with

Re: [PATCH] D22773: Modules: add command line option fmodules-disable-diagnostic-validation to disable validation of the diagnostic options when loading the module

manmanren added a comment. In https://reviews.llvm.org/D22773#495524, @benlangmuir wrote: > > the pcm could still be rewritten by a compilation that doesn't use a PCH, > > and then it would be out of date because of the timestamp instead of the > > diagnostic options > > > > > > "a

Re: [PATCH] D22773: Modules: add command line option fmodules-disable-diagnostic-validation to disable validation of the diagnostic options when loading the module

manmanren updated this revision to Diff 65449. manmanren added a comment. Addressing Ben's comments https://reviews.llvm.org/D22773 Files: include/clang/Driver/Options.td include/clang/Lex/HeaderSearchOptions.h include/clang/Serialization/ASTReader.h lib/Frontend/CompilerInvocation.cpp

Re: [PATCH] D22513: [clang-tidy] add check cppcoreguidelines-rule-of-five-and-zero

jbcoe marked an inline comment as done. jbcoe added a comment. https://reviews.llvm.org/D22513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22515: Added false-positive filter for unintended hash code collisions to the CloneDetector.

teemperor added a comment. This patch is no longer needed because the CloneDetector from patch https://reviews.llvm.org/D20795 no longer uses custom hashing. https://reviews.llvm.org/D22515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22725: [clang-tidy] Add check 'misc-replace-memcpy'

etienneb added inline comments. Comment at: clang-tidy/modernize/UseAlgorithmCheck.cpp:73 @@ +72,3 @@ + Finder->addMatcher( + callExpr(allOf(callee(functionDecl(matchesName("::memcpy"))), + argumentCountIs(3))) It's more efficient to use

[PATCH] D22785: [OpenMP] diagnose orphaned teams construct

kkwli0 created this revision. kkwli0 added reviewers: ABataev, sfantao, carlo.bertolli, arpith-jacob, hfinkel. kkwli0 added a subscriber: cfe-commits. The spec mandates that 'a teams construct must be contained within a target construct'. Currently, this scenario is not diagnosed. This patch

Re: [PATCH] D22391: [Sema] Add warning for implicitly casting a null constant to a non null pointer type

ahatanak updated this revision to Diff 65446. ahatanak added a comment. Addressed review comment and made a couple of other changes. - Move Sema::diagnoseNullPtrToNonnullCast to SemaChecking.cpp. - In diagnoseNullPtrToNonnullCast, call "Type::isAnyPointerType" instead of "Type::isPointerType"

Re: [PATCH] D22782: Added 'inline' attribute to __init to inline the basic_string's constructor

sebpop added a comment. In https://reviews.llvm.org/D22782#495436, @mclow.lists wrote: > Do we have a test for the problem that this is solving? I think we can write a testcase that shows that copy constructors are not optimized away unless the string constructor is inlined. This patch fixes

Re: [PATCH] D22773: Modules: add command line option fmodules-disable-diagnostic-validation to disable validation of the diagnostic options when loading the module

benlangmuir added a comment. We need to add this option to the module hash (see getModuleHash - we already add a bunch of other HSOpts there). Otherwise the pcm could still be rewritten by a compilation that doesn't use a PCH, and then it would be out of date because of the timestamp instead

r276696 - [Sema][ObjC] Compute the nullability of a conditional expression based

Author: ahatanak Date: Mon Jul 25 16:58:19 2016 New Revision: 276696 URL: http://llvm.org/viewvc/llvm-project?rev=276696=rev Log: [Sema][ObjC] Compute the nullability of a conditional expression based on the nullabilities of its operands. This commit is a follow-up to r276076 and enables

Re: [PATCH] D22782: Added 'inline' attribute to __init to inline the basic_string's constructor

mclow.lists added a comment. Do we have a test for the problem that this is solving? https://reviews.llvm.org/D22782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22773: Modules: add command line option fmodules-disable-diagnostic-validation to disable validation of the diagnostic options when loading the module

manmanren added a comment. In https://reviews.llvm.org/D22773#495403, @benlangmuir wrote: > We need to add this option to the module hash (see getModuleHash - we already > add a bunch of other HSOpts there). Otherwise the pcm could still be > rewritten by a compilation that doesn't use a PCH,

[libclc] r276704 - Make min follow the OCL 1.0 specs

Author: jvesely Date: Mon Jul 25 17:36:22 2016 New Revision: 276704 URL: http://llvm.org/viewvc/llvm-project?rev=276704=rev Log: Make min follow the OCL 1.0 specs OpenCL 1.0: "Returns y if y < x, otherwise it returns x. If x *and* y are infinite or NaN, the return values are undefined." OpenCL

Re: [PATCH] D22773: Modules: add command line option fmodules-disable-diagnostic-validation to disable validation of the diagnostic options when loading the module

benlangmuir added a comment. > the pcm could still be rewritten by a compilation that doesn't use a PCH, and > then it would be out of date because of the timestamp instead of the > diagnostic options > > "a compilation that doesn't use a PCH", is that a different project? And we > have two

r276711 - [CMake] Pass DYLD_LIBRARY_PATH as CMake variable instead of as envar

Author: cbieneman Date: Mon Jul 25 18:48:14 2016 New Revision: 276711 URL: http://llvm.org/viewvc/llvm-project?rev=276711=rev Log: [CMake] Pass DYLD_LIBRARY_PATH as CMake variable instead of as envar On OS X 10.11 System Integrity Protection prevents the DYLD environment variables from being

Re: [PATCH] D20795: Added basic capabilities to detect source code clones.

teemperor updated this revision to Diff 65441. teemperor added a comment. - The CloneGroup values in StringMap no longer store a copy of their own key. https://reviews.llvm.org/D20795 Files: include/clang/Analysis/CloneDetection.h include/clang/StaticAnalyzer/Checkers/Checkers.td

Re: [PATCH] D22513: [clang-tidy] add check cppcoreguidelines-rule-of-five-and-zero

jbcoe removed rL LLVM as the repository for this revision. jbcoe updated this revision to Diff 65423. jbcoe added a comment. Fix underline length in docs. https://reviews.llvm.org/D22513 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

Re: [PATCH] D20795: Added basic capabilities to detect source code clones.

teemperor added inline comments. Comment at: lib/Analysis/CloneDetection.cpp:178 @@ +177,3 @@ + + bool VisitFunctionDecl(FunctionDecl *D) { +// If we found a function, we start the clone search on its body statement. NoQ wrote: > You'd probably want to add

Re: [PATCH] D20795: Added basic capabilities to detect source code clones.

teemperor marked 3 inline comments as done. teemperor added a comment. https://reviews.llvm.org/D20795 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22697: [ObjC Availability] Consider lexical context of use of declaration when emitting availability diagnostics

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM except one nit. Manman Comment at: include/clang/Sema/Sema.h:9595 @@ -9594,1 +9594,3 @@ + + VersionTuple getCurContextVersion() const; Can

[PATCH] D22787: [OpenMP] Add support to map member expressions with references to pointers.

sfantao created this revision. sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0. sfantao added subscribers: cfe-commits, caomhin. This patch add support to map pointers through references in class members. Although a reference does not have storage that a user can

Re: [PATCH] D22725: [clang-tidy] Add check 'misc-replace-memcpy'

Prazek added a comment. In https://reviews.llvm.org/D22725#495329, @etienneb wrote: > In https://reviews.llvm.org/D22725#494167, @Prazek wrote: > > > hmm It seems that I mislead you, I suck at C api - memmove source and > > destination can overlap, but std::move can't. So I guess you have to

Re: [PATCH] D20795: Added basic capabilities to detect source code clones.

teemperor updated this revision to Diff 65439. teemperor marked 7 inline comments as done. teemperor added a comment. - Fixed the minor problems as pointed out by Artem. - Now using AnalysisConsumer instead of RecursiveASTVisitor. - Function names are now confirming to LLVM code-style. - Renamed

r276716 - [Coverage] Do not write out coverage mappings with zero entries

Author: vedantk Date: Mon Jul 25 19:24:59 2016 New Revision: 276716 URL: http://llvm.org/viewvc/llvm-project?rev=276716=rev Log: [Coverage] Do not write out coverage mappings with zero entries After r275121, we stopped mapping regions from system headers. Lambdas declared in regions belonging to

[PATCH] D22794: [Sema] Propagate nullability when deducing type of auto

ahatanak created this revision. ahatanak added a reviewer: doug.gregor. ahatanak added a subscriber: cfe-commits. This patch fixes Sema to propagate the nullability of the initializer expression of a variable declared with auto or __auto_type to the deduced type. The patch consists of two

Re: [PATCH] D22787: [OpenMP] Add support to map member expressions with references to pointers.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D22787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22788: [OpenMP] Code generation for the is_device_ptr clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with some nits Comment at: include/clang/AST/OpenMPClause.h:4419 @@ -4405,1 +4418,3 @@ + } + /// \brief Build clause with number of variables \a NumVars. ///

Re: [PATCH] D21343: Implement `lcm` and `gcd` from library fundamentals V2

mclow.lists updated this revision to Diff 65463. mclow.lists added a comment. Updated with Eric's constexpr tests. Once this is approved, it will be applied twice - once in ``, and once in `` https://reviews.llvm.org/D21343 Files: include/experimental/numeric

Re: [PATCH] D22785: [OpenMP] diagnose orphaned teams construct

kkwli0 added a comment. Will add the braces. Thanks. https://reviews.llvm.org/D22785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21343: Implement `lcm` and `gcd` from library fundamentals V2

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D21343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22785: [OpenMP] diagnose orphaned teams construct

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: lib/Sema/SemaOpenMP.cpp:3360-3366 @@ -3356,5 +3359,9 @@ if (NestingProhibited) { - SemaRef.Diag(StartLoc,

r276726 - [OpenMP] diagnose orphaned teams construct

Author: kli Date: Mon Jul 25 23:32:50 2016 New Revision: 276726 URL: http://llvm.org/viewvc/llvm-project?rev=276726=rev Log: [OpenMP] diagnose orphaned teams construct The OpenMP spec mandates that 'a teams construct must be contained within a target construct'. Currently, this scenario is not

Re: [PATCH] D22785: [OpenMP] diagnose orphaned teams construct

This revision was automatically updated to reflect the committed changes. Closed by commit rL276726: [OpenMP] diagnose orphaned teams construct (authored by kli). Changed prior to commit: https://reviews.llvm.org/D22785?vs=65430=65472#toc Repository: rL LLVM https://reviews.llvm.org/D22785

Re: [PATCH] D22663: Support setting default value for -rtlib at build time

zlei added a comment. In https://reviews.llvm.org/D22663#494460, @Hahnfeld wrote: > With the changes applied and configured with > `CLANG_DEFAULT_RTLIB=compiler-rt` some tests fail so you may have to adapt > the idea of `-rtlib=platform` for the tests. Got it. And I also need to fix those

Re: [llvm-dev] [RFC] Embedded bitcode and related upstream (Part II)

Hi, I hope I'm not breaking any mailing list etiquette by replying to this mail, but if I am then please accept my apologies. On Fri, Jun 3, 2016 at 8:36 PM, Steven Wu via llvm-dev wrote: > Hi everyone > > I am still in the process of upstreaming some improvements to

[clang-tools-extra] r276620 - [clang-rename] fix typos in tests

Author: omtcyfz Date: Mon Jul 25 03:56:11 2016 New Revision: 276620 URL: http://llvm.org/viewvc/llvm-project?rev=276620=rev Log: [clang-rename] fix typos in tests TemplateFunctionFindBy{Declaration|Use}.cpp contained typos and therefore were failing. clang-rename passes these tests after typos

[libunwind] r276625 - [libunwind][ARM] Add support for Thumb1 targets

Author: olista01 Date: Mon Jul 25 04:21:56 2016 New Revision: 276625 URL: http://llvm.org/viewvc/llvm-project?rev=276625=rev Log: [libunwind][ARM] Add support for Thumb1 targets The Thumb1 version of the code for saving and restoring the unwind context has a few bugs which prevent it from

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

This revision was automatically updated to reflect the committed changes. Closed by commit rL276625: [libunwind][ARM] Add support for Thumb1 targets (authored by olista01). Changed prior to commit: https://reviews.llvm.org/D22292?vs=65039=65317#toc Repository: rL LLVM

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

vladisld added a subscriber: vladisld. vladisld added a comment. Have the alternatives to sub-modules and monolithic repository been discussed ? Sub-modules have their disadvantages as described in the following blog post:

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

szepet updated this revision to Diff 65310. szepet added a comment. full diff submitted https://reviews.llvm.org/D22507 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/EnumMisuseCheck.cpp clang-tidy/misc/EnumMisuseCheck.h clang-tidy/misc/MiscTidyModule.cpp

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

etienneb added a comment. some nits Comment at: docs/clang-tidy/checks/misc-enum-misuse.rst:37 @@ +36,3 @@ +unsigned flag; +flag = A | H; //OK, disjoint value intervalls in the enum types > probably good use +flag = B | F; //warning, have common values so they are probably

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

This revision was automatically updated to reflect the committed changes. Closed by commit rL276640: MPITypeMismatchCheck for Clang-Tidy (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D21962?vs=65222=65351#toc Repository: rL LLVM https://reviews.llvm.org/D21962

Re: [PATCH] D22671: MPI-Checker: move MPIFunctionClassifier.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL276639: MPI-Checker: move MPIFunctionClassifier.h (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D22671?vs=65050=65348#toc Repository: rL LLVM

[clang-tools-extra] r276641 - Remove trailing spaces.

Author: alexfh Date: Mon Jul 25 10:43:22 2016 New Revision: 276641 URL: http://llvm.org/viewvc/llvm-project?rev=276641=rev Log: Remove trailing spaces. Modified: clang-tools-extra/trunk/test/clang-tidy/mpi-type-mismatch.cpp Modified:

[clang-tools-extra] r276640 - MPITypeMismatchCheck for Clang-Tidy

Author: alexfh Date: Mon Jul 25 10:43:14 2016 New Revision: 276640 URL: http://llvm.org/viewvc/llvm-project?rev=276640=rev Log: MPITypeMismatchCheck for Clang-Tidy Summary: This check verifies if buffer type and MPI (Message Passing Interface) datatype pairs match. All MPI datatypes defined by

Re: [clang-tools-extra] r276408 - [clang-tidy] new cppcoreguidelines-slicing

On Fri, Jul 22, 2016 at 2:42 PM, Clement Courbet via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: courbet > Date: Fri Jul 22 07:42:19 2016 > New Revision: 276408 > > URL: http://llvm.org/viewvc/llvm-project?rev=276408=rev > Log: > [clang-tidy] new cppcoreguidelines-slicing > > Flags

Re: [PATCH] D22227: [ubsan] Disable bounds-check for flexible array ivars

vsk added a comment. Ping. https://reviews.llvm.org/D7 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22045: [X86] Support of no_caller_saved_registers attribute (Clang part)

hjl.tools added a comment. no_caller_saved_registers attribute can be used with any calling conventions. https://reviews.llvm.org/D22045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22045: [X86] Support of no_caller_saved_registers attribute (Clang part)

On Mon, Jul 25, 2016 at 11:15 AM, H.J Lu wrote: > hjl.tools added a comment. > > no_caller_saved_registers attribute can be used with any calling conventions. Okay, so is it expected that use of this attribute through a function pointer is not going to produce the same

r276639 - MPI-Checker: move MPIFunctionClassifier.h

Author: alexfh Date: Mon Jul 25 10:27:16 2016 New Revision: 276639 URL: http://llvm.org/viewvc/llvm-project?rev=276639=rev Log: MPI-Checker: move MPIFunctionClassifier.h Summary: This patch moves the MPIFunctionClassifier header to `clang/include/clang/StaticAnalyzer/Checkers`, in order to

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

Prazek added a subscriber: Prazek. Comment at: clang-tidy/misc/EnumMisuseCheck.cpp:19 @@ +18,3 @@ + +// Stores a min and a max value which describe an interval. +struct ValueRange { s/\/\//\/\/\/ In other words, change // to /// (doxygen comment)

Re: [PATCH] D12664: Fixed comparison.

jtouton abandoned this revision. jtouton added a comment. This change was introduced quite some time ago now. https://reviews.llvm.org/D12664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22663: Support setting default value for -rtlib at build time

Hahnfeld requested changes to this revision. Hahnfeld added a comment. This revision now requires changes to proceed. In general the idea looks good and takes this point off my personal todo list :-) With the changes applied and configured with `CLANG_DEFAULT_RTLIB=compiler-rt` some tests fail

r276618 - Update description for CLANG_DEFAULT_CXX_STDLIB and add comment. NFC

Author: hahnfeld Date: Mon Jul 25 03:04:26 2016 New Revision: 276618 URL: http://llvm.org/viewvc/llvm-project?rev=276618=rev Log: Update description for CLANG_DEFAULT_CXX_STDLIB and add comment. NFC We agreed to call it "platform default" instead of "architecture default". (see D17286)

Re: [PATCH] D21748: Implement tooling::Replacements as a class.

ioeric added a comment. ping :) https://reviews.llvm.org/D21748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22654: [Clang-rename] Remove custom version, fix extra space in error message

omtcyfz added a comment. Just remove it then? Repository: rL LLVM https://reviews.llvm.org/D22654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19815: Support '#pragma once' in headers when using PCH

This revision was automatically updated to reflect the committed changes. Closed by commit rL276653: Support '#pragma once' in headers when using PCH (authored by ssrivastava). Changed prior to commit: https://reviews.llvm.org/D19815?vs=57320=65372#toc Repository: rL LLVM

Re: [PATCH] D16538: [cc1as] Add MCTargetOptions argument to createAsmBackend

This revision was automatically updated to reflect the committed changes. Closed by commit rL276655: [cc1as] Add MCTargetOptions argument to createAsmBackend (authored by joel_k_jones). Changed prior to commit: https://reviews.llvm.org/D16538?vs=62793=65374#toc Repository: rL LLVM

Re: r276361 - Reverting r275115 which caused PR28634.

Merged the revert to 3.9 in r276656. Thanks, Hans On Mon, Jul 25, 2016 at 10:02 AM, Pieb, Wolfgang wrote: > Yes, it should. I'm just now realizing that the original change got into 3.9. > > Thanks, > Wolfgang > >> -Original Message- >> From: hwennb...@google.com

r276655 - [cc1as] Add MCTargetOptions argument to createAsmBackend

Author: joel_k_jones Date: Mon Jul 25 12:18:44 2016 New Revision: 276655 URL: http://llvm.org/viewvc/llvm-project?rev=276655=rev Log: [cc1as] Add MCTargetOptions argument to createAsmBackend Allow an assembler backend to get ABI options. This is to match the changes to

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

etienneb added a subscriber: etienneb. etienneb added a comment. thx for the check Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:25 @@ +24,3 @@ + const SourceManager = Context->getSourceManager(); + const LangOptions LangOpts = Context->getLangOpts(); +

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

yaxunl added inline comments. Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188 @@ +187,3 @@ +#endif +// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' - ignoring}} +#else Anastasia wrote: > Can you move this error message down

Re: [PATCH] D16989: Change interpretation of function definition in friend declaration of template class.

sepavloff updated this revision to Diff 65376. sepavloff added a comment. Added one more case in shouldLinkDependentDeclWithPrevious https://reviews.llvm.org/D16989 Files: include/clang/Sema/Sema.h lib/Sema/SemaDecl.cpp test/SemaCXX/PR25848.cpp test/SemaCXX/friend2.cpp Index:

Re: r275377 - Use hasFlag instead of hasArg

Ping? On Mon, Jul 18, 2016 at 11:28 AM David Blaikie wrote: > What build problem did this cause? Did this just not compile (it looks as > if ArgList has hasArg and hasFlag, so I'm not sure what the specific > problem might've been) > > On Wed, Jul 13, 2016 at 11:45 PM Dean

r276653 - Support '#pragma once' in headers when using PCH

Author: ssrivastava Date: Mon Jul 25 12:17:06 2016 New Revision: 276653 URL: http://llvm.org/viewvc/llvm-project?rev=276653=rev Log: Support '#pragma once' in headers when using PCH The '#pragma once' directive was erroneously ignored when encountered in the header-file specified in

[PATCH] D22767: [OpenCL] Added CLK_ABGR definition for get_image_channel_order return value

ashi1 created this revision. ashi1 added reviewers: yaxunl, Anastasia. ashi1 added a subscriber: cfe-commits. ashi1 set the repository for this revision to rL LLVM. Added CLK_ABGR definition for get_image_channel_order return value inside opencl-c.h file Repository: rL LLVM

Re: r276352 - [Sema] Handle errors during rewriteBuiltinFunctionDecl

Actually, I now see the PR doesn't reproduce on 3.9, so this must have broke after the branch point. On Fri, Jul 22, 2016 at 7:02 AM, Hans Wennborg wrote: > Richard: should we merge this to 3.9? > > On Thu, Jul 21, 2016 at 7:03 PM, David Majnemer via cfe-commits >

Re: [PATCH] D22767: [OpenCL] Added CLK_ABGR definition for get_image_channel_order return value

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rL LLVM https://reviews.llvm.org/D22767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxxabi] r276022 - Attempt to bring peace to -Werror buildbots.

Should we fix the diagnostic? Or is the code triggering it just esoteric enough to not be a good justification for changing the warning? On Tue, Jul 19, 2016 at 1:42 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Tue Jul 19 15:35:09 2016 > New

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

ashi1 added inline comments. Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188 @@ +187,3 @@ +#endif +// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' - ignoring}} +#else yaxunl wrote: > Anastasia wrote: > > Can you move this error

Re: r276102 - [X86][SSE] Reimplement SSE fp2si conversion intrinsics instead of using generic IR

Hi Simon (and all), I noticed that this patch changes the definition of intrinsic _mm_cvtsd2_ss in emmintrin.h. Is that intentional? My understanding is that your patch should have only addressed float-to-integer conversions. Was this change to _mm_cvtsd_ss motivated by the fact that (V)CVTSD2SS

Re: [PATCH] D20795: Added basic capabilities to detect source code clones.

NoQ added a comment. The idea with strings as keys is curious! I've got a few more minor comments :) Comment at: lib/Analysis/CloneDetection.cpp:104 @@ +103,3 @@ +// Storage for the signatures of the direct child statements. This is only +// needed if the current

Re: [PATCH] D19815: Support '#pragma once' in headers when using PCH

elsteveogrande added a comment. Looks like I have the "accept" ability in this repo, wasn't sure since I just registered for this recently :) I think since the tests look good, it's a nice and elegant 1-line change, per the reviewer's (@rsmith 's) comments, this should be ok to go. This would

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

alexfh added a subscriber: alexfh. Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:36 @@ +35,3 @@ +(llvm::Twine("forward<") + TypeParmType->getDecl()->getName() + + llvm::Twine(">")) +.str(); nit: The second `llvm::Twine`

Re: [PATCH] D21724: [RFC] Enhance synchscope representation (clang)

kzhuravl updated this revision to Diff 65343. kzhuravl added a comment. Remove metadata generation https://reviews.llvm.org/D21724 Files: lib/CodeGen/CGBuiltin.cpp Index: lib/CodeGen/CGBuiltin.cpp === ---

Re: [PATCH] D20811: [analyzer] Model some library functions

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:192 @@ +191,3 @@ + }; + + // The map of all functions supported by the checker. It is initialized Even though there are some doxygen-style comments in the

Re: [PATCH] D22654: [Clang-rename] Remove custom version, fix extra space in error message

Eugene.Zelenko updated this revision to Diff 65379. Eugene.Zelenko added a comment. Don't include DiagnosticIDs.h Repository: rL LLVM https://reviews.llvm.org/D22654 Files: clang-rename/tool/ClangRename.cpp test/clang-rename/InvalidNewName.cpp Index:

[PATCH] D22770: [Sema, NFC] Reset HasFallthroughStmt when clearing FunctionScopeInfo

erik.pilkington created this revision. erik.pilkington added a reviewer: rsmith. erik.pilkington added a subscriber: cfe-commits. The FunctionScopeInfo stack in Sema uses an optimization where the memory for the top-level functions is reused. The function FunctionScopeInfo::Clear() is used to

[ReviewRequest] [Sema/Parser] GCC Compatibility Patch: Support for __final specifier

Hi all, my first potential-contribution, so I apologize if I'm submitting this improperly, I'm unfamiliar with the 'type' keys that you use in the topic, so hopefully I have this right. As reported in bug 28473, GCC supports 'final' functionality in pre-C++11 code using the __final keyword.

Re: [PATCH] D22584: constexpr array support C++1z (P0031)

lefticus updated this revision to Diff 65390. lefticus added a comment. Fixed syntax errors in test files. https://reviews.llvm.org/D22584 Files: include/array include/iterator test/std/containers/sequences/array/at.pass.cpp test/std/containers/sequences/array/begin.pass.cpp

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

alexfh added a comment. A couple of nits. Comment at: clang-tidy/performance/InefficientStringConcatenationCheck.cpp:51 @@ +50,3 @@ + hasArgument( + 0, declRefExpr(BasicStringType), + declRefExpr(hasDeclaration(decl().bind("lhsStrT"))).bind("lhsStr")),

Re: [PATCH] D19544: Pass for translating math intrinsics to math library calls.

hfinkel added a comment. In https://reviews.llvm.org/D19544#492258, @mmasten wrote: > I think this is just saying that some of the weird types are not supported on > all targets. For now, is it ok to proceed with checking this code in? Correct. In https://reviews.llvm.org/D19544#493403,

Re: [libcxxabi] r276022 - Attempt to bring peace to -Werror buildbots.

+Richard Trieu - worth fixing? If anyone does get around to fixing this, would be good to remove the workaround committed here in r276022. On Mon, Jul 25, 2016 at 10:51 AM Richard Smith wrote: > On 25 Jul 2016 6:29 p.m., "David Blaikie via cfe-commits"

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

bittnerbarni added inline comments. Comment at: clang-tidy/performance/InefficientStringConcatenationCheck.cpp:55 @@ +54,3 @@ + hasDeclaration(decl(equalsBoundNode("lhsStrT"))), + hasDescendant(BasicStringPlusOperator)); + Yes

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

alexfh added a comment. Alexander, FYI, the patch has been reverted, since it breaks multiple buildbots, e.g. - http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/13909/steps/ninja%20check%201/logs/FAIL%3A%20Clang%20Tools%3A%3Ampi-type-mismatch.cpp -

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

bittnerbarni updated this revision to Diff 65384. bittnerbarni marked an inline comment as done. https://reviews.llvm.org/D20196 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/InefficientStringConcatenationCheck.cpp

Re: [PATCH] D22654: [Clang-rename] Remove custom version, fix extra space in error message

omtcyfz added a comment. lgtm Repository: rL LLVM https://reviews.llvm.org/D22654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22584: constexpr array support C++1z (P0031)

lefticus updated this revision to Diff 65398. lefticus added a comment. Correct context from last patch https://reviews.llvm.org/D22584 Files: include/array include/iterator test/std/containers/sequences/array/at.pass.cpp test/std/containers/sequences/array/begin.pass.cpp

Re: [PATCH] D17820: Clang Code Completion Filtering

CrisCristescu updated this revision to Diff 65401. CrisCristescu marked 3 inline comments as done. CrisCristescu added a comment. Addressing some sugesstions. Repository: rL LLVM https://reviews.llvm.org/D17820 Files: include/clang/Lex/Preprocessor.h

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

Alexander_Droste removed rL LLVM as the repository for this revision. Alexander_Droste updated this revision to Diff 65404. Alexander_Droste added a comment. Hi, thanks for the notification! Obviously, on some systems `char` is unsigned by default which is why the check now tolerates distinct

Re: [PATCH] D22584: constexpr array support C++1z (P0031)

lefticus marked 3 inline comments as done. lefticus added a comment. https://reviews.llvm.org/D22584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22584: constexpr array support C++1z (P0031)

lefticus added a comment. I believe all or most of the "untested" comments are correctly tested in the updated test files via static_asserts with contexpr. I've commented on just the first one to make sure I understand correctly. Comment at: include/array:156 @@ -155,3 +155,3

Re: [PATCH] D17820: Clang Code Completion Filtering

CrisCristescu updated this revision to Diff 65403. CrisCristescu marked an inline comment as done. CrisCristescu added a comment. PP CodeCompletionII initialisation. Repository: rL LLVM https://reviews.llvm.org/D17820 Files: include/clang/Lex/Preprocessor.h

Re: [PATCH] D22584: constexpr array support C++1z (P0031)

lefticus added a comment. I believe I messed up the context for the files, will attempt to resubmit the patch. https://reviews.llvm.org/D22584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22505: clang-format Access Modifier Use Normal Indent

LokiAstari added a comment. Hope you don't mind me chiming in: > Roughly go ahead with what you are suggesting, although the option should not > be called AccessModifierStandardIndent, as that carries no meaning and > actually is far from the "standard" way. Reasonable names that spring to

r276674 - [CMake] Cleaning up some CMake warnings

Author: cbieneman Date: Mon Jul 25 13:54:30 2016 New Revision: 276674 URL: http://llvm.org/viewvc/llvm-project?rev=276674=rev Log: [CMake] Cleaning up some CMake warnings In Bootstrap builds Clang logs some warnings. These are caused because Clang passes CLANG_STAGE and

Re: [ReviewRequest] [Sema/Parser] GCC Compatibility Patch: Support for __final specifier

I'd rename VS_Alt_Final to VS_GNU_Final. On Mon, Jul 25, 2016 at 2:24 PM, Keane, Erich via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi all, my first potential-contribution, so I apologize if I’m submitting > this improperly, I’m unfamiliar with the ‘type’ keys that you use in the >

Re: [PATCH] D22513: [clang-tidy] add check cppcoreguidelines-rule-of-five-and-zero

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/cppcoreguidelines-special-member-functions.rst:4 @@ +3,3 @@ +cppcoreguidelines-special-member-functions +=== + Size should be same as size of name above.

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos updated this revision to Diff 65417. https://reviews.llvm.org/D21814 Files: clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h clang-rename/tool/ClangRename.cpp clang-rename/tool/clang-rename.py docs/clang-rename.rst test/clang-rename/ClassFindByName.cpp

  1   2   >