Author: omtcyfz
Date: Fri Jul 29 05:16:45 2016
New Revision: 277131
URL: http://llvm.org/viewvc/llvm-project?rev=277131=rev
Log:
[clang-rename] speedup RenamingAction
The complexity of renaming a USR is O(N) [N stands for number of nodes in
Translation Unit]. In some cases there are more than
Author: asbokhan
Date: Fri Jul 29 05:42:48 2016
New Revision: 277134
URL: http://llvm.org/viewvc/llvm-project?rev=277134=rev
Log:
[GCC] Support for __final specifier
As reported in bug 28473, GCC supports "final" functionality in pre-C++11 code
using the __final keyword. Clang currently
vmiklos updated this revision to Diff 66105.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clang-rename/ClassTestMulti.cpp
vmiklos added a comment.
Rebased on top of r277131 and resolved conflicts.
> As for help message, look at clang-tidy. Is there a need in helpMain?
I think so; we have this chicken-and-egg problem (see earlier comments of this
review), that the options parser wants to know the option category,
vmiklos added a comment.
> Just write a FIXME then, I think I may look into that on the next week or
> somewhen.
Done.
> Most of the time I use Foo->Bar renaming in tests
Done, I've renamed ClaN->KlaN to FooN->BarN.
https://reviews.llvm.org/D21814
omtcyfz added a comment.
besides, let me push one thing; it's about passing a vector of USRs to the
USRLocFinder instead of passing them 1 by 1; removes a need to write that
`FIXME` of yours :)
https://reviews.llvm.org/D21814
___
cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277134: [GCC] Support for __final specifier (authored by
asbokhan).
Changed prior to commit:
https://reviews.llvm.org/D22919?vs=65951=66104#toc
Repository:
rL LLVM
https://reviews.llvm.org/D22919
omtcyfz added a comment.
In https://reviews.llvm.org/D21814#500481, @vmiklos wrote:
> > 1. Run `clang-format` or something, 80 char width limit is broken in
> > `tool/ClangRename.cpp` dozen of times.
>
>
> Done. I was afraid doing that, due to the changes not related to my patch, but
> the
omtcyfz added a comment.
In https://reviews.llvm.org/D21814#500506, @vmiklos wrote:
> Rebased on top of r277131 and resolved conflicts.
>
> > As for help message, look at clang-tidy. Is there a need in helpMain?
>
>
> I think so; we have this chicken-and-egg problem (see earlier comments of this
ioeric updated this revision to Diff 66093.
ioeric marked an inline comment as done.
ioeric added a comment.
- getShiftedCodePosition: do not minus 1 when there is no replacement text.
https://reviews.llvm.org/D21748
Files:
include/clang/Tooling/Core/Replacement.h
On 23/07/16 04:32, Richard Smith via cfe-commits wrote:
Author: rsmith
Date: Fri Jul 22 21:32:21 2016
New Revision: 276508
URL: http://llvm.org/viewvc/llvm-project?rev=276508=rev
Log:
Add -fmodules-ts flag to cc1 for the provisional C++ modules TS, and mark
'module' and 'import' as keywords
vmiklos added a comment.
Is there anything I can help with to get this accepted, please? As far as I see
I addressed all so far mentioned concerns. Thanks.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
omtcyfz added a subscriber: Eugene.Zelenko.
omtcyfz added a comment.
1. Run `clang-format` or something, 80 char width limit is broken in
`tool/ClangRename.cpp` dozen of times.
2. Only do `outs() << "abcd\n" << "efgh\n"` if you have something in between,
which can not be predefined. I.e. if you
vmiklos added a subscriber: Eugene.Zelenko.
vmiklos added a comment.
> 1. Run `clang-format` or something, 80 char width limit is broken in
> `tool/ClangRename.cpp` dozen of times.
Done. I was afraid doing that, due to the changes not related to my patch, but
the result doesn't seem to be too
omtcyfz added a comment.
Ping. Change is quite trivial.
https://reviews.llvm.org/D22853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D22957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hokein created this revision.
hokein added a reviewer: klimek.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D22957
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
omtcyfz updated this revision to Diff 66095.
omtcyfz added a comment.
git rebase; git resolve conflicts
https://reviews.llvm.org/D22853
Files:
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/TemplateTypenameFindByTemplateParam.cpp
vmiklos updated this revision to Diff 66099.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clang-rename/ClassTestMulti.cpp
Author: d0k
Date: Fri Jul 29 08:07:09 2016
New Revision: 277138
URL: http://llvm.org/viewvc/llvm-project?rev=277138=rev
Log:
Make test not fail on hosts where the default omp library is gomp.
This is the case on some linuxes, just force libomp so we get the
desired results.
Modified:
aaron.ballman added a comment.
In https://reviews.llvm.org/D22668#500340, @hubert.reinterpretcast wrote:
> In https://reviews.llvm.org/D22668#499164, @aaron.ballman wrote:
>
> > I don't suppose there's a way to test these changes, is there?
>
>
> It's a utility class (which is not even used
Author: hokein
Date: Fri Jul 29 08:57:27 2016
New Revision: 277142
URL: http://llvm.org/viewvc/llvm-project?rev=277142=rev
Log:
[ASTMatcher] Add hasTemplateArgument/hasAnyTemplateArgument support in
functionDecl.
Reviewers: klimek
Subscribers: klimek, cfe-commits
Differential Revision:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277142: [ASTMatcher] Add
hasTemplateArgument/hasAnyTemplateArgument support in… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D22957?vs=66094=66119#toc
Repository:
rL LLVM
vmiklos added a comment.
In https://reviews.llvm.org/D21814#500621, @omtcyfz wrote:
> P.S. not sure whether we have to write `clang-rename: for the -new-name
> option: must be specified` out. We already launched `clang-rename` what else
> could've give us an error?
You mean how is that error
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
Comment at: include/llvm/Support/MathExtras.h:672
@@ -669,2 +671,3 @@
inline uint64_t alignTo(uint64_t Value, uint64_t Align, uint64_t Skew =
omtcyfz added a comment.
P.S. not sure whether we have to write `clang-rename: for the -new-name option:
must be specified` out. We already launched `clang-rename` what else could've
give us an error?
https://reviews.llvm.org/D21814
___
Author: djasper
Date: Fri Jul 29 08:45:03 2016
New Revision: 277141
URL: http://llvm.org/viewvc/llvm-project?rev=277141=rev
Log:
Add missing '-no-canonical-prefixes' in test.
Modified:
cfe/trunk/test/Driver/offloading-interoperability.c
Modified:
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:60
@@ +59,3 @@
+ }
+}
+
Btw, with MSVC, this will give you a "not all control paths return a value"
warning. You should put an llvm_unreachable() after
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Fix an MSVC x64 compiler error due to mismatched iterator types.
This was attempting to store a list::iterator in a
list::iterator. That isn't guaranteed
jbcoe marked 9 inline comments as done.
jbcoe added a comment.
Repository:
rL LLVM
https://reviews.llvm.org/D22513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Fix an MSVC x64 compiler warning, "warning C4312: 'type cast': conversion from
'unsigned int' to 'int *' of greater size".
The warning (which is valuable) is simple to avoid:
vmiklos added a comment.
Great! Manuel, OK to land?
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I don't have easy access to Windows machine to test this, but it seems that whichever compiler is being used is broken. This is about a member function accessing a variable of the same class. I don't think I am doing any non-portable code pattern here.
Alexey, do you have a easy way to test
Author: probinson
Date: Fri Jul 29 15:46:16 2016
New Revision: 277211
URL: http://llvm.org/viewvc/llvm-project?rev=277211=rev
Log:
Fix CGOpenMPRuntime.cpp for VS2013. NFC.
I don't know why these changes work but they do.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
Modified:
jbcoe set the repository for this revision to rL LLVM.
jbcoe updated this revision to Diff 66161.
jbcoe added a comment.
Fix MSVC warning.
Repository:
rL LLVM
https://reviews.llvm.org/D22513
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
erichkeane created this revision.
erichkeane added reviewers: cfe-commits, andreybokhanko, aizatsky.
erichkeane set the repository for this revision to rL LLVM.
erichkeane added a project: clang-c.
My recent change to implement __final missed initializing the variable, which
was caught by the
andreybokhanko accepted this revision.
andreybokhanko added a comment.
This revision is now accepted and ready to land.
LGTM
I can commit this patch on Monday, when I will reach my work machine.
Andrey
Repository:
rL LLVM
https://reviews.llvm.org/D22970
I don't have the ability to commit this, but if it is blocking someone in some
way (since the build verifier would otherwise be broken), someone committing it
before then would be much appreciated.
Thanks!
-Erich
-Original Message-
From: Andrey Bokhanko
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277206: Ensure Ident_GNU_final is properly initialized in
the Parser Initialize function (authored by majnemer).
Changed prior to commit:
https://reviews.llvm.org/D22970?vs=66158=66165#toc
Repository:
Author: majnemer
Date: Fri Jul 29 15:01:12 2016
New Revision: 277206
URL: http://llvm.org/viewvc/llvm-project?rev=277206=rev
Log:
Ensure Ident_GNU_final is properly initialized in the Parser Initialize function
The recent change implementing __final forgot to initialize a variable.
This was
Fixed in: r277206 after review in https://reviews.llvm.org/D22970
From: Keane, Erich
Sent: Friday, July 29, 2016 11:58 AM
To: 'Andrey Bokhanko' ; Mike Aizatsky
Cc: cfe-commits
Subject: RE: r277134 - [GCC] Support for
I agree this looks like a compiler bug, but I'm not sure what's
causing it exactly. Putting "this->" in front of those accesses to
CurDir and CGF seems to fix it, but it's also very ugly.
I tried a couple of other things, like moving the method out-of-line,
but no luck yet.
On Fri, Jul 29, 2016
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin, rizsotto.mailinglist.
NoQ added a subscriber: cfe-commits.
It seems that the executable scripts are not marked as executable in the
repository, so i had to `chmod +x` them before using. Because the old
scan-build is `+x`, i
Author: compnerd
Date: Fri Jul 29 14:15:51 2016
New Revision: 277200
URL: http://llvm.org/viewvc/llvm-project?rev=277200=rev
Log:
CodeGen: try harder to make the CFString structure RW
The previous change was insufficient to mark the content as read-write as the
structure itself was marked
Author: rnk
Date: Fri Jul 29 14:43:28 2016
New Revision: 277205
URL: http://llvm.org/viewvc/llvm-project?rev=277205=rev
Log:
Fix naked.cpp test on 32-bit Windows
Modified:
cfe/trunk/test/CodeGenCXX/naked.cpp
Modified: cfe/trunk/test/CodeGenCXX/naked.cpp
URL:
Yes, it still appears to be broken:
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/26504/steps/run%20tests/logs/stdio
On Thu, Jul 28, 2016 at 1:30 PM, Samuel F Antao via cfe-commits
wrote:
> Hi Mike,
>
> I've already pushed r276981 and r276988 to fix
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Add TEST_STACK_ALLOCATOR_WORKAROUND. As I reported to Eric and Marshall:
"stack_allocator is seriously nonconformant to N4582 17.6.3.5
[allocator.requirements].
First,
On Fri, Jul 29, 2016 at 3:57 PM, Haojian Wu via cfe-commits
wrote:
> Author: hokein
> Date: Fri Jul 29 08:57:27 2016
> New Revision: 277142
>
> URL: http://llvm.org/viewvc/llvm-project?rev=277142=rev
> Log:
> [ASTMatcher] Add hasTemplateArgument/hasAnyTemplateArgument
hokein created this revision.
hokein added a reviewer: klimek.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D22963
Files:
docs/LibASTMatchersReference.html
include/clang/AST/ASTTypeTraits.h
include/clang/ASTMatchers/ASTMatchers.h
hokein updated this revision to Diff 66129.
hokein marked an inline comment as done.
hokein added a comment.
Fix code style.
https://reviews.llvm.org/D22963
Files:
docs/LibASTMatchersReference.html
include/clang/AST/ASTTypeTraits.h
include/clang/ASTMatchers/ASTMatchers.h
No, this is not templateName patch. The templateName one is in r277155.
On Fri, Jul 29, 2016 at 4:45 PM, Benjamin Kramer
wrote:
> On Fri, Jul 29, 2016 at 3:57 PM, Haojian Wu via cfe-commits
> wrote:
> > Author: hokein
> > Date: Fri Jul 29
hokein updated this revision to Diff 66131.
hokein added a comment.
Use new ast matchers to simplify the code.
Updating D22803: [clang-tidy] Fix an unused-using-decl false positive about
template arguments in
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Comment at: unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:550
@@ +549,3 @@
+"template class Y {};"
+ "X xi;",
+
hokein marked an inline comment as done.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:84-87
@@ -80,4 +83,6 @@
if (const auto *Used = Result.Nodes.getNodeAs("used")) {
-if (const auto *Specialization =
-dyn_cast(Used))
+if (const auto *FD =
Author: hokein
Date: Fri Jul 29 10:45:11 2016
New Revision: 277155
URL: http://llvm.org/viewvc/llvm-project?rev=277155=rev
Log:
[ASTMatcher] Add templateName matcher.
Reviewers: klimek
Subscribers: klimek, cfe-commits
Differential Revision: https://reviews.llvm.org/D22963
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277155: [ASTMatcher] Add templateName matcher. (authored by
hokein).
Changed prior to commit:
https://reviews.llvm.org/D22963?vs=66129=66130#toc
Repository:
rL LLVM
https://reviews.llvm.org/D22963
Author: aaronballman
Date: Fri Jul 29 16:41:18 2016
New Revision: 277217
URL: http://llvm.org/viewvc/llvm-project?rev=277217=rev
Log:
Sorting includes; NFC.
Modified:
clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp
Modified:
hubert.reinterpretcast updated this revision to Diff 66186.
hubert.reinterpretcast added a comment.
Replace call to LLVM_CONSTEXPR function in constant expression context
https://reviews.llvm.org/D22668
Files:
include/llvm/Support/AlignOf.h
include/llvm/Support/MathExtras.h
hubert.reinterpretcast updated this revision to Diff 66190.
hubert.reinterpretcast added a comment.
Make FixedSizeStorageOwner accessible to test code
https://reviews.llvm.org/D22668
Files:
include/llvm/Support/AlignOf.h
include/llvm/Support/MathExtras.h
Author: hans
Date: Fri Jul 29 17:48:24 2016
New Revision: 277237
URL: http://llvm.org/viewvc/llvm-project?rev=277237=rev
Log:
Creating release directory for release_390.
Added:
libcxxabi/tags/RELEASE_390/
___
cfe-commits mailing list
Author: hans
Date: Fri Jul 29 17:48:26 2016
New Revision: 277238
URL: http://llvm.org/viewvc/llvm-project?rev=277238=rev
Log:
Creating release candidate rc1 from release_390 branch
Added:
libcxxabi/tags/RELEASE_390/rc1/
- copied from r277237, libcxxabi/branches/release_39/
Author: hans
Date: Fri Jul 29 17:48:20 2016
New Revision: 277236
URL: http://llvm.org/viewvc/llvm-project?rev=277236=rev
Log:
Creating release candidate rc1 from release_390 branch
Added:
libcxx/tags/RELEASE_390/rc1/ (props changed)
- copied from r277235, libcxx/branches/release_39/
Author: hans
Date: Fri Jul 29 17:48:17 2016
New Revision: 277235
URL: http://llvm.org/viewvc/llvm-project?rev=277235=rev
Log:
Creating release directory for release_390.
Added:
libcxx/tags/RELEASE_390/
___
cfe-commits mailing list
Author: akirtzidis
Date: Fri Jul 29 21:20:21 2016
New Revision: 277261
URL: http://llvm.org/viewvc/llvm-project?rev=277261=rev
Log:
[c-index-test] Make sure to check that clang_Cursor_getNumTemplateArguments did
not return -1.
Modified:
cfe/trunk/tools/c-index-test/c-index-test.c
Modified:
Hi Hans,
Thanks for the troubleshooting. I'd prefer to avoid the 'this->', but if Alexey is okay with that I wouldn't mind. The best solution would be to update the compiler of the bot if there is a newer version and see if the issue goes away, but not sure if that is possible at all.
Thanks
Author: echristo
Date: Fri Jul 29 17:11:11 2016
New Revision: 277221
URL: http://llvm.org/viewvc/llvm-project?rev=277221=rev
Log:
Remove unused variable.
Fixes PR28761.
Modified:
cfe/trunk/lib/Headers/avx512fintrin.h
Modified: cfe/trunk/lib/Headers/avx512fintrin.h
URL:
teemperor created this revision.
teemperor added reviewers: v.g.vassilev, NoQ, zaks.anna.
teemperor added a subscriber: cfe-commits.
One of the current false-positives the CloneDetector produces is that the
statements `a < b ? b` and `b < a ? b` are considered clones of each other,
even though
Hi Hans,
Can you make sure this makes it into 3.9 please?
Thanks!
-eric
On Fri, Jul 29, 2016 at 3:18 PM Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: echristo
> Date: Fri Jul 29 17:11:11 2016
> New Revision: 277221
>
> URL:
dcoughlin added a comment.
As PR15623 shows, returning the existing cast is not correct. But rather than
replace it with an unknown, here is a proposal for how to address this without
regressing in precision.
Instead of using `assumeDual()` in `ExprEngine::VisitLogicalExpr()` on the
`RHSVal`
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Ok. LGTM.
Thank you!
Anna.
https://reviews.llvm.org/D22810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:216
@@ +215,3 @@
+llvm::raw_svector_ostream warning(buf);
+warning << "warning: Path diagnostic report is not generated. Current "
+<< "output format does not support
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM
Thank you!
https://reviews.llvm.org/D22926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
zaks.anna added a subscriber: Alexander_Droste.
zaks.anna added a comment.
> Even though there are some doxygen-style comments in the checkers, i’ve never
> seen doxygen actually generate any docs for checker classes.
> Are they useful for IDE quick-hints only?
I think it's useful to have
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:206
@@ +205,3 @@
+: Call.getArgExpr(ArgNo)->getType().getCanonicalType();
+ }
+ static QualType getArgType(const CallExpr *CE, ArgNoTy ArgNo) {
Author: hans
Date: Fri Jul 29 19:41:37 2016
New Revision: 277256
URL: http://llvm.org/viewvc/llvm-project?rev=277256=rev
Log:
Fix VS2013 build of CGOpenMPRuntime.cpp
It seems the compiler was getting confused by the in-class initializers
in local struct MapInfo, so moving those to a default
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Since this is an improvement, it looks good to me. (Improving printing of ObjC
methods is a good add on, but not blocking..)
https://reviews.llvm.org/D22856
It seems the compiler was getting thrown off by the in-class
initializers of the local MapInfo struct. I've tried to work around
this in r277256. Hopefully this will make the buildbots happier.
Cheers,
Hans
On Fri, Jul 29, 2016 at 2:20 PM, Samuel F Antao wrote:
> Hi Hans,
>
vsk added a subscriber: vsk.
vsk added a comment.
This is neat!
I may be missing something, but could you explain why 'false-positives.cpp' was
deleted? I'd expect the test to be incorporated into 'functions.cpp' with the
'expected-*' directives removed.
Comment at:
hubert.reinterpretcast updated this revision to Diff 66179.
hubert.reinterpretcast added a comment.
Address review comments: add tests, access control, Doxygen
https://reviews.llvm.org/D22668
Files:
include/llvm/Support/AlignOf.h
include/llvm/Support/MathExtras.h
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for the check! The oddness with the DenseMap can wait until a
follow-up patch, btw.
Repository:
rL LLVM
https://reviews.llvm.org/D22513
hubert.reinterpretcast updated this revision to Diff 66185.
hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added a comment.
Avoid MSVC C4099: replace 'struct' with 'class'
https://reviews.llvm.org/D22668
Files:
include/llvm/Support/AlignOf.h
Author: hans
Date: Fri Jul 29 17:48:51 2016
New Revision: 277249
URL: http://llvm.org/viewvc/llvm-project?rev=277249=rev
Log:
Creating release directory for release_390.
Added:
libunwind/tags/RELEASE_390/
___
cfe-commits mailing list
Author: hans
Date: Fri Jul 29 17:48:54 2016
New Revision: 277250
URL: http://llvm.org/viewvc/llvm-project?rev=277250=rev
Log:
Creating release candidate rc1 from release_390 branch
Added:
libunwind/tags/RELEASE_390/rc1/ (props changed)
- copied from r277249,
Author: emaste
Date: Fri Jul 29 16:24:19 2016
New Revision: 277215
URL: http://llvm.org/viewvc/llvm-project?rev=277215=rev
Log:
libunwind: correct return code in unwinding trace log message
Modified:
libunwind/trunk/src/Unwind-EHABI.cpp
Modified: libunwind/trunk/src/Unwind-EHABI.cpp
URL:
sfantao updated this revision to Diff 66189.
sfantao added a comment.
- Remove duplicate keyword in linker script.
https://reviews.llvm.org/D21847
Files:
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
lib/Driver/Tools.cpp
test/Driver/openmp-offload.c
Index:
hubert.reinterpretcast updated this revision to Diff 66194.
hubert.reinterpretcast added a comment.
Make FixedSizeStorage accessible to test code
FixedSizeStorage and not FixedSizeStorageOwner is what the test code needs. Use
alias template to avoid issues with MSVC.
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
https://reviews.llvm.org/D22668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
omtcyfz added a comment.
In https://reviews.llvm.org/D21814#500629, @vmiklos wrote:
> In https://reviews.llvm.org/D21814#500621, @omtcyfz wrote:
>
> > P.S. not sure whether we have to write `clang-rename: for the -new-name
> > option: must be specified` out. We already launched `clang-rename`
vmiklos added a comment.
Yes, exactly, so not easy to customize I guess.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mmasten
Date: Fri Jul 29 11:44:24 2016
New Revision: 277167
URL: http://llvm.org/viewvc/llvm-project?rev=277167=rev
Log:
Initial vectorization support for svml calls (short vector math library).
Differential Revision: https://reviews.llvm.org/D19544
Modified:
omtcyfz added a comment.
In https://reviews.llvm.org/D21814#500735, @vmiklos wrote:
> Yes, exactly, so not easy to customize I guess.
Aha, alright. Well, doesn't matter too much.
LGTM.
https://reviews.llvm.org/D21814
___
cfe-commits mailing
Sorry for being overly dense, you misspelled 'typename' in the docs.
On Fri, Jul 29, 2016 at 5:59 PM, Haojian Wu wrote:
> No, this is not templateName patch. The templateName one is in r277155.
>
> On Fri, Jul 29, 2016 at 4:45 PM, Benjamin Kramer
> wrote:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277166: Initial support for vectorization using svml (short
vector math library). (authored by mmasten).
Changed prior to commit:
https://reviews.llvm.org/D19544?vs=65152=66141#toc
Repository:
rL
Author: yaxunl
Date: Fri Jul 29 12:50:10 2016
New Revision: 277179
URL: http://llvm.org/viewvc/llvm-project?rev=277179=rev
Log:
[OpenCL] Added CLK_ABGR definition for get_image_channel_order return value
Added CLK_ABGR definition for get_image_channel_order return value inside
opencl-c.h file.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277179: [OpenCL] Added CLK_ABGR definition for
get_image_channel_order return value (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D22767?vs=65375=66149#toc
Repository:
rL
Author: yaxunl
Date: Fri Jul 29 12:52:34 2016
New Revision: 277181
URL: http://llvm.org/viewvc/llvm-project?rev=277181=rev
Log:
[OpenCL] Add extension cl_khr_mipmap_image to clang
Adding extension cl_khr_mipmap_image to clang's OpenCL Extensions and initiated
inside AMDGPU Target.
Patch by
Sounds like you care highly about your commit :-)
> On Jul 29, 2016, at 10:10 AM, Michael Kuperstein wrote:
>
> mkuper resigned from this revision.
> mkuper removed a reviewer: mkuper.
> mkuper added a comment.
>
> I really don't understand anything about this. :-)
>
>
mkuper resigned from this revision.
mkuper removed a reviewer: mkuper.
mkuper added a comment.
I really don't understand anything about this. :-)
https://reviews.llvm.org/D22900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jasonliu added a comment.
Ping?
https://reviews.llvm.org/D22698
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Oh, my bad...Fixed. Thanks!
On Fri, Jul 29, 2016 at 6:32 PM, Benjamin Kramer
wrote:
> Sorry for being overly dense, you misspelled 'typename' in the docs.
>
> On Fri, Jul 29, 2016 at 5:59 PM, Haojian Wu wrote:
> > No, this is not templateName patch. The
1 - 100 of 115 matches
Mail list logo