[clang-tools-extra] r277444 - [clang-tidy] Fix an unused-using-decl false positive about template arguments in

Author: hokein Date: Tue Aug 2 06:26:35 2016 New Revision: 277444 URL: http://llvm.org/viewvc/llvm-project?rev=277444=rev Log: [clang-tidy] Fix an unused-using-decl false positive about template arguments in function call expression. Summary: The check doesn't mark the template argument as used

Re: [PATCH] D22803: [clang-tidy] Fix an unused-using-decl false positive about template arguments infunction call expression.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rL277444: [clang-tidy] Fix an unused-using-decl false positive about template arguments in (authored by hokein). Changed prior to commit:

Re: [PATCH] D22505: clang-format Access Modifier Use Normal Indent

djasper added a comment. I generally agree. Note, however, that the mentioned style guide doesn't actually specify this. All it says is "The public, protected, and private keywords should be indented inside the class with the function declarations indented as well." So I guess, class C {

Re: [PATCH] D23008: [clang-tidy] fix segfault in cppcore-guidelines-special-member-functions check

jbcoe removed rL LLVM as the repository for this revision. jbcoe updated this revision to Diff 66444. jbcoe added a comment. Add test that triggers segfault without fix in place. https://reviews.llvm.org/D23008 Files: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp

[clang-tools-extra] r277437 - [clang-rename] add support for template parameter renaming

Author: omtcyfz Date: Tue Aug 2 04:38:38 2016 New Revision: 277437 URL: http://llvm.org/viewvc/llvm-project?rev=277437=rev Log: [clang-rename] add support for template parameter renaming Few simple tweaks allow template parameters to be renamed. See

Re: [PATCH] D22853: [clang-rename] add support for template parameter renaming

This revision was automatically updated to reflect the committed changes. Closed by commit rL277437: [clang-rename] add support for template parameter renaming (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D22853?vs=66373=66446#toc Repository: rL LLVM

[clang-tools-extra] r277438 - clang-rename: split existing options into two new subcommands

Author: vmiklos Date: Tue Aug 2 04:51:31 2016 New Revision: 277438 URL: http://llvm.org/viewvc/llvm-project?rev=277438=rev Log: clang-rename: split existing options into two new subcommands - rename-at is meant to be integrated with editors and works mainly off of a location in a file, and

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

This revision was automatically updated to reflect the committed changes. Closed by commit rL277438: clang-rename: split existing options into two new subcommands (authored by vmiklos). Changed prior to commit: https://reviews.llvm.org/D21814?vs=66362=66448#toc Repository: rL LLVM

Re: [PATCH] D23023: [include-fixer] Correct nested class search for identifiers with scoped information

hokein updated this revision to Diff 66452. hokein added a comment. Address review comments. https://reviews.llvm.org/D23023 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixerContext.cpp include-fixer/SymbolIndexManager.cpp include-fixer/SymbolIndexManager.h

Re: [PATCH] D23054: [clang-cl] Fix 2 pch tests to use x86_64 as target

rengolin added a subscriber: rengolin. rengolin added a comment. All tests should have the target explicit, so I'd advocate for all of them to be changed. Also, we need to make sure --target=x86_64 is enough on Windows. I remember some -target=arm not being enough (arm-eabi was enough, for

Re: [PATCH] D22431: clang-format: [JS] nested and tagged template strings.

djasper added inline comments. Comment at: lib/Format/FormatTokenLexer.cpp:254 @@ +253,3 @@ + for (; Offset != Lex->getBuffer().end(); ++Offset) { +if (*Offset == '`') { + StateStack.pop(); I'd use Offset[0] Comment at:

Re: [PATCH] D23023: [include-fixer] Correct nested class search for identifiers with scoped information

This revision was automatically updated to reflect the committed changes. Closed by commit rL277442: [include-fixer] Correct nested class search for identifiers with scoped… (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D23023?vs=66452=66454#toc Repository: rL LLVM

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Sorry for the delay. I almost missed that there was an update to the patch. Please mark addressed comments as "Done". This way it's easier for me to track changes and it's easier

Re: [PATCH] D22505: clang-format Access Modifier Use Normal Indent

klimek added a comment. Perhaps call it AccessModifierIntroducesScope or something? Side-track: I find it highly confusing that in class C { int v1; private: int v2; } v1 & v2 have different indent, although they are in the same scope. https://reviews.llvm.org/D22505

Re: [PATCH] D22514: CloneDetection now respects statement specific data when searching for clones.

This revision was automatically updated to reflect the committed changes. Closed by commit rL277449: [analyzer] Respect statement-specific data in CloneDetection. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D22514?vs=66309=66460#toc Repository: rL LLVM

Re: [PATCH] D22505: clang-format Access Modifier Use Normal Indent

klimek added a comment. (full disclosure: I'm also generally opposed to this change, but if there are really enough users using this it's probably a lost cause) https://reviews.llvm.org/D22505 ___ cfe-commits mailing list

Re: [libcxx] r277357 - Improve shared_ptr dtor performance

Hi Ben, Looks like there's a typo in this patch that is causing a buildbot failure: http://lab.llvm.org:8011/builders/libcxx-libcxxabi-singlethreaded-x86_64-linux-debian/builds/1128/steps/build.libcxx/logs/stdio Also seen in our local builders. I will fix it if I get around to it before you :)

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22853: [clang-rename] add support for template parameter renaming

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Comment at: clang-rename/USRFinder.cpp:80 @@ -79,1 +79,3 @@ TypeBeginLoc, 0, Context.getSourceManager(), Context.getLangOpts()); +if (const auto

[clang-tools-extra] r277442 - [include-fixer] Correct nested class search for identifiers with scoped information

Author: hokein Date: Tue Aug 2 05:43:10 2016 New Revision: 277442 URL: http://llvm.org/viewvc/llvm-project?rev=277442=rev Log: [include-fixer] Correct nested class search for identifiers with scoped information Summary: include-fixer will firstly try to use scoped namespace context information

Re: [PATCH] D22505: clang-format Access Modifier Use Normal Indent

klimek added a comment. In https://reviews.llvm.org/D22505#503278, @djasper wrote: > So you'd be for #1 of the three choices from my previous comment? Yes, because I think ultimately introducing scopes is different from simple outdents/indents. https://reviews.llvm.org/D22505

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

omtcyfz added a comment. //Make sure to rebase once more; documentation was updated in the last revision.// https://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22208: [clang-tidy] Fixes to modernize-use-emplace

alexfh added a comment. Please add revision number (this can be automated, if include differential revision URL in your commit message as described in http://llvm.org/docs/Phabricator.html#committing-a-change). https://reviews.llvm.org/D22208 ___

Re: [PATCH] D22834: Added 'inline' attribute to basic_string's destructor

On Sat, Jul 30, 2016 at 12:47 PM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Tue, Jul 26, 2016 at 10:30:22PM +, Laxman Sole via cfe-commits > wrote: > > Currently basic_string's destructor is not getting inlined. So adding > 'inline' attribute to

Re: [PATCH] D22505: clang-format Access Modifier Use Normal Indent

djasper added a comment. So you'd be for #1 of the three choices from my previous comment? https://reviews.llvm.org/D22505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r277449 - [analyzer] Respect statement-specific data in CloneDetection.

Author: dergachev Date: Tue Aug 2 07:21:09 2016 New Revision: 277449 URL: http://llvm.org/viewvc/llvm-project?rev=277449=rev Log: [analyzer] Respect statement-specific data in CloneDetection. So far the CloneDetector only respected the kind of each statement when searching for clones. This

r277457 - [clang-cl] Fix PCH tests to use x86_64 as target

Author: rovka Date: Tue Aug 2 08:53:00 2016 New Revision: 277457 URL: http://llvm.org/viewvc/llvm-project?rev=277457=rev Log: [clang-cl] Fix PCH tests to use x86_64 as target These tests require x86-registered-target, but they don't force the target as x86 on the command line, which means they

Re: [PATCH] D23054: [clang-cl] Fix PCH tests to use x86_64 as target

This revision was automatically updated to reflect the committed changes. Closed by commit rL277457: [clang-cl] Fix PCH tests to use x86_64 as target (authored by rovka). Changed prior to commit: https://reviews.llvm.org/D23054?vs=66467=66468#toc Repository: rL LLVM

Re: r277449 - [analyzer] Respect statement-specific data in CloneDetection.

Wow, i haven't noticed it's mine! Will have a look, sorry. On 8/2/16 5:51 PM, Renato Golin via cfe-commits wrote: On 2 August 2016 at 13:21, Artem Dergachev via cfe-commits wrote: Author: dergachev Date: Tue Aug 2 07:21:09 2016 New Revision: 277449 URL:

[clang-tools-extra] r277452 - clang-tools-extra/test/clang-rename/TemplateTypenameFindBy*.cpp: Appease targeting ms mode.

Author: chapuni Date: Tue Aug 2 08:17:40 2016 New Revision: 277452 URL: http://llvm.org/viewvc/llvm-project?rev=277452=rev Log: clang-tools-extra/test/clang-rename/TemplateTypenameFindBy*.cpp: Appease targeting ms mode. Modified:

[clang-tools-extra] r277451 - clang-tools-extra/test/clang-rename/TemplateTypenameFindBy*.cpp: Move RUN: lines below not to be affected by tweaks of parameters.

Author: chapuni Date: Tue Aug 2 08:17:36 2016 New Revision: 277451 URL: http://llvm.org/viewvc/llvm-project?rev=277451=rev Log: clang-tools-extra/test/clang-rename/TemplateTypenameFindBy*.cpp: Move RUN: lines below not to be affected by tweaks of parameters. Modified:

Re: [PATCH] D23054: [clang-cl] Fix PCH tests to use x86_64 as target

rovka retitled this revision from "[clang-cl] Fix 2 pch tests to use x86_64 as target" to "[clang-cl] Fix PCH tests to use x86_64 as target". rovka updated this revision to Diff 66467. rovka added a comment. Added cl-pch-errorhandling.cpp https://reviews.llvm.org/D23054 Files:

[PATCH] D23060: [analyzer] Show enabled checker list

xazax.hun created this revision. xazax.hun added reviewers: zaks.anna, dcoughlin, NoQ. xazax.hun added a subscriber: cfe-commits. This patch adds a command line option to list the checkers that were enabled by analyzer-checker and not disabled by -analyzer-disable-checker. It can be very useful

[PATCH] D23058: [clang-rename] add support for template instantiations

omtcyfz created this revision. omtcyfz added reviewers: alexfh, klimek. omtcyfz added a subscriber: cfe-commits. This patch introduces basic capabilities of renaming templated class and its specializations. https://reviews.llvm.org/D23058 Files: clang-rename/USRFinder.cpp

Re: r277449 - [analyzer] Respect statement-specific data in CloneDetection.

On 2 August 2016 at 13:21, Artem Dergachev via cfe-commits wrote: > Author: dergachev > Date: Tue Aug 2 07:21:09 2016 > New Revision: 277449 > > URL: http://llvm.org/viewvc/llvm-project?rev=277449=rev > Log: > [analyzer] Respect statement-specific data in

Re: [PATCH] D21814: clang-rename: split existing options into two new subcommands

vmiklos added a comment. Yes, I did that -- but I got no conflicts there. ;-) Repository: rL LLVM https://reviews.llvm.org/D21814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23014: [analyzer] Model base to derived casts more precisely.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:423 @@ +422,3 @@ + +if (!val.isZeroConstant()) { + val = getStoreManager().evalDynamicCast(val, T, Failed); I guess if `val` is a //non-zero// constant, it wouldn't

Re: [PATCH] D22853: [clang-rename] add support for template parameter renaming

chapuni added a subscriber: chapuni. chapuni added a comment. Seems a couple of tests would be incompatible to -fdelayed-template-parsing. Appeased in r277452. Repository: rL LLVM https://reviews.llvm.org/D22853 ___ cfe-commits mailing list

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

tavianator added a comment. Anything else I need to do for this patch? https://reviews.llvm.org/D21803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23014: [analyzer] Model base to derived casts more precisely.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:423 @@ +422,3 @@ + +if (!val.isZeroConstant()) { + val = getStoreManager().evalDynamicCast(val, T, Failed); xazax.hun wrote: > NoQ wrote: > > I guess if `val` is a

Re: [PATCH] D23054: [clang-cl] Fix 2 pch tests to use x86_64 as target

rovka added a comment. In https://reviews.llvm.org/D23054#503246, @rengolin wrote: > All tests should have the target explicit, so I'd advocate for all of them to > be changed. Coming right up... > Also, we need to make sure --target=x86_64 is enough on Windows. I remember > some

Re: [PATCH] D23014: [analyzer] Model base to derived casts more precisely.

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:423 @@ +422,3 @@ + +if (!val.isZeroConstant()) { + val = getStoreManager().evalDynamicCast(val, T, Failed); NoQ wrote: > I guess if `val` is a //non-zero//

Re: r277095 - [Parser] Fix bug where delayed typo in conditional expression was corrected twice

Sure, this is a pretty harmless bugfix. Cheers, Erik > On Aug 2, 2016, at 11:05 AM, Hans Wennborg wrote: > > Should we merge this to 3.9? > > Thanks, > Hans > > On Thu, Jul 28, 2016 at 5:55 PM, Erik Pilkington via cfe-commits > wrote: >> Author:

[libcxx] r277526 - [libcxx] basic_regex: add traits_type, string_type

Author: hubert.reinterpretcast Date: Tue Aug 2 16:34:48 2016 New Revision: 277526 URL: http://llvm.org/viewvc/llvm-project?rev=277526=rev Log: [libcxx] basic_regex: add traits_type, string_type Summary: In the synopsis in C++11 subclause 28.8 [re.regex], `basic_regex` is specified to have

r277537 - [CUDA] Do not allow using NVPTX target for host compilation.

Author: tra Date: Tue Aug 2 17:37:47 2016 New Revision: 277537 URL: http://llvm.org/viewvc/llvm-project?rev=277537=rev Log: [CUDA] Do not allow using NVPTX target for host compilation. Differential Revision: https://reviews.llvm.org/D23042 Modified:

Re: [PATCH] D23042: [CUDA] Do not allow using NVPTX target for host compilation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL277537: [CUDA] Do not allow using NVPTX target for host compilation. (authored by tra). Changed prior to commit: https://reviews.llvm.org/D23042?vs=66560=66578#toc Repository: rL LLVM

Re: [PATCH] D23042: [CUDA] Do not allow using NVPTX target for host compilation.

tra added a comment. In https://reviews.llvm.org/D23042#503869, @jlebar wrote: > > Restore assertions for presence of -march flag. > > > We don't need an explicit assertion in TranslateArgs? Nope. The action we create for fatbin uses CudaToolChain, but has nullptr BoundArch and there's no way

r277542 - [CUDA] Fix libdevice selection.

Author: tra Date: Tue Aug 2 18:12:51 2016 New Revision: 277542 URL: http://llvm.org/viewvc/llvm-project?rev=277542=rev Log: [CUDA] Fix libdevice selection. This makes clang's libdevice selection match that of NVCC as described in

Re: [PATCH] D22853: [clang-rename] add support for template parameter renaming

alexfh added a comment. In https://reviews.llvm.org/D22853#503303, @chapuni wrote: > Seems a couple of tests would be incompatible to -fdelayed-template-parsing. > Appeased in r277452. Thank you! And sorry for the inconvenience. Repository: rL LLVM https://reviews.llvm.org/D22853

Re: [PATCH] D23042: [CUDA] Do not allow using NVPTX target for host compilation.

tra marked an inline comment as done. tra added a comment. https://reviews.llvm.org/D23042 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r277539 - [clang-tidy] Fix missing dependency to static analyzer

Author: etienneb Date: Tue Aug 2 17:51:46 2016 New Revision: 277539 URL: http://llvm.org/viewvc/llvm-project?rev=277539=rev Log: [clang-tidy] Fix missing dependency to static analyzer Summary: This patch is fixing the build bot broken for a missing dependency. The missing dependency is

Re: [PATCH] D22670: MPI-Checker fix two comments

This revision was automatically updated to reflect the committed changes. Closed by commit rL277547: [analyzer] Update two comments in MPI-Checker. NFC. (authored by dcoughlin). Changed prior to commit: https://reviews.llvm.org/D22670?vs=65047=66594#toc Repository: rL LLVM

r277547 - [analyzer] Update two comments in MPI-Checker. NFC.

Author: dcoughlin Date: Tue Aug 2 18:24:40 2016 New Revision: 277547 URL: http://llvm.org/viewvc/llvm-project?rev=277547=rev Log: [analyzer] Update two comments in MPI-Checker. NFC. Correct two comments that do not match the current behavior of the checker. A patch by Alexander Droste!

Re: r277542 - [CUDA] Fix libdevice selection.

Sorry about that. I'll commit the fix shortly. On Tue, Aug 2, 2016 at 4:33 PM, Bruno Cardoso Lopes wrote: > Hi Artem, > > This broke > http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/26856 > , > can you take a look? > > Thanks, > > On Tue,

Re: [PATCH] D23042: [CUDA] Do not allow using NVPTX target for host compilation.

tra updated the summary for this revision. tra updated this revision to Diff 66560. tra added a comment. Added a comment describing why we delibrartly error out on use of NVPTX for host compilation. https://reviews.llvm.org/D23042 Files: include/clang/Basic/DiagnosticDriverKinds.td

Re: [PATCH] D23037: [CUDA] Fix libdevice selection.

tra updated this revision to Diff 66579. tra added a comment. Now that https://reviews.llvm.org/D23042 / r277537 makes sure that CudaToolchain is only used on device side, we can remove defaults for -march and restore asserts() ensuring that -march is added by the driver.

Re: r277542 - [CUDA] Fix libdevice selection.

Hi Artem, This broke http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/26856, can you take a look? Thanks, On Tue, Aug 2, 2016 at 4:12 PM, Artem Belevich via cfe-commits wrote: > Author: tra > Date: Tue Aug 2 18:12:51 2016 > New Revision:

Re: r277542 - [CUDA] Fix libdevice selection.

CUDA tests should be fixed in r277552. On Tue, Aug 2, 2016 at 4:48 PM, Artem Belevich wrote: > Sorry about that. I'll commit the fix shortly. > > On Tue, Aug 2, 2016 at 4:33 PM, Bruno Cardoso Lopes < > bruno.card...@gmail.com> wrote: > >> Hi Artem, >> >> This broke >>

Re: [PATCH] D18073: Add memory allocating functions

dcoughlin added a comment. In https://reviews.llvm.org/D18073#437171, @ariccio wrote: > I should elaborate. The principle of operation of this latest patch is that > the `FunctionDecl` in `IsCMemFunction` should never return a `nullptr` > `IdentifierInfo*` from `getIdentifier` (is that a valid

[PATCH] D23096: [Sema] Pass CombineWithOuterScope = true to constructor of LocalInstantiationScope

ahatanak created this revision. ahatanak added reviewers: rsmith, sepavloff. ahatanak added a subscriber: cfe-commits. This fixes PR28795. https://llvm.org/bugs/show_bug.cgi?id=28795 Sema wasn't replacing DependentScopeDeclRefExpr with DeclRefExpr during template instantiation of the default

r277552 - [CUDA] Updated CUDA tests that must run w/o CUDA installation.

Author: tra Date: Tue Aug 2 18:43:04 2016 New Revision: 277552 URL: http://llvm.org/viewvc/llvm-project?rev=277552=rev Log: [CUDA] Updated CUDA tests that must run w/o CUDA installation. Fixes test failures after r277542 on systems that don't have CUDA installed. Modified:

[clang-tools-extra] r277469 - [clang-rename] fix Emacs script build failure

Author: omtcyfz Date: Tue Aug 2 10:10:17 2016 New Revision: 277469 URL: http://llvm.org/viewvc/llvm-project?rev=277469=rev Log: [clang-rename] fix Emacs script build failure Clang-rename Emacs integration script sometimes doesn't work correctly. Modified:

r277473 - [analyzer] Hotfix for buildbot failure due to unspecified triple in r277449

Author: dergachev Date: Tue Aug 2 10:16:06 2016 New Revision: 277473 URL: http://llvm.org/viewvc/llvm-project?rev=277473=rev Log: [analyzer] Hotfix for buildbot failure due to unspecified triple in r277449 If a target triple is not specified, the default host triple is used, which is not good

Re: [PATCH] D23014: [analyzer] Model base to derived casts more precisely.

dcoughlin added a comment. Other than a naming/documentation suggestion, looks good to me. Thanks Gábor! Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:424 @@ +423,3 @@ +if (!val.isZeroConstant()) { + val = getStoreManager().evalDynamicCast(val, T,

Re: [PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

cameron314 added a comment. Anyone have time to check this out this week? It's a one-line fix, includes a test, and is for a fairly important bug :-) https://reviews.llvm.org/D20338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22698: [libcxx] Missing member types 'traits_type' and 'string_type' in class basic_regex

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D22698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22505: clang-format Access Modifier Use Normal Indent

djasper added a comment. No, I don't think so. Because you need a "double-indent" within classes. https://reviews.llvm.org/D22505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22782: Added 'inline' attribute to __init to inline the basic_string's constructor

EricWF added a subscriber: EricWF. EricWF added a comment. The change itself LGTM, although we probably want to inline the forward/input iterator __init's as well. However I would like to see a small benchmark that demonstrates the performance change. Please try and write the benchmark using

Re: [PATCH] D22834: Added 'inline' attribute to basic_string's destructor

On Sat, Jul 30, 2016 at 1:47 PM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Tue, Jul 26, 2016 at 10:30:22PM +, Laxman Sole via cfe-commits > wrote: > > Currently basic_string's destructor is not getting inlined. So adding > 'inline' attribute to

Re: [PATCH] D22834: Added 'inline' attribute to basic_string's destructor

On Mon, Aug 1, 2016 at 2:20 PM, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Tue, Jul 26, 2016 at 4:37 PM Laxman Sole via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> laxmansole created this revision. >> laxmansole added reviewers: mclow.lists,

r277570 - [index] Fix crash with indexing designated init expressions inside templates.

Author: akirtzidis Date: Wed Aug 3 00:38:53 2016 New Revision: 277570 URL: http://llvm.org/viewvc/llvm-project?rev=277570=rev Log: [index] Fix crash with indexing designated init expressions inside templates. rdar://27452869 Modified: cfe/trunk/lib/Index/IndexBody.cpp

[libcxx] r277572 - Silence another occurrence of MSVC's suprious unused warning. Patch from s...@microsoft.com

Author: ericwf Date: Wed Aug 3 00:46:36 2016 New Revision: 277572 URL: http://llvm.org/viewvc/llvm-project?rev=277572=rev Log: Silence another occurrence of MSVC's suprious unused warning. Patch from s...@microsoft.com Modified: libcxx/trunk/test/support/test_allocator.h Modified:

[libcxx] r277573 - Fix an MSVC x64 compiler warning. Patch from s...@microsoft.com

Author: ericwf Date: Wed Aug 3 00:48:09 2016 New Revision: 277573 URL: http://llvm.org/viewvc/llvm-project?rev=277573=rev Log: Fix an MSVC x64 compiler warning. Patch from s...@microsoft.com Modified:

Re: [PATCH] D22971: [libcxx] [test] Fix an MSVC x64 compiler warning.

EricWF closed this revision. EricWF added a comment. r277573. https://reviews.llvm.org/D22971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22818: [libcxx] [test] Silence another occurrence of MSVC's spurious unused warning.

EricWF closed this revision. EricWF added a comment. r277572. https://reviews.llvm.org/D22818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

Prazek added a comment. In https://reviews.llvm.org/D20196#504397, @bittnerbarni wrote: > I'm planning to submit more patches in the future, as I have time for them. > So it wouldn't be in vain :) http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

Re: [PATCH] D22818: [libcxx] [test] Silence another occurrence of MSVC's spurious unused warning.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D22818#496220, @majnemer wrote: > Do we have a way to keep track of this change so we can remove it when MSVC > gets fixed? No, but I'm not concerned about a

Re: [PATCH] D22834: Added 'inline' attribute to basic_string's destructor

EricWF added a subscriber: EricWF. EricWF added a comment. LGTM. However I would like to see a small benchmark that demonstrates the performance change. Please try and write the benchmark using Google Benchmark. Some helpful links:

[libcxx] r277574 - Fix compile error due to mismatched iterator types. Patch from s...@microsoft.com

Author: ericwf Date: Wed Aug 3 00:50:03 2016 New Revision: 277574 URL: http://llvm.org/viewvc/llvm-project?rev=277574=rev Log: Fix compile error due to mismatched iterator types. Patch from s...@microsoft.com Modified:

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

bittnerbarni added a comment. Thank you for all the assistance. Could you please do that? https://reviews.llvm.org/D20196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22972: [libcxx] [test] Fix an MSVC x64 compiler error due to mismatched iterator types.

EricWF closed this revision. EricWF added a comment. r277574. https://reviews.llvm.org/D22972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r277575 - Add MSVC specifics to .gitignore. Patch from s...@microsoft.com

Author: ericwf Date: Wed Aug 3 00:51:19 2016 New Revision: 277575 URL: http://llvm.org/viewvc/llvm-project?rev=277575=rev Log: Add MSVC specifics to .gitignore. Patch from s...@microsoft.com Modified: libcxx/trunk/.gitignore Modified: libcxx/trunk/.gitignore URL:

Re: [PATCH] D22819: [libcxx] [test] Add env.lst and keep.lst to .gitignore for the MSVC libraries test harness.

EricWF closed this revision. EricWF added a comment. r277575. https://reviews.llvm.org/D22819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22819: [libcxx] [test] Add env.lst and keep.lst to .gitignore for the MSVC libraries test harness.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Why not. https://reviews.llvm.org/D22819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23037: [CUDA] Fix libdevice selection.

tra marked an inline comment as done. tra added a comment. https://reviews.llvm.org/D23037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23037: [CUDA] Fix libdevice selection.

This revision was automatically updated to reflect the committed changes. Closed by commit rL277542: [CUDA] Fix libdevice selection. (authored by tra). Changed prior to commit: https://reviews.llvm.org/D23037?vs=66579=66589#toc Repository: rL LLVM https://reviews.llvm.org/D23037 Files:

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Thank you for working on this! Do you need me to commit the patch for you? https://reviews.llvm.org/D20196 ___ cfe-commits mailing

Re: [PATCH] D22782: Added 'inline' attribute to __init to inline the basic_string's constructor

laxmansole added a comment. Ping https://reviews.llvm.org/D22782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

bittnerbarni updated this revision to Diff 66492. https://reviews.llvm.org/D20196 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/InefficientStringConcatenationCheck.cpp clang-tidy/performance/InefficientStringConcatenationCheck.h

Re: [PATCH] D22419: [CFG] Fix crash in thread sanitizer.

nandor added a comment. ping https://reviews.llvm.org/D22419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] r277481 - Creating release_38 off revision 260304

Author: tstellar Date: Tue Aug 2 11:29:52 2016 New Revision: 277481 URL: http://llvm.org/viewvc/llvm-project?rev=277481=rev Log: Creating release_38 off revision 260304 Added: libclc/branches/release_38/ - copied from r260304, libclc/trunk/

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

bittnerbarni marked 14 inline comments as done. bittnerbarni added a comment. https://reviews.llvm.org/D20196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22505: clang-format Access Modifier Use Normal Indent

LokiAstari added a comment. I don't have a problem changing it so the default behaviour is: class C { int v1; private: int v2; }; But I would like to retain the functionality that if there is no explicit public/private/protected that it follows the original. But if there is

Re: [PATCH] D23045: [Include-fixer] Install executables and support scripts

Eugene.Zelenko added inline comments. Comment at: include-fixer/find-all-symbols/tool/CMakeLists.txt:22 @@ +21,2 @@ + DESTINATION share/clang + COMPONENT find-all-symbols) hokein wrote: > I think we can put it in `clang-include-fixer` as find-all-symbols is a

Re: [PATCH] D23003: [ObjC Availability] Warn upon unguarded use of partially available declaration

erik.pilkington updated this revision to Diff 66501. erik.pilkington added a comment. This new patch removes the warning `diag::warn_available_using_star_case`, as per Devin's suggestion. https://reviews.llvm.org/D23003 Files: include/clang/AST/Stmt.h

Re: [PATCH] D23004: [ASTMatchers] Add matchers canReferToDecl() and hasUnderlyingDecl()

aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:2809 @@ +2808,3 @@ +/// matches \c foo in \c foo(t); +AST_MATCHER_P(OverloadExpr, canReferToDecl, internal::Matcher, + InnerMatcher) { I find the name of this

r277488 - Updated documentation

Author: vitalybuka Date: Tue Aug 2 12:51:48 2016 New Revision: 277488 URL: http://llvm.org/viewvc/llvm-project?rev=277488=rev Log: Updated documentation Reviewers: kcc, eugenis Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D22992 Modified:

Re: [PATCH] D23042: [CUDA] Do not allow using NVPTX target for host compilation.

tra updated this revision to Diff 66505. tra added a comment. Herald added a subscriber: klimek. Abort pipeline constructions early if we detect that NVPTX is used for host compilation. Restore assertions for presence of -march flag. https://reviews.llvm.org/D23042 Files:

Re: [PATCH] D22208: [clang-tidy] Fixes to modernize-use-emplace

Prazek marked 5 inline comments as done. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:115 @@ -95,1 +114,3 @@ + auto CtorCallSourceRange = CharSourceRange::getTokenRange( + InnerCtorCall->getExprLoc(), CallParensRange.getBegin()); alexfh wrote: >

Re: [PATCH] D23008: [clang-tidy] fix segfault in cppcore-guidelines-special-member-functions check

Prazek added a subscriber: Prazek. Prazek accepted this revision. Prazek added a reviewer: Prazek. Prazek added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D23008 ___ cfe-commits mailing list

  1   2   >