Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev updated this revision to Diff 68536. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. Add setHidden(false) and update fixme. https://reviews.llvm.org/D23492 Files: include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cpp

Re: [PATCH] D23696: [CMake] Get libcxx building under LLVM/runtimes

This revision was automatically updated to reflect the committed changes. Closed by commit rL279151: [CMake] Get libcxx building under LLVM/runtimes (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D23696?vs=68610=68613#toc Repository: rL LLVM

Re: [PATCH] D23643: [Driver] Report invalid -mtune/-mcpu parameters when -arch=arm64

vsk updated this revision to Diff 68630. vsk added a comment. Per Akira's suggestion, don't pretend that the Arg* for -arch is a user-specified CPU name (and update the doxygen to reflect this). https://reviews.llvm.org/D23643 Files: lib/Driver/Tools.cpp test/Driver/arm-cortex-cpus.c

Re: [PATCH] D23684: Resolve ambiguity in a declaration if global nested name specifier is used

PR28422 is invalid. Giving better diagnostics in this case seems reasonable, but we should not accept the ill-formed code. On 18 Aug 2016 11:41 a.m., "Serge Pavlov" wrote: > sepavloff created this revision. > sepavloff added reviewers: rsmith, doug.gregor. > sepavloff added

Re: [PATCH] D23696: [CMake] Get libcxx building under LLVM/runtimes

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D23696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r279151 - [CMake] Get libcxx building under LLVM/runtimes

Author: cbieneman Date: Thu Aug 18 16:31:51 2016 New Revision: 279151 URL: http://llvm.org/viewvc/llvm-project?rev=279151=rev Log: [CMake] Get libcxx building under LLVM/runtimes Summary: The new LLVM runtimes build directory requires some basic conventions across the runtime projects. These

[PATCH] D23696: [CMake] Get libcxx building under LLVM/runtimes

beanz created this revision. beanz added a reviewer: EricWF. beanz added a subscriber: cfe-commits. The new LLVM runtimes build directory requires some basic conventions across the runtime projects. These changes make libcxx build under the runtimes subdirectory. The general idea of the changes

r279165 - AMDGPU: Add clang builtin for ds_swizzle.

Author: chfang Date: Thu Aug 18 17:04:54 2016 New Revision: 279165 URL: http://llvm.org/viewvc/llvm-project?rev=279165=rev Log: AMDGPU: Add clang builtin for ds_swizzle. Summary: int __builtin_amdgcn_ds_swizzle (int a, int imm); while imm is a constant. Differential Revision:

[PATCH] D23699: [CMake] Be more consistent about naming targets and components

beanz created this revision. beanz added a reviewer: EricWF. beanz added a subscriber: cfe-commits. The point of this patch is to have a consistent convention for naming build, check and install targets so that the targets can be constructed from the project name. This change renames a bunch

r279183 - [www] Add analyzer FAQ about not releasing ivars in -dealloc.

Author: dcoughlin Date: Thu Aug 18 20:22:50 2016 New Revision: 279183 URL: http://llvm.org/viewvc/llvm-project?rev=279183=rev Log: [www] Add analyzer FAQ about not releasing ivars in -dealloc. Modified: cfe/trunk/www/analyzer/faq.html Modified: cfe/trunk/www/analyzer/faq.html URL:

r279163 - C++ Modules TS: Add parsing support for module import declaration.

Author: rsmith Date: Thu Aug 18 16:59:42 2016 New Revision: 279163 URL: http://llvm.org/viewvc/llvm-project?rev=279163=rev Log: C++ Modules TS: Add parsing support for module import declaration. Added: cfe/trunk/test/Parser/cxx-modules-import.cpp Modified:

[clang-tools-extra] r279170 - [Documentation] Fixed style in modernize-use-emplace.rst.

Author: eugenezelenko Date: Thu Aug 18 17:11:27 2016 New Revision: 279170 URL: http://llvm.org/viewvc/llvm-project?rev=279170=rev Log: [Documentation] Fixed style in modernize-use-emplace.rst. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-emplace.rst Modified:

Re: [PATCH] D23530: Remove excessive padding from BarrierOp, PrefetchOp, PSBHintOp.

compnerd closed this revision. compnerd added a comment. SVN r279173 https://reviews.llvm.org/D23530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] r279180 - EHABI: cover switch once more

Author: compnerd Date: Thu Aug 18 18:59:12 2016 New Revision: 279180 URL: http://llvm.org/viewvc/llvm-project?rev=279180=rev Log: EHABI: cover switch once more When making WMMX support optional, we uncovered the switch. Add the missing entries. Since the entry is a break leading to a dead

[libunwind] r279195 - Creating release candidate rc2 from release_390 branch

Author: hans Date: Thu Aug 18 20:42:56 2016 New Revision: 279195 URL: http://llvm.org/viewvc/llvm-project?rev=279195=rev Log: Creating release candidate rc2 from release_390 branch Added: libunwind/tags/RELEASE_390/rc2/ (props changed) - copied from r279194,

r279196 - C++ Modules TS: support parsing the 'module' declaration (including extensions

Author: rsmith Date: Thu Aug 18 20:43:06 2016 New Revision: 279196 URL: http://llvm.org/viewvc/llvm-project?rev=279196=rev Log: C++ Modules TS: support parsing the 'module' declaration (including extensions from p0273r0 approved by EWG). We'll eventually need to handle this from the lexer as

r279154 - CodeGen: use range based for loop, NFC

Author: compnerd Date: Thu Aug 18 16:40:06 2016 New Revision: 279154 URL: http://llvm.org/viewvc/llvm-project?rev=279154=rev Log: CodeGen: use range based for loop, NFC Modified: cfe/trunk/lib/CodeGen/CGCall.cpp Modified: cfe/trunk/lib/CodeGen/CGCall.cpp URL:

Re: [PATCH] D23643: [Driver] Report invalid -mtune/-mcpu parameters when -arch=arm64

ahatanak added inline comments. Comment at: lib/Driver/Tools.cpp:1163 @@ -1162,3 +1162,3 @@ // FIXME: Should this be picked by checking the target triple instead? - if (Args.getLastArg(options::OPT_arch)) + if ((A = Args.getLastArg(options::OPT_arch))) return "cyclone";

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

teemperor updated this revision to Diff 68632. teemperor added a comment. This revision is now accepted and ready to land. - Moved from hash_stream to LLVM's MD5 implementation. https://reviews.llvm.org/D22515 Files: include/clang/Analysis/CloneDetection.h lib/Analysis/CloneDetection.cpp

r279181 - [analyzer] Weaken assertion in trackNullOrUndefValue()

Author: dcoughlin Date: Thu Aug 18 20:05:31 2016 New Revision: 279181 URL: http://llvm.org/viewvc/llvm-project?rev=279181=rev Log: [analyzer] Weaken assertion in trackNullOrUndefValue() We should ignore paren casts when making sure that the semantic expression in a PseudoObjectExpr for an ObjC

r279164 - PR28794: Don't try to instantiate function templates which are not visible.

Author: vvassilev Date: Thu Aug 18 17:01:25 2016 New Revision: 279164 URL: http://llvm.org/viewvc/llvm-project?rev=279164=rev Log: PR28794: Don't try to instantiate function templates which are not visible. Reviewed by Richard Smith. Added: cfe/trunk/test/Modules/Inputs/PR28794/

Re: [PATCH] D23643: [Driver] Report invalid -mtune/-mcpu parameters when -arch=arm64

vsk added inline comments. Comment at: lib/Driver/Tools.cpp:1163 @@ -1162,3 +1162,3 @@ // FIXME: Should this be picked by checking the target triple instead? - if (Args.getLastArg(options::OPT_arch)) + if ((A = Args.getLastArg(options::OPT_arch))) return "cyclone";

Re: Upgrade and fix clang-format-vs

Hi Antonio, On Wed, Aug 17, 2016 at 8:15 AM, Antonio Maiorano via cfe-commits wrote: > This patch for clang-format-vs includes the following: > > - Upgrade to VS 2015, including .NET framework upgrade from 4.0 to 4.5, and > upgrading Microsoft.VisualStudio references

[libcxx] r279188 - Creating release candidate rc2 from release_390 branch

Author: hans Date: Thu Aug 18 20:42:35 2016 New Revision: 279188 URL: http://llvm.org/viewvc/llvm-project?rev=279188=rev Log: Creating release candidate rc2 from release_390 branch Added: libcxx/tags/RELEASE_390/rc2/ (props changed) - copied from r279187, libcxx/branches/release_39/

[libcxxabi] r279189 - Creating release candidate rc2 from release_390 branch

Author: hans Date: Thu Aug 18 20:42:38 2016 New Revision: 279189 URL: http://llvm.org/viewvc/llvm-project?rev=279189=rev Log: Creating release candidate rc2 from release_390 branch Added: libcxxabi/tags/RELEASE_390/rc2/ (props changed) - copied from r279188,

r279206 - Re-commit [OpenCL] AMDGCN: Fix size_t type

Author: yaxunl Date: Fri Aug 19 00:17:25 2016 New Revision: 279206 URL: http://llvm.org/viewvc/llvm-project?rev=279206=rev Log: Re-commit [OpenCL] AMDGCN: Fix size_t type There was a premature cast to pointer type in emitPointerArithmetic which caused assertion in tests with assertion enabled.

Re: Upgrade and fix clang-format-vs

The key.snk is generated when you build, the problem is the csproj file hardcodes the directory to the sdk instead of using the appropriate project system variable like $(SDKToolsDir) On Thu, Aug 18, 2016 at 7:09 PM Zachary Turner wrote: > Llvm doesn't support vs2012 anymore,

[PATCH] D23705: [GraphTraits] Make nodes_iterator dereference to NodeRef

timshen created this revision. timshen added a reviewer: dblaikie. timshen added a subscriber: cfe-commits. Currently nodes_iterator may dereference to a NodeType* or a NodeType&. Make them all dereference to NodeType*, which is NodeRef later. Corresponding LLVM change: D23704

Re: Upgrade and fix clang-format-vs

Llvm doesn't support vs2012 anymore, as long as it supports vs2013 it's fine On Thu, Aug 18, 2016 at 7:07 PM Antonio Maiorano wrote: > Hi, > > What I meant by upgrade was simply making it build in VS 2015. However, > you bring up a valid point about making sure the extension

Re: [PATCH] D23493: Fix PR28366: Teach the const-expression evaluator to be more fault tolerant with non-const enclosing local variables, or otherwise fold them if const.

faisalv updated this revision to Diff 68644. faisalv marked 4 inline comments as done. faisalv added a comment. Address Richard's comments. https://reviews.llvm.org/D23493 Files: lib/AST/ExprConstant.cpp lib/Sema/SemaTemplateInstantiateDecl.cpp test/SemaCXX/constant-expression-cxx11.cpp

Re: [PATCH] D23493: Fix PR28366: Teach the const-expression evaluator to be more fault tolerant with non-const enclosing local variables, or otherwise fold them if const.

faisalv added a comment. Address Richard's comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:190 @@ -189,3 +189,3 @@ if (A->getCond()->isValueDependent() && !Cond->isValueDependent() && - !Expr::isPotentialConstantExprUnevaluated(Cond, cast(Tmpl), +

r279207 - clang/test/Modules/prebuilt-module.m: Prune "-triple" to fix a configuration mismatch.

Author: chapuni Date: Fri Aug 19 00:25:26 2016 New Revision: 279207 URL: http://llvm.org/viewvc/llvm-project?rev=279207=rev Log: clang/test/Modules/prebuilt-module.m: Prune "-triple" to fix a configuration mismatch. Modified: cfe/trunk/test/Modules/prebuilt-module.m Modified:

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev updated this revision to Diff 68620. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Move DiagnoseUninstantiableTemplate before the late template parsing. https://reviews.llvm.org/D23492 Files: include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cpp

r279159 - CodeGen: Rename a variable to better fit LLVM style. NFC

Author: bogner Date: Thu Aug 18 16:46:54 2016 New Revision: 279159 URL: http://llvm.org/viewvc/llvm-project?rev=279159=rev Log: CodeGen: Rename a variable to better fit LLVM style. NFC Modified: cfe/trunk/lib/CodeGen/CGCall.cpp Modified: cfe/trunk/lib/CodeGen/CGCall.cpp URL:

Re: [PATCH] D23316: [analyzer] Fixed the false-positives caused by macro generated code.

teemperor updated this revision to Diff 68556. teemperor added a comment. - Added more documentation to the CloneSignature::Complexity field. - Macros now have a complexity value of 1 + sum(ChildComplexityValues). - Tests should be less cryptic now. https://reviews.llvm.org/D23316 Files:

r279092 - [libclang] Added missing entry for newly introduced 'clang_getAllSkippedRanges' to libclang.exports

Author: cameron314 Date: Thu Aug 18 12:18:03 2016 New Revision: 279092 URL: http://llvm.org/viewvc/llvm-project?rev=279092=rev Log: [libclang] Added missing entry for newly introduced 'clang_getAllSkippedRanges' to libclang.exports Modified: cfe/trunk/tools/libclang/libclang.exports

Re: [PATCH] D23316: [analyzer] Fixed the false-positives caused by macro generated code.

teemperor updated this revision to Diff 68568. teemperor marked 2 inline comments as done. teemperor added a comment. - Added false-positives note for empty macros to the test suite. https://reviews.llvm.org/D23316 Files: include/clang/Analysis/CloneDetection.h

Re: [PATCH] D23316: [analyzer] Fixed the false-positives caused by macro generated code.

teemperor marked 10 inline comments as done. Comment at: lib/Analysis/CloneDetection.cpp:436 @@ +435,3 @@ +if (IsInMacro) { + Signature.Complexity = 0; +} NoQ wrote: > omtcyfz wrote: > > omtcyfz wrote: > > > omtcyfz wrote: > > > > NoQ wrote: > > > >

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

This revision was automatically updated to reflect the committed changes. Closed by commit rL279096: Module: add -fprebuilt-module-path to support loading prebuilt modules. (authored by mren). Changed prior to commit: https://reviews.llvm.org/D23125?vs=68456=68570#toc Repository: rL LLVM

r279097 - Revert "[Driver] Use llvm-config.h, not config.h to unbreak out-of-tree builds"

Author: vedantk Date: Thu Aug 18 12:43:02 2016 New Revision: 279097 URL: http://llvm.org/viewvc/llvm-project?rev=279097=rev Log: Revert "[Driver] Use llvm-config.h, not config.h to unbreak out-of-tree builds" This reverts commit r279035. According to Richard Smith, llvm-config.h does not contain

Re: Record ranges skipped by the preprocessor and expose them with libclang.

Ah, is that why! My fault, sorry. I couldn't figure out why it wouldn't link on the build machines when it worked fine for me locally (on Windows)... Thank you, I will fix this shortly. On Thu, Aug 18, 2016 at 12:52 PM, Will Dietz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > (Sending

r279096 - Module: add -fprebuilt-module-path to support loading prebuilt modules.

Author: mren Date: Thu Aug 18 12:42:15 2016 New Revision: 279096 URL: http://llvm.org/viewvc/llvm-project?rev=279096=rev Log: Module: add -fprebuilt-module-path to support loading prebuilt modules. In this mode, there is no need to load any module map and the programmer can simply use "@import"

Re: r279035 - [Driver] Use llvm-config.h, not config.h to unbreak out-of-tree builds

I shouldn't have assumed that this was correct because it built. Reverted in r279097. vedant > On Aug 18, 2016, at 9:25 AM, Richard Smith wrote: > > This doesn't work at all, llvm-config.h does not provide the relevant > configuration macros. > > > On 17 Aug 2016

Re: [PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

vsk accepted this revision. vsk added a reviewer: vsk. vsk added a comment. This revision is now accepted and ready to land. This lgtm. I haven't touched clang-format before, so it would be good to double-check with the code owner before committing. Repository: rL LLVM

Re: [PATCH] D23643: [Driver] Report invalid -mtune/-mcpu parameters when -arch=arm64

ahatanak added a subscriber: ahatanak. ahatanak added a comment. Thanks Vedant, this also fixes the crash that occurs when -mtune=native is provided. https://reviews.llvm.org/D14471. Comment at: lib/Driver/Tools.cpp:1163 @@ -1162,3 +1162,3 @@ // FIXME: Should this be

Re: [PATCH] D23643: [Driver] Report invalid -mtune/-mcpu parameters when -arch=arm64

vsk added inline comments. Comment at: lib/Driver/Tools.cpp:1163 @@ -1162,3 +1162,3 @@ // FIXME: Should this be picked by checking the target triple instead? - if (Args.getLastArg(options::OPT_arch)) + if ((A = Args.getLastArg(options::OPT_arch))) return "cyclone";

Re: [PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

djasper accepted this revision. djasper added a comment. Looks good. Repository: rL LLVM https://reviews.llvm.org/D23602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23628: Fix unittests after windows command line parsing

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D23628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r279112 - Use __has_include rather than a configure-time macro to determine if

Author: rsmith Date: Thu Aug 18 13:22:22 2016 New Revision: 279112 URL: http://llvm.org/viewvc/llvm-project?rev=279112=rev Log: Use __has_include rather than a configure-time macro to determine if is available. This should fix out-of-tree builds, at the cost of not providing the higher rlimits

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

llvm-config.h doesn't provide the necessary macros. I've applied a different fix for out-of-tree builds in r279112. On Wed, Aug 17, 2016 at 11:51 PM, Vedant Kumar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Done in clang/r279035. > > thanks, > vedant > > > On Aug 17, 2016, at 7:43 AM,

Re: [PATCH] D21959: [X86] Add xgetbv xsetbv intrinsics

guyblank added a comment. Still, __XSAVE__ should have been defined when compiling for a target that supports the feature. But anyway, the xsaveintrin.h is quite small so always including it shouldn't be an issue. Are you ok with me removing the #if just for this header file, or would you

Re: r279024 - PR28438: Update the information on an identifier with local definitions before

On 18/08/16 03:16, Richard Smith via cfe-commits wrote: Author: rsmith Date: Wed Aug 17 20:16:55 2016 New Revision: 279024 URL: http://llvm.org/viewvc/llvm-project?rev=279024=rev Log: PR28438: Update the information on an identifier with local definitions before trying to write out its macro

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

Done in clang/r279035. thanks, vedant > On Aug 17, 2016, at 7:43 AM, Will Dietz via cfe-commits > wrote: > > (Seems to fix the build here, FWIW. If sounds reasonable can someone commit > this? Thanks!) > > ~Will > > On Wed, Aug 17, 2016 at 9:39 AM Will Dietz

r279042 - test commit

Author: guyblank Date: Thu Aug 18 03:44:33 2016 New Revision: 279042 URL: http://llvm.org/viewvc/llvm-project?rev=279042=rev Log: test commit Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trunk/lib/Basic/Targets.cpp URL:

r279034 - Remove debugging aids from this test and fix its expectations.

Author: rsmith Date: Thu Aug 18 01:15:19 2016 New Revision: 279034 URL: http://llvm.org/viewvc/llvm-project?rev=279034=rev Log: Remove debugging aids from this test and fix its expectations. Modified: cfe/trunk/test/Modules/pr28438.cpp Modified: cfe/trunk/test/Modules/pr28438.cpp URL:

r279035 - [Driver] Use llvm-config.h, not config.h to unbreak out-of-tree builds

Author: vedantk Date: Thu Aug 18 01:43:07 2016 New Revision: 279035 URL: http://llvm.org/viewvc/llvm-project?rev=279035=rev Log: [Driver] Use llvm-config.h, not config.h to unbreak out-of-tree builds llvm/Config/config.h has intentionally been excluded from llvm installations (see:

Re: [PATCH] D23550: [analyzer] Small cleanups when checkers retrieving statements from exploded nodes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL279037: [analyzer] Small cleanups when checkers retrieving statements from exploded (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D23550?vs=68166=68492#toc Repository: rL

r279037 - [analyzer] Small cleanups when checkers retrieving statements from exploded

Author: xazax Date: Thu Aug 18 02:54:50 2016 New Revision: 279037 URL: http://llvm.org/viewvc/llvm-project?rev=279037=rev Log: [analyzer] Small cleanups when checkers retrieving statements from exploded nodes. Differential Revision: https://reviews.llvm.org/D23550 Modified:

Re: [PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

vsk added a subscriber: vsk. Comment at: tools/clang-format/git-clang-format:303 @@ -300,3 +302,3 @@ allowed_extensions = frozenset(allowed_extensions) - for filename in dictionary.keys(): + for filename in list(dictionary.keys()): base_ext = filename.rsplit('.', 1)

Re: [PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

abergmeier-dsfishlabs removed rL LLVM as the repository for this revision. abergmeier-dsfishlabs updated this revision to Diff 68487. abergmeier-dsfishlabs added a comment. Removed unnecessary list conversion. https://reviews.llvm.org/D23602 Files: tools/clang-format/git-clang-format Index:

r279043 - revert [analyzer] Added valist related checkers.

Author: xazax Date: Thu Aug 18 04:13:37 2016 New Revision: 279043 URL: http://llvm.org/viewvc/llvm-project?rev=279043=rev Log: revert [analyzer] Added valist related checkers. Removed: cfe/trunk/lib/StaticAnalyzer/Checkers/ValistChecker.cpp

Re: [PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

abergmeier-dsfishlabs set the repository for this revision to rL LLVM. abergmeier-dsfishlabs updated this revision to Diff 68488. abergmeier-dsfishlabs added a comment. Proper patch of last version (hopefully) Repository: rL LLVM https://reviews.llvm.org/D23602 Files:

Re: [PATCH] D15227: [analyzer] Valist checkers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL279041: [analyzer] Added valist related checkers. (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D15227?vs=68157=68497#toc Repository: rL LLVM

r279041 - [analyzer] Added valist related checkers.

Author: xazax Date: Thu Aug 18 03:43:26 2016 New Revision: 279041 URL: http://llvm.org/viewvc/llvm-project?rev=279041=rev Log: [analyzer] Added valist related checkers. Differential Revision: https://reviews.llvm.org/D15227 Added: cfe/trunk/lib/StaticAnalyzer/Checkers/ValistChecker.cpp

[clang-tools-extra] r279051 - [clang-tidy docs] Minor fix

Author: alexfh Date: Thu Aug 18 06:12:03 2016 New Revision: 279051 URL: http://llvm.org/viewvc/llvm-project?rev=279051=rev Log: [clang-tidy docs] Minor fix Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/mpi-type-mismatch.rst Modified:

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev added inline comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3600-3605 @@ -3598,2 +3599,8 @@ // which definitions should be visible. + if (DiagnoseUninstantiableTemplate(PointOfInstantiation, Function, +

[PATCH] D23641: [ASTMatchers] Fix documentation of is(Un)SignedInteger()

thegameg created this revision. thegameg added reviewers: aaron.ballman, courbet. thegameg added a subscriber: cfe-commits. Herald added a subscriber: klimek. The example is using `isInteger()` instead of `signed` / `unsigned` version. https://reviews.llvm.org/D23641 Files:

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu marked 2 inline comments as done. Comment at: lib/AST/Expr.cpp:2868 @@ +2867,3 @@ +OverloadedOperatorKind binOp = cast(this)->getOperator(); +if (binOp == OO_Equal || (binOp >= OO_PlusEqual && binOp <= OO_PipeEqual)) { + return true;

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu removed rL LLVM as the repository for this revision. Abpostelnicu updated this revision to Diff 68507. https://reviews.llvm.org/D22910 Files: include/clang/AST/ExprCXX.h lib/AST/Expr.cpp Index: lib/AST/Expr.cpp ===

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

omtcyfz updated this revision to Diff 68503. omtcyfz added a comment. Prevent unnecessary `std::vector` copying. Explicitly write type. https://reviews.llvm.org/D23651 Files: clang-rename/USRFindingAction.cpp clang-rename/USRFindingAction.h clang-rename/tool/ClangRename.cpp Index:

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

vmiklos added a comment. I can confirm that with this, the test script from the mail thread shows that clang-rename is almost as fast as clang++ as expected. Thanks! https://reviews.llvm.org/D23651 ___ cfe-commits mailing list

[clang-tools-extra] r279049 - [clang-tidy docs] Fix build errors on Sphinx 1.4.5

Author: alexfh Date: Thu Aug 18 06:06:09 2016 New Revision: 279049 URL: http://llvm.org/viewvc/llvm-project?rev=279049=rev Log: [clang-tidy docs] Fix build errors on Sphinx 1.4.5 Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst

Re: [PATCH] D23653: Minor cleanup of SimpleTypoCorrector

alexshap added a comment. F2283280: Screen Shot 2016-08-18 at 4.29.34 AM.png https://reviews.llvm.org/D23653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

omtcyfz marked an inline comment as done. Comment at: clang-rename/USRFindingAction.h:38-41 @@ -37,6 +37,6 @@ private: - unsigned SymbolOffset; - std::string OldName; - std::string SpellingName; - std::vector USRs; + const std::vector + const std::vector + std::vector

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

omtcyfz updated this revision to Diff 68511. omtcyfz added a comment. Prevent std::vector from redundant copying. https://reviews.llvm.org/D23651 Files: clang-rename/USRFindingAction.cpp clang-rename/USRFindingAction.h clang-rename/tool/ClangRename.cpp Index:

Re: [PATCH] D23314: [analyzer] CloneDetector allows comparing clones for suspicious variable pattern errors.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D23314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23528: [OpenMP] Sema and parsing for 'teams distribute simd' pragma

Hi, I had to revert this (r279045) because it breaks some of our buildbots (e.g. clang-cmake-aarch64-quick, clang-x86_64-linux-selfhost-modules). The error is in OpenMP/teams_distribute_simd_ast_print.cpp: clang:

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

alexshap added a subscriber: alexshap. Comment at: clang-rename/USRFindingAction.h:38 @@ -37,5 +37,3 @@ private: - unsigned SymbolOffset; - std::string OldName; - std::string SpellingName; - std::vector USRs; + std::vector SymbolOffsets; + std::vector OldNames;

Re: [PATCH] D15227: [analyzer] Valist checkers.

xazax.hun reopened this revision. xazax.hun added a comment. This revision is now accepted and ready to land. It looks like it broke some of the build bots. Error from the windows build bots: error: 'note' diagnostics expected but not seen: File

[PATCH] D23653: Minor cleanup of SimpleTypoCorrector

alexshap created this revision. alexshap added reviewers: gribozavr, bkramer. alexshap added a subscriber: cfe-commits. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Add the "explicit" specifier to the single-argument constructor

[clang-tools-extra] r279050 - [clang-tidy docs] Fix formatting.

Author: alexfh Date: Thu Aug 18 06:10:52 2016 New Revision: 279050 URL: http://llvm.org/viewvc/llvm-project?rev=279050=rev Log: [clang-tidy docs] Fix formatting. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/mpi-type-mismatch.rst Modified:

[PATCH] D23651: [clang-rename] improve performance for rename-all

omtcyfz created this revision. omtcyfz added reviewers: alexfh, vmiklos. omtcyfz added a subscriber: cfe-commits. As Miklos Vajna [[ http://lists.llvm.org/pipermail/cfe-dev/2016-August/050398.html | noticed ]] `clang-rename rename-all` has significant performance problems, which exposed the

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki marked 6 inline comments as done. Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:95-98 @@ +94,6 @@ +const QualType T = VD->getType(); +if (T->isPointerType() && !T->getPointeeType().isConstQualified()) + markCanNotBeConst(VD->getInit(),

Re: [PATCH] D23314: [analyzer] CloneDetector allows comparing clones for suspicious variable pattern errors.

This revision was automatically updated to reflect the committed changes. Closed by commit rL279056: [analyzer] Teach CloneDetector to find clones that look like copy-paste errors. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D23314?vs=68422=68518#toc Repository:

[PATCH] D23657: Remove some false positives when taking the address of packed members

rogfer01 created this revision. rogfer01 added reviewers: aaron.ballman, rsmith. rogfer01 added a subscriber: cfe-commits. This change remove some false positives when taking the address of packed members. - It silences the warning when a cast to uintptr_t/intptr_t happens. - If the field is in

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki updated this revision to Diff 68531. danielmarjamaki added a comment. Fixed review comments about formatting in doc https://reviews.llvm.org/D15332 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/NonConstParameterCheck.cpp

Re: [PATCH] D23641: [ASTMatchers] Fix documentation of is(Un)SignedInteger()

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! https://reviews.llvm.org/D23641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23641: [ASTMatchers] Fix documentation of is(Un)SignedInteger()

thegameg added a comment. Can you commit this for me, please? Thanks! https://reviews.llvm.org/D23641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23112: [analyzer] Correctly add assumptions based on array bounds.

NoQ added a comment. On second thought, in `RangeConstraintManager` we need a different functionality. In particular, from `4 * x < 1000` it does not follow that `x < 250` in the general case (due to possible overflows). But in the case of this checker, it doesn't matter - we are always sure

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki updated this revision to Diff 68528. danielmarjamaki marked 2 inline comments as done. danielmarjamaki added a comment. Fixed review comments https://reviews.llvm.org/D15332 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/NonConstParameterCheck.cpp

Re: [PATCH] D20132: [libclang] Add clang_getAllSkippedRanges function

cameron314 added inline comments. Comment at: unittests/libclang/LibclangTest.cpp:16-20 @@ -15,4 +15,7 @@ #include "gtest/gtest.h" #include #include +#include +#include +#include #define DEBUG_TYPE "libclang-test" rsmith wrote: > Please put these in

r279055 - Correct the documentation for isSignedInteger() and isUnsignedInteger().

Author: aaronballman Date: Thu Aug 18 07:26:17 2016 New Revision: 279055 URL: http://llvm.org/viewvc/llvm-project?rev=279055=rev Log: Correct the documentation for isSignedInteger() and isUnsignedInteger(). Patch by Visoiu Mistrih Francis Modified:

Re: [PATCH] D23641: [ASTMatchers] Fix documentation of is(Un)SignedInteger()

aaron.ballman closed this revision. aaron.ballman added a comment. Commit in r279055 https://reviews.llvm.org/D23641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r279056 - [analyzer] Teach CloneDetector to find clones that look like copy-paste errors.

Author: dergachev Date: Thu Aug 18 07:29:41 2016 New Revision: 279056 URL: http://llvm.org/viewvc/llvm-project?rev=279056=rev Log: [analyzer] Teach CloneDetector to find clones that look like copy-paste errors. The original clone checker tries to find copy-pasted code that is exactly identical

Re: [PATCH] D23361: [OpenCL] AMDGCN: Fix size_t type

Anastasia added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:1513 @@ -1512,2 +1512,3 @@ // extension. -llvm::Type *MiddleTy = CGF.IntPtrTy; +auto DestLLVMTy = ConvertType(DestTy); +llvm::Type *MiddleTy =

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:104 @@ +103,3 @@ + const QualType T = Parm->getType(); + if (!T->isPointerType() ||

Re: [PATCH] D23662: [libclang] Control whether crash recovery is enabled/disabled using function argument.

john.brawn added a subscriber: john.brawn. john.brawn added a comment. > When my Java application calls clang_createIndex() with crash recovery > enabled it replaces the JVM's segfault handler with > CrashRecoverySignalHandler and now this handler gets all the segfault signals > that would

Re: [PATCH] D23361: [OpenCL] AMDGCN: Fix size_t type

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D23361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r279076 - [libclang] Add clang_getAllSkippedRanges function

Author: cameron314 Date: Thu Aug 18 10:43:55 2016 New Revision: 279076 URL: http://llvm.org/viewvc/llvm-project?rev=279076=rev Log: [libclang] Add clang_getAllSkippedRanges function This complements the clang_getSkippedRanges function which returns skipped ranges filtered by a specific file.

Re: [PATCH] D20132: [libclang] Add clang_getAllSkippedRanges function

This revision was automatically updated to reflect the committed changes. Closed by commit rL279076: [libclang] Add clang_getAllSkippedRanges function (authored by cameron314). Changed prior to commit: https://reviews.llvm.org/D20132?vs=56964=68548#toc Repository: rL LLVM

  1   2   >