[PATCH] D23641: [ASTMatchers] Fix documentation of is(Un)SignedInteger()

thegameg created this revision. thegameg added reviewers: aaron.ballman, courbet. thegameg added a subscriber: cfe-commits. Herald added a subscriber: klimek. The example is using `isInteger()` instead of `signed` / `unsigned` version. https://reviews.llvm.org/D23641 Files:

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu marked 2 inline comments as done. Comment at: lib/AST/Expr.cpp:2868 @@ +2867,3 @@ +OverloadedOperatorKind binOp = cast(this)->getOperator(); +if (binOp == OO_Equal || (binOp >= OO_PlusEqual && binOp <= OO_PipeEqual)) { + return true;

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu removed rL LLVM as the repository for this revision. Abpostelnicu updated this revision to Diff 68507. https://reviews.llvm.org/D22910 Files: include/clang/AST/ExprCXX.h lib/AST/Expr.cpp Index: lib/AST/Expr.cpp ===

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

omtcyfz updated this revision to Diff 68511. omtcyfz added a comment. Prevent std::vector from redundant copying. https://reviews.llvm.org/D23651 Files: clang-rename/USRFindingAction.cpp clang-rename/USRFindingAction.h clang-rename/tool/ClangRename.cpp Index:

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

omtcyfz marked an inline comment as done. Comment at: clang-rename/USRFindingAction.h:38-41 @@ -37,6 +37,6 @@ private: - unsigned SymbolOffset; - std::string OldName; - std::string SpellingName; - std::vector USRs; + const std::vector + const std::vector + std::vector

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev added inline comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3600-3605 @@ -3598,2 +3599,8 @@ // which definitions should be visible. + if (DiagnoseUninstantiableTemplate(PointOfInstantiation, Function, +

Re: [PATCH] D23653: Minor cleanup of SimpleTypoCorrector

alexshap added a comment. F2283280: Screen Shot 2016-08-18 at 4.29.34 AM.png https://reviews.llvm.org/D23653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D23653: Minor cleanup of SimpleTypoCorrector

alexshap created this revision. alexshap added reviewers: gribozavr, bkramer. alexshap added a subscriber: cfe-commits. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Add the "explicit" specifier to the single-argument constructor

[clang-tools-extra] r279051 - [clang-tidy docs] Minor fix

Author: alexfh Date: Thu Aug 18 06:12:03 2016 New Revision: 279051 URL: http://llvm.org/viewvc/llvm-project?rev=279051=rev Log: [clang-tidy docs] Minor fix Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/mpi-type-mismatch.rst Modified:

[clang-tools-extra] r279050 - [clang-tidy docs] Fix formatting.

Author: alexfh Date: Thu Aug 18 06:10:52 2016 New Revision: 279050 URL: http://llvm.org/viewvc/llvm-project?rev=279050=rev Log: [clang-tidy docs] Fix formatting. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/mpi-type-mismatch.rst Modified:

[clang-tools-extra] r279049 - [clang-tidy docs] Fix build errors on Sphinx 1.4.5

Author: alexfh Date: Thu Aug 18 06:06:09 2016 New Revision: 279049 URL: http://llvm.org/viewvc/llvm-project?rev=279049=rev Log: [clang-tidy docs] Fix build errors on Sphinx 1.4.5 Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst

Re: [PATCH] D15227: [analyzer] Valist checkers.

xazax.hun reopened this revision. xazax.hun added a comment. This revision is now accepted and ready to land. It looks like it broke some of the build bots. Error from the windows build bots: error: 'note' diagnostics expected but not seen: File

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

alexshap added a subscriber: alexshap. Comment at: clang-rename/USRFindingAction.h:38 @@ -37,5 +37,3 @@ private: - unsigned SymbolOffset; - std::string OldName; - std::string SpellingName; - std::vector USRs; + std::vector SymbolOffsets; + std::vector OldNames;

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki marked 6 inline comments as done. Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:95-98 @@ +94,6 @@ +const QualType T = VD->getType(); +if (T->isPointerType() && !T->getPointeeType().isConstQualified()) + markCanNotBeConst(VD->getInit(),

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

vmiklos added a comment. I can confirm that with this, the test script from the mail thread shows that clang-rename is almost as fast as clang++ as expected. Thanks! https://reviews.llvm.org/D23651 ___ cfe-commits mailing list

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

omtcyfz updated this revision to Diff 68503. omtcyfz added a comment. Prevent unnecessary `std::vector` copying. Explicitly write type. https://reviews.llvm.org/D23651 Files: clang-rename/USRFindingAction.cpp clang-rename/USRFindingAction.h clang-rename/tool/ClangRename.cpp Index:

[PATCH] D23651: [clang-rename] improve performance for rename-all

omtcyfz created this revision. omtcyfz added reviewers: alexfh, vmiklos. omtcyfz added a subscriber: cfe-commits. As Miklos Vajna [[ http://lists.llvm.org/pipermail/cfe-dev/2016-August/050398.html | noticed ]] `clang-rename rename-all` has significant performance problems, which exposed the

Re: [PATCH] D23528: [OpenMP] Sema and parsing for 'teams distribute simd' pragma

Hi, I had to revert this (r279045) because it breaks some of our buildbots (e.g. clang-cmake-aarch64-quick, clang-x86_64-linux-selfhost-modules). The error is in OpenMP/teams_distribute_simd_ast_print.cpp: clang:

Re: [PATCH] D23314: [analyzer] CloneDetector allows comparing clones for suspicious variable pattern errors.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D23314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r279043 - revert [analyzer] Added valist related checkers.

Author: xazax Date: Thu Aug 18 04:13:37 2016 New Revision: 279043 URL: http://llvm.org/viewvc/llvm-project?rev=279043=rev Log: revert [analyzer] Added valist related checkers. Removed: cfe/trunk/lib/StaticAnalyzer/Checkers/ValistChecker.cpp

Re: [PATCH] D21959: [X86] Add xgetbv xsetbv intrinsics

guyblank added a comment. Still, __XSAVE__ should have been defined when compiling for a target that supports the feature. But anyway, the xsaveintrin.h is quite small so always including it shouldn't be an issue. Are you ok with me removing the #if just for this header file, or would you

r279042 - test commit

Author: guyblank Date: Thu Aug 18 03:44:33 2016 New Revision: 279042 URL: http://llvm.org/viewvc/llvm-project?rev=279042=rev Log: test commit Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trunk/lib/Basic/Targets.cpp URL:

Re: [PATCH] D15227: [analyzer] Valist checkers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL279041: [analyzer] Added valist related checkers. (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D15227?vs=68157=68497#toc Repository: rL LLVM

r279041 - [analyzer] Added valist related checkers.

Author: xazax Date: Thu Aug 18 03:43:26 2016 New Revision: 279041 URL: http://llvm.org/viewvc/llvm-project?rev=279041=rev Log: [analyzer] Added valist related checkers. Differential Revision: https://reviews.llvm.org/D15227 Added: cfe/trunk/lib/StaticAnalyzer/Checkers/ValistChecker.cpp

Re: [PATCH] D23550: [analyzer] Small cleanups when checkers retrieving statements from exploded nodes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL279037: [analyzer] Small cleanups when checkers retrieving statements from exploded (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D23550?vs=68166=68492#toc Repository: rL

r279037 - [analyzer] Small cleanups when checkers retrieving statements from exploded

Author: xazax Date: Thu Aug 18 02:54:50 2016 New Revision: 279037 URL: http://llvm.org/viewvc/llvm-project?rev=279037=rev Log: [analyzer] Small cleanups when checkers retrieving statements from exploded nodes. Differential Revision: https://reviews.llvm.org/D23550 Modified:

Re: r279024 - PR28438: Update the information on an identifier with local definitions before

On 18/08/16 03:16, Richard Smith via cfe-commits wrote: Author: rsmith Date: Wed Aug 17 20:16:55 2016 New Revision: 279024 URL: http://llvm.org/viewvc/llvm-project?rev=279024=rev Log: PR28438: Update the information on an identifier with local definitions before trying to write out its macro

Re: [PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

abergmeier-dsfishlabs set the repository for this revision to rL LLVM. abergmeier-dsfishlabs updated this revision to Diff 68488. abergmeier-dsfishlabs added a comment. Proper patch of last version (hopefully) Repository: rL LLVM https://reviews.llvm.org/D23602 Files:

Re: [PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

abergmeier-dsfishlabs removed rL LLVM as the repository for this revision. abergmeier-dsfishlabs updated this revision to Diff 68487. abergmeier-dsfishlabs added a comment. Removed unnecessary list conversion. https://reviews.llvm.org/D23602 Files: tools/clang-format/git-clang-format Index:

r279035 - [Driver] Use llvm-config.h, not config.h to unbreak out-of-tree builds

Author: vedantk Date: Thu Aug 18 01:43:07 2016 New Revision: 279035 URL: http://llvm.org/viewvc/llvm-project?rev=279035=rev Log: [Driver] Use llvm-config.h, not config.h to unbreak out-of-tree builds llvm/Config/config.h has intentionally been excluded from llvm installations (see:

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

Done in clang/r279035. thanks, vedant > On Aug 17, 2016, at 7:43 AM, Will Dietz via cfe-commits > wrote: > > (Seems to fix the build here, FWIW. If sounds reasonable can someone commit > this? Thanks!) > > ~Will > > On Wed, Aug 17, 2016 at 9:39 AM Will Dietz

Re: [PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

vsk added a subscriber: vsk. Comment at: tools/clang-format/git-clang-format:303 @@ -300,3 +302,3 @@ allowed_extensions = frozenset(allowed_extensions) - for filename in dictionary.keys(): + for filename in list(dictionary.keys()): base_ext = filename.rsplit('.', 1)

r279034 - Remove debugging aids from this test and fix its expectations.

Author: rsmith Date: Thu Aug 18 01:15:19 2016 New Revision: 279034 URL: http://llvm.org/viewvc/llvm-project?rev=279034=rev Log: Remove debugging aids from this test and fix its expectations. Modified: cfe/trunk/test/Modules/pr28438.cpp Modified: cfe/trunk/test/Modules/pr28438.cpp URL:

<    1   2