[PATCH] D24373: [coroutines] Adding builtins for coroutine intrinsics and backendutil support.

rsmith added inline comments. > LanguageExtensions.rst:1886 > + bool __builtin_coro_done(void *addr); > + void __builtin_coro_promise(void *addr, int alignment, bool from_promise) > + Return type here is `void*`, not `void`. > LanguageExtensions.rst:1916 > + > +Other coroutine builtins are

[PATCH] D25068: [coroutines] Switch to using std::experimental namespace per P0057R5

rsmith accepted this revision. rsmith added inline comments. > Sema.h:720-723 > + /// \brief The C++ "std::experimental" namespace, where the experimental > parts > + /// of the standard library resides. > + NamespaceDecl *StdExperimentalNamespace; > + This is in the middle of a block of

Re: r283063 - Alias must point to a definition

yes, it works, thanks! 2016-10-03 18:19 GMT+03:00 Aditya K : > Thanks for poining that out. I have updated the test case, please see if > that works. > > > http://llvm.org/viewvc/llvm-project?view=revision=283085 > > > > -Aditya > > > -- > *From:*

[PATCH] D25204: Register Calling Convention, Clang changes

erichkeane created this revision. erichkeane added reviewers: oren_ben_simhon, cfe-commits. erichkeane set the repository for this revision to rL LLVM. The Register Calling Convention (RegCall) was introduced by Intel to optimize parameter transfer on function call. This calling convention

Re: [PATCH] D16989: Change interpretation of function definition in friend declaration of template class.

Ping. Thanks, --Serge 2016-09-16 23:17 GMT+07:00 Serge Pavlov : > Ping. > > Thanks, > --Serge > > 2016-09-08 20:43 GMT+07:00 Serge Pavlov : > >> Any feedback? >> >> Thanks, >> --Serge >> >> 2016-09-02 13:11 GMT+07:00 Serge Pavlov :

[PATCH] D25199: [ubsan] Sanitize deleted pointers

vsk added a comment. It looks like programs which trip -fsanitize-value-after-delete will just crash without further reporting, which isn't in keeping with the way other ubsan checks are implemented. IMO, address sanitizer is better-equipped to diagnose this issue.

[PATCH] D25166: [CUDA] Mark device functions as nounwind.

rnk added a comment. In https://reviews.llvm.org/D25166#559168, @jlebar wrote: > > Also, take a look at CodeGenFunction::getInvokeDestImpl(). I think you > > should add some checks in there to return nullptr if we're doing a > > device-side CUDA compilation. That's a much more direct way to

[PATCH] D25139: [CUDA] Add Sema::CUDADiagBuilder and Sema::CUDADiagIfDeviceCode().

rnk added inline comments. > Sema.h:9210 > + /// Emit no diagnostics. > + NOP, > + /// Emit the diagnostic immediately (i.e., behave like Sema::Diag()). LLVM has a different enum naming convention:

[PATCH] D24644: Pass -ffunction-sections/-fdata-sections along to gold-plugin

pcc added a comment. > Are you suggesting having them enabled unconditionally in both gold-plugin > and gold? That will require changes to both llvm and binutils, and the latter > will have effects for other compilers. I mean in the gold plugin only. There would not need to be any changes to

[PATCH] D23765: Fix for clang PR 29087

twoh added a comment. ping https://reviews.llvm.org/D23765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25199: [ubsan] Sanitize deleted pointers

gingell created this revision. gingell added reviewers: cfe-commits, kcc. This patch adds a "value-after-delete" sanitizer, which will invalidate the value of a pointer passed in a delete expression. For instance, when -fsanitize=value-after-delete is passed: int *foo = new int; delete foo; //

[libcxx] r283124 - Mark a couple issues as done (2742 and 2760)

Author: marshall Date: Mon Oct 3 12:35:08 2016 New Revision: 283124 URL: http://llvm.org/viewvc/llvm-project?rev=283124=rev Log: Mark a couple issues as done (2742 and 2760) Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL:

[PATCH] D24516: [Driver][Diagnostics] Make 'show option names' default for driver warnings

bruno added a comment. Ping! https://reviews.llvm.org/D24516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r283120 - [CUDA] Disallow overloading destructors.

Author: jlebar Date: Mon Oct 3 11:48:23 2016 New Revision: 283120 URL: http://llvm.org/viewvc/llvm-project?rev=283120=rev Log: [CUDA] Disallow overloading destructors. Summary: We'd attempted to allow this, but turns out we were doing a very bad job. :) Making this work properly would be a

r283121 - [CUDA] Clean up some comments in Sema::IsOverload. NFC

Author: jlebar Date: Mon Oct 3 11:48:27 2016 New Revision: 283121 URL: http://llvm.org/viewvc/llvm-project?rev=283121=rev Log: [CUDA] Clean up some comments in Sema::IsOverload. NFC Modified: cfe/trunk/lib/Sema/SemaOverload.cpp Modified: cfe/trunk/lib/Sema/SemaOverload.cpp URL:

[PATCH] D24571: [CUDA] Disallow overloading destructors.

jlebar added inline comments. > rnk wrote in SemaOverload.cpp:1131 > I feel like we should exit early on destructors here, before we do any target > checks. The assert also feels kind of trivial because we only come into this > overload machinery if looking up New's DeclarationName found Old.

[PATCH] D25068: [coroutines] Switch to using std::experimental namespace per P0057R5

GorNishanov requested changes to this revision. GorNishanov added a comment. This revision now requires changes to proceed. > coroutines.cpp:1 > // RUN: %clang_cc1 -std=c++14 -fcoroutines -verify %s > Change to -fcoroutines-ts https://reviews.llvm.org/D25068

[PATCH] D25143: [CUDA] Disallow __shared__ variables in host functions.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D25143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25150: [CUDA] Allow static variables in __host__ __device__ functions, so long as they're never codegen'ed for device.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D25150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24991: Inline hot functions in libcxx shared_ptr implementation.

hxy9243 updated this revision to Diff 73293. hxy9243 added a comment. Addresses comments from @halyavin, rename "atomic_support.h" to "__atomic_support" to avoid collisions with application headers. Repository: rL LLVM https://reviews.llvm.org/D24991 Files:

[PATCH] D24571: [CUDA] Disallow overloading destructors.

rnk accepted this revision. rnk added a reviewer: rnk. rnk added a comment. This revision is now accepted and ready to land. lgtm > SemaOverload.cpp:1131 > >if (getLangOpts().CUDA && ConsiderCudaAttrs) { > CUDAFunctionTarget NewTarget = IdentifyCUDATarget(New), I feel like we

[PATCH] D25166: [CUDA] Mark device functions as nounwind.

jlebar added a comment. In https://reviews.llvm.org/D25166#559117, @rnk wrote: > It feels like the right thing is to disable EH in device side compilation, > but obviously that won't work because it would reject try/throw in host code. Exactly. > I think instead of doing that, we should make

[PATCH] D24082: [CMake] Fix libc++abi arm build w/o libunwind.

logan added a comment. Ping? Any other comments? https://reviews.llvm.org/D24082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24087: [lit] Allow more file extensions for test cases.

logan closed this revision. logan added a comment. Thanks for reviewing. Committed as rL283118 with the suggested change regarding to `is_sh_test` assertion. https://reviews.llvm.org/D24087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25190: [ThinLTO doc] Fix typo

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. Good catch indeed! https://reviews.llvm.org/D25190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r283118 - [lit] Allow more file extensions for test cases.

Author: logan Date: Mon Oct 3 11:00:22 2016 New Revision: 283118 URL: http://llvm.org/viewvc/llvm-project?rev=283118=rev Log: [lit] Allow more file extensions for test cases. This commit splits the file extensions before determining the test format. This allows libc++abi to add assembly-based

[PATCH] D25166: [CUDA] Mark device functions as nounwind.

rnk added a comment. It feels like the right thing is to disable EH in device side compilation, but obviously that won't work because it would reject try/throw in host code. I think instead of doing that, we should make sure that CUDA diagnoses try / catch / throw in device functions, and then

[PATCH] D24909: fix for not copying fp denormal and trapping options.

hfinkel added a comment. In https://reviews.llvm.org/D24909#559110, @SjoerdMeijer wrote: > Hi Hal, > Thanks for reviewing and you're right: this should work. We actually have > actually some downstream (aarch64) build attribute selection code that would > work better with this change. Are

[PATCH] D24909: fix for not copying fp denormal and trapping options.

SjoerdMeijer added a comment. Hi Hal, Thanks for reviewing and you're right: this should work. We actually have actually some downstream (aarch64) build attribute selection code that would work better with this change. Are you okay with committing this change? Cheers, Sjoerd.

[PATCH] D24426: DebugInfo: Pass non-zero alignment to DIBuilder only if aligment was forced

rnk added inline comments. > CGDebugInfo.cpp:47 > > +namespace { > +template LLVM prefers `static` to anonymous namespaces http://llvm.org/docs/CodingStandards.html#anonymous-namespaces > CGDebugInfo.cpp:48 > +namespace { > +template > +uint64_t GetTypeAlignIfRequired(Type Ty, const

r283116 - [ARC] Ignore qualifiers in copy-restore expressions

Author: vedantk Date: Mon Oct 3 10:29:22 2016 New Revision: 283116 URL: http://llvm.org/viewvc/llvm-project?rev=283116=rev Log: [ARC] Ignore qualifiers in copy-restore expressions When ARC is enabled, an ObjCIndirectCopyRestoreExpr models the passing of a function argument s.t: * The

[PATCH] D25190: [ThinLTO doc] Fix typo

davide created this revision. davide added reviewers: mehdi_amini, tejohnson. davide added a subscriber: cfe-commits. This looks like an obvious typo to me, but I don't know the whole ThinLTO story, so. https://reviews.llvm.org/D25190 Files: clang/docs/ThinLTO.rst Index:

Re: r283063 - Alias must point to a definition

Thanks for poining that out. I have updated the test case, please see if that works. http://llvm.org/viewvc/llvm-project?view=revision=283085 -Aditya From: Yaron Keren Sent: Sunday, October 2, 2016 11:32 AM To: Aditya Kumar Cc:

[PATCH] D24461: CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds

edward-jones added a comment. Ping. https://reviews.llvm.org/D24461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r283114 - [OpenCL] Fix bug in __builtin_astype causing invalid LLVM cast instructions

Author: yaxunl Date: Mon Oct 3 09:41:50 2016 New Revision: 283114 URL: http://llvm.org/viewvc/llvm-project?rev=283114=rev Log: [OpenCL] Fix bug in __builtin_astype causing invalid LLVM cast instructions __builtin_astype is used to cast OpenCL opaque types to other types, as such, it needs to

[libcxx] r283113 - Change titie of page from Oulu to Issaquah

Author: marshall Date: Mon Oct 3 09:24:21 2016 New Revision: 283113 URL: http://llvm.org/viewvc/llvm-project?rev=283113=rev Log: Change titie of page from Oulu to Issaquah Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL:

[libcxx] r283112 - List tentatively ready issues for Issaquah

Author: marshall Date: Mon Oct 3 09:23:04 2016 New Revision: 283112 URL: http://llvm.org/viewvc/llvm-project?rev=283112=rev Log: List tentatively ready issues for Issaquah Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL:

Re: [llvm-dev] Upgrading phabricator

On Mon, 3 Oct 2016 13:47:08 + Sjoerd Meijer via cfe-commits wrote: > I just committed to Clang and noticed that the corresponding Phabricator > ticket does not get automatically closed (I have "Differential Revision:" in > my commit message and believe I didn't

RE: [llvm-dev] Upgrading phabricator

Hi, I just committed to Clang and noticed that the corresponding Phabricator ticket does not get automatically closed (I have "Differential Revision:" in my commit message and believe I didn't make a typo). Is it just me, or is this is broken after the upgrade? For committing to LLVM this

r283110 - This adds a separate file for the fp denormal regression tests. NFC.

Author: sjoerdmeijer Date: Mon Oct 3 08:13:50 2016 New Revision: 283110 URL: http://llvm.org/viewvc/llvm-project?rev=283110=rev Log: This adds a separate file for the fp denormal regression tests. NFC. I forgot to svn add the new file in my previous commit. Added:

r283109 - This adds a separate file for the fp denormal regression tests. NFC.

Author: sjoerdmeijer Date: Mon Oct 3 08:12:20 2016 New Revision: 283109 URL: http://llvm.org/viewvc/llvm-project?rev=283109=rev Log: This adds a separate file for the fp denormal regression tests. NFC. Differential Revision: https://reviews.llvm.org/D24907 Modified:

[PATCH] D24909: fix for not copying fp denormal and trapping options.

hfinkel added a comment. I'm fine with setting these for consistency, but I don't understand why our failure to do this would cause problems. If you look in lib/CodeGen/CGCall.cpp and you'll see: if (!CodeGenOpts.FPDenormalMode.empty()) FuncAttrs.addAttribute("denormal-fp-math",

[PATCH] D24715: [OpenCL] Block captured variables in dynamic parallelism - OpenCL 2.0

mshockwave removed a reviewer: bader. mshockwave updated this revision to Diff 73254. mshockwave added a comment. @Anastasia Sorry for late responding, I'd just attach a new version of patch that fixes block function use cases as normal lambda functions. But testing code is not included in this

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge added a comment. @dberris , could you deliver this patch to mainline? Or do we need approval from more reviewers? https://reviews.llvm.org/D24799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24907: NFC: separate file for fp denormal regression tests

SjoerdMeijer added a comment. Yes, excellent, I will rename it to denormal-fp-math.c and commit. Thanks for reviewing! https://reviews.llvm.org/D24907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r283106 - Wdocumentation fix

Author: rksimon Date: Mon Oct 3 07:37:08 2016 New Revision: 283106 URL: http://llvm.org/viewvc/llvm-project?rev=283106=rev Log: Wdocumentation fix Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp URL:

[PATCH] D24907: NFC: separate file for fp denormal regression tests

hfinkel accepted this revision. hfinkel added a reviewer: hfinkel. hfinkel added a comment. This revision is now accepted and ready to land. This LGTM, although I find "fast-math.c" much easier to read than "denormalfpmode.c". How about naming it "denormal-fp-math.c" to match the option name?

Re: r283102 - Fix PR 28885: Fix AST Printer output for the inherited constructor using

On 3 October 2016 at 13:23, Alex L wrote: > > > On 3 October 2016 at 13:12, Alex Lorenz via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: arphaman >> Date: Mon Oct 3 07:12:03 2016 >> New Revision: 283102 >> >> URL:

[PATCH] D24807: [Serialization] ArrayTypeTraitExpr: serialize sub-expression to avoid keeping it undefined

a.sidorin abandoned this revision. a.sidorin added a comment. Merged into https://reviews.llvm.org/D14326 and committed. https://reviews.llvm.org/D24807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r283105 - Fix PR 28885: Fix AST Printer output for the inherited constructor using

Author: arphaman Date: Mon Oct 3 07:22:17 2016 New Revision: 283105 URL: http://llvm.org/viewvc/llvm-project?rev=283105=rev Log: Fix PR 28885: Fix AST Printer output for the inherited constructor using declarations. This commit ensures that the correct record type is printed out for the using

r283104 - Revert r283102 (Typo in the phabricator link)

Author: arphaman Date: Mon Oct 3 07:17:56 2016 New Revision: 283104 URL: http://llvm.org/viewvc/llvm-project?rev=283104=rev Log: Revert r283102 (Typo in the phabricator link) Modified: cfe/trunk/lib/AST/DeclPrinter.cpp cfe/trunk/test/SemaCXX/cxx11-ast-print.cpp Modified:

[PATCH] D24339: [clang-tidy] Add check 'readability-redundant-member-init'

malcolm.parsons updated this revision to Diff 73260. malcolm.parsons added a comment. Herald added a subscriber: modocache. Don't warn for trivially default constructable members https://reviews.llvm.org/D24339 Files: clang-tidy/readability/CMakeLists.txt

Re: r283102 - Fix PR 28885: Fix AST Printer output for the inherited constructor using

On 3 October 2016 at 13:12, Alex Lorenz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: arphaman > Date: Mon Oct 3 07:12:03 2016 > New Revision: 283102 > > URL: http://llvm.org/viewvc/llvm-project?rev=283102=rev > Log: > Fix PR 28885: Fix AST Printer output for the inherited

r283102 - Fix PR 28885: Fix AST Printer output for the inherited constructor using

Author: arphaman Date: Mon Oct 3 07:12:03 2016 New Revision: 283102 URL: http://llvm.org/viewvc/llvm-project?rev=283102=rev Log: Fix PR 28885: Fix AST Printer output for the inherited constructor using declarations. This commit ensures that the correct record type is printed out for the using

[PATCH] D24084: [CMake] Cleanup libunwind lookup code.

logan added a comment. Ping. Any further comments? Or, should we duplicate `` in multiple repositories? https://reviews.llvm.org/D24084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25003: [libcxxabi] [cmake] Update LLVM_CMAKE_PATH following install layout change

mgorny abandoned this revision. mgorny added a comment. Independently fixed in rL283100. https://reviews.llvm.org/D25003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24081: [CMake] Fix libc++abi standalone cmake build.

logan closed this revision. logan added a comment. Thanks for reviewing. Committed as rL283100. https://reviews.llvm.org/D24081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] r283100 - [CMake] Fix libc++abi standalone cmake build.

Author: logan Date: Mon Oct 3 06:08:17 2016 New Revision: 283100 URL: http://llvm.org/viewvc/llvm-project?rev=283100=rev Log: [CMake] Fix libc++abi standalone cmake build. The cmake files install directory has been changed to ${prefix}/lib/cmake/llvm since r259821. Searching cmake modules in

[PATCH] D24878: ASTImporter: expressions, pt.2

xazax.hun added a comment. The referenced patch was commited. Could you close/abandon this one? https://reviews.llvm.org/D24878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

SV: [PATCH] D24861: [Sema] extend Wshift-op-parentheses so it warns for multiplicative operators

Hello! Moving it to a subgroup such as -Wparentheses is fine for me. I will look at that when I have time. Do you think this warning has an acceptable output then? Best regards, Daniel Marjamäki

[PATCH] D24905: Fix unreachable code false positive, vardecl in switch

danielmarjamaki added a comment. In https://reviews.llvm.org/D24905#557573, @dcoughlin wrote: > Sorry, missed this patch. > > I think it would good to add a test to make sure we do warn when the var decl > has an initializer, since that will not be executed. > > void varDecl(int X) { >

r283096 - [StaticAnalyser] Add test case to ensure that unreachable code is found.

Author: danielmarjamaki Date: Mon Oct 3 04:45:35 2016 New Revision: 283096 URL: http://llvm.org/viewvc/llvm-project?rev=283096=rev Log: [StaticAnalyser] Add test case to ensure that unreachable code is found. https://reviews.llvm.org/D24905 Modified:

[PATCH] D24909: fix for not copying fp denormal and trapping options.

SjoerdMeijer added a comment. Ping https://reviews.llvm.org/D24909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24933: Enable configuration files in clang

sepavloff added inline comments. > mgorny wrote in driver.cpp:334 > 1. I'm not sure if others would agree with me but I think it would be better > to move those default paths straight to LLVM. If others tools are to adopt > those configuration files, it would only be reasonable to use the same

[PATCH] D24933: Enable configuration files in clang

sepavloff updated this revision to Diff 73245. sepavloff added a comment. Updated path The patch is aligned with corresponding changes in llvm repository (https://reviews.llvm.org/D24926). Also support of configuration selection for executables line foo-clang is added.

[PATCH] D24759: [RFC][StaticAnalyser] fix unreachable code false positives when block numbers mismatch

danielmarjamaki closed this revision. danielmarjamaki added a comment. r283095 https://reviews.llvm.org/D24759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r283095 - [StaticAnalyzer] Fix UnreachableCode false positives.

Author: danielmarjamaki Date: Mon Oct 3 03:28:51 2016 New Revision: 283095 URL: http://llvm.org/viewvc/llvm-project?rev=283095=rev Log: [StaticAnalyzer] Fix UnreachableCode false positives. When there is 'do { } while (0);' in the code the ExplodedGraph and UnoptimizedCFG did not match.

r283094 - [analyzer] Improve CloneChecker diagnostics

Author: dergachev Date: Mon Oct 3 03:11:50 2016 New Revision: 283094 URL: http://llvm.org/viewvc/llvm-project?rev=283094=rev Log: [analyzer] Improve CloneChecker diagnostics Highlight code clones referenced by the warning message with the help of the extra notes feature recently introduced in

r283093 - [analyzer] Add extra notes to ObjCDeallocChecker

Author: dergachev Date: Mon Oct 3 03:03:51 2016 New Revision: 283093 URL: http://llvm.org/viewvc/llvm-project?rev=283093=rev Log: [analyzer] Add extra notes to ObjCDeallocChecker The report is now highlighting instance variables and properties referenced by the warning message with the help of

[PATCH] D25161: [cmake] Install 'clang-cpp' symlink

mgorny closed this revision. mgorny added a comment. I'm going to close this manually since it seems that Phabricator commit processing is stuck somehow. https://reviews.llvm.org/D25161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r283092 - [analyzer] Extend bug reports with extra notes

Author: dergachev Date: Mon Oct 3 02:58:26 2016 New Revision: 283092 URL: http://llvm.org/viewvc/llvm-project?rev=283092=rev Log: [analyzer] Extend bug reports with extra notes These diagnostics are separate from the path-sensitive engine's path notes, and can be added manually on top of

[PATCH] D25131: Fix PR 28885: Fix AST Printer output for inheriting constructor using declarations

arphaman added a comment. In https://reviews.llvm.org/D25131#558004, @rsmith wrote: > Minor comment, otherwise LGTM. This makes sense, thanks for pointing it out! I'll update the comment when I commit. Repository: rL LLVM https://reviews.llvm.org/D25131

RE: r278483 - This patch implements PR#22821.

Hi Joerg, thanks for your comments. I agree that these false positives are annoying. I submitted a while ago a patch to address those false positives in https://reviews.llvm.org/D23657 but it is pending approval. Kind regards, Roger > -Original Message- > From: Joerg Sonnenberger

<    1   2