[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris requested changes to this revision. dberris added a comment. This revision now requires changes to proceed. Are we sure this will not fail on Windows? i.e. have you built/run the tests on Windws ARM or X86_64? > Tools.cpp:4787 > options::OPT_fnoxray_instrument,

[PATCH] D25303: [coroutines] Fix re-building of dependent coroutine promise_type

EricWF created this revision. EricWF added reviewers: rsmith, GorNishanov, majnemer. EricWF added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. When using TreeTransform to rebuild a coroutine the coroutine `promise_type` variable is not transformed because it's stored in the

r283420 - [Driver] Add driver support for Fuchsia

Author: phosek Date: Thu Oct 6 01:08:09 2016 New Revision: 283420 URL: http://llvm.org/viewvc/llvm-project?rev=283420=rev Log: [Driver] Add driver support for Fuchsia Provide toolchain and tool support for Fuchsia operating system. Fuchsia uses compiler-rt as the runtime library and libc++,

[Clang-Tidy]: modernize-avoid-bind erroneous scope resolution.

Hello, i would like to suggest a fix for one of the checks in clang-tidy and i should hope this one is the correct mailing list.The check is modernize-avoid-bind.Consider the following:void bar(int x, int y);namespace N{  void bar(int x, int y);}void foo(){  auto Test =

[clang-tools-extra] r283424 - [clang-move] Cleanup around replacements.

Author: hokein Date: Thu Oct 6 03:29:32 2016 New Revision: 283424 URL: http://llvm.org/viewvc/llvm-project?rev=283424=rev Log: [clang-move] Cleanup around replacements. Summary: cleanup the remaining empty namespace after moving out the class defintitions. Reviewers: ioeric Subscribers:

[PATCH] D25227: [clang-move] Move comments which are associated with the moved class.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D25227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r283432 - [Sema] Fix PR30520: Handle incomplete field types in transparent_union unions

Author: arphaman Date: Thu Oct 6 04:47:29 2016 New Revision: 283432 URL: http://llvm.org/viewvc/llvm-project?rev=283432=rev Log: [Sema] Fix PR30520: Handle incomplete field types in transparent_union unions This commit fixes a crash that happens when clang is analyzing a transparent_union

[clang-tools-extra] r283425 - [clang-move] Move comments which are associated with the moved class.

Author: hokein Date: Thu Oct 6 03:59:24 2016 New Revision: 283425 URL: http://llvm.org/viewvc/llvm-project?rev=283425=rev Log: [clang-move] Move comments which are associated with the moved class. Reviewers: ioeric Subscribers: cfe-commits Differential Revision:

[PATCH] D25308: [Sema] Ignore transparent_union attributes in C++

arphaman created this revision. arphaman added reviewers: rnk, aaron.ballman. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. While working on fixing PR30520 yesterday I noticed that clang also crashes on code like this: template union u {

[PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

rmaprath updated this revision to Diff 73759. rmaprath added a comment. Final patch to be committed, with all the remaining comments addressed. https://reviews.llvm.org/D24562 Files: test/std/re/re.alg/re.alg.search/grep.pass.cpp test/std/re/re.regex/re.regex.assign/assign.pass.cpp

r283428 - Fix PR30440: Initialize FunctionTypeDepth in CXXNameMangler

Author: arphaman Date: Thu Oct 6 04:37:15 2016 New Revision: 283428 URL: http://llvm.org/viewvc/llvm-project?rev=283428=rev Log: Fix PR30440: Initialize FunctionTypeDepth in CXXNameMangler This commit fixes PR 30440 by initializing CXXNameMangler's FunctionTypeDepth in the two constructors

r283430 - Add missing -no-canonical-prefixes.

Author: d0k Date: Thu Oct 6 04:40:37 2016 New Revision: 283430 URL: http://llvm.org/viewvc/llvm-project?rev=283430=rev Log: Add missing -no-canonical-prefixes. Modified: cfe/trunk/test/Driver/fuchsia.c cfe/trunk/test/Driver/fuchsia.cpp Modified: cfe/trunk/test/Driver/fuchsia.c URL:

[PATCH] D25309: [clang-move] Support moving multiple classes in one run.

hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D25309 Files: clang-move/ClangMove.cpp clang-move/ClangMove.h clang-move/tool/ClangMoveMain.cpp test/clang-move/Inputs/database_template.json

[PATCH] D25303: [coroutines] Fix re-building of dependent coroutine promise_type

EricWF abandoned this revision. EricWF added a comment. This is all wrong. Sorry for the noise. https://reviews.llvm.org/D25303 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r283441 - [libcxx] Recover no-exceptions XFAILs - I

Author: asiri Date: Thu Oct 6 06:15:41 2016 New Revision: 283441 URL: http://llvm.org/viewvc/llvm-project?rev=283441=rev Log: [libcxx] Recover no-exceptions XFAILs - I First batch of changes to get some of these XFAILs working in the no-exceptions libc++ variant. Changed some XFAILs to

[PATCH] D25321: Fix PR13910: Don't warn that __builtin_unreachable() is unreachable

arphaman updated this revision to Diff 73781. arphaman added a comment. Slight update: There's no need to pass `CFGBlock` into `isBuiltinUnreachable`. Repository: rL LLVM https://reviews.llvm.org/D25321 Files: lib/Analysis/ReachableCode.cpp test/Sema/warn-unreachable.c Index:

[libcxx] r283452 - Mark issues 2514, 2519, 2536 and 2475 as done

Author: marshall Date: Thu Oct 6 08:59:18 2016 New Revision: 283452 URL: http://llvm.org/viewvc/llvm-project?rev=283452=rev Log: Mark issues 2514, 2519, 2536 and 2475 as done Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL:

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

yaxunl added a comment. Please add a test. Thanks. Repository: rL LLVM https://reviews.llvm.org/D25305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D19063: clang-format: Fixed line merging of more than two lines

cameron314 added a comment. I'll commit this in a few days, when I have some time to reintegrate it to the trunk. Thanks! https://reviews.llvm.org/D19063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D15075: No error for conflict between inputs\outputs and clobber list

zizhar updated this revision to Diff 73760. zizhar added a comment. fixed :) https://reviews.llvm.org/D15075 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/TargetInfo.h lib/Basic/TargetInfo.cpp lib/Basic/Targets.cpp lib/Headers/intrin.h

[PATCH] D25311: Add FixItHint for missing #include (err_module_unimported_use_header)

sammccall added a reviewer: rsmith. sammccall added a comment. (First patch, so please spell out mistakes!) I think the big question is whether it's okay to depend on Format. https://reviews.llvm.org/D25311 ___ cfe-commits mailing list

[PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu updated this revision to Diff 73766. Abpostelnicu marked 3 inline comments as done. https://reviews.llvm.org/D22910 Files: lib/AST/Expr.cpp Index: lib/AST/Expr.cpp === --- lib/AST/Expr.cpp +++ lib/AST/Expr.cpp @@

[PATCH] D25314: [libcxxabi] [cmake] Handle missing LIBUNWIND_* directories gracefully

mgorny created this revision. mgorny added reviewers: EricWF, asl. mgorny added a subscriber: cfe-commits. Herald added a subscriber: beanz. Add LIBUNWIND_* directories to include path only if they were actually found, in order to fix the CMake error. Both of the directories are usually

[PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

rmaprath closed this revision. rmaprath added a comment. Committed as r283441. Thanks! https://reviews.llvm.org/D24562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25321: Fix PR13910: Don't warn that __builtin_unreachable() is unreachable

arphaman created this revision. arphaman added reviewers: dblaikie, krememek. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch fixes the issue of clang emitting an unreachable warning when it encounters unreachable

RE: [PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

Thanks! Now I’ve been able to commit D24955. /Björn On Wed, Oct 5, 2016 at 9:18 PM, Nemanja Ivanovic > wrote: OK, will remove optimization and the selects and commit this now. Sorry about the delay. On Wed, Oct 5, 2016 at 9:16 PM, Sanjay

[PATCH] D24380: [migrate-tool] Framework for a codebase-dependent migration tool.

ioeric added a comment. Test phab...sorry spamming... https://reviews.llvm.org/D24380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25316: [clang-tidy] Fix PR25499: Enhance modernize-use-auto to casts

malcolm.parsons updated this revision to Diff 73780. malcolm.parsons added a comment. Add functional casts to tests and doc. https://reviews.llvm.org/D25316 Files: clang-tidy/modernize/UseAutoCheck.cpp clang-tidy/modernize/UseAutoCheck.h docs/clang-tidy/checks/modernize-use-auto.rst

[PATCH] D25117: [Driver] Add driver support for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL283420: [Driver] Add driver support for Fuchsia (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D25117?vs=73562=73784#toc Repository: rL LLVM https://reviews.llvm.org/D25117

[PATCH] D25282: [clang-move] Cleanup around replacements.

This revision was automatically updated to reflect the committed changes. Closed by commit rL283424: [clang-move] Cleanup around replacements. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D25282?vs=73663=73786#toc Repository: rL LLVM

[PATCH] D25241: [libcxx] Improve code generation for vector::clear().

brucem updated this revision to Diff 73790. brucem added a comment. Address comments from mclow. https://reviews.llvm.org/D25241 Files: include/vector test/std/containers/sequences/vector/vector.modifiers/clear.pass.cpp Index:

[PATCH] D25316: [clang-tidy] Fix PR25499: Enhance modernize-use-auto to casts

malcolm.parsons created this revision. malcolm.parsons added reviewers: angelgarcia, aaron.ballman, klimek. malcolm.parsons added subscribers: cfe-commits, Eugene.Zelenko. Extend modernize-use-auto to cases when variable is assigned with cast. e.g. Type *Ptr1 = dynamic_cast(Ptr2);

[PATCH] D25227: [clang-move] Move comments which are associated with the moved class.

This revision was automatically updated to reflect the committed changes. Closed by commit rL283425: [clang-move] Move comments which are associated with the moved class. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D25227?vs=73463=73785#toc Repository: rL LLVM

[PATCH] D25273: Fix PR30520: Fix incomplete type crash when dealing with transparent_union attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rL283432: [Sema] Fix PR30520: Handle incomplete field types in transparent_union unions (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D25273?vs=73626=73789#toc Repository:

[PATCH] D24932: Fix PR 30440

This revision was automatically updated to reflect the committed changes. Closed by commit rL283428: Fix PR30440: Initialize FunctionTypeDepth in CXXNameMangler (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D24932?vs=72526=73787#toc Repository: rL LLVM

r283444 - [modules] Allow VarDecls with initializers to use special var abbrev.

Author: vvassilev Date: Thu Oct 6 08:04:54 2016 New Revision: 283444 URL: http://llvm.org/viewvc/llvm-project?rev=283444=rev Log: [modules] Allow VarDecls with initializers to use special var abbrev. Update storage sizes to fit the (past) changes in the VarDecl's data model. Update some

[PATCH] D25334: Implement __stosb intrinsic as a volatile memset

agutowski updated this revision to Diff 73828. agutowski marked an inline comment as done. agutowski added a comment. fix return value and comment https://reviews.llvm.org/D25334 Files: include/clang/Basic/BuiltinsX86.def lib/CodeGen/CGBuiltin.cpp lib/Headers/intrin.h

[PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

loladiro added a comment. Bump, please do take another close look at the latest update, particularly with respecting to marking things constexpr that are not so in C++11. Repository: rL LLVM https://reviews.llvm.org/D24372 ___ cfe-commits

[PATCH] D25316: [clang-tidy] Fix PR25499: Enhance modernize-use-auto to casts

malcolm.parsons updated this revision to Diff 73831. malcolm.parsons added a comment. Mention in release notes. https://reviews.llvm.org/D25316 Files: clang-tidy/modernize/UseAutoCheck.cpp clang-tidy/modernize/UseAutoCheck.h docs/clang-tidy/checks/modernize-use-auto.rst

[PATCH] D25338: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

mgorny updated this revision to Diff 73855. https://reviews.llvm.org/D25338 Files: docs/CommandGuide/clang.rst include/clang/Driver/Options.td lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp === --- lib/Driver/Driver.cpp

r283499 - [analyzer] Add explanation why analyzer report is not generated (fix for PR12421).

Author: ayartsev Date: Thu Oct 6 16:42:21 2016 New Revision: 283499 URL: http://llvm.org/viewvc/llvm-project?rev=283499=rev Log: [analyzer] Add explanation why analyzer report is not generated (fix for PR12421). Currently if the path diagnostic consumer (e.g HTMLDiagnostics and

r283489 - [modules] Be sure to emit local specializations of imported templates, even if

Author: rsmith Date: Thu Oct 6 15:30:51 2016 New Revision: 283489 URL: http://llvm.org/viewvc/llvm-project?rev=283489=rev Log: [modules] Be sure to emit local specializations of imported templates, even if the resulting specialization is not referenced by the rest of the AST. This both avoids

[PATCH] D25316: [clang-tidy] Fix PR25499: Enhance modernize-use-auto to casts

Prazek added a comment. Please add tests with long long p = static_cast(4); and the same with const at beginning. I remember I had problems with this last time (Type->SourceRange was returning only source range for the first token. I will review patch later. https://reviews.llvm.org/D25316

[PATCH] D23236: When ARC is enabled, no warning will be generated when a method1. Returns 'nil' in a method that is attributed to return a 'nonnull'2. The return-statement is a ConditionalOperator, wh

dcoughlin added a comment. In https://reviews.llvm.org/D23236#561467, @parallaxe wrote: > In https://reviews.llvm.org/D23236#557898, @dcoughlin wrote: > > > Upon reflection, I don't think this is the right approach. > > > > Desugaring any AttributedType in the return type seems like a really, >

[PATCH] D25338: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

mgorny marked 2 inline comments as done. mgorny added a comment. Updated the docs. I'll look into the test case tomorrow. https://reviews.llvm.org/D25338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25337: [Modules] Add a command line option for enabling the modules feature exclusively for the Clang builtins.

bruno added a reviewer: bruno. bruno added a comment. Hi Elad, Is there any reason why you can't explicit model this in your build system by pre-building the intrinsics and pointing to a module cache path containing the pcm files? By doing that we don't need to have a specific compile flag.

[PATCH] D25338: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

bruno added a reviewer: bruno. bruno added a comment. Testcase? > clang.rst:398 > + Print the library path for the currently used compiler runtime library > + ("libgcc.a" or "libclang_rt.builtins.*.a" appropriately). > You can probably drop the "appropriately" > Options.td:1865 > +

[PATCH] D24508: PR28752: Do not instantiate var decls which are not visible.

rsmith added inline comments. > SemaDecl.cpp:3692-3693 > + // Demote the newly parsed definition to a fake declaration. > + // FIXME: Sema::AddInitializationToDecl still allows two definitions, > + // which make the AST variants inconsistent. > + assert (Def != New && "There

r283498 - Add another .def file to module map to fix modules buildbot's displeasure.

Author: rsmith Date: Thu Oct 6 16:31:04 2016 New Revision: 283498 URL: http://llvm.org/viewvc/llvm-project?rev=283498=rev Log: Add another .def file to module map to fix modules buildbot's displeasure. Modified: cfe/trunk/include/clang/module.modulemap Modified:

[PATCH] D23236: When ARC is enabled, no warning will be generated when a method1. Returns 'nil' in a method that is attributed to return a 'nonnull'2. The return-statement is a ConditionalOperator, wh

dcoughlin added a comment. I left out the example I was describing above for 'InitializationSequence::Perform()': @interface Bar - (nonnull Bar *)method; @end @implementation Bar - (Bar *)method { return 0; } @end https://reviews.llvm.org/D23236

[PATCH] D25349: [coroutines] Build fallthrough and set_exception statements.

EricWF created this revision. EricWF added reviewers: rsmith, GorNishanov, majnemer. EricWF added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. This patch adds semantic checking and building of the fall-through `co_return;` statement as well as the

[PATCH] D25153: preprocessor supports `-dI` flag

elsteveogrande added inline comments. > PrintPreprocessedOutput.cpp:329-330 > +static std::string sanitizePath(StringRef Path) { > + std::string Result; > + Result.reserve(Path.size() * 2); > + while (!Path.empty()) { Note: I'm //pretty// sure this is about as efficient as it gets for

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

zaks.anna added a comment. Daniel, please, add reviewers to this patch. Repository: rL LLVM https://reviews.llvm.org/D25326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24752: [Modules] Add missing dependencies to clang builtins modulemap

bruno added inline comments. > eladcohen wrote in module.modulemap:133 > emmintrin.h is already included explicitly in wmmintrin.h & __wmmintrin_aes.h. > > If a user includes / there is no problem, since the > intel submodule has an 'export *' directive and both aes & sse2 will be > imported.

[PATCH] D25334: Implement __stosb intrinsic as a volatile memset

hans added inline comments. > CGBuiltin.cpp:7604 > + case X86::BI__stosb: { > +// we treat __stosb as volatile memset - it may not generate "rep stosb" > +// instruction, but it will create a memset that won't be optimized away Nit: I'd suggest capital w for "We" and ending the

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge updated this revision to Diff 73824. https://reviews.llvm.org/D24799 Files: lib/Driver/Tools.cpp test/Driver/xray-instrument.c Index: test/Driver/xray-instrument.c === --- test/Driver/xray-instrument.c +++

[PATCH] D25316: [clang-tidy] Fix PR25499: Enhance modernize-use-auto to casts

malcolm.parsons added a comment. In https://reviews.llvm.org/D25316#563654, @Eugene.Zelenko wrote: > I think will be good idea to handle LLVM casts and getAs<> methods too. There > are plenty of them in LLVM/Clang/etc code used for variable initialization. Yes. I plan to do that, but maybe in

[PATCH] D25316: [clang-tidy] Fix PR25499: Enhance modernize-use-auto to casts

Eugene.Zelenko added a comment. Please mention this enhancement in in docs/ReleaseNotes.rst (in alphabetical order). https://reviews.llvm.org/D25316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25334: Implement __stosb intrinsic as a volatile memset

agutowski marked an inline comment as done. agutowski added inline comments. > hans wrote in CGBuiltin.cpp:7613 > Why is it returning Dest here, and not the result of Builder.CreateMemSet? My mistake (that's what memset returns), thanks! https://reviews.llvm.org/D25334

[PATCH] D25343: [OpenCL] Add noduplicate to group functions opencl-c.h

yaxunl created this revision. yaxunl added reviewers: Anastasia, bader. yaxunl added subscribers: cfe-commits, b-sumner. Certain OpenCL builtin functions are supposed to be executed by all threads in a work group or sub group. Such functions should not be duplicated during transformation. It

[PATCH] D25296: [coroutines] Fix co_return statement for initializer list arguments

GorNishanov added a comment. LGTM, but, I cannot approve clang patches. Let's wait on @rsmith to give the go ahead. https://reviews.llvm.org/D25296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25309: [clang-move] Support moving multiple classes in one run.

hokein added inline comments. > ioeric wrote in ClangMove.cpp:316 > What would happen if `InMovedClassNames == false`? "InMovedClassNames" should not be false in the matcher. Added an assert. https://reviews.llvm.org/D25309 ___ cfe-commits mailing

[PATCH] D25309: [clang-move] Support moving multiple classes in one run.

hokein updated this revision to Diff 73819. hokein marked 7 inline comments as done. hokein added a comment. Address review comments. https://reviews.llvm.org/D25309 Files: clang-move/ClangMove.cpp clang-move/ClangMove.h clang-move/tool/ClangMoveMain.cpp

[PATCH] D25309: [clang-move] Support moving multiple classes in one run.

ioeric added inline comments. > hokein wrote in ClangMove.cpp:316 > "InMovedClassNames" should not be false in the matcher. Added an assert. I think you should instead exit early if `ClassNames.empty()` or assert not empty. > ClangMove.cpp:299 > + for (StringRef ClassName : ClassNames) { > +

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge added a comment. In https://reviews.llvm.org/D24799#563058, @dberris wrote: > Are we sure this will not fail on Windows? i.e. have you built/run the tests > on Windws ARM or X86_64? The test itself passes for `arm-pc-win32` and `x86_64-pc-win32` on my machine. So in this sense it

[PATCH] D25337: [Modules] Add a command line option for enabling the modules feature exclusively for the Clang builtins.

eladcohen created this revision. eladcohen added reviewers: hans, rnk, zvi, rsmith, chandlerc. eladcohen added a subscriber: cfe-commits. -fexclusive-builtin-modules enables the clang 'modules' feature exclusively for the clang intrinsic header files. The end goal of this effort is to have this

[PATCH] D25338: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

mgorny created this revision. mgorny added a reviewer: ddunbar. mgorny added a subscriber: cfe-commits. Herald added a subscriber: dberris. Make the -print-libgcc-file-name option print an appropriate compiler runtime library, that is libgcc.a if gcc runtime is used and an appropriate compiler-rt

[PATCH] D25258: [coroutines] Create allocation and deallocation sub-statements.

GorNishanov updated this revision to Diff 73835. GorNishanov added a comment. Addressed review comments. Anything else, @rsmith? 1. compute default new align and pass it to coro.id 2. fix typo in comment https://reviews.llvm.org/D25258 Files: include/clang/AST/StmtCXX.h

[PATCH] D25316: [clang-tidy] Fix PR25499: Enhance modernize-use-auto to casts

Eugene.Zelenko added a comment. I think will be good idea to handle LLVM casts and getAs<> methods too. There are plenty of them in LLVM/Clang/etc code used for variable initialization. See also https://reviews.llvm.org/D17765 for Boost related ideas. https://reviews.llvm.org/D25316

[PATCH] D25334: Implement __stosb intrinsic as a volatile memset

agutowski created this revision. agutowski added reviewers: rnk, hans, thakis, majnemer. agutowski added a subscriber: cfe-commits. We need __stosb to be an intrinsic, because SecureZeroMemory function uses it without including intrin.h. Implementing it as a volatile memset is not consistent

[PATCH] D25335: [OpenCL] Allow partial initializer for array and struct

yaxunl created this revision. yaxunl added reviewers: Anastasia, bader. yaxunl added a subscriber: cfe-commits. Currently Clang allows partial initializer for C99 but not for OpenCL, e.g. float a[16][16] = {1.0f, 2.0f}; is allowed in C99 but not allowed in OpenCL. This patch fixes that.

r283487 - [Sema] Replace smart quote with "'" in comment.

Author: jlebar Date: Thu Oct 6 14:47:56 2016 New Revision: 283487 URL: http://llvm.org/viewvc/llvm-project?rev=283487=rev Log: [Sema] Replace smart quote with "'" in comment. Looks like the smart quote was copy/pasted from the C++ standard. The smart quote was not encoded as valid UTF-8 (?),

[PATCH] D25309: [clang-move] Support moving multiple classes in one run.

ioeric added inline comments. > ClangMove.cpp:295 > void ClangMoveTool::registerMatchers(ast_matchers::MatchFinder *Finder) { > - std::string FullyQualifiedName = "::" + Spec.Name; > + auto ParseNames = [](llvm::StringRef Names) { > +SmallVector ClassNames; Why create this

[PATCH] D25321: Fix PR13910: Don't warn that __builtin_unreachable() is unreachable

aprantl added inline comments. > ReachableCode.cpp:64 > +const FunctionDecl *FDecl = dyn_cast(DRE->getDecl()); > +return FDecl && FDecl->getIdentifier() && > + FDecl->getBuiltinID() == Builtin::BI__builtin_unreachable; Maybe also wrap the inner dyn_cast in an if for symmetry?

r283508 - PR25890: Fix incoherent error handling in PerformImplicitConversion and

Author: rsmith Date: Thu Oct 6 18:12:58 2016 New Revision: 283508 URL: http://llvm.org/viewvc/llvm-project?rev=283508=rev Log: PR25890: Fix incoherent error handling in PerformImplicitConversion and CheckSingleAssignmentConstraints. These no longer produce ExprError() when they have not emitted

[PATCH] D25349: [coroutines] Build fallthrough and set_exception statements.

GorNishanov added a comment. shipit > coreturn.cpp:36 > + suspend_always final_suspend(); > + awaitable yield_value(int); > + void return_void(); No need to hve yield_value here, unless you want to use co_yield expression in the

[PATCH] D25349: [coroutines] Build fallthrough and set_exception statements.

EricWF added inline comments. > GorNishanov wrote in coreturn.cpp:36 > No need to hve yield_value here, unless you want to use co_yield expression > in the coroutine. In this file, we are using co_await only. (Same comment > for promise_float and promise_int) Ack. I'll add them back if I

[PATCH] D25349: [coroutines] Build fallthrough and set_exception statements.

majnemer added inline comments. > AnalysisBasedWarnings.cpp:537 >if (const FunctionDecl *FD = dyn_cast(D)) { > -ReturnsVoid = FD->getReturnType()->isVoidType(); > +if (const CoroutineBodyStmt *CBody = dyn_cast(Body)) > + ReturnsVoid = CBody->getFallthroughHandler() != nullptr;

[PATCH] D25349: [coroutines] Build fallthrough and set_exception statements.

GorNishanov added a comment. LGTM, but, will need to wait for @rsmith to sign off. https://reviews.llvm.org/D25349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

NoQ added a comment. Funny facts about the Environment: (a) Environment allows taking SVals of ReturnStmt, which is not an expression, by transparently converting it into its sub-expression. In fact, it only stores expressions. Having just noticed (a), i also understand that (a) is not of

[PATCH] D25153: preprocessor supports `-dI` flag

majnemer added a comment. The change from an algorithmic POV looks good but I can't speak to whether or not the approach is sound, I'll leave that to @rsmith. > majnemer wrote in PrintPreprocessedOutput.cpp:404 > !SearchPath.empty() This review comment was never addressed.

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris added inline comments. > rSerge wrote in Tools.cpp:4787 > Is there any advantage over `const char* const` here? This same value is turned into a string later on anyway. You can make it a std::string and std::move(...) it at the call to CmdArgs.push_back(...). > rSerge wrote in

[PATCH] D25153: preprocessor supports `-dI` flag

elsteveogrande added inline comments. > PrintPreprocessedOutput.cpp:388-394 > + if (SearchPath.size() > 0) { > +// Print out info about the search path within this comment. We need > +// to escape it because we're printing a quoted string within the > +// comment

[PATCH] D25343: [OpenCL] Mark group functions as noduplicate in opencl-c.h

arsenm added a comment. These should be convergent instead https://reviews.llvm.org/D25343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D25321: Fix PR13910: Don't warn that __builtin_unreachable() is unreachable

On Thu, Oct 6, 2016 at 6:16 AM Alex Lorenz wrote: > arphaman created this revision. > arphaman added reviewers: dblaikie, krememek. > arphaman added a subscriber: cfe-commits. > arphaman set the repository for this revision to rL LLVM. > > This patch fixes the issue of clang

Re: [PATCH] D25321: Fix PR13910: Don't warn that __builtin_unreachable() is unreachable

On 6 October 2016 at 15:50, David Blaikie wrote: > > > On Thu, Oct 6, 2016 at 6:16 AM Alex Lorenz wrote: > >> arphaman created this revision. >> arphaman added reviewers: dblaikie, krememek. >> arphaman added a subscriber: cfe-commits. >> arphaman set the

[PATCH] D24085: arm: Fix ttype encoding assertion failure.

logan added inline comments. > mclow.lists wrote in cxa_personality.cpp:363 > It's not clear to me how this accomplishes what you want. > You're looking for `00/10/90`, right? Why not just check for that? > > Why are you anding with 0x0f ? > Before, this would pass only a single value -

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

danielmarjamaki created this revision. danielmarjamaki added subscribers: cfe-commits, dcoughlin, NoQ. danielmarjamaki set the repository for this revision to rL LLVM. Returns when calling an inline function should not be merged in the ExplodedGraph unless they are same. Background post on

r283448 - Allocate after the early exit checks. NFC.

Author: vvassilev Date: Thu Oct 6 08:18:06 2016 New Revision: 283448 URL: http://llvm.org/viewvc/llvm-project?rev=283448=rev Log: Allocate after the early exit checks. NFC. Modified: cfe/trunk/lib/Serialization/ASTReaderDecl.cpp Modified: cfe/trunk/lib/Serialization/ASTReaderDecl.cpp URL:

[PATCH] D24508: PR28752: Do not instantiate var decls which are not visible.

v.g.vassilev added inline comments. > rsmith wrote in SemaTemplate.cpp:509 > This function still appears to be able to return true (indicating to the > caller that a diagnostic was produced) without actually producing a > diagnostic. Is it better now? > rsmith wrote in SemaTemplate.cpp:505 >

r283460 - [OpenMP] Check if the template specialization is mappable instead of specialized template Differential Revision: https://reviews.llvm.org/D25252

Author: davidsh Date: Thu Oct 6 10:47:36 2016 New Revision: 283460 URL: http://llvm.org/viewvc/llvm-project?rev=283460=rev Log: [OpenMP] Check if the template specialization is mappable instead of specialized template Differential Revision: https://reviews.llvm.org/D25252 Modified:

[PATCH] D24508: PR28752: Do not instantiate var decls which are not visible.

v.g.vassilev updated this revision to Diff 73803. v.g.vassilev marked 4 inline comments as done. v.g.vassilev added a comment. Rebase, comments some more fixes. https://reviews.llvm.org/D24508 Files: include/clang/AST/Decl.h lib/AST/Decl.cpp lib/Sema/SemaDecl.cpp

Re: r283460 - [OpenMP] Check if the template specialization is mappable instead of specialized template Differential Revision: https://reviews.llvm.org/D25252

LGTM On 6 Oct 2016 8:58 am, "David Sheinkman via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Author: davidsh > Date: Thu Oct 6 10:47:36 2016 > New Revision: 283460 > > URL: http://llvm.org/viewvc/llvm-project?rev=283460=rev > Log: > [OpenMP] Check if the template specialization is