[PATCH] D25349: [coroutines] Build fallthrough and set_exception statements.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D25349#571778, @GorNishanov wrote: > @rsmith, I am wondering what were your thoughts on where to generate try { > body } catch (...) {

[PATCH] D26024: [Xray] Don't generate output for xray tests

dberris accepted this revision. dberris added a comment. Yes, thanks (and sorry for missing this). https://reviews.llvm.org/D26024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r285271 - [coroutines] Build fallthrough and set_exception statements.

Author: ericwf Date: Thu Oct 27 02:30:31 2016 New Revision: 285271 URL: http://llvm.org/viewvc/llvm-project?rev=285271=rev Log: [coroutines] Build fallthrough and set_exception statements. Summary: This patch adds semantic checking and building of the fall-through `co_return;` statement as well

[PATCH] D21075: Correct invalid end location in diagnostics for some identifiers.

klimek added a comment. > It's mostly about how much is "underlined". If there is only a caret, that > quite often translates into a single character being pointed out, instead of > an identifier (i.e. the first character). Hene the extension of the range. Aren't we mostly doing token

[PATCH] D26026: [libcxx] Make regex_match backtrack when search fails

timshen created this revision. timshen added a reviewer: mclow.lists. timshen added a subscriber: cfe-commits. Herald added a subscriber: emaste. Fixes PR19851. alg.re.match/ecma.pass.cpp still XFAILS on linux, but after commenting out locale-related tests, it passes. I don't have a freebsd

[PATCH] D23754: cmake: Add CLANG_GOLD_LIBDIR_SUFFIX to specify loc of LLVMgold.so

mgorny added a comment. In https://reviews.llvm.org/D23754#580441, @chandlerc wrote: > In https://reviews.llvm.org/D23754#580277, @mgorny wrote: > > > The difference is that LLVMgold.so is not used by LLVM or clang directly > > but by the system binutils, and so it must match the ABI of the

[PATCH] D25719: [Sema] Fix PR30664

rsmith added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:3429-3430 // initial standard conversion sequence converts the source type to - // the type required by the argument of the constructor - BeforeToType =

[PATCH] D23754: cmake: Add CLANG_GOLD_LIBDIR_SUFFIX to specify loc of LLVMgold.so

mgorny abandoned this revision. mgorny added a comment. Works for me. I don't know if this even has a valid failure case, just felt uneasy about having the obviously-wrong path in code. https://reviews.llvm.org/D23754 ___ cfe-commits mailing list

r285275 - Mark invalid RecordDecls as completed.

Author: erikjv Date: Thu Oct 27 03:37:14 2016 New Revision: 285275 URL: http://llvm.org/viewvc/llvm-project?rev=285275=rev Log: Mark invalid RecordDecls as completed. Sema::ActOnTag creates TagDecls for records. However, if those record declarations are invalid, and the parser is in C++ mode, it

[PATCH] D23754: cmake: Add CLANG_GOLD_LIBDIR_SUFFIX to specify loc of LLVMgold.so

chandlerc added a comment. In https://reviews.llvm.org/D23754#580631, @mgorny wrote: > In https://reviews.llvm.org/D23754#580620, @chandlerc wrote: > > > I'm not sure it really makes sense for the Clang driver to go hunting for > > an LLVMgold.so from an unrelated build of Clang and LLVM. > > >

[PATCH] D23754: cmake: Add CLANG_GOLD_LIBDIR_SUFFIX to specify loc of LLVMgold.so

chandlerc added a comment. In https://reviews.llvm.org/D23754#580612, @mgorny wrote: > In https://reviews.llvm.org/D23754#580441, @chandlerc wrote: > > > In https://reviews.llvm.org/D23754#580277, @mgorny wrote: > > > > > The difference is that LLVMgold.so is not used by LLVM or clang directly

[PATCH] D25674: [Concepts] Class template associated constraints

rsmith added inline comments. Comment at: include/clang/AST/DeclTemplate.h:412-417 + /// \brief The template parameter list and optional requires-clause + /// associated with this declaration. + /// + /// The boolean value indicates whether this particular declaration has an

[PATCH] D25942: Fix crash in implicit default constructor creation for a template record specialization that has a field declaration with an initializer expression

rsmith added inline comments. Comment at: lib/AST/DeclCXX.cpp:1350 while (auto *NewCTD = CTD->getInstantiatedFromMemberTemplate()) { -if (NewCTD->isMemberSpecialization()) +if (NewCTD->isMemberSpecialization() || +

[PATCH] D26024: [Xray] Don't generate output for xray tests

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Testing the code generator in a Driver test is a really weird thing to do. The patch doesn't make it worse though and spamming the test directory is a bad thing. I'll land this.

r285268 - [PPC] add vector byte reverse functions to altivec.h

Author: nemanjai Date: Thu Oct 27 01:23:57 2016 New Revision: 285268 URL: http://llvm.org/viewvc/llvm-project?rev=285268=rev Log: [PPC] add vector byte reverse functions to altivec.h This patch corresponds to review https://reviews.llvm.org/D25915. Committing on behalf of Sean Fertile.

[PATCH] D26024: [Xray] Don't generate output for xray tests

sammccall created this revision. sammccall added a reviewer: dberris. sammccall added a subscriber: cfe-commits. Don't generate output for xray tests https://reviews.llvm.org/D26024 Files: test/Driver/XRay/xray-instrument-cpu.c test/Driver/XRay/xray-instrument-os.c Index:

[PATCH] D26024: [Xray] Don't generate output for xray tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL285276: [Xray] Don't generate output for xray tests (authored by d0k). Changed prior to commit: https://reviews.llvm.org/D26024?vs=75991=75994#toc Repository: rL LLVM

[PATCH] D26002: Implement vector count leading/trailing bytes with zero lsb and vector parity builtins - clang portion

nemanjai added a comment. Other than the minor nit, this LGTM. Comment at: include/clang/Basic/BuiltinsPPC.def:275 + +BUILTIN(__builtin_altivec_vclzlsbb, "SiV16Uc", "") No need for this extra blank line. https://reviews.llvm.org/D26002

[PATCH] D25640: [CUDA] [AST] Allow isInlineDefinitionExternallyVisible to be called on functions without bodies.

rsmith added a comment. I'm not OK with losing this checking entirely. It seems like the problem case is when we're currently processing the definition of the function in question (so it /does/ have a body, it just doesn't have a /complete/ body yet)? I suppose we could track that directly

[PATCH] D23754: cmake: Add CLANG_GOLD_LIBDIR_SUFFIX to specify loc of LLVMgold.so

mgorny added a comment. In https://reviews.llvm.org/D23754#580620, @chandlerc wrote: > I'm not sure it really makes sense for the Clang driver to go hunting for an > LLVMgold.so from an unrelated build of Clang and LLVM. > > The Clang driver is going to run a particular CC1 invocation, ask it

r285276 - [Xray] Don't generate output for xray tests

Author: d0k Date: Thu Oct 27 03:49:18 2016 New Revision: 285276 URL: http://llvm.org/viewvc/llvm-project?rev=285276=rev Log: [Xray] Don't generate output for xray tests Patch by Sam McCall! Differential Revision: http://reviews.llvm.org/D26024 Modified:

[PATCH] D25660: [Analyzer] Checker for iterators dereferenced beyond their range.

NoQ added a comment. Thanks!! Will try to look at the rest of the stuff as soon as possible>< Comment at: test/Analysis/iterator-past-end.cpp:3 + +template struct __iterator { + typedef __iterator iterator; baloghadamsoftware wrote: > NoQ wrote:

[PATCH] D16533: Bug 20796 - GCC's -Wstrict-prototypes warning not implemented in Clang

arphaman added a comment. Hi Paul, Are you planning to work on this patch? If not, can I take a shot at it? Cheers, Alex https://reviews.llvm.org/D16533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r285281 - Fix MSVC warning about missing 'this' from lambda default capture mode

Author: rksimon Date: Thu Oct 27 05:51:29 2016 New Revision: 285281 URL: http://llvm.org/viewvc/llvm-project?rev=285281=rev Log: Fix MSVC warning about missing 'this' from lambda default capture mode Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp

[PATCH] D25605: Empty the C/DtorLists once emitted. This is essential when running in incremental processing mode, because we don't want to reemit the 'tors over and over again.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r285277. Repository: rL LLVM https://reviews.llvm.org/D25605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

mgorny added inline comments. Comment at: lib/Driver/Tools.cpp:2021 std::string Plugin = - ToolChain.getDriver().Dir + "/../lib" CLANG_LIBDIR_SUFFIX "/LLVMgold.so"; + ToolChain.getDriver().Dir + "/../lib" LLVM_RUNTIMES_LIBDIR_SUFFIX "/LLVMgold.so";

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

mgorny retitled this revision from "cmake: Supporting overriding runtime libdir via CLANG_LIBDIR_SUFFIX" to "[cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX". mgorny updated the summary for this revision. mgorny updated this revision to Diff 75996. mgorny added a comment. Here's the initial patch

[PATCH] D25909: [analyzer] MacOSXApiChecker: Disallow dispatch_once predicates on heap and in ivars.

NoQ added inline comments. Comment at: test/Analysis/dispatch-once.m:62 +- (void)test_ivar_struct_from_inside { + dispatch_once(, ^{}); // expected-warning{{Call to 'dispatch_once' uses the instance variable 's' for the predicate value.}} +} dcoughlin wrote: >

[PATCH] D25925: [clang-tidy] Update cert-err58-cpp to match its new generalised form.

malcolm.parsons updated this revision to Diff 75997. malcolm.parsons added a comment. Add tests for operator new with FIXME comment. https://reviews.llvm.org/D25925 Files: clang-tidy/cert/StaticObjectExceptionCheck.cpp docs/clang-tidy/checks/cert-err58-cpp.rst

r285277 - Empty the CtorLists/DtorLists once emitted.

Author: vvassilev Date: Thu Oct 27 04:12:20 2016 New Revision: 285277 URL: http://llvm.org/viewvc/llvm-project?rev=285277=rev Log: Empty the CtorLists/DtorLists once emitted. This is essential when clang is running in incremental processing mode because we don't want to reemit the 'tors over and

r285287 - Add const versions of Expr::getInits() and Expr::inits()

Author: erikjv Date: Thu Oct 27 07:12:08 2016 New Revision: 285287 URL: http://llvm.org/viewvc/llvm-project?rev=285287=rev Log: Add const versions of Expr::getInits() and Expr::inits() Modified: cfe/trunk/include/clang/AST/Expr.h Modified: cfe/trunk/include/clang/AST/Expr.h URL:

[PATCH] D25909: [analyzer] MacOSXApiChecker: Disallow dispatch_once predicates on heap and in ivars.

NoQ updated this revision to Diff 75998. NoQ marked 3 inline comments as done. NoQ added a comment. Also, do not create error nodes unless we're sure we're throwing a report. https://reviews.llvm.org/D25909 Files: lib/StaticAnalyzer/Checkers/MacOSXAPIChecker.cpp

[PATCH] D25660: [Analyzer] Checker for iterators dereferenced beyond their range.

baloghadamsoftware added inline comments. Comment at: test/Analysis/iterator-past-end.cpp:3 + +template struct __iterator { + typedef __iterator iterator; NoQ wrote: > baloghadamsoftware wrote: > > NoQ wrote: > > > We should probably separate this

[PATCH] D26030: Add shebang.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. These scripts aren't `+x`. Maybe you want to make them executable as well. Also, scan-build-py adds `# -*- coding: utf-8 -*-` as well to its python executables. Repository: rL LLVM

[PATCH] D25731: [analyzer] NumberObjectConversion: Support OSNumber and CFNumberRef.

NoQ updated this revision to Diff 76043. NoQ added a comment. - Fix warning messages, finally, hopefully. - Make handling of macros much more careful, because errors of form `x == Y`, where X is an `NSNumber` pointer, and `Y` is a custom macro that expands to `0`, were found.

r285301 - Attempt to make clang-format.py python 3 - compatible.

Author: alexfh Date: Thu Oct 27 10:15:23 2016 New Revision: 285301 URL: http://llvm.org/viewvc/llvm-project?rev=285301=rev Log: Attempt to make clang-format.py python 3 - compatible. Modified: cfe/trunk/tools/clang-format/clang-format.py Modified:

[PATCH] D26034: [CodeCompletion] Block property setters: Use dynamic priority heuristic

arphaman created this revision. arphaman added a reviewer: akyrtzi. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch implements a heuristic that I mentioned in https://reviews.llvm.org/D25520. When completing blocks properties that

[PATCH] D25909: [analyzer] MacOSXApiChecker: Disallow dispatch_once predicates on heap and in ivars.

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Looks great! Please, commit. https://reviews.llvm.org/D25909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r285300 - Move 'quoted' for string_view from to (where the other versions of 'quoted' live. No functional change.

Author: marshall Date: Thu Oct 27 10:10:07 2016 New Revision: 285300 URL: http://llvm.org/viewvc/llvm-project?rev=285300=rev Log: Move 'quoted' for string_view from to (where the other versions of 'quoted' live. No functional change. Modified: libcxx/trunk/include/iomanip

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge added a comment. @dberris , thanks! I ran clang-format on Tools.cpp , then just copy-pasted the changed piece. Do you remember, was the whitespace problem in this file? Or was it in the tests? Repository: rL LLVM https://reviews.llvm.org/D24799

[PATCH] D26035: Expand -Wlogical-not-parentheses to also fire on `!x & A`.

thakis created this revision. thakis added a reviewer: hans. thakis added a subscriber: cfe-commits. This is a misspelling of the intended `!(x & A)` negated bit test that happens in practice every now and then. I ran this on Chromium and all its dependencies, and it fired 0 times -- no false

r285326 - [Driver][OpenMP] Add support to create jobs for unbundling actions.

Author: sfantao Date: Thu Oct 27 13:14:55 2016 New Revision: 285326 URL: http://llvm.org/viewvc/llvm-project?rev=285326=rev Log: [Driver][OpenMP] Add support to create jobs for unbundling actions. Summary: This patch adds the support to create jobs for the `OffloadBundlingAction` which will

[PATCH] D13419: Fix several problems at the intersection of template instantiations and visibility

loladiro added a comment. Since this was approved, I'll rebase and commit. Repository: rL LLVM https://reviews.llvm.org/D13419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

jwhowarth added a comment. Opened https://llvm.org/bugs/show_bug.cgi?id=30811 since the inability for symlinks to be handled in locating libLTO.dylib defeats the purpose of this commit. Repository: rL LLVM https://reviews.llvm.org/D25932 ___

r285331 - [coroutines] Add diagnostics for copy/move assignment operators and functions with deduced return types.

Author: ericwf Date: Thu Oct 27 13:43:28 2016 New Revision: 285331 URL: http://llvm.org/viewvc/llvm-project?rev=285331=rev Log: [coroutines] Add diagnostics for copy/move assignment operators and functions with deduced return types. Summary: The title says it all. Additionally this patch

[PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

loladiro added a comment. Ok then, will commit. Repository: rL LLVM https://reviews.llvm.org/D24372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

jwhowarth reopened this revision. jwhowarth added a comment. This approach doesn't work if the user installs clang in a buried subdirectory such as /sw/opt/llvm-4.0 but accesses the compilers via a /sw/bin/clang-4.0 symlink pointing at /sw/opt/llvm-4.0/bin/clang-4.0... $ /sw/bin/clang-4.0

[PATCH] D25204: Register Calling Convention, Clang changes

erichkeane added a comment. I guess I'm not sure how to respond to that... Calling conventions traditionally use double underscore to prevent from stomping on user keywords. Additionally, this is in a specification that has an existing implementation available, so I'm not sure what could be

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

mehdi_amini added a comment. I just verified that I reproduce with -flto and an previous clang version. Repository: rL LLVM https://reviews.llvm.org/D25932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25292: [coroutines] Add diagnostics for copy/move assignment operators and functions with deduced return types.

EricWF updated this revision to Diff 76076. EricWF added a comment. Resolved merge conflicts. https://reviews.llvm.org/D25292 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCoroutine.cpp test/SemaCXX/coroutines.cpp Index: test/SemaCXX/coroutines.cpp

[PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro added a comment. I came across a situation again where this would be useful to have. I know this was approved, but looking it looks like I wanted @majnemer to have another look. https://reviews.llvm.org/D13330 ___ cfe-commits mailing list

r285320 - [Driver][OpenMP] Add logic for offloading-specific argument translation.

Author: sfantao Date: Thu Oct 27 12:39:44 2016 New Revision: 285320 URL: http://llvm.org/viewvc/llvm-project?rev=285320=rev Log: [Driver][OpenMP] Add logic for offloading-specific argument translation. Summary: This patch includes support for argument translation that is specific of a given

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

mehdi_amini added a comment. Since you re-open this revision, can you clarify how this is triggering the bug you mention? It seems like the issue already existed? Repository: rL LLVM https://reviews.llvm.org/D25932 ___ cfe-commits mailing list

[PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

sfantao updated this revision to Diff 76064. sfantao marked an inline comment as done. sfantao added a comment. - Add comment explaing that the bundler tool can detect if the input file is a bundle or not. https://reviews.llvm.org/D21853 Files: include/clang/Driver/Action.h

r285324 - [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

Author: sfantao Date: Thu Oct 27 13:00:51 2016 New Revision: 285324 URL: http://llvm.org/viewvc/llvm-project?rev=285324=rev Log: [Driver][OpenMP] Update actions builder to create unbundling action when necessary. Summary: Each time that offloading support is requested by the user and the input

r285327 - Use -fopenmp=libomp in all OpenMP offloading tests.

Author: sfantao Date: Thu Oct 27 13:29:57 2016 New Revision: 285327 URL: http://llvm.org/viewvc/llvm-project?rev=285327=rev Log: Use -fopenmp=libomp in all OpenMP offloading tests. This will make sure the right features are being tested even for machines that default to libgomp. Modified:

[PATCH] D26026: [libcxx] Make regex_match backtrack when search fails

timshen marked an inline comment as done. timshen added inline comments. Comment at: libcxx/test/std/re/re.alg/re.alg.match/ecma.pass.cpp:374 std::cmatch m; const char s[] = "tournament"; +assert(std::regex_match(s, m,

r285325 - [Driver][OpenMP] Add support to create jobs for bundling actions.

Author: sfantao Date: Thu Oct 27 13:04:42 2016 New Revision: 285325 URL: http://llvm.org/viewvc/llvm-project?rev=285325=rev Log: [Driver][OpenMP] Add support to create jobs for bundling actions. Summary: This patch adds the support to create a job for the `OffloadBundlingAction` which will

[PATCH] D26002: Implement vector count leading/trailing bytes with zero lsb and vector parity builtins - clang portion

kbarton accepted this revision. kbarton added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D26002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r285323 - [Driver][OpenMP] Update actions builder to create bundling action when necessary.

Author: sfantao Date: Thu Oct 27 12:50:43 2016 New Revision: 285323 URL: http://llvm.org/viewvc/llvm-project?rev=285323=rev Log: [Driver][OpenMP] Update actions builder to create bundling action when necessary. Summary: In order to save the user from dealing with multiple output files (for host

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

mehdi_amini added a comment. I reproduced with clang that ships with XCode by doing: ln -s `xcrun -find clang` /tmp/clang /tmp/clang /tmp/main.cpp -flto clang: warning: libLTO.dylib relative to clang installed dir not found; using 'ld' default search path instead `

[PATCH] D25204: Register Calling Convention, Clang changes

majnemer added a comment. The __ namespace is reserved for us and I can't imagine how __regcall would upset any existing code out there. https://reviews.llvm.org/D25204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

sfantao added a comment. A PR was generated as requested by Hal explaining why we do not generate jobs for NVPTX targets yet. https://llvm.org/bugs/show_bug.cgi?id=30812 https://reviews.llvm.org/D21845 ___ cfe-commits mailing list

[PATCH] D25204: Register Calling Convention, Clang changes

joerg added a comment. The __ namespace is shared between all parts of the implementation, not just the compiler. The convention in the past was that compiler keywords will end in a __ as well, but calling conventions and Objective C broke that convention. I still think it is something that

LLVM buildmaster will be updated and restarted at 3 PM Pacific time today

Hello everyone, LLVM buildmaster will be updated and restarted at 3 PM Pacific time today. Thank you for understanding. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions.

sfantao updated this revision to Diff 76069. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21857 Files: include/clang/Driver/Action.h include/clang/Driver/Driver.h include/clang/Driver/Tool.h lib/Driver/Action.cpp lib/Driver/Driver.cpp lib/Driver/Tool.cpp

[PATCH] D26041: [clang-tidy] Extend misc-use-after-move to support unique_ptr and shared_ptr.

mboehme created this revision. mboehme added a reviewer: alexfh. mboehme added a subscriber: cfe-commits. As a unique_ptr or shared_ptr that has been moved from is guaranteed to be null, we only warn if the pointer is dereferenced. https://reviews.llvm.org/D26041 Files:

[PATCH] D26026: [libcxx] Make regex_match backtrack when search fails

timshen updated this revision to Diff 76088. timshen added a comment. Added http://www.open-std.org/jtc1/sc22/wg21/docs/lwg-defects.html#2273 as comments. https://reviews.llvm.org/D26026 Files: libcxx/include/regex libcxx/test/std/re/re.alg/re.alg.match/ecma.pass.cpp Index:

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for working on this! https://reviews.llvm.org/D22346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D13419: Fix several problems at the intersection of template instantiations and visibility

loladiro added a comment. Hmm, the rebased version of this introduces new errors in `test/Modules/cxx-templates.cpp`. That test didn't exist when I wrote this code and I'm not familiar with templates. @rsmith could you take a look, error is: error: 'error' diagnostics seen but not expected:

r285341 - Add documentation describing the components of a complete toolchain including Clang.

Author: rsmith Date: Thu Oct 27 15:55:56 2016 New Revision: 285341 URL: http://llvm.org/viewvc/llvm-project?rev=285341=rev Log: Add documentation describing the components of a complete toolchain including Clang. Added: cfe/trunk/docs/Toolchain.rst Modified:

[PATCH] D13419: Fix several problems at the intersection of template instantiations and visibility

loladiro updated this revision to Diff 76094. loladiro added a comment. Rebased patch Repository: rL LLVM https://reviews.llvm.org/D13419 Files: lib/AST/Decl.cpp lib/AST/DeclCXX.cpp test/CodeGenCXX/visibility.cpp Index: test/CodeGenCXX/visibility.cpp

[PATCH] D25204: Register Calling Convention, Clang changes

erichkeane updated this revision to Diff 76117. erichkeane added a comment. Remove single-underscore version of _regcall kw. https://reviews.llvm.org/D25204 Files: include/clang-c/Index.h include/clang/AST/Type.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

[PATCH] D25640: [CUDA] [AST] Allow isInlineDefinitionExternallyVisible to be called on functions without bodies.

jlebar added a comment. OK, I can add new flags with the best of 'em. I got rid of a super ugly hack I found that was working around the same problem I was trying to work around here. (And I verified that if I don't call setWillHaveBody, a testcase fails.) I can split this out into two

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

jwhowarth added a comment. In https://reviews.llvm.org/D25932#581167, @mehdi_amini wrote: > I just verified that I reproduce with -flto and an previous clang version. This issue will only be triggered if you build with "-DCMAKE_INSTALL_PREFIX:PATH=/sw/opt/llvm-4.0" to place llvm in a buried

[PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro set the repository for this revision to rL LLVM. loladiro updated this revision to Diff 76102. loladiro added a comment. Rebased on current master. Repository: rL LLVM https://reviews.llvm.org/D13330 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

[libcxx] r285352 - [libcxx] Make regex_match backtrack when search fails

Author: timshen Date: Thu Oct 27 16:40:34 2016 New Revision: 285352 URL: http://llvm.org/viewvc/llvm-project?rev=285352=rev Log: [libcxx] Make regex_match backtrack when search fails Summary: Fixes PR19851. alg.re.match/ecma.pass.cpp still XFAILS on linux, but after commenting out locale-related

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

falho updated this revision to Diff 76072. falho marked an inline comment as done. falho added a comment. in cpp diagnostics message: comma changed back to semicolon, + curly braces removed testfiles corrected accordingly https://reviews.llvm.org/D22346 Files:

[PATCH] D13330: Implement __attribute__((unique_instantiation))

majnemer added a comment. I think this looks good but I'd like @rsmith to take a look. https://reviews.llvm.org/D13330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

mgorny added a comment. In https://reviews.llvm.org/D23752#581416, @chandlerc wrote: > I don't get it. > > There is nothing "RUNTIMES" about it. And this variable is actually used to > produce real libraries: libclang, etc. > > It's just the LIBDIR_SUFFIX. That's it. The reason it is called >

[PATCH] D26044: Factor out libc++ version file to allow Clang to more easily sniff for the installed version

rsmith created this revision. rsmith added reviewers: mclow.lists, EricWF. rsmith added a subscriber: cfe-commits. rsmith set the repository for this revision to rL LLVM. Clang would like to enable some language-version-specific functionality only if the installed C++ standard library supports

[PATCH] D25640: [CUDA] [AST] Allow isInlineDefinitionExternallyVisible to be called on functions without bodies.

jlebar updated this revision to Diff 76118. jlebar added a comment. Add WillHaveBody flag. https://reviews.llvm.org/D25640 Files: clang/include/clang/AST/Decl.h clang/lib/AST/Decl.cpp clang/lib/Sema/SemaDecl.cpp clang/test/SemaCUDA/gnu-inline.cu Index:

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

falho added a comment. Cool! Thank you for the reviews! https://reviews.llvm.org/D22346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

chandlerc added a comment. I don't get it. There is nothing "RUNTIMES" about it. And this variable is actually used to produce real libraries: libclang, etc. It's just the LIBDIR_SUFFIX. That's it. The reason it is called CLANG_LIBDIR_SUFFIX and set from LLVM_LIBDIR_SUFFIX is to support using

[PATCH] D26026: [libcxx] Make regex_match backtrack when search fails

This revision was automatically updated to reflect the committed changes. timshen marked an inline comment as done. Closed by commit rL285352: [libcxx] Make regex_match backtrack when search fails (authored by timshen). Changed prior to commit:

[PATCH] D25204: Register Calling Convention, Clang changes

rnk added a comment. In https://reviews.llvm.org/D25204#581477, @erichkeane wrote: > In general, I can see the benefit of this rule, however in the case of > calling conventions, I would think that keeping them all orthogonal is > important. Having "most" calling conventions work one way, and

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

beanz added a comment. This looks like it is in the direction I would expect. Please let me know once the final patch is ready. Comment at: lib/Driver/Tools.cpp:2021 std::string Plugin = - ToolChain.getDriver().Dir + "/../lib" CLANG_LIBDIR_SUFFIX "/LLVMgold.so"; +

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

chandlerc added a comment. In https://reviews.llvm.org/D23752#581427, @mgorny wrote: > In https://reviews.llvm.org/D23752#581416, @chandlerc wrote: > > > I don't get it. > > > > There is nothing "RUNTIMES" about it. And this variable is actually used to > > produce real libraries: libclang,

[PATCH] D25483: [libcxx] [test] Fix non-Standard assumptions about how many elements are allocated

STL_MSFT closed this revision. STL_MSFT added a comment. Committed r285346. Thanks!! https://reviews.llvm.org/D25483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

mgorny added a comment. This really doesn't solve the problems we have. We don't want to build and install two almost-identical copies of compiler-rt and clang headers, when we can just build one and make clang use it. https://reviews.llvm.org/D23752

[PATCH] D25657: include-fixer: Don't overwrite buffer changes

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL285060. Please specify "Differential revision: " as last line of commit message. https://reviews.llvm.org/D25657 ___ cfe-commits mailing

[PATCH] D25654: [Sema] Don't perform aggregate initialization for types with explicit constructors

EricWF updated this revision to Diff 76095. EricWF added a comment. - Disallow classes with inherited constructors - Add tests under `test/CXX/drs/dr15xx.cpp` I still only implemented this change in C++1z, please let me know if you want me to backport the DR. https://reviews.llvm.org/D25654

[PATCH] D25731: [analyzer] NumberObjectConversion: Support OSNumber and CFNumberRef.

dcoughlin accepted this revision. dcoughlin added a comment. LGTM. Comment at: test/Analysis/number-object-conversion.m:98 + +#define NULL_INSIDE_MACRO NULL +void test_NULL_inside_macro(NSNumber *p) { This is great! And a good catch.

[PATCH] D25660: [Analyzer] Checker for iterators dereferenced beyond their range.

zaks.anna added a comment. >> Actually, I always test first on real code, and it seemed to be inlined. But >> now, even if I >> removed the pragma it was not inlined. Looks like this patch is interfering with this inlining suppression. We had many false positives without it. Mainly, the

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

chandlerc added a comment. In https://reviews.llvm.org/D23752#581436, @mgorny wrote: > This really doesn't solve the problems we have. We don't want to build and > install two almost-identical copies of compiler-rt and clang headers, when we > can just build one and make clang use it.

[PATCH] D25204: Register Calling Convention, Clang changes

rnk added a comment. Remember the fight over _Atomic with MSVC's STL? The fallacy of the implementer's namespace is that there is only one implementer. https://llvm.org/bugs/show_bug.cgi?id=19043 We should prefer adding `__attribute__`s and `__declspec`s instead of keywords when possible.

[libcxx] r285346 - [PATCH] D25483: [libcxx] [test] Fix non-Standard assumptions about how many elements are allocated

Author: stl_msft Date: Thu Oct 27 16:25:12 2016 New Revision: 285346 URL: http://llvm.org/viewvc/llvm-project?rev=285346=rev Log: [PATCH] D25483: [libcxx] [test] Fix non-Standard assumptions about how many elements are allocated Modified:

Re: r285281 - Fix MSVC warning about missing 'this' from lambda default capture mode

> On 27 Oct 2016, at 13:25, Erik Verbruggen wrote: > > Eh? Preprocessor::IsFileLexer(const IncludeStackInfo &) is static and doesn't > need 'this'... Apparently MSVC mistakingly confuses that method with the > non-static Preprocessor::IsFileLexer() method? You’re not

r285349 - [docs] Update the TSan and MSan docs to refer to the new no_sanitize attribute

Author: zaks Date: Thu Oct 27 16:38:44 2016 New Revision: 285349 URL: http://llvm.org/viewvc/llvm-project?rev=285349=rev Log: [docs] Update the TSan and MSan docs to refer to the new no_sanitize attribute TSan and MSan were the only remaining sanitizers referring to the deprecated attribute for

[PATCH] D25204: Register Calling Convention, Clang changes

erichkeane added a comment. In https://reviews.llvm.org/D25204#581469, @rnk wrote: > Remember the fight over _Atomic with MSVC's STL? The fallacy of the > implementer's namespace is that there is only one implementer. > https://llvm.org/bugs/show_bug.cgi?id=19043 > > We should prefer adding

  1   2   >