[PATCH] D25869: [Driver] Add unit tests for Distro detection

mgorny updated this revision to Diff 78506. mgorny added a comment. Added tests for SUSE and Arch Linux (and found a bug for the former, https://reviews.llvm.org/D26850). https://reviews.llvm.org/D25869 Files: unittests/Driver/CMakeLists.txt unittests/Driver/DistroTest.cpp Index:

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

AntonBikineev updated this revision to Diff 78511. https://reviews.llvm.org/D26829 Files: include/clang/Basic/DiagnosticLexKinds.td include/clang/Lex/LiteralSupport.h lib/Lex/Lexer.cpp lib/Lex/LiteralSupport.cpp Index: lib/Lex/LiteralSupport.cpp

[PATCH] D26746: [OpenCL] Split PipeType into ReadPipe/WritePipe

joey closed this revision. joey marked 3 inline comments as done. joey added a comment. Committed as r287343. Repository: rL LLVM https://reviews.llvm.org/D26746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26847: Fix Internal Compiler Error compiling Clang with the latest version of MSVC

hughbe added a comment. Thanks Malcolm. You're right, my bad! Sorry for wasting your time Repository: rL LLVM https://reviews.llvm.org/D26847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

AntonBikineev updated the summary for this revision. AntonBikineev updated this revision to Diff 78507. https://reviews.llvm.org/D26829 Files: include/clang/Basic/DiagnosticLexKinds.td include/clang/Lex/LiteralSupport.h lib/Lex/Lexer.cpp lib/Lex/LiteralSupport.cpp Index:

r287343 - [OpenCL] Introduce ReadPipeType and WritePipeType.

Author: joey Date: Fri Nov 18 08:10:54 2016 New Revision: 287343 URL: http://llvm.org/viewvc/llvm-project?rev=287343=rev Log: [OpenCL] Introduce ReadPipeType and WritePipeType. This allows Sema to diagnose passing a read_only pipe to a write_only pipe argument. Modified:

[PATCH] D26843: Make sizeof expression context partially evaluated

EricWF added a comment. > But that is not valid in C afaik and in C++ I get: > > error: invalid use of non-static data member 'm' > int x = sizeof(T::m); >~~~^ > > > Can you post a full reproducible example of what the change breaks? That is a full reproducible

[PATCH] D25475: [analyzer] Add a new SVal to support pointer-to-member operations.

kromanenkov added a comment. ping https://reviews.llvm.org/D25475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26636: patch for llvm/clang bug 25965, suppress warning diagnostic on float-to-bool conversion when in condition context

mibintc removed rL LLVM as the repository for this revision. mibintc updated this revision to Diff 78518. mibintc added a comment. I regenerated the diff using diff -x -U99 https://reviews.llvm.org/D26636 Files: include/clang/AST/Expr.h include/clang/AST/Stmt.h

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

AntonBikineev updated this revision to Diff 78523. AntonBikineev added a comment. Just added a small test case https://reviews.llvm.org/D26829 Files: include/clang/Basic/DiagnosticLexKinds.td include/clang/Lex/LiteralSupport.h lib/Lex/Lexer.cpp lib/Lex/LiteralSupport.cpp

[PATCH] D26843: Make sizeof expression context partially evaluated

pmatos added a comment. In https://reviews.llvm.org/D26843#599673, @EricWF wrote: > > But that is not valid in C afaik and in C++ I get: > > > > error: invalid use of non-static data member 'm' > > int x = sizeof(T::m); > >~~~^ > > > > > > Can you post a full

[PATCH] D26853: Make llvm::Error generated from replacement interfaces more specific.

ioeric created this revision. ioeric added reviewers: klimek, djasper, bkramer. ioeric added a subscriber: cfe-commits. The new error information contains the type of error (e.g. overlap or bad file path) and the replacement(s) that is causing the error. This enables us to resolve some errors.

[PATCH] D26849: [Sema] Set range end of constructors and destructors in template instantiations

malcolm.parsons updated this revision to Diff 78522. malcolm.parsons added a comment. Add test. https://reviews.llvm.org/D26849 Files: lib/Sema/SemaTemplateInstantiateDecl.cpp test/Misc/ast-dump-decl.cpp Index: test/Misc/ast-dump-decl.cpp

[PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

majnemer added a comment. Do we have a testcase where the declspec is applied to something inappropriate like an int? Comment at: lib/Sema/SemaDeclAttr.cpp:4669-4673 + if (!(isa(D) || isa(D))) { S.Diag(Attr.getLoc(), diag::warn_attribute_wrong_decl_type) - <<

[PATCH] D26858: [AArch64] Don't constrain the assembler when using -mgeneral-regs-only

sbaranga created this revision. sbaranga added reviewers: jmolloy, rengolin, t.p.northover. sbaranga added a subscriber: cfe-commits. Herald added a subscriber: aemerson. We use the neonasm, cryptoasm, fp-armv8asm and fullfp16asm features to enable the assembling of instructions that were

[PATCH] D26837: [analyzer] Litter the SVal/SymExpr/MemRegion class hierarchy with asserts.

a.sidorin added a comment. Personally, I like this change because it makes our assumptions clearer. My comments are below. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:54 + : store(st), region(r) { +

[PATCH] D26838: [analyzer] Enforce super-region classes for various memory regions through compile-time and run-time type checks.

a.sidorin added a comment. Hi Artem! I like this change mostly but I also have some remarks. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1279 /// associated element type, index, and super region. const ElementRegion *getElementRegion(QualType

[PATCH] D25660: [Analyzer] Checker for iterators dereferenced beyond their range.

baloghadamsoftware updated this revision to Diff 78527. baloghadamsoftware added a comment. Test updated to include test case where system headers are inlined. https://reviews.llvm.org/D25660 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:1621 let Args = [StringArgument<"Guid">]; -// let Subjects = SubjectList<[CXXRecord]>; + let Subjects = SubjectList<[CXXRecord, Enum], WarnDiag,

[PATCH] D26773: [analyzer] Refactor recursive symbol reachability check to use symbol_iterator

This revision was automatically updated to reflect the committed changes. Closed by commit rL287380: [analyzer] Refactor recursive symbol reachability check to use symbol_iterator (authored by ddcc). Changed prior to commit: https://reviews.llvm.org/D26773?vs=78392=78575#toc Repository: rL

r287380 - [analyzer] Refactor recursive symbol reachability check to use symbol_iterator

Author: ddcc Date: Fri Nov 18 15:07:03 2016 New Revision: 287380 URL: http://llvm.org/viewvc/llvm-project?rev=287380=rev Log: [analyzer] Refactor recursive symbol reachability check to use symbol_iterator Reviewers: zaks.anna, dcoughlin Subscribers: cfe-commits Differential Revision:

r287390 - [AMDGPU] Change frexp.exp builtin to return i16 for f16 input

Author: kzhuravl Date: Fri Nov 18 16:31:51 2016 New Revision: 287390 URL: http://llvm.org/viewvc/llvm-project?rev=287390=rev Log: [AMDGPU] Change frexp.exp builtin to return i16 for f16 input Differential Revision: https://reviews.llvm.org/D26863 Modified:

[PATCH] D26868: Sema: As of MSVC 2015, a user-declared move operation causes the deletion of both copy operations.

pcc created this revision. pcc added reviewers: rnk, rsmith. pcc added a subscriber: cfe-commits. https://reviews.llvm.org/D26868 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaCXX/MicrosoftCompatibility.cpp Index: clang/test/SemaCXX/MicrosoftCompatibility.cpp

[PATCH] D26815: [libcxx] [test] Fix an assumption about the state of moved-from std::functions.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r287382. https://reviews.llvm.org/D26815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26813: [libcxx] [test] allocator is non-Standard.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r287381. https://reviews.llvm.org/D26813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26816: [libcxx] [test] Fix non-Standard assumptions when testing sample().

STL_MSFT closed this revision. STL_MSFT marked an inline comment as done. STL_MSFT added a comment. Thanks, r287383 (including the requested comment). https://reviews.llvm.org/D26816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

hans added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7670-7673 +if ((Old_TSK == TSK_ExplicitInstantiationDeclaration || + Old_TSK == TSK_ImplicitInstantiation) && (TSK == TSK_ExplicitInstantiationDefinition ||

[PATCH] D26186: Allow using libsupc++ with LIBCXX_ENABLE_STATIC_ABI_LIBRARY

EricWF closed this revision. EricWF added a comment. Committed as r287388. https://reviews.llvm.org/D26186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r287388 - Allow using libsupc++ with LIBCXX_ENABLE_STATIC_ABI_LIBRARY. Patch from Michael Daniels.

Author: ericwf Date: Fri Nov 18 16:25:41 2016 New Revision: 287388 URL: http://llvm.org/viewvc/llvm-project?rev=287388=rev Log: Allow using libsupc++ with LIBCXX_ENABLE_STATIC_ABI_LIBRARY. Patch from Michael Daniels. The code cannot currently link when using libsupc++ with the

[PATCH] D26863: [AMDGPU] Change frexp.exp builtin to return i16 for f16 input

This revision was automatically updated to reflect the committed changes. Closed by commit rL287390: [AMDGPU] Change frexp.exp builtin to return i16 for f16 input (authored by kzhuravl). Changed prior to commit: https://reviews.llvm.org/D26863?vs=78546=78586#toc Repository: rL LLVM

[PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

puetzk added a comment. Also rebased against r287335/496a3f56c7 Repository: rL LLVM https://reviews.llvm.org/D26846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D26843: Make sizeof expression context partially evaluated

FYI I took the example from the [C++1z standard]( http://eel.is/c++draft/expr.prim.id#2) > [expr.prim.id]p2: > An id-expression that denotes a non-static data member or non-static member function of a class can only > be used [...] if that id-expression denotes a non-static data member and it

r287378 - [ARM] Fix sema check of ARM special register names

Author: oleg Date: Fri Nov 18 15:00:08 2016 New Revision: 287378 URL: http://llvm.org/viewvc/llvm-project?rev=287378=rev Log: [ARM] Fix sema check of ARM special register names Summary: This is a simple sema check patch for arguments of `__builtin_arm_rsr` and the related builtins, which

[PATCH] D26816: [libcxx] [test] Fix non-Standard assumptions when testing sample().

STL_MSFT marked an inline comment as done. STL_MSFT added a comment. Added the requested comment, will commit. Comment at: test/std/algorithms/alg.modifying.operations/alg.random.sample/sample.pass.cpp:74 assert(end.base() - oa == std::min(os, is)); -

[libcxx] r287383 - [libcxx] [test] D26816: Fix non-Standard assumptions when testing sample().

Author: stl_msft Date: Fri Nov 18 15:54:43 2016 New Revision: 287383 URL: http://llvm.org/viewvc/llvm-project?rev=287383=rev Log: [libcxx] [test] D26816: Fix non-Standard assumptions when testing sample(). sample() isn't specified with a reproducible algorithm, so expecting exact output is

[libcxx] r287381 - [libcxx] [test] D26813: allocator is non-Standard.

Author: stl_msft Date: Fri Nov 18 15:54:31 2016 New Revision: 287381 URL: http://llvm.org/viewvc/llvm-project?rev=287381=rev Log: [libcxx] [test] D26813: allocator is non-Standard. N4582 17.6.3.5 [allocator.requirements] says that allocators are given cv-unqualified object types, and N4582

[libcxx] r287382 - [libcxx] [test] D26815: Fix an assumption about the state of moved-from std::functions.

Author: stl_msft Date: Fri Nov 18 15:54:38 2016 New Revision: 287382 URL: http://llvm.org/viewvc/llvm-project?rev=287382=rev Log: [libcxx] [test] D26815: Fix an assumption about the state of moved-from std::functions. The Standard doesn't provide any guarantees beyond "valid but unspecified"

[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

smeenai added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7670-7673 +if ((Old_TSK == TSK_ExplicitInstantiationDeclaration || + Old_TSK == TSK_ImplicitInstantiation) && (TSK == TSK_ExplicitInstantiationDefinition ||

[PATCH] D26814: [libcxx] [test] Change ifstream constructor tests to handle read-only files.

STL_MSFT added a comment. My changes to the ofstream.cons tests preserve the test coverage (as they already contain the machinery to create writable files). Would you like it if I removed the "if (fs) { stuff }" blocks from the ifstream.cons tests entirely, and changed the comments to say

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

AntonBikineev updated this revision to Diff 78510. https://reviews.llvm.org/D26829 Files: include/clang/Basic/DiagnosticLexKinds.td include/clang/Lex/LiteralSupport.h lib/Lex/Lexer.cpp lib/Lex/LiteralSupport.cpp Index: lib/Lex/LiteralSupport.cpp

[PATCH] D21099: [Sema] Teach -Wcast-align to look at the aligned attribute of the declared variables

arphaman added inline comments. Comment at: lib/Sema/SemaChecking.cpp:10270 +static void setSrcAlign(Expr *SE, CharUnits , ASTContext ) { + if (const auto *DRE = dyn_cast(SE)) I'm not sure if you can, since I don't really know `CharUnits`, but I think you

[PATCH] D25869: [Driver] Add unit tests for Distro detection

bruno added a comment. LGTM! Please add this before https://reviews.llvm.org/D26850, which should contain a testcase on top of this! Thanks https://reviews.llvm.org/D25869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

RE: D26636: patch for llvm/clang bug 25965, suppress warning diagnostic on float-to-bool conversion when in condition context

Thanks for your question The bug was originally posted in llvm bugs database, see 25965, there is discussion between Richard Smith and the submitter Gregory Pakosz which concludes "maybe we should suppress the diagnostic entirely". Evidently there is fairly usage to guard against divide by

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

sdardis added inline comments. Comment at: lib/Sema/SemaExpr.cpp:8064 + ScalarCast = CK_FloatingCast; +} else if (ScalarTy->isIntegralType(S.Context)) { + // Determine if the integer constant can be expressed as a floating point bruno wrote: > I

[PATCH] D26636: patch for llvm/clang bug 25965, suppress warning diagnostic on float-to-bool conversion when in condition context

joerg added a comment. Besides "it triggers on SPEC", why should the warning be disabled here? I think it is perfectly sensible to have a warning for all six conditional contexts here. https://reviews.llvm.org/D26636 ___ cfe-commits mailing list

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

malcolm.parsons added a comment. Does `Sema::CheckLiteralOperatorDeclaration` need to check `StringLiteralParser::isValidUDSuffix`? https://reviews.llvm.org/D26829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

sdardis updated this revision to Diff 78531. sdardis marked 4 inline comments as done. sdardis added a comment. Addressed review comments. https://reviews.llvm.org/D25866 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp test/Sema/vector-cast.c

[PATCH] D26830: [libcxx] Add string_view literals

AntonBikineev updated this revision to Diff 78532. AntonBikineev marked an inline comment as done. AntonBikineev added a comment. Fixing typos... https://reviews.llvm.org/D26830 Files: include/string_view test/std/strings/string.view/string.view.literals/literal.pass.cpp

[PATCH] D26863: [AMDGPU] Change frexp.exp builtin to return i16 for f16 input

kzhuravl created this revision. kzhuravl added reviewers: tstellarAMD, arsenm. kzhuravl added subscribers: b-sumner, cfe-commits. Herald added subscribers: tony-tye, yaxunl, nhaehnle, wdng. https://reviews.llvm.org/D26863 Files: include/clang/Basic/BuiltinsAMDGPU.def

[PATCH] D26863: [AMDGPU] Change frexp.exp builtin to return i16 for f16 input

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D26863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26845: [analyzer] Fix crash on the access to a union's region.

NoQ added a comment. Thanks for looking into this! It seems to be exactly the same as https://reviews.llvm.org/D26442. I was just about to commit this last one, however maybe we should actually have a more careful investigation on this issue now that we have duplicates. Repository: rL LLVM

[PATCH] D26588: Add LocationContext to members of check::RegionChanges

NoQ added inline comments. Comment at: include/clang/StaticAnalyzer/Core/Checker.h:325 + const CallEvent *Call, + const LocationContext *LCtx) { +return ((const CHECKER *) checker)->checkRegionChanges(state, invalidated,

[PATCH] D26858: [AArch64] Don't constrain the assembler when using -mgeneral-regs-only

sbaranga updated this revision to Diff 78541. sbaranga added a comment. Update regression tests. https://reviews.llvm.org/D26858 Files: docs/UsersManual.rst lib/Driver/Tools.cpp test/Driver/aarch64-mgeneral_regs_only.c Index: lib/Driver/Tools.cpp

[PATCH] D26544: [PPC] support for arithmetic builtins in the FE

kbarton accepted this revision. kbarton added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D26544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26843: Make sizeof expression context partially evaluated

EricWF added a comment. In case your wondering *why* this happens In https://reviews.llvm.org/D26843#599804, @pmatos wrote: > In https://reviews.llvm.org/D26843#599673, @EricWF wrote: > > > > But that is not valid in C afaik and in C++ I get: > > > > > > error: invalid use of non-static data

[PATCH] D26843: Make sizeof expression context partially evaluated

EricWF added a comment. > This is different from your initial snippet and compiles fine with my patch. Your confused. Both examples compile fine w/o your patch and are rejected with it. I just double checked. https://reviews.llvm.org/D26843 ___

r287358 - LTO support for -fsave-optimization-record on Darwin

Author: anemet Date: Fri Nov 18 12:17:36 2016 New Revision: 287358 URL: http://llvm.org/viewvc/llvm-project?rev=287358=rev Log: LTO support for -fsave-optimization-record on Darwin I guess this would have to be added for each linker. Differential Revision: https://reviews.llvm.org/D26833

[PATCH] D26833: LTO support for -fsave-optimization-record on Darwin

anemet added a comment. Mehdi offered to help out making this work for ThinLTO on the LLVM side. For now this option will be ignored by ThinLTO. https://reviews.llvm.org/D26833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r287373 - Make LIBCXX_ENABLE_STATIC_ABI_LIBRARY merge libc++.a and libc++abi.a

Author: ericwf Date: Fri Nov 18 13:53:45 2016 New Revision: 287373 URL: http://llvm.org/viewvc/llvm-project?rev=287373=rev Log: Make LIBCXX_ENABLE_STATIC_ABI_LIBRARY merge libc++.a and libc++abi.a Modified: libcxx/trunk/CMakeLists.txt libcxx/trunk/lib/CMakeLists.txt

[libcxxabi] r287364 - __cxa_demangle: use default member initialization

Author: compnerd Date: Fri Nov 18 13:01:53 2016 New Revision: 287364 URL: http://llvm.org/viewvc/llvm-project?rev=287364=rev Log: __cxa_demangle: use default member initialization Sink the Db initialization into the structure rather than out-of-line at the declaration size. This just makes it

[PATCH] D26843: Make sizeof expression context partially evaluated

pmatos added a comment. Apologies if I am being shallow and wasting your time but `sizeof(T::m)` doesn't compile at the moment with clang trunk. Using the same service you used before . https://reviews.llvm.org/D26843

[PATCH] D26807: Fix a comment for -fsave-optimization-record

This revision was automatically updated to reflect the committed changes. Closed by commit rL287357: Fix a comment for -fsave-optimization-record (authored by anemet). Changed prior to commit: https://reviews.llvm.org/D26807?vs=78389=78551#toc Repository: rL LLVM

[PATCH] D26833: LTO support for -fsave-optimization-record on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rL287358: LTO support for -fsave-optimization-record on Darwin (authored by anemet). Changed prior to commit: https://reviews.llvm.org/D26833?vs=78464=78552#toc Repository: rL LLVM

r287357 - Fix a comment for -fsave-optimization-record

Author: anemet Date: Fri Nov 18 12:17:33 2016 New Revision: 287357 URL: http://llvm.org/viewvc/llvm-project?rev=287357=rev Log: Fix a comment for -fsave-optimization-record Differential Revision: https://reviews.llvm.org/D26807 Modified: cfe/trunk/lib/Driver/Tools.cpp Modified:

[PATCH] D26845: [analyzer] Fix crash on the access to a union's region.

alexshap added a comment. Thanks, - just want to have one of them (https://reviews.llvm.org/D26442 or this one) checked in sooner rather than later. Looks like i have missed that diff on cfe-commits, I'm ok to abandon my patch in favor of https://reviews.llvm.org/D26442. Repository: rL LLVM

[PATCH] D26808: [Sema] Don't allow applying address-of operator to a call to a function with __unknown_anytype return type

spyffe accepted this revision. spyffe added a comment. This revision is now accepted and ready to land. I think it's all right to be conservative here. The inference rules could get quite complicated if (for example) the use looked like this extern void foo (double *bar); extern

[PATCH] D26560: Add a test for vcall on a null ptr.

krasin added inline comments. Comment at: test/ubsan/TestCases/TypeCheck/null.cpp:1 -// RUN: %clangxx -fsanitize=null %s -O3 -o %t -// RUN: %run %t l 2>&1 | FileCheck %s --check-prefix=CHECK-LOAD -// RUN: %expect_crash %run %t s 2>&1 | FileCheck %s --check-prefix=CHECK-STORE -//

[PATCH] D26560: Add a test for vcall on a null ptr.

krasin updated this revision to Diff 78557. krasin added a comment. sync & address the comments. https://reviews.llvm.org/D26560 Files: test/ubsan/TestCases/TypeCheck/null.cpp Index: test/ubsan/TestCases/TypeCheck/null.cpp ===

r287371 - Adapt to llvm NamedRegionTimer changes

Author: matze Date: Fri Nov 18 13:43:25 2016 New Revision: 287371 URL: http://llvm.org/viewvc/llvm-project?rev=287371=rev Log: Adapt to llvm NamedRegionTimer changes We have to specify a name and description for the timers and groups now. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp

Re: [PATCH] D26843: Make sizeof expression context partially evaluated

On 18/11/16 20:30, Aaron Ballman wrote: > On Fri, Nov 18, 2016 at 2:22 PM, Paulo Matos via cfe-commits > wrote: >> pmatos added a comment. >> >> Apologies if I am being shallow and wasting your time but `sizeof(T::m)` >> doesn't compile at the moment with clang

[PATCH] D26812: [libcxx] [test] In random tests, use real static_asserts and silence a warning.

STL_MSFT accepted this revision. STL_MSFT added a reviewer: STL_MSFT. STL_MSFT added a comment. This revision is now accepted and ready to land. Made the requested changes, committed as r287391 with Eric's approval. Comment at:

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticLexKinds.td:189-190 InGroup, DefaultIgnore; +def err_cxx1z_string_view_literal : Error< + "string_view literals are a C++1z feature">; def ext_binary_literal : Extension< I don't see a

[PATCH] D26589: Add static analyzer checker for finding infinite recursion

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/RecursionChecker.cpp:65 + + for (const auto *ParentLC = C.getStackFrame()->getParent(); + ParentLC != nullptr; ParentLC = ParentLC->getParent()) { Off-by-1: `C.getStackFrame()` is already

[PATCH] D26814: [libcxx] [test] Change ifstream constructor tests to handle read-only files.

STL_MSFT updated the summary for this revision. STL_MSFT updated this revision to Diff 78589. STL_MSFT added a comment. Instead of skipping failures to open, just have comments pointing to the ofstream.cons tests where this coverage has moved. https://reviews.llvm.org/D26814 Files:

r287410 - [Sema] Don't allow applying address-of operator to a call to a function

Author: ahatanak Date: Fri Nov 18 18:13:03 2016 New Revision: 287410 URL: http://llvm.org/viewvc/llvm-project?rev=287410=rev Log: [Sema] Don't allow applying address-of operator to a call to a function with __unknown_anytype return type. When the following code is compiled, Sema infers that the

[PATCH] D26808: [Sema] Don't allow applying address-of operator to a call to a function with __unknown_anytype return type

This revision was automatically updated to reflect the committed changes. Closed by commit rL287410: [Sema] Don't allow applying address-of operator to a call to a function (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D26808?vs=78396=78598#toc Repository: rL

[PATCH] D26826: [libcxx] Implement locale.h to fix modules build

EricWF added inline comments. Comment at: include/locale.h:2 +// -*- C++ -*- +//=== math.h --===// +// rsmith wrote: > This is not math.h. It was fixed before committing but I didn't update phab.

[PATCH] D26186: Allow using libsupc++ with LIBCXX_ENABLE_STATIC_ABI_LIBRARY

mdaniels added a comment. I don't have commit access, could I trouble someone to do it on my behalf? https://reviews.llvm.org/D26186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26110: Add a check for GCC to the _LIBCPP_EXPLICIT define

mdaniels added a comment. I don't have commit access, could I trouble someone to do it on my behalf? https://reviews.llvm.org/D26110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r287413 - [libcxx] Implement locale.h to fix modules build

Author: ericwf Date: Fri Nov 18 19:14:15 2016 New Revision: 287413 URL: http://llvm.org/viewvc/llvm-project?rev=287413=rev Log: [libcxx] Implement locale.h to fix modules build Summary: Because `locale.h` isn't part of the libc++ modules the class definitions it provides are exported as part of

[PATCH] D26760: Add the way to extract SVals of arguments used in a call for a given StackFrameCtx

NoQ added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:739 + if (SFC->inTopFrame()) { +// if we are in the top frame we don't have any arguments bound in the store +// because the call wasn't modeled in the first place.

[libcxx] r287417 - Mark test as unsupported in C++03

Author: ericwf Date: Fri Nov 18 19:38:00 2016 New Revision: 287417 URL: http://llvm.org/viewvc/llvm-project?rev=287417=rev Log: Mark test as unsupported in C++03 Modified: libcxx/trunk/test/libcxx/modules/clocale_exports.sh.cpp Modified:

[PATCH] D24933: Enable configuration files in clang

srhines added a comment. Thanks to Hans for notifying me about this. Cross-compilation flags are a big challenge in Android, but I have similar concerns about looking for magic files/dirs. Richard's suggestion about improving @file is really interesting, and would satisfy a large part of our

[libcxx] r287391 - [libcxx] [test] D26812: In random tests, use real static_asserts and silence a warning.

Author: stl_msft Date: Fri Nov 18 16:45:32 2016 New Revision: 287391 URL: http://llvm.org/viewvc/llvm-project?rev=287391=rev Log: [libcxx] [test] D26812: In random tests, use real static_asserts and silence a warning. In C++11 mode and newer, use real static_asserts. In C++03 mode, min() and

[PATCH] D26760: Add the way to extract SVals of arguments used in a call for a given StackFrameCtx

NoQ added a comment. Note that the uncontrolled recursion checker will not be able to test this overwrite problem, because overwriting the argument region spoils the stack frame for it. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:743 +const

[PATCH] D26826: [libcxx] Implement locale.h to fix modules build

rsmith added a comment. This should only be needed if you are not using `-fmodules-local-submodule-visibility` and do not have a module map for your C standard library. Is that really a configuration we want to support? Building without `-fmodules-local-submodule-visibility` typically only

r287406 - [CMake] clang-offload-bundler depends on intrinsics_gen

Author: cbieneman Date: Fri Nov 18 17:31:14 2016 New Revision: 287406 URL: http://llvm.org/viewvc/llvm-project?rev=287406=rev Log: [CMake] clang-offload-bundler depends on intrinsics_gen ClangOffloadBundler.cpp has the following include chain: llvm/Bitcode/BitcodeWriter.h

r287407 - [CMake] clang depends on intrinsics_gen

Author: cbieneman Date: Fri Nov 18 17:31:16 2016 New Revision: 287407 URL: http://llvm.org/viewvc/llvm-project?rev=287407=rev Log: [CMake] clang depends on intrinsics_gen cc1_main.cpp has the following include chain: llvm/LinkAllPasses.h llvm/Analysis/AliasSetTracker.h

[PATCH] D21099: [Sema] Teach -Wcast-align to look at the aligned attribute of the declared variables

ahatanak updated this revision to Diff 78594. ahatanak marked 2 inline comments as done. ahatanak added a comment. Make the helper function return the Decl's alignment by value. https://reviews.llvm.org/D21099 Files: lib/Sema/SemaChecking.cpp test/Sema/warn-cast-align.c Index:

[PATCH] D26868: Sema: As of MSVC 2015, a user-declared move operation causes the deletion of both copy operations.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Nice, lgtm https://reviews.llvm.org/D26868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r287411 - Sema: As of MSVC 2015, a user-declared move operation causes the deletion of both copy operations.

Author: pcc Date: Fri Nov 18 18:30:56 2016 New Revision: 287411 URL: http://llvm.org/viewvc/llvm-project?rev=287411=rev Log: Sema: As of MSVC 2015, a user-declared move operation causes the deletion of both copy operations. Differential Revision: https://reviews.llvm.org/D26868 Modified:

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

AntonBikineev updated this revision to Diff 78602. https://reviews.llvm.org/D26829 Files: include/clang/Basic/DiagnosticLexKinds.td include/clang/Lex/LiteralSupport.h lib/Lex/Lexer.cpp lib/Lex/LiteralSupport.cpp lib/Sema/SemaDeclCXX.cpp test/SemaCXX/cxx1z-user-defined-literals.cpp

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

AntonBikineev added a comment. In https://reviews.llvm.org/D26829#599906, @malcolm.parsons wrote: > Does `Sema::CheckLiteralOperatorDeclaration` need to check > `StringLiteralParser::isValidUDSuffix`? Thanks, nice point! Just addressed it. https://reviews.llvm.org/D26829

[PATCH] D26868: Sema: As of MSVC 2015, a user-declared move operation causes the deletion of both copy operations.

This revision was automatically updated to reflect the committed changes. Closed by commit rL287411: Sema: As of MSVC 2015, a user-declared move operation causes the deletion of… (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D26868?vs=78576=78603#toc Repository: rL

[PATCH] D26881: [libcxx] Remove CPlusPlus11 requirements from the module.modulemap

EricWF created this revision. EricWF added reviewers: rsmith, mclow.lists. EricWF added a subscriber: cfe-commits. This patch does two things: - Allow `std.strstream` to used in C++11. This is needed to get the libc++ test suite passing with modules enabled. Also enforcing that strstream is

[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

smeenai updated this revision to Diff 78620. smeenai updated the summary for this revision. smeenai added a comment. Addressing comments https://reviews.llvm.org/D26657 Files: include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cpp test/CodeGenCXX/dllexport.cpp

[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

smeenai updated this revision to Diff 78621. smeenai added a comment. Typo in comment https://reviews.llvm.org/D26657 Files: include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cpp test/CodeGenCXX/dllexport.cpp test/CodeGenCXX/windows-itanium-dllexport.cpp Index:

[libcxx] r287435 - Fix stdint/cstdint modules

Author: ericwf Date: Fri Nov 18 21:29:03 2016 New Revision: 287435 URL: http://llvm.org/viewvc/llvm-project?rev=287435=rev Log: Fix stdint/cstdint modules Added: libcxx/trunk/test/libcxx/modules/cinttypes_exports.sh.cpp libcxx/trunk/test/libcxx/modules/cstdint_exports.sh.cpp

[PATCH] D26885: [libcxx] Fix max_size() across all containers

EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. The `max_size()` method of containers should respect both the allocator's reported `max_size` and the range of the `difference_type`. This patch makes all containers choose the smallest

r287436 - Doxygen comments for avxintrin.h.

Author: kromanova Date: Fri Nov 18 22:59:08 2016 New Revision: 287436 URL: http://llvm.org/viewvc/llvm-project?rev=287436=rev Log: Doxygen comments for avxintrin.h. Added doxygen comments to avxintrin.h's intrinsics. As of now, all the intrinsics in this file that were documented by Sony's

  1   2   >