[PATCH] D23765: Fix for clang PR 29087

2016-11-27 Thread Hal Finkel via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL287999: Adjust type-trait evaluation to properly handle Using(Shadow)Decls (authored by hfinkel). Changed prior to commit: https://reviews.llvm.org/D23765?vs=76817=79354#toc Repository: rL LLVM

r287999 - Adjust type-trait evaluation to properly handle Using(Shadow)Decls

2016-11-27 Thread Hal Finkel via cfe-commits
Author: hfinkel Date: Sun Nov 27 10:26:14 2016 New Revision: 287999 URL: http://llvm.org/viewvc/llvm-project?rev=287999=rev Log: Adjust type-trait evaluation to properly handle Using(Shadow)Decls Since r274049, for an inheriting constructor declaration, the name of the using declaration (and

Re: r282411 - [analyzer] Improve CastToStruct checker so it can also detect widening casts of struct data

2016-11-27 Thread Abramo Bagnara via cfe-commits
Il 26/09/2016 17:17, Daniel Marjamaki via cfe-commits ha scritto: > Author: danielmarjamaki > Date: Mon Sep 26 10:17:18 2016 > New Revision: 282411 > > URL: http://llvm.org/viewvc/llvm-project?rev=282411=rev > Log: > [analyzer] Improve CastToStruct checker so it can also detect widening casts >

[PATCH] D26934: [libc++] Add _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS

2016-11-27 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai updated this revision to Diff 79359. smeenai added a comment. Not changing non-Windows behavior, to make sure I'm not breaking anyone https://reviews.llvm.org/D26934 Files: CMakeLists.txt docs/UsingLibcxx.rst include/__config include/__config_site.in Index:

[PATCH] D27153: [libc++] Make __num_get_float hidden

2016-11-27 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai created this revision. smeenai added reviewers: EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. It's an internal function and shouldn't be exported. It's also a source of discrepancy in the published ABI list; these symbols aren't exported for me on CentOS 7 or Ubuntu 16.04,

[PATCH] D25717: [x86][inline-asm][clang][fixup] accept 'v' constraint

2016-11-27 Thread coby via Phabricator via cfe-commits
coby abandoned this revision. coby added a comment. deprecated Repository: rL LLVM https://reviews.llvm.org/D25717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26082: Support for Python 3 in libclang python bindings

2016-11-27 Thread Mathieu Duponchelle via Phabricator via cfe-commits
MathieuDuponchelle added a comment. Hey, for what it's worth when skipping the free at this line: https://github.com/llvm-mirror/clang/blob/master/bindings/python/clang/cindex.py#L181 the issues are gone, I haven't investigated the reason why. Repository: rL LLVM

[PATCH] D26934: [libc++] Add _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS

2016-11-27 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai updated this revision to Diff 79358. smeenai added a comment. Herald added a subscriber: mgorny. Addressing comments https://reviews.llvm.org/D26934 Files: CMakeLists.txt docs/UsingLibcxx.rst include/__config include/__config_site.in Index: include/__config_site.in

[PATCH] D26934: [libc++] Add _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS

2016-11-27 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added inline comments. Comment at: include/__config:513-516 #if defined(_LIBCPP_DISABLE_DLL_IMPORT_EXPORT) +// this can be removed once any existing users have switched to the new macro +# error "Use _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS instead of

[PATCH] D27157: IRGen: Remove all uses of CreateDefaultAlignedLoad.

2016-11-27 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Thanks for doing this! A couple minor questions / comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2195 LoadInst *Load = -Builder.CreateDefaultAlignedLoad(IntToPtr, /*isVolatile=*/true); +Builder.CreateAlignedLoad(IntTy,

[PATCH] D27099: [OpenCL] Prohibit using reserve_id_t in program scope.

2016-11-27 Thread Egor Churaev via Phabricator via cfe-commits
echuraev updated this revision to Diff 79372. echuraev marked 2 inline comments as done. https://reviews.llvm.org/D27099 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/SemaOpenCL/event_t.cl test/SemaOpenCL/invalid-clk-events-cl2.0.cl

[PATCH] D27153: [libc++] Make __num_get_float hidden

2016-11-27 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. I'm having some second thoughts about this. Visibility for template functions makes my head spin :/ Is there a general policy we've been following for these? I didn't find much just scanning through other definitions. https://reviews.llvm.org/D27153

[PATCH] D27157: IRGen: Remove all uses of CreateDefaultAlignedLoad.

2016-11-27 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc created this revision. pcc added a reviewer: rsmith. pcc added subscribers: cfe-commits, rjmccall. https://reviews.llvm.org/D27157 Files: clang/lib/CodeGen/CGBuilder.h clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGObjCGNU.cpp

[PATCH] D26904: [astimporter] Support importing CXXDependentScopeMemberExpr and FunctionTemplateDecl

2016-11-27 Thread Kareem Khazem via Phabricator via cfe-commits
khazem updated this revision to Diff 79371. khazem added a comment. Thanks for the comments, Aleksei! I've merged some aspects of the code you pointed me to, although I had to change some of it because some of the function calls have changed since 2015. In particular, I'm checking for

[PATCH] D26082: Support for Python 3 in libclang python bindings

2016-11-27 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe added a comment. Thanks Mathieu. Tests ran without issues when I submitted my patch but I tested on macOS. I'll have a look into this and see if I can reproduce the problem. Repository: rL LLVM https://reviews.llvm.org/D26082 ___