[PATCH] D28279: [clang-move] Support moving type alias declarations.

hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D28279 Files: clang-move/ClangMove.cpp test/clang-move/Inputs/type_alias.h test/clang-move/move-type-alias.cpp unittests/clang-move/ClangMoveTests.cpp Index:

[PATCH] D28286: [CodeCompletion] Code complete the missing C++11 keywords

arphaman created this revision. arphaman added reviewers: manmanren, akyrtzi. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch adds context sensitive code completion support for the C++11 keywords that currently don't have completion

[PATCH] D28231: -Wunreachable-code: Avoid multiple diagnostics that are triggered by the same source range and fix the unary operator fixit source range

arphaman updated this revision to Diff 83032. arphaman added a comment. You're right, the fixit for `if (!s->p || 1)` is wrong, but that was another existing bug. The updated patch fixes this issue. Repository: rL LLVM https://reviews.llvm.org/D28231 Files: lib/Analysis/ReachableCode.cpp

[PATCH] D27478: Make ASTContext::getDeclAlign return the correct alignment for FunctionDecls

arphaman accepted this revision. arphaman added a reviewer: arphaman. arphaman added a comment. This revision is now accepted and ready to land. Thanks. LGTM, I think the patch makes sense. https://reviews.llvm.org/D27478 ___ cfe-commits mailing

[PATCH] D17981: [clang-tidy] Fix clang-tidy to support parsing of assembly statements.

jckooijman added a comment. Hi, this is my first time posting here so excuse me if i am giving you not enough information. I found this bugreport from: https://blog.yuo.be/2016/05/11/columns-ui-can-now-be-compiled-using-clang/ I am getting the exact same issue using clang-tidy e.g.

[PATCH] D28246: clang-format: [JS] avoid indent after ambient function declarations.

sammccall accepted this revision. sammccall added a reviewer: sammccall. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: unittests/Format/FormatTestJS.cpp:382 + "let x = 1;\n"); + verifyFormat("declare function foo():

Re: [PATCH] D27123: Add AVR target and toolchain to Clang

On 1/4/17 2:52 AM, Dylan McKay wrote: I've just raised a bug here https://llvm.org/bugs/show_bug.cgi?id=31530 > What's necessary for sign-off? Should I ping the reviewer (Richard Smith) again? I think so long as Richard or someone else who actively works on Clang signs off. Perhaps

[PATCH] D28282: [change-namespace] get whitespaces right when moving old namespaces.

alexshap added a comment. thx, LGTM https://reviews.llvm.org/D28282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28246: clang-format: [JS] avoid indent after ambient function declarations.

mprobst updated this revision to Diff 83038. mprobst added a comment. - Handle type declarations. - test for object literal return types https://reviews.llvm.org/D28246 Files: lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp

[PATCH] D28246: clang-format: [JS] avoid indent after ambient function declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rL290959: clang-format: [JS] avoid indent after ambient function declarations. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D28246?vs=83038=83039#toc Repository: rL LLVM

[PATCH] D28246: clang-format: [JS] avoid indent after ambient function declarations.

mprobst marked an inline comment as done. mprobst added inline comments. Comment at: unittests/Format/FormatTestJS.cpp:382 + "let x = 1;\n"); + verifyFormat("declare function foo(): string;\n" + "let x = 1;\n"); sammccall wrote: >

[PATCH] D28289: Fix tests with CLANG_DEFAULT_LINKER

Hahnfeld created this revision. Hahnfeld added reviewers: phosek, mgorny. Hahnfeld added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert. I originally requested this to be tested in https://reviews.llvm.org/D25263 but in the end forgot to make sure that it was done.

[PATCH] D27163: Introduce -f[no-]strict-return flag that controls code generation for C++'s undefined behaviour return optimisation

This revision was automatically updated to reflect the committed changes. arphaman marked 5 inline comments as done. Closed by commit rL290960: Add -f[no-]strict-return flag that can be used to avoid undefined behaviour (authored by arphaman). Changed prior to commit:

r290960 - Add -f[no-]strict-return flag that can be used to avoid undefined behaviour

Author: arphaman Date: Wed Jan 4 07:40:34 2017 New Revision: 290960 URL: http://llvm.org/viewvc/llvm-project?rev=290960=rev Log: Add -f[no-]strict-return flag that can be used to avoid undefined behaviour in non-void functions that fall off at the end without returning a value when compiling

[PATCH] D28229: [libcxx] Fix testing of the externally-threaded library build after r290850

rmaprath added a comment. In https://reviews.llvm.org/D28229#634278, @compnerd wrote: > I dont think that making Win32 threading an external one makes much sense > unless we also do the same for pthreads. Its just as valid a threading model > as pthreads, so why give preferential treatment to

[PATCH] D28282: [change-namespace] get whitespaces right when moving old namespaces.

ioeric updated this revision to Diff 83051. ioeric marked an inline comment as done. ioeric added a comment. - fix a nit. https://reviews.llvm.org/D28282 Files: change-namespace/ChangeNamespace.cpp unittests/change-namespace/ChangeNamespaceTests.cpp Index:

[clang-tools-extra] r290966 - [change-namespace] get newlines around moved namespace right.

Author: ioeric Date: Wed Jan 4 08:49:08 2017 New Revision: 290966 URL: http://llvm.org/viewvc/llvm-project?rev=290966=rev Log: [change-namespace] get newlines around moved namespace right. Summary: Previously, a `\n` might be left in the old namespace and thus not copied to the new namespace,

[clang-tools-extra] r290967 - [clang-move] Support moving type alias declarations.

Author: hokein Date: Wed Jan 4 08:50:49 2017 New Revision: 290967 URL: http://llvm.org/viewvc/llvm-project?rev=290967=rev Log: [clang-move] Support moving type alias declarations. Reviewers: ioeric Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D28279 Added:

[PATCH] D28279: [clang-move] Support moving type alias declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rL290967: [clang-move] Support moving type alias declarations. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D28279?vs=83016=83053#toc Repository: rL LLVM

r290959 - clang-format: [JS] avoid indent after ambient function declarations.

Author: mprobst Date: Wed Jan 4 07:36:43 2017 New Revision: 290959 URL: http://llvm.org/viewvc/llvm-project?rev=290959=rev Log: clang-format: [JS] avoid indent after ambient function declarations. Summary: Before: declare function foo(); let x = 1; After: declare function foo(); let

[PATCH] D28282: [change-namespace] get whitespaces right when moving old namespaces.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM with some nits. Would be clearer to elaborate more descriptions in the commit message. Looks like the patch actually resolves newline character "\n" rather than whitespace...

[PATCH] D28282: [change-namespace] get newlines around moved namespace right.

This revision was automatically updated to reflect the committed changes. Closed by commit rL290966: [change-namespace] get newlines around moved namespace right. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D28282?vs=83051=83052#toc Repository: rL LLVM

[PATCH] D28257: [OpenCL] Re-enable supported core extensions based on opencl version when disabling all extensions using pragma

Anastasia added inline comments. Comment at: test/SemaOpenCL/extensions.cl:47 +#ifndef _OPENCL_H_ int isnan(float x) { Why do you need this? https://reviews.llvm.org/D28257 ___ cfe-commits mailing list

Re: [PATCH] D27123: Add AVR target and toolchain to Clang

Did you get the BugZilla account sorted Senthil? On Thu, Dec 22, 2016 at 10:47 AM, Nico Weber wrote: > On Wed, Dec 21, 2016 at 6:42 AM, Senthil Kumar Selvaraj via Phabricator > via cfe-commits wrote: > >> saaadhu added a comment. >> >> Would

Re: [PATCH] D27123: Add AVR target and toolchain to Clang

I've just raised a bug here https://llvm.org/bugs/show_bug.cgi?id=31530 > What's necessary for sign-off? Should I ping the reviewer (Richard Smith) again? I think so long as Richard or someone else who actively works on Clang signs off. Perhaps somebody else is keen to review? On the other

[PATCH] D28321: [CUDA] Add __declspec spellings for CUDA attributes.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:604 +// CUDA attributes are spelled __attribute__((attr)) or __declspec(__attr__). + jlebar wrote: > aaron.ballman wrote: > > jlebar wrote: > > > aaron.ballman wrote: > > > >

[PATCH] D28207: Add second fast path for DiagnosticsEngine::GetDiagStatePointForLoc

djasper added inline comments. Comment at: lib/Basic/Diagnostic.cpp:179 + + // 2nd most frequent case: L is before the first diag state change. + FullSourceLoc FirstStateChangePos = DiagStatePoints[1].Loc; rsmith wrote: > djasper wrote: > > rsmith wrote: > > >

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

echristo added a comment. In https://reviews.llvm.org/D27872#636147, @timshen wrote: > In https://reviews.llvm.org/D27872#636130, @echristo wrote: > > > Looks pretty weird. Typically I'd suggest just: > > > > if (foo) { > > > > Foo(); > > return; > > > > } > > > > since that will keep

[PATCH] D28207: Add second fast path for DiagnosticsEngine::GetDiagStatePointForLoc

rsmith added inline comments. Comment at: lib/Basic/Diagnostic.cpp:179 + + // 2nd most frequent case: L is before the first diag state change. + FullSourceLoc FirstStateChangePos = DiagStatePoints[1].Loc; djasper wrote: > rsmith wrote: > > It's surprising to

[libcxx] r291021 - Use C++11 static_assert in variant tests. Patch from Michael Park

Author: ericwf Date: Wed Jan 4 16:43:08 2017 New Revision: 291021 URL: http://llvm.org/viewvc/llvm-project?rev=291021=rev Log: Use C++11 static_assert in variant tests. Patch from Michael Park Modified: libcxx/trunk/test/libcxx/utilities/variant/variant.variant/variant.ctor/copy.pass.cpp

r291020 - [Parse] Don't ignore attributes after a late-parsed attr.

Author: gbiv Date: Wed Jan 4 16:43:01 2017 New Revision: 291020 URL: http://llvm.org/viewvc/llvm-project?rev=291020=rev Log: [Parse] Don't ignore attributes after a late-parsed attr. Without this, we drop everything after the first late-parsed attribute in a single __attribute__. (Where "drop"

[PATCH] D28330: [analyzer] Fix false positives in Keychain API checker

alexshap added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp:527 + if (ReturnSymbol) +for (AllocatedDataTy::iterator I = ASet.begin(), E = ASet.end(); + I != E; ++I) { alexshap wrote:

[PATCH] D28330: [analyzer] Fix false positives in Keychain API checker

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Looks good to me, aside from minor quibbles about capitalization and variable naming. Comment at: lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp:502 +

r291036 - [gtest] The way EXPECT_TEST now works after upgrading gtest triggers an

Author: chandlerc Date: Wed Jan 4 17:57:25 2017 New Revision: 291036 URL: http://llvm.org/viewvc/llvm-project?rev=291036=rev Log: [gtest] The way EXPECT_TEST now works after upgrading gtest triggers an ODR use. These traits don't have a definition as they're intended to be used strictly at

[PATCH] D28320: [Driver] Driver changes to support CUDA compilation on Windows.

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains.cpp:1819 Args.getLastArgValue(options::OPT_cuda_path_EQ)); - else { + else if (HostTriple.isOSLinux() ||

[PATCH] D27429: [Chrono][Darwin] On Darwin use CLOCK_UPTIME_RAW instead of CLOCK_MONOTONIC

howard.hinnant added inline comments. Comment at: src/chrono.cpp:218 +#error "Never use CLOCK_MONOTONIC for steady_clock::now on Apple platforms" +#endif + Nice, thanks! https://reviews.llvm.org/D27429 ___

[PATCH] D28274: [MS] Instantiate default args during instantiation of exported default ctors

This revision was automatically updated to reflect the committed changes. Closed by commit rL291045: [MS] Instantiate default args during instantiation of exported default ctors (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D28274?vs=83059=83170#toc Repository: rL

r291064 - Fix assertion failure on deduction failure due to too short template argument list.

Author: rsmith Date: Wed Jan 4 20:31:32 2017 New Revision: 291064 URL: http://llvm.org/viewvc/llvm-project?rev=291064=rev Log: Fix assertion failure on deduction failure due to too short template argument list. We were previously incorrectly using TDK_TooFewArguments to report a template

[PATCH] D28037: [Altivec] Change vec_sl to a << (b % (sizeof(a) * 8))

echristo added a comment. LGTM. Thanks! -eric https://reviews.llvm.org/D28037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28330: [analyzer] Fix false positives in Keychain API checker

zaks.anna created this revision. zaks.anna added a reviewer: dcoughlin. zaks.anna added subscribers: cfe-commits, dergachev.a. The checker has several false positives that this patch addresses: 1. Do not check if the return status has been compared to error (or no error) at the time when

[PATCH] D28317: [Windows] Remove functions in intrin.h that are defined in Builtin.def.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D28317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! https://reviews.llvm.org/D27529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

timshen added a comment. In https://reviews.llvm.org/D27872#636149, @echristo wrote: > I'm pretty sure I've never seen return widely used in > the code base versus my suggestion. That said, if you've looked and it's > roughly 50/50 then I care a lot less (and we can bike shed in some separate

[PATCH] D28320: [Driver] Driver changes to support CUDA compilation on Windows.

jlebar marked an inline comment as done. jlebar added a comment. Thank you for the reviews! Comment at: clang/lib/Driver/ToolChains.cpp:1819 Args.getLastArgValue(options::OPT_cuda_path_EQ)); - else { + else if (HostTriple.isOSLinux() || HostTriple.isMacOSX()) {

[libcxx] r291065 - PR31540: install libc++abi headers into include/c++/v1 in build area.

Author: rsmith Date: Wed Jan 4 20:55:10 2017 New Revision: 291065 URL: http://llvm.org/viewvc/llvm-project?rev=291065=rev Log: PR31540: install libc++abi headers into include/c++/v1 in build area. This allows an in-build-area clang binary to find . Modified:

[PATCH] D28310: Add virtual functions getter

rjmccall added a comment. This is a potentially significant pessimization. Can you turn this into a range iterator of some sort? https://reviews.llvm.org/D28310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28037: [Altivec] Change vec_sl to a << (b % (sizeof(a) * 8))

timshen updated this revision to Diff 83140. timshen added a comment. Update comments, and move llvm changes to another patch. https://reviews.llvm.org/D28037 Files: clang/lib/Headers/altivec.h clang/test/CodeGen/builtins-ppc-altivec.c Index: clang/test/CodeGen/builtins-ppc-altivec.c

r291017 - Remove use of intrusive ref count ownership acquisition

Author: dblaikie Date: Wed Jan 4 16:36:39 2017 New Revision: 291017 URL: http://llvm.org/viewvc/llvm-project?rev=291017=rev Log: Remove use of intrusive ref count ownership acquisition The one use of CheckerManager (AnalysisConsumer, calling createCheckerManager) keeps a strong reference to the

[libcxx] r291028 - Implement P0505: 'Wording for GB 50'

Author: marshall Date: Wed Jan 4 17:03:24 2017 New Revision: 291028 URL: http://llvm.org/viewvc/llvm-project?rev=291028=rev Log: Implement P0505: 'Wording for GB 50' Modified: libcxx/trunk/include/chrono

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

timshen added a comment. In https://reviews.llvm.org/D27872#636130, @echristo wrote: > Looks pretty weird. Typically I'd suggest just: > > if (foo) { > > Foo(); > return; > > } > > since that will keep cognitive overhead to a minimum. > > -eric > > > Other functions are not controversial.

[libcxx] r291039 - Fix Sphinx build error caused by bad indentation

Author: ericwf Date: Wed Jan 4 18:04:37 2017 New Revision: 291039 URL: http://llvm.org/viewvc/llvm-project?rev=291039=rev Log: Fix Sphinx build error caused by bad indentation Modified: libcxx/trunk/docs/DesignDocs/VisibilityMacros.rst Modified:

[PATCH] D28318: [TableGen] Only normalize the spelling of GNU-style attributes.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D28318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r291046 - Fix std::pointer_safety type in ABI v2

Author: ericwf Date: Wed Jan 4 19:15:42 2017 New Revision: 291046 URL: http://llvm.org/viewvc/llvm-project?rev=291046=rev Log: Fix std::pointer_safety type in ABI v2 In the C++ standard `std::pointer_safety` is defined as a C++11 strongly typed enum. However libc++ currently defines it as a

[PATCH] D28324: [CUDA] Don't define functions that the CUDA headers themselves define on Windows.

jlebar marked an inline comment as done. jlebar added inline comments. Comment at: clang/lib/Headers/__clang_cuda_cmath.h:76 + +// For inscrutible reasons, the CUDA headers define these functions for us on +// Windows. tra wrote: > inscrut__a__ble? Thanks. :)

[libcxx] r291059 - Fix PR26961 - Add default constructor to std::pointer_safety struct.

Author: ericwf Date: Wed Jan 4 19:28:40 2017 New Revision: 291059 URL: http://llvm.org/viewvc/llvm-project?rev=291059=rev Log: Fix PR26961 - Add default constructor to std::pointer_safety struct. In ABI v1 libc++ implements std::pointer_safety as a class type instead of an enumeration. However

[PATCH] D26893: [Sema] Fix assert on valid during template argument deduction

rsmith added a comment. Sorry I missed this =( Thanks for the fix! https://reviews.llvm.org/D26893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28321: [CUDA] Add __declspec spellings for CUDA attributes.

jlebar added a comment. Thank you for the review! Comment at: clang/include/clang/Basic/Attr.td:604 +// CUDA attributes are spelled __attribute__((attr)) or __declspec(__attr__). + aaron.ballman wrote: > jlebar wrote: > > aaron.ballman wrote: > > > jlebar

r291030 - Bail out if we try to build a DeclRefExpr naming an invalid declaration.

Author: rsmith Date: Wed Jan 4 17:14:16 2017 New Revision: 291030 URL: http://llvm.org/viewvc/llvm-project?rev=291030=rev Log: Bail out if we try to build a DeclRefExpr naming an invalid declaration. Most code paths would already bail out in this case, but certain paths, particularly overload

[libcxx] r291060 - Fix XPASS buildbot failure related to structured bindings

Author: ericwf Date: Wed Jan 4 19:34:14 2017 New Revision: 291060 URL: http://llvm.org/viewvc/llvm-project?rev=291060=rev Log: Fix XPASS buildbot failure related to structured bindings The test was previously set to XFAIL if __cpp_structured_bindings wasn't defined. However there are Clang 4.0

[PATCH] D26893: [Sema] Fix assert on valid during template argument deduction

erik.pilkington abandoned this revision. erik.pilkington added a comment. @rsmith fixed this in r291064. https://reviews.llvm.org/D26893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28253: static_assert inside make_shared when the object is not constructible

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM minus the `config.py` changes, but those were discussed offline. Also I prefer to write new `.fail.cpp` tests using clang verify. It allows fail tests to contain more than one test case,

[PATCH] D28229: [libcxx] Fix testing of the externally-threaded library build after r290850

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Accepting and Closing. This was committed in r290878. https://reviews.llvm.org/D28229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

echristo added a comment. In https://reviews.llvm.org/D27872#628212, @timshen wrote: > I changed type style to early return. > > For constructors and destructors, I use: > > if (...) { > // statement; > return; > } > > > For normal functions that returns void, I chose: > > if

[libcxx] r291031 - Fix verify test on 32 bit systems

Author: ericwf Date: Wed Jan 4 17:30:06 2017 New Revision: 291031 URL: http://llvm.org/viewvc/llvm-project?rev=291031=rev Log: Fix verify test on 32 bit systems Modified: libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.helper/tuple_size_incomplete.fail.cpp Modified:

[PATCH] D28174: [libcxx] [NFC] Rename _LIBCPP_TYPE_VIS_ONLY to _LIBCPP_TEMPLATE_VIS.

EricWF accepted this revision. EricWF added a reviewer: EricWF. EricWF added a comment. This revision is now accepted and ready to land. Accepting since there were no objections. https://reviews.llvm.org/D28174 ___ cfe-commits mailing list

[PATCH] D28174: [libcxx] [NFC] Rename _LIBCPP_TYPE_VIS_ONLY to _LIBCPP_TEMPLATE_VIS.

EricWF closed this revision. EricWF added a comment. Committed in r291035. https://reviews.llvm.org/D28174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r291045 - [MS] Instantiate default args during instantiation of exported default ctors

Author: rnk Date: Wed Jan 4 19:08:22 2017 New Revision: 291045 URL: http://llvm.org/viewvc/llvm-project?rev=291045=rev Log: [MS] Instantiate default args during instantiation of exported default ctors Summary: Replace some old code that probably pre-dated the change to delay emission of

r291058 - [Sema] Mark undefined ctors as deleted. NFC.

Author: gbiv Date: Wed Jan 4 19:21:21 2017 New Revision: 291058 URL: http://llvm.org/viewvc/llvm-project?rev=291058=rev Log: [Sema] Mark undefined ctors as deleted. NFC. Looks like these functions exist just to prevent bad implicit conversions. Rather than waiting for the linker to complain

r291034 - Only instantiate members of nested classes in local classes once, rather than once per enclosing class.

Author: rsmith Date: Wed Jan 4 17:45:01 2017 New Revision: 291034 URL: http://llvm.org/viewvc/llvm-project?rev=291034=rev Log: Only instantiate members of nested classes in local classes once, rather than once per enclosing class. Modified:

[PATCH] D28334: [clang-tidy] Add -extra-arg and -extra-arg-before to run-clang-tidy.py

ehsan created this revision. ehsan added reviewers: bkramer, alexfh, klimek. ehsan added a subscriber: cfe-commits. Herald added a subscriber: JDevlieghere. These flags allow specifying extra arguments to the tool's command line which don't appear in the compilation database.

Вuildbot numbers for the week of 12/25/2016 - 12/31/2016

Hello everyone, Below are some buildbot numbers for the last week of 12/25/2016 - 12/31/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status

Buildbot numbers for the week of 12/18/2016 - 12/24/2016

Hello everyone, Below are some buildbot numbers for the last week of 12/18/2016 - 12/24/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status

[PATCH] D28330: [analyzer] Fix false positives in Keychain API checker

alexshap added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp:527 + if (ReturnSymbol) +for (AllocatedDataTy::iterator I = ASet.begin(), E = ASet.end(); + I != E; ++I) { nit: auto I =

[PATCH] D28299: Module: use PCMCache to manage memory buffers for pcm files.

benlangmuir added a comment. Can we test the already-validated diagnostics? Comment at: include/clang/Basic/FileManager.h:176 + /// Manage memory buffers associated with pcm files. + std::unique_ptr BufferMgr; + Why is this inside the FileManager? It isn't

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

This revision was automatically updated to reflect the committed changes. Closed by commit rL291041: Correct Vectorcall Register passing and HVA Behavior (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D27529?vs=83116=83164#toc Repository: rL LLVM

r291041 - Correct Vectorcall Register passing and HVA Behavior

Author: erichkeane Date: Wed Jan 4 18:20:51 2017 New Revision: 291041 URL: http://llvm.org/viewvc/llvm-project?rev=291041=rev Log: Correct Vectorcall Register passing and HVA Behavior Front end component (back end changes are D27392). The vectorcall calling convention was broken subtly in two

[PATCH] D27429: [Chrono][Darwin] On Darwin use CLOCK_UPTIME_RAW instead of CLOCK_MONOTONIC

bruno updated this revision to Diff 83158. bruno added a comment. Thanks for the reviews. @howard.hinnant thanks for the great explanation & examples. Attached a new version of the patch, addressing all suggestions. The logic became a bit simpler after Saleem's r290804, which already moved the

[PATCH] D28220: provide Win32 native threading

compnerd updated the summary for this revision. compnerd updated this revision to Diff 83174. Repository: rL LLVM https://reviews.llvm.org/D28220 Files: include/__config include/__threading_support Index: include/__threading_support

r291074 - Factor out more common logic in template argument deduction from function call arguments.

Author: rsmith Date: Wed Jan 4 22:08:31 2017 New Revision: 291074 URL: http://llvm.org/viewvc/llvm-project?rev=291074=rev Log: Factor out more common logic in template argument deduction from function call arguments. No functionality change intended. Modified:

r291083 - [AVR] Support r26 through r31 in inline assembly

Author: dylanmckay Date: Wed Jan 4 23:31:12 2017 New Revision: 291083 URL: http://llvm.org/viewvc/llvm-project?rev=291083=rev Log: [AVR] Support r26 through r31 in inline assembly These are synonyms for the X,Y, and Z registers. Modified: cfe/trunk/lib/Basic/Targets.cpp Modified:

[PATCH] D28220: provide Win32 native threading

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. This LGTM. I'm sure we can flush out any bugs once we get the tests running. Repository: rL LLVM https://reviews.llvm.org/D28220 ___

[PATCH] D28220: provide Win32 native threading

halyavin added inline comments. Comment at: include/__threading_support:474 + system_clock::time_point(duration_cast(duration)); + auto timeout_ms = duration_cast(abstime - system_clock::now()); + Since negative timeouts can't be avoided, we must make

r291090 - [AVR] Revert the functional part of r291083

Author: dylanmckay Date: Thu Jan 5 01:17:46 2017 New Revision: 291090 URL: http://llvm.org/viewvc/llvm-project?rev=291090=rev Log: [AVR] Revert the functional part of r291083 As Senthil points out, this is unnecessary as we already have these registers in AddlRegNames. Modified:

[PATCH] D28220: provide Win32 native threading

compnerd marked 6 inline comments as done. compnerd added inline comments. Comment at: include/__threading_support:527 +static inline _LIBCPP_ALWAYS_INLINE unsigned int WINAPI +__libcpp_thread_trampoline(void *__data) +{ rnk wrote: > halyavin wrote: > >

[PATCH] D28220: provide Win32 native threading

compnerd updated this revision to Diff 83178. compnerd added a comment. Address a number of review comments. Repository: rL LLVM https://reviews.llvm.org/D28220 Files: include/__config include/__threading_support Index: include/__threading_support

[PATCH] D28344: [AVR] Add support for the full set of inline asm constraints

dylanmckay created this revision. dylanmckay added a reviewer: jroelofs. dylanmckay added subscribers: cfe-commits, saaadhu. Previously the method would simply return false, causing every single inline assembly constraint to trigger a compile error. This adds inline assembly constraint support

[libcxx] r291087 - [libcxx] Fix PR31402: map::__find_equal_key has undefined behavior.

Author: ericwf Date: Thu Jan 5 00:06:18 2017 New Revision: 291087 URL: http://llvm.org/viewvc/llvm-project?rev=291087=rev Log: [libcxx] Fix PR31402: map::__find_equal_key has undefined behavior. Summary: This patch fixes llvm.org/PR31402 by replacing `map::__find_equal_key` with

[PATCH] D28131: [libcxx] Fix PR31402: map::__find_equal_key has undefined behavior.

EricWF accepted this revision. EricWF added a reviewer: EricWF. EricWF added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D28131#632516, @vsk wrote: > LGTM. I'm not sure what to do for a test. Have you tried checking the IR for > the affected object

[PATCH] D28220: provide Win32 native threading

compnerd updated this revision to Diff 83182. compnerd marked an inline comment as done. compnerd added a comment. Fix `__libcpp_condvar_timedwait` parameter usage (absolute vs relative time) Repository: rL LLVM https://reviews.llvm.org/D28220 Files: include/__config

[PATCH] D28220: provide Win32 native threading

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: include/__threading_support:458 + __libcpp_mutex_reference&& __m, + timespec* __ts) +{ halyavin wrote: > In posix,

r291075 - Per [temp.deduct.call], do not deduce an array bound of 0 from an empty initializer list.

Author: rsmith Date: Wed Jan 4 22:16:30 2017 New Revision: 291075 URL: http://llvm.org/viewvc/llvm-project?rev=291075=rev Log: Per [temp.deduct.call], do not deduce an array bound of 0 from an empty initializer list. Modified: cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp

[PATCH] D27123: Add AVR target and toolchain to Clang

dylanmckay added a comment. Signed off by Jonathan Roelofs via cfe-commits https://reviews.llvm.org/D27123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28343: [AVR] Fix register numbers for in getGCCAddlRegNames()

dylanmckay created this revision. dylanmckay added a reviewer: saaadhu. dylanmckay added a subscriber: cfe-commits. These do not match up with the register numbers defined in LLVM's AVRRegisterInfo.td Adding Senthil as a reviewer as he originally implemented this.

[PATCH] D12644: Using -isysroot on Apple platform

EricWF resigned from this revision. EricWF removed a reviewer: EricWF. EricWF added a comment. I'm resigning as a reviewer. I suggested an alternative fix and explained why this fix wasn't correct in a comment above. Please re-add me as a reviewer if you disagree with my analysis.

[PATCH] D28343: [AVR] Fix register numbers for in getGCCAddlRegNames()

saaadhu added a comment. If you've added X, Y, Z and SP to GCCRegNames, you don't need AddlRegNames array at all, The reason I had them in AddlRegNames was to tell Clang that they alias regs in GCCRegNames. I followed X86TargetInfo's example - it has "ax" in GCCRegNames, and "al", "ah",

[PATCH] D27424: Add the diagnose_if attribute to clang.

george.burgess.iv added a comment. Do we have a page that details when we should/shouldn't use `auto`? I was under the impression that it was preferred only in cases where the type's spelled out (e.g. `cast`, ...). (To be clear, I'm happy to use it in loops, too; I'd just like to know if we

r291082 - Add AVR target and toolchain to Clang

Author: dylanmckay Date: Wed Jan 4 23:20:27 2017 New Revision: 291082 URL: http://llvm.org/viewvc/llvm-project?rev=291082=rev Log: Add AVR target and toolchain to Clang Summary: Authored by Senthil Kumar Selvaraj This patch adds barebones support in Clang for the (experimental) AVR target. It

[libcxx] r291081 - Fix test suite configuration when no lit.site.cfg is available

Author: ericwf Date: Wed Jan 4 23:18:37 2017 New Revision: 291081 URL: http://llvm.org/viewvc/llvm-project?rev=291081=rev Log: Fix test suite configuration when no lit.site.cfg is available Modified: libcxx/trunk/test/libcxx/test/config.py Modified: libcxx/trunk/test/libcxx/test/config.py

[PATCH] D20660: Remove `auto_ptr` in C++17.

EricWF added inline comments. Comment at: include/memory:1962 +#if _LIBCPP_STD_VER <= 14 || defined(_LIBCPP_NO_REMOVE_AUTOPTR) template I would love to have a semi-consistent naming scheme for macros which re-enable removed C++17 features. Maybe

[PATCH] D28298: [OpenMP] Add fields for flags in the offload entry descriptor.

Hahnfeld added a subscriber: cfe-commits. Hahnfeld added a comment. Otherwise SGTM Comment at: lib/CodeGen/CGOpenMPRuntime.h:250-252 + // \brief Flags associated the device global. + int32_t Flags; + Is that intentionally not in the `protected`

  1   2   3   >