EricWF added a comment.
Yeah, I think I agree with @majnemer that I would rather use an expanded
interface than this type-erased mutex type. Thank you for working on this.
Repository:
rL LLVM
https://reviews.llvm.org/D28226
___
cfe-commits maili
EricWF resigned from this revision.
EricWF removed a reviewer: EricWF.
EricWF added a comment.
Looks like @mclow.lists just committed another version of this paper, so this
patch is no longer needed.
Resigning as reviewer.
https://reviews.llvm.org/D22584
Prazek created this revision.
Prazek added a reviewer: rjmccall.
Prazek added a subscriber: cfe-commits.
Small refactor
https://reviews.llvm.org/D28310
Files:
include/clang/AST/VTableBuilder.h
lib/CodeGen/ItaniumCXXABI.cpp
Index: lib/CodeGen/ItaniumCXXABI.cpp
=
aprantl added inline comments.
Comment at: include/clang/Basic/DiagnosticSerializationKinds.td:131
+ "diagnostic options now it is a non-system module">,
+ InGroup;
+
Is this better?
"module file '%0' was validated as a system module and is now being imported
erichkeane updated this revision to Diff 83116.
erichkeane added a comment.
Refactor per @rnk s suggestion.
https://reviews.llvm.org/D27529
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGen/vectorcall.c
test/CodeGenCXX/homogeneous-aggregates.cpp
Index: lib/CodeGen/TargetInfo.cpp
===
cryptoad added a comment.
Understood.
I'll let someone else chime on on the TSAN aspect of the patch.
https://reviews.llvm.org/D28304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman updated this revision to Diff 83118.
aaron.ballman added a comment.
Added support for `AdjustedType` and `AdjustedTypeLoc`.
https://reviews.llvm.org/D28166
Files:
include/clang/AST/Type.h
include/clang/AST/TypeLoc.h
lib/Sema/SemaDecl.cpp
test/Sema/knr-def-call.c
test/Sem
amaiorano created this revision.
amaiorano added reviewers: ioeric, cfe-commits, klimek, djasper.
See https://reviews.llvm.org/D28081 for the changes to getStyle
This change will be committed right after https://reviews.llvm.org/D28081.
https://reviews.llvm.org/D28315
Files:
change-namespace
amaiorano added a comment.
I made these changes, and they build, but I didn't really test them. Are there
unit tests for these tools that I can run?
https://reviews.llvm.org/D28315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
amaiorano added a comment.
@ioeric I think you removed cfe-commits as a reviewer, then added it back, but
it didn't work. Should I re-add?
https://reviews.llvm.org/D28081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
EricWF created this revision.
EricWF added reviewers: compnerd, rmaprath.
EricWF added a subscriber: cfe-commits.
Herald added a subscriber: mgorny.
This patch attempts to clean up the macro configuration mess in
`<__threading_support>`, specifically the mess involving external threading
variant
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added subscribers: echristo, cfe-commits.
These duplicate declarations cause a problem for CUDA compiles on
Windows. All implicitly-defined functions are host+device, and this
applies to the declarations in Builtin.def. But then
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added subscribers: tra, cfe-commits.
When Sema looks up an attribute name, it strips off leading and trailing
"__" if the attribute is GNU-style. That is, __attribute__((foo)) and
__attribute__((__foo__)) are equivalent.
This is
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
Previously it was taking the true target triple, which is not really
what it needs: The location of the CUDA installation depends on the host
OS.
https://reviews.llvm.org/D28319
Files:
clang/li
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
For the most part this is straightforward: Just add a CudaInstallation
object to the MSVC and MinGW toolchains.
CudaToolChain has to override computeMSVCVersion so that
Clang::constructJob passes t
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: rnk, cfe-commits.
CUDA attributes are spelled __declspec(__foo__) on Windows.
https://reviews.llvm.org/D28321
Files:
clang/include/clang/Basic/Attr.td
clang/test/SemaCUDA/attr-declspec.cu
Index: clang/tes
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
CUDA lets users share structs between the host and device, so for that
and other reasons, primitive types such as ptrdiff_t should be the same
on both sides of the compilation.
Our code to do this
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
When compiling device code, we may still see host code with explicit
calling conventions. NVPTX needs to claim that it supports these CCs,
so that (a) we don't raise noisy warnings, and (b) we don'
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
https://reviews.llvm.org/D28324
Files:
clang/lib/Headers/__clang_cuda_cmath.h
Index: clang/lib/Headers/__clang_cuda_cmath.h
===
-
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
MSVC seems to use "__in" and "__out" for its own purposes, so we have to
pick different names in this macro.
https://reviews.llvm.org/D28325
Files:
clang/lib/Headers/__clang_cuda_intrinsics.h
jlebar created this revision.
jlebar added subscribers: llvm-commits, cfe-commits.
https://reviews.llvm.org/D28326
Files:
llvm/docs/CompileCudaWithLLVM.rst
Index: llvm/docs/CompileCudaWithLLVM.rst
===
--- llvm/docs/CompileCudaWit
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:604
+// CUDA attributes are spelled __attribute__((attr)) or __declspec(__attr__).
+
For my own edification, do you have a link to
jlebar added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:604
+// CUDA attributes are spelled __attribute__((attr)) or __declspec(__attr__).
+
aaron.ballman wrote:
> For my own edification, do you have a link to some documentation of what CUDA
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
This seems much better organized I think, and easier to follow. Thanks for the
docs on the various options!
https://reviews.llvm.org/D28316
___
Author: rsmith
Date: Wed Jan 4 16:03:59 2017
New Revision: 291014
URL: http://llvm.org/viewvc/llvm-project?rev=291014&view=rev
Log:
Fix failure to treat overloaded function in braced-init-list as a non-deduced
context.
Previously, if an overloaded function in a braced-init-list was encountered
malcolm.parsons added subscribers: cfe-commits, malcolm.parsons.
malcolm.parsons added a comment.
A mailing list cannot review.
https://reviews.llvm.org/D28315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:604
+// CUDA attributes are spelled __attribute__((attr)) or __declspec(__attr__).
+
jlebar wrote:
> aaron.ballman wrote:
> > For my own edification, do you have a link to some d
jlebar added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:604
+// CUDA attributes are spelled __attribute__((attr)) or __declspec(__attr__).
+
aaron.ballman wrote:
> jlebar wrote:
> > aaron.ballman wrote:
> > > For my own edification, do you h
rsmith added inline comments.
Comment at: lib/Basic/Diagnostic.cpp:179
+
+ // 2nd most frequent case: L is before the first diag state change.
+ FullSourceLoc FirstStateChangePos = DiagStatePoints[1].Loc;
djasper wrote:
> rsmith wrote:
> > It's surprising to me
timshen updated this revision to Diff 83140.
timshen added a comment.
Update comments, and move llvm changes to another patch.
https://reviews.llvm.org/D28037
Files:
clang/lib/Headers/altivec.h
clang/test/CodeGen/builtins-ppc-altivec.c
Index: clang/test/CodeGen/builtins-ppc-altivec.c
=
echristo added a comment.
LGTM.
Thanks!
-eric
https://reviews.llvm.org/D28037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:604
+// CUDA attributes are spelled __attribute__((attr)) or __declspec(__attr__).
+
jlebar wrote:
> aaron.ballman wrote:
> > jlebar wrote:
> > > aaron.ballman wrote:
> > > > For
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM minus the `config.py` changes, but those were discussed offline.
Also I prefer to write new `.fail.cpp` tests using clang verify. It allows fail
tests to contain more than one test case,
Author: dblaikie
Date: Wed Jan 4 16:36:39 2017
New Revision: 291017
URL: http://llvm.org/viewvc/llvm-project?rev=291017&view=rev
Log:
Remove use of intrusive ref count ownership acquisition
The one use of CheckerManager (AnalysisConsumer, calling
createCheckerManager) keeps a strong reference to
Author: dblaikie
Date: Wed Jan 4 16:36:43 2017
New Revision: 291018
URL: http://llvm.org/viewvc/llvm-project?rev=291018&view=rev
Log:
Fix for LLVM Bitcode API change (to use std::shared_ptr)
Modified:
cfe/trunk/lib/Frontend/SerializedDiagnosticPrinter.cpp
cfe/trunk/lib/Frontend/TestModul
EricWF updated this revision to Diff 83145.
EricWF added a comment.
Updating with final changes.
https://reviews.llvm.org/D28222
Files:
include/__tuple
test/libcxx/test/config.py
test/std/utilities/tuple/tuple.tuple/tuple.helper/tuple_size.pass.cpp
test/std/utilities/tuple/tuple.tuple/
Author: ericwf
Date: Wed Jan 4 16:38:46 2017
New Revision: 291019
URL: http://llvm.org/viewvc/llvm-project?rev=291019&view=rev
Log:
[libcxx] Re-implement LWG 2770 again: Fix tuple_size to work with structured
bindings
Summary:
This patch attempts to re-implement a fix for LWG 2770, but not the
djasper added inline comments.
Comment at: lib/Basic/Diagnostic.cpp:179
+
+ // 2nd most frequent case: L is before the first diag state change.
+ FullSourceLoc FirstStateChangePos = DiagStatePoints[1].Loc;
rsmith wrote:
> djasper wrote:
> > rsmith wrote:
> > >
Author: gbiv
Date: Wed Jan 4 16:43:01 2017
New Revision: 291020
URL: http://llvm.org/viewvc/llvm-project?rev=291020&view=rev
Log:
[Parse] Don't ignore attributes after a late-parsed attr.
Without this, we drop everything after the first late-parsed attribute
in a single __attribute__. (Where "dr
Author: ericwf
Date: Wed Jan 4 16:43:08 2017
New Revision: 291021
URL: http://llvm.org/viewvc/llvm-project?rev=291021&view=rev
Log:
Use C++11 static_assert in variant tests. Patch from Michael Park
Modified:
libcxx/trunk/test/libcxx/utilities/variant/variant.variant/variant.ctor/copy.pass.c
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Accepting and Closing. This was committed in r290878.
https://reviews.llvm.org/D28229
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
zaks.anna created this revision.
zaks.anna added a reviewer: dcoughlin.
zaks.anna added subscribers: cfe-commits, dergachev.a.
The checker has several false positives that this patch addresses:
1. Do not check if the return status has been compared to error (or no error)
at the time when leaks
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
After getting some realtime clarifications in IRC, I now understand better why
this is needed. This patch LGTM! The documentation points I raised are still
valid, but are by no m
jlebar added a comment.
Thank you for the review!
Comment at: clang/include/clang/Basic/Attr.td:604
+// CUDA attributes are spelled __attribute__((attr)) or __declspec(__attr__).
+
aaron.ballman wrote:
> jlebar wrote:
> > aaron.ballman wrote:
> > > jlebar wro
Author: marshall
Date: Wed Jan 4 17:03:24 2017
New Revision: 291028
URL: http://llvm.org/viewvc/llvm-project?rev=291028&view=rev
Log:
Implement P0505: 'Wording for GB 50'
Modified:
libcxx/trunk/include/chrono
libcxx/trunk/test/std/utilities/time/time.duration/time.duration.arithmetic/op
echristo added a comment.
In https://reviews.llvm.org/D27872#628212, @timshen wrote:
> I changed type style to early return.
>
> For constructors and destructors, I use:
>
> if (...) {
> // statement;
> return;
> }
>
>
> For normal functions that returns void, I chose:
>
> if (..
timshen added a comment.
In https://reviews.llvm.org/D27872#636130, @echristo wrote:
> Looks pretty weird. Typically I'd suggest just:
>
> if (foo) {
>
> Foo();
> return;
>
> }
>
> since that will keep cognitive overhead to a minimum.
>
> -eric
>
> > Other functions are not controversial.
I
Author: rsmith
Date: Wed Jan 4 17:14:16 2017
New Revision: 291030
URL: http://llvm.org/viewvc/llvm-project?rev=291030&view=rev
Log:
Bail out if we try to build a DeclRefExpr naming an invalid declaration.
Most code paths would already bail out in this case, but certain paths,
particularly overlo
echristo added a comment.
In https://reviews.llvm.org/D27872#636147, @timshen wrote:
> In https://reviews.llvm.org/D27872#636130, @echristo wrote:
>
> > Looks pretty weird. Typically I'd suggest just:
> >
> > if (foo) {
> >
> > Foo();
> > return;
> >
> > }
> >
> > since that will keep cogniti
Author: ericwf
Date: Wed Jan 4 17:30:06 2017
New Revision: 291031
URL: http://llvm.org/viewvc/llvm-project?rev=291031&view=rev
Log:
Fix verify test on 32 bit systems
Modified:
libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.helper/tuple_size_incomplete.fail.cpp
Modified:
libcxx/tr
Author: ericwf
Date: Wed Jan 4 17:35:51 2017
New Revision: 291032
URL: http://llvm.org/viewvc/llvm-project?rev=291032&view=rev
Log:
Fix private inheritance in C++03 tuple_size
Modified:
libcxx/trunk/include/__tuple
Modified: libcxx/trunk/include/__tuple
URL:
http://llvm.org/viewvc/llvm-pro
Author: rsmith
Date: Wed Jan 4 17:45:01 2017
New Revision: 291034
URL: http://llvm.org/viewvc/llvm-project?rev=291034&view=rev
Log:
Only instantiate members of nested classes in local classes once, rather than
once per enclosing class.
Modified:
cfe/trunk/lib/Sema/SemaTemplateInstantiateDec
benlangmuir added a comment.
Can we test the already-validated diagnostics?
Comment at: include/clang/Basic/FileManager.h:176
+ /// Manage memory buffers associated with pcm files.
+ std::unique_ptr BufferMgr;
+
Why is this inside the FileManager? It isn't us
alexshap added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp:527
+ if (ReturnSymbol)
+for (AllocatedDataTy::iterator I = ASet.begin(), E = ASet.end();
+ I != E; ++I) {
nit: auto I = ...
alexshap added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp:527
+ if (ReturnSymbol)
+for (AllocatedDataTy::iterator I = ASet.begin(), E = ASet.end();
+ I != E; ++I) {
alexshap wrote:
>
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
Accepting since there were no objections.
https://reviews.llvm.org/D28174
___
cfe-commits mailing list
cfe-commi
EricWF closed this revision.
EricWF added a comment.
Committed in r291035.
https://reviews.llvm.org/D28174
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Looks good to me, aside from minor quibbles about capitalization and variable
naming.
Comment at: lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp:502
+
Author: chandlerc
Date: Wed Jan 4 17:57:25 2017
New Revision: 291036
URL: http://llvm.org/viewvc/llvm-project?rev=291036&view=rev
Log:
[gtest] The way EXPECT_TEST now works after upgrading gtest triggers an
ODR use. These traits don't have a definition as they're intended to be
used strictly at c
Author: ericwf
Date: Wed Jan 4 18:04:37 2017
New Revision: 291039
URL: http://llvm.org/viewvc/llvm-project?rev=291039&view=rev
Log:
Fix Sphinx build error caused by bad indentation
Modified:
libcxx/trunk/docs/DesignDocs/VisibilityMacros.rst
Modified: libcxx/trunk/docs/DesignDocs/VisibilityM
zaks.anna updated this revision to Diff 83160.
zaks.anna added a comment.
Addressed all comments
https://reviews.llvm.org/D28330
Files:
lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp
test/Analysis/keychainAPI.m
Index: test/Analysis/keychainAPI.m
===
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D28318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D28317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
https://reviews.llvm.org/D27529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
bruno updated this revision to Diff 83158.
bruno added a comment.
Thanks for the reviews. @howard.hinnant thanks for the great explanation &
examples.
Attached a new version of the patch, addressing all suggestions. The logic
became a bit simpler after Saleem's r290804, which already moved the
Author: erichkeane
Date: Wed Jan 4 18:20:51 2017
New Revision: 291041
URL: http://llvm.org/viewvc/llvm-project?rev=291041&view=rev
Log:
Correct Vectorcall Register passing and HVA Behavior
Front end component (back end changes are D27392). The vectorcall
calling convention was broken subtly in
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291041: Correct Vectorcall Register passing and HVA Behavior
(authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D27529?vs=83116&id=83164#toc
Repository:
rL LLVM
https://revi
ehsan created this revision.
ehsan added reviewers: bkramer, alexfh, klimek.
ehsan added a subscriber: cfe-commits.
Herald added a subscriber: JDevlieghere.
These flags allow specifying extra arguments to the tool's command
line which don't appear in the compilation database.
https://reviews.llv
timshen added a comment.
In https://reviews.llvm.org/D27872#636149, @echristo wrote:
> I'm pretty sure I've never seen return widely used in
> the code base versus my suggestion. That said, if you've looked and it's
> roughly 50/50 then I care a lot less (and we can bike shed in some separate
tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Driver/ToolChains.cpp:1819
Args.getLastArgValue(options::OPT_cuda_path_EQ));
- else {
+ else if (HostTriple.isOSLinux() || HostTriple.isMacOSX(
howard.hinnant added inline comments.
Comment at: src/chrono.cpp:218
+#error "Never use CLOCK_MONOTONIC for steady_clock::now on Apple platforms"
+#endif
+
Nice, thanks!
https://reviews.llvm.org/D27429
___
cfe-comm
tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Headers/__clang_cuda_cmath.h:76
+
+// For inscrutible reasons, the CUDA headers define these functions for us on
+// Windows.
inscrut__a_
Hello everyone,
Below are some buildbot numbers for the last week of 12/18/2016 -
12/24/2016.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status fro
Hello everyone,
Below are some buildbot numbers for the last week of 12/25/2016 -
12/31/2016.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status fro
Author: rnk
Date: Wed Jan 4 19:08:22 2017
New Revision: 291045
URL: http://llvm.org/viewvc/llvm-project?rev=291045&view=rev
Log:
[MS] Instantiate default args during instantiation of exported default ctors
Summary:
Replace some old code that probably pre-dated the change to delay
emission of dll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291045: [MS] Instantiate default args during instantiation
of exported default ctors (authored by rnk).
Changed prior to commit:
https://reviews.llvm.org/D28274?vs=83059&id=83170#toc
Repository:
rL L
jlebar marked an inline comment as done.
jlebar added a comment.
Thank you for the reviews!
Comment at: clang/lib/Driver/ToolChains.cpp:1819
Args.getLastArgValue(options::OPT_cuda_path_EQ));
- else {
+ else if (HostTriple.isOSLinux() || HostTriple.isMacOSX()) {
Author: ericwf
Date: Wed Jan 4 19:15:42 2017
New Revision: 291046
URL: http://llvm.org/viewvc/llvm-project?rev=291046&view=rev
Log:
Fix std::pointer_safety type in ABI v2
In the C++ standard `std::pointer_safety` is defined
as a C++11 strongly typed enum. However libc++ currently defines
it as a
jlebar marked an inline comment as done.
jlebar added inline comments.
Comment at: clang/lib/Headers/__clang_cuda_cmath.h:76
+
+// For inscrutible reasons, the CUDA headers define these functions for us on
+// Windows.
tra wrote:
> inscrut__a__ble?
Thanks. :)
Author: gbiv
Date: Wed Jan 4 19:21:21 2017
New Revision: 291058
URL: http://llvm.org/viewvc/llvm-project?rev=291058&view=rev
Log:
[Sema] Mark undefined ctors as deleted. NFC.
Looks like these functions exist just to prevent bad implicit
conversions. Rather than waiting for the linker to complain
Author: ericwf
Date: Wed Jan 4 19:28:40 2017
New Revision: 291059
URL: http://llvm.org/viewvc/llvm-project?rev=291059&view=rev
Log:
Fix PR26961 - Add default constructor to std::pointer_safety struct.
In ABI v1 libc++ implements std::pointer_safety as a class type instead
of an enumeration. Howe
Author: ericwf
Date: Wed Jan 4 19:34:14 2017
New Revision: 291060
URL: http://llvm.org/viewvc/llvm-project?rev=291060&view=rev
Log:
Fix XPASS buildbot failure related to structured bindings
The test was previously set to XFAIL if __cpp_structured_bindings
wasn't defined. However there are Clang
Author: rsmith
Date: Wed Jan 4 20:31:32 2017
New Revision: 291064
URL: http://llvm.org/viewvc/llvm-project?rev=291064&view=rev
Log:
Fix assertion failure on deduction failure due to too short template argument
list.
We were previously incorrectly using TDK_TooFewArguments to report a template
a
erik.pilkington abandoned this revision.
erik.pilkington added a comment.
@rsmith fixed this in r291064.
https://reviews.llvm.org/D26893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
Author: rsmith
Date: Wed Jan 4 20:55:10 2017
New Revision: 291065
URL: http://llvm.org/viewvc/llvm-project?rev=291065&view=rev
Log:
PR31540: install libc++abi headers into include/c++/v1 in build area.
This allows an in-build-area clang binary to find .
Modified:
libcxx/trunk/cmake/Modules/
rjmccall added a comment.
This is a potentially significant pessimization. Can you turn this into a
range iterator of some sort?
https://reviews.llvm.org/D28310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
rsmith added a comment.
Sorry I missed this =( Thanks for the fix!
https://reviews.llvm.org/D26893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
compnerd abandoned this revision.
compnerd added a comment.
Superceded by https://reviews.llvm.org/D28338
Repository:
rL LLVM
https://reviews.llvm.org/D28226
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
smeenai added a comment.
Adding cfe-commits as a subscriber after diff creation won't send the email out
AFAIK. You'll have to re-upload the patch.
Repository:
rL LLVM
https://reviews.llvm.org/D28338
___
cfe-commits mailing list
cfe-commits@list
ahatanak added a comment.
I found another problem with the current patch: it can generate IR that doesn't
pass asan's use-after-scope check. For example, IRGen generates the following
IR for function move_lifetime_start in lifetime2.c when this patch is applied:
entry:
%i = alloca i32, al
compnerd updated the summary for this revision.
compnerd updated this revision to Diff 83174.
Repository:
rL LLVM
https://reviews.llvm.org/D28220
Files:
include/__config
include/__threading_support
Index: include/__threading_support
compnerd marked 6 inline comments as done.
compnerd added inline comments.
Comment at: include/__threading_support:527
+static inline _LIBCPP_ALWAYS_INLINE unsigned int WINAPI
+__libcpp_thread_trampoline(void *__data)
+{
rnk wrote:
> halyavin wrote:
> > Trampolin
compnerd updated this revision to Diff 83178.
compnerd added a comment.
Address a number of review comments.
Repository:
rL LLVM
https://reviews.llvm.org/D28220
Files:
include/__config
include/__threading_support
Index: include/__threading_support
===
compnerd marked an inline comment as done.
compnerd added inline comments.
Comment at: include/__threading_support:458
+ __libcpp_mutex_reference&& __m,
+ timespec* __ts)
+{
halyavin wrote:
> In posix, p
compnerd updated this revision to Diff 83182.
compnerd marked an inline comment as done.
compnerd added a comment.
Fix `__libcpp_condvar_timedwait` parameter usage (absolute vs relative time)
Repository:
rL LLVM
https://reviews.llvm.org/D28220
Files:
include/__config
include/__threading_
Author: ericwf
Date: Wed Jan 4 21:57:40 2017
New Revision: 291072
URL: http://llvm.org/viewvc/llvm-project?rev=291072&view=rev
Log:
Get test-suite configuring on Windows with clang-cl
This patch gets the test suite "working" on Windows, although
none of the tests pass.
In order to reuse the exi
Author: rsmith
Date: Wed Jan 4 22:08:31 2017
New Revision: 291074
URL: http://llvm.org/viewvc/llvm-project?rev=291074&view=rev
Log:
Factor out more common logic in template argument deduction from function call
arguments.
No functionality change intended.
Modified:
cfe/trunk/lib/Sema/SemaT
george.burgess.iv updated this revision to Diff 83188.
george.burgess.iv marked 18 inline comments as done.
george.burgess.iv added a comment.
Addressed all feedback + made `diagnose_if` late-parsed.
https://reviews.llvm.org/D27424
Files:
include/clang/AST/Expr.h
include/clang/Basic/Attr.td
george.burgess.iv added a comment.
Do we have a page that details when we should/shouldn't use `auto`? I was under
the impression that it was preferred only in cases where the type's spelled out
(e.g. `cast`, ...). (To be clear, I'm happy to use it in loops, too; I'd
just like to know if we hav
Author: rsmith
Date: Wed Jan 4 22:16:30 2017
New Revision: 291075
URL: http://llvm.org/viewvc/llvm-project?rev=291075&view=rev
Log:
Per [temp.deduct.call], do not deduce an array bound of 0 from an empty
initializer list.
Modified:
cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp
cfe/trunk/
101 - 200 of 218 matches
Mail list logo
