r291565 - [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device

Author: arpith Date: Tue Jan 10 09:42:51 2017 New Revision: 291565 URL: http://llvm.org/viewvc/llvm-project?rev=291565=rev Log: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device Summary: This patch introduces support for the execution of parallel constructs

[PATCH] D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291565: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX… (authored by arpith). Changed prior to commit: https://reviews.llvm.org/D28145?vs=83641=83808#toc Repository:

[PATCH] D20428: Tracking exception specification source locations

malcolm.parsons added inline comments. Comment at: include/clang/AST/TypeLoc.h:1355 + bool hasExceptionSpec() const { +if (auto FPT = dyn_cast(getTypePtr())) { + return FPT->hasExceptionSpec(); `auto *` Comment at:

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

aaron.ballman requested changes to this revision. aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:41 +void UseNoexceptCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus) +return;

[PATCH] D28400: [AArch64] Use generic bitreverse intrinsic, rather than AArch64 specific.

RKSimon added inline comments. Comment at: test/CodeGen/arm_acle.c:247 // ARM-LABEL: test_rbit // AArch32: call i32 @llvm.arm.rbit +// AArch64: call i32 @llvm.bitreverse.i32 Since you're here is it worth dealing with the AARCH32 case as well? We know it works

[PATCH] D28260: Add an argumentsAre matcher

aaron.ballman requested changes to this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision now requires changes to proceed. You should also regenerate the HTML matcher documentation as part of this patch. Comment at:

r291564 - [Sema] Avoid -Wshadow warning when a "redefinition of " error is presented

Author: arphaman Date: Tue Jan 10 08:41:13 2017 New Revision: 291564 URL: http://llvm.org/viewvc/llvm-project?rev=291564=rev Log: [Sema] Avoid -Wshadow warning when a "redefinition of " error is presented This commit ensures that clang avoids the redundant -Wshadow warning for variables that

[PATCH] D28260: Add an argumentsAre matcher

aaron.ballman added a comment. Given that this can't be expressed as a dynamic matcher, I'm wondering what the use case is for the matcher. Do you have a specific need for this functionality, or do you see this being generally useful? https://reviews.llvm.org/D28260

[PATCH] D28451: [AVR] Add support for the 'interrupt' and 'naked' attributes

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. The patch is also missing Sema tests that ensure the attributes are properly diagnosed when applied to something other than a function, a target other than AVR,

[PATCH] D20428: Tracking exception specification source locations

hintonda added a comment. Aaron, I've got this version in a branch, so if you like, I'd be happy to apply Malcolm's suggestions. https://reviews.llvm.org/D20428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28445: [Analyzer] Extend taint propagation and checking

vlad.tsyrklevich added inline comments. Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:443 + if (auto LCV = Val.getAs()) +return C.getSymbolManager().getRegionValueSymbol(LCV->getRegion()); + zaks.anna wrote: > This might create a new

[PATCH] D28400: [AArch64] Use generic bitreverse intrinsic, rather than AArch64 specific.

mcrosier added inline comments. Comment at: test/CodeGen/arm_acle.c:247 // ARM-LABEL: test_rbit // AArch32: call i32 @llvm.arm.rbit +// AArch64: call i32 @llvm.bitreverse.i32 RKSimon wrote: > Since you're here is it worth dealing with the AARCH32 case as well?

[PATCH] D20428: Tracking exception specification source locations

aaron.ballman added a comment. In https://reviews.llvm.org/D20428#641416, @hintonda wrote: > Aaron, I've got this version in a branch, so if you like, I'd be happy to > apply Malcolm's suggestions. Please do; they're good suggestions. https://reviews.llvm.org/D20428

[PATCH] D28400: [AArch64] Use generic bitreverse intrinsic, rather than AArch64 specific.

sbaranga accepted this revision. sbaranga added a reviewer: sbaranga. sbaranga added a comment. This revision is now accepted and ready to land. This looks straight-forward to me. LGTM. -Silviu https://reviews.llvm.org/D28400 ___ cfe-commits

[PATCH] D20428: Tracking exception specification source locations

hintonda updated this revision to Diff 83816. hintonda added a comment. - Address comments. https://reviews.llvm.org/D20428 Files: include/clang/AST/Decl.h include/clang/AST/TypeLoc.h lib/AST/Decl.cpp lib/Parse/ParseDeclCXX.cpp lib/Sema/SemaType.cpp lib/Sema/TreeTransform.h

[libcxx] r291572 - Fix up some mismatched SFINAE conditionsin shared_ptr; some used '_Tp*', others used 'element_type *'. Today, they're the same - but soon they won't be. No functional change.

Author: marshall Date: Tue Jan 10 10:59:33 2017 New Revision: 291572 URL: http://llvm.org/viewvc/llvm-project?rev=291572=rev Log: Fix up some mismatched SFINAE conditionsin shared_ptr; some used '_Tp*', others used 'element_type *'. Today, they're the same - but soon they won't be. No

[PATCH] D28445: [Analyzer] Extend taint propagation and checking

NoQ added a comment. Thanks for working on the taint! I really wish the taint analysis in the analyzer to flourish, and the part you've digged into is particularly sensitive, so i'd dump some thoughts here, hopefully helpful. **What works as it should: ** > In the second example, the SVal

[PATCH] D28526: [ARM] Add diagnostics when initialization global variables with ropi/rwpi

weimingz created this revision. weimingz added reviewers: olista01, jmolloy. weimingz added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. This patch adds diagnoses when initializing a global variable using the address of another global variable that uses ROPI/RWPI

[PATCH] D28001: [X86] Teach Clang about -mfentry flag

niravd added inline comments. Comment at: include/clang/Driver/Options.td:1731 def mno_pie_copy_relocations : Flag<["-"], "mno-pie-copy-relocations">, Group; +def mfentry : Flag<["-"], "mfentry">, HelpText<"insert calls to fentry at function entry">, Flags<[CC1Option]>,

[PATCH] D28001: [X86] Teach Clang about -mfentry flag

niravd updated this revision to Diff 83850. niravd marked 2 inline comments as done. niravd added a comment. Address comments https://reviews.llvm.org/D28001 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CodeGenFunction.cpp

[PATCH] D28526: [ARM] Add diagnostics when initialization global variables with ropi/rwpi

efriedma requested changes to this revision. efriedma added a reviewer: efriedma. efriedma added a comment. This revision now requires changes to proceed. We really should be checking this much earlier. IsGlobalLValue() in ExprConstant.cpp is the canonical place to answer the question "is the

Re: [clang-tools-extra] r291446 - [include-fixer] Load symbol index asynchronously.

Hello Benjamin, It looks like this commit added warnings to the builder: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/3596 C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\ppltasks.h(1531): warning C4530: C++ exception handler used, but

[PATCH] D28530: [Driver] Correct empty files in D28238

cryptoad abandoned this revision. cryptoad added a comment. Nevermind, it seems to be working with empty files! https://reviews.llvm.org/D28530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28238: [Driver] Add openSuse AArch64 Triple

cryptoad marked 4 inline comments as done. cryptoad added a comment. Thank you for the review Renato! https://reviews.llvm.org/D28238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r291600 - Serialize the UsesSEH bit on FunctionDecl

Author: rnk Date: Tue Jan 10 15:27:03 2017 New Revision: 291600 URL: http://llvm.org/viewvc/llvm-project?rev=291600=rev Log: Serialize the UsesSEH bit on FunctionDecl Fixes PR31539 Added: cfe/trunk/test/PCH/uses-seh.cpp Modified: cfe/trunk/lib/Serialization/ASTReaderDecl.cpp

Re: r290450 - [PM] Introduce options to enable the (still experimental) new pass

(explicitly adding Richard so he sees this discussion as some of this involves a discussion between myself and him) On Tue, Jan 10, 2017 at 4:36 PM Justin Bogner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Chandler Carruth via cfe-commits writes: > >

[PATCH] D28520: Disable -Wthread-safety-analysis for some functions in __thread_support

dim updated this revision to Diff 83851. dim added a comment. Let's try this simpler version instead. https://reviews.llvm.org/D28520 Files: include/__threading_support Index: include/__threading_support === ---

r291597 - Don't try to check implicit conversion sequences for an object argument if

Author: rsmith Date: Tue Jan 10 14:52:50 2017 New Revision: 291597 URL: http://llvm.org/viewvc/llvm-project?rev=291597=rev Log: Don't try to check implicit conversion sequences for an object argument if there is no object argument, when early checking of implicit conversion sequences for a

[PATCH] D28530: [Driver] Correct empty files in D28238

cryptoad created this revision. cryptoad added a reviewer: rengolin. cryptoad added a subscriber: cfe-commits. The binary files added as part of https://reviews.llvm.org/rL291598 seem to be empty. Those are the actual files that should have been uploaded by arc. https://reviews.llvm.org/D28530

[PATCH] D28526: [ARM] Add diagnostics when initialization global variables with ropi/rwpi

weimingz added a comment. Hi Eli, Thanks for the comments! I though of implementation in Sema and I actually experimented a little bit. Then it seemed that the CodeGenOpts is only available in the CGM. Any ideas? https://reviews.llvm.org/D28526

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

mehdi_amini added a comment. In https://reviews.llvm.org/D28404#641632, @probinson wrote: > In https://reviews.llvm.org/D28404#641606, @mehdi_amini wrote: > > > If we want to support `-O0 -flto` and `optnone` it the way to convey this > > to the optimizer, I don't see the alternative. > > >

[PATCH] D28260: Add an argumentsAre matcher

fowles added a subscriber: jdennett. fowles added a comment. @jdennett wanted this matcher for something he is working on and I had some free cycles to write it up. Unfortunately, I am about to leave on an extended vacation, so I will not be able to follow up with this patch for 2 months at

[PATCH] D24991: Inline hot functions in libcxx shared_ptr implementation.

hxy9243 marked an inline comment as done. hxy9243 added a comment. Addressed previous issues in the comments. The patch still shows consistent perf uplift in proprietary benchmark on shared_ptr. @EricWF @sebpop @hiraditya Any thoughts? Repository: rL LLVM https://reviews.llvm.org/D24991

Re: [clang-tools-extra] r291446 - [include-fixer] Load symbol index asynchronously.

I didn't manage to reproduce this. Does adding ${PTHREAD_LIB} to LINK_LIBS of tools/clang/tools/extra/include-fixer/plugin/CMakeLists.txt help? On Tue, Jan 10, 2017 at 8:31 PM, Bill Seurer wrote: > On 01/09/2017 09:18 AM, Benjamin Kramer via cfe-commits wrote: >> >>

[PATCH] D28520: Disable -Wthread-safety-analysis for some functions in __thread_support

dim updated this revision to Diff 83843. dim added a comment. - Move `_LIBCPP_THREAD_SAFETY_ANNOTATION` macro definition to `__config`. - Add `_LIBCPP_THREAD_SAFETY_ANNOTATION(no_thread_safety_analysis)` macros to `__threading_support` function declarations which require them. Note that I was

[PATCH] D28529: [test] Port clang tests to canonicalized booleans

mgorny created this revision. mgorny added a reviewer: beanz. mgorny added a subscriber: cfe-commits. Herald added a subscriber: klimek. Use the new llvm_canonicalize_cmake_booleans() function to canonicalize booleans for lit tests. Replace the duplicate ENABLE_CLANG* variables used to hold

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

yaxunl added inline comments. Comment at: docs/UsersManual.rst:2003 + $ clang -target nvptx64-unknown-unknown test.cl + $ clang -target amdgcn-unknown-amdhsa test.cl + $ clang -target amdgcn-amd-amdhsa-opencl test.cl Comment at:

r291596 - Fix conversion index / argument index mismatch when diagnosing overload resolution failure.

Author: rsmith Date: Tue Jan 10 14:19:21 2017 New Revision: 291596 URL: http://llvm.org/viewvc/llvm-project?rev=291596=rev Log: Fix conversion index / argument index mismatch when diagnosing overload resolution failure. Modified: cfe/trunk/lib/Sema/SemaOverload.cpp

[libcxx] r291592 - [CMake][libcxx] Move Python check to main CMake file

Author: phosek Date: Tue Jan 10 13:51:17 2017 New Revision: 291592 URL: http://llvm.org/viewvc/llvm-project?rev=291592=rev Log: [CMake][libcxx] Move Python check to main CMake file This is to make sure this check is called even when building as part of LLVM runtimes when we are doing standalone

[PATCH] D28520: Disable -Wthread-safety-analysis for some functions in __thread_support

dim added a comment. Hmm, actually this does not work. The definition of `_LIBCPP_THREAD_SAFETY_ANNOTATION` I moved from `__mutex_base` to `__config` is only enabled if `_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS` is manually defined. There must have been some reason to do it like this in

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

chandlerc added a comment. In https://reviews.llvm.org/D28404#641696, @mehdi_amini wrote: > In https://reviews.llvm.org/D28404#641632, @probinson wrote: > > > In https://reviews.llvm.org/D28404#641606, @mehdi_amini wrote: > > > > > If we want to support `-O0 -flto` and `optnone` it the way to

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. I guess I'm getting irritated because people are trying to tell me what optnone means. I know what it means; I spent probably a whole year pushing to get it adopted. Optnone means: When you are running optimizations, try not to optimize this part, if you can.

r291610 - Remove dead code.

Author: rsmith Date: Tue Jan 10 17:04:46 2017 New Revision: 291610 URL: http://llvm.org/viewvc/llvm-project?rev=291610=rev Log: Remove dead code. Modified: cfe/trunk/lib/Parse/Parser.cpp Modified: cfe/trunk/lib/Parse/Parser.cpp URL:

[PATCH] D28467: [Sema] Add warning for unused lambda captures

aaron.ballman added inline comments. Comment at: include/clang/Sema/ScopeInfo.h:457 +/// lambda. +bool Used = false; + arphaman wrote: > malcolm.parsons wrote: > > Should this be moved into one of the `PointerIntPair`s? > I'm not sure.. If we needed

r291598 - [Driver] Add openSuse AArch64 Triple

Author: cryptoad Date: Tue Jan 10 15:13:08 2017 New Revision: 291598 URL: http://llvm.org/viewvc/llvm-project?rev=291598=rev Log: [Driver] Add openSuse AArch64 Triple Summary: openSuse has AArch64 support, with images running on the Raspberry Pi 3. The libraries and headers live under the

[libcxx] r291632 - [CMake][libcxx] Do not rely on the existence of c++abi or unwind targets

Author: phosek Date: Tue Jan 10 18:56:10 2017 New Revision: 291632 URL: http://llvm.org/viewvc/llvm-project?rev=291632=rev Log: [CMake][libcxx] Do not rely on the existence of c++abi or unwind targets There is no guaranteed order in which CMake files for individual runtimes are invoked and

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

lethalantidote created this revision. lethalantidote added a reviewer: thakis. lethalantidote added a subscriber: cfe-commits. Elliminates uninitialized warning for volitile variables. https://reviews.llvm.org/D28543 Files: clang/lib/Sema/AnalysisBasedWarnings.cpp Index:

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 5 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r291628 - Module: Do not create Implicit ImportDecl for module X if we

Author: mren Date: Tue Jan 10 18:48:19 2017 New Revision: 291628 URL: http://llvm.org/viewvc/llvm-project?rev=291628=rev Log: Module: Do not create Implicit ImportDecl for module X if we are building an implemenation of module X. This fixes a regression caused by r280409.

r291635 - [analyzer] Fix crash in body farm for getter without implicit self.

Author: dcoughlin Date: Tue Jan 10 19:02:34 2017 New Revision: 291635 URL: http://llvm.org/viewvc/llvm-project?rev=291635=rev Log: [analyzer] Fix crash in body farm for getter without implicit self. Fix a crash in body farm when synthesizing a getter for a property synthesized for a property

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

aaron.ballman added inline comments. Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:6-8 +The check converts dynamic exception specifications, e.g., +``throw()``, ``throw([,...])``, or ``throw(...)``, to +``noexcept``, ``noexcept(false)``, blank, or a user defined

[PATCH] D24991: Inline hot functions in libcxx shared_ptr implementation.

kubabrecka added inline comments. Comment at: libcxx/include/memory:3702 +inline T +__libcpp_atomic_increment(T& t) _NOEXCEPT +{ I don't think this should be named `__libcpp_atomic_increment`, because it uses relaxed ordering and thus it's not a generic

[PATCH] D28299: Module: use PCMCache to manage memory buffers for pcm files.

benlangmuir added inline comments. Comment at: include/clang/Basic/FileManager.h:176 + /// Manage memory buffers associated with pcm files. + std::unique_ptr BufferMgr; + manmanren wrote: > benlangmuir wrote: > > Why is this inside the FileManager? It isn't

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:99 + + assert(CRange.isValid() && "Exception Specification Range is invalid."); + assert(FnTy &&

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda added inline comments. Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:6-8 +The check converts dynamic exception specifications, e.g., +``throw()``, ``throw([,...])``, or ``throw(...)``, to +``noexcept``, ``noexcept(false)``, blank, or a user defined

Re: r280409 - When we reach the end of a #include of a header of a local submodule that we

Hi Richard, I fixed a regression caused by this commit in r291628. Let me know if you see any problem! Manman > On Sep 1, 2016, at 1:15 PM, Richard Smith via cfe-commits > wrote: > > Author: rsmith > Date: Thu Sep 1 15:15:25 2016 > New Revision: 280409 > > URL:

[PATCH] D26267: [Modules] Include builtins with #include instead of #import for ObjC

bruno closed this revision. bruno added a comment. Thanks for the review Richard. Committed 291644 Comment at: lib/Lex/HeaderSearch.cpp:1082 + auto TryEnterImported = [&](void) -> bool { +if (!ModulesEnabled) rsmith wrote: > Maybe add a FIXME here

Re: r291628 - Module: Do not create Implicit ImportDecl for module X if we

On Tue, Jan 10, 2017 at 5:59 PM, Richard Smith wrote: > On 10 January 2017 at 17:57, Richard Smith wrote: > >> On 10 January 2017 at 16:48, Manman Ren via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: mren >>> Date: Tue Jan 10

[PATCH] D28451: [AVR] Add support for the 'interrupt' and 'naked' attributes

dylanmckay updated this revision to Diff 83913. dylanmckay marked 2 inline comments as done. dylanmckay added a comment. [AVR] Document the 'interrupt' and 'naked' attributes https://reviews.llvm.org/D28451 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

[PATCH] D28451: [AVR] Add support for the 'interrupt' and 'naked' attributes

dylanmckay added inline comments. Comment at: include/clang/Basic/Attr.td:488 + +def AVRSignal : InheritableAttr, TargetSpecificAttr { + let Spellings = [GNU<"signal">]; aaron.ballman wrote: > Does this attribute appertain to any specific subjects, or can you

Re: r291628 - Module: Do not create Implicit ImportDecl for module X if we

On 10 January 2017 at 17:57, Richard Smith wrote: > On 10 January 2017 at 16:48, Manman Ren via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: mren >> Date: Tue Jan 10 18:48:19 2017 >> New Revision: 291628 >> >> URL:

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

thakis added a comment. Thanks! Can you add a test somewhere? `grep -R W.*uninitialized test/Sema*` will probably show you the existing test for this code. (Another technique: Comment some of the existing tests, run `ninja check-clang`, and see which tests start failing.) You can run an

r291644 - [Modules] Support #import when entering files with modules

Author: bruno Date: Tue Jan 10 20:14:51 2017 New Revision: 291644 URL: http://llvm.org/viewvc/llvm-project?rev=291644=rev Log: [Modules] Support #import when entering files with modules Textual headers and builtins that are #import'd from different modules should get re-entered when these

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. Apologies for the delay over the holiday season, I will look into this later on after office hours. https://reviews.llvm.org/D27800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26244: [Driver] Prefer libraries installed next to Clang over those from GCC

chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. There are some issues with this patch currently. At a basic level, it needs well crafted test cases. You can find out how to write them by looking at other Driver tests. But

[PATCH] D28526: [ARM] Add diagnostics when initialization global variables with ropi/rwpi

efriedma added a comment. If there isn't already a LangOptions flag which reflects this, it probably makes sense to add one. https://reviews.llvm.org/D28526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28503: Documentation for the newly added x86 intrinsics.

agutowski added a comment. For my part, LGTM. Repository: rL LLVM https://reviews.llvm.org/D28503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r291653 - Only launch asynchronously if threading is enabled.

Author: klimek Date: Wed Jan 11 01:20:46 2017 New Revision: 291653 URL: http://llvm.org/viewvc/llvm-project?rev=291653=rev Log: Only launch asynchronously if threading is enabled. Modified: clang-tools-extra/trunk/include-fixer/SymbolIndexManager.h Modified:

[PATCH] D28400: [AArch64] Use generic bitreverse intrinsic, rather than AArch64 specific.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291574: [AArch64] Use generic bitreverse intrinsic, rather than AArch64 specific. (authored by mcrosier). Changed prior to commit: https://reviews.llvm.org/D28400?vs=83367=83817#toc Repository: rL

[PATCH] D28231: -Wunreachable-code: Avoid multiple diagnostics that are triggered by the same source range and fix the unary operator fixit source range

arphaman updated this revision to Diff 83819. arphaman added a comment. Fix more issues with FIXIT for unary operators. Repository: rL LLVM https://reviews.llvm.org/D28231 Files: lib/Analysis/ReachableCode.cpp lib/Sema/AnalysisBasedWarnings.cpp test/Sema/warn-unreachable.c Index:

[PATCH] D28252: [OpenMP] Sema and parsing for 'target teams distribute simd' pragma

kkwli0 marked an inline comment as done. kkwli0 added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:6444 + + CapturedStmt *CS = cast(AStmt); + // 1.2.2 OpenMP Language Terminology ABataev wrote: > auto * Will do. https://reviews.llvm.org/D28252

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia updated this revision to Diff 83824. Anastasia added a comment. Updated with comments from Mats! https://reviews.llvm.org/D28080 Files: docs/UsersManual.rst www/index.html Index: www/index.html === ---

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda marked 7 inline comments as done. hintonda added inline comments. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:64 + Finder->addMatcher( + parmVarDecl(hasType(pointerType(pointee(parenType(innerType( +

r291574 - [AArch64] Use generic bitreverse intrinsic, rather than AArch64 specific.

Author: mcrosier Date: Tue Jan 10 11:20:28 2017 New Revision: 291574 URL: http://llvm.org/viewvc/llvm-project?rev=291574=rev Log: [AArch64] Use generic bitreverse intrinsic, rather than AArch64 specific. Differential Revision: https://reviews.llvm.org/D28400 Modified:

[PATCH] D28505: CGDecl: Skip static variable initializers in unreachable code

This revision was automatically updated to reflect the committed changes. Closed by commit rL291576: CGDecl: Skip static variable initializers in unreachable code (authored by matze). Changed prior to commit: https://reviews.llvm.org/D28505?vs=83754=83820#toc Repository: rL LLVM

r291576 - CGDecl: Skip static variable initializers in unreachable code

Author: matze Date: Tue Jan 10 11:43:01 2017 New Revision: 291576 URL: http://llvm.org/viewvc/llvm-project?rev=291576=rev Log: CGDecl: Skip static variable initializers in unreachable code This fixes http://llvm.org/PR31054 Differential Revision: https://reviews.llvm.org/D28505 Added:

[PATCH] D28231: -Wunreachable-code: Avoid multiple diagnostics that are triggered by the same source range and fix the unary operator fixit source range

arphaman added inline comments. Comment at: lib/Analysis/ReachableCode.cpp:229 + if (SilenceableCondValNotSet && SilenceableCondVal->getBegin().isValid()) +*SilenceableCondVal = UO->getSourceRange(); + return UO->getOpcode() == UO_LNot && IsSubExprConfigValue;

[PATCH] D27068: Improve string::find

hiraditya added a comment. Just for the record, I ported the patch to gcc/libstdc++ as well: PR66414 optimize std::string::find https://github.com/gcc-mirror/gcc/commit/fc7ebc4b8d9ad7e2891b7f72152e8a2b7543cd65 Repository: rL LLVM https://reviews.llvm.org/D27068

[PATCH] D25213: Fix PR28181: Prevent operator overloading related assertion failure crash that happens in C only

arphaman updated this revision to Diff 83822. arphaman added a comment. Ping Repository: rL LLVM https://reviews.llvm.org/D25213 Files: lib/Sema/SemaExpr.cpp test/Sema/PR28181.c Index: test/Sema/PR28181.c === ---

[PATCH] D28350: [Sema] Avoid -Wshadow warning when a "redefinition of " error is presented

This revision was automatically updated to reflect the committed changes. Closed by commit rL291564: [Sema] Avoid -Wshadow warning when a "redefinition of " error is presented (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D28350?vs=83214=83806#toc Repository: rL

[PATCH] D17981: [clang-tidy] Fix clang-tidy to support parsing of assembly statements.

etienneb added a comment. jckooijman, this issue is still not solved on ToT. You can apply this patch on your local repo. It's fixing the problem, but your executable size will increase. https://reviews.llvm.org/D17981 ___ cfe-commits mailing list

[PATCH] D28467: [Sema] Add warning for unused lambda captures

arphaman added inline comments. Comment at: include/clang/Sema/ScopeInfo.h:457 +/// lambda. +bool Used = false; + malcolm.parsons wrote: > Should this be moved into one of the `PointerIntPair`s? I'm not sure.. If we needed other capturing information in

[PATCH] D20428: Tracking exception specification source locations

aaron.ballman added a comment. I think that these changes look good to me, and I noticed Richard signed off on the other review for the exception spec changes (thank you for working on that!), so I think this is ready to commit. In https://reviews.llvm.org/D20428#641068, @hintonda wrote: >

[PATCH] D28033: [analyzer] Treat pointers to static member functions as function pointers

dcoughlin updated this revision to Diff 83828. dcoughlin added a comment. Updating spacing, as @kromanenkov requested. https://reviews.llvm.org/D28033 Files: lib/StaticAnalyzer/Core/SValBuilder.cpp test/Analysis/pointer-to-member.cpp Index: test/Analysis/pointer-to-member.cpp

[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

enyquist added a comment. Well, your patch is here for me to try, and it looks like it's been accepted. So I guess I should just pull my finger out and try it :) Thanks for your response-- I'll let you know if I come across any issues. https://reviews.llvm.org/D21279

[PATCH] D28520: Disable -Wthread-safety-analysis for some functions in __thread_support

aaron.ballman added a reviewer: delesley. aaron.ballman added a comment. Alternatively, these functions could be given the proper thread safety annotations, couldn't they? https://reviews.llvm.org/D28520 ___ cfe-commits mailing list

r291581 - [analyzer] Treat pointers to static member functions as function pointers

Author: dcoughlin Date: Tue Jan 10 12:49:27 2017 New Revision: 291581 URL: http://llvm.org/viewvc/llvm-project?rev=291581=rev Log: [analyzer] Treat pointers to static member functions as function pointers Sema treats pointers to static member functions as having function pointer type, so treat

r291583 - [OpenMP] Remove outdated comments. NFC.

Author: kli Date: Tue Jan 10 12:57:07 2017 New Revision: 291583 URL: http://llvm.org/viewvc/llvm-project?rev=291583=rev Log: [OpenMP] Remove outdated comments. NFC. Modified: cfe/trunk/include/clang/Basic/OpenMPKinds.def Modified: cfe/trunk/include/clang/Basic/OpenMPKinds.def URL:

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda added inline comments. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:68 + this); +} + aaron.ballman wrote: > hintonda wrote: > > aaron.ballman wrote: > > > Also missing: typedefs and using declarations. > > As far as I know, it isn't legal

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

mehdi_amini added a comment. In https://reviews.llvm.org/D28404#641538, @probinson wrote: > > - optnone isn't *really* no optimizations: clearly this is true, but then > > neither is -O0. We run the always inliner, a couple of other passes, and we > > run several parts of the code generators

[PATCH] D28148: [Sema] Suppress warnings for C's zero initializer

sgilles marked an inline comment as done. sgilles added a comment. Ping - if there are no comments, could this be accepted? https://reviews.llvm.org/D28148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28520: Disable -Wthread-safety-analysis for some functions in __thread_support

EricWF added a comment. Also look in `__mutex` where libc++ defines its own macros for the annotations. https://reviews.llvm.org/D28520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28520: Disable -Wthread-safety-analysis for some functions in __thread_support

dim created this revision. dim added reviewers: EricWF, mclow.lists. dim added subscribers: cfe-commits, emaste, joerg. Many thread-related libc++ test cases fail on FreeBSD, due to the following -Werror warnings: In file included from

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia marked 4 inline comments as done. Anastasia added a comment. Ping! Any more comments here? It would be nice to commit this before the 4.0 rel branch is taken (on Jan 12). https://reviews.llvm.org/D28080 ___ cfe-commits mailing list

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda updated this revision to Diff 83827. hintonda marked an inline comment as done. hintonda added a comment. - Addressed comments. https://reviews.llvm.org/D20693 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

rnk added a comment. In https://reviews.llvm.org/D28365#640868, @hamzasood wrote: > Ha, good point. Does that include the environment stuff in Command too or > just the linker? Yes, please make the Command environment changes as part of a separate patch with the linker environment changes.

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

KP updated this revision to Diff 83829. KP added a comment. Rename IsPointerOrReference to isPointerOrReference to comply with coding style https://reviews.llvm.org/D27651 Files: lib/Format/WhitespaceManager.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[libcxx] r291580 - Qualify some type names that I thought were fine, but some of the bots don't like.

Author: marshall Date: Tue Jan 10 12:40:01 2017 New Revision: 291580 URL: http://llvm.org/viewvc/llvm-project?rev=291580=rev Log: Qualify some type names that I thought were fine, but some of the bots don't like. Modified: libcxx/trunk/include/memory Modified: libcxx/trunk/include/memory

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:68 + this); +} + hintonda wrote: > aaron.ballman wrote: > > Also missing: typedefs and using declarations. > As far as I know, it isn't legal to add dynamic exception

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#641078, @chandlerc wrote: > For me, the arguments you're raising against -O0 and -flto don't hold up on > closer inspection: > > - O0 != optnone: correct. But this is only visible in LTO. And in LTO, Os != > optsize, and Oz !=

  1   2   >