r292768 - DebugInfo: Omit class definitions even in the presence of available_externally vtables

2017-01-22 Thread David Blaikie via cfe-commits
Author: dblaikie Date: Sun Jan 22 20:24:03 2017 New Revision: 292768 URL: http://llvm.org/viewvc/llvm-project?rev=292768=rev Log: DebugInfo: Omit class definitions even in the presence of available_externally vtables To ensure optimization level doesn't pessimize the -fstandalone-debug vtable

[PATCH] D28953: [analyzer] Eliminate analyzer limitations on symbolic constraint generation

2017-01-22 Thread Dominic Chen via Phabricator via cfe-commits
ddcc updated this revision to Diff 85314. ddcc added a comment. Rebase https://reviews.llvm.org/D28953 Files: include/clang/StaticAnalyzer/Checkers/SValExplainer.h lib/StaticAnalyzer/Core/SValBuilder.cpp lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp test/Analysis/bitwise-ops.c

[PATCH] D28954: [analyzer] Add support for symbolic float expressions

2017-01-22 Thread Dominic Chen via Phabricator via cfe-commits
ddcc updated this revision to Diff 85315. ddcc added a comment. Rebase https://reviews.llvm.org/D28954 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

2017-01-22 Thread Dominic Chen via Phabricator via cfe-commits
ddcc updated this revision to Diff 85313. ddcc added a comment. Convert to plugin, add move/assignment constructor, avoid Z3_simplify(), use Z3_mk_simple_solver(), generate logical and of all constraints in solver https://reviews.llvm.org/D28952 Files: CMakeLists.txt

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

2017-01-22 Thread Dominic Chen via Phabricator via cfe-commits
ddcc added a comment. I'd like to note that one of the main challenges with this implementation was needing to perform type reinference and implicit casting within the constraint manager, since the constraints are sometimes implicit. (e.g. `(int) x` instead of `x == 0`). It also didn't help

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

2017-01-22 Thread Dominic Chen via Phabricator via cfe-commits
ddcc updated this revision to Diff 85316. ddcc added a comment. Rebase https://reviews.llvm.org/D28955 Files: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h

[PATCH] D29001: [Modules] Fallback to building the module if a timeout occurs

2017-01-22 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno created this revision. Herald added a subscriber: fhahn. After https://reviews.llvm.org/D28299 gets in, clang will use PCMCache to manage memory buffers for pcm files. This means the lock file manager isn't needed for correctness anymore, but only as an optimization: clang waits for

[PATCH] D28973: Supresses misc-move-constructor-init warning for const fields.

2017-01-22 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/test/clang-tidy/misc-move-constructor-init.cpp:88 +struct O { + O(O&& other) : b(other.b) {} // ok + const B b;

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

2017-01-22 Thread Nuno Lopes via Phabricator via cfe-commits
nlopes added a comment. Cool work Dominic! Just a few random comments from the peanut gallery regarding the usage of Z3: - I would definitely split the Z3Expr into expr/solver/model classes. Several advantages: plugging in new solvers becomes easier and reference counting can be handled more

Re: r292558 - Add documentation for constexpr string builtin support.

2017-01-22 Thread Kim Gräsman via cfe-commits
Hi Richard, On Fri, Jan 20, 2017 at 1:58 AM, Richard Smith via cfe-commits wrote: > > +String builtins > +--- > + > +Clang provides constant expression evaluation support for builtins forms of > +the following functions from the C standard library

[PATCH] D28520: Disable -Wthread-safety-analysis for some functions in __thread_support

2017-01-22 Thread Dimitry Andric via Phabricator via cfe-commits
dim updated this revision to Diff 85283. dim added a comment. Let's try it with this much simpler version instead, which disables the thread safety analysis _only_ for FreeBSD, and nowhere else. And no messing with capabilities, either. https://reviews.llvm.org/D28520 Files:

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

2017-01-22 Thread don hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 85291. hintonda added a comment. - Rebased. https://reviews.llvm.org/D20693 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseNoexceptCheck.cpp clang-tidy/modernize/UseNoexceptCheck.h

[PATCH] D28983: clang-format: remove tests that assume no config file will be found as this is not always the case

2017-01-22 Thread Eric Liu via Phabricator via cfe-commits
ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lgtm https://reviews.llvm.org/D28983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28983: clang-format: remove tests that assume no config file will be found as this is not always the case

2017-01-22 Thread Mikael Holmén via Phabricator via cfe-commits
uabelho added a comment. Great! This patch solves the problems we saw. Thanks! https://reviews.llvm.org/D28983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r291318 - PR23135: Don't instantiate constexpr functions referenced in unevaluated operands where possible.

2017-01-22 Thread Mehdi Amini via cfe-commits
Hi Richard, I have a link failure in WebKit following this patch, the move-assign operator for an nested class isn’t emitted (IRGen) in some context where it is needed. I’m working on running creduce the test-case which is pretty large, but in case it rings a bell, I let you know already. —

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

2017-01-22 Thread Pekka Jääskeläinen via Phabricator via cfe-commits
pekka.jaaskelainen added a comment. In https://reviews.llvm.org/D28080#651732, @Anastasia wrote: > @pekka.jaaskelainen, I just compiled the release 4.0 branch and it all works > for me as expected: > clang -cc1 -triple spir64-unknown-unknown test.cl > clang -target spir64-unknown-unknown

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

2017-01-22 Thread Paulo Matos via Phabricator via cfe-commits
pmatos updated this revision to Diff 85328. pmatos added a comment. Here's an updated patch including the test. Hope this is now ok for submission. Please accept my apologies with regards to the delaying in submitting this. https://reviews.llvm.org/D27800 Files: include/clang/Sema/Sema.h

Re: r291905 - [Sema] Add warning for unused lambda captures

2017-01-22 Thread Malcolm Parsons via cfe-commits
On 20 January 2017 at 21:32, Nico Weber wrote: > This warns about code like > > constexpr int foo = 4; > []() { use(foo); } > > That's correct, but removing then makes MSVC complain about this code > like "error C3493: 'foo' cannot be implicitly captured because no

[PATCH] D28520: Disable -Wthread-safety-analysis for some functions in __thread_support

2017-01-22 Thread Dimitry Andric via Phabricator via cfe-commits
dim added a comment. In https://reviews.llvm.org/D28520#648880, @delesley wrote: > Sorry about the slow response. My main concern here is that the thread > safety analysis was designed for use with a library that wraps the system > mutex in a separate Mutex class. We did that specifically