[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

bmharper added a comment. Pinging @djasper. Any chance we can get this merged? https://reviews.llvm.org/D21279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

djasper added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:207 + +if (i != Start) { + if (Changes[i].NestingAndIndentLevel > Merge the two ifs into a single one? Comment at: lib/Format/WhitespaceManager.cpp:318 + for

r292776 - ASTImporter: improve support for C++ templates

Author: a.sidorin Date: Mon Jan 23 03:30:36 2017 New Revision: 292776 URL: http://llvm.org/viewvc/llvm-project?rev=292776=rev Log: ASTImporter: improve support for C++ templates * Support template partial specialization * Avoid infinite recursion in IsStructurallyEquivalent for

r292778 - ASTImporter: add forgotten tests for rL292776

Author: a.sidorin Date: Mon Jan 23 03:45:29 2017 New Revision: 292778 URL: http://llvm.org/viewvc/llvm-project?rev=292778=rev Log: ASTImporter: add forgotten tests for rL292776 Added: cfe/trunk/test/ASTMerge/class-template-partial-spec/

r292779 - ASTImporter: quick test fix

Author: a.sidorin Date: Mon Jan 23 04:16:30 2017 New Revision: 292779 URL: http://llvm.org/viewvc/llvm-project?rev=292779=rev Log: ASTImporter: quick test fix Differential Revision: https://reviews.llvm.org/D26753 Modified: cfe/trunk/test/ASTMerge/class-template-partial-spec/test.cpp

[PATCH] D26753: ASTImporter: improve support for C++ templates

a.sidorin added a comment. Main revisions: https://reviews.llvm.org/rL292776, https://reviews.llvm.org/rL292778. Sorry for not mentioning them in Differential Revision. Repository: rL LLVM https://reviews.llvm.org/D26753 ___ cfe-commits

r292781 - ASTImporter: fix tests on Windows with removing slashed parts of paths

Author: a.sidorin Date: Mon Jan 23 04:39:45 2017 New Revision: 292781 URL: http://llvm.org/viewvc/llvm-project?rev=292781=rev Log: ASTImporter: fix tests on Windows with removing slashed parts of paths Differential Revision: https://reviews.llvm.org/D26753 Modified:

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

krasimir added inline comments. Comment at: lib/Format/BreakableToken.h:87 /// space. virtual void replaceWhitespace(unsigned LineIndex, unsigned TailOffset, Split Split, By the way, I got confused, this stays because the

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

klimek added inline comments. Comment at: lib/Format/BreakableToken.h:40 +/// of the content after a split has been used for breaking, and +/// - insertBreak, for executing the split using a whitespace manager. +/// Do we want to describe how replaceWhitespace

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

krasimir updated this revision to Diff 85339. krasimir added a comment. - [clang-format] Improve the interface of BreakableToken and add comments. https://reviews.llvm.org/D28764 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/CMakeLists.txt

RE: [libunwind] r292722 - DWARF: allow enabling tracing at runtime

Hi Saleem, This patch is causing our internal runs of the libc++ and libc++abi tests to fail, because logDWARF is referenced but not defined in release builds (with NDEBUG defined). However, I see that all of the libc++ buildbots are passing. Does this patch need modifying to make

[PATCH] D26753: ASTImporter: improve support for C++ templates

This revision was automatically updated to reflect the committed changes. Closed by commit rL292779: ASTImporter: quick test fix (authored by a.sidorin). Changed prior to commit: https://reviews.llvm.org/D26753?vs=79054=85332#toc Repository: rL LLVM https://reviews.llvm.org/D26753 Files:

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

nkakuev added a comment. Ping. https://reviews.llvm.org/D26418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29018: [clang-tidy] Ignore implicit functions in performance-unnecessary-value-param

madsravn added a comment. Looks good to me. Nice touch by solving with implicit. https://reviews.llvm.org/D29018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r292786 - [clang-tidy] Ignore implicit functions in performance-unnecessary-value-param

Author: malcolm.parsons Date: Mon Jan 23 07:18:08 2017 New Revision: 292786 URL: http://llvm.org/viewvc/llvm-project?rev=292786=rev Log: [clang-tidy] Ignore implicit functions in performance-unnecessary-value-param Summary: The performance-unnecessary-value-param check mangled inherited

[PATCH] D29018: [clang-tidy] Ignore implicit functions in performance-unnecessary-value-param

This revision was automatically updated to reflect the committed changes. Closed by commit rL292786: [clang-tidy] Ignore implicit functions in performance-unnecessary-value-param (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D29018?vs=85358=85365#toc

[PATCH] D29025: Revert "IRGen: Start using the WriteThinLTOBitcode pass."

mboehme created this revision. Herald added subscribers: mgorny, mehdi_amini. This reverts commit r292662. This change broke internal builds. Will provide a reproducer internally. https://reviews.llvm.org/D29025 Files: lib/CodeGen/BackendUtil.cpp test/CMakeLists.txt

[PATCH] D29018: [clang-tidy] Ignore implicit functions in performance-unnecessary-value-param

malcolm.parsons created this revision. Herald added a subscriber: JDevlieghere. The performance-unnecessary-value-param check mangled inherited constructors, as the constructors' parameters do not have useful source locations. Fix this by ignoring implicit functions. Fixes PR31684.

[PATCH] D26466: [clang-tidy] Fix NOLINT test

nkakuev added a comment. Ping. https://reviews.llvm.org/D26466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28983: clang-format: remove tests that assume no config file will be found as this is not always the case

This revision was automatically updated to reflect the committed changes. Closed by commit rL292787: clang-format: remove tests that assume no config file will be found as this is… (authored by amaiorano). Changed prior to commit: https://reviews.llvm.org/D28983?vs=85247=85366#toc Repository:

r292787 - clang-format: remove tests that assume no config file will be found as this is not always the case

Author: amaiorano Date: Mon Jan 23 07:20:23 2017 New Revision: 292787 URL: http://llvm.org/viewvc/llvm-project?rev=292787=rev Log: clang-format: remove tests that assume no config file will be found as this is not always the case These tests fail for developers who place their build directories

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

krasimir updated this revision to Diff 85376. krasimir added a comment. - Add a note about replaceWhitespace in the comments of BreakableToken. https://reviews.llvm.org/D28764 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/CMakeLists.txt

[PATCH] D29026: [OpenMP] DSAChecker bug fix for combined directives.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D29026 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27257: [CodeCompletion] Ensure that ObjC root class completes instance methods from protocols and categories as well

arphaman updated this revision to Diff 85400. arphaman added a comment. Add comment to parameter Repository: rL LLVM https://reviews.llvm.org/D27257 Files: lib/Sema/SemaCodeComplete.cpp test/Index/complete-objc-message.m Index: test/Index/complete-objc-message.m

[PATCH] D29033: [clang-format] Fix LanguageKind comments.

This revision was automatically updated to reflect the committed changes. Closed by commit rL292796: [clang-format] Fix LanguageKind comments. (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D29033?vs=85397=85403#toc Repository: rL LLVM

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

sdardis created this revision. Historically, NetBSD, FreeBSD and OpenBSD have defined the macro ABICALLS in the preprocessor when -mabicalls is in effect. Mainline GCC later defined __mips_abicalls when -mabicalls is in effect. This patch teaches the preprocessor to define these macros when

r292794 - [OpenMP] DSAChecker bug fix for combined directives.

Author: arpith Date: Mon Jan 23 09:38:49 2017 New Revision: 292794 URL: http://llvm.org/viewvc/llvm-project?rev=292794=rev Log: [OpenMP] DSAChecker bug fix for combined directives. The DSAChecker code in SemaOpenMP looks at the captured statement associated with an OpenMP directive. A combined

[PATCH] D28520: Disable -Wthread-safety-analysis for some functions in __thread_support

aaron.ballman added a comment. In https://reviews.llvm.org/D28520#652607, @dim wrote: > In https://reviews.llvm.org/D28520#648880, @delesley wrote: > > > Sorry about the slow response. My main concern here is that the thread > > safety analysis was designed for use with a library that wraps

[PATCH] D28514: [CodeCompletion] Reset the hidden declaration obtained after lookup when caching UsingShadowDecls

arphaman added a comment. In https://reviews.llvm.org/D28514#651724, @ahatanak wrote: > If they are equal, the loop can continue because a UsingDecl doesn't hide a > UsingShadowDecl that is tied to it. You're right, that would be better, I didn't notice that method before. Repository: rL

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

sdardis added a comment. Sending it to the correct list this time. https://reviews.llvm.org/D29032 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29026: [OpenMP] DSAChecker bug fix for combined directives.

This revision was automatically updated to reflect the committed changes. Closed by commit rL292794: [OpenMP] DSAChecker bug fix for combined directives. (authored by arpith). Changed prior to commit: https://reviews.llvm.org/D29026?vs=85382=85393#toc Repository: rL LLVM

[PATCH] D28514: [CodeCompletion] Reset the hidden declaration obtained after lookup when caching UsingShadowDecls

arphaman updated this revision to Diff 85398. arphaman added a comment. Verify that the using shadow decl can be hidden by its owning using decl. Repository: rL LLVM https://reviews.llvm.org/D28514 Files: lib/Sema/SemaLookup.cpp test/Index/complete-cached-globals.cpp Index:

[PATCH] D27257: [CodeCompletion] Ensure that ObjC root class completes instance methods from protocols and categories as well

arphaman marked an inline comment as done. arphaman added a comment. In https://reviews.llvm.org/D27257#652135, @bruno wrote: > How does this interact (if at all) with classes annotated with > `__attribute__((objc_root_class))`? The root classes are just classes without a superclass, the

[PATCH] D29033: [clang-format] Fix LanguageKind comments.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Thanks! https://reviews.llvm.org/D29033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r292796 - [clang-format] Fix LanguageKind comments.

Author: krasimir Date: Mon Jan 23 10:21:06 2017 New Revision: 292796 URL: http://llvm.org/viewvc/llvm-project?rev=292796=rev Log: [clang-format] Fix LanguageKind comments. Summary: With the introduction of LK_ObjC, the comment line for LK_Cpp became obsolete. Reviewers: djasper Reviewed By:

Re: [libcxx] r291961 - Add _LIBCPP_DIAGNOSE_WARNING and _LIBCPP_DIAGNOSE_ERROR macros.

This happens to fire in practice in protobuf. It's probably a true positive and it's cool that this warning found it, but it means we have to disable Wuser-defined-warnings for a bit -- which then disables all of these user-defined warnings. Right now there aren't any others, but it feels like

[PATCH] D28451: [AVR] Add support for the 'interrupt' and 'naked' attributes

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5158 + case llvm::Triple::avr: +handleAVRInterruptAttr(S, D, Attr); +break; aaron.ballman wrote: > Just call `handleSimpleAttribute()` instead. Since this is no longer truly a

r292791 - Revert "IRGen: Start using the WriteThinLTOBitcode pass."

Author: mboehme Date: Mon Jan 23 08:33:42 2017 New Revision: 292791 URL: http://llvm.org/viewvc/llvm-project?rev=292791=rev Log: Revert "IRGen: Start using the WriteThinLTOBitcode pass." Summary: This reverts commit r292662. This change broke internal builds. Will provide a reproducer

[PATCH] D29025: Revert "IRGen: Start using the WriteThinLTOBitcode pass."

This revision was automatically updated to reflect the committed changes. Closed by commit rL292791: Revert "IRGen: Start using the WriteThinLTOBitcode pass." (authored by mboehme). Changed prior to commit: https://reviews.llvm.org/D29025?vs=85375=85379#toc Repository: rL LLVM

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

aaron.ballman added inline comments. Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:37-38 + const auto *DeclStatement = Result.Nodes.getNodeAs("declstmt"); + if (!DeclStatement) +return; + Is there a case where this could happen? I would

[PATCH] D29031: [mips] Add support for static model on N64

sdardis created this revision. The patch teaches the Clang driver how to handle the N64 static relocation model properly. It enforces the correct target feature (+noabicalls) when -fno-pic is used. This is required as non-pic N64 code as the abi extension to call PIC code (CPIC) is unsupported.

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

krasimir updated this revision to Diff 85381. krasimir added a comment. - Add back a test case that I had previously removed for no good reason. https://reviews.llvm.org/D28764 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/CMakeLists.txt

[PATCH] D29026: [OpenMP] DSAChecker bug fix for combined directives.

arpith-jacob created this revision. The DSAChecker code in SemaOpenMP looks at the captured statement associated with an OpenMP directive. A combined directive such as 'target parallel' has nested capture statements, which have to be fully traversed before executing the DSAChecker. This is a

[PATCH] D29027: [Stack Protection] Add remark for reasons why Stack Protection has been applied

jhenderson created this revision. Herald added a subscriber: fhahn. Depends on https://reviews.llvm.org/D29023, which is currently under review. In that change, I am adding diagnostic information to LLVM for why Stack Smash Protection has been applied to each function. This is the second stage,

Re: [libcxx] r292276 - Fix std::string assignment ambiguity from braced initializer lists.

> On 17 Jan 2017, at 23:10, Eric Fiselier via cfe-commits > wrote: > > Author: ericwf > Date: Tue Jan 17 16:10:32 2017 > New Revision: 292276 > > URL: http://llvm.org/viewvc/llvm-project?rev=292276=rev > Log: > Fix std::string assignment ambiguity from braced

Re: [libcxx] r291961 - Add _LIBCPP_DIAGNOSE_WARNING and _LIBCPP_DIAGNOSE_ERROR macros.

The only plan that we have at the moment is basically for a -Wno-user-defined-warnings-in-system-headers type of flag. I agree that it would be nice if we could be more granular than this, so I'll think about what we can do. On Mon, Jan 23, 2017 at 8:36 AM, Nico Weber wrote:

[PATCH] D28860: [OpenCL] Diagnose write_only image3d when extension is disabled

yaxunl added a comment. The tests should be added to SemaOpenCL/extension-version.cl Comment at: lib/Sema/SemaType.cpp:6683 + // access qualifier unless the cl_khr_3d_image_writes extension is enabled. + if (CurType->isOCLImage3dWOType() && +

[PATCH] D27257: [CodeCompletion] Ensure that ObjC root class completes instance methods from protocols and categories as well

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Ok. Thanks Alex, LGTM Repository: rL LLVM https://reviews.llvm.org/D27257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29038: [OpenCL] Accept logical NOT for pointer types in CL1.0 and CL1.1

arsenm added inline comments. Comment at: test/SemaOpenCL/logical-ops.cl:1-3 +// RUN: %clang_cc1 %s -verify -cl-std=CL1.1 -triple x86_64-unknown-linux-gnu +// RUN: %clang_cc1 %s -verify -cl-std=CL1.2 -triple x86_64-unknown-linux-gnu + Should this have a 2.0 run

[PATCH] D29038: [OpenCL] Accept logical NOT for pointer types in CL1.0 and CL1.1

arsenm added inline comments. Comment at: test/SemaOpenCL/logical-ops.cl:1-3 +// RUN: %clang_cc1 %s -verify -cl-std=CL1.1 -triple x86_64-unknown-linux-gnu +// RUN: %clang_cc1 %s -verify -cl-std=CL1.2 -triple x86_64-unknown-linux-gnu + arsenm wrote: > Should this

Re: r291905 - [Sema] Add warning for unused lambda captures

On Sun, Jan 22, 2017 at 6:17 AM, Malcolm Parsons wrote: > On 20 January 2017 at 21:32, Nico Weber wrote: > > This warns about code like > > > > constexpr int foo = 4; > > []() { use(foo); } > > > > That's correct, but removing then makes MSVC

[PATCH] D26110: Add a check for GCC to the _LIBCPP_EXPLICIT define

EricWF added a comment. I think I may have committed these changes as part of another change set. https://reviews.llvm.org/D26110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27680: [CodeGen] Move lifetime.start of a variable when goto jumps back past its declaration

rjmccall added inline comments. Comment at: lib/CodeGen/CodeGenFunction.h:217 + /// statements. + llvm::SmallVector LabelSeenStack; + Shouldn't this be maintained by some existing scoping structure like LexicalScope? Comment at:

Re: [libcxx] r292833 - Manually force the use of __decltype in C++03 with Clang 3.4.

This patch should be merge into 4.0 since it is needed to fix compile time regressions in when using Clang 3.4 and C++03. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216054 for more info. /Eric On Mon, Jan 23, 2017 at 2:41 PM, Eric Fiselier via cfe-commits <

[PATCH] D28981: Use GNU-style attributes for several __throw_XXX() functions

dim added a comment. In https://reviews.llvm.org/D28981#653908, @mclow.lists wrote: > > In https://reviews.llvm.org/rL279744, __throw_XXX() functions were > > introduced, partially for compatibility with software compiled against > > libstdc++. > > You're working from a false premise. These

Re: [libcxx] r292822 - Fixed a typo in __config that prevented the aligned new/delete tests from passing on Mac OS.

This patch needs to get merged into 4.0 since the offending commit with the misspelling is in the 4.0 branch. /Eric On Mon, Jan 23, 2017 at 12:51 PM, Marshall Clow via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: marshall > Date: Mon Jan 23 13:51:54 2017 > New Revision: 292822 > >

[libcxx] r292823 - Implement LWG#2778: basic_string_view is missing constexpr.

Author: marshall Date: Mon Jan 23 13:53:28 2017 New Revision: 292823 URL: http://llvm.org/viewvc/llvm-project?rev=292823=rev Log: Implement LWG#2778: basic_string_view is missing constexpr. Added: libcxx/trunk/test/std/strings/string.view/string.view.cons/assign.pass.cpp Modified:

[PATCH] D28520: Disable -Wthread-safety-analysis for some functions in __thread_support

dim updated this revision to Diff 85440. dim added a comment. In https://reviews.llvm.org/D28520#653360, @aaron.ballman wrote: > In https://reviews.llvm.org/D28520#652607, @dim wrote: > > > > [...] >> I'm really open to any variant, as long as something that works can get in >> before the

[PATCH] D26110: Add a check for GCC to the _LIBCPP_EXPLICIT define

mclow.lists added a comment. Ok, this is weird. It looks like the changes to <__config> got committed, but not the test. https://reviews.llvm.org/D26110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28526: [ARM] Add diagnostics when initialization global variables with ropi/rwpi

weimingz updated this revision to Diff 85446. weimingz edited the summary of this revision. weimingz added a comment. As Eli sugguested, it's better to check it in Sema. In order to access RelocationModel in Sema, we moved it from CodeGenOpts to LangOpts https://reviews.llvm.org/D28526 Files:

[libcxx] r292830 - Fix GCC C++03 build by hiding default template argument in C++03

Author: ericwf Date: Mon Jan 23 15:24:58 2017 New Revision: 292830 URL: http://llvm.org/viewvc/llvm-project?rev=292830=rev Log: Fix GCC C++03 build by hiding default template argument in C++03 Modified: libcxx/trunk/include/string Modified: libcxx/trunk/include/string URL:

Re: [libcxx] r292822 - Fixed a typo in __config that prevented the aligned new/delete tests from passing on Mac OS.

Ok, go ahead. On Mon, Jan 23, 2017 at 1:54 PM, Eric Fiselier wrote: > This patch needs to get merged into 4.0 since the offending commit with the > misspelling is in the 4.0 branch. > > /Eric > > > On Mon, Jan 23, 2017 at 12:51 PM, Marshall Clow via cfe-commits >

[PATCH] D28520: Disable -Wthread-safety-analysis for some functions in __thread_support

EricWF added a comment. @dim I would really rather just suppress these warnings if we want them merged into 4.0. https://reviews.llvm.org/D28520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxx] r291961 - Add _LIBCPP_DIAGNOSE_WARNING and _LIBCPP_DIAGNOSE_ERROR macros.

My dream, and something I would like to work towards is supporting something like this: > [[clang::libcxx_diagnose_if(cond, "message", "warning", /* warning-id*/ "non-const-functor")]] > > -Wno-libcxx-warnings=non-const-functor This way libc++ warnings get treated differently from all other

[PATCH] D28510: Reinstate CWG1607 restrictions on lambdas appearing inside certain constant-expressions

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. I don't think it's possible to check this in the way you're doing so here. In general, there's no way to know whether a constant expression will be part of a `typedef` declaration

Re: [libcxx] r292830 - Fix GCC C++03 build by hiding default template argument in C++03

This patch should be merge into the 4.0 branch. It fixes a bug introduced to the 4.0 branch in r292354 ( https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216054). /Eric On Mon, Jan 23, 2017 at 2:24 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date:

Re: r292800 - [analyzer] Fix memory space of static locals seen from nested blocks.

Sounds good to me. Anna, you're the code owner here. Ok to merge this? Thanks, Hans On Mon, Jan 23, 2017 at 10:37 AM, Artem Dergachev wrote: > Hans, > > Could we merge this one into the 4.0.0 release branch? It's a recent bugfix > for the analyzer. > > Thanks, > Artem. > >

Re: r291905 - [Sema] Add warning for unused lambda captures

On Mon, Jan 23, 2017 at 5:29 PM, Aaron Ballman wrote: > On Mon, Jan 23, 2017 at 5:00 PM, Nico Weber via cfe-commits > wrote: > > On Sun, Jan 22, 2017 at 6:17 AM, Malcolm Parsons < > malcolm.pars...@gmail.com> > > wrote: > >> > >> On 20 January

r292847 - PR31692: Don't mark a declaration as invalid if we haven't necessarily emitted a (user-visible) error.

Author: rsmith Date: Mon Jan 23 17:14:23 2017 New Revision: 292847 URL: http://llvm.org/viewvc/llvm-project?rev=292847=rev Log: PR31692: Don't mark a declaration as invalid if we haven't necessarily emitted a (user-visible) error. Added:

[PATCH] D28981: Use GNU-style attributes for several __throw_XXX() functions

jwakely added a comment. The __throw_xxx functions are not part of the public libstdc++ API and whatever Firefox is trying to do with them is not supported by libstdc++ and is undefined behaviour. Make it stop. https://reviews.llvm.org/D28981 ___

Re: r292800 - [analyzer] Fix memory space of static locals seen from nested blocks.

Yes, ok to merge! Thank you. Sent from my iPhone > On Jan 23, 2017, at 1:50 PM, Hans Wennborg wrote: > > Sounds good to me. > > Anna, you're the code owner here. Ok to merge this? > > Thanks, > Hans > >> On Mon, Jan 23, 2017 at 10:37 AM, Artem Dergachev

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

dcoughlin added a comment. This is super-exciting work! Some high-level notes: - The running-time numbers you report are very high. At a ~20x slowdown, the benefits from improved solver reasoning will have to be very, very large to justify the performance cost. It is worth thinking about ways

Re: [libcxx] r292833 - Manually force the use of __decltype in C++03 with Clang 3.4.

r292866. On Mon, Jan 23, 2017 at 5:22 PM, Hans Wennborg wrote: > Sounds good to me. > > On Mon, Jan 23, 2017 at 1:56 PM, Eric Fiselier wrote: > > This patch should be merge into 4.0 since it is needed to fix compile > time > > regressions in when using Clang

[libcxx] r292866 - Merge r292833 - Manually force the use of __decltype in C++03 with Clang 3.4.

Author: ericwf Date: Mon Jan 23 19:01:55 2017 New Revision: 292866 URL: http://llvm.org/viewvc/llvm-project?rev=292866=rev Log: Merge r292833 - Manually force the use of __decltype in C++03 with Clang 3.4. This merges a version of r292833 since it didn't apply cleanly due to other upstream

Re: [libcxx] r291961 - Add _LIBCPP_DIAGNOSE_WARNING and _LIBCPP_DIAGNOSE_ERROR macros.

I like the idea of tagging diagnose_ifs with tags, though I wonder how this could be made applicable to code outside of libcxx. Specifically, if I import some big library that uses diagnose_if, then I'd still need to use `-Wno-user-defined-warnings` if said lib had a single diagnose_if that I

[PATCH] D28933: Revert the return type for `emplace_(back|front)` to `void` in C++14 and before

hans added a comment. This sounds like something we'll want to merge to the release branch when it lands? https://reviews.llvm.org/D28933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28835: [coroutines] NFC: Refactor Sema::CoroutineBodyStmt construction.

GorNishanov updated this revision to Diff 85490. GorNishanov added a comment. Feedback implemented! https://reviews.llvm.org/D28835 Files: include/clang/AST/StmtCXX.h include/clang/Sema/ScopeInfo.h lib/AST/StmtCXX.cpp lib/Sema/SemaCoroutine.cpp test/SemaCXX/coroutines.cpp Index:

Re: [libcxx] r292830 - Fix GCC C++03 build by hiding default template argument in C++03

r292867. On Mon, Jan 23, 2017 at 2:52 PM, Hans Wennborg wrote: > We merged the first one, so I suppose we better fix it :-) > > Sounds good to me. > > On Mon, Jan 23, 2017 at 1:37 PM, Eric Fiselier wrote: > > This patch should be merge into the 4.0 branch. > >

[libcxx] r292867 - Merge r292830 - Fix GCC C++03 build by hiding default template argument in C++03

Author: ericwf Date: Mon Jan 23 19:03:36 2017 New Revision: 292867 URL: http://llvm.org/viewvc/llvm-project?rev=292867=rev Log: Merge r292830 - Fix GCC C++03 build by hiding default template argument in C++03 Modified: libcxx/branches/release_40/include/string Modified:

[PATCH] D29063: [libcxx] Never use within libc++

EricWF created this revision. Herald added a subscriber: mgorny. It is my opinion that libc++ should never use ``, including in the `dylib`. This patch remove all uses of `assert` from within libc++ and replaces most of them with `_LIBCPP_ASSERT` instead. Additionally this patch turn

Re: r292847 - PR31692: Don't mark a declaration as invalid if we haven't necessarily emitted a (user-visible) error.

Hans, this should go into Clang 4. On 23 January 2017 at 15:14, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Mon Jan 23 17:14:23 2017 > New Revision: 292847 > > URL: http://llvm.org/viewvc/llvm-project?rev=292847=rev > Log: > PR31692: Don't mark a

r292856 - Re-commit "Don't inline dllimport functions referencing non-imported methods"

Author: hans Date: Mon Jan 23 17:57:50 2017 New Revision: 292856 URL: http://llvm.org/viewvc/llvm-project?rev=292856=rev Log: Re-commit "Don't inline dllimport functions referencing non-imported methods" This re-commits r292522 with the addition that it also handles calls through pointer to

Re: r292522 - Don't inline dllimport functions referencing non-imported methods

Thanks for reverting! This was indeed broken. I've re-committed it with a fix in r292856. On Fri, Jan 20, 2017 at 12:56 PM, Reid Kleckner via cfe-commits wrote: > The first Chrome DLL build with this change is crashing during compilation: >

Re: r291963 - [clang] Emit `diagnose_if` warnings from system headers

Ping? On Tue, Jan 17, 2017 at 4:16 PM, Hans Wennborg wrote: > Richard, what do you think? > > On Fri, Jan 13, 2017 at 3:16 PM, Eric Fiselier wrote: >> I would love to see this merged. It would make it easier to write libc++ >> tests if the tests didn't have to

Re: r292847 - PR31692: Don't mark a declaration as invalid if we haven't necessarily emitted a (user-visible) error.

Thanks! r292859. On Mon, Jan 23, 2017 at 3:26 PM, Richard Smith wrote: > Hans, this should go into Clang 4. > > On 23 January 2017 at 15:14, Richard Smith via cfe-commits > wrote: >> >> Author: rsmith >> Date: Mon Jan 23 17:14:23 2017 >> New

[PATCH] D28889: Change where we handle arg-dependent diagnose_if attributes

george.burgess.iv updated this revision to Diff 85486. george.burgess.iv marked 2 inline comments as done. george.burgess.iv added a comment. Addressed all feedback. Richard noted that, because we're now doing these checks after overload resolution has occurred, we no longer need to convert

[PATCH] D28835: [coroutines] NFC: Refactor Sema::CoroutineBodyStmt construction.

GorNishanov marked 2 inline comments as done. GorNishanov added a comment. Looks even better now! https://reviews.llvm.org/D28835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r292862 - [sanitizer-coverage] emit __sanitizer_cov_trace_pc_guard w/o a preceding 'if' by default. Update the docs, also add deprecation notes around other parts of sanitizer coverage

Author: kcc Date: Mon Jan 23 18:57:31 2017 New Revision: 292862 URL: http://llvm.org/viewvc/llvm-project?rev=292862=rev Log: [sanitizer-coverage] emit __sanitizer_cov_trace_pc_guard w/o a preceding 'if' by default. Update the docs, also add deprecation notes around other parts of sanitizer

[PATCH] D29039: Proposal for clang-format -r option

djasper added a comment. I am happy to let other people in the community weigh in, but I would not move forward with this patch. Listing directories is not a task that clang-format should do. It does not seem useful to me to add this functionality to basically every single tool that you might

[PATCH] D28772: [Preprocessor] Fix incorrect token caching that occurs when lexing _Pragma in macro argument pre-expansion mode when skipping a function body

rsmith added a comment. Can we instead address this locally in `_Pragma` handling, by getting it to clear out the junk it inserted into the token stream when it's done (if backtracking is enabled)? Repository: rL LLVM https://reviews.llvm.org/D28772

Re: r292800 - [analyzer] Fix memory space of static locals seen from nested blocks.

Merged in r292858. Thanks, Hans On Mon, Jan 23, 2017 at 4:15 PM, Anna Zaks wrote: > Yes, ok to merge! > Thank you. > > Sent from my iPhone > >> On Jan 23, 2017, at 1:50 PM, Hans Wennborg wrote: >> >> Sounds good to me. >> >> Anna, you're the code owner here.

[PATCH] D28845: Prototype of modules codegen

dblaikie updated this revision to Diff 85484. dblaikie added a comment. Add bit to the Module record for when modular codegen decls are included in the MODULAR_CODEGEN_DECLS bitcode record https://reviews.llvm.org/D28845 Files: include/clang/AST/ASTContext.h

Re: [PATCH] D28889: Change where we handle arg-dependent diagnose_if attributes

> Also, I plan to submit this (once it's LGTM'ed) to the 4.0 branch. Is that OK with you, Richard? (To be clear, I'll check with Hans before I submit this there, as well. Just trying to save a round-trip. :) ) On Mon, Jan 23, 2017 at 4:39 PM, George Burgess IV via Phabricator <

[PATCH] D28007: Switch TableGen to emit calls to ASTRecordReader for AttrPCHRead.

dlj updated this revision to Diff 85493. dlj added a comment. - Pull, merge, etc. https://reviews.llvm.org/D28007 Files: include/clang/Serialization/ASTReader.h lib/Serialization/ASTReaderDecl.cpp utils/TableGen/ClangAttrEmitter.cpp Index: utils/TableGen/ClangAttrEmitter.cpp

r292874 - Revert "[analyzer] Fix memory space of static locals seen from nested blocks."

Author: dcoughlin Date: Mon Jan 23 20:10:59 2017 New Revision: 292874 URL: http://llvm.org/viewvc/llvm-project?rev=292874=rev Log: Revert "[analyzer] Fix memory space of static locals seen from nested blocks." This reverts commit r292800. It is causing null pointer dereference false positives

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

joerg added a comment. I'm not terribly attached to using __ABICALLS__ for NetBSD, but let me check back with some of the MIPS folks. I would prefer __mips_abicalls to be always defined though, independent of the historic behavior. https://reviews.llvm.org/D29032

Re: [libcxx] r292833 - Manually force the use of __decltype in C++03 with Clang 3.4.

Sounds good to me. On Mon, Jan 23, 2017 at 1:56 PM, Eric Fiselier wrote: > This patch should be merge into 4.0 since it is needed to fix compile time > regressions in when using Clang 3.4 and C++03. > > See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216054 for more info. >

[PATCH] D28835: [coroutines] NFC: Refactor Sema::CoroutineBodyStmt construction.

GorNishanov updated this revision to Diff 85489. GorNishanov added a comment. No changes. Merge with top of the tree (to simplify comparing with the updated version that is coming up in a second). https://reviews.llvm.org/D28835 Files: include/clang/AST/StmtCXX.h

Re: [libcxx] r292822 - Fixed a typo in __config that prevented the aligned new/delete tests from passing on Mac OS.

r292869. On Mon, Jan 23, 2017 at 3:00 PM, Hans Wennborg wrote: > Ok, go ahead. > > On Mon, Jan 23, 2017 at 1:54 PM, Eric Fiselier wrote: > > This patch needs to get merged into 4.0 since the offending commit with > the > > misspelling is in the 4.0 branch. > >

[libcxx] r292869 - Merge r292822 - Fixed a typo in __config that prevented the aligned new/delete tests from passing on Mac OS.

Author: ericwf Date: Mon Jan 23 19:05:56 2017 New Revision: 292869 URL: http://llvm.org/viewvc/llvm-project?rev=292869=rev Log: Merge r292822 - Fixed a typo in __config that prevented the aligned new/delete tests from passing on Mac OS. Modified: libcxx/branches/release_40/include/__config

  1   2   >