[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:20-33 +static StringRef +makeDynamicExceptionString(const SourceManager &SM, + c

[PATCH] D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL292938: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer. (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D28667?vs=85014&id=85586#toc Repository: rL LL

[clang-tools-extra] r292938 - [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.

Author: xazax Date: Tue Jan 24 09:18:11 2017 New Revision: 292938 URL: http://llvm.org/viewvc/llvm-project?rev=292938&view=rev Log: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer. Fixes PR30964. The old behavior can be achieved using a setting. Patch by: Andras Leitereg

[PATCH] D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D28667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

emaste added a comment. In https://reviews.llvm.org/D29032#654854, @emaste wrote: > As mentioned in https://reviews.llvm.org/D29032 Err, that should be https://reviews.llvm.org/D29024 https://reviews.llvm.org/D29032 ___ cfe-commits mailing list c

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

emaste added a comment. As mentioned in https://reviews.llvm.org/D29032 I agree with @joerg - `__mips_abicalls` should always be defined if this is what GCC does. https://reviews.llvm.org/D29032 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D29084: [OpenMP] Codegen support for 'target teams' on the host.

arpith-jacob created this revision. This patch adds support for codegen of 'target teams' on the host. This combined directive has two captured statements, one for the 'teams' region, and the other for the 'parallel'. This target teams region is offloaded using the __tgt_target_teams() call. The

[PATCH] D28768: [clang-tidy] Add check 'modernize-return-braced-init-list'

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: test/clang-tidy/modernize-return-braced-init-list.cpp:150 +template +T f16() { + return T(); "With multiple instantiations" is an

[PATCH] D29067: IRGen: When loading the main module in the distributed ThinLTO backend, look for the module containing the summary.

tejohnson added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:867 +Expected clang::FindThinLTOModule(MemoryBufferRef MBRef) { + Expected> BMsOrErr = getBitcodeModuleList(MBRef); Would it be better to have this in llvm (e.g. in BitcodeReader li

[PATCH] D29082: [OpenMP] Support for the num_threads-clause on 'target parallel'.

arpith-jacob created this revision. The num_threads-clause on the combined directive applies to the 'parallel' region of this construct. We modify the NumThreadsClause class to capture the clause expression within the 'target' region. The offload runtime call for 'target parallel' is changed to

[PATCH] D29083: [OpenMP] Support for the num_threads-clause on 'target parallel' on the NVPTX device.

arpith-jacob created this revision. Herald added a subscriber: jholewinski. This patch adds support for the Spmd construct 'target parallel' on the NVPTX device. This involves ignoring the num_threads clause on the device since the number of threads in this combined construct is already set on th

[PATCH] D28981: Use GNU-style attributes for several __throw_XXX() functions

dim abandoned this revision. dim added a comment. Ok, back to Mozilla we go. https://reviews.llvm.org/D28981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28860: [OpenCL] Diagnose write_only image3d when extension is disabled

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D28860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D27257: [CodeCompletion] Ensure that ObjC root class completes instance methods from protocols and categories as well

This revision was automatically updated to reflect the committed changes. Closed by commit rL292932: [CodeCompletion] Ensure that ObjC root class completes instance (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D27257?vs=85400&id=85578#toc Repository: rL LLVM htt

[PATCH] D28510: Reinstate CWG1607 restrictions on lambdas appearing inside certain constant-expressions

faisalv added a comment. In https://reviews.llvm.org/D28510#653794, @rsmith wrote: > I don't think it's possible to check this in the way you're doing so here. In > general, there's no way to know whether a constant expression will be part of > a `typedef` declaration or function declaration un

[PATCH] D29031: [mips] Add support for static model on N64

seanbruno accepted this revision. seanbruno added a comment. This revision is now accepted and ready to land. From a "does this work" perspective, FreeBSD compiles are better now with this in place. Repository: rL LLVM https://reviews.llvm.org/D29031 __

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

seanbruno accepted this revision. seanbruno added a comment. This revision is now accepted and ready to land. FreeBSD is happy with this. https://reviews.llvm.org/D29032 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

r292932 - [CodeCompletion] Ensure that ObjC root class completes instance

Author: arphaman Date: Tue Jan 24 08:15:08 2017 New Revision: 292932 URL: http://llvm.org/viewvc/llvm-project?rev=292932&view=rev Log: [CodeCompletion] Ensure that ObjC root class completes instance methods from protocols and categories as well Code completion results for class methods already in

[PATCH] D28860: [OpenCL] Diagnose write_only image3d when extension is disabled

svenvh added a comment. In https://reviews.llvm.org/D28860#653662, @yaxunl wrote: > The tests should be added to SemaOpenCL/extension-version.cl SemaOpenCL/extension-version.cl already has a test for the cl_khr_3d_image_writes extension. Comment at: lib/Sema/SemaType.cpp:66

[PATCH] D28860: [OpenCL] Diagnose write_only image3d when extension is disabled

svenvh updated this revision to Diff 85575. svenvh edited the summary of this revision. svenvh added a comment. Removed the custom sema check and added the extension to the image type in OpenCLImageTypes.def. https://reviews.llvm.org/D28860 Files: include/clang/Basic/OpenCLImageTypes.def l

r292927 - [Sema] Fix assumption about typo corrections containing no decl.

Author: d0k Date: Tue Jan 24 06:49:59 2017 New Revision: 292927 URL: http://llvm.org/viewvc/llvm-project?rev=292927&view=rev Log: [Sema] Fix assumption about typo corrections containing no decl. This can happen when the typo correction is coming from an external sema source. Test case will follow

Re: [PATCH] D29063: [libcxx] Never use within libc++

Thanks for the lightening fast response :) / Asiri On Tue, Jan 24, 2017 at 12:38 PM, Eric Fiselier via Phabricator via cfe-commits wrote: > EricWF added a comment. > > It seems like weird usages of `_LIBCPP_ASSERT` in `` are > causing this problem. > Specifically the usages in `` attempt to use

[PATCH] D29027: [Stack Protection] Add remark for reasons why Stack Protection has been applied

jhenderson updated this revision to Diff 85570. jhenderson edited the summary of this revision. jhenderson added a comment. Thanks for the comments. I have updated the diff accordingly, by removing the unknown case, adding a check to distinguish between the function attribute and command-line sw

[PATCH] D26466: [clang-tidy] Fix NOLINT test

This revision was automatically updated to reflect the committed changes. Closed by commit rL292926: [clang-tidy] Fix NOLINT test (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D26466?vs=77378&id=85571#toc Repository: rL LLVM https://reviews.llvm.org/D26466 Files:

[clang-tools-extra] r292926 - [clang-tidy] Fix NOLINT test

Author: alexfh Date: Tue Jan 24 06:42:26 2017 New Revision: 292926 URL: http://llvm.org/viewvc/llvm-project?rev=292926&view=rev Log: [clang-tidy] Fix NOLINT test Summary: Test cases I've added in review D26218 were too brittle and weren't working properly. This patch fixes this. Reviewers: alex

[PATCH] D29077: [lsan] Enable LSan for x86 Linux.

m.ostapenko created this revision. m.ostapenko added a project: Sanitizers. This is a missed part of https://reviews.llvm.org/D28609. Enable LSan for x86 Linux in clang driver. Repository: rL LLVM https://reviews.llvm.org/D29077 Files: lib/Driver/ToolChains.cpp Index: lib/Driver/ToolCha

[PATCH] D29063: [libcxx] Never use within libc++

EricWF added a comment. It seems like weird usages of `_LIBCPP_ASSERT` in `` are causing this problem. Specifically the usages in `` attempt to use `_LIBCPP_ASSERT` in C++11 constexpr functions and this currently does not work. For now I've reverted this change in r292923. https://reviews.llv

[libcxx] r292923 - Revert "[libcxx] Never use within libc++"

Author: ericwf Date: Tue Jan 24 06:26:01 2017 New Revision: 292923 URL: http://llvm.org/viewvc/llvm-project?rev=292923&view=rev Log: Revert "[libcxx] Never use within libc++" This reverts commit r292883. Unfortunately uses _LIBCPP_ASSERT in a way which is not compatible with the C++11 dylib bui

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

krasimir added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1158-1159 +CommentPragmasRegex.match(Current.TokenText.substr(2)) || +Current.TokenText.substr(2).ltrim().startswith("clang-format on") || +Current.TokenText.substr(2).ltrim().

[PATCH] D29063: [libcxx] Never use within libc++

rmaprath added a comment. Sorry, I meant `-DLIBCXX_ENABLE_ASSERTIONS=ON`. https://reviews.llvm.org/D29063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29063: [libcxx] Never use within libc++

rmaprath added a comment. @EricWF: My downstream builds have `-DLLVM_ENABLE_ASSERTIONS=ON` by default and they are showing some failures after this commit. Log attached: F3019711: log.txt It should be pretty easy to reproduce these (I'm on Ubuntu 16.04) if yo

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

klimek added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1158-1159 +CommentPragmasRegex.match(Current.TokenText.substr(2)) || +Current.TokenText.substr(2).ltrim().startswith("clang-format on") || +Current.TokenText.substr(2).ltrim().st

[clang-tools-extra] r292918 - [clang-tidy] Avoid incorrect fixes in modernize-use-using

Author: alexfh Date: Tue Jan 24 05:41:02 2017 New Revision: 292918 URL: http://llvm.org/viewvc/llvm-project?rev=292918&view=rev Log: [clang-tidy] Avoid incorrect fixes in modernize-use-using Avoid fixes for typedefs with multiple types and for typedefs with struct definitions. Partially addresses

[clang-tools-extra] r292917 - [clang-tidy] Add more tests for modernize-use-using.

Author: alexfh Date: Tue Jan 24 05:40:23 2017 New Revision: 292917 URL: http://llvm.org/viewvc/llvm-project?rev=292917&view=rev Log: [clang-tidy] Add more tests for modernize-use-using. Modified: clang-tools-extra/trunk/test/clang-tidy/modernize-use-using.cpp Modified: clang-tools-extra/trun

r292914 - Replace use of chdir with llvm::sys::fs::set_current_path

Author: labath Date: Tue Jan 24 05:14:29 2017 New Revision: 292914 URL: http://llvm.org/viewvc/llvm-project?rev=292914&view=rev Log: Replace use of chdir with llvm::sys::fs::set_current_path NFCI Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Modified: cfe/trunk/lib/Basic/VirtualFileSy

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

krasimir updated this revision to Diff 85557. krasimir marked 3 inline comments as done. krasimir added a comment. - Address review comments. https://reviews.llvm.org/D28764 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/CMakeLists.txt lib/Format/Comments.cp

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

krasimir marked 3 inline comments as done. krasimir added inline comments. Comment at: lib/Format/BreakableToken.h:55-56 +/// been reformatted, and +/// - replaceWhitespaceBefore, for executing the reflow using a whitespace +/// manager. +/// klimek wrote: >

[PATCH] D21675: New ODR checker for modules

teemperor added a comment. I feel like we have a really similar use case in the Analysis/CloneDetection{.h/.cpp} with the hashing of statements. I tried substituting the call to the statement hashing with a call to the CloneDetection API and it seems that most tests pass and the remaining fails

[libcxx] r292908 - Revert yet another accidental change caused by r292684

Author: ericwf Date: Tue Jan 24 04:38:46 2017 New Revision: 292908 URL: http://llvm.org/viewvc/llvm-project?rev=292908&view=rev Log: Revert yet another accidental change caused by r292684 Modified: libcxx/trunk/test/libcxx/test/config.py Modified: libcxx/trunk/test/libcxx/test/config.py URL:

[libcxxabi] r292906 - Remove all usages of REQUIRES-ANY in the test suite.

Author: ericwf Date: Tue Jan 24 04:28:23 2017 New Revision: 292906 URL: http://llvm.org/viewvc/llvm-project?rev=292906&view=rev Log: Remove all usages of REQUIRES-ANY in the test suite. Pending LIT changes are about to remove the REQUIRES-ANY keyword in place of supporting boolean && and || withi

[libcxx] r292905 - Fix bad XFAIL which recent LIT changes diagnosed

Author: ericwf Date: Tue Jan 24 04:19:32 2017 New Revision: 292905 URL: http://llvm.org/viewvc/llvm-project?rev=292905&view=rev Log: Fix bad XFAIL which recent LIT changes diagnosed Modified: libcxx/trunk/test/std/utilities/meta/meta.unary.prop.query/void_t.pass.cpp Modified: libcxx/trunk/t

[libcxx] r292901 - Remove all usages of REQUIRES-ANY in the test suite.

Author: ericwf Date: Tue Jan 24 03:11:08 2017 New Revision: 292901 URL: http://llvm.org/viewvc/llvm-project?rev=292901&view=rev Log: Remove all usages of REQUIRES-ANY in the test suite. Pending LIT changes are about to remove the REQUIRES-ANY keyword in place of supporting boolean && and || withi

r292898 - Revert "[test] Replace `REQUIRES-ANY: a, b, c` with `REQUIRES: a || b || c`."

Author: gparker Date: Tue Jan 24 02:57:17 2017 New Revision: 292898 URL: http://llvm.org/viewvc/llvm-project?rev=292898&view=rev Log: Revert "[test] Replace `REQUIRES-ANY: a, b, c` with `REQUIRES: a || b || c`." The underlying `lit` change needs to be better-coordinated with libc++. Modified:

r292897 - [test] Replace `REQUIRES-ANY: a, b, c` with `REQUIRES: a || b || c`.

Author: gparker Date: Tue Jan 24 02:47:25 2017 New Revision: 292897 URL: http://llvm.org/viewvc/llvm-project?rev=292897&view=rev Log: [test] Replace `REQUIRES-ANY: a, b, c` with `REQUIRES: a || b || c`. Requires the new `lit` boolean expressions in LLVM r292896. Modified: cfe/trunk/test/Driv

<    1   2