[PATCH] D31019: [clangd] [RFC] Use libclang and CXTranslationUnit instead of ASTUnit

2017-03-16 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer resigned from this revision. bkramer added a comment. It's not. the goal is to get rid of ASTUnit inside of clangd in the long term as it's a big problem for extensibility. libclang is just a wrapper for ASTUnit, with even more problems. If you want to get completion running, just call

[PATCH] D28136: [OpenCL] Implement as_type operator as alias of __builtin_astype.

2017-03-16 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Comment at: lib/Headers/opencl-c.h:6588 -char __ovld __cnfn as_char(char); -char __ovld __cnfn as_char(uchar); - bader wrote: > Anastasia

[PATCH] D30810: Preserve vec3 type.

2017-03-16 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In https://reviews.llvm.org/D30810#702443, @bruno wrote: > > As a result, I think it would be good for clang to have both of features > > and I would like to stick to the option "-fpresereve-vec3' to change the > > behavior easily. > > The motivation doesn't seem soli

[PATCH] D30932: [clang-format] disabled adding extra space after MSVC '__super' keyword

2017-03-16 Thread Martin Probst via Phabricator via cfe-commits
mprobst added a comment. @jutocz done, thanks for the patch! Repository: rL LLVM https://reviews.llvm.org/D30932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r297936 - [clang-format] disable adding extra space after MSVC '__super' keyword

2017-03-16 Thread Martin Probst via cfe-commits
Author: mprobst Date: Thu Mar 16 05:21:35 2017 New Revision: 297936 URL: http://llvm.org/viewvc/llvm-project?rev=297936&view=rev Log: [clang-format] disable adding extra space after MSVC '__super' keyword clang-format treats MSVC `__super` keyword like all other keywords adding a single space aft

[PATCH] D30932: [clang-format] disabled adding extra space after MSVC '__super' keyword

2017-03-16 Thread Martin Probst via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL297936: [clang-format] disable adding extra space after MSVC '__super' keyword (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D30932?vs=91733&id=91982#toc Repository: rL LLV

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

2017-03-16 Thread Paulo Matos via Phabricator via cfe-commits
pmatos updated this revision to Diff 91980. pmatos marked an inline comment as done. https://reviews.llvm.org/D27800 Files: include/clang/Sema/Sema.h lib/Sema/SemaExpr.cpp test/SemaCXX/pr31042.cpp Index: test/SemaCXX/pr31042.cpp

[PATCH] D30931: [clang-tidy] added new identifier naming case type for ignoring case style

2017-03-16 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. In https://reviews.llvm.org/D30931#702578, @jutocz wrote: > You are right, it does look misleading. I'll try to modify it the way you > suggest (though I'm new to LLVM, so be ready to give me more comments;) Sure, thank you for the work! https://reviews.llvm.org/D3093

[PATCH] D30977: [CodeGen] Emit a CoreFoundation link guard when @available is used

2017-03-16 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 91977. arphaman marked an inline comment as done. arphaman added a comment. The guard function is now `hidden`. I also adopted linker options as John suggested. Repository: rL LLVM https://reviews.llvm.org/D30977 Files: lib/CodeGen/CGObjC.cpp lib/C

[PATCH] D30931: [clang-tidy] added new identifier naming case type for ignoring case style

2017-03-16 Thread Juliusz Toczydłowski via Phabricator via cfe-commits
jutocz added a comment. You are right, it does look misleading. I'll try to modify it the way you suggest (though I'm new to LLVM, so be ready to give me more comments;). https://reviews.llvm.org/D30931 ___ cfe-commits mailing list cfe-commits@list

r297931 - clang-format: Fix bug in wrapping behavior of operators.

2017-03-16 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Thu Mar 16 02:54:11 2017 New Revision: 297931 URL: http://llvm.org/viewvc/llvm-project?rev=297931&view=rev Log: clang-format: Fix bug in wrapping behavior of operators. Before (even violating the column limit): auto Diag = diag() << (aaa

<    1   2