[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

teemperor marked an inline comment as done. teemperor added a comment. Well this patch won't change a lot with the false-positives or performance (it's more refactoring) :) https://reviews.llvm.org/D23418 ___ cfe-commits mailing list cfe-commits@li

r298905 - FileManager: mark virtual file entries as valid entries

Author: erikjv Date: Tue Mar 28 04:18:05 2017 New Revision: 298905 URL: http://llvm.org/viewvc/llvm-project?rev=298905&view=rev Log: FileManager: mark virtual file entries as valid entries The getVirtualFile method would create entries for e.g. libclang's CXUnsavedFile but not mark them as valid.

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

xiangzhai added a comment. Hi Raphael, Thanks for your reply! > regarding performance: Last time I checked we spend most of the time on the > verification of the hash values. We can do some tricks to make this faster > (like delaying the verification to the end of the constraints where we have

[PATCH] D27810: FileManager: mark virtual file entries as valid entries

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D27810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D27810: FileManager: mark virtual file entries as valid entries

erikjv updated this revision to Diff 93221. erikjv added a comment. Added a test for the specific scenario, and added asserts for validity of UFEs returned by getVirtualFile. https://reviews.llvm.org/D27810 Files: lib/Basic/FileManager.cpp unittests/Basic/FileManagerTest.cpp Index: unitte

[PATCH] D31370: [clang-tidy] Prototype to check for exception specification

JonasToth marked an inline comment as done. JonasToth added inline comments. Comment at: clang-tidy/modernize/NoexceptCorrectnessCheck.cpp:60 + N.getNodeAs("direct_throwing_decl")) { +// FIXME how is that done? i did not find a noThrow predicate +//if (ThrowingDe

[PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

chrib added a comment. Yes we can enable cantunwind with the nothrow gcc attribute when exceptions are enabled Forcing it in exceptions are not enabled (e.g for attribute cleanup) would require -funwind-tables at function level anyway So the flag should work, but conceptually I think you are ri

[PATCH] D31370: [clang-tidy] Prototype to check for exception specification

JonasToth planned changes to this revision. JonasToth marked 2 inline comments as done. JonasToth added a comment. commented review Comment at: clang-tidy/modernize/NoexceptCorrectnessCheck.cpp:60 + N.getNodeAs("direct_throwing_decl")) { +// FIXME how is that done?

[PATCH] D30248: [libclang] Fix crash in member access code completion with implicit base

erikjv closed this revision. erikjv added a comment. Landed as r298903. https://reviews.llvm.org/D30248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r298903 - [libclang] Fix crash in member access code completion with implicit base

Author: erikjv Date: Tue Mar 28 02:22:21 2017 New Revision: 298903 URL: http://llvm.org/viewvc/llvm-project?rev=298903&view=rev Log: [libclang] Fix crash in member access code completion with implicit base If there is an unresolved member access AST node, and the base is implicit, do not access/u

<    1   2