RE: r299355 - [ASTImporter] Fix for importing unnamed structs

Hi Peter and Gabor, This change is causing a failure of the test "Clang :: ASTMerge/struct/test.c" on the PS4 Windows bot: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/7609 FAIL: Clang :: ASTMerge/struct/test.c (18568 of 32374)

[PATCH] D31447: [Driver] Add option to print the resource directory

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. One minor nitpick on the test case, but otherwise this looks fine to me. Comment at: test/Driver/immediate-options.c:19 +// RUN: %clang -print-resource-dir | FileCheck %s

[PATCH] D31394: [X86][Clang] Converting __mm{|256|512}_movm_epi{8|16|32|64} LLVMIR call into generic intrinsics.

m_zuckerman added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:7176 + return CGF.Builder.CreateSExt( + Mask, llvm::VectorType::get(IT, NumberOfElements), "vpmovm2"); +} craig.topper wrote: > Why can't we just use DstTy here to create the SExt?

[PATCH] D31394: [X86][Clang] Converting __mm{|256|512}_movm_epi{8|16|32|64} LLVMIR call into generic intrinsics.

craig.topper added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:7176 + return CGF.Builder.CreateSExt( + Mask, llvm::VectorType::get(IT, NumberOfElements), "vpmovm2"); +} m_zuckerman wrote: > craig.topper wrote: > > Why can't we just use DstTy

[libunwind] r299381 - Try to trigger the new docs builder. NFC

Author: jroelofs Date: Mon Apr 3 14:23:11 2017 New Revision: 299381 URL: http://llvm.org/viewvc/llvm-project?rev=299381=rev Log: Try to trigger the new docs builder. NFC Modified: libunwind/trunk/docs/index.rst Modified: libunwind/trunk/docs/index.rst URL:

[PATCH] D30435: [clang-import-test] Lookup inside entities

spyffe updated this revision to Diff 93927. spyffe added a comment. Herald added a subscriber: mgorny. • Broke all the `ASTImporter` and `ExternalASTSource` subclassing logic into its own source file, with its API defined in `AST/ExternalASTMerger.h`. • Cleaned up the API for LLDB's consumption:

[PATCH] D30920: Do not pass -Os and -Oz to the Gold plugin

pirama added a comment. From the discussion, it seems it is theoretically feasible to make optimization for speed a function-level attribute as well. After looking at the PassMangerBuilder for this bug, I think that'll make the optimization passes cleaner by keeping the passes and their

[PATCH] D31487: [coroutines] Fix rebuilding of implicit and dependent coroutine statements.

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM with nits addressed https://reviews.llvm.org/D31487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r299380 - [coroutines] Fix rebuilding of implicit and dependent coroutine statements.

Author: ericwf Date: Mon Apr 3 14:21:00 2017 New Revision: 299380 URL: http://llvm.org/viewvc/llvm-project?rev=299380=rev Log: [coroutines] Fix rebuilding of implicit and dependent coroutine statements. Summary: Certain implicitly generated coroutine statements, such as the calls to

[PATCH] D30435: [clang-import-test] Lookup inside entities

spyffe updated this revision to Diff 93929. spyffe added a comment. Added the `ExternalASTMerger` implementation/interface, which I hadn't `svn add`ed before generating the last diff. Repository: rL LLVM https://reviews.llvm.org/D30435 Files: include/clang/AST/ExternalASTMerger.h

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D31404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxx] r299385 - suppress GCC warning about noexcept functions changing mangling

On 3 April 2017 at 13:53, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Mon Apr 3 15:53:15 2017 > New Revision: 299385 > > URL: http://llvm.org/viewvc/llvm-project?rev=299385=rev > Log: > suppress GCC warning about noexcept functions changing

r299397 - Recommit r299321 '[X86] Add __extension__ to f16c macro intrinsics to suppress warnings about compound literals when compiled for with earlier language standards enabled.'

Author: ctopper Date: Mon Apr 3 17:59:30 2017 New Revision: 299397 URL: http://llvm.org/viewvc/llvm-project?rev=299397=rev Log: Recommit r299321 '[X86] Add __extension__ to f16c macro intrinsics to suppress warnings about compound literals when compiled for with earlier language standards

Re: [libcxx] r299385 - suppress GCC warning about noexcept functions changing mangling

I'll create a reduced reproducer, but it'll take some time because GCC is quite cryptic about the instantiation stack. if you want many instances within the libc++ build simply revert this commit and build with a new GCC. /Eric ___ cfe-commits mailing

<    1   2