[PATCH] D31745: [OpenCL] Added diagnostic for implicit declaration of function in OpenCL

2017-04-10 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8254 "%0 cannot be used as the type of a kernel parameter">; +def err_opencl_implicit_function_decl : Error< + "implicit declaration of function %0 is invalid in OpenCL">;

[PATCH] D31885: Remove TBAA information from LValues representing union members

2017-04-10 Thread wenzel.ja...@epfl.ch via Phabricator via cfe-commits
wjakob added a comment. Disclaimer: I am not an LLVM developer. Just looking at the patch, I wonder if it could be much less intrusive if `LValue CodeGenFunction::EmitLValue(const Expr *E)` is split into two methods -- a private one, and a public-facing one that applies your `ClearTBAA`

[clang-tools-extra] r299854 - [clangd] Relax absolute path checking assertion

2017-04-10 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Apr 10 12:03:44 2017 New Revision: 299854 URL: http://llvm.org/viewvc/llvm-project?rev=299854=rev Log: [clangd] Relax absolute path checking assertion clangd can process absolute paths from systems that don't use the native path style, so this assertion needs to check both

[clang-tools-extra] r299850 - Revert "XFAIL clangd tests on Windows"

2017-04-10 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Apr 10 11:55:48 2017 New Revision: 299850 URL: http://llvm.org/viewvc/llvm-project?rev=299850=rev Log: Revert "XFAIL clangd tests on Windows" This reverts r299849, apparently these tests only fail on my machine. Modified:

[clang-tools-extra] r299849 - XFAIL clangd tests on Windows

2017-04-10 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Apr 10 11:50:55 2017 New Revision: 299849 URL: http://llvm.org/viewvc/llvm-project?rev=299849=rev Log: XFAIL clangd tests on Windows They all assert. Filed as PR32596. Modified: clang-tools-extra/trunk/test/clangd/completion.test

[clang-tools-extra] r299844 - [clangd] Fix nondeterminism in clangd test

2017-04-10 Thread Krasimir Georgiev via cfe-commits
Author: krasimir Date: Mon Apr 10 09:06:54 2017 New Revision: 299844 URL: http://llvm.org/viewvc/llvm-project?rev=299844=rev Log: [clangd] Fix nondeterminism in clangd test Modified: clang-tools-extra/trunk/test/clangd/diagnostics.test Modified:

[clang-tools-extra] r299843 - [clangd] Remove ASTUnits for closed documents and cache CompilationDatabase per directory.

2017-04-10 Thread Krasimir Georgiev via cfe-commits
Author: krasimir Date: Mon Apr 10 08:31:39 2017 New Revision: 299843 URL: http://llvm.org/viewvc/llvm-project?rev=299843=rev Log: [clangd] Remove ASTUnits for closed documents and cache CompilationDatabase per directory. Contributed by ilya-biryukov! Differential Revision:

Re: r299774 - Sema: prevent __declspec(naked) use on x64

2017-04-10 Thread Aaron Ballman via cfe-commits
On Fri, Apr 7, 2017 at 4:48 PM, Saleem Abdulrasool wrote: > Yeah, I shouldn't write commit messages late at night (I didn't commit until > the morning to keep an eye on the bots). Also, if you're going to make a change that might break users, having a review for that

<    1   2