Re: [PATCH] D31591: Fix a bug which access nullptr and cause segmentation fault

It seems to me the test have already been simplified enough, so I'm not quite sure what you are trying to do more than this. Isn't this just ready to submit? On Wed, Apr 12, 2017 at 5:46 PM, Yuka Takahashi via Phabricator < revi...@reviews.llvm.org> wrote: > yamaguchi updated this revision to Dif

Re: [PATCH] [PPC64]: Add support for Swift calling convention

On Wed, 2017-04-12 at 14:01 -0700, Adrian Prantl wrote: > Is it possible to add a testcase for this? I will look into it. Thanks for the review! Andrew > > -- adrian > > > > On Mar 22, 2017, at 5:00 AM, Andrew Jeffery via cfe-commits > > wrote: > > > > > > Signed-off-by: Andrew Jeffery >

[PATCH] D31887: [clangd] Add documentation page

malaperle-ericsson updated this revision to Diff 95078. malaperle-ericsson added a comment. Fix mention of "extra Clang tools" https://reviews.llvm.org/D31887 Files: docs/clangd.rst docs/index.rst Index: docs/index.rst === ---

[PATCH] D30837: [libcxx] Support for shared_ptr

EricWF added a comment. - Please apply this patch on top of yours. It adds tests for the diagnostics produced when the default deleter is used. LGTM other than the inline comments. I'll want to run this by @mclow.lists before g

[PATCH] D31769: Remove the binders `bind1st`, `bind2nd`, `men_fun`, etc from C++17

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. The `.fail.cpp` tests should use `// UNSUPPORTED: c++98, c++03, c++11, c++14` instead of `#error `. Other than that this LGTM. Comment at: test/std/depr/depr.function.obje

[libcxx] r300175 - Cleanup any_cast failure test

Author: ericwf Date: Thu Apr 13 00:27:55 2017 New Revision: 300175 URL: http://llvm.org/viewvc/llvm-project?rev=300175&view=rev Log: Cleanup any_cast failure test Modified: libcxx/trunk/test/std/utilities/any/any.nonmembers/any.cast/reference_types.fail.cpp Modified: libcxx/trunk/test/std/

Re: r300122 - [clang-cl] Make all sanitizer flags available in clang-cl

I think this broke some of the bots. http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/30152/ Could you take a look? > On Apr 12, 2017, at 3:50 PM, Reid Kleckner via cfe-commits > wrote: > > Author:

[PATCH] D31561: cmath: Skip Libc for integral types in isinf, etc.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM minus inline comments. Comment at: libcxx/include/math.h:354 inline _LIBCPP_INLINE_VISIBILITY -typename std::enable_if::value, bool>::type +typename std::enable_if::val

[PATCH] D26830: [libcxx] Add string_view literals

EricWF added inline comments. Comment at: test/std/strings/string.view/string.view.literals/literal2.pass.cpp:16 + +int main() +{ EricWF wrote: > What's the point of this test that `literal.pass.cpp` doesn't cover? Ping on this comment. Commen

[PATCH] D26830: [libcxx] Add string_view literals

EricWF added a comment. @AntonBikineev Yeah, this should be abandoned. Sorry my mistake. https://reviews.llvm.org/D26830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24371: Add diagnostics to require_constant_initialization

EricWF added a comment. @rsmith gentle ping. Repository: rL LLVM https://reviews.llvm.org/D24371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31725: [libc++] Add _LIBCPP_DISABLE_EXTERN_TEMPLATE config option

EricWF added a comment. Please add docs to http://libcxx.llvm.org/docs/UsingLibcxx.html#libc-configuration-macros https://reviews.llvm.org/D31725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D31725: [libc++] Add _LIBCPP_DISABLE_EXTERN_TEMPLATE config option

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM minus doc. https://reviews.llvm.org/D31725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

<    1   2