[PATCH] D32298: [clang-format] Turn IncompleteFormat into a string

krasimir updated this revision to Diff 96113. krasimir added a comment. - Address review comments https://reviews.llvm.org/D32298 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/UnwrappedLineFormatter.cpp lib/Format/UnwrappedLineFormatter.h

[PATCH] D32342: Fixed llvm/CMakeLists.txt which doesn't generate proper MakeFiles and added relative path to llvm doxygen

yamaguchi created this revision. Herald added a subscriber: mgorny. Fist part is to change CMakeLists.txt and doxygen.cfg.in by following reasons: In llvm/docs/CmakeLists.txt, it was - set(abs_top_srcdir ${LLVM_MAIN_SRC_DIR}) - set(abs_top_builddir ${LLVM_BINARY_DIR}) However,

[PATCH] D30773: Make git-clang-format python 3 compatible

jbcoe accepted this revision. jbcoe added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D30773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32298: [clang-format] Turn IncompleteFormat into a string

krasimir added inline comments. Comment at: lib/Format/UnwrappedLineFormatter.cpp:845 + if (!Invalid) +os << " This might be due to a syntax error at line " << LineNumber + << "."; djasper wrote: > I wonder whether this might be confusing

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

chrib added inline comments. Comment at: test/CodeGen/arm-fp-eabi.c:1 +// RUN: %clang %s -target arm-none-eabi -O2 -S -o nofp.s +// RUN: not grep '.setfp' nofp.s ahatanak wrote: > Instead of generating a .s file and looking for ".setfp", you can pass -### > and

[PATCH] D32298: [clang-format] Turn IncompleteFormat into a string

krasimir updated this revision to Diff 96115. krasimir marked an inline comment as done. krasimir added a comment. - Removed double declaration https://reviews.llvm.org/D32298 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/UnwrappedLineFormatter.cpp

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

chrib updated this revision to Diff 96109. chrib added a comment. - Check not mdisable-fp-elim for arm eabi when optimizing https://reviews.llvm.org/D31972 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/frame-pointer.c Index: test/Driver/frame-pointer.c

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

danielmarjamaki added a comment. I don't have further comments except that I would personally rewrite: // Get the value of the size argument. SVal TotalSize = State->getSVal(Arg1, LCtx); if (SuffixWithN) { const Expr *Arg2 = CE->getArg(2); TotalSize = evalMulForBufferSize(C, Arg1,

[PATCH] D32298: [clang-format] Turn IncompleteFormat into a string

djasper added inline comments. Comment at: include/clang/Format/Format.h:1527 +/// non-recoverable syntax error. tooling::Replacements reformat(const FormatStyle , StringRef Code, ArrayRef Ranges, This is a public interface

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai added a comment. Never mind :) Repository: rL LLVM https://reviews.llvm.org/D30771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

yamaguchi created this revision. This is a patch for bug [1] Warnings should not be emitted with -M and -MM flags, because this mode is only used for generate MakeFiles. [1]: https://bugs.llvm.org/show_bug.cgi?id=6817 https://reviews.llvm.org/D32341 Files: lib/Driver/ToolChains/Clang.cpp

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai updated this revision to Diff 96101. xiangzhai added a comment. Further reduce redundant code. Repository: rL LLVM https://reviews.llvm.org/D30771 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/gmalloc.c Index: test/Analysis/gmalloc.c

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

danielmarjamaki added a comment. you can ignore my comment ... LGTM I don't want to accept this revision. Hopefully NoQ or somebody else can do that. Repository: rL LLVM https://reviews.llvm.org/D30771 ___ cfe-commits mailing list

[PATCH] D32346: [clang-tidy] New readability check for strlen argument

danielmarjamaki created this revision. Herald added a subscriber: mgorny. I propose this new readability checker. Repository: rL LLVM https://reviews.llvm.org/D32346 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

hfinkel added a comment. In https://reviews.llvm.org/D32199#732737, @rsmith wrote: > In https://reviews.llvm.org/D32199#732189, @hfinkel wrote: > > > In https://reviews.llvm.org/D32199#731472, @rsmith wrote: > > > > > 1. C's "effective type" rule allows writes to set the type pretty much > > >

[PATCH] D32347: Add support for openSUSE ARM Triples

ismail added a comment. In https://reviews.llvm.org/D32347#733476, @rengolin wrote: > In https://reviews.llvm.org/D32347#733475, @ismail wrote: > > > Yes openSUSE prefers the "hl" prefix to mean HardFloat. > > > I'm not sure that'll do what you expect it, though. Having the "hf" at the > end of

[PATCH] [libclang] Check for a record declaration before a template specialization.

This allows us to get the default template parameters too. This patch was submitted also as https://reviews.llvm.org/D31732, but I see no reference to it in cfe-commits or llvm-commits, so I guess it got lost? This fixes bug 32539. Signed-off-by: Emilio Cobos Álvarez ---

[PATCH] D32347: Add support for openSUSE ARM Triples

rengolin added a comment. Nothing new here, pretty much standard. No "gnueabihf"? https://reviews.llvm.org/D32347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32298: [clang-format] Turn IncompleteFormat into a string

krasimir updated this revision to Diff 96120. krasimir added a comment. - Introduce a proper abstraction https://reviews.llvm.org/D32298 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/UnwrappedLineFormatter.cpp lib/Format/UnwrappedLineFormatter.h

[PATCH] D25113: [Sema] Don't display an invalid redefinition error when dealing with a redefinition of a function whose previous definition was typo-corrected

arphaman updated this revision to Diff 96123. arphaman added reviewers: ahatanak, v.g.vassilev. arphaman added a comment. Rebased the patch. Repository: rL LLVM https://reviews.llvm.org/D25113 Files: include/clang/Sema/Sema.h lib/Sema/SemaDecl.cpp test/SemaCXX/typo-correction.cpp

[PATCH] D32342: Fixed llvm/CMakeLists.txt which doesn't generate proper MakeFiles and added relative path to llvm doxygen

teemperor added a comment. I think most of the changes are just necessary because we replaced `LLVM_MAIN_SRC_DIR` with `CMAKE_SOURCE_DIR` (all the added `../` and removed `docs`). On the other hand this is now in sync with the way the the clang doxygen.cfg is structured and it fixes the

[PATCH] D25051: Fix PR 10758: Infinite recursion when dealing with copy-initialization

arphaman updated this revision to Diff 96122. arphaman added reviewers: ahatanak, v.g.vassilev. arphaman added a comment. Rebased the patch. Repository: rL LLVM https://reviews.llvm.org/D25051 Files: include/clang/Sema/Sema.h lib/Sema/SemaInit.cpp

[PATCH] D32298: [clang-format] Replace IncompleteFormat by a struct with Line

djasper added inline comments. Comment at: include/clang/Format/Format.h:1519 + /// formatted due to a non-recoverable syntax error. + bool IncompleteFormat = false; + Maybe we should invert this and make this FormatComplete or something? Otherwise this is

[PATCH] D32347: Add support for openSUSE ARM Triples

ismail added a comment. In https://reviews.llvm.org/D32347#733474, @rengolin wrote: > Nothing new here, pretty much standard. No "gnueabihf"? Yes openSUSE prefers the "hl" prefix to mean HardFloat. https://reviews.llvm.org/D32347 ___ cfe-commits

[PATCH] D32347: Add support for openSUSE ARM Triples

rengolin added reviewers: rovka, compnerd. rengolin added a comment. In https://reviews.llvm.org/D32347#733475, @ismail wrote: > Yes openSUSE prefers the "hl" prefix to mean HardFloat. I'm not sure that'll do what you expect it, though. Having the "hf" at the end of the triple has some

[PATCH] D31975: [Analyzer] Iterator Checkers

NoQ added a comment. I had a look at how hard it is to split the patch. In ~3 hours i reached this far: F3239478: 0001-Delete-the-old-checker.patch F3239481: 0002-Reduced-patch-with-the-following-changes.patch F3239475:

[PATCH] D32346: [clang-tidy] New readability check for strlen argument

JonasToth added a comment. My thoughts on the check added. Have you run it over a big codebase? What is the turnout? Comment at: clang-tidy/readability/StrlenArgumentCheck.cpp:23 + Finder->addMatcher( + callExpr(callee(functionDecl(hasName("strlen"))), +

[PATCH] D32347: Add support for openSUSE ARM Triples

ismail created this revision. Herald added a subscriber: aemerson. Add support for armv6hl-suse-linux-gnueabi and armv7hl-suse-linux-gnueabi triples used by openSUSE/SUSE. https://reviews.llvm.org/D32347 Files: lib/Driver/ToolChains/Gnu.cpp

[PATCH] D32347: Add support for openSUSE ARM Triples

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. Ok, I see no harm in letting you work upstream, since no one should be relying on the correct behaviour on opensuse for now. LGTM. Thanks! https://reviews.llvm.org/D32347

r300969 - Add support for openSUSE ARM Triples

Author: ismail Date: Fri Apr 21 07:26:43 2017 New Revision: 300969 URL: http://llvm.org/viewvc/llvm-project?rev=300969=rev Log: Add support for openSUSE ARM Triples Summary: Add support for armv6hl-suse-linux-gnueabi and armv7hl-suse-linux-gnueabi triples used by openSUSE/SUSE. Reviewers:

[PATCH] D32342: Changed llvm/CMakeLists.txt and added relative path to llvm doxygen

yamaguchi updated this revision to Diff 96124. yamaguchi retitled this revision from "Fixed llvm/CMakeLists.txt which doesn't generate proper MakeFiles and added relative path to llvm doxygen" to "Changed llvm/CMakeLists.txt and added relative path to llvm doxygen". yamaguchi added a comment.

[PATCH] D32348: [libclang] Check for a record declaration before a template specialization.

arphaman added a comment. Please post the diff with full context (git diff -U). Repository: rL LLVM https://reviews.llvm.org/D32348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32298: [clang-format] Replace IncompleteFormat by a struct with Line

krasimir updated this revision to Diff 96129. krasimir marked 5 inline comments as done. krasimir added a comment. - Changed IncompleteFormat to FormatComplete https://reviews.llvm.org/D32298 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/UnwrappedLineFormatter.cpp

[PATCH] D32351: [Tooling, libclang] Remove unused CompilationDatabase::MappedSources

krasimir created this revision. Herald added a subscriber: klimek. This field is never assigned to and it's only ever read from libclang. This patch removes it and adapts libclang to return constants. https://reviews.llvm.org/D32351 Files: include/clang/Tooling/CompilationDatabase.h

Re: [PATCH] [libclang] Check for a record declaration before a template specialization.

Hi, On 21 April 2017 at 12:55, Emilio Cobos Álvarez via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This allows us to get the default template parameters too. > > This patch was submitted also as https://reviews.llvm.org/D31732, but I > see no > reference to it in cfe-commits or

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

hfinkel updated this revision to Diff 96135. hfinkel retitled this revision from "[TBAASan] A TBAA Sanitizer (Clang)" to "[TySan] A Type Sanitizer (Clang)". hfinkel edited the summary of this revision. hfinkel added a comment. Rename TBAASanitizer -> TypeSanitizer

Re: [PATCH] [libclang] Check for a record declaration before a template specialization.

On Fri, Apr 21, 2017 at 01:49:24PM +0100, Alex L wrote: > Hi, > > On 21 April 2017 at 12:55, Emilio Cobos Álvarez via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > This allows us to get the default template parameters too. > > > > This patch was submitted also as

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

sanwou01 added a comment. Thanks for your comments Reid. Please find my responses inline. I'll spin a new patch addressing your comments soonish. Comment at: include/clang/Basic/SourceLocation.h:336 + bool hasManager() const { return SrcMgr != nullptr; } /// \pre This

[PATCH] D32348: [libclang] Check for a record declaration before a template specialization.

emilio created this revision. emilio added a project: clang-c. This allows us to see the default template parameters too. This is a regression in clang 4.0, so uplifting to a dot release would be neat (but not required, I guess). The regression was caused by https://reviews.llvm.org/D26663.

[PATCH] D32342: Changed llvm/CMakeLists.txt and added relative path to llvm doxygen

yamaguchi updated this revision to Diff 96128. yamaguchi added a comment. Modified README.txt. I thought its good to specify where the html is. https://reviews.llvm.org/D32342 Files: docs/CMakeLists.txt docs/README.txt docs/doxygen.cfg.in Index: docs/doxygen.cfg.in

[PATCH] D32348: [libclang] Check for a record declaration before a template specialization.

emilio updated this revision to Diff 96130. emilio added a comment. Full diff, thanks @arphaman :) https://reviews.llvm.org/D32348 Files: clang/test/Index/print-type.cpp clang/tools/libclang/CXType.cpp Index: clang/tools/libclang/CXType.cpp

[PATCH] D32298: [clang-format] Replace IncompleteFormat by a struct with Line

krasimir updated this revision to Diff 96131. krasimir added a comment. - Refactor tests https://reviews.llvm.org/D32298 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/UnwrappedLineFormatter.cpp lib/Format/UnwrappedLineFormatter.h test/Format/incomplete.cpp

[PATCH] D32298: [clang-format] Replace IncompleteFormat by a struct with Line

krasimir added inline comments. Comment at: include/clang/Format/Format.h:1524 + /// best-effort analysis, and could be imprecise. + unsigned Line = 0; +}; djasper wrote: > Hm. Something we might need to be thinking about here is whether this should > be the

Re: [llvm-dev] Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

Hi, Fragmentation of the bots is not ideal. While I totally understand Eric's reasoning for doing so, and am delighted to see another Windows bot helping to ensure quality code, I think this is a bit of a slippery slope. We already have the main Buildbots, Green Dragon, Chapuni's Bots, a myriad

[PATCH] D32350: [Analyzer] Exception Checker

baloghadamsoftware created this revision. Herald added a subscriber: mgorny. This is an old checker used only internally until now. The original author is Bence Babati, I added him as a subscriber. The checker checks whather exceptions escape the main() function, destructors. functions with

[PATCH] D32238: [Clangd] Failed to decode params using 1.x-compatible request message

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D32238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r300981 - [PR32667] -Wdocumentation should allow @param/@returns for fields/variables

Author: arphaman Date: Fri Apr 21 09:17:49 2017 New Revision: 300981 URL: http://llvm.org/viewvc/llvm-project?rev=300981=rev Log: [PR32667] -Wdocumentation should allow @param/@returns for fields/variables that have a function/block pointer type This commit improves the -Wdocumentation warning

r300983 - [clang-format] Clang-tidy cleanup of NamespaceEndCommentFixerTest.cpp, NFC

Author: krasimir Date: Fri Apr 21 09:30:01 2017 New Revision: 300983 URL: http://llvm.org/viewvc/llvm-project?rev=300983=rev Log: [clang-format] Clang-tidy cleanup of NamespaceEndCommentFixerTest.cpp, NFC Modified: cfe/trunk/unittests/Format/NamespaceEndCommentsFixerTest.cpp Modified:

r300985 - [clang-format] Replace IncompleteFormat by a struct with Line

Author: krasimir Date: Fri Apr 21 09:35:20 2017 New Revision: 300985 URL: http://llvm.org/viewvc/llvm-project?rev=300985=rev Log: [clang-format] Replace IncompleteFormat by a struct with Line Summary: This patch replaces the boolean IncompleteFormat that is used to notify the client if an

[PATCH] D32298: [clang-format] Replace IncompleteFormat by a struct with Line

This revision was automatically updated to reflect the committed changes. Closed by commit rL300985: [clang-format] Replace IncompleteFormat by a struct with Line (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D32298?vs=96131=96141#toc Repository: rL LLVM

[PATCH] D29659: [OpenMP] Add flag for disabling the default generation of relocatable OpenMP target code for NVIDIA GPUs.

gtbercea updated this revision to Diff 96144. gtbercea added a comment. Refactor if condition. Repository: rL LLVM https://reviews.llvm.org/D29659 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c

[PATCH] D29659: [OpenMP] Add flag for disabling the default generation of relocatable OpenMP target code for NVIDIA GPUs.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D29659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31739: Add markup for libc++ dylib availability

jroelofs added inline comments. Comment at: utils/libcxx/test/config.py:387 +self.config.available_features.add( +'with_system_cxx_lib=%s' % component) mehdi_amini wrote: > jroelofs wrote: > > Is it worth filtering out

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

xazax.hun marked 6 inline comments as done and an inline comment as not done. xazax.hun added a comment. In https://reviews.llvm.org/D30691#731617, @zaks.anna wrote: > I agree that scan-build or scan-build-py integration is an important issue to > resolve here. What I envision is that users

r300982 - [clang-format] Clang-tidy cleanup of CleanupTest.cpp, NFC

Author: krasimir Date: Fri Apr 21 09:21:21 2017 New Revision: 300982 URL: http://llvm.org/viewvc/llvm-project?rev=300982=rev Log: [clang-format] Clang-tidy cleanup of CleanupTest.cpp, NFC Modified: cfe/trunk/unittests/Format/CleanupTest.cpp Modified:

[PATCH] D32298: [clang-format] Replace IncompleteFormat by a struct with Line

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Sounds good. https://reviews.llvm.org/D32298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32298: [clang-format] Replace IncompleteFormat by a struct with Line

krasimir added inline comments. Comment at: include/clang/Format/Format.h:1524 + /// best-effort analysis, and could be imprecise. + unsigned Line = 0; +}; krasimir wrote: > djasper wrote: > > Hm. Something we might need to be thinking about here is whether

[PATCH] D32346: [clang-tidy] New readability check for strlen argument

Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Comment at: docs/clang-tidy/checks/readability-strlen-argument.rst:6 + +This checker will detect addition in strlen() argument. Example code: +

r300988 - [OpenCL] Fix semantic check of ndrange_t for device_side_enqueue.

Author: stulova Date: Fri Apr 21 10:13:24 2017 New Revision: 300988 URL: http://llvm.org/viewvc/llvm-project?rev=300988=rev Log: [OpenCL] Fix semantic check of ndrange_t for device_side_enqueue. Check unqualified type for ndrange argument in device_side_enqueue so device_side_enqueue accept

[PATCH] D30805: [OpenCL] Add intel_reqd_sub_group_size attribute support

Anastasia added a comment. Sure! LGTM! https://reviews.llvm.org/D30805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32238: [Clangd] Failed to decode params using 1.x-compatible request message

malaperle-ericsson added a comment. Could you commit it? I don't have commit access :) Thanks! https://reviews.llvm.org/D32238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32348: [libclang] Check for a record declaration before a template specialization.

arphaman added inline comments. Comment at: clang/test/Index/print-type.cpp:118 // CHECK: TemplateRef=Foo:4:8 [type=] [typekind=Invalid] [isPOD=0] -// CHECK: FieldDecl=qux:29:38 (Definition) [type=Qux] [typekind=Unexposed]

[PATCH] D32351: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources

bkramer added a comment. lg from my side. It would be good to wait until Manuel is back though, I think he had plans for extending this interface at some point. https://reviews.llvm.org/D32351 ___ cfe-commits mailing list

[PATCH] D32234: [Clangd] Support Authority-less URIs

malaperle-ericsson added a comment. Benjamin, I added a test, do you still think it's OK? Thanks! https://reviews.llvm.org/D32234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32234: [Clangd] Support Authority-less URIs

bkramer added a comment. Still looking good. Will commit this soon. https://reviews.llvm.org/D32234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r300991 - [Clangd] Failed to decode params using 1.x-compatible request message

Author: d0k Date: Fri Apr 21 10:51:23 2017 New Revision: 300991 URL: http://llvm.org/viewvc/llvm-project?rev=300991=rev Log: [Clangd] Failed to decode params using 1.x-compatible request message textDocument/completion sends a TextDocumentPositionParams message in the 2.x and 3.x. But in 1.x it

[PATCH] D32238: [Clangd] Failed to decode params using 1.x-compatible request message

This revision was automatically updated to reflect the committed changes. Closed by commit rL300991: [Clangd] Failed to decode params using 1.x-compatible request message (authored by d0k). Changed prior to commit: https://reviews.llvm.org/D32238?vs=95811=96153#toc Repository: rL LLVM

[clang-tools-extra] r300990 - [Clangd] Support Authority-less URIs

Author: d0k Date: Fri Apr 21 10:51:18 2017 New Revision: 300990 URL: http://llvm.org/viewvc/llvm-project?rev=300990=rev Log: [Clangd] Support Authority-less URIs Clangd strips URIs by removing the file:// part but some clients can send file: which is also valid according to RFC 3896. For

[PATCH] D32234: [Clangd] Support Authority-less URIs

This revision was automatically updated to reflect the committed changes. Closed by commit rL300990: [Clangd] Support Authority-less URIs (authored by d0k). Changed prior to commit: https://reviews.llvm.org/D32234?vs=95809=96152#toc Repository: rL LLVM https://reviews.llvm.org/D32234

[PATCH] D30268: Avoid copy of __atoms when char_type is char

hiraditya updated this revision to Diff 96159. hiraditya added a comment. Minimized the diff by putting #ifdefs inside the function. https://reviews.llvm.org/D30268 Files: libcxx/include/__config libcxx/include/locale Index: libcxx/include/locale

[PATCH] D30268: Avoid copy of __atoms when char_type is char

hiraditya added inline comments. Comment at: libcxx/include/locale:891 +#ifndef _LIBCPP_ABI_OPTIMIZED_LOCALE // signed EricWF wrote: > Would it be possible to reduce the amount of duplicate code between the two > implementations? Currently it seems like

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

yamaguchi updated this revision to Diff 96273. yamaguchi added a comment. Add testcase. https://reviews.llvm.org/D32341 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/m_and_mm.c Index: test/Driver/m_and_mm.c === ---

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

v.g.vassilev added a comment. Could you add a test case? https://reviews.llvm.org/D32341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32369: [ms] Give -Wmicrosoft-enum-forward-reference a chance to fire in clang-cl, PR32736

thakis closed this revision. thakis added a comment. r301032, thanks. https://reviews.llvm.org/D32369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32309: [libcxx] [test] Resolve compiler warnings in LCM/GCD tests

rsmith added inline comments. Comment at: test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp:46 +std::gcd(static_cast(0), static_cast(0)))>::value, ""); +const bool result = static_cast>(out) == +

[PATCH] D32348: [libclang] Check for a record declaration before a template specialization.

emilio added inline comments. Comment at: clang/test/Index/print-type.cpp:118 // CHECK: TemplateRef=Foo:4:8 [type=] [typekind=Invalid] [isPOD=0] -// CHECK: FieldDecl=qux:29:38 (Definition) [type=Qux] [typekind=Unexposed]

[PATCH] D32333: [clang-tidy] Update IdentifierNamingCheck to remove extra leading/trailing underscores

jtbandes updated this revision to Diff 96180. jtbandes edited the summary of this revision. jtbandes added a comment. Remove unnecessary checks for empty prefix/suffix https://reviews.llvm.org/D32333 Files: clang-tidy/readability/IdentifierNamingCheck.cpp

[PATCH] D32333: [clang-tidy] Update IdentifierNamingCheck to remove extra leading/trailing underscores

jtbandes updated this revision to Diff 96181. jtbandes added a comment. Cleanup https://reviews.llvm.org/D32333 Files: clang-tidy/readability/IdentifierNamingCheck.cpp test/clang-tidy/readability-identifier-naming.cpp Index: test/clang-tidy/readability-identifier-naming.cpp

[PATCH] D31856: Headers: Make the type of SIZE_MAX the same as size_t

efriedma added a comment. We normally use stdint.h from the host C library, rather than our own version; this file is only relevant in -ffreestanding mode. So it should be safe to change. https://reviews.llvm.org/D31856 ___ cfe-commits mailing

[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and compiler flags

eugenis updated this revision to Diff 96227. eugenis added a comment. Reverted back to using pass constructor argument. Repository: rL LLVM https://reviews.llvm.org/D32064 Files: lib/CodeGen/BackendUtil.cpp Index: lib/CodeGen/BackendUtil.cpp

[PATCH] D32371: Add comments to the diagnostic kinds in Diagnostic.td.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Highly useful I'd say! lgtm Comment at: include/clang/Basic/Diagnostic.td:113 +// Extensions are warnings about accepted language extensions that are +// default-off but

[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and compiler flags

pcc added a comment. Please add a test case. Repository: rL LLVM https://reviews.llvm.org/D32064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32084: AMDGPU/GFX9: Set +fast-fmaf for >=gfx900 unless -cl-denorms-are-zero is set

arsenm added inline comments. Comment at: lib/Basic/Targets.cpp:2208-2210 + TargetOpts.Features.push_back( + (Twine(hasFullSpeedFMAF32(TargetOpts.CPU) && + !CGOpts.FlushDenorm ? '+' : '-') + Twine("fast-fmaf")).str()); We glue fast-fmaf to

[PATCH] D32084: AMDGPU/GFX9: Set +fast-fmaf for >=gfx900 unless -cl-denorms-are-zero is set

kzhuravl abandoned this revision. kzhuravl added a comment. Abandoned in favor of https://reviews.llvm.org/D32363. https://reviews.llvm.org/D32084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32369: [ms] Give -Wmicrosoft-enum-forward-reference a chance to fire in clang-cl, PR32736

thakis created this revision. clang-cl sets MicrosoftCompat. In that mode, we always give enums a fixed underlying type, and for enums with fixed underlying type we never enter the block that tries to emit ext_ms_forward_ref_enum. Fix this by requiring an explicit underlying type when we're

[PATCH] D32372: Arrays of unknown bound in constant expressions

Arcoth created this revision. Arrays of unknown bound are subject to some bugs in constant expressions. const extern int arr[]; constexpr int f(int i) {return arr[i];} constexpr int arr[] {1, 2, 3}; int main() {constexpr int x = f(2);} This is spuriously rejected. On the other hand, extern

[PATCH] D32372: Arrays of unknown bound in constant expressions

rsmith added a comment. This needs testcases (the one from your summary plus the ones in my comments above would be good). Comment at: lib/AST/ExprConstant.cpp:2622 // Next subobject is an array element. - const ConstantArrayType *CAT =

[PATCH] D32378: Insert invariant.group.barrier for pointers comparsons

Prazek created this revision. This code was wrongly devirtualized before: A* a = new A; a->foo(); A* b = new(a) B; if (a == b) b->foo(); Now we insert barrier before comparing dynamic pointers. https://reviews.llvm.org/D32378 Files: lib/CodeGen/CGExprScalar.cpp

[PATCH] D32234: [Clangd] Support Authority-less URIs

malaperle-ericsson added a comment. Thanks a lot! Repository: rL LLVM https://reviews.llvm.org/D32234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32371: Add comments to the diagnostic kinds in Diagnostic.td.

Johnniesnato added a comment. 0day Scene Albums House, Club, Dance, Minimal, Psy-Trance, Dubstep http://0daymusic.org https://reviews.llvm.org/D32371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32263: Preprocessor: Suppress -Wnonportable-include-path for header maps

eric_niebler added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:401 + } + /// \brief Look up a subframework for the specified \#include file. Why not just add a `, bool *IsMapped = nullptr` parameter to the existing `LookupFile`?

[PATCH] D32043: [Driver] Load all necessary default sanitizer blacklists

vsk added a comment. In https://reviews.llvm.org/D32043#728427, @pcc wrote: > This seems reasonable to me, although it's unfortunate that the design of the > sanitizer blacklist feature does not (at present) allow different blacklists > for different sanitizers. IMO this might be a real

[PATCH] D31856: Headers: Make the type of SIZE_MAX the same as size_t

rsmith added a comment. In https://reviews.llvm.org/D31856#733845, @efriedma wrote: > We normally use stdint.h from the host C library, rather than our own > version; this file is only relevant in -ffreestanding mode. So it should be > safe to change. Agreed; r89237 (and nearby changes:

[PATCH] D31739: Add markup for libc++ dylib availability

mehdi_amini added a comment. @mclow.lists you mentioned on IRC you may have some suggestions to make this less noisy? Do you still plan to review? https://reviews.llvm.org/D31739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32263: Preprocessor: Suppress -Wnonportable-include-path for header maps

dexonsmith updated this revision to Diff 96201. dexonsmith added a comment. Thanks for the review, Eli. I've changed `IsModule` to be a required `bool*` parameter. Setting the default to `nullptr` looked confusing at call sites. https://reviews.llvm.org/D32263 Files:

[PATCH] D32263: Preprocessor: Suppress -Wnonportable-include-path for header maps

dexonsmith added a comment. s/Eli/Eric/ https://reviews.llvm.org/D32263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32369: [ms] Give -Wmicrosoft-enum-forward-reference a chance to fire in clang-cl, PR32736

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D32369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r301032 - [ms] Give -Wmicrosoft-enum-forward-reference a chance to fire in clang-cl, PR32736

Author: nico Date: Fri Apr 21 15:12:26 2017 New Revision: 301032 URL: http://llvm.org/viewvc/llvm-project?rev=301032=rev Log: [ms] Give -Wmicrosoft-enum-forward-reference a chance to fire in clang-cl, PR32736 clang-cl sets MicrosoftCompat. In that mode, we always give enums a fixed underlying

[PATCH] D32346: [clang-tidy] New readability check for strlen argument

Eugene.Zelenko added a comment. It may be good idea to add check for arguments which taken from C++ containers like std::string, std::string_view, etc. Repository: rL LLVM https://reviews.llvm.org/D32346 ___ cfe-commits mailing list

[PATCH] D31739: Add markup for libc++ dylib availability

mehdi_amini added a comment. @mclow.lists you mentioned on IRC you may have some suggestions to make this less noisy? Do you still plan to review? https://reviews.llvm.org/D31739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >