[PATCH] D32372: Arrays of unknown bound in constant expressions

Arcoth updated this revision to Diff 97114. Arcoth added a comment. Simplified array-to-pointer conversion (simply add the array as unsized; let findCompleteObject and the SubobjectDesignator ctor do the work). https://reviews.llvm.org/D32372 Files: include/clang/Basic/DiagnosticASTKinds.td

[PATCH] D32550: Supress all uses of LLVM_END_WITH_NULL

serge-sans-paille added a subscriber: mehdi_amini. serge-sans-paille added a comment. @mehdi_amini are you okay with my previous explanation? https://reviews.llvm.org/D32550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r301651 - [clang-tidy] modernize-use-emplace: remove unnecessary make_pair calls

Author: kuhar Date: Fri Apr 28 11:25:45 2017 New Revision: 301651 URL: http://llvm.org/viewvc/llvm-project?rev=301651=rev Log: [clang-tidy] modernize-use-emplace: remove unnecessary make_pair calls Summary: When there is a push_back with a call to make_pair, turn it into emplace_back and remove

[PATCH] D32395: [clang-tidy] modernize-use-emplace: remove unnecessary make_pair calls

This revision was automatically updated to reflect the committed changes. Closed by commit rL301651: [clang-tidy] modernize-use-emplace: remove unnecessary make_pair calls (authored by kuhar). Changed prior to commit: https://reviews.llvm.org/D32395?vs=96634=97113#toc Repository: rL LLVM

[PATCH] D32372: Arrays of unknown bound in constant expressions

Arcoth updated this revision to Diff 97116. Arcoth added a comment. (Just fixed a slip after typing with the wrong window in focus...) https://reviews.llvm.org/D32372 Files: include/clang/Basic/DiagnosticASTKinds.td lib/AST/ExprConstant.cpp test/SemaCXX/constexpr-array-unknown-bound.cpp

r301648 - [libclang] Expose some target information via the C API.

Author: emilio Date: Fri Apr 28 10:56:39 2017 New Revision: 301648 URL: http://llvm.org/viewvc/llvm-project?rev=301648=rev Log: [libclang] Expose some target information via the C API. This allows users to query the target triple and target pointer width, which would make me able to fix

[PATCH] D32389: [libclang] Expose some target information via the C API.

This revision was automatically updated to reflect the committed changes. Closed by commit rL301648: [libclang] Expose some target information via the C API. (authored by emilio). Changed prior to commit: https://reviews.llvm.org/D32389?vs=96834=97109#toc Repository: rL LLVM

r301652 - [DOXYGEN] Minor improvements in doxygen comments.

Author: kromanova Date: Fri Apr 28 11:45:39 2017 New Revision: 301652 URL: http://llvm.org/viewvc/llvm-project?rev=301652=rev Log: [DOXYGEN] Minor improvements in doxygen comments. - I removed doxygen comments for the intrinsics that "alias" the other existing documented intrinsics and that

[PATCH] D32372: Arrays of unknown bound in constant expressions

rsmith added a comment. Thanks, this looks good, just a couple of minor things and then it should be ready to land. Do you have commit access or will you need someone else to commit this for you? Comment at: lib/AST/ExprConstant.cpp:152 + uint64_t ,

r301727 - PR26771: don't forget the " 2" (returning from #included file) linemarker after including an empty file with -frewrite-includes.

Author: rsmith Date: Fri Apr 28 19:54:03 2017 New Revision: 301727 URL: http://llvm.org/viewvc/llvm-project?rev=301727=rev Log: PR26771: don't forget the " 2" (returning from #included file) linemarker after including an empty file with -frewrite-includes. Added:

[PATCH] D32412: analyze all kinds of expressions for integer overflow

nlewycky added a comment. > If we're now catching integer overflow in more cases, please add some > relevant testcases. Both more and fewer. More because we no longer have a whitelist of three kinds of expressions that we recurse into. Fewer because we no longer call IgnoreParenCasts() on the

[PATCH] D32412: analyze all kinds of expressions for integer overflow

nlewycky updated this revision to Diff 97179. nlewycky added a comment. [No changes, just full context this time.] https://reviews.llvm.org/D32412 Files: include/clang/Sema/Sema.h lib/AST/ExprConstant.cpp lib/Sema/SemaChecking.cpp

[PATCH] D32291: [analyzer] Implement handling array subscript into null pointer, improve null dereference checks for array subscripts

zaks.anna added inline comments. Comment at: cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:80 } -else if (isDeclRefExprToReference(E)) { +else if (isa(E)) { return E; Not sure what this does, but looks like we are stricter here

RE: r301707 - Adapt to LLVM API change (DINamespace no longer takes line/file info).

Hi Adrian, This commit, or the previous one you made seems to be causing a failure in the clang test CodeGenCXX\debug-info-namespace.cpp on the ps4 Windows and Linux bots. It's failing when trying to match the CHECK line on line 79 of the test because the line it matches seems to have one

r301735 - Fix PR32831: 'this capture while instantiating generic lambda call operator specialization

Author: faisalv Date: Fri Apr 28 22:49:17 2017 New Revision: 301735 URL: http://llvm.org/viewvc/llvm-project?rev=301735=rev Log: Fix PR32831: 'this capture while instantiating generic lambda call operator specialization When computing the appropriate cv-qualifiers for the 'this' capture, we

r301725 - Add pragma to perform module import and use it in -E output.

Author: rsmith Date: Fri Apr 28 19:34:47 2017 New Revision: 301725 URL: http://llvm.org/viewvc/llvm-project?rev=301725=rev Log: Add pragma to perform module import and use it in -E output. Many of our supported configurations support modules but do not have any first-class syntax to perform a

r301726 - Remove unused, empty test directories.

Author: rsmith Date: Fri Apr 28 19:46:27 2017 New Revision: 301726 URL: http://llvm.org/viewvc/llvm-project?rev=301726=rev Log: Remove unused, empty test directories. Removed: cfe/trunk/test/Frontend/Rewriter/ ___ cfe-commits mailing list

[PATCH] D32412: analyze all kinds of expressions for integer overflow

nlewycky updated this revision to Diff 97178. nlewycky edited the summary of this revision. nlewycky added a comment. Rebase. Now that ObjCBoxedExpr change is in, we can remove Sema::CheckForIntOverflow entirely. https://reviews.llvm.org/D32412 Files: include/clang/Sema/Sema.h

[PATCH] D32372: Arrays of unknown bound in constant expressions

Arcoth updated this revision to Diff 97180. Arcoth added a comment. Applied the last review's suggestions. https://reviews.llvm.org/D32372 Files: include/clang/Basic/DiagnosticASTKinds.td lib/AST/ExprConstant.cpp test/SemaCXX/constexpr-array-unknown-bound.cpp Index:

r301731 - Fix "REQUIRES: system-darwin" failing tests after r301725.

Author: rsmith Date: Fri Apr 28 20:29:44 2017 New Revision: 301731 URL: http://llvm.org/viewvc/llvm-project?rev=301731=rev Log: Fix "REQUIRES: system-darwin" failing tests after r301725. Also remove the apparently-unneeded REQUIRES (the tests also pass on at least Linux, and don't appear to have

r301732 - Remove some apparently-unnecessary 'REQUIRES: system-darwin' from tests.

Author: rsmith Date: Fri Apr 28 20:38:29 2017 New Revision: 301732 URL: http://llvm.org/viewvc/llvm-project?rev=301732=rev Log: Remove some apparently-unnecessary 'REQUIRES: system-darwin' from tests. Let's see if any buildbots actually have trouble with these. (They at least pass on Linux.)

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

yamaguchi updated this revision to Diff 97182. yamaguchi added a comment. Update testcase. Made it minimal. https://reviews.llvm.org/D32646 Files: lib/Sema/SemaInit.cpp test/Sema/warn-missing-braces.c Index: test/Sema/warn-missing-braces.c

[PATCH] D31887: [clangd] Add documentation page

malaperle-ericsson added a comment. In https://reviews.llvm.org/D31887#740747, @Prazek wrote: > In https://reviews.llvm.org/D31887#740727, @malaperle-ericsson wrote: > > > Would it be possible to commit this? I do not have commit rights. Thanks! > > > Why won't you get commit right? You will

r301667 - [CodeGen][ObjC] Don't retain captured Objective-C pointers at block

Author: ahatanak Date: Fri Apr 28 13:50:57 2017 New Revision: 301667 URL: http://llvm.org/viewvc/llvm-project?rev=301667=rev Log: [CodeGen][ObjC] Don't retain captured Objective-C pointers at block creation that are const-qualified. When a block captures an ObjC object pointer, clang retains the

[PATCH] D32601: [CodeGen][ObjC] Don't retain/release capture objects at block creation that are const-qualified

This revision was automatically updated to reflect the committed changes. Closed by commit rL301667: [CodeGen][ObjC] Don't retain captured Objective-C pointers at block (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D32601?vs=96940=97136#toc Repository: rL LLVM

[PATCH] D32475: [clang-format] Don’t propagate AvoidBinPacking into argument subexpressions

jtbandes added a comment. Friendly ping :) happy to make more changes if needed. Thanks again for your time. https://reviews.llvm.org/D32475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r301684 - Enable -fno-split-dwarf-inlining even when -gsplit-dwarf isn't specified.

Author: dblaikie Date: Fri Apr 28 15:50:25 2017 New Revision: 301684 URL: http://llvm.org/viewvc/llvm-project?rev=301684=rev Log: Enable -fno-split-dwarf-inlining even when -gsplit-dwarf isn't specified. Since -gsplit-dwarf is specified on a backend compile (in ThinLTO parlance) it isn't passed

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32410: change the way the expr evaluator handles objcboxedexpr

nlewycky updated this revision to Diff 97173. nlewycky added a comment. If the boxing method can't be constexpr then we can never evaluate it for a constant value, which means that we should unconditionally return Error, and use noteFailure to decide whether to visit the subexpr.

[PATCH] D32566: Revert rL301328 and add tests for the regressions introduced.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Yes, let's first revert back to the clang 4.0 behavior, then please mail cfe-dev to discuss what the right behavior should be. Repository: rL LLVM https://reviews.llvm.org/D32566

[PATCH] D24999: [Sema] Only relax array-at-end-of-object checks in __builtin_object_size when -fno-strict-aliasing is given.

ahatanak added a dependency: D21453: Add support for attribute "overallocated". ahatanak added a comment. Depends on https://reviews.llvm.org/D21453. Adding a dependency as a reminder to look into https://reviews.llvm.org/D21453 before committing this patch. https://reviews.llvm.org/D24999

r301701 - [ODRHash] Add testcase with different paramter names. NFC

Author: rtrieu Date: Fri Apr 28 17:03:28 2017 New Revision: 301701 URL: http://llvm.org/viewvc/llvm-project?rev=301701=rev Log: [ODRHash] Add testcase with different paramter names. NFC Modified: cfe/trunk/test/Modules/odr_hash.cpp Modified: cfe/trunk/test/Modules/odr_hash.cpp URL:

[PATCH] D32410: change the way the expr evaluator handles objcboxedexpr

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D32410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32515: [libcxx] [test] Changes to accommodate LWG 2904 "Make variant move-assignment more exception safe"

CaseyCarter added a comment. Added some inline notes for reviewers. Comment at: test/std/utilities/variant/variant.variant/variant.assign/T.pass.cpp:195 } -assert(v.valueless_by_exception()); +assert(v.index() == 0); +assert(std::get<0>(v) == "hello");

r301707 - Adapt to LLVM API change (DINamespace no longer takes line/file info).

Author: adrian Date: Fri Apr 28 17:25:53 2017 New Revision: 301707 URL: http://llvm.org/viewvc/llvm-project?rev=301707=rev Log: Adapt to LLVM API change (DINamespace no longer takes line/file info). rdar://problem/17484998 https://reviews.llvm.org/D32648 Modified:

r301721 - ObjCBoxedExpr can't be evaluated by the constant expression evaluator.

Author: nicholas Date: Fri Apr 28 19:07:27 2017 New Revision: 301721 URL: http://llvm.org/viewvc/llvm-project?rev=301721=rev Log: ObjCBoxedExpr can't be evaluated by the constant expression evaluator. A boxed expression evaluates its subexpr and then calls an objc method to transform it into

r301635 - [index] Handle vector types in USR generator

Author: arphaman Date: Fri Apr 28 04:46:36 2017 New Revision: 301635 URL: http://llvm.org/viewvc/llvm-project?rev=301635=rev Log: [index] Handle vector types in USR generator rdar://25339187 Modified: cfe/trunk/lib/Index/USRGeneration.cpp cfe/trunk/test/Index/usrs.cpp Modified:

r301637 - [X86][SSE] Add _mm_set_pd1 (PR32827)

Author: rksimon Date: Fri Apr 28 05:28:32 2017 New Revision: 301637 URL: http://llvm.org/viewvc/llvm-project?rev=301637=rev Log: [X86][SSE] Add _mm_set_pd1 (PR32827) Matches _mm_set_ps1 implementation Modified: cfe/trunk/lib/Headers/emmintrin.h cfe/trunk/test/CodeGen/sse2-builtins.c

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

bkramer added a comment. Can you please run clang-format on this change? There are pieces that don't follow the style. Also the mutable state in PrintingPolicy is really really ugly, is there no better way for this? :( https://reviews.llvm.org/D30946

[PATCH] D31887: [clangd] Add documentation page

malaperle-ericsson added a comment. Would it be possible to commit this? I do not have commit rights. Thanks! https://reviews.llvm.org/D31887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31887: [clangd] Add documentation page

Prazek added a comment. In https://reviews.llvm.org/D31887#740727, @malaperle-ericsson wrote: > Would it be possible to commit this? I do not have commit rights. Thanks! Why won't you get commit right? You will probably make some other contribution to clangd, so it will be handy to have it :)

[PATCH] D29768: [TargetInfo] Set 'UseSignedCharForObjCBool' to false by default

arphaman added a comment. Ping. Repository: rL LLVM https://reviews.llvm.org/D29768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29768: [TargetInfo] Set 'UseSignedCharForObjCBool' to false by default

aaron.ballman added inline comments. Comment at: lib/Basic/Targets.cpp:4340-4341 llvm::Triple T = llvm::Triple(Triple); -if (T.isWatchOS()) - UseSignedCharForObjCBool = false; +if (!T.isWatchOS()) + UseSignedCharForObjCBool = true; SizeType =

r301643 - [Sema] Avoid an invalid redefinition error that was presented for

Author: arphaman Date: Fri Apr 28 07:30:05 2017 New Revision: 301643 URL: http://llvm.org/viewvc/llvm-project?rev=301643=rev Log: [Sema] Avoid an invalid redefinition error that was presented for of a function whose previous definition was typo-corrected rdar://28550928 Differential Revision:

[PATCH] D25113: [Sema] Don't display an invalid redefinition error when dealing with a redefinition of a function whose previous definition was typo-corrected

This revision was automatically updated to reflect the committed changes. Closed by commit rL301643: [Sema] Avoid an invalid redefinition error that was presented for (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D25113?vs=96123=97084#toc Repository: rL LLVM

[PATCH] D32395: [clang-tidy] modernize-use-emplace: remove unnecessary make_pair calls

alexfh accepted this revision. alexfh added a comment. LG https://reviews.llvm.org/D32395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32389: [libclang] Expose some target information via the C API.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rL LLVM https://reviews.llvm.org/D32389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev updated this revision to Diff 97098. v.g.vassilev added a comment. This revision is now accepted and ready to land. Implement a special diagnostic switch for the warning. https://reviews.llvm.org/D29877 Files: include/clang/Basic/DiagnosticGroups.td

r301647 - Use the -Wunknown-warning-option group for the "unknown warning group"

Author: arphaman Date: Fri Apr 28 09:45:25 2017 New Revision: 301647 URL: http://llvm.org/viewvc/llvm-project?rev=301647=rev Log: Use the -Wunknown-warning-option group for the "unknown warning group" diagnostic in #pragma diagnostic This matches the warning group that's specified for the

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev added a comment. @rsmith, @mclow.lists, @arphaman, I am planning to reland that soon. Let me know if you have any objections. https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

yamaguchi created this revision. This is an update patch for bug [1]. -Wmissing-braces should not fire for system headers. [1] https://bugs.llvm.org/show_bug.cgi?id=24007 https://reviews.llvm.org/D32646 Files: lib/Sema/SemaInit.cpp test/Sema/warn-missing-braces.c Index:

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

ruiu added inline comments. Comment at: test/Sema/warn-missing-braces.c:6-11 +typedef struct _GUID { + unsigned Data1; + unsigned short Data2; + unsigned short Data3; + unsigned char Data4[8]; +} GUID; You can simplify this, can't you? It seems something

[PATCH] D32372: Arrays of unknown bound in constant expressions

Arcoth updated this revision to Diff 97105. Arcoth added a comment. Updated `SubobjectDesignator` to hold `MostDerivedIsAnUnsizedArray` instead of `FirstEntryIsAnUnsizedArray`. Consequently, we cannot know whether the first element is an unsized array; please see line 7352 in particular, where

[PATCH] D32592: [Analyzer] Iterator Checker - Part1: Minimal Checker for a Simple Test Case

baloghadamsoftware updated this revision to Diff 97060. baloghadamsoftware added a comment. Checker and test included now :-) https://reviews.llvm.org/D32592 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

xiangzhai updated this revision to Diff 97047. xiangzhai added a subscriber: cfe-commits. xiangzhai added a comment. Hi Artem, Please review my updated patch, I use SourceManager's getFilename and add some testcases, thanks a lot! Regards, Leslie Zhai Repository: rL LLVM

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

NoQ added a comment. Thanks! Because LLVM's Illinois license is rather permissive than copyleft, we try to avoid stuff copied from GPL/LGPL software (such as Qt or K3B) in our codebase. The code doesn't seem to have been copy-pasted from a copyleft project, but I guess it's better to rename

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

xiangzhai updated this revision to Diff 97059. xiangzhai added a comment. Hi Artem, Thanks for your review! > Because LLVM's Illinois license is rather permissive than copyleft, we try to > avoid stuff copied from GPL/LGPL software (such as Qt or K3B) in our > codebase. The code doesn't seem

[PATCH] D32635: [libcxx] regex: fix backreferences in forward assertions

pammon created this revision. Herald added a reviewer: EricWF. In regex, forward assertions like '(?=stuff)' are implemented by constructing a child regular expression 'stuff' and matching that. If the child regular expression contains a backreference, this would trip an assertion or reference

[PATCH] D32638: [x86][inline-asm][clang]Amend size directive deduction mechanism of unsized memory operands

coby created this revision. This is an extension of the work being carried by the following change: https://reviews.llvm.org/D26586 This commit handles cases where the size qualifier of an indirect memory reference operand in Intel syntax is missing (e.g. "vaddps xmm1, xmm2, [a]"). GCC will

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

v.g.vassilev added a comment. In general, I think we should support such use-cases. It seems cleaner to me if we provide some sort of callbacks where the users can specify their custom false positive filters. I've discussed this in brief with Raphael and we were planning to write this up.

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

xiangzhai added a comment. Hi Vassil, The first one considered about CopyPaste dection Thanks for your reply! Let's do it together and Happy International Labor Day :) Regards, Leslie Zhai Repository: rL LLVM