[libcxx] r303862 - Last commit included some extra constexpr; remove them

Author: marshall Date: Thu May 25 09:20:26 2017 New Revision: 303862 URL: http://llvm.org/viewvc/llvm-project?rev=303862=rev Log: Last commit included some extra constexpr; remove them Modified: libcxx/trunk/include/algorithm Modified: libcxx/trunk/include/algorithm URL:

r303861 - [AMDGPU] add __builtin_amdgcn_s_getpc

Author: timcorringham Date: Thu May 25 09:16:11 2017 New Revision: 303861 URL: http://llvm.org/viewvc/llvm-project?rev=303861=rev Log: [AMDGPU] add __builtin_amdgcn_s_getpc Summary: Added the builtin corresponding to the s_getpc intrinsic added in llvm D32862 Subscribers: kzhuravl, wdng,

[PATCH] D32592: [Analyzer] Iterator Checker - Part 1: Minimal Checker for a Simple Test Case

baloghadamsoftware updated this revision to Diff 100239. baloghadamsoftware added a comment. Comments added and fixed. https://reviews.llvm.org/D32592 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt

r303857 - [X86] Adding avx512_vpopcntdq feature set and its intrinsics

Author: orenb Date: Thu May 25 08:44:11 2017 New Revision: 303857 URL: http://llvm.org/viewvc/llvm-project?rev=303857=rev Log: [X86] Adding avx512_vpopcntdq feature set and its intrinsics AVX512_VPOPCNTDQ is a new feature set that was published by Intel. The patch represents the Clang side of

[PATCH] D33170: [X86] Adding avx512_vpopcntdq feature set and its intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rL303857: [X86] Adding avx512_vpopcntdq feature set and its intrinsics (authored by orenb). Changed prior to commit: https://reviews.llvm.org/D33170?vs=99685=100236#toc Repository: rL LLVM

[libcxx] r303856 - Make for_each_n only avaliable on C++17

Author: marshall Date: Thu May 25 08:40:57 2017 New Revision: 303856 URL: http://llvm.org/viewvc/llvm-project?rev=303856=rev Log: Make for_each_n only avaliable on C++17 Modified: libcxx/trunk/include/algorithm Modified: libcxx/trunk/include/algorithm URL:

[PATCH] D33328: [CodeGen] Pessimize aliasing for union members (and may-alias) objects

This revision was automatically updated to reflect the committed changes. Closed by commit rL303851: [CodeGen] Pessimize aliasing for member unions (and may-alias) objects (authored by kparzysz). Changed prior to commit: https://reviews.llvm.org/D33328?vs=100142=100232#toc Repository: rL

r303851 - [CodeGen] Pessimize aliasing for member unions (and may-alias) objects

Author: kparzysz Date: Thu May 25 07:55:47 2017 New Revision: 303851 URL: http://llvm.org/viewvc/llvm-project?rev=303851=rev Log: [CodeGen] Pessimize aliasing for member unions (and may-alias) objects Use the TBAA info of the omnipotent char for these objects. Differential Revision:

[PATCH] D33547: Updated getting started guide for visual studio + cmake

aaron.ballman created this revision. It took me a while to track this down and I figured I'd save someone else the time. By default, CMake uses the 32-bit toolchain on Windows, even if generating a 64-bit solution. Given the size of Clang's code base, this can lead to quite a few link errors

[PATCH] D33536: [coroutines] Bump __cpp_coroutines version

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D33536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33534: [coroutines] Diagnose when promise types fail to declare either return_void or return_value.

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D33534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

RE: [clang-tools-extra] r303849 -

Just a commit access test with messed up log message. - Florian -Original Message- From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Florian Gross via cfe-commits Sent: Thursday, May 25, 2017 1:43 PM To: cfe-commits@lists.llvm.org Subject: [clang-tools-extra]

[clang-tools-extra] r303849 -

Author: fgross Date: Thu May 25 06:43:06 2017 New Revision: 303849 URL: http://llvm.org/viewvc/llvm-project?rev=303849=rev Log: (empty) Modified: clang-tools-extra/trunk/clang-tidy/readability/BracesAroundStatementsCheck.cpp Modified:

[PATCH] D33448: [CodeGen] Add thumb-mode to target-features for arm/thumb triples.

fhahn added a comment. @echristo lib/Basic/Targets.cpp is indeed a much better place to add thumb-mode to the target features, thanks for pointing me in the right direction! https://reviews.llvm.org/D33448 ___ cfe-commits mailing list

[PATCH] D33448: [CodeGen] Add thumb-mode to target-features for arm/thumb triples.

fhahn updated this revision to Diff 100222. fhahn retitled this revision from "[CodeGen] Add thumb-mode to function target-features for arm/thumb triples." to "[CodeGen] Add thumb-mode to target-features for arm/thumb triples.". fhahn edited the summary of this revision. fhahn added a comment.

[PATCH] D33353: [OpenCL] An error shall occur if any scalar operand has greater rank than the type of the vector element

echuraev updated this revision to Diff 100219. echuraev marked 2 inline comments as done. https://reviews.llvm.org/D33353 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp test/SemaOpenCL/arithmetic-conversions.cl test/SemaOpenCL/cond.cl Index:

[PATCH] D33470: [clang-tidy] Add misc-default-numerics

Prazek updated this revision to Diff 100216. Prazek marked 8 inline comments as done. Prazek added a comment. - Thanks for the review Aaron, that is much better. https://reviews.llvm.org/D33470 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/DefaultNumericsCheck.cpp

[PATCH] D33525: [ThinLTO] Migrate ThinLTOBitcodeWriter to the new PM.

chandlerc added a comment. (focusing on the LLVM side of this review for now) Can you add an LLVM-based test? Can you add this to `lib/Passes/PassRegistry.def`? Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:423 + +class AARGetter { + FunctionAnalysisManager

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

EricWF added inline comments. Comment at: test/std/utilities/variant/variant.variant/variant.assign/copy.pass.cpp:389 +template +constexpr bool triviality_test = + std::is_trivially_copy_assignable::value == `triviality_test` should also compare

[PATCH] D33340: [libcxx] [test] Add string nullptr asserts to erase functions.

EricWF added a comment. @BillyONeal Changes like this are good for post-commit review (ie just commit it). Adding clearly correct assertions and test cases is never an objectionable thing. https://reviews.llvm.org/D33340 ___ cfe-commits mailing

[PATCH] D33290: [libcxx] [test] Remove workaround for C1XX conversion-to-nullptr bug

EricWF added a comment. @CaseyCarter Changes like this are good for post-commit review (ie just commit it) https://reviews.llvm.org/D33290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33290: [libcxx] [test] Remove workaround for C1XX conversion-to-nullptr bug

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D33290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33340: [libcxx] [test] Add string nullptr asserts to erase functions.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Sorry for the delay reviewing such a simple change. https://reviews.llvm.org/D33340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33538: [coroutines] Support "coroutines" feature in module map requires clause

EricWF added inline comments. Comment at: test/Modules/requires-coroutines.mm:1 +// RUN: rm -rf %t +// RUN: %clang_cc1 -Wauto-import -fmodules-cache-path=%t -fmodules -fimplicit-module-maps -F %S/Inputs %s -verify Should this test be called

r303844 - [OpenCL] Added regression test on invalid vector initialization.

Author: echuraev Date: Thu May 25 01:55:02 2017 New Revision: 303844 URL: http://llvm.org/viewvc/llvm-project?rev=303844=rev Log: [OpenCL] Added regression test on invalid vector initialization. Summary: This patch increases code coverage. Reviewers: Anastasia Reviewed By: Anastasia

r303846 - [OpenCL] reserve_id_t cannot be used as argument to kernel function

Author: echuraev Date: Thu May 25 02:18:37 2017 New Revision: 303846 URL: http://llvm.org/viewvc/llvm-project?rev=303846=rev Log: [OpenCL] reserve_id_t cannot be used as argument to kernel function Reviewers: Anastasia Reviewed By: Anastasia Subscribers: yaxunl, cfe-commits, bader

[PATCH] D30837: [libcxx] Support for shared_ptr<T()>

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after addressing inline comments. Sorry for the delay. Comment at: include/memory:3663 +template +struct rebind +{ This rebind isn't

[PATCH] D32592: [Analyzer] Iterator Checker - Part 1: Minimal Checker for a Simple Test Case

NoQ added a comment. Sorry, got carried away by GSoC and critical stuff... In https://reviews.llvm.org/D32592#749613, @baloghadamsoftware wrote: > In https://reviews.llvm.org/D32592#747132, @NoQ wrote: > > > Then, in methods that deal with iterator `SVal`s directly, i wish we had > > hints

[PATCH] D31745: [OpenCL] Added diagnostic for implicit declaration of function in OpenCL

echuraev updated this revision to Diff 100210. https://reviews.llvm.org/D31745 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/SemaOpenCL/clang-builtin-version.cl test/SemaOpenCL/to_addr_builtin.cl Index: test/SemaOpenCL/to_addr_builtin.cl

[PATCH] D32592: [Analyzer] Iterator Checker - Part 1: Minimal Checker for a Simple Test Case

baloghadamsoftware added a comment. Any comments regarding the last changes? https://reviews.llvm.org/D32592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33538: [coroutines] Support "coroutines" feature to module map "requires"

EricWF updated this revision to Diff 100207. EricWF added a comment. - Alphabetize newly added switch case. https://reviews.llvm.org/D33538 Files: docs/Modules.rst lib/Basic/Module.cpp test/Modules/Inputs/DependsOnModule.framework/Headers/coroutines.h

[PATCH] D32350: [Analyzer] Exception checker for misuse: uncaught/noncompliant throws

baloghadamsoftware abandoned this revision. baloghadamsoftware added a comment. Superseded by https://reviews.llvm.org/D33537 https://reviews.llvm.org/D32350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33538: [coroutines] Support "coroutines" feature to module map "requires"

EricWF created this revision. In order for libc++ to add `` to its module map, there has to be a feature that can be used to detect if coroutines support is enabled in Clang. https://reviews.llvm.org/D33538 Files: docs/Modules.rst lib/Basic/Module.cpp

[PATCH] D33537: [clang-tidy] Exception Escape Checker

baloghadamsoftware added a comment. Supersedes https://reviews.llvm.org/D32350 https://reviews.llvm.org/D33537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33537: [clang-tidy] Exception Escape Checker

baloghadamsoftware created this revision. Herald added a subscriber: mgorny. Finds functions which should not throw exceptions: Destructors, move constructors, move assignment operators, the main() function, swap() functions, functions marked with throw() or noexcept and functions given as

<    1   2