[PATCH] D33525: [ThinLTO] Migrate ThinLTOBitcodeWriter to the new PM.

timshen updated this revision to Diff 100761. timshen marked 12 inline comments as done. timshen added a comment. Updated based on the comments, and left out Clang changes for a separate patch. https://reviews.llvm.org/D33525 Files: llvm/include/llvm/Transforms/IPO/ThinLTOBitcodeWriter.h

[PATCH] D33525: [ThinLTO] Migrate ThinLTOBitcodeWriter to the new PM.

timshen added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:443 + writeThinLTOBitcode(OS, ThinLinkOS, + [](Function ) -> AAResults & { +return FAM.getResult(F); chandlerc wrote: > Are

[PATCH] D33660: [coroutines] Fix assertion during -Wuninitialized analysis

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LBTM (Looks brilliant to me) https://reviews.llvm.org/D33660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33304: [WIP][clang-tidy] Add a new module Android and a new check for file descriptors.

yawanng updated this revision to Diff 100777. yawanng added a comment. Modify the detection algorithm. Add another two checks and corresponding tests as well as the docs. https://reviews.llvm.org/D33304 Files: clang-tidy/CMakeLists.txt clang-tidy/android/AndroidTidyModule.cpp

[PATCH] D33616: [MS] Fix _bittest* intrinsics for values bigger than 31

majnemer added a comment. Do you really want to be doing signed division here? Because it is signed, it won't turn into the simple bitshifts and masks that one might expect. https://reviews.llvm.org/D33616 ___ cfe-commits mailing list

[PATCH] D33616: [MS] Fix _bittest* intrinsics for values bigger than 31

hans added a comment. From looking in the Intel manual (Table 3-2, in 3.1.1.9 about Bit(BitBase,BitOffset)) it does sound like the bit offset can be negative *shudder*, so I suppose this is necessary and explains why the type is signed in the first place? Hopefully most of these will be

r304253 - [modules] Minor documentation clarification for behavior of requires-declaration.

Author: rsmith Date: Tue May 30 18:05:23 2017 New Revision: 304253 URL: http://llvm.org/viewvc/llvm-project?rev=304253=rev Log: [modules] Minor documentation clarification for behavior of requires-declaration. Modified: cfe/trunk/docs/Modules.rst Modified: cfe/trunk/docs/Modules.rst URL:

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 updated this revision to Diff 100796. jyu2 added a comment. Okay this CFG version of this change. In this change I am basic using same algorithm with -Winfinite-recursion. In addition to my original implementation, I add handler type checking which basic using

Re: r304190 - Diagnose attempts to build a preprocessed module that defines an unavailable submodule.

Hello Richard, This commit broke a test on few of our builders: Failing Tests (1): Clang :: Modules/preprocess-unavailable.cpp http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/11935

[PATCH] D33304: [clang-tidy] Add a new module Android and a new check for file descriptors.

yawanng updated this revision to Diff 100786. yawanng marked 8 inline comments as done. https://reviews.llvm.org/D33304 Files: clang-tidy/CMakeLists.txt clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CreatUsageCheck.cpp

[PATCH] D33698: [CodeGen][ObjC] Fix assertion failure in CodeGenFunction::EmitARCStoreStrongCall

ahatanak created this revision. The assertion fails because CGObjCRuntime::EmitValueForIvarAtOffset doesn't get the correct type of the ivar when the class the ivar belongs to is parameterized. It assigns the type of the ivar in the parameterized base class, instead of the type in the derived

[PATCH] D33304: [clang-tidy] Add a new module Android and a new check for file descriptors.

yawanng updated this revision to Diff 100782. https://reviews.llvm.org/D33304 Files: clang-tidy/CMakeLists.txt clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CreatUsageCheck.cpp clang-tidy/android/CreatUsageCheck.h

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r304237 - Add an explicit -std= to test to unbreak on PS4 targets.

Author: rsmith Date: Tue May 30 15:13:34 2017 New Revision: 304237 URL: http://llvm.org/viewvc/llvm-project?rev=304237=rev Log: Add an explicit -std= to test to unbreak on PS4 targets. Modified: cfe/trunk/test/Modules/preprocess-unavailable.cpp Modified:

[libcxx] r304236 - [test] s/uexpectedly/unexpectedly/

Author: caseycarter Date: Tue May 30 15:12:55 2017 New Revision: 304236 URL: http://llvm.org/viewvc/llvm-project?rev=304236=rev Log: [test] s/uexpectedly/unexpectedly/ Modified: libcxx/trunk/test/support/test_macros.h Modified: libcxx/trunk/test/support/test_macros.h URL:

[PATCH] D32842: Specify which sanitizers are covered by a sanitizer blacklist

eugenis added a comment. This change scares me a bit, to be honest. Is this really that big of a problem? Blacklists are not supposed to be big, maybe we can tolerate a few false negatives? Consider extending the blacklist syntax instead, the same way Valgrind does. Blacklist entries could be

[PATCH] D33616: [MS] Fix _bittest* intrinsics for values bigger than 31

majnemer accepted this revision. majnemer added a comment. LGTM https://reviews.llvm.org/D33616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33616: [MS] Fix _bittest* intrinsics for values bigger than 31

majnemer added a comment. In https://reviews.llvm.org/D33616#768287, @hans wrote: > From looking in the Intel manual (Table 3-2, in 3.1.1.9 about > Bit(BitBase,BitOffset)) it does sound like the bit offset can be negative > *shudder*, so I suppose this is necessary and explains why the type is

[PATCH] D32842: Specify which sanitizers are covered by a sanitizer blacklist

vsk added a comment. In https://reviews.llvm.org/D32842#768038, @eugenis wrote: > This change scares me a bit, to be honest. Is this really that big of a > problem? Blacklists are not supposed to be big, maybe we can tolerate a few > false negatives? I'd like to make it possible to deploy a

[PATCH] D33304: [clang-tidy] Add a new module Android and a new check for file descriptors.

Eugene.Zelenko added inline comments. Comment at: clang-tidy/utils/ExprToStr.cpp:23 + SM.getCharacterData(TE) - SM.getCharacterData(B)); +} +} // namespace utils Please add empty line. Comment at:

Re: r304190 - Diagnose attempts to build a preprocessed module that defines an unavailable submodule.

Thank you! > (I did not receive any email about this from the buildbots. Is that expected?) No, looks wrong. I will keep an eye on this. Thanks Galina On Tue, May 30, 2017 at 1:14 PM, Richard Smith wrote: > On 30 May 2017 at 13:08, Galina Kistanova

[PATCH] D33616: [MS] Fix _bittest* intrinsics for values bigger than 31

rsmith added a comment. In https://reviews.llvm.org/D33616#768287, @hans wrote: > From looking in the Intel manual (Table 3-2, in 3.1.1.9 about > Bit(BitBase,BitOffset)) it does sound like the bit offset can be negative > *shudder*, so I suppose this is necessary and explains why the type is

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

loladiro created this revision. LLVM commit https://reviews.llvm.org/D33655 was reverted, because it exposed an assertion failure, in `GenerateVarArgsThunk`. That function attempts to clone a function before clang is entirely done generating the debug info for the current compliation unit. That

[PATCH] D33616: [MS] Fix _bittest* intrinsics for values bigger than 31

majnemer added inline comments. Comment at: clang/lib/Headers/intrin.h:345-347 + _BitBase += (_BitPos / 32); + _BitPos %= 32; return (*_BitBase >> _BitPos) & 1; `_bittest` seems to expand to `(((unsigned char const *)_BitBase)[_BitPos >> 3] >> (_BitPos &

r304261 - [ODRHash] Support TemplateSpecializationType

Author: rtrieu Date: Tue May 30 19:31:58 2017 New Revision: 304261 URL: http://llvm.org/viewvc/llvm-project?rev=304261=rev Log: [ODRHash] Support TemplateSpecializationType Modified: cfe/trunk/lib/AST/ODRHash.cpp cfe/trunk/test/Modules/odr_hash.cpp Modified:

Re: [PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

If SPs are now all finalized early - I'm assuming there's some other code that finalizes SPs that's no longer needed? Also - this seems like a layering/separation issue - does other code call into the DI as casually/explicitly as this code being added to CGVTables? (Or should the callback go

[PATCH] D33029: [clang-format] add option for dangling parenthesis

stringham added inline comments. Comment at: include/clang/Format/Format.h:793 + /// \endcode + bool DanglingParenthesis; + djasper wrote: > stringham wrote: > > djasper wrote: > > > I don't think this is a name that anyone will intuitively understand. I > >

Re: r303317 - The constant expression evaluator should examine function arguments for non-constexpr function calls unless the EvalInfo says to stop.

On Wed, May 17, 2017 at 11:56:55PM -, Nick Lewycky via cfe-commits wrote: > Author: nicholas > Date: Wed May 17 18:56:54 2017 > New Revision: 303317 > > URL: http://llvm.org/viewvc/llvm-project?rev=303317=rev > Log: > The constant expression evaluator should examine function arguments for >

[PATCH] D33703: Support lazy stat'ing of files referenced by module maps

rsmith created this revision. This patch adds support for a `header` declaration in a module map to specify certain `stat` information (currently, size and mtime) about that header file. This has two purposes: - It removes the need to eagerly `stat` every file referenced by a module map.

Re: [PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

For some reason your comments aren't showing up on Phabricator, so replying via email - hope everybody sees it. If SPs are now all finalized early - I'm assuming there's some other code > that finalizes SPs that's no longer needed? > Not all of them, just the one before cloning. I wanted to make

[PATCH] D33708: [test] [libcxx] Disable MSVC++'s compare(a, b) implies !compare(b, a) assertion in predicate application count tests

BillyONeal created this revision. Turn off MSVC++'s comp(a, b) implies !comp(b, a) assertion in tests that are checking for predicate counts. There should be no functionality change for libcxx as it does not look for the _ITERATOR_DEBUG_LEVEL macro. While this assert is technically out of

[PATCH] D33708: [test] [libcxx] Disable MSVC++'s compare(a, b) implies !compare(b, a) assertion in predicate application count tests

BillyONeal abandoned this revision. BillyONeal added a comment. Stephan pointed out that the force include breaks this. Backing it out for now :( https://reviews.llvm.org/D33708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33706: [AMDGPU] Fix address space for global and temporary variables in C++

yaxunl updated this revision to Diff 100819. yaxunl added a comment. Fix comments. https://reviews.llvm.org/D33706 Files: lib/Basic/Targets.cpp lib/CodeGen/CGCall.cpp lib/CodeGen/CGDecl.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.cpp

Re: [PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

I'll let Adrian weigh in - but I suspect, if possible, it'd be better to just finalize them all once IRGen for the function finishes. On Tue, May 30, 2017 at 6:02 PM Keno Fischer wrote: > For some reason your comments aren't showing up on Phabricator, so > replying via

[PATCH] D33706: [AMDGPU] Fix address space for global and temporary variables in C++

yaxunl created this revision. Herald added subscribers: t-tye, Anastasia, tpr, dstuttard, wdng, kzhuravl. AMDGPU backend requires global variables in global or constant address space and alloca in private address space. However, in C++ all variables are in default address space. Previously

Re: r303317 - The constant expression evaluator should examine function arguments for non-constexpr function calls unless the EvalInfo says to stop.

Joerg Sonnenberger wrote: On Wed, May 17, 2017 at 11:56:55PM -, Nick Lewycky via cfe-commits wrote: Author: nicholas Date: Wed May 17 18:56:54 2017 New Revision: 303317 URL: http://llvm.org/viewvc/llvm-project?rev=303317=rev Log: The constant expression evaluator should examine function

[PATCH] D33356: [Nios2] Changes in frontend to support Nios2 LLVM target

belickim added inline comments. Comment at: include/clang/Basic/TargetBuiltins.h:154 + /// \brief Nios2 builtins + namespace Nios2 { + enum { ahatanak wrote: > No need to indent enum inside namespace. > >

[PATCH] D33525: [ThinLTO] Migrate ThinLTOBitcodeWriter to the new PM.

chandlerc added inline comments. Comment at: llvm/test/Transforms/ThinLTOBitcodeWriter/new-pm.ll:1 +; RUN: opt -passes='lto' -debug-pass-manager -thinlto-bc -thin-link-bitcode-file=%t2 -o %t %s 2>&1 | FileCheck %s --check-prefix=DEBUG_PM +; RUN: llvm-bcanalyzer -dump %t2 |

[PATCH] D33356: [Nios2] Changes in frontend to support Nios2 LLVM target

ahatanak added a comment. A couple of coding style nits. FYI, LLVM coding standard is documented here: http://llvm.org/docs/CodingStandards.html Comment at: include/clang/Basic/TargetBuiltins.h:154 + /// \brief Nios2 builtins + namespace Nios2 { + enum {

[PATCH] D33356: [Nios2] Changes in frontend to support Nios2 LLVM target

belickim updated this revision to Diff 100674. belickim added a comment. Thanks Akira for your comments, I made all changes that you suggested. https://reviews.llvm.org/D33356 Files: include/clang/Basic/BuiltinsNios2.def include/clang/Basic/TargetBuiltins.h lib/Basic/Targets.cpp

[PATCH] D32437: [analyzer] Nullability: fix a crash when adding notes inside a synthesized property accessor.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:704 +const LocationContext *ParentLC = LC->getParent(); +while (ParentLC->getAnalysisDeclContext()->isBodyAutosynthesized()) { + LC = ParentLC; zaks.anna wrote: > Is

[PATCH] D33525: [ThinLTO] Migrate ThinLTOBitcodeWriter to the new PM.

timshen added inline comments. Comment at: llvm/test/Transforms/ThinLTOBitcodeWriter/new-pm.ll:1 +; RUN: opt -passes='lto' -debug-pass-manager -thinlto-bc -thin-link-bitcode-file=%t2 -o %t %s 2>&1 | FileCheck %s --check-prefix=DEBUG_PM +; RUN: llvm-bcanalyzer -dump %t2 |

[PATCH] D33356: [Nios2] Changes in frontend to support Nios2 LLVM target

belickim updated this revision to Diff 100668. belickim added a comment. I added test for driver to check if target and CPU flags are recognized, as Craig suggested. https://reviews.llvm.org/D33356 Files: include/clang/Basic/BuiltinsNios2.def include/clang/Basic/TargetBuiltins.h

[PATCH] D33623: Make the parser close parens for you on EOF

alexfh added a comment. Sam knows this stuff much better. https://reviews.llvm.org/D33623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32480: clang-format: Add CompactNamespaces option

Typz added a comment. ping? https://reviews.llvm.org/D32480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33398: Mangle __unaligned in Itanium ABI

rogfer01 updated this revision to Diff 100670. rogfer01 added a comment. Thanks @aaron.ballman for the review. I have extended the test with your suggestions. https://reviews.llvm.org/D33398 Files: lib/AST/ItaniumMangle.cpp test/CodeGenCXX/pr33080.cpp

[PATCH] D32437: [analyzer] Nullability: fix a crash when adding notes inside a synthesized property accessor.

NoQ updated this revision to Diff 100673. NoQ marked 3 inline comments as done. NoQ added a comment. Fix comments. https://reviews.llvm.org/D32437 Files: include/clang/StaticAnalyzer/Core/BugReporter/PathDiagnostic.h lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp

r304205 - [PPC] Make altivec conversion function macros.

Author: d0k Date: Tue May 30 06:37:29 2017 New Revision: 304205 URL: http://llvm.org/viewvc/llvm-project?rev=304205=rev Log: [PPC] Make altivec conversion function macros. The second argument must be a constant, otherwise instruction selection will fail. always_inline is not enough for isel to

[PATCH] D15994: Allow for unfinished #if blocks in preambles.

This revision was automatically updated to reflect the committed changes. erikjv marked 3 inline comments as done. Closed by commit rL304207: Allow for unfinished #if blocks in preambles (authored by erikjv). Changed prior to commit: https://reviews.llvm.org/D15994?vs=98757=100691#toc

r304201 - [ARM] Fix Neon vector type alignment to 64-bit

Author: javed.absar Date: Tue May 30 05:12:15 2017 New Revision: 304201 URL: http://llvm.org/viewvc/llvm-project?rev=304201=rev Log: [ARM] Fix Neon vector type alignment to 64-bit The maximum alignment for ARM NEON data types should be 64-bits as specified in ARM procedure call standard document

Re: r304201 - [ARM] Fix Neon vector type alignment to 64-bit

Hi Javed, I think this broke the bots: http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/7620 Can you have a look, or revert? Thanks, Diana On 30 May 2017 at 12:12, Javed Absar via cfe-commits wrote: > Author: javed.absar > Date: Tue May 30 05:12:15

[PATCH] D33531: Clang-tidy readability: avoid const value return

alexfh added a comment. In https://reviews.llvm.org/D33531#767628, @aaron.ballman wrote: > In https://reviews.llvm.org/D33531#767059, @alexfh wrote: > > > > Would it make sense to silence this diagnostic in the presence of also > > > checking for cert-dcl21-cpp for such operators? > > > >

r304207 - Allow for unfinished #if blocks in preambles

Author: erikjv Date: Tue May 30 06:54:55 2017 New Revision: 304207 URL: http://llvm.org/viewvc/llvm-project?rev=304207=rev Log: Allow for unfinished #if blocks in preambles Previously, a preamble only included #if blocks (and friends like ifdef) if there was a corresponding #endif before any

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

Typz marked an inline comment as done. Typz added inline comments. Comment at: unittests/Format/FormatTest.cpp:8571 +"*/", +format("int a; /* first line second line third line */", Style)); +} Typz wrote: > This is not working as

[PATCH] D32480: clang-format: Add CompactNamespaces option

klimek added a comment. I'm less concerned about everything suddenly re-indenting when you change code - if you use any kind of namespace indentation, that's what will happen now and then (and is why many style guides do not indent in namespaces). For what it's worth, I'd 1. vote for only

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

Typz updated this revision to Diff 100698. Typz marked an inline comment as done. Typz added a comment. fix code & tests https://reviews.llvm.org/D33589 Files: lib/Format/ContinuationIndenter.cpp lib/Format/ContinuationIndenter.h lib/Format/FormatToken.cpp lib/Format/FormatToken.h

[PATCH] D33412: Add support for #pragma clang section

rogfer01 added a comment. This clang change looks sensible to me. Can you add documentation in `LanguageExtensions.rst` describing this new pragma and its semantics? Thanks! https://reviews.llvm.org/D33412 ___ cfe-commits mailing list

[PATCH] D33531: Clang-tidy readability: avoid const value return

aaron.ballman added a comment. In https://reviews.llvm.org/D33531#767059, @alexfh wrote: > > Would it make sense to silence this diagnostic in the presence of also > > checking for cert-dcl21-cpp for such operators? > > Currently there's no mechanism in clang-tidy to express dependencies or >

r304191 - [OpenCL] An error shall occur if any scalar operand has greater rank than the type of the vector element

Author: echuraev Date: Tue May 30 00:32:03 2017 New Revision: 304191 URL: http://llvm.org/viewvc/llvm-project?rev=304191=rev Log: [OpenCL] An error shall occur if any scalar operand has greater rank than the type of the vector element Summary: This is the fix for patch

r304193 - [OpenCL] Added diagnostic for implicit declaration of function in OpenCL

Author: echuraev Date: Tue May 30 00:57:52 2017 New Revision: 304193 URL: http://llvm.org/viewvc/llvm-project?rev=304193=rev Log: [OpenCL] Added diagnostic for implicit declaration of function in OpenCL Reviewers: Anastasia, cfe-commits Reviewed By: Anastasia Subscribers: bader, yaxunl

[PATCH] D33405: Mark all ARCMT test files as binary files in git, just like with svn

erikjv added a comment. Ping? https://reviews.llvm.org/D33405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33671: [analyzer] In plist alternate mode, don't add weird control flow pieces from ObjC property declarations to uses.

NoQ created this revision. Herald added a subscriber: xazax.hun. These result in really weird arrows that have little to do with control flow. Other path diagnostic modes behave differently and seem to be unaffected. Patching on top of https://reviews.llvm.org/D32437, where this gets

[PATCH] D33497: [clang-tidy] check for __func__/__FUNCTION__ in lambdas

alexfh added inline comments. Comment at: clang-tidy/misc/LambdaFunctionNameCheck.cpp:61-62 +void LambdaFunctionNameCheck::registerPPCallbacks(CompilerInstance ) { + Compiler.getPreprocessor().addPPCallbacks(std::unique_ptr( + new MacroExpansionsWithFileAndLine())); +}

[PATCH] D33531: Clang-tidy readability: avoid const value return

aaron.ballman added a comment. In https://reviews.llvm.org/D33531#767640, @alexfh wrote: > In https://reviews.llvm.org/D33531#767628, @aaron.ballman wrote: > > > In https://reviews.llvm.org/D33531#767059, @alexfh wrote: > > > > > > Would it make sense to silence this diagnostic in the presence

r304210 - Fix issue with test that caused bildbot failure

Author: javed.absar Date: Tue May 30 08:34:26 2017 New Revision: 304210 URL: http://llvm.org/viewvc/llvm-project?rev=304210=rev Log: Fix issue with test that caused bildbot failure These tests did not specify the target. The failure was triggered by change - https://reviews.llvm.org/D33205

[PATCH] D33042: [libclang] Allow to suspend a translation unit.

erikjv closed this revision. erikjv added a comment. Committed as r304212. https://reviews.llvm.org/D33042 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33678: [clangd] Mark results of clangd requests with a tag provided by the FileSystemProvider.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D33678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33398: Mangle __unaligned in Itanium ABI

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Can you run clang-format over both the test files? Aside from that, looks good to me, but you should wait for @rsmith or @majnemer to sign off before committing.

[clang-tools-extra] r304214 - [clangd] Mark results of clangd requests with a tag provided by the FileSystemProvider.

Author: ibiryukov Date: Tue May 30 10:11:02 2017 New Revision: 304214 URL: http://llvm.org/viewvc/llvm-project?rev=304214=rev Log: [clangd] Mark results of clangd requests with a tag provided by the FileSystemProvider. Summary: This allows an implementation of FileSystemProvider that can track

[PATCH] D33678: [clangd] Mark results of clangd requests with a tag provided by the FileSystemProvider.

This revision was automatically updated to reflect the committed changes. Closed by commit rL304214: [clangd] Mark results of clangd requests with a tag provided by the… (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D33678?vs=100709=100711#toc Repository: rL

[PATCH] D33623: Make the parser close parens for you on EOF

fowles abandoned this revision. fowles added a comment. Switching to https://reviews.llvm.org/D33679 for sbenza's suggestion https://reviews.llvm.org/D33623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33531: Clang-tidy readability: avoid const value return

sbenza added inline comments. Comment at: clang-tidy/readability/ConstValueReturnCheck.cpp:31 + isAnyPointer(), + references(type()), + templateTypeParmType(), References are never const qualified, right? Comment at:

[PATCH] D33678: [clangd] Mark results of clangd requests with a tag provided by the FileSystemProvider.

ilya-biryukov created this revision. This allows an implementation of FileSystemProvider that can track which vfs::FileSystem were used for each of the requests. https://reviews.llvm.org/D33678 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.h

[PATCH] D33623: Make the parser close parens for you on EOF

sbenza added a comment. Do we want this change in the parser itself? or in clang-query? clang-query could be helpful enough to add parens when it detect an `ET_ParserNoCloseParen` error, without changing the language here. https://reviews.llvm.org/D33623

[PATCH] D33644: Add default values for function parameter chunks

yvvan updated this revision to Diff 100705. yvvan edited the summary of this revision. yvvan added a comment. Support for non-simple types. Drop results with macros. https://reviews.llvm.org/D33644 Files: lib/Sema/SemaCodeComplete.cpp Index: lib/Sema/SemaCodeComplete.cpp

[PATCH] D33679: Make clang-query close parens for you

fowles created this revision. Make clang-query close parens for you https://reviews.llvm.org/D33679 Files: clang-query/QueryParser.cpp Index: clang-query/QueryParser.cpp === --- clang-query/QueryParser.cpp +++

[PATCH] D33679: Make clang-query close parens for you

fowles updated this revision to Diff 100716. fowles added a comment. Add tests for real https://reviews.llvm.org/D33679 Files: clang-query/QueryParser.cpp test/clang-query/missing-parens.c Index: test/clang-query/missing-parens.c

[PATCH] D33679: Make clang-query close parens for you

fowles updated this revision to Diff 100715. fowles added a comment. Add a test https://reviews.llvm.org/D33679 Files: clang-query/QueryParser.cpp Index: clang-query/QueryParser.cpp === --- clang-query/QueryParser.cpp +++

r304211 - Fixup r304205 - Require PowerPC target

Author: rovka Date: Tue May 30 09:05:33 2017 New Revision: 304211 URL: http://llvm.org/viewvc/llvm-project?rev=304211=rev Log: Fixup r304205 - Require PowerPC target Modified: cfe/trunk/test/CodeGen/altivec-ct.c Modified: cfe/trunk/test/CodeGen/altivec-ct.c URL:

r304212 - [libclang] Allow to suspend a translation unit.

Author: erikjv Date: Tue May 30 09:25:54 2017 New Revision: 304212 URL: http://llvm.org/viewvc/llvm-project?rev=304212=rev Log: [libclang] Allow to suspend a translation unit. A suspended translation unit uses significantly less memory but on the other side does not support any other calls than

[PATCH] D33676: Place implictly declared functions at block scope

chill added a subscriber: cfe-commits. chill added a comment. This issue https://bugs.llvm.org//show_bug.cgi?id=2266 does not appear to trigger anymore, with this patch applied. https://reviews.llvm.org/D33676 ___ cfe-commits mailing list

[PATCH] D33676: Place implictly declared functions at block scope

rogfer01 added a comment. I wonder what should we do in C99 for cases like void foo(void) { { extern void g(int(*a)[call_to_undeclared()]); int (*p_ok)() = call_to_undeclared; } int (*p_err)() = call_to_undeclared; } I understand that the scope `S` in this case

[PATCH] D33616: [MS] Fix _bittest* intrinsics for values bigger than 31

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D33616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33676: Place implictly declared functions at block scope

chill added a comment. In https://reviews.llvm.org/D33676#767746, @rogfer01 wrote: > I understand that the scope `S` in this case is a (function) prototype scope > so it would not be the innermost block scope, would it? That said, GCC does > not accept `p_ok` above so probably this behaviour

Re: r304201 - [ARM] Fix Neon vector type alignment to 64-bit

Hi, I think this change is responsible for a tablgen failure in stage2 builds: http://green.lab.llvm.org/green/job/clang-stage2-configure-Rthinlto_build/2171/ > On May 30, 2017, at 4:59 AM, Diana Picus via

Re: r304201 - [ARM] Fix Neon vector type alignment to 64-bit

On Tue, May 30, 2017 at 3:12 AM, Javed Absar via cfe-commits wrote: > Author: javed.absar > Date: Tue May 30 05:12:15 2017 > New Revision: 304201 > > URL: http://llvm.org/viewvc/llvm-project?rev=304201=rev > Log: > [ARM] Fix Neon vector type alignment to 64-bit > > The

Re: r304201 - [ARM] Fix Neon vector type alignment to 64-bit

Sorry, I didn't see the email from Ahmed. I think best option is to revert right now and submit for review a restricted version later as suggested. Will do revert. Thanks Javed From: Javed Absar Sent: 30 May 2017 17:43:35 To: Vedant Kumar Cc: cfe-commits;

r304216 - [OPENMP] Allow 'use_device_ptr' clause in 'target data' alone.

Author: abataev Date: Tue May 30 11:00:04 2017 New Revision: 304216 URL: http://llvm.org/viewvc/llvm-project?rev=304216=rev Log: [OPENMP] Allow 'use_device_ptr' clause in 'target data' alone. According to OpenMP 5.0 at least one 'map' or 'use_device_ptr' clause must be specified for 'target

Re: r304201 - [ARM] Fix Neon vector type alignment to 64-bit

Hi. I fixed the tests - union-align.c and bool_casts.cl Did you mean this error now: FAILED: lib/Target/ARM/ARMGenGlobalISel.inc.tmp " because that doesn't seem related to alignment fix. Thanks Javed From: v...@apple.com on behalf of

[PATCH] D33563: Track whether a unary operation can overflow

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:9 +VK_LValue, OK_Ordinary, Loc, true); // Construct the loop that copies all elements of this array. ahatanak

[PATCH] D33563: Track whether a unary operation can overflow

aaron.ballman updated this revision to Diff 100703. aaron.ballman added a comment. Addressing review comments. https://reviews.llvm.org/D33563 Files: include/clang/AST/Expr.h lib/AST/ASTDumper.cpp lib/AST/ASTImporter.cpp lib/AST/ExprConstant.cpp lib/CodeGen/CGExprScalar.cpp

[PATCH] D33676: Place implictly declared functions at block scope

rogfer01 added a comment. I think what happens is that the implicit declaration is done in the prototype scope which is not visible later. Doing the same as GCC in the handling of this extension is probably the best: note that in C90 a function call should not happen inside an array expression

[PATCH] D33499: [PPC] PPC32/Darwin ABI info

kparzysz updated this revision to Diff 100720. kparzysz retitled this revision from "[PPC] First approximation of PPC32/Darwin ABI info" to "[PPC] PPC32/Darwin ABI info". kparzysz edited the summary of this revision. kparzysz added a comment. This patch corrects the ABI alignment issues for

r304220 - Reverting Neon vector type 64-alignment fix

Author: javed.absar Date: Tue May 30 12:09:47 2017 New Revision: 304220 URL: http://llvm.org/viewvc/llvm-project?rev=304220=rev Log: Reverting Neon vector type 64-alignment fix The patch caused ABI breaks on darwin/others. Reverting to come back with a more restrictive patch. Modified:

r304229 - [OpenMP][Driver] Put target binary for each offload target into a

Author: abataev Date: Tue May 30 13:57:51 2017 New Revision: 304229 URL: http://llvm.org/viewvc/llvm-project?rev=304229=rev Log: [OpenMP][Driver] Put target binary for each offload target into a separate section, by Sergey Dmitriev Linker script that is generated by the clang driver for creating

Re: r304207 - Allow for unfinished #if blocks in preambles

On 30 May 2017 at 04:54, Erik Verbruggen via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: erikjv > Date: Tue May 30 06:54:55 2017 > New Revision: 304207 > > URL: http://llvm.org/viewvc/llvm-project?rev=304207=rev > Log: > Allow for unfinished #if blocks in preambles > > Previously,

[PATCH] D25001: [Module] Merge function prototype with a non-prototype function declaration

ahatanak added a comment. ping https://reviews.llvm.org/D25001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r304190 - Diagnose attempts to build a preprocessed module that defines an unavailable submodule.

On 30 May 2017 at 13:08, Galina Kistanova wrote: > Hello Richard, > > This commit broke a test on few of our builders: > > Failing Tests (1): > Clang :: Modules/preprocess-unavailable.cpp > > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_ >

[PATCH] D33692: [ThinLTO] Migrate ThinLTOBitcodeWriter to the new PM.

timshen created this revision. Herald added subscribers: inglorion, Prazek, mehdi_amini. Also see https://reviews.llvm.org/D33429 for other ThinLTO + New PM related changes. https://reviews.llvm.org/D33692 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/thin_link_bitcode.c

[PATCH] D33304: [clang-tidy] Add a new module Android and a new check for file descriptors.

yawanng added a comment. Hi, I have updated this CL for review. Thank you very much :) https://reviews.llvm.org/D33304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >